Home | History | Annotate | Download | only in doc

Lines Matching full:code

11 have <a href="code.html">written and tested your code</a>.
15 (Note that the <code>gccgo</code> frontend lives elsewhere;
39 It also checks that the design is sound before code is written;
40 the code review tool is not the place for high-level discussions.
54 You've <a href="code.html">written and tested your code</a>, but
55 before sending code out for review, run all the tests for the whole
65 (To build under Windows use <code>all.bat</code>.)
70 "<code>ALL</code> <code>TESTS</code> <code>PASSED</code>".
73 <h2 id="Code_review">Code review</h2>
78 A custom git command called <code>git-codereview</code>,
79 discussed below, helps manage the code review process through a Google-hosted
80 <a href="https://go-review.googlesource.com/">instance</a> of the code review
81 system called <a href="https://code.google.com/p/gerrit/">Gerrit</a>.
84 <h3>Set up authentication for code review</h3>
119 Your secret authentication token is now in a <code>.gitcookie</code> file
151 (If the copyright holder for your code has already completed the
173 Now install the <code>git-codereview</code> command by running,
181 Make sure <code>git-codereview</code> is installed in your shell path, so that the
182 <code>git</code> command can find it. Check that
194 Note to Git aficionados: The <code>git-codereview</code> command is not required to
195 upload and manage Gerrit code reviews. For those who prefer plain Git, the text
198 configures; those hooks add a Gerrit <code>Change-Id</code> line to the commit
201 checkout by running <code>git-codereview</code> <code>hooks</code>.
207 The <code>git-codereview</code> command can be run directly from the shell
216 but it is more convenient to set up aliases for <code>git-codereview</code>'s own
225 The <code>git-codereview</code> subcommands have been chosen to be distinct from
233 (usually <code>.gitconfig</code> in your home directory):
248 <p>After installing the <code>git-codereview</code> command, you can run</p>
275 (In Git terms, <code>git</code> <code>sync</code> runs
276 <code>git</code> <code>pull</code> <code>-r</code>.)
286 <code>git</code> <code>add</code>,
287 <code>git</code> <code>rm</code>,
289 <code>git</code> <code>mv</code>.
293 If you wish to checkpoint your work, or are ready to send the code out for review, run</p>
306 (In Git terms, <code>git</code> <code>change</code> <code>&lt;branch&gt;</code>
307 runs <code>git</code> <code>checkout</code> <code>-b</code> <code>branch</code>,
308 then <code>git</code> <code>branch</code> <code>--set-upstream-to</code> <code>origin/master</code>,
309 then <code>git</code> <code>commit</code>.)
314 (It uses the editor named by the <code>$EDITOR</code> environment variable,
315 <code>vi</code> by default.)
334 and is used as the subject for code review mail.
387 <code>git</code> <code>add</code>, and then run
396 change description contains a <code>Change-Id</code> line near the bottom,
398 <code>git</code> <code>change</code>.
404 (In Git terms, <code>git</code> <code>change</code> with no branch name
405 runs <code>git</code> <code>commit</code> <code>--amend</code>.)
420 using the <code>-r</code> or <code>-cc</code> options.
438 (In Git terms, <code>git</code> <code>mail</code> pushes the local committed
439 changes to Gerrit using <code>git</code> <code>push</code> <code>origin</code>
440 <code>HEAD:refs/for/master</code>.)
449 The code review server assigns your change an issue number and URL,
450 which <code>git</code> <code>mail</code> will print, something like:
458 <h3>Reviewing code</h3>
461 Running <code>git</code> <code>mail</code> will send an email to you and the
478 When you have revised the code and are ready for another round of review,
479 stage those changes and use <code>git</code> <code>change</code> to update the
482 run <code>git</code> <code>mail</code> again.
488 (+1 or +2) and replying <code>LGTM</code>: looks good to me.
492 You can see a list of your pending changes by running <code>git</code>
493 <code>pending</code>, and switch between change branches with <code>git</code>
494 <code>change</code> <code><i>&lt;branch&gt;</i></code>.
509 (In git terms, <code>git</code> <code>sync</code> runs
510 <code>git</code> <code>pull</code> <code>-r</code>.)
520 For example, suppose you have edited <code>sin.go</code> but
522 When you run <code>git</code> <code>sync</code>,
568 with conflicts marked by <code>&lt;&lt;&lt;&lt;&lt;&lt;&lt;</code> and
569 <code>&gt;&gt;&gt;&gt;&gt;&gt;&gt;</code>.
571 Continuing the example, searching for those strings in <code>sin.go</code>
589 to remove the markers and leave the correct code:
609 <code>git</code> <code>reset</code> <code>HEAD</code> <code>sin.go</code>
611 Then run <code>git</code> <code>rebase</code> <code>--continue</code> to
615 <h3>Reviewing code by others</h3>
635 After the code has been <code>LGTM</code>'ed, an approver may
643 The change description will include a link to the code review,
644 and the code review will be updated with a link to the change
664 and in the <a href="/CONTRIBUTORS"><code>CONTRIBUTORS</code></a> file
665 and perhaps the <a href="/AUTHORS"><code>AUTHORS</code></a> file.
668 <p>The <a href="/CONTRIBUTORS"><code>CONTRIBUTORS</code></a> file
670 the <a href="/AUTHORS"><code>AUTHORS</code></a> file defines
674 <p>Code that you contribute should use the standard copyright header:</p>
678 // Use of this source code is governed by a BSD-style