Home | History | Annotate | Download | only in patch
      1 # we don't support trace_event on libchrome
      2 
      3 --- a/base/values.cc
      4 +++ b/base/values.cc
      5 @@ -18,7 +18,8 @@
      6  #include "base/stl_util.h"
      7  #include "base/strings/string_util.h"
      8  #include "base/strings/utf_string_conversions.h"
      9 -#include "base/trace_event/memory_usage_estimator.h"
     10 +// Unsupported in libchrome
     11 +// #include "base/trace_event/memory_usage_estimator.h"
     12  
     13  namespace base {
     14  
     15 @@ -632,20 +633,21 @@ bool Value::Equals(const Value* other) const {
     16    return *this == *other;
     17  }
     18  
     19 -size_t Value::EstimateMemoryUsage() const {
     20 -  switch (type_) {
     21 -    case Type::STRING:
     22 -      return base::trace_event::EstimateMemoryUsage(string_value_);
     23 -    case Type::BINARY:
     24 -      return base::trace_event::EstimateMemoryUsage(binary_value_);
     25 -    case Type::DICTIONARY:
     26 -      return base::trace_event::EstimateMemoryUsage(dict_);
     27 -    case Type::LIST:
     28 -      return base::trace_event::EstimateMemoryUsage(list_);
     29 -    default:
     30 -      return 0;
     31 -  }
     32 -}
     33 +// Unsupported in libchrome
     34 +// size_t Value::EstimateMemoryUsage() const {
     35 +//   switch (type_) {
     36 +//     case Type::STRING:
     37 +//       return base::trace_event::EstimateMemoryUsage(string_value_);
     38 +//     case Type::BINARY:
     39 +//       return base::trace_event::EstimateMemoryUsage(binary_value_);
     40 +//     case Type::DICTIONARY:
     41 +//       return base::trace_event::EstimateMemoryUsage(dict_);
     42 +//     case Type::LIST:
     43 +//       return base::trace_event::EstimateMemoryUsage(list_);
     44 +//     default:
     45 +//       return 0;
     46 +//   }
     47 +// }
     48  
     49  void Value::InternalMoveConstructFrom(Value&& that) {
     50    type_ = that.type_;
     51 
     52 --- a/base/values.h
     53 +++ b/base/values.h
     54 @@ -352,7 +352,7 @@ class BASE_EXPORT Value {
     55  
     56    // Estimates dynamic memory usage.
     57    // See base/trace_event/memory_usage_estimator.h for more info.
     58 -  size_t EstimateMemoryUsage() const;
     59 +  // size_t EstimateMemoryUsage() const;
     60  
     61   protected:
     62    // TODO(crbug.com/646113): Make these private once DictionaryValue and
     63 
     64