1 2010-02-10 Jesus Sanchez-Palencia <jesus.palencia (a] openbossa.org> 2 3 Reviewed by Kenneth Rohde Christiansen. 4 5 Support frameset flattening 6 https://bugs.webkit.org/show_bug.cgi?id=32717 7 8 Add support for enabling/disabling FrameSet Flattening on the Windows port. 9 10 * Interfaces/IWebPreferencesPrivate.idl: 11 * WebPreferenceKeysPrivate.h: 12 * WebPreferences.cpp: 13 (WebPreferences::initializeDefaultSettings): 14 (WebPreferences::isFrameSetFlatteningEnabled): 15 (WebPreferences::setFrameSetFlatteningEnabled): 16 * WebPreferences.h: 17 * WebView.cpp: 18 (WebView::notifyPreferencesChanged): 19 20 2010-02-10 Adam Roben <aroben (a] apple.com> 21 22 Remove unnecessary #include of shfolder.h 23 24 shfolder.h has been deprecated in newer versions of the Windows SDK. 25 26 Fixes <http://webkit.org/b/34803> WebPreferences.cpp fails to compile 27 under VS2010 RC due to #include of shfolder.h. 28 29 Reviewed by Darin Adler. 30 31 * WebPreferences.cpp: Removed #include. 32 33 2010-02-08 Charlie Reis <creis (a] chromium.org> 34 35 Reviewed by Darin Adler. 36 37 onbeforeunload not called at window close + frame or iframe focused 38 https://bugs.webkit.org/show_bug.cgi?id=27481 39 40 Chromium and WebKit on Windows will now fire beforeunload handlers 41 even if an inner frame is focused. 42 43 Layout tests aren't able to test this bug, since it requires closing 44 the actual browser window, not calling window.close(). Instead, 45 test with WebCore/manual-tests/onbeforeunload-focused-iframe.html. 46 47 * WebView.cpp: 48 (WebView::shouldClose): 49 50 2010-02-08 Brent Fulgham <bfulgham (a] webkit.org> 51 52 Reviewed by Adam Roben. 53 54 Include header position in World Transform used for plugin positioning. 55 https://bugs.webkit.org/show_bug.cgi?id=34709 56 57 * WebFrame.cpp: 58 (WebFrame::spoolPage): Correct WinCairo plugin print positioning to 59 account for header size. Existing code ignored this, causing 60 plugins to overlay other elements. 61 62 2010-02-04 Alice Liu <alice.liu (a] apple.com> 63 64 Reviewed by Jon Honeycutt. 65 66 https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error 67 codes for most elements that arent listbox or menupopup related" 68 <rdar://problem/7436861> 69 70 * AccessibleBase.cpp: 71 (AccessibleBase::accSelect): 72 - Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that 73 aren't beneath listboxes or menupopups. This was too restrictive since 74 any element can be selectable. 75 - Correct the misinterpretation of MSDN's stipulation of situations involving 76 adding, removing, and extending selection on single-select elements 77 78 2010-02-04 Brent Fulgham <bfulgham (a] webkit.org> 79 80 Reviewed by Adam Roben. 81 82 Properly handle margin settings when printing Plugins in WinCairo. 83 https://bugs.webkit.org/show_bug.cgi?id=34613 84 85 * WebFrame.cpp: 86 (WebFrame::spoolPage): Adjust the GraphicsContext passed to the 87 paintContents method so that the World Transform is properly 88 positioned to account for margin settings at the time that 89 PluginViewWin.cpp processes the drawing operations. 90 91 2010-02-04 Brent Fulgham <bfulgham (a] webkit.org> 92 93 Reviewed by Adam Roben. 94 95 Properly handle margin settings in WinCairo. 96 https://bugs.webkit.org/show_bug.cgi?id=34545 97 98 * WebFrame.cpp: 99 (scaleFactor): Require the margin information as an input 100 parameter, and use them when computing the scaling factor. 101 (WebFrame::drawHeader): Pass margin size to scaleFactor. 102 (WebFrame::drawFooter): Pass margin size to scaleFactor. 103 (WebFrame::spoolPage): 104 1. Pass margin size to scaleFactor. 105 2. Recognize that the return value of printerMarginRect is 106 already in device units, and therefore scale it so that 107 the Cairo drawing is correct. 108 3. Remove scaling call for margins in GDI code, as it is 109 already in scaled units. 110 111 2010-02-03 Brian Weinstein <bweinstein (a] apple.com> 112 113 Reviewed by Steve Falkenburg. 114 115 Scroll does not work with IBM Thinkpad. 116 <https://bugs.webkit.org/show_bug.cgi?id=14227> 117 <rdar://7142545> 118 119 When initializing the WebView, add two scrollbar Windows inside of 120 our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events. 121 (similar to what Firefox did in: <https://bugzilla.mozilla.org/show_bug.cgi?id=507222>. 122 123 Only do this if the user has installed some kind of Trackpoint driver, using an algorithm 124 like <https://bugzilla.mozilla.org/show_bug.cgi?id=514927>. 125 126 Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll 127 the WebView. 128 129 * WebView.cpp: 130 (WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down 131 by lines or pages. 132 (WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right 133 by lines or pages. 134 (WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL. 135 (WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create 136 vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages. 137 (WebView::shouldInitializeTrackPointHack): Check if there is a registry key for 138 the some kind of IBM Trackpoint driver. 139 * WebView.h: 140 141 2010-02-02 Steve Falkenburg <sfalken (a] apple.com> 142 143 Reviewed by Darin Adler. 144 145 Copyright year updating for Windows version resources should be automatic 146 https://bugs.webkit.org/show_bug.cgi?id=34503 147 148 * WebKit.vcproj/WebKit.rc: 149 150 2010-02-02 Adam Roben <aroben (a] apple.com> 151 152 Stop copying WebCore's IDL files from SRCROOT to OBJROOT 153 154 WebKit doesn't use these anymore (as of r52921). 155 156 Part of Bug 34496: Clean up WebCore's IDL/script copying 157 <https://bugs.webkit.org/show_bug.cgi?id=34496> 158 159 Reviewed by Steve Falkenburg. 160 161 * WebKit.vcproj/WebKit.make: 162 163 2010-01-29 Gavin Barraclough <barraclough (a] apple.com> 164 165 Reviewed by Sam Weinig + Oliver Hunt. 166 167 Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds 168 169 Pass processeing user gensture flag to media play/pause methods. 170 171 * FullscreenVideoController.cpp: 172 (FullscreenVideoController::play): 173 (FullscreenVideoController::pause): 174 175 2010-01-29 Brian Weinstein <bweinstein (a] apple.com> 176 177 Reviewed by Adam Roben. 178 179 Drag and Drop: Windows uses "stop" sign as cursor when dragging 180 https://bugs.webkit.org/show_bug.cgi?id=34305 181 <rdar://problem/7589672> 182 183 Add a preference in WebKit (that defaults to false), for whether or not 184 we should show the custom cursors during drag and drop. However, this is 185 currently only used on Windows, and only used to hide the "drop not allowed" 186 icon inside the WebView is the preference is set to true. 187 188 This will be off by default, so no change in behavior. 189 190 * Interfaces/IWebPreferencesPrivate.idl: Added new functions. 191 * Interfaces/WebKit.idl: Touched to force Interfaces build. 192 * WebDropSource.cpp: 193 (WebDropSource::GiveFeedback): Implementation of conditional showing cursor 194 logic. 195 * WebPreferenceKeysPrivate.h: Added new preference key. 196 * WebPreferences.cpp: Added new functions. 197 (WebPreferences::setCustomDragCursorsEnabled): 198 (WebPreferences::customDragCursorsEnabled): 199 * WebPreferences.h: Added new functions. 200 201 2010-01-28 Jon Honeycutt <jhoneycutt (a] apple.com> 202 203 MSAA: Crash when posting a notification for a detached object 204 205 https://bugs.webkit.org/show_bug.cgi?id=34309 206 <rdar://problem/7409759> 207 208 Reviewed by Darin Adler. 209 210 * AccessibleBase.cpp: 211 (AccessibleBase::QueryService): 212 If an unrecognized service ID is passed, return early. Otherwise, return 213 the result of QueryInterface. 214 (AccessibleBase::QueryInterface): 215 Add static_casts. Check for new UUIDs. 216 (AccessibleBase::isSameObject): 217 Query the object for AccessibleBase. Return whether the pointers or the 218 wrapped objects match. 219 220 * AccessibleBase.h: 221 Give the class a UUID so we can query for it in isSameObject(). Inherit 222 from IAccessibleComparable; inherit from IServiceProvider so clients can 223 use QueryService to query for a custom interface. 224 225 * Interfaces/AccessibleComparable.idl: Added. Declares a function that 226 can be called to compare to accessible objects. 227 228 * Interfaces/WebKit.idl: 229 Include the new IDL. 230 231 * WebKit.vcproj/Interfaces.vcproj: 232 Add the new IDL to the project. 233 234 2010-01-27 Aaron Boodman <aa (a] chromium.org> 235 236 Expand NotificationCenter::checkPermission() interface. 237 It now passes the full URL instead of just the origin. 238 239 https://bugs.webkit.org/show_bug.cgi?id=34238 240 241 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: 242 (WebDesktopNotificationsDelegate::checkPermission): 243 * WebCoreSupport/WebDesktopNotificationsDelegate.h: 244 245 2010-01-27 Adam Roben <aroben (a] apple.com> 246 247 Make it possible to instantiate WebSerializedJSValue using 248 WebKitCreateInstance 249 250 Reviewed by Dave Hyatt. 251 252 * ForEachCoClass.h: 253 * WebKitClassFactory.cpp: 254 Added WebSerializedJSValue. 255 256 2010-01-26 Steve Falkenburg <sfalken (a] apple.com> 257 258 Reviewed by Oliver Hunt. 259 260 Windows build references non-existent include paths 261 https://bugs.webkit.org/show_bug.cgi?id=34175 262 263 * WebKit.vcproj/WebKit.vcproj: 264 265 2010-01-25 Steve Falkenburg <sfalken (a] apple.com> 266 267 Reviewed by Simon Fraser. 268 269 A WebGeolocationControllerClient is leaked for every WebView 270 https://bugs.webkit.org/show_bug.cgi?id=34145 271 272 * WebCoreSupport/WebGeolocationControllerClient.cpp: 273 (WebGeolocationControllerClient::geolocationDestroyed): Added. 274 * WebCoreSupport/WebGeolocationControllerClient.h: 275 276 2010-01-23 Dan Bernstein <mitz (a] apple.com> 277 278 Reviewed by Maciej Stachowiak. 279 280 <rdar://problem/7569820> svg/custom/text-zoom.xhtml fails on Windows 281 https://bugs.webkit.org/show_bug.cgi?id=34006 282 283 * WebPreferences.cpp: 284 (WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey 285 with a default value of true. 286 287 2010-01-20 Steve Falkenburg <sfalken (a] apple.com> 288 289 Reviewed by Sam Weinig. 290 291 Add missing implementation for WebGeolocationPosition::initWithTimestamp. 292 293 * WebGeolocationPosition.cpp: 294 (WebGeolocationPosition::initWithTimestamp): Implemented. 295 296 2010-01-20 Jon Honeycutt <jhoneycutt (a] apple.com> 297 298 MSAA: accSelect() is not implemented 299 300 https://bugs.webkit.org/show_bug.cgi?id=33918 301 <rdar://problem/7436861> 302 303 Reviewed by Darin Adler. 304 305 * AccessibleBase.cpp: 306 (AccessibleBase::accSelect): 307 If there is an invalid combination of state flags, return early. If the 308 caller passed the "take focus" flag, focus the object. If the "take 309 selection" flag was passed, check whether the parent object is an 310 AccessibilityListBox; if so, call the object's setSelectedChildren() 311 function. If the parent is an AccessibilityMenuListPopup, call the 312 child object's setSelected() function. Otherwise, if the parent is some 313 other, unsupported object, return early. 314 If the selection flags include "add", "remove", or "extend" selection, 315 and the parent object is not multi-selectable, return early. Otherwise, 316 set or unset the child's selected flag based on the passed flag. 317 318 2010-01-20 Steve Falkenburg <sfalken (a] apple.com> 319 320 Reviewed by Darin Adler and Adam Roben. 321 322 Feature defines are difficult to maintain on Windows builds 323 https://bugs.webkit.org/show_bug.cgi?id=33883 324 325 FeatureDefines.vsprops are now maintained in a way similar to 326 Configurations/FeatureDefines.xcconfig, with the added advantage 327 of having a single FeatureDefines file across all projects. 328 329 * WebKit.vcproj/Interfaces.vcproj: Add FeatureDefines.vsprops inherited property sheet. 330 * WebKit.vcproj/WebKit.sln: Set up Cairo configuration for WebCoreGenerated. 331 * WebKit.vcproj/WebKit.vcproj: Remove ENABLE_ preprocessor definitions. 332 Add FeatureDefines.vsprops inherited property sheet. 333 * WebKit.vcproj/WebKitGUID.vcproj: Add FeatureDefines.vsprops inherited property sheet. 334 335 2010-01-17 Jon Honeycutt <jhoneycutt (a] apple.com> 336 337 MSAA: The child <option> elements of a non-multiple <select> are not 338 exposed 339 340 https://bugs.webkit.org/show_bug.cgi?id=33773 341 <rdar://problem/7550556> 342 343 Reviewed by Alice Liu. 344 345 * AccessibleBase.cpp: 346 (AccessibleBase::get_accState): 347 If the object is invisible, set the invisible state flag. If the object 348 is collapsed, set the collapsed state. If the object is a combo box, 349 set the has popup flag, and if it's not collapsed, set the expanded 350 flag. 351 (MSAARole): 352 Add new WebCore to MSAA role mappings. 353 354 * WebCoreLocalizedStrings.cpp: 355 (WebCore::AXMenuListActionVerb): 356 Return the action verb that Firefox uses for <select> elements with 357 popups. 358 (WebCore::AXMenuListPopupActionVerb): 359 Return the verb that Firefox uses for a popup list. 360 361 2010-01-19 John Sullivan <sullivan (a] apple.com> 362 363 https://bugs.webkit.org/show_bug.cgi?id=33854 364 Would like a variant of WebHTMLRepresentation's searchForLabelsBeforeElement that returns 365 more info about where the result was found 366 367 Reviewed by Darin Adler 368 369 * Interfaces/IWebHTMLRepresentation.idl: 370 Created variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove. 371 372 * Interfaces/WebKit.idl: 373 Touched in order to get other idl change to propagate correctly. 374 375 * WebHTMLRepresentation.cpp: 376 (WebHTMLRepresentation::deprecatedSearchForLabels): 377 Renamed since iDL doesn't support two functions with the same name but different signatures. 378 (WebHTMLRepresentation::searchForLabels): 379 Implemented variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove. 380 381 * WebHTMLRepresentation.h: 382 Declared variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove. 383 384 2010-01-19 Adam Roben <aroben (a] apple.com> 385 386 Windows build fix 387 388 * WebScriptWorld.cpp: Added missing #include. 389 390 2010-01-19 Dave Hyatt <hyatt (a] apple.com> 391 392 Build bustage fix. Make sure the newly added scriptWorldForGlobalContext function is [local] in the IDL. 393 394 * Interfaces/IWebScriptWorld.idl: 395 396 2010-01-19 Dave Hyatt <hyatt (a] apple.com> 397 398 Reviewed by Adam Roben. 399 400 Add an API to obtain a WebScriptWorld from a JSGlobalContextRef. 401 402 * Interfaces/IWebScriptWorld.idl: 403 * WebScriptWorld.cpp: 404 (WebScriptWorld::scriptWorldForGlobalContext): 405 * WebScriptWorld.h: 406 407 2010-01-18 Adam Roben <aroben (a] apple.com> 408 409 Add IWebViewPrivate::setDomainRelaxationForbiddenForURLScheme 410 411 WebKit/win part of fixing <http://webkit.org/b/33806> 412 <rdar://problem/7552837> Would like API to disallow setting of 413 document.domain for pages with certain URL schemes 414 415 Reviewed by Sam Weinig. 416 417 * Interfaces/IWebViewPrivate.idl: Added 418 setDomainRelaxationForbiddenForURLScheme. 419 420 * Interfaces/WebKit.idl: Touched to force a build. 421 422 * WebView.cpp: 423 (WebView::setDomainRelaxationForbiddenForURLScheme): 424 * WebView.h: 425 Added. Calls through to SecurityOrigin. 426 427 2010-01-18 Chris Marrin <cmarrin (a] apple.com> 428 429 Reviewed by Darin Adler. 430 431 Use new setScrollFrame API 432 https://bugs.webkit.org/show_bug.cgi?id=32279 433 434 * WebView.cpp: 435 (WebView::updateRootLayerContents): 436 437 2010-01-15 Jon Honeycutt <jhoneycutt (a] apple.com> 438 439 MSAA: Screen rect for <option> elements is always the zero rect 440 441 https://bugs.webkit.org/show_bug.cgi?id=33758 442 443 Reviewed by Oliver Hunt. 444 445 * AccessibleBase.cpp: 446 (AccessibleBase::accLocation): 447 Use elementRect() rather than boundingBoxRect(), which 448 AccessibilityListBoxOption overrides. 449 450 2010-01-15 Jon Honeycutt <jhoneycutt (a] apple.com> 451 452 get_accParent should try to retrieve parent AccessibilityObject, before 453 calling upon window 454 455 https://bugs.webkit.org/show_bug.cgi?id=22893 456 457 Reviewed by Darin Adler. 458 459 * AccessibleBase.cpp: 460 (AccessibleBase::get_accParent): 461 If the object has a parent object, return it. If not, return the 462 accessible for the WebView window. 463 464 2010-01-12 Jon Honeycutt <jhoneycutt (a] apple.com> 465 466 MSAA: selected, selectable, extended selectable, and multiple 467 selectable states are not reported 468 469 https://bugs.webkit.org/show_bug.cgi?id=33574 470 <rdar://problem/7536826> 471 472 Reviewed by Darin Adler. 473 474 * AccessibleBase.cpp: 475 (AccessibleBase::get_accState): 476 Remove the call to isMultiSelect(). Call the correctly-named 477 isMultiSelectable(), and if it returns true, set both the "extended 478 selectable" and "multiple selectable" states. Check whether the object 479 is selected or selectable, and report those states. 480 481 2010-01-13 Steve Falkenburg <sfalken (a] apple.com> 482 483 Reviewed by Adam Roben. 484 485 Add additional Geolocation interfaces in WebKit for Windows. 486 487 * Interfaces/IWebGeolocationPolicyListener.idl: Added. 488 * Interfaces/IWebUIDelegatePrivate.idl: Add decidePolicyForGeolocationRequest to IWebUIDelegatePrivate2. 489 Append since this version hasn't shipped. 490 * Interfaces/WebKit.idl: Add include of IWebGeolocationPolicyListener.idl. 491 * WebCoreSupport/WebChromeClient.cpp: 492 (WebChromeClient::requestGeolocationPermissionForFrame): Call into decidePolicyForGeolocationRequest. 493 * WebCoreSupport/WebGeolocationControllerClient.cpp: 494 (WebGeolocationControllerClient::WebGeolocationControllerClient): Moved *. 495 * WebGeolocationPolicyListener.cpp: Added. 496 * WebGeolocationPolicyListener.h: Added. 497 * WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPolicyListener. 498 * WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPolicyListener, WebGeolocationPolicyListener. 499 * WebView.cpp: 500 (WebView::setGeolocationProvider): Removed extraneous STDMETHODCALLTYPE. 501 (WebView::geolocationProvider): Removed extraneous STDMETHODCALLTYPE. 502 (WebView::geolocationDidChangePosition): Removed extraneous STDMETHODCALLTYPE. 503 (WebView::geolocationDidFailWithError): Removed extraneous STDMETHODCALLTYPE. 504 505 2010-01-12 Steve Falkenburg <sfalken (a] apple.com> 506 507 Reviewed by Adam Roben, Sam Weinig. 508 509 Add Geolocation interfaces in WebKit for Windows. 510 511 * ForEachCoClass.h: Added WebGeolocationPosition. 512 * Interfaces/IWebError.idl: 513 * Interfaces/IWebGeolocationPosition.idl: Added. 514 * Interfaces/IWebGeolocationProvider.idl: Added. 515 * Interfaces/IWebViewPrivate.idl: 516 * Interfaces/WebKit.idl: 517 * WebCoreSupport/WebGeolocationControllerClient.cpp: Added. 518 (WebGeolocationControllerClient::WebGeolocationControllerClient): 519 (WebGeolocationControllerClient::startUpdating): 520 (WebGeolocationControllerClient::stopUpdating): 521 (WebGeolocationControllerClient::lastPosition): 522 * WebCoreSupport/WebGeolocationControllerClient.h: Added. 523 * WebGeolocationPosition.cpp: Added IWebGeolocationPosition implementation. 524 * WebGeolocationPosition.h: Added IWebGeolocationPosition implementation. 525 * WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPosition.idl, IWebGeolocationProvider.idl, 526 relocated JavaScriptCoreAPITypes.idl, WebScrollbarTypes.idl 527 * WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPosition.h/.cpp, WebGeolocationControllerClient.h/cpp, 528 * WebKitClassFactory.cpp: Add WebGeolocationPosition include. 529 * WebView.cpp: 530 (WebView::initWithFrame): Create WebGeolocationControllerClient if Geolocation is enabled. 531 (WebView::setGeolocationProvider): Added Geolocation-specific method. 532 (WebView::geolocationProvider): Added Geolocation-specific method. 533 (WebView::geolocationDidChangePosition): Added Geolocation-specific method. 534 (WebView::geolocationDidFailWithError): Added Geolocation-specific method. 535 * WebView.h: Added setGeolocationProvider, geolocationProvider, geolocationDidChangePosition, geolocationDidFailWithError. 536 537 2010-01-11 Jon Honeycutt <jhoneycutt (a] apple.com> 538 539 MSAA: Accessibility role of <select multiple> elements is wrong 540 541 https://bugs.webkit.org/show_bug.cgi?id=33522 542 543 Reviewed by Darin Adler. 544 545 * AccessibleBase.cpp: 546 (MSAARole): 547 Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA 548 "list" and "list item" roles. 549 550 2010-01-08 Brent Fulgham <bfulgham (a] webkit.org> 551 552 Build fix, no review. 553 554 Protect video control logic inside ENABLE(VIDEO). 555 556 * WebView.cpp: 557 (WebView::enterFullscreenForNode): 558 (WebView::exitFullscreen): 559 * WebView.h: 560 561 2010-01-08 Chris Marrin <cmarrin (a] apple.com> 562 563 Reviewed by Adam Roben. 564 565 Implement full-screen video for Windows 566 https://bugs.webkit.org/show_bug.cgi?id=31318 567 568 This adds a full-screen controller, FullscreenVideoController, 569 which manages going in and out of full-screen. The actual 570 full-screen window is created and managed by logic added 571 to QTMovieWin. FullscreenVideoController also creates and 572 manages a HUD. The HUD renders and manages events to 573 control the playing video. Movie controller events go to 574 FullscreenVideoController which then sends them to HTMLMediaElement, 575 which is passed to the controller by WebView, which gets the call 576 to go into full-screen mode from HTMLMediaElement via 577 ChromeClient. 578 579 I've also updated the icons so the related sets (Play/Pause and 580 volume high/volume low/exit fullscreen) are the same size. This 581 allows me to position them using common code. 582 583 * WebCoreSupport/WebChromeClient.cpp: 584 (WebChromeClient::supportsFullscreenForNode): 585 (WebChromeClient::enterFullscreenForNode): 586 (WebChromeClient::exitFullscreenForNode): 587 * WebCoreSupport/WebChromeClient.h: 588 * WebKit.vcproj/WebKit.vcproj: 589 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: 590 * WebKit.vcproj/fsVideoAudioVolumeLow.png: 591 * WebKit.vcproj/fsVideoExitFullscreen.png: 592 * WebKit.vcproj/fsVideoPause.png: 593 * WebKit.vcproj/fsVideoPlay.png: 594 * WebKitDLL.cpp: 595 (loadResourceIntoBuffer): 596 * FullscreenVideoController.cpp: Added. 597 * FullscreenVideoController.h: Added. 598 * WebView.cpp: 599 (WebView::enterFullscreenForNode): 600 (WebView::exitFullscreen): 601 * WebView.h: 602 603 2010-01-08 Brent Fulgham <bfulgham (a] webkit.org> 604 605 Unreviewed correction. 606 607 Accidentally left unnecessary modification to hdcFromContext 608 in when landing r52995. 609 610 * WebFrame.cpp: 611 (hdcFromContext): Back out unneeded modification. 612 613 2010-01-08 Brent Fulgham <bfulgham (a] webkit.org> 614 615 Reviewed by Adam Roben. 616 617 Use correct cairo surface data type for handling print operations. 618 https://bugs.webkit.org/show_bug.cgi?id=33022. 619 620 * WebFrame.cpp: 621 (scaleFactor): Handle 'scale = 0' case. 622 (WebFrame::spoolPage): Use scaleFactor helper function. Account for 623 margin size in region passed to header/footer routines. 624 (WebFrame::spoolPages): Properly clean up Cairo surface. 625 626 2010-01-07 Kent Tamura <tkent (a] chromium.org> 627 628 Reviewed by Maciej Stachowiak. 629 630 Remove COM code generation files. 631 https://bugs.webkit.org/show_bug.cgi?id=32854 632 633 * WebKit.vcproj/DerivedSources.make: Removed. 634 * WebKit.vcproj/build-generated-files.sh: Removed. 635 636 2010-01-05 Adam Roben <aroben (a] apple.com> 637 638 Make IWebView::close and destroying a WebView's HWND optional for 639 WebKit clients 640 641 WebView will now take care of these operations itself when its last 642 reference is released, if they haven't already been done. 643 644 IWebView::close now also destroys the WebView's HWND. All WebKit 645 clients were already performing these operations in succession anyway, 646 or were attempting to by calling IWebView::close then destroying the 647 WebView's host window (which actually resulted in the WebView's HWND 648 leaking, and the crash in the below bug). 649 650 Fixes <rdar://problem/7374218> <http://webkit.org/b/32827> Crash when 651 calling IWebView::close, then releasing the WebView, without calling 652 DestroyWindow 653 654 Fixes a few WebViewDestruction tests, too. 655 656 Reviewed by Steve Falkenburg. 657 658 * WebView.cpp: 659 (WebView::~WebView): Don't try to destroy m_viewWindow here. That 660 should already have happened. Assert that this is the case. 661 (WebView::close): If m_viewWindow isn't already being destroyed, 662 destroy it now. Moved the call to revokeDragDrop() here from our 663 WM_DESTROY handler because it needs to be done before m_viewWindow is 664 nulled out. 665 (WebView::WebViewWndProc): Removed call to revokeDragDrop() that 666 close() now performs. 667 (WebView::Release): If our last reference is being released, call 668 close() so that clients don't have to. (It's harmless to call close() 669 multiple times.) We do this here instead of in the destructor because 670 close() can cause AddRef() and Release() to be called, and calling 671 those from within the destructor leads to double-destruction. 672 (WebView::setHostWindow): Removed an unnecessary (and now harmful) 673 null-check. 674 (WebView::revokeDragDrop): Changed an assertion into a run-time check, 675 since this will now sometimes be called when m_viewWindow hasn't been 676 created yet. Changed the IsWindow call to a null-check because we 677 never hold onto a destroyed m_viewWindow. 678 (WebView::windowAncestryDidChange): If we don't have a view window, 679 stop tracking changes to our parent's active state. 680 681 2010-01-05 Adam Roben <aroben (a] apple.com> 682 683 Make it safe to call IWebView::close when IWebView::initWithFrame 684 hasn't been called 685 686 Part of <rdar://problem/7374218> <http://webkit.org/b/32827> Crash 687 when IWebView::close, then releasing the WebView, without calling 688 DestroyWindow 689 690 Reviewed by Steve Falkenburg. 691 692 * WebView.cpp: 693 (WebView::close): Null-check m_page and m_preferences before using 694 them. They will be null if initWithFrame was never called. 695 696 2010-01-05 Adam Roben <aroben (a] apple.com> 697 698 Add assertions to catch double-destruction of WebViews earlier 699 700 I basically copied the m_deletionHasBegun logic from WTF::RefCounted. 701 702 Fixes <http://webkit.org/b/33219>. 703 704 Reviewed by Darin Adler. 705 706 * WebView.cpp: 707 (WebView::WebView): Initialize m_deletionHasBegun 708 (WebView::AddRef): Assert that deletion hasn't already begun. 709 (WebView::Release): Assert that deletion hasn't already begun, then 710 record when deletion *does* begin. 711 712 * WebView.h: Added m_deletionHasBegun. 713 714 2010-01-05 Adam Roben <aroben (a] apple.com> 715 716 Remove dead code in WebViewWndProc 717 718 Fixes <http://webkit.org/b/33218>. 719 720 Reviewed by Darin Adler. 721 722 * WebView.cpp: 723 (WebView::WebViewWndProc): Removed a redundant isBeingDestroyed check. 724 We bail out much earlier in this function if isBeingDestroyed is true. 725 726 2010-01-04 Jon Honeycutt <jhoneycutt (a] apple.com> 727 728 MSAA: Accessibility role of <select> elements is wrong 729 730 https://bugs.webkit.org/show_bug.cgi?id=33192 731 732 Reviewed by Sam Weinig. 733 734 * AccessibleBase.cpp: 735 (MSAARole): 736 Map WebCore::PopUpButtonRole to MSAA's ROLE_SYSTEM_COMBOBOX. 737 738 2010-01-04 Alexey Proskuryakov <ap (a] apple.com> 739 740 Reviewed by Darin Adler. 741 742 https://bugs.webkit.org/show_bug.cgi?id=33181 743 The first letter is not removed properly from inline input hole 744 745 * WebView.cpp: (WebView::onIMEEndComposition): If composition is ended before it was 746 confirmed, cancel it. 747 748 2010-01-04 Alexey Proskuryakov <ap (a] apple.com> 749 750 Reviewed by Darin Adler. 751 752 https://bugs.webkit.org/show_bug.cgi?id=33161 753 Assertion failure in WebView when using Chinese Simplified IME 754 755 * WebView.cpp: (WebView::onIMERequestCharPosition): Changed the assertion into release mode 756 check. We can't make assertions about arguments passed from outside WebKit. 757 758 2010-01-04 Alexey Proskuryakov <ap (a] apple.com> 759 760 Reviewed by Darin Adler. 761 762 https://bugs.webkit.org/show_bug.cgi?id=33157 763 Implement TextInput logging channel on Windows 764 765 * WebKitLogging.cpp: (WebKitInitializeLoggingChannelsIfNecessary): 766 * WebKitLogging.h: 767 Added a TextInput channel in place of unused Network one. 768 769 * WebView.cpp: 770 (WebView::WebViewWndProc): Changed onIMERequest to return result directly. We never forward 771 it to DefWindowProc, so there is no need to return an unused boolean result for "handled". 772 (WebView::onIMEStartComposition): Added logging. 773 (imeCompositionArgumentNames): A helper function for detailed logging in onIMEComposition. 774 (imeNotificationName): A helper function for detailed logging in onIMENotify. 775 (imeRequestName): A helper function for detailed logging in onIMERequest. 776 (WebView::onIMEComposition): Added logging. 777 (WebView::onIMEEndComposition): Ditto. 778 (WebView::onIMEChar): Ditto. 779 (WebView::onIMENotify): Ditto. 780 (WebView::onIMERequestCharPosition): Changed to return result directly. 781 (WebView::onIMERequestReconvertString): Ditto. 782 (WebView::onIMERequest): Changed to return result directly. Added logging. 783 (WebView::onIMESelect): Added logging. 784 (WebView::onIMESetContext): Added logging. 785 786 * WebView.h: onIMERequest functions now return result directly. 787 788 789 2010-01-04 Adam Roben <aroben (a] apple.com> 790 791 Add WebKitAPITest 792 793 Fixes <http://webkit.org/b/33167>. 794 795 Reviewed by Sam Weinig. 796 797 * WebKit.vcproj/WebKit.sln: Added WebKitAPITest.vcproj. It builds just 798 after DumpRenderTree.vcproj. 799 800 2010-01-04 Dan Bernstein <mitz (a] apple.com> 801 802 Reviewed by Ada Chan and Mark Rowe. 803 804 Updated copyright string 805 806 * WebKit.vcproj/WebKit.rc: 807 808 2009-12-22 Darin Adler <darin (a] apple.com> 809 810 Another try at fixing Windows build. 811 812 * WebKitPrefix.cpp: Touch it. 813 814 2009-12-22 Darin Adler <darin (a] apple.com> 815 816 Reviewed by Mark Rowe. 817 818 Turn off datagrid by default, at least for all platforms Apple ships. 819 The datagrid implementation isn't ready for general web use yet. 820 821 * WebKit.vcproj/WebKit.vcproj: Turn off datagrid by default. 822 823 2009-12-21 Adam Roben <aroben (a] apple.com> 824 825 Fix non-ACCELERATED_COMPOSITING builds 826 827 * WebPreferences.cpp: 828 (WebPreferences::acceleratedCompositingEnabled): Guard use of 829 WKCACFLayerRenderer with USE(ACCELERATED_COMPOSITING). 830 831 2009-12-18 Adam Roben <aroben (a] apple.com> 832 833 Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled 834 835 Fixes <http://webkit.org/b/32745>. 836 837 Reviewed by Ada Chan. 838 839 * Interfaces/IWebPreferencesPrivate.idl: Added 840 [set]AcceleratedCompositingEnabled. 841 842 * Interfaces/WebKit.idl: Touched to force a build. 843 844 * WebPreferenceKeysPrivate.h: Added 845 WebKitAcceleratedCompositingEnabledPreferenceKey. 846 847 * WebPreferences.cpp: 848 (WebPreferences::initializeDefaultSettings): Make accelerated 849 compositing be on by default. 850 (WebPreferences::setAcceleratedCompositingEnabled): Store the new 851 value. 852 (WebPreferences::acceleratedCompositingEnabled): If accelerated 853 compositing isn't available, return false. Otherwise, return the value 854 stored in preferences. 855 856 * WebPreferences.h: Added [set]AcceleratedCompositingAvailable. 857 858 * WebView.cpp: 859 (WebView::notifyPreferencesChanged): Just pass the value from 860 WebPreferences on down. 861 862 2009-12-17 Jon Honeycutt <jhoneycutt (a] apple.com> 863 864 MSAA: Accessibility role of list items is wrong 865 866 https://bugs.webkit.org/show_bug.cgi?id=32688 867 868 Reviewed by Adam Roben. 869 870 * AccessibleBase.cpp: 871 (MSAARole): 872 Make the WebCore list item role map to the MSAA list item role. 873 874 2009-12-17 Jon Honeycutt <jhoneycutt (a] apple.com> 875 876 MSAA: Accessibility role of list markers is wrong 877 878 https://bugs.webkit.org/show_bug.cgi?id=32687 879 880 Reviewed by Adam Roben. 881 882 * AccessibleBase.cpp: 883 (MSAARole): 884 Make the WebCore list marker role map to the MSAA static text role. 885 886 2009-12-18 Adam Roben <aroben (a] apple.com> 887 888 Add #includes needed after WebCore clean-up 889 890 Rubber-stamped by Anders Carlsson. 891 892 Fixes <http://webkit.org/b/32718>. 893 894 * WebCoreSupport/WebContextMenuClient.cpp: 895 * WebDataSource.cpp: 896 * WebHTMLRepresentation.cpp: 897 * WebView.cpp: 898 * WebView.h: 899 900 2009-12-17 Benjamin Otte <otte (a] gnome.org> 901 902 Reviewed by Adam Roben. 903 904 Don't include all JSC headers everywhere 905 https://bugs.webkit.org/show_bug.cgi?id=32663 906 907 * WebCoreLocalizedStrings.cpp: Added now-needed #include of 908 MathExtras.h. 909 910 2009-12-17 Adam Roben <aroben (a] apple.com> 911 912 Remove WebKit.sln's Debug_All and Debug_Internal configurations 913 914 These configurations aren't buildable by people outside of Apple, and 915 Apple doesn't use this solution file. 916 917 Fixes <http://webkit.org/b/31000> Windows WebKit Build Configuration 918 should default to Debug instead of Debug_all. 919 920 Rubber-stamped by Dan Bernstein. 921 922 * WebKit.vcproj/WebKit.sln: 923 924 2009-12-16 Jon Honeycutt <jhoneycutt (a] apple.com> 925 926 MSAA: Accessibility role of text nodes is wrong 927 928 https://bugs.webkit.org/show_bug.cgi?id=32631 929 <rdar://problem/7369084> 930 931 Reviewed by Alice Liu. 932 933 * AccessibleBase.cpp: 934 (MSAARole): 935 If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT. 936 (AccessibleBase::role): 937 Call roleValueForMSAA(). 938 939 2009-12-14 Brent Fulgham <bfulgham (a] webkit.org> 940 941 Reviewed by Adam Roben. 942 943 Provide working printing support for WinCairo port. 944 945 * WebFrame.cpp: 946 (WebFrame::spoolPage): Conditionalize initialization of 947 PlatformGraphicsContext handling for CG vs. Cairo. 948 (scaleFactor): Add helper function. 949 (hdcFromContext): Add helper function. 950 (WebFrame::drawHeader): Correct Cairo variation. 951 (WebFrame::drawFooter): Correct Cairo variation. 952 (WebFrame::spoolPages): Correct Cairo variation. 953 954 2009-12-13 Sam Weinig <sam (a] webkit.org> 955 956 Reviewed by Dan Bernstein. 957 958 Fix for https://bugs.webkit.org/show_bug.cgi?id=32499 959 Add client based Geolocation provider 960 961 Add first cut of a client based Geolocation provider. This is guarded by 962 ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a 963 GeolocationControllerClient interface that no-one currently implements, 964 but will in a subsequent patch. 965 966 * WebView.cpp: 967 (WebView::initWithFrame): 968 969 2009-12-14 Adam Roben <aroben (a] apple.com> 970 971 Change IWebFramePrivate's vtable to be compatible with Safari 4.0.4 972 973 Reviewed by Steve Falkenburg. 974 975 Fixes <http://webkit.org/b/32433> REGRESSION (r51567): Right click on 976 a link element crashes WebKit nightly 977 978 * Interfaces/IWebFramePrivate.idl: Moved pauseSVGAnimation to the end 979 of the interface so the vtable that Safari 4.0.4 sees is unchanged. 980 981 2009-12-14 Adam Roben <aroben (a] apple.com> 982 983 Build fix 984 985 * WebKit.vcproj/WebKit.vcproj: Added $(DXSDK_DIR)\Lib\x86 to the 986 libpath for all non-Cairo configurations (it was missing from most of 987 them). 988 989 2009-12-11 Chris Marrin <cmarrin (a] apple.com> 990 991 Reviewed by Jon Honeycutt. 992 993 Added icons for full-screen video on Windows 994 https://bugs.webkit.org/show_bug.cgi?id=31318 995 996 * WebKit.vcproj/WebKit.rc: 997 * WebKit.vcproj/WebKit.vcproj: 998 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Added. 999 * WebKit.vcproj/fsVideoAudioVolumeLow.png: Added. 1000 * WebKit.vcproj/fsVideoExitFullscreen.png: Added. 1001 * WebKit.vcproj/fsVideoPause.png: Added. 1002 * WebKit.vcproj/fsVideoPlay.png: Added. 1003 * WebKit.vcproj/resource.h: 1004 1005 2009-12-11 Chris Marrin <cmarrin (a] apple.com> 1006 1007 Reviewed by Adam Roben. 1008 1009 Delay load DLLs for accelerated compositing 1010 https://bugs.webkit.org/show_bug.cgi?id=31856 1011 1012 If the DLLs (d3d9 and QuartzCore). are not present it 1013 turns off accelerated compositing and avoids calling 1014 any of the functions in the DLLs. 1015 1016 * WebView.cpp: 1017 (WebView::notifyPreferencesChanged): 1018 1019 2009-12-10 Jon Honeycutt <jhoneycutt (a] apple.com> 1020 1021 Pass more information about a plug-in to the PluginHalterDelegate 1022 1023 Reviewed by Adam Roben. 1024 1025 * Interfaces/IWebPluginHalterDelegate.idl: 1026 Add new parameters. 1027 1028 * WebCoreSupport/WebPluginHalterClient.cpp: 1029 (WebPluginHalterClient::shouldHaltPlugin): 1030 Update for new parameters. Pass them when making the delegate call. 1031 1032 * WebCoreSupport/WebPluginHalterClient.h: 1033 Update for new parameters. 1034 1035 2009-12-09 Brent Fulgham <bfulgham (a] webkit.org> 1036 1037 Revert incorrect commit-box update r51911. 1038 It mistakenly set the selectAll implementation in the 1039 deslectAll method. 1040 1041 * WebFrame.cpp: 1042 (WebFrame::deselectAll): 1043 1044 2009-12-09 Brent Fulgham <bfulgham (a] webkit.org> 1045 1046 Reviewed by Darin Adler. 1047 1048 Provide an implementation for 'selectAll' 1049 https://bugs.webkit.org/show_bug.cgi?id=32296 1050 1051 * WebFrame.cpp: 1052 (WebFrame::selectAll): Implement "SelectAll" command. 1053 1054 2009-12-09 Brent Fulgham <bfulgham (a] webkit.org> 1055 1056 Reviewed by Darin Adler. 1057 1058 Provide an implementation for 'selectAll' 1059 https://bugs.webkit.org/show_bug.cgi?id=32296 1060 1061 * WebFrame.cpp: 1062 (WebFrame::selectAll): Implement "SelectAll" command. 1063 1064 2009-12-08 Chris Marrin <cmarrin (a] apple.com> 1065 1066 Reviewed by Adam Roben. 1067 1068 Delay load DLLs for accelerated compositing 1069 https://bugs.webkit.org/show_bug.cgi?id=31856 1070 1071 If the DLLs (d3d9 and QuartzCore). are not present it 1072 turns off accelerated compositing and avoids calling 1073 any of the functions in the DLLs. 1074 1075 * WebView.cpp: 1076 * WebView.h: 1077 1078 2009-12-08 Adam Roben <aroben (a] apple.com> 1079 1080 Windows build fix 1081 1082 * Interfaces/WebKit.idl: Touched this to force Interfaces.vcproj to rebuild. 1083 1084 2009-12-08 John Sullivan <sullivan (a] apple.com> 1085 1086 Reviewed by Dan Bernstein 1087 1088 Split two-clause assertions into two separate assertions. 1089 1090 * DOMHTMLClasses.cpp: 1091 (DOMHTMLInputElement::isTextField): 1092 Split a two-clause assertion into two separate assertions. 1093 (DOMHTMLInputElement::rectOnScreen): 1094 Added the two assertions here that all other functions in this group shared. 1095 (DOMHTMLInputElement::selectedRange): 1096 Split a two-clause assertion into two separate assertions. 1097 (DOMHTMLInputElement::setAutofilled): 1098 Split a two-clause assertion into two separate assertions. 1099 (DOMHTMLInputElement::isAutofilled): 1100 Split a two-clause assertion into two separate assertions. 1101 1102 2009-12-08 Nikolas Zimmermann <nzimmermann (a] rim.com> 1103 1104 Rubber-stamped by Maciej Stachowiak. 1105 1106 Turn on (SVG) Filters for Win. 1107 https://bugs.webkit.org/show_bug.cgi?id=32224 1108 1109 * WebKit.vcproj/WebKit.vcproj: 1110 1111 2009-12-08 John Sullivan <sullivan (a] apple.com> 1112 1113 Add isAutofilled getter to match existing setter. 1114 1115 Reviewed by Ada Chan. 1116 1117 * DOMHTMLClasses.cpp: 1118 (DOMHTMLInputElement::isAutofilled): 1119 Implemented new cover function. 1120 1121 * DOMHTMLClasses.h: 1122 Declared new cover function. 1123 1124 * Interfaces/DOMPrivate.idl: 1125 Declared new interface. 1126 1127 2009-12-07 Gavin Barraclough <barraclough (a] apple.com> 1128 1129 Reviewed by NOBODY (Windows build fix part III). 1130 1131 * WebView.cpp: 1132 (WebView::stringByEvaluatingJavaScriptFromString): 1133 1134 2009-12-07 Gavin Barraclough <barraclough (a] apple.com> 1135 1136 Reviewed by NOBODY (Windows build fix part II). 1137 1138 * WebView.cpp: 1139 (WebView::stringByEvaluatingJavaScriptFromString): 1140 1141 2009-12-03 Brady Eidson <beidson (a] apple.com> 1142 1143 Reviewed by Sam Weinig. 1144 1145 <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API 1146 1147 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: 1148 * WebCoreSupport/WebFrameLoaderClient.cpp: 1149 (WebFrameLoaderClient::dispatchDidPushStateWithinPage): 1150 (WebFrameLoaderClient::dispatchDidReplaceStateWithinPage): 1151 (WebFrameLoaderClient::dispatchDidPopStateWithinPage): 1152 * WebCoreSupport/WebFrameLoaderClient.h: 1153 1154 2009-12-03 Pavel Feldman <pfeldman (a] dhcp-172-28-174-220.spb.corp.google.com> 1155 1156 Reviewed by Timothy Hatcher. 1157 1158 Web Inspector: Simplify the settings support in inspector controller. 1159 1160 https://bugs.webkit.org/show_bug.cgi?id=32076 1161 1162 * WebCoreSupport/WebInspectorClient.cpp: 1163 (WebInspectorClient::attachWindow): 1164 (WebInspectorClient::detachWindow): 1165 (WebInspectorClient::showWindowWithoutNotifications): 1166 * WebCoreSupport/WebInspectorClient.h: 1167 1168 2009-12-03 Ben Murdoch <benm (a] google.com> 1169 1170 Reviewed by Brady Eidson. 1171 1172 [Android] The FrameLoaderClient is unaware of BackForwardList changes. 1173 https://bugs.webkit.org/show_bug.cgi?id=31914 1174 1175 * WebCoreSupport/WebFrameLoaderClient.cpp: 1176 (WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug). 1177 (WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto. 1178 (WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto. 1179 * WebCoreSupport/WebFrameLoaderClient.h: 1180 1181 2009-12-02 Timothy Hatcher <timothy (a] apple.com> 1182 1183 Move setValueForUser to the end of the DOMHTMLInputElement interface 1184 so it is fine for binary compatibility. 1185 1186 Directed by Steve Falkenburg. 1187 1188 * Interfaces/DOMHTML.idl: 1189 1190 2009-12-02 Timothy Hatcher <timothy (a] apple.com> 1191 1192 Expose setValueForUser for the COM DOMHTMLInputElement. 1193 1194 <rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript 1195 1196 Reviewed by Dan Bernstein. 1197 1198 * DOMHTMLClasses.cpp: 1199 (DOMHTMLInputElement::setValueForUser): 1200 * Interfaces/DOMHTML.idl: 1201 1202 2009-12-01 Nikolas Zimmermann <nzimmermann (a] rim.com> 1203 1204 Not reviewed. Try to fix windows build. 1205 1206 * WebFrame.cpp: 1207 1208 2009-12-01 Nikolas Zimmermann <nzimmermann (a] rim.com> 1209 1210 Reviewed by Simon Fraser. 1211 1212 Add SVG animation test framework with 'snapshot' functionality 1213 https://bugs.webkit.org/show_bug.cgi?id=31897 1214 1215 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method, 1216 forwarding the call to SVGDocumentExtensions, if SVG is enabled. 1217 1218 Implemented just like the existing pauseAnimation* methods for CSS animations. 1219 1220 * Interfaces/IWebFramePrivate.idl: 1221 * WebFrame.cpp: 1222 (WebFrame::pauseSVGAnimation): 1223 * WebFrame.h: 1224 1225 2009-11-30 Adam Roben <aroben (a] apple.com> 1226 1227 Fix double-free of BSTRs passed to WebNavigationData::createInstance 1228 1229 WebFrameLoaderClient::updateGlobalHistory was converting 1230 WebCore::Strings to WebCore::BStrings, then passing them to 1231 WebNavigationData::createInstance. But the latter function takes BSTR 1232 parameters and adopts them into WebCore::BStrings. So the end result 1233 was that two WebCore::BStrings would end up freeing each underlying 1234 BSTR. 1235 1236 The fix is to only convert to WebCore::BString inside 1237 WebNavigationData. 1238 1239 Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION 1240 (r49564): Crash in updateGlobalHistory when running Javascript iBench 1241 test 1242 1243 I couldn't find a way to reproduce this in DumpRenderTree. 1244 1245 Reviewed by Steve Falkenburg. 1246 1247 * WebCoreSupport/WebFrameLoaderClient.cpp: 1248 (WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to 1249 WebNavigationData::createInstance. 1250 1251 * WebNavigationData.cpp: 1252 (WebNavigationData::WebNavigationData): 1253 (WebNavigationData::createInstance): 1254 * WebNavigationData.h: 1255 Changed to take const WebCore::String&s instead of BSTRs and to 1256 convert the Strings to BStrings at this level. 1257 1258 2009-11-30 Steve Falkenburg <sfalken (a] apple.com> 1259 1260 Reviewed by Adam Roben. 1261 1262 WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject 1263 https://bugs.webkit.org/show_bug.cgi?id=31986 1264 1265 * WebFrame.cpp: 1266 (WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned. 1267 1268 2009-11-24 Chris Marrin <cmarrin (a] apple.com> 1269 1270 Another Windows build fix 1271 1272 Got rid of d3d.lib and d3dx9.lib dependency. Not needed until 1273 we turn on ACCELERATED_COMPOSITING 1274 1275 * WebKit.vcproj/WebKit.vcproj: 1276 1277 2009-11-24 Chris Marrin <cmarrin (a] apple.com> 1278 1279 Fixed Windows build 1280 1281 Got rid of QuartzCore.lib dependency. Not needed until 1282 we turn on ACCELERATED_COMPOSITING 1283 1284 * WebKit.vcproj/WebKit.vcproj: 1285 1286 2009-11-24 Chris Marrin <cmarrin (a] apple.com> 1287 1288 Reviewed by Simon Fraser. 1289 1290 Implement accelerated compositing 1291 https://bugs.webkit.org/show_bug.cgi?id=27314 1292 1293 This is the WebKit side of the implementation. It plumbs the root layer 1294 from WebCore. It also makes changes to WebView which places the 1295 backing store of the page into the root compositing layer so it is 1296 properly composited with all the other layers. This deals with resizing, 1297 scrolling, and incremental repaint of the page. 1298 1299 * WebCoreSupport/WebChromeClient.cpp: 1300 (WebChromeClient::attachRootGraphicsLayer): 1301 (WebChromeClient::scheduleCompositingLayerSync): 1302 * WebCoreSupport/WebChromeClient.h: 1303 (WebChromeClient::setNeedsOneShotDrawingSynchronization): 1304 * WebKit.vcproj/WebKit.vcproj: 1305 * WebView.cpp: 1306 (WebView::WebView): 1307 (WebView::close): 1308 (WebView::repaint): 1309 (WebView::scrollBackingStore): 1310 (WebView::paint): 1311 (WebViewWndProc): 1312 (WebView::setRootChildLayer): 1313 (WebView::setAcceleratedCompositing): 1314 (WebView::setRootLayerContents): 1315 * WebView.h: 1316 (WebView::isAcceleratedCompositing): 1317 (WebView::resizeLayerWindow): 1318 (WebView::layerWindowBecameVisible): 1319 (WebView::setRootLayerNeedsDisplay): 1320 1321 2009-11-23 Laszlo Gombos <laszlo.1.gombos (a] nokia.com> 1322 1323 Reviewed by Kenneth Rohde Christiansen. 1324 1325 Include "config.h" to meet Coding Style Guidelines 1326 https://bugs.webkit.org/show_bug.cgi?id=31792 1327 1328 * GEN_DOMObject.cpp: 1329 * WebScriptObject.cpp: 1330 1331 2009-11-21 Jon Honeycutt <jhoneycutt (a] apple.com> 1332 1333 Windows build fix. Unreviewed. 1334 1335 * Interfaces/IWebSerializedJSValue.idl: 1336 1337 2009-11-20 Jon Honeycutt <jhoneycutt (a] apple.com> 1338 1339 DOMElement::tagName() is unimplemented 1340 1341 https://bugs.webkit.org/show_bug.cgi?id=31746 1342 1343 Reviewed by Darin Adler. 1344 1345 * DOMCoreClasses.cpp: 1346 (DOMElement::tagName): 1347 Create a BString from the element's tag name, and release its BSTR 1348 into result. 1349 1350 2009-11-20 Jon Honeycutt <jhoneycutt (a] apple.com> 1351 1352 DOMNode::childNodes() is unimplemented 1353 1354 https://bugs.webkit.org/show_bug.cgi?id=31745 1355 1356 Reviewed by Darin Adler. 1357 1358 * DOMCoreClasses.cpp: 1359 (DOMNode::childNodes): 1360 Create a DOMNodeList from the node's child nodes. 1361 1362 2009-11-20 Dave Hyatt <hyatt (a] apple.com> 1363 1364 Reviewed by Jon Honeycutt. 1365 1366 Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the 1367 serialization into a separate serialize() function that can be called after the object has been 1368 created. 1369 1370 Fix a typo in serialize() caused when fixing build bustage (put a ! back in). 1371 1372 * Interfaces/IWebSerializedJSValue.idl: 1373 * WebSerializedJSValue.cpp: 1374 (WebSerializedJSValue::WebSerializedJSValue): 1375 (WebSerializedJSValue::createInstance): 1376 (WebSerializedJSValue::serialize): 1377 (WebSerializedJSValue::deserialize): 1378 * WebSerializedJSValue.h: 1379 1380 2009-11-20 Brian Weinstein <bweinstein (a] apple.com> 1381 1382 Reviewed by Dave Hyatt. 1383 1384 Another go at the Windows Build Fix - this is a couple steps of it, 1385 so a little more involved than most build fixes. 1386 1387 * Interfaces/IWebSerializedJSValue.idl: 1388 * Interfaces/JavaScriptCoreAPITypes.idl: 1389 * WebKit.vcproj/Interfaces.vcproj: 1390 * WebSerializedJSValue.cpp: 1391 (WebSerializedJSValue::deserialize): 1392 * WebSerializedJSValue.h: 1393 1394 2009-11-20 Brian Weinstein <bweinstein (a] apple.com> 1395 1396 Reviewed by Dave Hyatt. 1397 1398 Build fix for Windows - only declare JSContextRef once, instead 1399 of in two different idl files. Create a new file to hold the 1400 definition of JSContextRef. 1401 1402 * Interfaces/IWebFrameLoadDelegate.idl: 1403 * Interfaces/IWebSerializedJSValue.idl: 1404 * Interfaces/JavaScriptCoreAPITypes.idl: Added. 1405 * Interfaces/WebKit.idl: 1406 * WebKit.vcproj/Interfaces.vcproj: 1407 1408 2009-11-20 Dave Hyatt <hyatt (a] apple.com> 1409 1410 Reviewed by Oliver Hunt and Jon Honeycutt. 1411 1412 Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore 1413 and exposes the ability to do JS value serialization/deserialization to WebKit clients. 1414 1415 * Interfaces/IWebSerializedJSValue.idl: Added. 1416 * Interfaces/WebKit.idl: 1417 * WebKit.vcproj/WebKit.vcproj: 1418 * WebSerializedJSValue.cpp: Added. 1419 (WebSerializedJSValue::WebSerializedJSValue): 1420 (WebSerializedJSValue::~WebSerializedJSValue): 1421 (WebSerializedJSValue::createInstance): 1422 (WebSerializedJSValue::AddRef): 1423 (WebSerializedJSValue::Release): 1424 (WebSerializedJSValue::QueryInterface): 1425 (WebSerializedJSValue::deserialize): 1426 * WebSerializedJSValue.h: Added. 1427 1428 2009-11-19 Alexey Proskuryakov <ap (a] apple.com> 1429 1430 Reviewed by Darin Adler. 1431 1432 https://bugs.webkit.org/show_bug.cgi?id=31690 1433 Make SocketStreamHandleCFNet work on Windows 1434 1435 * WebDownloadCFNet.cpp: 1436 (WebDownload::init): 1437 (WebDownload::initWithRequest): 1438 (WebDownload::initToResumeWithBundle): 1439 Update for loaderRunLoop() now being in its own header. 1440 1441 2009-11-19 Eric Carlson <eric.carlson (a] apple.com> 1442 1443 Reviewed by Dan Bernstein. 1444 1445 <rdar://problem/7035231> 1446 Support closed caption in <video> element 1447 1448 * WebCoreLocalizedStrings.cpp: 1449 (WebCore::localizedMediaControlElementString): 1450 (WebCore::localizedMediaControlElementHelpText): 1451 Add accessibility help strings for media controller closed caption button. 1452 1453 2009-11-18 Michelangelo De Simone <micdesim (a] gmail.com> 1454 1455 Reviewed by Darin Adler. 1456 1457 Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>. 1458 Support for validationMessage attribute, as per HTML5 specs. 1459 1460 * WebCoreLocalizedStrings.cpp: 1461 (WebCore::validationMessageValueMissingText): 1462 (WebCore::validationMessageTypeMismatchText): 1463 (WebCore::validationMessagePatternMismatchText): 1464 (WebCore::validationMessageTooLongText): 1465 (WebCore::validationMessageRangeUnderflowText): 1466 (WebCore::validationMessageRangeOverflowText): 1467 (WebCore::validationMessageStepMismatchText): 1468 1469 2009-11-18 Daniel Bates <dbates (a] webkit.org> 1470 1471 Reviewed by Darin Adler. 1472 1473 https://bugs.webkit.org/show_bug.cgi?id=31186 1474 1475 Changes associated with renaming RenderTextControl::isUserEdited. 1476 1477 * DOMHTMLClasses.cpp: 1478 (DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited. 1479 (DOMHTMLTextAreaElement::isUserEdited): Ditto. 1480 1481 2009-11-12 Jon Honeycutt <jhoneycutt (a] apple.com> 1482 1483 Implement DOMHTMLInputElement::replaceCharactersInRange(). 1484 1485 https://bugs.webkit.org/show_bug.cgi?id=31492 1486 1487 Reviewed by Dan Bernstein. 1488 1489 * DOMHTMLClasses.cpp: 1490 (DOMHTMLInputElement::replaceCharactersInRange): 1491 Get the text of the input field. Replace the given range with the 1492 replacement text, and set this new string as the input element's value. 1493 Select from index to the end of the field. This matches the 1494 implementation in the Obj-C bindings. 1495 1496 2009-11-12 Jon Honeycutt <jhoneycutt (a] apple.com> 1497 1498 DOMHTMLOptionElement is missing some functionality. 1499 1500 https://bugs.webkit.org/show_bug.cgi?id=31491 1501 1502 Reviewed by Dan Bernstein. 1503 1504 * DOMHTMLClasses.cpp: 1505 (DOMHTMLOptionElement::text): 1506 Cast m_element to an HTMLOptionElement, and call its text() function. 1507 (DOMHTMLOptionElement::label): 1508 Ditto, for label(). 1509 1510 2009-11-12 Jon Honeycutt <jhoneycutt (a] apple.com> 1511 1512 DOMHTMLSelectElement is missing some implementation. 1513 1514 https://bugs.webkit.org/show_bug.cgi?id=31489 1515 1516 Reviewed by Dan Bernstein. 1517 1518 * DOMHTMLClasses.cpp: 1519 (DOMHTMLSelectElement::options): 1520 Cast m_element to an HTMLSelectElement. If it has no options, return 1521 E_FAIL. Otherwise, create a DOMHTMLOptionsCollection to wrap the 1522 options, and return it. 1523 (DOMHTMLSelectElement::activateItemAtIndex): 1524 If the index is out of bounds, return E_FAIL. Otherwise, select the 1525 item. 1526 1527 2009-11-12 Jon Honeycutt <jhoneycutt (a] apple.com> 1528 1529 DOMHTMLOptionsCollection is missing some implementation. 1530 1531 https://bugs.webkit.org/show_bug.cgi?id=31488 1532 1533 Reviewed by Dan Bernstein. 1534 1535 * DOMHTMLClasses.cpp: 1536 (DOMHTMLOptionsCollection::DOMHTMLOptionsCollection): 1537 Initialize m_collection. 1538 (DOMHTMLOptionsCollection::createInstance): 1539 Create a DOMHTMLOptionsCollection. If we fail to query for 1540 IDOMHTMLOptionsCollection, delete it, and return 0. Otherwise, return 1541 the result. 1542 (DOMHTMLOptionsCollection::length): 1543 (DOMHTMLOptionsCollection::item): 1544 Create a DOMNode for the WebCore Node. If this is 0, return E_FAIL. 1545 (DOMHTMLOptionsCollection::namedItem): 1546 Correct the signature of this function. 1547 1548 * DOMHTMLClasses.h: 1549 Declare DOMHTMLOptionsCollection::createInstance(). Correct the 1550 signature of namedItem() to match IDOMHTMLOptionsCollection. Add a 1551 member to DOMHTMLOptionsCollection to hold the WebCore object. 1552 1553 2009-11-12 Jon Honeycutt <jhoneycutt (a] apple.com> 1554 1555 DOMHTMLInputElement::rectOnScreen() returns the wrong rect 1556 1557 https://bugs.webkit.org/show_bug.cgi?id=31487 1558 1559 Reviewed by Darin Adler. 1560 1561 * DOMHTMLClasses.cpp: 1562 (DOMHTMLInputElement::rectOnScreen): 1563 Return the rect on screen, not the rect in the window. 1564 1565 2009-11-17 Brent Fulgham <bfulgham (a] webkit.org> 1566 1567 Reviewed by NOBODY - Build Fix. 1568 1569 Correct build error in Debug_Cairo target after @49705. 1570 1571 * WebKit.vcproj/WebKit.vcproj: Revise JavaScriptCore.lib 1572 dependency to have proper "_debug" suffix needed by 1573 the Debug_Cairo target. 1574 1575 2009-11-17 Brian Weinstein <bweinstein (a] apple.com> 1576 1577 Reviewed by NOBODY - Build Fix. 1578 1579 Touch files to try to fix the build. 1580 1581 * Interfaces/IWebInspector.idl: 1582 * Interfaces/WebKit.idl: 1583 * WebKit.vcproj/Interfaces.vcproj: 1584 1585 2009-11-17 Pavel Feldman <pfeldman (a] chromium.org> 1586 1587 Reviewed by Timothy Hatcher. 1588 1589 Web Inspector: Make DRT show web inspector for tests in inspector/ folder. 1590 - Updated DRT to show/close inspector for all tests under /inspector 1591 - Introduced LayoutTestController::setTimelineProfilingEnabled and 1592 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled 1593 - Removed reload on each inspector test 1594 - Renamed fast/inspector to fast/inspector-support in order not to trigger 1595 inspector for those. 1596 - Reimplemented timeline tests in order to get rid of reload there. 1597 - Moved tests that don't require harness into the fast group. 1598 1599 https://bugs.webkit.org/show_bug.cgi?id=31472 1600 1601 * Interfaces/IWebInspector.idl: 1602 * WebInspector.cpp: 1603 (WebInspector::isTimelineProfilingEnabled): 1604 (WebInspector::setTimelineProfilingEnabled): 1605 * WebInspector.h: 1606 1607 2009-11-13 Adam Roben <aroben (a] apple.com> 1608 1609 Build fix 1610 1611 * Interfaces/WebKit.idl: Touch this to force interfaces to rebuild. 1612 1613 2009-11-13 Adam Roben <aroben (a] apple.com> 1614 1615 Tell the WebFrameLoadDelegate when window objects in isolated worlds 1616 are cleared 1617 1618 Fixes <http://webkit.org/b/31124>. 1619 1620 Reviewed by Dave Hyatt. 1621 1622 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added 1623 didClearWindowObjectForFrameInScriptWorld. 1624 1625 * WebFrame.cpp: 1626 (WebFrame::dispatchDidClearWindowObjectInWorld): 1627 * WebFrame.h: 1628 Replaced windowObjectCleared with this function. If the delegate 1629 implements IWebFrameLoadDelegatePrivate2, call 1630 didClearWindowObjectForFrameInScriptWorld. Otherwise, if the passed-in 1631 world is the mainThreadNormalWorld(), call 1632 didClearWindowObjectForFrame. 1633 1634 * WebScriptWorld.cpp: 1635 (allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in 1636 existence. 1637 (WebScriptWorld::WebScriptWorld): Add ourselves to allWorlds(). 1638 (WebScriptWorld::~WebScriptWorld): Remove ourselves from allWorlds(). 1639 (WebScriptWorld::standardWorld): Added this non-COM getter for the 1640 standard world, which the COM getter now calls through to. 1641 (WebScriptWorld::findOrCreateWorld): Added. Returns the existing 1642 WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't 1643 already exist. 1644 1645 * WebScriptWorld.h: Added new standardWorld overload, made one 1646 overload of createInstance private, and added findOrCreateWorld. 1647 1648 2009-11-13 Adam Roben <aroben (a] apple.com> 1649 1650 Build fix 1651 1652 * Interfaces/WebKit.idl: Un-sort the #includes again. Apparently they 1653 are order-dependent! 1654 1655 2009-11-13 Adam Roben <aroben (a] apple.com> 1656 1657 Touch WebKit.idl to fix the Windows build 1658 1659 * Interfaces/WebKit.idl: Sorted #includes. 1660 1661 2009-11-13 Adam Roben <aroben (a] apple.com> 1662 1663 Finish replacing worldIDs with world objects 1664 1665 The only remaining use of worldIDs was in a method only used by DRT 1666 for the isolated worlds tests. 1667 1668 Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects 1669 1670 Reviewed by Mark Rowe. 1671 1672 * Interfaces/IWebFramePrivate.idl: 1673 * WebFrame.cpp: 1674 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): 1675 * WebFrame.h: 1676 Renamed from stringByEvaluatingJavaScriptInIsolatedWorld. Now takes an 1677 IWebScriptWorld instead of a worldID, so we don't need to maintain a 1678 map of worldID -> world anymore. 1679 1680 2009-11-12 Shinichiro Hamaji <hamaji (a] chromium.org> 1681 1682 Reviewed by Darin Adler. 1683 1684 externalRepresentation should take Frame as the argument 1685 https://bugs.webkit.org/show_bug.cgi?id=31393 1686 1687 No new tests as this is just a refactoring. 1688 1689 * WebFrame.cpp: 1690 (WebFrame::renderTreeAsExternalRepresentation): 1691 1692 2009-11-12 Adam Roben <aroben (a] apple.com> 1693 1694 Replace worldIDs with world objects 1695 1696 WebScriptWorld is the new object that represents a world. The only 1697 place worldID is still used is in 1698 IWebFramePrivate::stringByEvaluatingJavaScriptInIsolatedWorld, but 1699 that will change soon. 1700 1701 Part of <http://webkit.org/b/31414> Implement new SPI for dealing with 1702 user scripts/stylesheets and isolated worlds 1703 1704 Reviewed by Sam Weinig. 1705 1706 * ForEachCoClass.h: Added WebScriptWorld. 1707 1708 * Interfaces/IWebFramePrivate.idl: Replaced contextForWorldID with 1709 contextForWorld. 1710 1711 * Interfaces/IWebScriptWorld.idl: Added. 1712 1713 * Interfaces/IWebViewPrivate.idl: Changed the user script/stylesheet 1714 functions to take an IWebScriptWorld instead of a worldID. 1715 1716 * Interfaces/WebKit.idl: Added WebScriptWorld. 1717 1718 * WebFrame.cpp: 1719 (WebFrame::contextForWorld): Renamed from contextForWorldID. Now takes 1720 an IWebScriptWorld. 1721 (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): Moved the 1722 bizarre world caching/creation logic that DRT depends on here from the 1723 findWorld function in ScriptController.cpp. Updated to use 1724 ScriptController::executeScriptInWorld instead of 1725 ScriptController::executeScriptInIsolatedWorld. 1726 1727 * WebFrame.h: Replaced contextForWorldID with contextForWorld. 1728 1729 * WebScriptWorld.cpp: Added. 1730 (WebScriptWorld::WebScriptWorld): 1731 (WebScriptWorld::~WebScriptWorld): 1732 (WebScriptWorld::createInstance): 1733 (WebScriptWorld::AddRef): 1734 (WebScriptWorld::Release): 1735 (WebScriptWorld::QueryInterface): 1736 Standard COM class implementations. 1737 1738 (WebScriptWorld::standardWorld): Returns a shared instance that represents 1739 WebCore's mainThreadNormalWorld(). 1740 1741 * WebScriptWorld.h: Added. 1742 (WebScriptWorld::world): Simple getter. 1743 1744 * WebKit.vcproj/Interfaces.vcproj: Added IWebScriptWorld.idl. 1745 1746 * WebKit.vcproj/WebKit.vcproj: Added WebScriptWorld. 1747 1748 * WebKitClassFactory.cpp: Added WebScriptWorld. 1749 1750 * WebView.cpp: 1751 (WebView::addUserScriptToGroup): 1752 (WebView::addUserStyleSheetToGroup): 1753 (WebView::removeUserScriptFromGroup): 1754 (WebView::removeUserStyleSheetFromGroup): 1755 (WebView::removeUserScriptsFromGroup): 1756 (WebView::removeUserStyleSheetsFromGroup): 1757 * WebView.h: 1758 Changed these functions to take an IWebScriptWorld instead of a worldID. 1759 1760 2009-11-12 Adam Roben <aroben (a] apple.com> 1761 1762 Small clean-up in WebView's user content functions 1763 1764 Preparation for <http://webkit.org/b/31414> Implement new SPI for 1765 dealing with user scripts/stylesheets and isolated worlds 1766 1767 Reviewed by Dave Hyatt. 1768 1769 * WebView.cpp: 1770 (toString): 1771 (toKURL): 1772 Added these helper functions to convert BSTRs to WebCore types. 1773 1774 (toStringVector): 1775 (WebView::addUserScriptToGroup): 1776 (WebView::addUserStyleSheetToGroup): 1777 (WebView::removeUserScriptFromGroup): 1778 (WebView::removeUserStyleSheetFromGroup): 1779 (WebView::removeUserScriptsFromGroup): 1780 (WebView::removeUserStyleSheetsFromGroup): 1781 (WebView::removeAllUserContentFromGroup): 1782 Use the new helper functions. 1783 1784 2009-11-11 Beth Dakin <bdakin (a] apple.com> 1785 1786 Build fix. No review needed. 1787 1788 * WebKitGraphics.cpp: 1789 (WebDrawText): 1790 1791 2009-11-10 Daniel Bates <dbates (a] webkit.org> 1792 1793 Reviewed by Oliver Hunt. 1794 1795 https://bugs.webkit.org/show_bug.cgi?id=30754 1796 1797 Modified WebDropSource::QueryContinueDrag so as to not call EventHandler::dragSourceMovedTo. 1798 1799 * WebDropSource.cpp: 1800 (WebDropSource::QueryContinueDrag): Removed call to EventHandler::dragSourceMovedTo. 1801 1802 2009-11-10 Alexey Proskuryakov <ap (a] apple.com> 1803 1804 Reviewed by Dan Bernstein. 1805 1806 https://bugs.webkit.org/show_bug.cgi?id=31312 1807 Decouple authentication panel callbacks from ResourceHandle 1808 1809 * WebCoreSupport/WebFrameLoaderClient.cpp: 1810 (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): 1811 * WebURLAuthenticationChallenge.cpp: 1812 (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): 1813 (WebURLAuthenticationChallenge::sender): 1814 * WebURLAuthenticationChallengeSender.cpp: 1815 (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender): 1816 (WebURLAuthenticationChallengeSender::createInstance): 1817 (WebURLAuthenticationChallengeSender::authenticationClient): 1818 * WebURLAuthenticationChallengeSender.h: 1819 * WebURLAuthenticationChallengeSenderCFNet.cpp: 1820 (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge): 1821 (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge): 1822 (WebURLAuthenticationChallengeSender::useCredential): 1823 Adjusted for WebCore changes. 1824 1825 2009-11-10 Brian Weinstein <bweinstein (a] apple.com> 1826 1827 Reviewed by NOBODY - Build Fix. 1828 1829 Updated fillRoundedRect to take a ColorSpace argument. 1830 1831 * WebCoreSupport/WebDragClient.cpp: 1832 (WebDragClient::createDragImageForLink): 1833 1834 2009-11-08 Janne Koskinen <janne.p.koskinen (a] digia.com> 1835 1836 Reviewed by Holger Freyther. 1837 1838 ResourceRequest to be class instead of struct 1839 https://bugs.webkit.org/show_bug.cgi?id=30670 1840 1841 Started as a compilation fix for Symbian where the compiler makes a distinction between 1842 class and struct in function argument signatures. 1843 Changed forward declaration of ResourceRequest to have class in the forward 1844 declaration instead of struct. 1845 1846 * WebDownload.h: 1847 1848 2009-11-05 Adam Roben <aroben (a] apple.com> 1849 1850 Make CFDictionaryPropertyBag::createInstance return a COMPtr 1851 1852 I also cleaned up CFDictionaryPropertyBag's class declaration a little 1853 while I was at it. 1854 1855 Part of <http://webkit.org/b/25294> <rdar://problem/6803127> All 1856 WebKit/win classes should return COMPtrs from their static constructor 1857 members 1858 1859 Reviewed by Steve Falkenburg. 1860 1861 * CFDictionaryPropertyBag.cpp: 1862 (CFDictionaryPropertyBag::CFDictionaryPropertyBag): Changed to 1863 initialize m_refCount to 0. m_refCount gets increased to 1 by 1864 createInstance. 1865 (CFDictionaryPropertyBag::createInstance): Changed to return a COMPtr. 1866 1867 * CFDictionaryPropertyBag.h: 1868 - Updated copyright years 1869 - Fixed header guard to match current style 1870 - Replaced #include of CoreFoundation.h with forward-declaration of 1871 CFMutableDictionaryRef 1872 - Added #include of COMPtr.h 1873 - Fixed opening brace placement in class declaration 1874 - Made createInstance return a COMPtr 1875 - Made constructor/destructor private 1876 - Made QueryInterface and IPropertyBag functions private 1877 - Removed unnecessary parameter names and MIDL comments 1878 1879 * WebCache.cpp: 1880 (WebCache::statistics): Updated for change to 1881 CFDictionaryPropertyBag::createInstance. Now uses releaseRef to place 1882 the IPropertyBag pointers into the s array. 1883 1884 * WebCoreSupport/WebFrameLoaderClient.cpp: 1885 (WebFrameLoaderClient::dispatchDidFailToStartPlugin): 1886 * WebDatabaseManager.cpp: 1887 (WebDatabaseManager::dispatchDidModifyDatabase): 1888 * WebFrame.cpp: 1889 (WebFrame::createJavaAppletWidget): 1890 Updated for change to CFDictionaryPropertyBag::createInstance. 1891 1892 * WebHistory.cpp: Removed releaseUserInfo, which is no longer needed. 1893 That function was also doing an unnecessary call to setDictionary(0). 1894 (createUserInfoFromArray): 1895 (createUserInfoFromHistoryItem): 1896 Changed to return COMPtr. 1897 1898 (WebHistory::loadFromURL): Updated for change to 1899 CFDictionaryPropertyBag::createInstance. 1900 1901 (WebHistory::removeAllItems): Updated for change to 1902 CFDictionaryPropertyBag::createInstance, which fixed a leak! We had 1903 forgotten to call releaseUserInfo here. 1904 1905 (WebHistory::removeItem): 1906 (WebHistory::addItem): 1907 (WebHistory::visitedURL): 1908 * WebIconDatabase.cpp: 1909 (postDidAddIconNotification): 1910 Updated for change to CFDictionaryPropertyBag::createInstance. 1911 1912 * WebKitClassFactory.cpp: 1913 (releaseRefFromCreateInstance): Added this overloaded function 1914 template to abstract away the difference between createInstance 1915 functions that return a ref'd pointer and createInstance functions 1916 that return a COMPtr. 1917 (WebKitClassFactory::CreateInstance): Changed to use 1918 releaseRefFromCreateInstance. 1919 1920 2009-11-03 Brian Weinstein <bweinstein (a] apple.com> 1921 1922 Reviewed by Steve Falkenburg. 1923 1924 WebActionModifierFlagsKey should return an unsigned, because 1925 flags imply a bitmask, and that is what other classes expect from 1926 it. 1927 1928 * WebActionPropertyBag.cpp: 1929 (WebActionPropertyBag::Read): 1930 1931 2009-11-02 Eric Carlson <eric.carlson (a] apple.com> 1932 1933 Reviewed by John Sullivan and Mark Rowe. 1934 1935 <rdar://problem/7356733> Voiceover does not read correct media controller time values 1936 1937 * WebCoreLocalizedStrings.cpp: 1938 (WebCore::localizedMediaTimeDescription): 1939 1940 2009-10-29 Jon Honeycutt <jhoneycutt (a] apple.com> 1941 1942 MSAA: Accessibility of headings is not correct 1943 1944 https://bugs.webkit.org/show_bug.cgi?id=30937 1945 1946 Reviewed by Alice Liu. 1947 1948 * AccessibleBase.cpp: 1949 (AccessibleBase::get_accDescription): 1950 Call the object's descriptionForMSAA(). Moved the comment to the 1951 WebCore file. 1952 (AccessibleBase::get_accRole): 1953 If the object has a string role, return that. Otherwise, return the 1954 integer role. 1955 1956 * AccessibleBase.h: 1957 Removed description(), as this was moved to WebCore. 1958 1959 2009-10-29 Jon Honeycutt <jhoneycutt (a] apple.com> 1960 1961 MSAA: Accessibility of links is wrong 1962 1963 https://bugs.webkit.org/show_bug.cgi?id=30928 1964 1965 Reviewed by Darin Adler. 1966 1967 * AccessibleBase.cpp: 1968 (AccessibleBase::get_accState): 1969 Check whether the element is linked, instead of whether the node is an 1970 anchor, so the child "linkable" elements of anchor elements will also 1971 be "linked". 1972 (AccessibleBase::name): 1973 Return the name for MSAA. 1974 (AccessibleBase::value): 1975 Return the string value for MSAA. 1976 1977 2009-10-30 Evan Stade <estade (a] chromium.org> 1978 1979 Reviewed by David Levin. 1980 1981 Notify the chrome when the focused node has changed. 1982 https://bugs.webkit.org/show_bug.cgi?id=30832 1983 1984 Added stub implementation for new ChromeClient function. 1985 1986 * WebCoreSupport/WebChromeClient.cpp: 1987 (WebChromeClient::focusedNodeChanged): 1988 * WebCoreSupport/WebChromeClient.h: 1989 1990 2009-10-30 Roland Steiner <rolandsteiner (a] chromium.org> 1991 1992 Reviewed by Eric Seidel. 1993 1994 Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak. 1995 1996 Bug 28420 - Implement HTML5 <ruby> rendering 1997 (https://bugs.webkit.org/show_bug.cgi?id=28420) 1998 1999 No new tests (no functional change). 2000 2001 * WebKit.vcproj/WebKit.vcproj: 2002 2003 2009-10-29 Mark Rowe <mrowe (a] apple.com> 2004 2005 Rubber-stamped by Dan Bernstein. 2006 2007 <http://webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch due to changes 2008 to IWebFramePrivate vtable ordering 2009 2010 * Interfaces/IWebFramePrivate.idl: Move the newly-added method to the end of the interface so that 2011 it doesn't affect the ordering of the vtable. 2012 2013 2009-10-28 Steve Falkenburg <sfalken (a] apple.com> 2014 2015 Reviewed by Sam "Horatio" Weinig. 2016 2017 Should not generate/build COM DOM bindings 2018 https://bugs.webkit.org/show_bug.cgi?id=30880 2019 2020 * Interfaces/WebKit.idl: Remove generated interfaces. 2021 * WebKit.vcproj/InterfacesGenerated.vcproj: Removed. 2022 * WebKit.vcproj/WebKit.sln: Remove InterfacesGenerated.vcproj. 2023 * WebKit.vcproj/WebKit.submit.sln: Remove InterfacesGenerated.vcproj. 2024 * WebKit.vcproj/WebKit.vcproj: Remove generated interfaces. 2025 2026 2009-10-27 Shinichiro Hamaji <hamaji (a] chromium.org> 2027 2028 Reviewed by Darin Adler. 2029 2030 Provide a way to get counter values with layoutTestContoller 2031 https://bugs.webkit.org/show_bug.cgi?id=30555 2032 2033 * Interfaces/IWebFramePrivate.idl: 2034 * WebFrame.cpp: 2035 (WebFrame::counterValueForElementById): 2036 * WebFrame.h: 2037 2038 2009-10-28 Joe Mason <jmason (a] rim.com> 2039 2040 Reviewed by Adam Treat. 2041 2042 Call the shared FrameLoader::defaultObjectContentType instead of 2043 copying code into FrameLoaderClient::objectContentType. This causes no 2044 behavioural change. 2045 2046 * WebFrame.cpp: 2047 (WebFrame::objectContentType): 2048 2049 2009-10-28 Holger Hans Peter Freyther <zecke (a] selfish.org> 2050 2051 Speculative build-fix for WebElementPropertyBag.cpp 2052 2053 * WebElementPropertyBag.cpp: Include RenderObject.h 2054 2055 2009-10-27 Holger Hans Peter Freyther <zecke (a] selfish.org> 2056 2057 Reviewed by Simon Fraser. 2058 2059 Change HitTestResult methods to use (3d) transformation aware methods 2060 https://bugs.webkit.org/show_bug.cgi?id=27347 2061 2062 The HitTestResult::boundingBox method was removed. The 2063 RenderObject must be used directly. In contrast to the 2064 old HitTestResult::boundingBox method this code must use 2065 a (3d) transformation aware method to not run into an 2066 assert in SVGRenderBase::mapLocalToContainer. 2067 2068 * WebElementPropertyBag.cpp: 2069 (WebElementPropertyBag::Read): Replace HitTestResult::boundingBox() 2070 2071 2009-10-26 Laszlo Gombos <laszlo.1.gombos (a] nokia.com> 2072 2073 Reviewed by Darin Adler. 2074 2075 Make .rc files compile on Windows without depending on MFC headers 2076 https://bugs.webkit.org/show_bug.cgi?id=30750 2077 2078 * WebKit.vcproj/WebKit.rc: Use winresrc.h because it exists even 2079 when MFC is not installed, and is all that's needed here. 2080 2081 2009-10-26 Sam Weinig <sam (a] webkit.org> 2082 2083 Rubber-stamped by Darin Adler. 2084 2085 Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection 2086 inherit from HTMLCollection. 2087 2088 * DOMCreateInstance.cpp: 2089 2090 2009-10-25 Dan Bernstein <mitz (a] apple.com> 2091 2092 Reviewed by John Sullivan. 2093 2094 Add contextForWorldID to the IWebFramePrivate interface. 2095 2096 * Interfaces/IWebFramePrivate.idl: 2097 * WebFrame.h: 2098 2099 2009-10-25 Sam Weinig <sam (a] webkit.org> 2100 2101 Another try at fixing windows. 2102 2103 * DOMCreateInstance.cpp: 2104 2105 2009-10-25 Sam Weinig <sam (a] webkit.org> 2106 2107 Touch WebKit.idl in an effort to try and regenerate the COM bindings. 2108 2109 * Interfaces/WebKit.idl: 2110 2111 2009-10-23 Mark Rowe <mrowe (a] apple.com> 2112 2113 Build fix. Include config.h before including other files. 2114 2115 * AccessibleImage.cpp: 2116 2117 2009-10-23 Gavin Barraclough <barraclough (a] apple.com> 2118 2119 Reviewed by Geoff Garen. 2120 2121 https://bugs.webkit.org/show_bug.cgi?id=30729 2122 Provide private API to request the global context for a specific world. 2123 Used to initialize parameters on the global object. 2124 2125 * WebFrame.cpp: 2126 (WebFrame::contextForWorldID): 2127 * WebFrame.h: 2128 2129 2009-10-23 Brian Weinstein <bweinstein (a] apple.com> 2130 2131 Reviewed by John Sullivan. 2132 2133 Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it. 2134 <http://webkit.org/b/30732> and <rdar://7332018>. 2135 2136 Turns off pan-scrolling on a WebView when it is about to lose focus. 2137 2138 * WebView.cpp: 2139 (WebViewWndProc): 2140 2141 2009-10-23 Jon Honeycutt <jhoneycutt (a] apple.com> 2142 2143 MSAA: Name for image elements should use alt attribute text 2144 2145 https://bugs.webkit.org/show_bug.cgi?id=30727 2146 <rdar://problem/7328291> 2147 2148 Reviewed by Alice Liu. 2149 2150 * AccessibleBase.cpp: 2151 (AccessibleBase::createInstance): 2152 If the AccessibilityObject is an image, return an AccessibleImage. 2153 2154 * AccessibleImage.cpp: Added. 2155 (AccessibleImage::AccessibleImage): 2156 Call the base constructor. 2157 (AccessibleImage::name): 2158 If the object is not an AccessibilityRenderObject, return the base's 2159 name(). Look first for an ARIA "labeled-by" attribute, then look for an 2160 alternate text attribute. Fall back to the base's name(). 2161 2162 * AccessibleImage.h: Added. 2163 (AccessibleImage::~AccessibleImage): 2164 2165 * WebKit.vcproj/WebKit.vcproj: 2166 Add AccessibleImage to the project. 2167 2168 2009-10-23 Sam Weinig <sam (a] webkit.org> 2169 2170 Try and fix the windows build. 2171 2172 * Interfaces/WebKit.idl: 2173 2174 2009-10-22 Gavin Barraclough <barraclough (a] apple.com> 2175 2176 Reviewed by Sam Weinig & Geoff Garen. 2177 2178 https://bugs.webkit.org/show_bug.cgi?id=30696 2179 Update to incorporate support for IsolatedWorlds in JSC bindings. 2180 2181 * Interfaces/IWebFramePrivate.idl: 2182 * WebFrame.cpp: 2183 (WebFrame::globalContext): 2184 (WebFrame::windowObjectCleared): 2185 (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): 2186 * WebFrame.h: 2187 2188 2009-10-20 Fumitoshi Ukai <ukai (a] chromium.org> 2189 2190 Reviewed by David Levin. 2191 2192 Removed WebSocket runtime settings. 2193 https://bugs.webkit.org/show_bug.cgi?id=29896 2194 2195 WebSocket runtime configuration is supported by chromium/v8 only. 2196 2197 * Interfaces/IWebPreferencesPrivate.idl: 2198 * WebPreferenceKeysPrivate.h: 2199 * WebPreferences.cpp: 2200 (WebPreferences::initializeDefaultSettings): 2201 (WebPreferences::experimentalNotificationsEnabled): 2202 * WebPreferences.h: 2203 * WebView.cpp: 2204 (WebView::notifyPreferencesChanged): 2205 2206 2009-10-19 Adam Roben <aroben (a] apple.com> 2207 2208 Fix crashes/assertions when calling WebLocalizedString from multiple 2209 threads concurrently 2210 2211 Fixes <http://webkit.org/b/30534> WebLocalizedString asserts if called 2212 from multiple threads concurrently 2213 2214 Reviewed by John Sullivan. 2215 2216 * WebLocalizableStrings.cpp: 2217 (mainBundleLocStringsMutex): 2218 (frameworkLocStringsMutex): 2219 Added these new getters. 2220 2221 (findCachedString): 2222 (cacheString): 2223 Lock the relevant mutex before accessing each string map. Otherwise 2224 bad things could happen if two threads end up here at the same time. 2225 2226 2009-10-19 Adam Roben <aroben (a] apple.com> 2227 2228 Get rid of a few static initializers/exit-time destructors in 2229 WebLocalizableStrings 2230 2231 Reviewed by Dan Bernstein. 2232 2233 * WebLocalizableStrings.cpp: 2234 (mainBundleLocStrings): 2235 (frameworkLocStrings): 2236 Added these functions instead of file-scope variables. 2237 2238 (findCachedString): 2239 (cacheString): 2240 Updated to use the new functions. 2241 2242 2009-10-19 Nate Chapin <japhet (a] chromium.org> 2243 2244 Unreviewed, build fix. 2245 2246 Update call to FrameLoader::urlSelected(). 2247 2248 * WebCoreSupport/WebContextMenuClient.cpp: 2249 (WebContextMenuClient::searchWithGoogle): 2250 2251 2009-10-16 Steve Falkenburg <sfalken (a] apple.com> 2252 2253 Reviewed by Dan Bernstein. 2254 2255 https://bugs.webkit.org/show_bug.cgi?id=30456 2256 Fixes for new Debug_All Windows build configuration. 2257 2258 * WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming. 2259 2260 2009-10-16 Jon Honeycutt <jhoneycutt (a] apple.com> 2261 2262 Add SPI to determine whether a plug-in has ever been halted. 2263 2264 Part of <rdar://problem/7312158>. 2265 2266 Reviewed by Dan Bernstein. 2267 2268 * Interfaces/IWebViewPrivate.idl: 2269 Add hasPluginForNodeBeenHalted(). 2270 2271 * WebView.cpp: 2272 (pluginViewForNode): 2273 Code factored out of isNodeHaltedPlugin(). 2274 (WebView::isNodeHaltedPlugin): 2275 Remove STDMETHODCALLTYPE, as it has no use at the definition. Use 2276 pluginViewForNode(). 2277 (WebView::restartHaltedPluginForNode): 2278 Ditto. 2279 (WebView::hasPluginForNodeBeenHalted): 2280 Get the PluginView for the given node. Return the result of 2281 PluginView::hasBeenHalted(). 2282 2283 * WebView.h: 2284 Declare hasPluginForNodeBeenHalted(). 2285 2286 2009-10-16 Steve Falkenburg <sfalken (a] apple.com> 2287 2288 Reviewed by Adam Roben. 2289 2290 Add a Debug_All configuration to build entire stack as debug. 2291 Change Debug_Internal to: 2292 - stop using _debug suffix for all WebKit/Safari binaries 2293 - not use _debug as a DLL naming suffix 2294 - use non-debug C runtime lib. 2295 2296 * WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all". 2297 * WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All. 2298 * WebKit.vcproj/WebKit.sln: Add Debug_All configuration. 2299 * WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration. 2300 * WebKit.vcproj/WebKit.vcproj: 2301 Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo. 2302 Add Debug_All configuration. 2303 * WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration. 2304 2305 2009-10-15 Jon Honeycutt <jhoneycutt (a] apple.com> 2306 2307 Add SPI to restart a halted plug-in. 2308 2309 Part of <rdar://problem/7273354> Halted plug-ins should restart on 2310 mouseover 2311 2312 https://bugs.webkit.org/show_bug.cgi?id=30151 2313 2314 Reviewed by Kevin Decker. 2315 2316 * Interfaces/IWebViewPrivate.idl: 2317 Add restartHaltedPluginForNode(). 2318 2319 * WebView.cpp: 2320 (WebView::restartHaltedPluginForNode): 2321 From the IDOMNode, query for the DOMNode. From the DOMNode, get the 2322 WebCore::Node. Get the node's renderer, and check whether it is a 2323 RenderWidget. If so, get its Widget, and check whether it's a 2324 PluginView. If so, call PluginView::restart(). 2325 2326 * WebView.h: 2327 Declare restartHaltedPluginForNode(). 2328 2329 2009-10-14 Jon Honeycutt <jhoneycutt (a] apple.com> 2330 2331 Add SPI to determine whether a node is a halted plug-in. 2332 2333 Part of <rdar://problem/7273354> Halted plug-ins should restart on 2334 mouseover 2335 2336 https://bugs.webkit.org/show_bug.cgi?id=30151 2337 2338 Reviewed by Darin Adler. 2339 2340 * Interfaces/IWebViewPrivate.idl: 2341 Add isNodehaltedPlugin(). 2342 2343 * WebView.cpp: 2344 (WebView::isNodeHaltedPlugin): 2345 From the IDOMNode, query for the DOMNode. From the DOMNode, get the 2346 WebCore::Node. Get the node's renderer, and check whether it is a 2347 RenderWidget. If so, get its Widget, and check whether it's a 2348 PluginView. If so, return the result of PluginView::isHalted(). 2349 2350 * WebView.h: 2351 Declare isNodeHaltedPlugin(). 2352 2353 2009-10-15 Daniel Bates <dbates (a] webkit.org> 2354 2355 Reviewed by Adam Roben. 2356 2357 https://bugs.webkit.org/show_bug.cgi?id=24731 2358 And 2359 rdar://problem/5015961 2360 2361 Implements support for DHTML drag-and-drop operations (i.e. ondragstart, ondragend) 2362 in the Windows build so that it conforms to the Mac OS X build. Hence, dropEffect is 2363 correctly set. 2364 2365 The WebView and WebDropSource drag-and-drop functions, as called by function 2366 DoDragDrop in its event loop, neither used the drop effect as specified by 2367 event.dataTransfer.dropEffect nor respected event.dataTransfer.effectsAllowed. 2368 Instead, these functions defaulted to some hardcoded drop effect and set of 2369 allowed drop effects, respectively. 2370 2371 Tests: fast/events/drag-and-drop.html 2372 2373 * WebCoreSupport/WebDragClient.cpp: 2374 (WebDragClient::startDrag): 2375 * WebDropSource.cpp: 2376 (WebDropSource::QueryContinueDrag): Moved call to EventHandler::dragSourceEndedAt 2377 into method WebDragClient::startDrag. 2378 * WebDropSource.h: 2379 * WebView.cpp: 2380 (WebView::keyStateToDragOperation): Fixes <rdar://problem/5015961>. Determines 2381 appropriate drop effect from state of keyboard and allowed effects 2382 m_page->dragController()->sourceDragOperation(). 2383 (WebView::DragEnter): 2384 (WebView::DragOver): 2385 (WebView::Drop): 2386 * WebView.h: 2387 2388 2009-10-14 Adam Roben <aroben (a] apple.com> 2389 2390 Windows build fix 2391 2392 * WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and 2393 IWebNavigationData from the build (they get #imported via WebKit.idl). 2394 2395 2009-10-14 Brady Eidson <beidson (a] apple.com> 2396 2397 Reviewed by Sam Weinig. 2398 2399 WebKit Win API should provide a delegate interface for global history. 2400 https://bugs.webkit.org/show_bug.cgi?id=29905 2401 2402 -Add IWebHistoryDelegate for clients to implement. 2403 -Add (I)WebNavigationData for the history delegate's use. 2404 -When it exists, call the history delegate instead of using WebHistory. 2405 2406 * Interfaces/IWebHistoryDelegate.idl: Added. 2407 * Interfaces/IWebHistoryPrivate.idl: 2408 * Interfaces/IWebNavigationData.idl: Added. 2409 * Interfaces/IWebViewPrivate.idl: 2410 * Interfaces/WebKit.idl: 2411 2412 * WebKit.vcproj/Interfaces.vcproj: 2413 * WebKit.vcproj/WebKit.vcproj: 2414 2415 * WebCoreSupport/WebChromeClient.cpp: 2416 (WebChromeClient::populateVisitedLinks): 2417 * WebCoreSupport/WebFrameLoaderClient.cpp: 2418 (WebFrameLoaderClient::updateGlobalHistory): 2419 (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): 2420 (WebFrameLoaderClient::setTitle): 2421 2422 * WebView.cpp: 2423 (WebView::close): 2424 (WebView::mainFrameURL): 2425 (WebView::setHistoryDelegate): 2426 (WebView::historyDelegate): 2427 (WebView::addVisitedLinks): 2428 * WebView.h: 2429 2430 * WebHistory.cpp: 2431 (WebHistory::setVisitedLinkTrackingEnabled): 2432 (WebHistory::removeAllVisitedLinks): 2433 * WebHistory.h: 2434 2435 * WebNavigationData.cpp: Added. 2436 (WebNavigationData::QueryInterface): 2437 (WebNavigationData::AddRef): 2438 (WebNavigationData::Release): 2439 (WebNavigationData::WebNavigationData): 2440 (WebNavigationData::~WebNavigationData): 2441 (WebNavigationData::createInstance): 2442 (WebNavigationData::url): 2443 (WebNavigationData::title): 2444 (WebNavigationData::originalRequest): 2445 (WebNavigationData::response): 2446 (WebNavigationData::hasSubstituteData): 2447 (WebNavigationData::clientRedirectSource): 2448 * WebNavigationData.h: Added. 2449 2450 2009-10-13 Dave Hyatt <hyatt (a] apple.com> 2451 2452 Fix more WebView bustage. 2453 2454 * WebView.cpp: 2455 (WebView::addUserScriptToGroup): 2456 (WebView::addUserStyleSheetToGroup): 2457 (WebView::removeUserScriptsFromGroup): 2458 (WebView::removeUserStyleSheetsFromGroup): 2459 2460 2009-10-13 Dave Hyatt <hyatt (a] apple.com> 2461 2462 Fix build bustage on Windows. 2463 2464 * WebView.cpp: 2465 (WebView::addUserScriptToGroup): 2466 (WebView::addUserStyleSheetToGroup): 2467 (WebView::removeUserScriptsFromGroup): 2468 (WebView::removeUserStyleSheetsFromGroup): 2469 2470 2009-10-13 Dave Hyatt <hyatt (a] apple.com> 2471 2472 Reviewed by Adam Roben.. 2473 2474 Split removal functions for user scripts and stylehseets based on type. 2475 2476 * Interfaces/IWebViewPrivate.idl: 2477 * WebView.cpp: 2478 (WebView::removeUserScriptFromGroup): 2479 (WebView::removeUserStyleSheetFromGroup): 2480 * WebView.h: 2481 2482 2009-10-09 Adam Barth <abarth (a] webkit.org> 2483 2484 Reviewed by Darin Adler. 2485 2486 Factor HistoryController out of FrameLoader 2487 https://bugs.webkit.org/show_bug.cgi?id=30246 2488 2489 Update API call. 2490 2491 * WebView.cpp: 2492 (WebView::loadBackForwardListFromOtherView): 2493 2494 2009-10-08 Jon Honeycutt <jhoneycutt (a] apple.com> 2495 2496 Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking 2497 for the existence of a PluginHalterDelegate. 2498 2499 Reviewed by Dan Bernstein. 2500 2501 * Interfaces/IWebPreferencesPrivate.idl: 2502 Remove the getter and setter. 2503 2504 * WebCoreSupport/WebPluginHalterClient.cpp: 2505 (WebPluginHalterClient::enabled): 2506 Return true if the delegate exists. 2507 2508 * WebCoreSupport/WebPluginHalterClient.h: 2509 Declare implementation of enabled(). 2510 2511 * WebPreferenceKeysPrivate.h: 2512 Removed the pref key. 2513 2514 * WebPreferences.cpp: 2515 (WebPreferences::initializeDefaultSettings): 2516 Removed initialization of the pref. 2517 2518 * WebPreferences.h: 2519 Removed declaration of the getter/setter. 2520 2521 * WebView.cpp: 2522 (WebView::notifyPreferencesChanged): 2523 Don't propagate the pref. 2524 2525 2009-10-08 Adam Barth <abarth (a] webkit.org> 2526 2527 Reviewed by Eric Seidel. 2528 2529 Move executeScript from FrameLoader to ScriptController 2530 https://bugs.webkit.org/show_bug.cgi?id=30200 2531 2532 Update API call. 2533 2534 * WebView.cpp: 2535 (WebView::stringByEvaluatingJavaScriptFromString): 2536 2537 2009-10-08 Anders Carlsson <andersca (a] apple.com> 2538 2539 Reviewed by Sam Weinig. 2540 2541 Remove the shouldLoadMediaElementURL implementation. 2542 2543 * Interfaces/IWebPolicyDelegatePrivate.idl: 2544 * WebCoreSupport/WebFrameLoaderClient.cpp: 2545 (WebFrameLoaderClient::shouldUsePluginDocument): 2546 * WebCoreSupport/WebFrameLoaderClient.h: 2547 2548 2009-10-08 Adam Roben <aroben (a] apple.com> 2549 2550 Make IWebInspectorPrivate be accessed in a more standard way 2551 2552 IWebViewPrivate::inspectorPrivate has been removed. Callers should 2553 instead use IWebViewPrivate::inspector and then use QueryInterface to 2554 get the IWebInspectorPrivate interface. This matches how our other COM 2555 classes work. 2556 2557 Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be 2558 accessed in a more standard way 2559 2560 Reviewed by John Sullivan and Tim Hatcher. 2561 2562 * Interfaces/IWebViewPrivate.idl: Removed inspectorPrivate. 2563 2564 * WebInspector.cpp: 2565 (WebInspector::QueryInterface): Support querying to 2566 IWebInspectorPrivate. 2567 2568 * WebView.cpp: 2569 * WebView.h: 2570 Removed inspectorPrivate. 2571 2572 2009-10-08 Adam Roben <aroben (a] apple.com> 2573 2574 Move the new IWebViewPrivate::inspectorPrivate function after all 2575 functions that existed when Safari 4.0.3 was released 2576 2577 Fixes <http://webkit.org/b/30085> REGRESSION (r49091): run-safari 2578 crashes in Safari.dll 2579 2580 Reviewed by John Sullivan. 2581 2582 * Interfaces/IWebViewPrivate.idl: Moved inspectorPrivate to the end of 2583 the interface, so it won't modify the vtable that Safari 4.0.3 sees. 2584 2585 2009-10-07 Adam Roben <aroben (a] apple.com> 2586 2587 Expose origin whitelisting in the WebKit API on Windows 2588 2589 Fixes <http://webkit.org/b/30185>. 2590 2591 Reviewed by Eric Seidel. 2592 2593 * Interfaces/IWebViewPrivate.idl: Added whiteListAccessFromOrigin and 2594 resetOriginAccessWhiteLists, to match the Mac SPI. 2595 2596 * WebView.cpp: 2597 (WebView::whiteListAccessFromOrigin): 2598 (WebView::resetOriginAccessWhiteLists): 2599 * WebView.h: 2600 Added. These just call through to SecurityOrigin. 2601 2602 2009-10-07 Adam Barth <abarth (a] webkit.org> 2603 2604 Reviewed by Darin Adler. 2605 2606 Factor PolicyChecker out of FrameLoader 2607 https://bugs.webkit.org/show_bug.cgi?id=30155 2608 2609 Move the policy callback to the policy object. 2610 2611 * WebFrame.cpp: 2612 (WebFrame::dispatchWillSubmitForm): 2613 (WebFrame::receivedPolicyDecision): 2614 (WebFrame::dispatchDecidePolicyForMIMEType): 2615 (WebFrame::dispatchDecidePolicyForNewWindowAction): 2616 (WebFrame::dispatchDecidePolicyForNavigationAction): 2617 2618 2009-10-07 Daniel Bates <dbates (a] webkit.org> 2619 2620 Reviewed by Darin Adler. 2621 2622 https://bugs.webkit.org/show_bug.cgi?id=30102 2623 And 2624 <rdar://problem/5015957> 2625 2626 Fixes an issue (in the Windows build) where the cursor does not change to the 2627 not-allowed cursor when the drag-and-drop operation is not allowed. 2628 2629 The allowed effects in WebDragClient::startDrag are hard-coded to be 2630 DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of 2631 allowed drop effects should be determined by the allowed operations of the 2632 drag source. 2633 2634 We cannot test this using DRT because DRT looks at the programmatic drop 2635 cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy. 2636 That is, there is a discrepancy in the Windows build between the Windows API-based 2637 drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer 2638 to determine the cursor, a manual test is needed. 2639 2640 * WebCoreSupport/WebDragClient.cpp: 2641 (draggingSourceOperationMaskToDragCursors): Added method. 2642 (WebDragClient::startDrag): 2643 2644 2009-10-07 Steve Falkenburg <sfalken (a] apple.com> 2645 2646 Reviewed by Darin Adler. 2647 2648 https://bugs.webkit.org/show_bug.cgi?id=30176 2649 <rdar://problem/7281553> Extra information in UA causes problems with gmail 2650 2651 * WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space. 2652 2653 2009-10-06 Pavel Feldman <pfeldman (a] chromium.org> 2654 2655 Reviewed by Timothy Hatcher. 2656 2657 Web Inspector: default to an attached inspector window on Windows (as on Mac). 2658 2659 https://bugs.webkit.org/show_bug.cgi?id=30134 2660 2661 * WebCoreSupport/WebInspectorClient.cpp: 2662 (WebInspectorClient::showWindowWithoutNotifications): 2663 2664 2009-10-06 Adam Barth <abarth (a] webkit.org> 2665 2666 Reviewed by Eric Seidel. 2667 2668 Move FrameLoader::canLoad to SecurityOrigin 2669 https://bugs.webkit.org/show_bug.cgi?id=30111 2670 2671 * WebFrame.cpp: 2672 (WebFrame::allowsFollowingLink): 2673 2674 2009-10-06 Pavel Feldman <pfeldman (a] chromium.org> 2675 2676 Reviewed by Timothy Hatcher. 2677 2678 Web Inspector: close inspector client view on 2679 InspectorController::close API call. 2680 2681 In order to run batch web inspector layout tests (and not affect 2682 subsequent tests) we should close inspector client's view upon 2683 InspectorController::close API call. 2684 2685 https://bugs.webkit.org/show_bug.cgi?id=30009 2686 2687 * WebCoreSupport/WebInspectorClient.cpp: 2688 (WebInspectorClient::createPage): 2689 2690 2009-10-06 David Levin <levin (a] chromium.org> 2691 2692 Reviewed by NOBODY (windows build fix). 2693 2694 Speculative build fix for windows (due to r49160). 2695 2696 * WebDownloadCFNet.cpp: 2697 (WebDownload::initToResumeWithBundle): 2698 * WebIconDatabase.cpp: 2699 (WebIconDatabase::dispatchDidAddIconForPageURL): 2700 2701 2009-10-05 Pavel Feldman <pfeldman (a] chromium.org> 2702 2703 Reviewed by Timothy Hatcher. 2704 2705 Web Inspector: add testing harness for Web Inspector. 2706 2707 https://bugs.webkit.org/show_bug.cgi?id=30010 2708 2709 * Interfaces/IWebInspectorPrivate.idl: Added. 2710 * Interfaces/IWebViewPrivate.idl: 2711 * Interfaces/WebKit.idl: 2712 * WebInspector.cpp: 2713 (WebInspector::evaluateInFrontend): 2714 * WebInspector.h: 2715 * WebView.cpp: 2716 (WebView::inspectorPrivate): 2717 * WebView.h: 2718 2719 2009-10-02 Dave Hyatt <hyatt (a] apple.com> 2720 2721 Reviewed by Adam Roben. 2722 2723 Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns. 2724 2725 * Interfaces/IWebViewPrivate.idl: 2726 * WebView.cpp: 2727 (toStringVector): 2728 (WebView::addUserScriptToGroup): 2729 (WebView::addUserStyleSheetToGroup): 2730 * WebView.h: 2731 2732 2009-10-02 Steve Falkenburg <sfalken (a] apple.com> 2733 2734 Reviewed by Mark Rowe. 2735 2736 <https://bugs.webkit.org/show_bug.cgi?id=29989> 2737 Safari version number shouldn't be exposed in WebKit code 2738 2739 For a WebKit version of 532.3.4: 2740 Product version is: 5.32.3.4 (was 4.0.3.0) 2741 File version is: 5.32.3.4 (was 4.532.3.4) 2742 2743 * WebKit.vcproj/WebKit.rc: 2744 2745 2009-09-30 Sam Weinig <sam (a] webkit.org> 2746 2747 Reviewed by Dan Bernstein. 2748 2749 Fix for <rdar://problem/7259706> 2750 Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window 2751 2752 * Interfaces/IWebFramePrivate.idl: 2753 * WebFrame.cpp: 2754 (WebFrame::allowsFollowingLink): 2755 * WebFrame.h: 2756 2757 2009-09-30 Dave Hyatt <hyatt (a] apple.com> 2758 2759 Reviewed by Adam Roben. 2760 2761 Add the ability to remove user stylesheets and scripts by URL. 2762 2763 * Interfaces/IWebViewPrivate.idl: 2764 * WebView.cpp: 2765 (WebView::removeUserContentWithURLFromGroup): 2766 * WebView.h: 2767 2768 2009-09-29 Kenneth Russell <kbr (a] google.com> 2769 2770 Reviewed by Dimitri Glazkov. 2771 2772 Add support for run-time flag for 3D canvas 2773 https://bugs.webkit.org/show_bug.cgi?id=29826 2774 2775 * WebView.cpp: 2776 (WebView::notifyPreferencesChanged): Enable experimental WebGL 2777 flag when 3D_CANVAS is enabled in the build. 2778 2779 2009-09-28 Alexey Proskuryakov <ap (a] apple.com> 2780 2781 Reviewed by Darin Adler and Sam Weinig. 2782 2783 Onclick not fired for an element copied with cloneContents() or cloneNode() 2784 https://bugs.webkit.org/show_bug.cgi?id=25130 2785 2786 * DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now. 2787 2788 * WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp. 2789 2790 2009-09-28 Fumitoshi Ukai <ukai (a] chromium.org> 2791 2792 Reviewed by Eric Seidel. 2793 2794 Add experimentalWebSocketsEnabled in WebPreferences. 2795 https://bugs.webkit.org/show_bug.cgi?id=28941 2796 2797 * Interfaces/IWebPreferencesPrivate.idl: 2798 * WebPreferenceKeysPrivate.h: 2799 * WebPreferences.cpp: 2800 (WebPreferences::initializeDefaultSettings): 2801 (WebPreferences::setExperimentalWebSocketsEnabled): 2802 (WebPreferences::experimentalWebSocketsEnabled): 2803 * WebPreferences.h: 2804 * WebView.cpp: 2805 (WebView::notifyPreferencesChanged): 2806 (core): 2807 2808 2009-09-25 Darin Adler <darin (a] apple.com> 2809 2810 Reviewed by Steve Falkenburg. 2811 2812 Speed up access to history items by caching date computation. 2813 2814 * History/WebHistory.mm: 2815 (getDayBoundaries): Refactored from timeIntervalForBeginningOfDay. 2816 Returns the beginning of the day that the passed time is within and 2817 the beginning of the next day. 2818 (beginningOfDay): Added. Uses getDayBoundaries so it can be fast for 2819 multiple dates within the same day, which is the common case. 2820 (dateKey): Added. Calls beginningOfDay and converts to an integer. 2821 (WebHistory::findKey): Changed to call dateKey instead of 2822 timeIntervalForBeginningOfDay. 2823 2824 2009-09-25 Adam Roben <aroben (a] apple.com> 2825 2826 Add SPI to invalidate a WebView's backing store 2827 2828 This is useful in conjunction with 2829 IWebUIDelegatePrivate2::drawBackground. This provides a way for the UI 2830 delegate to force WebView to get its background redrawn. 2831 2832 Fixes <http://webkit.org/b/29737> Need SPI to invalidate a WebView's 2833 backing store 2834 2835 Reviewed by Anders Carlsson. 2836 2837 * Interfaces/IWebViewPrivate.idl: Added invalidateBackingStore. 2838 * WebView.cpp: 2839 (WebView::invalidateBackingStore): If rect is 0, invalidate our whole 2840 client rect. Otherwise invalidate the intersection of rect with our 2841 client rect. 2842 * WebView.h: 2843 2844 2009-09-24 Jon Honeycutt <jhoneycutt (a] apple.com> 2845 2846 Add a mechanism for automatically halting plug-ins. 2847 2848 Reviewed by Oliver Hunt. 2849 2850 * Interfaces/IWebPluginHalterDelegate.idl: Added. Defines an interface 2851 for a delegate that determines whether plug-ins should be halted. 2852 2853 * Interfaces/IWebPreferencesPrivate.idl: 2854 Declare functions to get and set the enabled state of the plug-in 2855 halter and the plug-in allowed run time. 2856 2857 * Interfaces/IWebViewPrivate.idl: 2858 Declare functions to get and set the IWebPluginHalterDelegate. 2859 2860 * Interfaces/WebKit.idl: 2861 2862 * WebCoreSupport/WebPluginHalterClient.cpp: Added. 2863 (WebPluginHalterClient::WebPluginHalterClient): 2864 (WebPluginHalterClient::shouldHaltPlugin): 2865 Get the IWebPluginHalterDelegate for the WebView. Create a WebKit 2866 DOMNode for the WebCore Node. Call the delegate's shouldHaltPlugin(). 2867 If the call fails, return false. Otherwise, return the result of the 2868 call. 2869 2870 * WebCoreSupport/WebPluginHalterClient.h: Added. 2871 2872 * WebKit.vcproj/Interfaces.vcproj: 2873 Add IWebPluginHalterDelegate.idl. 2874 2875 * WebKit.vcproj/WebKit.vcproj: 2876 Add WebPluginHalterClient.{h,cpp}. 2877 2878 * WebPreferenceKeysPrivate.h: 2879 Define WebKitPluginHalterEnabledPreferenceKey and 2880 WebKitPluginAllowedRunTimePreferenceKey. 2881 2882 * WebPreferences.cpp: 2883 (WebPreferences::initializeDefaultSettings): 2884 Leave plug-in halting disabled by default. Set the default value for 2885 the plug-in allowed run time to the max value of an unsigned int. 2886 (WebPreferences::setPluginHalterEnabled): 2887 (WebPreferences::pluginHalterEnabled): 2888 (WebPreferences::setPluginAllowedRunTime): 2889 (WebPreferences::pluginAllowedRunTime): 2890 2891 * WebPreferences.h: 2892 2893 * WebView.cpp: 2894 (WebView::close): 2895 Clear the IWebPluginHalterDelegate. 2896 (WebView::initWithFrame): 2897 Pass a WebPluginHalterClient when creating the Page. 2898 (WebView::notifyPreferencesChanged): 2899 Set the new settings when the preferences changed notification is 2900 received. 2901 (WebView::setPluginHalterDelegate): 2902 (WebView::pluginHalterDelegate): 2903 2904 * WebView.h: 2905 Declare overrides of setPluginHalterDelegate() and 2906 pluginHalterDelegate(). Added a member to track the 2907 IWebPluginHalterDelegate. 2908 2909 2009-09-14 John Gregg <johnnyg (a] google.com> 2910 2911 Reviewed by Eric Seidel. 2912 2913 Enable switch for notifications (experimental) in Page Settings 2914 https://bugs.webkit.org/show_bug.cgi?id=28930 2915 2916 Adds support for the experimentalNotificationsEnabled flag in Settings through 2917 WebPreferencesPrivate interface. Also cleans up some issues accessing the 2918 notification delegate through DumpRenderTree. 2919 2920 * Interfaces/IWebPreferencesPrivate.idl: 2921 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: 2922 (WebDesktopNotificationsDelegate::hasNotificationDelegate): 2923 (WebDesktopNotificationsDelegate::notificationDelegate): 2924 * WebPreferenceKeysPrivate.h: 2925 * WebPreferences.cpp: 2926 (WebPreferences::initializeDefaultSettings): 2927 (WebPreferences::setExperimentalNotificationsEnabled): 2928 (WebPreferences::experimentalNotificationsEnabled): 2929 * WebPreferences.h: 2930 * WebView.cpp: 2931 (WebView::notifyPreferencesChanged): 2932 2933 2009-09-23 Anders Carlsson <andersca (a] apple.com> 2934 2935 Reviewed by Adam Roben. 2936 2937 <rdar://problem/7243354> 2938 REGRESSION(48580-48636): Crash clicking embedded QT preview button on apple.com/trailers 2939 2940 Check for a null IWebPolicyDelegatePrivate. 2941 2942 * WebCoreSupport/WebFrameLoaderClient.cpp: 2943 (WebFrameLoaderClient::shouldLoadMediaElementURL): 2944 2945 2009-09-22 Sam Weinig <sam (a] webkit.org> 2946 2947 Rubber-stamped by Adam Roben. 2948 2949 Remove accidentally left in declaration of reloadFromOrigin in IWebFramePrivate.idl 2950 2951 * Interfaces/IWebFramePrivate.idl: 2952 2953 2009-09-22 Sam Weinig <sam (a] webkit.org> 2954 2955 Reviewed by Steve Falkenburg. 2956 2957 Fix for <rdar://problem/6451745> 2958 Windows WebKit needs to implement reloadFromOrigin() 2959 2960 * Interfaces/IWebFrame.idl: 2961 * Interfaces/IWebFramePrivate.idl: 2962 * Interfaces/IWebView.idl: 2963 * WebFrame.cpp: 2964 (WebFrame::reloadFromOrigin): 2965 * WebFrame.h: 2966 * WebView.cpp: 2967 (WebView::reloadFromOrigin): 2968 * WebView.h: 2969 2970 2009-09-22 Adam Roben <aroben (a] apple.com> 2971 2972 Manage refcounts correctly in DefaultDownloadDelegate::willSendRequest 2973 2974 Fixes <http://webkit.org/b/29650> Crash in 2975 WebDownload::willSendRequest when using DefaultDownloadDelegate 2976 2977 Reviewed by Brady Eidson. 2978 2979 * DefaultDownloadDelegate.cpp: 2980 (DefaultDownloadDelegate::willSendRequest): Call AddRef() on the 2981 object we're returning via the finalRequest out-parameter. 2982 2983 2009-09-21 Anders Carlsson <andersca (a] apple.com> 2984 2985 Reviewed by Adam Roben. 2986 2987 <rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource 2988 2989 Implement WebFrameLoaderClient::shouldLoadMediaElementURL and have it call the new private policy 2990 delegate method. 2991 2992 * Interfaces/IWebPolicyDelegatePrivate.idl: Added. 2993 * Interfaces/WebKit.idl: 2994 * WebCoreSupport/WebFrameLoaderClient.cpp: 2995 (WebFrameLoaderClient::shouldLoadMediaElementURL): 2996 * WebCoreSupport/WebFrameLoaderClient.h: 2997 * WebKit.vcproj/Interfaces.vcproj: 2998 2999 2009-09-17 Kenneth Rohde Christiansen <kenneth (a] webkit.org> 3000 3001 Reviewed by Simon Hausmann. 3002 3003 Make PlatformWindow return something else than PlatformWidget 3004 https://bugs.webkit.org/show_bug.cgi?id=29085 3005 3006 Reflect the rename of platformWindow and it's return type. 3007 3008 * AccessibleBase.cpp: 3009 (AccessibleBase::get_accParent): 3010 * WebCoreSupport/WebChromeClient.cpp: 3011 (WebChromeClient::platformPageClient): 3012 * WebCoreSupport/WebChromeClient.h: 3013 3014 2009-09-17 Brian Weinstein <bweinstein (a] apple.com> 3015 3016 Reviewed by Adam Roben. 3017 3018 Remove assertions that were being hit by calls to 3019 m_verticalScrollbar->invalidate(). These assertions were valid, 3020 but they were causing tests to fail, so replacing with a FIXME 3021 until we can find out the real cause/solution that is being tracked 3022 by http://webkit.org/b/29350. 3023 3024 * WebView.cpp: 3025 (WebView::addToDirtyRegion): 3026 (WebView::paintIntoBackingStore): 3027 3028 2009-09-17 Ada Chan <adachan (a] apple.com> 3029 3030 Post WebViewDidChangeSelectionNotification when the text selection changes. 3031 3032 Fixes <http://webkit.org/b/29321> 3033 3034 Reviewed by Adam Roben. 3035 3036 * Interfaces/IWebView.idl: 3037 * WebCoreSupport/WebEditorClient.cpp: 3038 (WebEditorClient::respondToChangedSelection): 3039 3040 2009-09-17 Adam Roben <aroben (a] apple.com> 3041 3042 Fix a crash when a WebView's HWND is destroyed before IWebView::close 3043 is called 3044 3045 WebView's HWND was being sent a WM_TIMER message after the WebView was 3046 destroyed. This normally isn't possible (we call DestroyWindow inside 3047 WebView's destructor to ensure the HWND doesn't outlive the WebView), 3048 but r48060 changed WebView to call SetParent(m_viewWindow, 3049 HWND_MESSAGE) while handling WM_DESTROY, and apparently this puts the 3050 HWND into some weird half-destroyed state where it can still receive 3051 WM_TIMER messages. 3052 3053 Fixes <http://webkit.org/b/29337> <rdar://problem/7209897> REGRESSION 3054 (r48060): unrepro but frequent crash in WebViewWndProc 3055 3056 Reviewed by Steve Falkenburg. 3057 3058 * WebView.cpp: 3059 (WebViewWndProc): When handling WM_DESTROY, call setIsBeingDestroyed() 3060 before calling close(). This allows setHostWindow to detect that we're 3061 handling WM_DESTROY. No other code in close() cared whether 3062 isBeingDestroyed() was true or not. 3063 (WebView::setHostWindow): If our host window is being set to 0 and 3064 we're being destroyed, don't become a message-only window. Doing this 3065 while handling WM_DESTROY seems to lead to crashes. 3066 3067 2009-09-16 Adam Roben <aroben (a] apple.com> 3068 3069 Add a UI delegate callback to let the delegate draw a WebView's 3070 background 3071 3072 Fixes <http://webkit.org/b/29315>. 3073 3074 Reviewed by Dave Hyatt. 3075 3076 * Interfaces/IWebUIDelegatePrivate.idl: Added 3077 IWebUIDelegatePrivate2::drawBackground. 3078 3079 * WebView.cpp: 3080 (WebView::paintIntoBackingStore): After clearing or filling with 3081 white, let the delegate draw whatever background it wants. Also added 3082 an assertion that the dirty rect is within our bounds. 3083 3084 2009-09-16 Adam Roben <aroben (a] apple.com> 3085 3086 Prevent WebView from painting over sibling windows 3087 3088 Fixes <http://webkit.org/b/29300> <rdar://problem/7227960> WebView can 3089 paint over sibling windows 3090 3091 Reviewed by Darin Adler. 3092 3093 * WebView.cpp: 3094 (WebView::initWithFrame): Create the WebView's HWND with the 3095 WS_CLIPSIBLINGS style. 3096 3097 2009-09-14 Brady Eidson <beidson (a] apple.com> 3098 3099 Reviewed by Alexey Proskuryakov. 3100 3101 Safari 4 cannot be used to update firmware on Linksys routers. 3102 <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160 3103 3104 Adopt the new WebCore::CredentialStorage in WebKit/Win. 3105 3106 * WebDownloadCFNet.cpp: 3107 (WebDownload::didReceiveAuthenticationChallenge): 3108 3109 2009-09-11 Steve Falkenburg <sfalken (a] apple.com> 3110 3111 Reviewed by Dan Bernstein. 3112 3113 Properly propagate preference from WebPreferences to WebCore::Settings. 3114 https://bugs.webkit.org/show_bug.cgi?id=29192 3115 3116 * WebView.cpp: 3117 (WebView::initWithFrame): Apply setting when creating a new WebView. 3118 (WebView::notifyPreferencesChanged): Apply setting when preferences change. 3119 3120 2009-09-11 Steve Falkenburg <sfalken (a] apple.com> 3121 3122 Reviewed by Darin Adler. 3123 3124 Allow WebKit clients to opt out of high resolution timers on Windows. 3125 https://bugs.webkit.org/show_bug.cgi?id=29192 3126 3127 * Interfaces/IWebPreferencesPrivate.idl: Added getter/setter. 3128 Put this just after last 4.0.3 method for future merging. 3129 * Interfaces/WebKit.idl: Touched to force a rebuild. 3130 * WebPreferenceKeysPrivate.h: Added prefs key for high res timers. 3131 * WebPreferences.cpp: 3132 (WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled. 3133 (WebPreferences::setShouldUseHighResolutionTimers): Added. 3134 (WebPreferences::shouldUseHighResolutionTimers): Added. 3135 * WebPreferences.h: Added getter/setter. 3136 3137 2009-09-11 Adam Roben <aroben (a] apple.com> 3138 3139 Get user script/stylesheet tests running on Windows 3140 3141 Fixes <http://webkit.org/b/29181> User script/stylesheet tests are 3142 skipped on Windows 3143 3144 Reviewed by John Sullivan. 3145 3146 * Interfaces/IWebViewPrivate.idl: Added addUserScriptToGroup, 3147 addUserStyleSheetToGroup, removeUserContentFromGroup, 3148 removeAllUserContentFromGropu to match the Mac SPI. 3149 3150 * WebView.cpp: 3151 (WebView::addUserScriptToGroup): 3152 (WebView::addUserStyleSheetToGroup): 3153 (WebView::removeUserContentFromGroup): 3154 (WebView::removeAllUserContentFromGroup): 3155 * WebView.h: 3156 Added. Implementation was based on similar methods in WebView.mm. 3157 3158 2009-09-11 Jon Honeycutt <jhoneycutt (a] apple.com> 3159 3160 Fix crash on launch on Windows. 3161 3162 Rubber-stamped by Mark Rowe. 3163 3164 * WebKit.vcproj/WebKit.vcproj: 3165 Define ENABLE_WEB_SOCKETS for all configurations. 3166 3167 2009-09-07 Drew Wilson <atwilson (a] google.com> 3168 3169 Reviewed by David Levin. 3170 3171 Enable SHARED_WORKERS by default. 3172 https://bugs.webkit.org/show_bug.cgi?id=28959 3173 3174 * WebKit.vcproj/WebKit.vcproj: 3175 3176 2009-09-04 Adam Roben <aroben (a] apple.com> 3177 3178 Make WebView function without a parent window 3179 3180 When WebView has no parent window, it becomes a message-only window, 3181 which hides it from the screen and prevents it from appearing on the 3182 taskbar. 3183 3184 Fixes <http://webkit.org/b/28971> <rdar://problem/4976998> 3185 WebView::initWithFrame fails if there's no host window 3186 3187 Reviewed by Dave Hyatt. 3188 3189 * WebView.cpp: 3190 (WebView::initWithFrame): m_hostWindow is null, use HWND_MESSAGE as 3191 our parent window, which will make us a message-only window. 3192 (WebView::setHostWindow): If he new host window is null, use 3193 HWND_MESSAGE as our parent window, which will make us a message-only 3194 window. 3195 3196 2009-09-04 Adam Barth <abarth (a] webkit.org> 3197 3198 Unreviewed attempt at a build fix. 3199 3200 Added missing include. 3201 3202 * WebCoreSupport/WebFrameLoaderClient.cpp: 3203 3204 2009-09-04 Adam Barth <abarth (a] webkit.org> 3205 3206 Unreviewed attempt at a build fix. 3207 3208 Fix typo of IWebFrameLoadDelegatePrivate2 and make 3209 IWebFrameLoadDelegatePrivate inherit from IWebFrameLoadDelegatePrivate 3210 as requestd by Adam Roben. 3211 3212 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: 3213 * WebCoreSupport/WebFrameLoaderClient.cpp: 3214 (WebFrameLoaderClient::didDisplayInsecureContent): 3215 (WebFrameLoaderClient::didRunInsecureContent): 3216 3217 2009-09-04 Adam Barth <abarth (a] webkit.org> 3218 3219 Reviewed by Eric Seidel. 3220 3221 https://bugs.webkit.org/show_bug.cgi?id=24696 3222 3223 Plumb mixed content notifications to IWebFrameLoadDelegatePrivate. 3224 3225 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added. 3226 * Interfaces/WebKit.idl: 3227 * WebCoreSupport/WebFrameLoaderClient.cpp: 3228 (WebFrameLoaderClient::didDisplayInsecureContent): 3229 (WebFrameLoaderClient::didRunInsecureContent): 3230 * WebKit.vcproj/Interfaces.vcproj: 3231 3232 2009-09-03 Adam Barth <abarth (a] webkit.org> 3233 3234 Reviewed by eric (a] webkit.org. 3235 3236 https://bugs.webkit.org/show_bug.cgi?id=24696 3237 3238 Stub implementations of mixed content methods of FrameLoaderClient. 3239 3240 * WebCoreSupport/WebFrameLoaderClient.cpp: 3241 (WebFrameLoaderClient::didDisplayInsecureContent): 3242 (WebFrameLoaderClient::didRunInsecureContent): 3243 * WebCoreSupport/WebFrameLoaderClient.h: 3244 3245 2009-09-01 Adam Roben <aroben (a] apple.com> 3246 3247 Post a notification when a WebView is closing 3248 3249 This is useful for situations where some code wants to react to the 3250 WebView closing but isn't in charge of the WebView and can't otherwise 3251 be notified. This notification could replace 3252 IWebUIDelegatePrivate::webViewClosing if we decide that the 3253 notification system isn't too burdensome. 3254 3255 <http://webkit.org/b/28875> 3256 3257 Reviewed by John Sullivan. 3258 3259 * Interfaces/IWebViewPrivate.idl: Added the 3260 WebViewWillCloseNotification string constant. 3261 * WebKit.vcproj/WebKit.vcproj: Link against comsuppw.lib in all 3262 configurations so that we can use _bstr_t. 3263 * WebView.cpp: 3264 (WebView::close): Post the WebViewWillCloseNotification. 3265 3266 2009-08-31 Alexey Proskuryakov <ap (a] webkit.org> 3267 3268 Reviewed by Darin Adler. 3269 3270 https://bugs.webkit.org/show_bug.cgi?id=28852 3271 Rename KURL single argument constructor to avoid confusion 3272 3273 * WebURLResponse.cpp: (WebURLResponse::createInstance): Adapt to the change. 3274 3275 2009-08-20 Adam Roben <aroben (a] apple.com> 3276 3277 Give WebKit clients access to the window features specified in 3278 window.open 3279 3280 Reviewed by Steve Falkenburg. 3281 3282 * COMVariantSetter.h: Added COMVariantSetters for bool and float. 3283 3284 * Interfaces/IWebUIDelegatePrivate.idl: Added IWebUIDelegatePrivate2, 3285 which contains a new version of createWebViewWithRequest that also 3286 passes the window features as an IPropertyBag. This is analagous to 3287 the -createWebViewWithRequest:windowFeatures: method added to 3288 WebUIDelegate on Mac in r27452. Also added key strings for use with 3289 the window features property bag. 3290 3291 * WebCoreSupport/WebChromeClient.cpp: 3292 (createWindowFeaturesPropertyBag): Added this helper function to turn 3293 a WebCore::WindowFeatures into an IPropertyBag for passing to WebKit 3294 clients. 3295 (WebChromeClient::createWindow): If the UI delegate implements 3296 IWebUIDelegatePrivate2, call the new createWebViewWithRequest function 3297 that takes a window features property bag. If the delegate doesn't 3298 implement the new function, fall back to the old functions. 3299 3300 2009-08-20 Adam Roben <aroben (a] apple.com> 3301 3302 A little clean-up in WebChromeClient::createWindow 3303 3304 Reviewed by Steve Falkenburg. 3305 3306 * WebCoreSupport/WebChromeClient.cpp: 3307 (WebChromeClient::createWindow): Refactored to share more code between 3308 the dialog and non-dialog cases. 3309 3310 2009-08-28 Gustavo Noronha Silva <gustavo.noronha (a] collabora.co.uk> 3311 3312 Reviewed by Holger Freyther. 3313 3314 https://bugs.webkit.org/show_bug.cgi?id=25889 3315 [GTK] scrollbar policy for main frame is not implementable 3316 3317 Add empty implementation for new ChromeClient method. 3318 3319 * WebCoreSupport/WebChromeClient.h: 3320 (WebChromeClient::scrollbarsModeDidChange): 3321 3322 2009-08-27 Brent Fulgham <bfulgham (a] webkit.org> 3323 3324 Reviewed by Adam Roben. 3325 3326 Modify Release_Cairo target to build testapi using the 3327 Release_CFLite target so that the correct CoreFoundation 3328 (in this case, CFLite.dll) is linked. 3329 3330 * WebKit.vcproj/WebKit.sln: 3331 3332 2009-08-26 Adam Barth <abarth (a] webkit.org> 3333 3334 Reviewed by Oliver Hunt. 3335 3336 Don't let local files access web URLs 3337 https://bugs.webkit.org/show_bug.cgi?id=28480 3338 3339 * WebPreferences.cpp: 3340 (WebPreferences::initializeDefaultSettings): 3341 3342 2009-08-26 David Levin <levin (a] chromium.org> 3343 3344 Reviewed by Darin Fisher. 3345 3346 ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http. 3347 https://bugs.webkit.org/show_bug.cgi?id=28735 3348 3349 * WebMutableURLRequest.cpp: 3350 (WebMutableURLRequest::setHTTPShouldHandleCookies): 3351 3352 2009-08-25 Eric Carlson <eric.carlson (a] apple.com> 3353 3354 Reviewed by Oliver Hunt. 3355 3356 <video> and <audio> controller should be accessible 3357 https://bugs.webkit.org/show_bug.cgi?id=28081 3358 3359 * WebCoreLocalizedStrings.cpp: 3360 (WebCore::localizedMediaControlElementString): 3361 (WebCore::localizedMediaControlElementHelpText): 3362 (WebCore::localizedMediaTimeDescription): 3363 New. 3364 3365 2009-08-25 Brent Fulgham <bfulgham (a] webkit.org> 3366 3367 Build fix for Windows. 3368 3369 Revise Debug_Cairo build target to build testapi, jsc, WinLauncher, 3370 DumpRenderTree, and TestNetscapeAPI using WinCairo debug build 3371 settings so they link against the proper libraries. 3372 3373 * WebKit.vcproj/WebKit.sln: 3374 3375 2009-08-25 David Levin <levin (a] chromium.org> 3376 3377 Reviewed by Adam Roben. 3378 3379 PLATFORM(CFNETWORK) should be USE(CFNETWORK). 3380 https://bugs.webkit.org/show_bug.cgi?id=28713 3381 3382 Also, moved the #if header section after the other #includes. 3383 3384 * WebError.cpp: 3385 (WebError::localizedDescription): 3386 3387 2009-08-24 Brent Fulgham <bfulgham (a] webkit.org> 3388 3389 Reviewed by Steve Falkenburg. 3390 3391 Revise CFLite Debug build to emit DLL's with _debug label. 3392 https://bugs.webkit.org/show_bug.cgi?id=28695. 3393 3394 * WebKit.vcproj/WebKit.vcproj: Modify Debug_Cairo target to 3395 inherit from new debug_wincairo property sheet, instead of 3396 the current debug sheet. 3397 3398 2009-08-22 Adam Barth <abarth (a] webkit.org> 3399 3400 Revert 47684. We're going to do this later once clients have had a 3401 chance to opt into the setting they like. 3402 3403 * WebPreferences.cpp: 3404 (WebPreferences::initializeDefaultSettings): 3405 3406 2009-08-22 Adam Barth <abarth (a] webkit.org> 3407 3408 Reviewed by Eric Seidel. 3409 3410 Don't let local files access web URLs 3411 https://bugs.webkit.org/show_bug.cgi?id=28480 3412 3413 * WebPreferences.cpp: 3414 (WebPreferences::initializeDefaultSettings): 3415 3416 2009-08-20 Brian Weinstein <bweinstein (a] apple.com> 3417 3418 Reviewed by Adam Roben. 3419 3420 Fix of <http://webkit.org/b/27850>. Panning by emulating Mouse Wheel Events breaks Google Maps. 3421 3422 Switched to using RenderLayer::scrollByRecursively instead of emulating a mouse wheel, 3423 and switched to handling the hit testing in WebView from doing it as part of the mouse wheel event. 3424 One downside of this fix is that panning will not jump out of frames anymore (same behavior as pan-scrolling), but 3425 this is tracked in <http://webkit.org/b/28237>. 3426 3427 * WebView.cpp: 3428 (WebView::gestureNotify): Added hit testing here to figure out the node the user started the gesture on. 3429 (WebView::gesture): Switched from emulating mouse wheel events for panning to calling RenderLayer::scrollByRecursively. 3430 * WebView.h: 3431 3432 2009-08-18 Brian Weinstein <bweinstein (a] apple.com> 3433 3434 Reviewed by Oliver Hunt. 3435 3436 Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support 3437 LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota. 3438 3439 Added a setQuota interface method to IWebDatabaseManager and implemented it. 3440 3441 * Interfaces/IWebDatabaseManager.idl: 3442 * WebDatabaseManager.cpp: 3443 (WebDatabaseManager::setQuota): 3444 * WebDatabaseManager.h: 3445 3446 2009-08-18 Drew Wilson <atwilson (a] google.com> 3447 3448 Unreviewed (build break). 3449 3450 Added missing include for WebWorkersPrivate.h. 3451 3452 * WebKitClassFactory.cpp: 3453 3454 2009-08-18 Peter Kasting <pkasting (a] google.com> 3455 3456 Reviewed by Eric Seidel. 3457 3458 https://bugs.webkit.org/show_bug.cgi?id=28415 3459 Set svn:eol-style CRLF on all .sln and .vcproj files that don't already 3460 have it. 3461 3462 * WebKit.vcproj/InterfacesGenerated.vcproj: 3463 3464 2009-08-18 Drew Wilson <atwilson (a] google.com> 3465 3466 Reviewed by Eric Seidel. 3467 3468 Need to extend DumpRenderTree to expose number of worker threads 3469 https://bugs.webkit.org/show_bug.cgi?id=28292 3470 3471 Defined/implemented COM interfaces to expose WorkerThread::workerThreadCount() for DumpRenderTree. 3472 3473 * ForEachCoClass.h: 3474 Added WebWorkersPrivate. 3475 * Interfaces/IWebWorkersPrivate.idl: Added. 3476 * Interfaces/WebKit.idl: 3477 Added WebWorkersPrivate. 3478 * WebKit.vcproj/Interfaces.vcproj: 3479 * WebKit.vcproj/WebKit.vcproj: 3480 * WebWorkersPrivate.cpp: Added. 3481 Implementation of the IWebWorkersPrivate COM interface, to expose workerThreadCount() for DumpRenderTree. 3482 (WebWorkersPrivate::QueryInterface): 3483 (WebWorkersPrivate::AddRef): 3484 (WebWorkersPrivate::Release): 3485 (WebWorkersPrivate::workerThreadCount): 3486 (WebWorkersPrivate::createInstance): 3487 (WebWorkersPrivate::WebWorkersPrivate): 3488 (WebWorkersPrivate::~WebWorkersPrivate): 3489 * WebWorkersPrivate.h: Added. 3490 3491 2009-08-17 Peter Kasting <pkasting (a] google.com> 3492 3493 Reviewed by Steve Falkenburg. 3494 3495 https://bugs.webkit.org/show_bug.cgi?id=27323 3496 Only add Cygwin to the path when it isn't already there. This avoids 3497 causing problems for people who purposefully have non-Cygwin versions of 3498 executables like svn in front of the Cygwin ones in their paths. 3499 3500 * WebKit.vcproj/Interfaces.vcproj: 3501 * WebKit.vcproj/InterfacesGenerated.vcproj: 3502 * WebKit.vcproj/WebKit.vcproj: 3503 * WebKit.vcproj/WebKitGUID.vcproj: 3504 3505 2009-08-17 Simon Fraser <simon.fraser (a] apple.com> 3506 3507 Speculative fix for Windows build bustage. 3508 3509 * DOMHTMLClasses.cpp: 3510 (DOMHTMLElement::idName): 3511 3512 2009-08-13 Jon Honeycutt <jhoneycutt (a] apple.com> 3513 3514 Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit 3515 nightly (20866) 3516 3517 https://bugs.webkit.org/show_bug.cgi?id=20866 3518 3519 Reviewed by Oliver Hunt. 3520 3521 * AccessibleBase.cpp: 3522 (AccessibleBase::getAccessibilityObjectForChild): 3523 If the child ID is negative, negate it and treat it as an AXID. 3524 3525 2009-08-12 Brian Weinstein <bweinstein (a] apple.com> 3526 3527 Reviewed by Adam Roben. 3528 3529 Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down 3530 list detaches drop down. 3531 3532 Added a check in mouseWheel to see if our focus is currently in a popup, if so, close 3533 the popup (matches other browser behavior). 3534 3535 * WebView.cpp: 3536 (WebView::mouseWheel): 3537 3538 2009-08-12 Adam Roben <aroben (a] apple.com> 3539 3540 Make WebPreferenceKeysPrivate.h available for client use 3541 3542 Reviewed by Dave Hyatt. 3543 3544 Fixes <http://webkit.org/b/28227>. 3545 3546 * WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to 3547 $WebKitOutputDir, just like we do for a few other headers. Also let VS 3548 reorder some XML attributes. 3549 3550 * WebPreferenceKeysPrivate.h: Touched this file to force a build. 3551 3552 2009-08-11 Adam Roben <aroben (a] apple.com> 3553 3554 Remove support for a window resizer within the WebView 3555 3556 Starting with Safari 4, there is never a window resizer inside the 3557 WebView, so we no longer need to support that functionality. 3558 3559 Fixes <http://webkit.org/b/28190> Remove support for a window resizer 3560 within the WebView 3561 3562 Reviewed by Dave Hyatt. 3563 3564 * Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate 3565 functions related to the window resizer with unused*() functions. We 3566 can't remove them entirely because we need to keep the vtable 3567 unchanged so new versions of WebKit will work with old versions of 3568 Safari (e.g., for nightlies and WebKit development). 3569 3570 * WebCoreSupport/WebChromeClient.cpp: 3571 (WebChromeClient::windowResizerRect): Now always returns an empty 3572 rect. 3573 3574 * WebView.cpp: 3575 (WebView::paint): 3576 (WebView::handleMouseEvent): 3577 * WebView.h: 3578 Removed window-resizer-related code. 3579 3580 2009-08-11 John Gregg <johnnyg (a] google.com> 3581 3582 Reviewed by Maciej Stachowiak. 3583 3584 Move the accessor for notifications presenter from WebUIDelegate 3585 to WebUIDelegate2 which extends it. When making this call from 3586 WebCoreSupport, check using QueryInterface before calling. 3587 3588 https://bugs.webkit.org/show_bug.cgi?id=28198 3589 3590 * Interfaces/IWebUIDelegate.idl: 3591 * Interfaces/IWebUIDelegate2.idl: Added. 3592 * Interfaces/WebKit.idl: 3593 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: 3594 (WebDesktopNotificationsDelegate::show): 3595 (WebDesktopNotificationsDelegate::cancel): 3596 (WebDesktopNotificationsDelegate::notificationObjectDestroyed): 3597 (WebDesktopNotificationsDelegate::requestPermission): 3598 (WebDesktopNotificationsDelegate::checkPermission): 3599 (WebDesktopNotificationsDelegate::hasNotificationDelegate): 3600 (WebDesktopNotificationsDelegate::notificationDelegate): 3601 * WebCoreSupport/WebDesktopNotificationsDelegate.h: 3602 3603 2009-08-11 Drew Wilson <atwilson (a] google.com> 3604 3605 Reviewed by NOBODY (build break). 3606 3607 Speculative Windows build fix - undo previous unnecessary change. 3608 3609 * WebCoreSupport/WebDesktopNotificationsDelegate.h: 3610 3611 2009-08-11 Brian Weinstein <bweinstein (a] apple.com> 3612 3613 Reviewed by Steve Falkenburg. 3614 3615 Refactored MIMETypeforExtension to be a member of IWebViewPrivate 3616 instead of IWebView. 3617 3618 * Interfaces/IWebView.idl: 3619 * Interfaces/IWebViewPrivate.idl: 3620 * WebView.cpp: 3621 (WebView::MIMETypeForExtension): 3622 * WebView.h: 3623 3624 2009-08-11 Drew Wilson <atwilson (a] google.com> 3625 3626 Reviewed by NOBODY (build break) 3627 3628 Speculative fix for windows build break. 3629 3630 * WebKitSupport/WebDesktopNotificationsDelegate.h: 3631 WebCore/Notification*.h => WebCore/notifications/Notification*.h 3632 3633 2009-08-11 John Gregg <johnnyg (a] google.com> 3634 3635 Reviewed by Maciej Stachowiak. 3636 3637 Desktop Notifications API 3638 https://bugs.webkit.org/show_bug.cgi?id=25643 3639 3640 Adds test hooks for notification features to WebCoreSupport for 3641 use in DumpRenderTree. 3642 3643 * Interfaces/IWebDesktopNotificationsDelegate.idl: Added. 3644 * Interfaces/IWebUIDelegate.idl: 3645 * Interfaces/WebKit.idl: 3646 * WebCoreSupport/WebChromeClient.cpp: 3647 (WebChromeClient::WebChromeClient): 3648 * WebCoreSupport/WebChromeClient.h: 3649 (WebChromeClient::notificationPresenter): 3650 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added. 3651 (NotificationCOMWrapper::create): 3652 (NotificationCOMWrapper::NotificationCOMWrapper): 3653 (NotificationCOMWrapper::QueryInterface): 3654 (NotificationCOMWrapper::AddRef): 3655 (NotificationCOMWrapper::Release): 3656 (NotificationCOMWrapper::isHTML): 3657 (NotificationCOMWrapper::contentsURL): 3658 (NotificationCOMWrapper::iconURL): 3659 (NotificationCOMWrapper::title): 3660 (NotificationCOMWrapper::text): 3661 (NotificationCOMWrapper::notifyDisplay): 3662 (NotificationCOMWrapper::notifyError): 3663 (NotificationCOMWrapper::notifyClose): 3664 (WebDesktopNotificationsDelegate::WebDesktopNotificationsDelegate): 3665 (WebDesktopNotificationsDelegate::show): 3666 (WebDesktopNotificationsDelegate::cancel): 3667 (WebDesktopNotificationsDelegate::notificationObjectDestroyed): 3668 (WebDesktopNotificationsDelegate::requestPermission): 3669 (WebDesktopNotificationsDelegate::checkPermission): 3670 (WebDesktopNotificationsDelegate::notificationDelegate): 3671 * WebCoreSupport/WebDesktopNotificationsDelegate.h: Added. 3672 * WebCoreSupport/WebInspectorDelegate.h: 3673 (WebInspectorDelegate::desktopNotificationsDelegate): 3674 * WebKit.vcproj/Interfaces.vcproj: 3675 * WebKit.vcproj/WebKit.vcproj: 3676 3677 2009-08-11 Brian Weinstein <bweinstein (a] apple.com> 3678 3679 Reviewed by Adam Roben. 3680 3681 Fix of <rdar://5016504> SVG file cannot be dragged to webview, 3682 but can be opened via Open File. 3683 3684 Added a new function to IWebView that gets the MIME type for a given 3685 extension from the MIMETypeRegistry. 3686 3687 * Interfaces/IWebView.idl: 3688 * WebView.cpp: 3689 (WebView::MIMETypeForExtension): 3690 * WebView.h: 3691 3692 2009-08-11 Dmitry Titov <dimich (a] chromium.org> 3693 3694 Reviewed by Adam Roben. 3695 3696 Originally implemented by Glenn Wilson <gwilson (a] chromium.org>. 3697 3698 Added support for overriding default preferences per-test. 3699 See https://bugs.webkit.org/show_bug.cgi?id=20534 3700 3701 * Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest 3702 * WebPreferences.cpp: same. 3703 * WebPreferences.h: same. 3704 3705 2009-08-10 Dan Bernstein <mitz (a] apple.com> 3706 3707 Reviewed by Darin Adler. 3708 3709 Link drag images specify Lucida Grande on Windows and end up using Times 3710 New Roman 3711 <rdar://problem/7117835> 3712 3713 * WebCoreSupport/WebDragClient.cpp: 3714 (dragLabelFont): Added a RenderingMode parameter and changed to use the 3715 same typeface as the Windows small caption font. 3716 (WebDragClient::createDragImageForLink): Changed to respect the 3717 pages rendering mode. 3718 3719 2009-08-10 Brent Fulgham <bfulgham (a] webkit.org> 3720 3721 Reviewed by Adam Roben. 3722 3723 https://bugs.webkit.org/show_bug.cgi?id=28048. 3724 Move various WinCairo build settings into *.vsprops file. 3725 3726 * WebKit.vcproj/WebKit.vcproj: Add new cURL.vsprops property sheet 3727 (which contains link settings for cURL and its dependencies), and 3728 remove the corresponding entries from the vcproj file. Remove 3729 png, jpeg, cairo library linking flags from vcproj, now that they 3730 are in the WinCairo.vsprops file. 3731 3732 2009-08-09 Nikolas Zimmermann <nikolas.zimmermann (a] torchmobile.com> 3733 3734 Reviewed by George Staikos. 3735 3736 [WML] Deck access control is completly broken 3737 https://bugs.webkit.org/show_bug.cgi?id=27721 3738 3739 Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'. 3740 3741 * Interfaces/IWebFramePrivate.idl: 3742 3743 2009-08-09 Nikolas Zimmermann <nikolas.zimmermann (a] torchmobile.com> 3744 3745 Reviewed by Maciej Stachowiak. 3746 3747 FrameLoadType / WebFrameLoadType enums are out of sync 3748 https://bugs.webkit.org/show_bug.cgi?id=28132 3749 3750 Synchronize FrameLoadType <-> WebFrameLoadType enums (append missing 'WebFrameLoadTypeReloadFromOrigin' value) 3751 3752 * Interfaces/IWebFramePrivate.idl: 3753 3754 2009-08-06 Adam Barth <abarth (a] webkit.org> 3755 3756 Unreviewed revert. 3757 3758 http://bugs.webkit.org/show_bug.cgi?id=27879 3759 3760 Revert 46877 because it broke GTK. 3761 3762 * COMPropertyBag.h: 3763 3764 2009-08-06 Zoltan Horvath <hzoltan (a] inf.u-szeged.hu> 3765 3766 Reviewed by Adam Barth. 3767 3768 Change Noncopyable inheriting to public 3769 http://bugs.webkit.org/show_bug.cgi?id=27879 3770 3771 Since Noncopyable is inherited from FastAllocBase, 3772 Noncopyable's inheriting has been changed to public. 3773 3774 * COMPropertyBag.h: 3775 3776 2009-08-04 Alice Liu <alice.liu (a] apple.com> 3777 3778 "Shift + Enter" should behave like "Enter" in editable fields. 3779 Affects backward search in find-in-page in Safari for Windows 3780 3781 Reviewed by Jon Honeycutt. 3782 3783 * WebView.cpp: 3784 Register shift+enter as InsertNewline command, similar to other 3785 modifier+Enter combinations. 3786 3787 2009-07-29 Jon Honeycutt <jhoneycutt (a] apple.com> 3788 3789 Part of <rdar://problem/5698113> Safari shouldn't auto-activate 3790 plug-ins in background tabs (make Win consistent with Mac) 3791 3792 https://bugs.webkit.org/show_bug.cgi?id=27855 3793 3794 Reviewed by Adam Roben and Anders Carlsson. 3795 3796 * Interfaces/IWebViewPrivate.idl: 3797 Add setCanStartPlugins(). 3798 3799 * WebCoreSupport/WebFrameLoaderClient.cpp: 3800 (WebFrameLoaderClient::dispatchDidFailToStartPlugin): 3801 Added; code moved from createPlugin(). Modified to obtain the plug-in's 3802 page URL, the plug-ins "plug-ins page" parameter value, and the 3803 plug-in's MIME type by calling getter functions on the passed 3804 PluginView. 3805 (WebFrameLoaderClient::createPlugin): 3806 If the plug-in status is not "success," call 3807 dispatchDidFailToStartPlugin(). 3808 3809 * WebCoreSupport/WebFrameLoaderClient.h: 3810 Declare an override of dispatchDidFailToStartPlugin(). 3811 3812 * WebView.cpp: 3813 (WebViewWndProc): 3814 Add a missing ) to a comment. 3815 (WebView::setCanStartPlugins): 3816 Call the Page's setCanStartPlugins() function. 3817 3818 * WebView.h: 3819 3820 2009-07-30 Darin Adler <darin (a] apple.com> 3821 3822 Reviewed by David Levin. 3823 3824 Use checked casts for render tree 3825 https://bugs.webkit.org/show_bug.cgi?id=23522 3826 3827 * DOMHTMLClasses.cpp: 3828 (DOMHTMLInputElement::isUserEdited): 3829 (DOMHTMLTextAreaElement::isUserEdited): 3830 Use checked casts. 3831 3832 2009-07-31 Anders Carlsson <andersca (a] apple.com> 3833 3834 Reviewed by Dan Bernstein. 3835 3836 -Fix <rdar://problem/7104097> 3837 3838 Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count. 3839 3840 * WebCoreSupport/EmbeddedWidget.cpp: 3841 (EmbeddedWidget::create): 3842 * WebCoreSupport/EmbeddedWidget.h: 3843 3844 2009-07-29 Brian Weinstein <bweinstein (a] apple.com> 3845 3846 Was doing the build fix wrong, NotImplemented.h is in WebCore. 3847 3848 * WebCoreSupport/WebInspectorClient.cpp: 3849 3850 2009-07-29 Brian Weinstein <bweinstein (a] apple.com> 3851 3852 Windows build fix. 3853 3854 * WebCoreSupport/WebInspectorClient.cpp: 3855 3856 2009-07-29 Kevin McCullough <kmccullough (a] apple.com> 3857 3858 Reviewed by Darin Adler. 3859 3860 Added foundation work to allow a testing infrastructure for the Web 3861 Inspector. 3862 3863 * WebCoreSupport/WebInspectorClient.cpp: 3864 (WebInspectorClient::inspectorWindowObjectCleared): Empty definition 3865 to let Windows compile but we should implement this at some point so 3866 that the tests can be run on Windows too. 3867 * WebCoreSupport/WebInspectorClient.h: 3868 3869 2009-07-28 Tor Arne Vestb <tor.arne.vestbo (a] nokia.com> 3870 3871 Reviewed by Steve Falkenburg. 3872 3873 Add output directory for VS pre-build steps to enable out-of-tree builds 3874 3875 https://bugs.webkit.org/show_bug.cgi?id=27700 3876 3877 The tmp.obj file is now placed in the intermediate build directory. 3878 3879 * WebKit.vcproj/WebKit.vcproj: 3880 3881 2009-07-27 Brian Weinstein <bweinstein (a] apple.com> 3882 3883 Build fix for Windows. 3884 3885 * WebView.cpp: 3886 (WebView::stringByEvaluatingJavaScriptFromString): 3887 3888 2009-07-27 Alexey Proskuryakov <ap (a] webkit.org> 3889 3890 Reviewed by Darin Adler. 3891 3892 https://bugs.webkit.org/show_bug.cgi?id=27735 3893 Give a helpful name to JSLock constructor argument 3894 3895 * WebCoreStatistics.cpp: 3896 (WebCoreStatistics::javaScriptObjectsCount): 3897 (WebCoreStatistics::javaScriptGlobalObjectsCount): 3898 (WebCoreStatistics::javaScriptProtectedObjectsCount): 3899 (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount): 3900 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts): 3901 * WebJavaScriptCollector.cpp: 3902 (WebJavaScriptCollector::objectCount): 3903 * WebView.cpp: 3904 (WebView::stringByEvaluatingJavaScriptFromString): 3905 3906 2009-07-25 Kwang Yul Seo <skyul (a] company100.net> 3907 3908 Reviewed by Darin Adler. 3909 3910 Windows build break due to warning C4819 3911 https://bugs.webkit.org/show_bug.cgi?id=27416 3912 3913 Disable C4819 warning to fix build. 3914 3915 * WebKit.vcproj/WebKit.vcproj: 3916 3917 2009-07-24 Brent Fulgham <bfulgham (a] webkit.org> 3918 3919 Reviewed by Dave Hyatt. 3920 3921 Clean up dependencies on Apple support libraries for non-Apple build. 3922 http://bugs.webkit.org/show_bug.cgi?id=27532. 3923 3924 * DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h 3925 * WebDownload.h: Conditionalize include of CFNetwork.h 3926 * WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h 3927 3928 2009-07-24 Andrei Popescu <andreip (a] google.com> 3929 3930 Reviewed by Anders Carlsson. 3931 3932 ApplicationCache should have size limit 3933 https://bugs.webkit.org/show_bug.cgi?id=22700 3934 3935 * WebCoreSupport/WebChromeClient.cpp: 3936 (WebChromeClient::reachedMaxAppCacheSize): 3937 Adds empty implementation of the reachedMaxAppCacheSize callback. 3938 * WebCoreSupport/WebChromeClient.h: 3939 3940 2009-07-23 Brady Eidson <beidson (a] apple.com> 3941 3942 Reviewed by Geoff Garen. 3943 3944 WebFrameLoaderClient on Windows doesn't gracefully handle a null request returned from willSendRequest. 3945 https://bugs.webkit.org/show_bug.cgi?id=27595 3946 3947 * WebCoreSupport/WebFrameLoaderClient.cpp: 3948 (WebFrameLoaderClient::dispatchWillSendRequest): 3949 3950 2009-07-22 Takeshi Yoshino <tyoshino (a] google.com> 3951 3952 Reviewed by Darin Adler. 3953 3954 VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp 3955 https://bugs.webkit.org/show_bug.cgi?id=26375 3956 3957 Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp 3958 with hex escape sequences. 3959 3960 VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message ( 3961 treated as an error and stopped build). 3962 3963 WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be 3964 represented in the current code page (932). Save the file in Unicode format to prevent data loss 3965 3966 A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break 3967 localized string generation process. 3968 3969 * WebCoreLocalizedStrings.cpp: 3970 (WebCore::imageTitle): 3971 3972 2009-07-21 Roland Steiner <rolandsteiner (a] google.com> 3973 3974 Reviewed by David Levin. 3975 3976 Add ENABLE_RUBY to list of build options 3977 https://bugs.webkit.org/show_bug.cgi?id=27324 3978 3979 * WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY. 3980 3981 2009-07-20 Peter Kasting <pkasting (a] google.com> 3982 3983 Reviewed by Mark Rowe. 3984 3985 https://bugs.webkit.org/show_bug.cgi?id=27468 3986 Back out r46060, which caused problems for some Apple developers. 3987 3988 * WebKit.vcproj/Interfaces.vcproj: 3989 * WebKit.vcproj/InterfacesGenerated.vcproj: 3990 * WebKit.vcproj/WebKit.vcproj: 3991 * WebKit.vcproj/WebKitGUID.vcproj: 3992 3993 2009-07-17 Brian Weinstein <bweinstein (a] apple.com> 3994 3995 Reviewed by Adam Roben. 3996 3997 Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272) 3998 https://bugs.webkit.org/show_bug.cgi?id=14272 3999 4000 Implemented resizing of inspector window when it is in attached mode. Implemented setAttachedWindowHeight 4001 to set window sizes and redraw the inspector and the inspected web view, and used stored preferences 4002 in InspectorController.cpp to remember user's preferred height. 4003 4004 * WebCoreSupport/WebInspectorClient.cpp: 4005 4006 2009-07-17 Peter Kasting <pkasting (a] google.com> 4007 4008 Reviewed by Steve Falkenburg. 4009 4010 https://bugs.webkit.org/show_bug.cgi?id=27323 4011 Only add Cygwin to the path when it isn't already there. This avoids 4012 causing problems for people who purposefully have non-Cygwin versions of 4013 executables like svn in front of the Cygwin ones in their paths. 4014 4015 * WebKit.vcproj/Interfaces.vcproj: 4016 * WebKit.vcproj/InterfacesGenerated.vcproj: 4017 * WebKit.vcproj/WebKit.vcproj: 4018 * WebKit.vcproj/WebKitGUID.vcproj: 4019 4020 2009-07-16 Fumitoshi Ukai <ukai (a] chromium.org> 4021 4022 Reviewed by David Levin. 4023 4024 Add --web-sockets flag and ENABLE_WEB_SOCKETS define. 4025 https://bugs.webkit.org/show_bug.cgi?id=27206 4026 4027 Add ENABLE_WEB_SOCKETS 4028 4029 * WebKit.vcproj/WebKit.vcproj: add ENABLE_WEB_SOCKETS 4030 4031 2009-07-16 Xiaomei Ji <xji (a] chromium.org> 4032 4033 Reviewed by Darin Adler. 4034 4035 Fix tooltip does not get its directionality from its element's directionality. 4036 https://bugs.webkit.org/show_bug.cgi?id=24187 4037 4038 Per mitz's suggestion in comment #6, while getting the plain-text 4039 title, we also get the directionality of the title. How to handle 4040 the directionality is up to clients. Clients could ignore it, 4041 or use attribute or unicode control characters to display the title 4042 as what they want. 4043 4044 * WebCoreSupport/WebChromeClient.cpp: 4045 (WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet). 4046 * WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip(). 4047 * WebElementPropertyBag.cpp: 4048 (WebElementPropertyBag::Read): Change call of spellingToolTip() and title() due to signature change. 4049 4050 2009-07-15 Darin Adler <darin (a] apple.com> 4051 4052 Reviewed by Sam Weinig. 4053 4054 Renamed parseURL to deprecatedParseURL. 4055 4056 * WebCoreSupport/WebFrameLoaderClient.cpp: 4057 (WebFrameLoaderClient::createPlugin): Renamed. 4058 4059 2009-07-14 Steve Falkenburg <sfalken (a] apple.com> 4060 4061 Reorganize JavaScriptCore headers into: 4062 API: include/JavaScriptCore/ 4063 Private: include/private/JavaScriptCore/ 4064 4065 Reviewed by Darin Adler. 4066 4067 * WebKit.vcproj/WebKit.vcproj: 4068 4069 2009-07-14 Zoltan Horvath <hzoltan (a] inf.u-szeged.hu> 4070 4071 Reviewed by Darin Adler. 4072 4073 Change all Noncopyable inheriting visibility to public. 4074 https://bugs.webkit.org/show_bug.cgi?id=27225 4075 4076 Change all Noncopyable inheriting visibility to public because 4077 it is needed to the custom allocation framework (bug #20422). 4078 4079 * COMEnumVariant.h: 4080 * WebDatabaseManager.cpp: 4081 * WebInspector.h: 4082 * WebLocalizableStrings.cpp: 4083 4084 2009-07-13 Brent Fulgham <bfulgham (a] webkit.org> 4085 4086 Reviewed by Adam Roben. 4087 4088 Refactor WebFrame::spoolPages for easier sharing with Windows Cairo. 4089 https://bugs.webkit.org/show_bug.cgi?id=27240. 4090 4091 * WebFrame.cpp: 4092 (WebFrame::printHeader): New shared method to print the header. 4093 (WebFrame::printFooter): New shared method to print the footer. 4094 (WebFrame::spoolPage): New conditionally-compiled method to print 4095 a page. 4096 (WebFrame::spoolPages): Revised to call the platform-specific spoolPage 4097 for each page. 4098 * WebFrame.h: Add new method prototypes. 4099 4100 2009-07-13 Brent Fulgham <bfulgham (a] webkit.org> 4101 4102 Reviewed by Adam Roben. 4103 4104 Add new configuration flag for redistributable Windows build. 4105 https://bugs.webkit.org/show_bug.cgi=27087 4106 4107 * WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to 4108 Debug_Cairo and Release_Cairo targets. 4109 4110 2009-07-12 Brent Fulgham <bfulgham (a] gmail.com> 4111 4112 Speculative Windows build fix after http://trac.webkit.org/changeset/45786. 4113 4114 * WebCoreSupport/WebChromeClient.cpp: 4115 (WebChromeClient::addMessageToConsole): 4116 4117 2009-07-10 Adam Barth <abarth (a] webkit.org> 4118 4119 Reviewed by Sam Weinig with the power of Grayskull. 4120 4121 Enable XSSAuditor by default. 4122 4123 * WebPreferences.cpp: 4124 (WebPreferences::initializeDefaultSettings): 4125 4126 2009-07-09 Drew Wilson <atwilson (a] google.com> 4127 4128 Reviewed by Alexey Proskuryakov. 4129 4130 https://bugs.webkit.org/show_bug.cgi?id=26903 4131 4132 Turned on CHANNEL_MESSAGING by default because the MessageChannel API 4133 can now be implemented for Web Workers and is reasonably stable. 4134 4135 * WebKit.vcproj/WebKit.vcproj: 4136 4137 2009-07-09 Brian Weinstein <bweinstein (a] apple.com> 4138 4139 Reviewed by Alice Liu. 4140 4141 Fix of <rdar://5712929> Add preferences key to remember if the Inspector was docked (14271) 4142 https://bugs.webkit.org/show_bug.cgi?id=27140 4143 4144 Added a preference key to remember whether the user prefers the inspector detached or attached. 4145 4146 * WebCoreSupport/WebInspectorClient.cpp: 4147 (WebInspectorClient::showWindow): Pass both parameters into setWindowVisible 4148 (WebInspectorClient::closeWindow): Ditto 4149 (WebInspectorClient::attachWindow): Set preference to attached windows here 4150 (WebInspectorClient::detachWindow): Set preference to detached windows here 4151 (WebInspectorClient::showWindowWithoutNotifications): Read preference for attached vs. detached 4152 (WebInspectorClient::onClose): Pass both parameters into setWindowVisible 4153 4154 2009-07-09 Alexey Proskuryakov <ap (a] webkit.org> 4155 4156 Reviewed by Oliver Hunt. 4157 4158 <rdar://problem/6921671> Visit count shouldn't be incremented by redirects. 4159 4160 * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): 4161 Do not increase visit count if there is a redirect source. As a result, only pages that were 4162 explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking 4163 a link) will be counted. 4164 4165 * Interfaces/IWebHistoryItemPrivate.idl: 4166 * WebHistory.cpp: 4167 (WebHistory::visitedURL): 4168 * WebHistory.h: 4169 * WebHistoryItem.cpp: 4170 (WebHistoryItem::visitedWithTitle): 4171 * WebHistoryItem.h: 4172 Marshal this new argument all the way down to WebCore. 4173 4174 2009-07-09 Beth Dakin and Jon Honeycutt <bdakin (a] apple.com> 4175 4176 Reviewed by Dave Hyatt. 4177 4178 Make Widget RefCounted to fix: 4179 4180 <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 4181 at WebCore::Widget::afterMouseDown() after clicking To Do's close 4182 box 4183 <rdar://problem/6978804> WER #16: Repro Access Violation in 4184 WebCore::PluginView::bindingInstance (1310178023) 4185 -and- 4186 <rdar://problem/6991251> WER #13: Crash in WebKit! 4187 WebCore::PluginView::performRequest+203 (1311461169) 4188 4189 * WebCoreSupport/WebFrameLoaderClient.cpp: 4190 (WebFrameLoaderClient::createPlugin): 4191 * WebCoreSupport/WebFrameLoaderClient.h: 4192 * WebFrame.cpp: 4193 (WebFrame::createJavaAppletWidget): 4194 * WebFrame.h: 4195 4196 2009-07-09 Sam Weinig <sam (a] webkit.org> 4197 4198 Reviewed by Steve Falkenburg. 4199 4200 Roll out r43848. The quirk is no longer necessary. 4201 4202 * WebView.cpp: 4203 (WebView::userAgentForKURL): 4204 4205 2009-07-07 Ada Chan <adachan (a] apple.com> 4206 4207 Reviewed by Dave Hyatt. 4208 4209 Missed a call to FocusController::setFocused(true) when handling WM_SETFOCUS in WebView. 4210 https://bugs.webkit.org/show_bug.cgi?id=27057 4211 4212 * WebView.cpp: 4213 (WebViewWndProc): 4214 4215 2009-07-02 Erik Arvidsson <arv (a] chromium.org> 4216 4217 Reviewed by Adam Roben. 4218 4219 [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc 4220 https://bugs.webkit.org/show_bug.cgi?id=26699 4221 4222 * WebDropSource.cpp: 4223 (WebDropSource::QueryContinueDrag): 4224 4225 2009-07-02 Oliver Hunt <oliver (a] apple.com> 4226 4227 Reviewed by Anders Carlsson. 4228 4229 <rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670) 4230 <https://bugs.webkit.org/show_bug.cgi?id=26670> 4231 4232 Make windows loader client match mac behaviour more closely. 4233 4234 * WebCoreSupport/WebFrameLoaderClient.cpp: 4235 (WebFrameLoaderClient::forceLayout): 4236 4237 2009-06-30 Brent Fulgham <bfulgham (a] gmail.com> 4238 4239 Reviewed by Adam Roben. 4240 4241 Build DumpRenderTree under Cairo. 4242 https://bugs.webkit.org/show_bug.cgi?id=26457 4243 4244 * WebKit.vcproj/WebKit.sln: Add Cairo targets to the 4245 DumpRenderTree build, and use the in the Debug_Cairo 4246 and Release_Cairo targets. 4247 4248 2009-07-02 Eric Carlson <eric.carlson (a] apple.com> 4249 4250 Fix Windows build by including missing localized string methods. 4251 4252 * WebCoreLocalizedStrings.cpp: 4253 (WebCore::mediaElementLoadingStateText): 4254 (WebCore::mediaElementLiveBroadcastStateText): 4255 4256 2009-07-01 David Hyatt <hyatt (a] apple.com> 4257 4258 Reviewed by Tim Hatcher. 4259 4260 <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused, 4261 even though the field is not actually focused for keyboard input 4262 4263 Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the 4264 focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't 4265 have focus. 4266 4267 * WebView.cpp: 4268 (WebViewWndProc): 4269 4270 2009-06-29 David Hyatt <hyatt (a] apple.com> 4271 4272 Fix Windows bustage. Missed two configurations for enabling DATAGRID. 4273 4274 * WebKit.vcproj/WebKit.vcproj: 4275 4276 2009-06-29 Jessie Berlin <jberlin (a] apple.com> 4277 4278 Reviewed by Adam Roben. 4279 4280 Fix the windows build. 4281 4282 * WebCoreSupport/WebContextMenuClient.cpp: 4283 (WebContextMenuClient::isSpeaking): 4284 * WebCoreSupport/WebContextMenuClient.h: 4285 4286 2009-06-29 David Hyatt <hyatt (a] apple.com> 4287 4288 Reviewed by Adam Roben. 4289 4290 Make sure to patch all configurations to have datagrid enabled. 4291 4292 * WebKit.vcproj/WebKit.vcproj: 4293 4294 2009-06-29 David Hyatt <hyatt (a] apple.com> 4295 4296 Reviewed by Adam Roben. 4297 4298 Put <datagrid> behind an ifdef. 4299 4300 * WebKit.vcproj/WebKit.vcproj: 4301 4302 2009-06-26 Brian Weinstein <bweinstein (a] apple.com> 4303 4304 Reviewed by Simon Fraser. 4305 4306 https://bugs.webkit.org/show_bug.cgi?id=26695 4307 4308 Added hit testing on scrollbars, so if you start a gesture over a scrollbar, 4309 it isn't counted, and lets the user drag the scrollbar itself instead of a 4310 panning gesture. Also cleaned up code in gesture. 4311 4312 * WebView.cpp: 4313 (WebView::gestureNotify): 4314 (WebView::gesture): 4315 4316 2009-06-26 Jeremy Orlow <jorlow (a] chromium.org> 4317 4318 Reviewed by Adam Barth. 4319 4320 https://bugs.webkit.org/show_bug.cgi?id=26767 4321 4322 Fix a build break due to LocalStorage.h being included in WebKitDLL.cpp 4323 despite it being deleted from the repo by the following patch/commit: 4324 https://bugs.webkit.org/show_bug.cgi?id=26732 4325 http://trac.webkit.org/changeset/45290 4326 4327 * WebKitDLL.cpp: 4328 4329 2009-06-26 Yongjun Zhang <yongjun.zhang (a] nokia.com> 4330 4331 Reviewed by Eric Seidel. 4332 4333 Bug 20303: [Qt] Key events are not working in frames. 4334 4335 Move the scroll handling code to EventHandler so that other 4336 ports can share the functionality. 4337 4338 * WebView.cpp: 4339 (WebView::keyDown): 4340 (EnumTextMatches::QueryInterface): 4341 4342 2009-06-23 Anders Carlsson <andersca (a] apple.com> 4343 4344 Reviewed by Darin Adler. 4345 4346 WebKit side of <rdar://problem/6946094>. 4347 4348 * Interfaces/IWebUIDelegate.idl: 4349 Add a newPasteboard out parameter to willPerformDragSourceAction. 4350 4351 * WebCoreSupport/WebDragClient.cpp: 4352 (WebDragClient::willPerformDragSourceAction): 4353 Implement this. If the client returns a new pasteboard, use it for the drag. 4354 4355 * WebCoreSupport/WebInspectorDelegate.h: 4356 (WebInspectorDelegate::willPerformDragSourceAction): 4357 Add the new parameter. 4358 4359 2009-06-20 Darin Adler <darin (a] apple.com> 4360 4361 Reviewed by Sam Weinig. 4362 4363 <rdar://problem/6964221> Need more processing of pluginspage. 4364 4365 * WebCoreSupport/WebFrameLoaderClient.cpp: 4366 (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily. 4367 4368 2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen (a] openbossa.org> 4369 4370 Reviewed by Steve Falkenburg. 4371 4372 https://bugs.webkit.org/show_bug.cgi?id=26494 4373 Bug 26494: RenderTheme::themeForPage reads from Settings before it has 4374 been initialized by WebKit 4375 4376 Get the shouldPaintNativeControls preference and update the settings 4377 before initializing the page, as the page depends on it after the 4378 themeForPage change. 4379 4380 * WebView.cpp: 4381 (WebView::initWithFrame): 4382 4383 2009-06-19 Brian Weinstein <bweinstein (a] apple.com> 4384 4385 Reviewed by Steve Falkenburg. 4386 4387 https://bugs.webkit.org/show_bug.cgi?id=26488 4388 No Support for Single Finger or Two Finger Panning in Windows 7 4389 4390 Added the code necessary for single finger and two-finger panning with 4391 window bounce. We now register for WM_GESTURENOTIFY and WM_GESTURE messages, 4392 and interpret the panning command. Also, added WindowsTouch.h which contains 4393 structs and #defines from the Windows 7 SDK. 4394 4395 * WebKit.vcproj/WebKit.vcproj: 4396 * WebView.cpp: 4397 (WebView::gestureNotify): Checks if we are in a pannable region - IE: Not in the scrollbar 4398 (WebView::gesture): Handles the Panning gesture, creating the WheelEvent 4399 (WebViewWndProc): Added cases for WM_GESTURE and WM_GESTURENOTIFY 4400 * WebView.h: 4401 * WindowsTouch.h: Added. 4402 4403 2009-06-18 Adam Barth <abarth (a] webkit.org> 4404 4405 Reviewed by Sam Weinig. 4406 4407 https://bugs.webkit.org/show_bug.cgi?id=26199 4408 4409 Added preference to enable the XSSAuditor. 4410 4411 * Interfaces/IWebPreferencesPrivate.idl: 4412 * WebPreferenceKeysPrivate.h: 4413 * WebPreferences.cpp: 4414 (WebPreferences::initializeDefaultSettings): 4415 (WebPreferences::isXSSAuditorEnabled): 4416 (WebPreferences::setXSSAuditorEnabled): 4417 * WebPreferences.h: 4418 * WebView.cpp: 4419 (WebView::notifyPreferencesChanged): 4420 4421 2009-06-18 Brent Fulgham <bfulgham (a] gmail.com> 4422 4423 Reviewed by Dave Levin. 4424 4425 Remove some boilerplate using the BitmapInfo struct. 4426 https://bugs.webkit.org/show_bug.cgi?id=26425 4427 4428 * WebFrame.cpp: 4429 (WebFrame::spoolPages): 4430 * WebIconDatabase.cpp: 4431 (createDIB): 4432 * WebKit.vcproj/WebKit.sln: 4433 * WebNodeHighlight.cpp: 4434 (WebNodeHighlight::update): 4435 * WebView.cpp: 4436 (WebView::ensureBackingStore): 4437 4438 2009-06-17 Steve Falkenburg <sfalken (a] apple.com> 4439 4440 Consolidate WebKit COM interfaces. 4441 Moved IID from the highest numbered COM interface to the first interface and combined all methods. 4442 4443 Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces. 4444 4445 Reviewed by Adam Roben. 4446 4447 * Interfaces/IWebFrameLoadDelegate.idl: 4448 * Interfaces/IWebFrameLoadDelegatePrivate.idl: 4449 * Interfaces/IWebResourceLoadDelegatePrivate.idl: 4450 * Interfaces/IWebUIDelegate.idl: 4451 * Interfaces/IWebUIDelegatePrivate.idl: 4452 * Interfaces/WebKit.idl: 4453 * WebCoreSupport/WebChromeClient.cpp: 4454 * WebCoreSupport/WebChromeClient.h: 4455 * WebCoreSupport/WebContextMenuClient.cpp: 4456 * WebCoreSupport/WebFrameLoaderClient.cpp: 4457 * WebCoreSupport/WebInspectorDelegate.h: 4458 * WebFrame.cpp: 4459 * WebView.cpp: 4460 4461 2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen (a] openbossa.org> 4462 4463 Reviewed by Adam Roben. 4464 4465 Create a different RenderTheme per page, so that RenderTheme has 4466 access to page specific theming. This is needed for the Qt port, as Qt 4467 supports setting the theme (style) per widget. 4468 4469 This change was suggested and discussed with Dave Hyatt. 4470 4471 More detailed: 4472 4473 1) Create a theme per page or one global one, depending on the needs 4474 of the platform. 4475 2) Add an accesser to the theme from RenderObject. 4476 3) Change all uses of the theming to access the theme through 4477 RenderObject, using the global default theme as fallback, when the 4478 document of RenderObject has no page. 4479 When we don't have access to a RenderObject, use the default theme. 4480 4) Modify all RenderTheme platform implementations to work with the 4481 above changes, still creating only one global theme. 4482 4483 * WebView.cpp: 4484 (WebViewWndProc): Get the theme from the associated page. 4485 4486 2009-06-16 Brian Weinstein <bweinstein (a] apple.com> 4487 4488 Reviewed by Adam Roben. 4489 4490 Switch Control+Mousewheel Zooming definitions to match other browsers on Windows. 4491 Control+Mousewheel-Down now zooms out, Control+Mousewheel-Up now zooms in. 4492 https://bugs.webkit.org/show_bug.cgi?id=25875. 4493 <rdar://problem/6903976> 4494 4495 * WebView.cpp: 4496 (WebView::mouseWheel): 4497 4498 2009-06-16 Brent Fulgham <bfulgham (a] gmail.com> 4499 4500 Reviewed by Darin Adler. 4501 4502 Use consistent Windows GUID Comparison Functions. 4503 https://bugs.webkit.org/show_bug.cgi?id=26427. 4504 4505 * WebView.cpp: 4506 (EnumTextMatches::QueryInterface): 4507 4508 == Rolled over to ChangeLog-2009-06-16 == 4509
