1 2011-04-19 Vsevolod Vlasov <vsevik (a] chromium.org> 2 3 Reviewed by Pavel Feldman. 4 5 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength 6 https://bugs.webkit.org/show_bug.cgi?id=58883 7 8 * WebCoreSupport/WebFrameLoaderClient.h: 9 10 2011-04-18 Timothy Hatcher <timothy (a] apple.com> 11 12 Remove the two commands that make en.lproj and copy Localizable.strings. 13 14 Rubber-stamped by Adam Roben. 15 16 * WebKit.vcproj/WebKitLibPostBuild.cmd: 17 18 2011-04-18 Patrick Gansterer <paroga (a] webkit.org> 19 20 Reviewed by Adam Roben. 21 22 Include <WebCore/COMPtr.h> instead of "COMPtr.h" 23 https://bugs.webkit.org/show_bug.cgi?id=58744 24 25 * DOMCoreClasses.cpp: 26 * DOMHTMLClasses.cpp: 27 * WebActionPropertyBag.cpp: 28 * WebBackForwardList.cpp: 29 * WebCoreSupport/WebGeolocationClient.h: 30 * WebDownload.h: 31 * WebDropSource.h: 32 * WebFrame.cpp: 33 * WebHistoryItem.cpp: 34 * WebIconDatabase.cpp: 35 * WebNavigationData.h: 36 * WebPreferences.cpp: 37 * WebResource.h: 38 * WebURLAuthenticationChallenge.cpp: 39 * WebURLAuthenticationChallengeSender.cpp: 40 * WebURLAuthenticationChallengeSenderCFNet.cpp: 41 * WebURLAuthenticationChallengeSenderCurl.cpp: 42 * WebView.h: 43 44 2011-04-17 Patrick Gansterer <paroga (a] webkit.org> 45 46 Reviewed by Adam Barth. 47 48 Rename PLATFORM(CG) to USE(CG) 49 https://bugs.webkit.org/show_bug.cgi?id=58729 50 51 * WebFrame.cpp: 52 (WebFrame::spoolPages): 53 * WebFrame.h: 54 * WebPreferences.cpp: 55 (WebPreferences::setFontSmoothing): 56 (WebPreferences::setFontSmoothingContrast): 57 * WebView.cpp: 58 (systemParameterChanged): 59 60 2011-04-16 Sam Weinig <sam (a] webkit.org> 61 62 Reviewed by Simon Fraser. 63 64 Windows should use WebCore localized strings 65 <rdar://problem/9119405> 66 https://bugs.webkit.org/show_bug.cgi?id=58733 67 68 * WebCoreSupport/WebEditorClient.cpp: 69 (undoNameForEditAction): 70 (WebEditorClient::registerCommandForUndo): 71 * WebPreferences.cpp: 72 (WebPreferences::initializeDefaultSettings): 73 * WebURLResponse.cpp: 74 (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode): 75 (WebURLResponse::localizedStringForStatusCode): 76 Change to use WEB_UI_STRING. 77 78 * WebCoreSupport/WebPlatformStrategies.cpp: 79 * WebCoreSupport/WebPlatformStrategies.h: 80 Remove the localization strategy in favor of using the default one. 81 82 2011-04-16 Patrick Gansterer <paroga (a] webkit.org> 83 84 Reviewed by Eric Seidel. 85 86 Rename PLATFORM(CAIRO) to USE(CAIRO) 87 https://bugs.webkit.org/show_bug.cgi?id=55192 88 89 * WebFrame.cpp: 90 (WebFrame::spoolPages): 91 * WebFrame.h: 92 93 2011-04-14 Adam Roben <aroben (a] apple.com> 94 95 Replace some known-to-fail assertions with FIXMEs 96 97 These assertions get hit during various layout tests. They indicate that we're sometimes 98 doing some extra work when a page goes into accelerated compositing mode, but otherwise 99 there's no bad effect. 100 101 See <http://webkit.org/b/58539> for more details. 102 103 Rubber-stamped by John Sullivan. 104 105 * WebView.cpp: 106 (WebView::paintIntoBackingStore): 107 (WebView::paintIntoWindow): 108 Replaced assertions with FIXMEs. 109 110 2011-04-13 James Robinson <jamesr (a] chromium.org> 111 112 Reviewed by Simon Fraser. 113 114 Allow setting composited backing stores for scrollbars and scroll corners 115 https://bugs.webkit.org/show_bug.cgi?id=57202 116 117 Update WebScrollBar to reflect ScrollableArea interface changes. 118 119 * WebScrollBar.h: 120 (WebScrollBar::invalidateScrollCornerRect): 121 (WebScrollBar::scrollCornerPresent): 122 (WebScrollBar::scrollCornerRect): 123 124 2011-04-12 Alice Liu <alice.liu (a] apple.com> 125 126 Reviewed by Sam Weinig. 127 128 https://bugs.webkit.org/show_bug.cgi?id=58292 129 Provide new setting to allow site icon loading despite disabling automatic image loading in general. 130 131 * Interfaces/IWebPreferencesPrivate.idl: Added prefs. 132 * Interfaces/WebKit.idl: Touch file to force autogeneration 133 * WebPreferenceKeysPrivate.h: Add preference key. 134 * WebPreferences.cpp: 135 (WebPreferences::initializeDefaultSettings): Initialize setting to false. 136 (WebPreferences::setLoadsSiteIconsIgnoringImageLoadingPreference): Added setter 137 (WebPreferences::loadsSiteIconsIgnoringImageLoadingPreference): Added getter 138 * WebPreferences.h: 139 * WebView.cpp: 140 (WebView::notifyPreferencesChanged): Add to settings that get propagated upon changes. 141 142 2011-04-11 Alexey Proskuryakov <ap (a] apple.com> 143 144 Reviewed by Maciej Stachowiak. 145 146 WebKit2: Cannot use Ctrl-Delete as a custom keyboard shortcut 147 https://bugs.webkit.org/show_bug.cgi?id=58265 148 <rdar://problem/9221468> 149 150 * WebView.cpp: (WebView::keyDown): Removed special handling of Backspace, which is unnecessary 151 now that WebCore implements it. 152 153 2011-04-06 Brian Weinstein <bweinstein (a] apple.com> 154 155 Reviewed by Adam Roben. 156 157 WebKit2: Support Windows 7 Gestures 158 https://bugs.webkit.org/show_bug.cgi?id=49824 159 <rdar://problem/8689728> 160 161 Move WindowsTouch.h from WebKit/win to WebCore/platform/win, so it can be 162 used in both WebKit and WebKit2. 163 164 * WebKit.vcproj/WebKit.vcproj: Remove WindowsTouch.h. 165 * WebView.cpp: Include WindowsTouch.h from WebCore instead of WebKit. 166 * WindowsTouch.h: Removed. 167 168 2011-04-05 Martin Robinson <mrobinson (a] igalia.com> 169 170 Reviewed by Eric Seidel. 171 172 [Cairo] Better separate the concerns of GraphicsContextCairo 173 https://bugs.webkit.org/show_bug.cgi?id=55150 174 175 * WebFrame.cpp: 176 (hdcFromContext): Modify this method to take PlatformContextCairo 177 instead of a cairo_t. 178 (WebFrame::spoolPage): Update to reflect new platform context. 179 (WebFrame::spoolPages): Ditto. 180 * WebFrame.h: Ditto. 181 182 2011-04-04 MORITA Hajime <morrita (a] google.com> 183 184 Reviewed by Ryosuke Niwa. 185 186 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult 187 https://bugs.webkit.org/show_bug.cgi?id=56085 188 189 * WebCoreSupport/WebEditorClient.h: 190 (WebEditorClient::requestCheckingOfString): 191 192 2011-04-04 Alexey Proskuryakov <ap (a] apple.com> 193 194 Reviewed by Dan Bernstein. 195 196 REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2 197 https://bugs.webkit.org/show_bug.cgi?id=51230 198 <rdar://problem/8780989> 199 200 * WebView.cpp: (WebView::keyDown): Moved Caps Lock handling from WebKits to WebCore, 201 because WebKit shouldn't be smart. 202 203 2011-04-04 Steve Falkenburg <sfalken (a] apple.com> 204 205 Reviewed by Adam Roben. 206 207 Remove unused AnalyzeWithLargeStack code from Windows build files 208 https://bugs.webkit.org/show_bug.cgi?id=57771 209 210 This was used for us to build with prefast automatically, 211 but it is out-of-date and hasn't been used for some time. 212 Removing completely for now. 213 214 * WebKit.vcproj/WebKitLibPreBuild.cmd: 215 216 2011-04-01 Adam Roben <aroben (a] apple.com> 217 218 Remove the WebView's "this" pointer from its HWND when WM_DESTROY is received 219 220 This will ensure we don't try to process any window messages after the window has been 221 destroyed. 222 223 Covered by existing tests. 224 225 Fixes <http://webkit.org/b/55054>. 226 227 Reviewed by Steve Falkenburg and John Sullivan. 228 229 * WebView.cpp: 230 (WebView::setIsBeingDestroyed): Moved here from the header file, and added a call to clear 231 out the this pointer from the HWND. 232 (WebView::WebViewWndProc): Changed a runtime check into an assertion. 233 234 * WebView.h: Moved setIsBeingDestroyed from here to the .cpp file. 235 236 2011-03-31 Evan Martin <evan (a] chromium.org> 237 238 Reviewed by Eric Seidel. 239 240 <title> should support dir attribute 241 https://bugs.webkit.org/show_bug.cgi?id=50961 242 243 Update to new FrameLoaderClient interface. 244 245 * WebCoreSupport/WebFrameLoaderClient.cpp: 246 (WebFrameLoaderClient::dispatchDidReceiveTitle): 247 * WebCoreSupport/WebFrameLoaderClient.h: 248 249 2011-03-30 Steve Falkenburg <sfalken (a] apple.com> 250 251 Reviewed by Adam Roben. 252 253 Share most vsprops between Release and Production builds in releaseproduction.vsprops 254 https://bugs.webkit.org/show_bug.cgi?id=57508 255 256 * WebKit.vcproj/InterfacesProduction.vsprops: 257 * WebKit.vcproj/InterfacesRelease.vsprops: 258 * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops: 259 * WebKit.vcproj/WebKitGUIDProduction.vsprops: 260 * WebKit.vcproj/WebKitGUIDRelease.vsprops: 261 * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops: 262 * WebKit.vcproj/WebKitLibProduction.vsprops: 263 * WebKit.vcproj/WebKitLibRelease.vsprops: 264 * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: 265 266 2011-03-30 Steve Falkenburg <sfalken (a] apple.com> 267 268 Reviewed by Adam Roben. 269 270 Update Windows production build logic for new production configurations 271 https://bugs.webkit.org/show_bug.cgi?id=57494 272 273 * WebKit.vcproj/InterfacesProduction.vsprops: 274 * WebKit.vcproj/WebKit.make: 275 * WebKit.vcproj/WebKitGUIDProduction.vsprops: 276 * WebKit.vcproj/WebKitLibProduction.vsprops: 277 278 2011-03-30 Steve Falkenburg <sfalken (a] apple.com> 279 280 Reviewed by Adam Roben. 281 282 Rename Windows configuration Release_LTCG to Production for clarity 283 https://bugs.webkit.org/show_bug.cgi?id=57465 284 285 * WebKit.vcproj/Interfaces.vcproj: 286 * WebKit.vcproj/InterfacesProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/InterfacesReleaseLTCG.vsprops. 287 * WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Removed. 288 * WebKit.vcproj/WebKit.sln: 289 * WebKit.vcproj/WebKit.submit.sln: 290 * WebKit.vcproj/WebKit.vcproj: 291 * WebKit.vcproj/WebKitGUID.vcproj: 292 * WebKit.vcproj/WebKitGUIDProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops. 293 * WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Removed. 294 * WebKit.vcproj/WebKitLibProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitLibReleaseLTCG.vsprops. 295 * WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Removed. 296 297 2011-03-29 Patrick Gansterer <paroga (a] webkit.org> 298 299 Reviewed by Adam Roben. 300 301 [WIN] Remove unused GEN_DOMObject files 302 https://bugs.webkit.org/show_bug.cgi?id=57370 303 304 * GEN_DOMObject.cpp: Removed. 305 * GEN_DOMObject.h: Removed. 306 307 2011-03-29 Steve Falkenburg <sfalken (a] apple.com> 308 309 More build fix. 310 311 * WebCoreSupport/WebPlatformStrategies.h: 312 313 2011-03-29 Steve Falkenburg <sfalken (a] apple.com> 314 315 Build fix. 316 317 * WebCoreSupport/WebPlatformStrategies.cpp: 318 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): 319 320 2011-03-29 Patrick Gansterer <paroga (a] webkit.org> 321 322 Unreviewed. Try to fix Windows build. 323 324 * DOMEventsClasses.cpp: Added initguid.h again. 325 326 2011-03-29 Patrick Gansterer <paroga (a] webkit.org> 327 328 Reviewed by Adam Roben. 329 330 [WIN] Cleanup includes in WebKit files 331 https://bugs.webkit.org/show_bug.cgi?id=57381 332 333 Add missing includes to fix build without precompiled header. 334 Also fix paths in #include statements (e.g. WTF -> wtf). 335 336 * AccessibleBase.h: 337 * AccessibleDocument.h: Replace using statement with a qualified name. 338 * CFDictionaryPropertyBag.h: 339 * DOMEventsClasses.cpp: 340 * DOMHTMLClasses.h: 341 * DefaultDownloadDelegate.cpp: 342 * DefaultDownloadDelegate.h: 343 * DefaultPolicyDelegate.cpp: 344 * DefaultPolicyDelegate.h: 345 * WebCoreSupport/EmbeddedWidget.h: 346 * WebCoreSupport/WebInspectorDelegate.h: 347 * WebDataSource.h: 348 * WebDatabaseManager.h: 349 * WebElementPropertyBag.h: 350 * WebFramePolicyListener.h: 351 * WebGeolocationPolicyListener.h: 352 * WebHistory.h: 353 * WebKitClassFactory.h: 354 * WebScriptWorld.h: 355 * WebSerializedJSValue.h: 356 * WebUserContentURLPattern.h: 357 358 2011-03-29 Steve Falkenburg <sfalken (a] apple.com> 359 360 Reviewed by Darin Adler. 361 362 Use per-configuration vsprops in WebKit to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE 363 https://bugs.webkit.org/show_bug.cgi?id=57383 364 365 Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from 366 InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within 367 the IDE. To avoid this, add a separate vsprops file for each project configuration that 368 contains the required inherited property sheets. 369 370 * WebKit.vcproj/Interfaces.vcproj: 371 * WebKit.vcproj/InterfacesDebug.vsprops: Added. 372 * WebKit.vcproj/InterfacesDebugAll.vsprops: Added. 373 * WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops: Added. 374 * WebKit.vcproj/InterfacesRelease.vsprops: Added. 375 * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops: Added. 376 * WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Added. 377 * WebKit.vcproj/WebKit.vcproj: 378 * WebKit.vcproj/WebKitGUID.vcproj: 379 * WebKit.vcproj/WebKitGUIDDebug.vsprops: Added. 380 * WebKit.vcproj/WebKitGUIDDebugAll.vsprops: Added. 381 * WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops: Added. 382 * WebKit.vcproj/WebKitGUIDRelease.vsprops: Added. 383 * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops: Added. 384 * WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Added. 385 * WebKit.vcproj/WebKitLibDebug.vsprops: Added. 386 * WebKit.vcproj/WebKitLibDebugAll.vsprops: Added. 387 * WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops: Added. 388 * WebKit.vcproj/WebKitLibRelease.vsprops: Added. 389 * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: Added. 390 * WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Added. 391 392 2011-03-29 Patrick Gansterer <paroga (a] webkit.org> 393 394 Reviewed by Adam Roben. 395 396 Remove #pragma warning push and pop statements 397 https://bugs.webkit.org/show_bug.cgi?id=57198 398 399 We do not need to disable warnings via #pragma since we started 400 compiling WebCore with the same compiler warnings flags as WebKit. 401 402 * DOMCSSClasses.cpp: 403 * DOMCoreClasses.cpp: 404 * DOMEventsClasses.cpp: 405 * DOMHTMLClasses.cpp: 406 * DefaultDownloadDelegate.cpp: 407 * DefaultPolicyDelegate.cpp: 408 * MarshallingHelpers.cpp: 409 * WebActionPropertyBag.cpp: 410 * WebActionPropertyBag.h: 411 * WebCache.cpp: 412 * WebCoreSupport/WebDragClient.cpp: 413 * WebCoreSupport/WebEditorClient.cpp: 414 * WebCoreSupport/WebEditorClient.h: 415 * WebCoreSupport/WebFrameLoaderClient.cpp: 416 * WebCoreSupport/WebFrameLoaderClient.h: 417 * WebCoreSupport/WebInspectorClient.cpp: 418 * WebDocumentLoader.h: 419 * WebDownload.cpp: 420 * WebDownloadCFNet.cpp: 421 * WebDownloadCurl.cpp: 422 * WebElementPropertyBag.cpp: 423 * WebError.cpp: 424 * WebError.h: 425 * WebFrame.cpp: 426 * WebFrame.h: 427 * WebFramePolicyListener.cpp: 428 * WebFramePolicyListener.h: 429 * WebHistory.cpp: 430 * WebHistoryItem.cpp: 431 * WebIconDatabase.cpp: 432 * WebIconDatabase.h: 433 * WebInspector.cpp: 434 * WebJavaScriptCollector.cpp: 435 * WebKitGraphics.cpp: 436 * WebKitSystemBits.cpp: 437 * WebLocalizableStrings.cpp: 438 * WebMutableURLRequest.cpp: 439 * WebMutableURLRequest.h: 440 * WebNodeHighlight.cpp: 441 * WebNodeHighlight.h: 442 * WebNotificationCenter.cpp: 443 * WebResource.cpp: 444 * WebResource.h: 445 * WebScrollBar.cpp: 446 * WebScrollBar.h: 447 * WebURLAuthenticationChallenge.cpp: 448 * WebURLAuthenticationChallenge.h: 449 * WebURLAuthenticationChallengeSender.cpp: 450 * WebURLAuthenticationChallengeSenderCFNet.cpp: 451 * WebURLAuthenticationChallengeSenderCurl.cpp: 452 * WebURLCredential.cpp: 453 * WebURLCredential.h: 454 * WebURLProtectionSpace.cpp: 455 * WebURLProtectionSpace.h: 456 * WebURLResponse.cpp: 457 * WebURLResponse.h: 458 459 2011-03-29 Brent Fulgham <bfulgham (a] webkit.org> 460 461 Unreviewed build fix after r82247. 462 463 * WebMutableURLRequest.cpp: The new CertificateCFWin routines 464 are not CFNetwork-specific. All CF-based ports can use them. 465 466 2011-03-29 Patrick Gansterer <paroga (a] webkit.org> 467 468 Reviewed by Adam Roben. 469 470 [WIN] Use WCHAR instead of TCHAR 471 https://bugs.webkit.org/show_bug.cgi?id=57191 472 473 We always use the UNICODE versions of windows functions, so 474 the usage of TCHAR makes no sense and mixing them is bad style. 475 476 * DefaultDownloadDelegate.cpp: 477 * WebCoreSupport/WebChromeClient.cpp: 478 * WebCoreSupport/WebContextMenuClient.cpp: 479 * WebCoreSupport/WebInspectorClient.cpp: 480 * WebKitDLL.cpp: 481 * WebNotificationCenter.cpp: 482 * WebPreferences.cpp: 483 * WebURLResponse.cpp: 484 * WebView.cpp: 485 486 2011-03-29 Jeff Miller <jeffm (a] apple.com> 487 488 Reviewed by Jon Honeycutt. 489 490 Add WebCore::copyCertificateToData() on Windows 491 https://bugs.webkit.org/show_bug.cgi?id=57296 492 493 Remove duplicate code that implemented this functionality in WebMutableURLRequest.cpp and use WebCore::copyCertificateToData() instead. 494 495 * WebMutableURLRequest.cpp: 496 (WebMutableURLRequest::setClientCertificate): Use WebCore::copyCertificateToData(). 497 498 2011-03-28 Patrick Gansterer <paroga (a] webkit.org> 499 500 Reviewed by Adam Roben. 501 502 [WIN] Remove unused DOMCreateInstance files 503 https://bugs.webkit.org/show_bug.cgi?id=57193 504 505 * DOMCreateInstance.cpp: Removed. 506 * DOMCreateInstance.h: Removed. 507 508 2011-03-28 Adele Peterson <adele (a] apple.com> 509 510 Build fix. 511 512 * WebFrame.cpp: (WebFrame::hasSpellingMarker): 513 Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor. 514 515 2011-03-28 Jeff Miller <jeffm (a] apple.com> 516 517 Reviewed by Adam Roben. 518 519 Include certificate when sending a WebCore::ResourceError to UI process on Windows 520 https://bugs.webkit.org/show_bug.cgi?id=57195 521 522 Rename callers of wkGetSSLPeerCertificateData() to use wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*. 523 524 * WebError.cpp: 525 (WebError::sslPeerCertificate): 526 * WebURLResponse.cpp: 527 (WebURLResponse::sslPeerCertificate): 528 529 2011-03-28 Darin Adler <darin (a] apple.com> 530 531 Set eol-style to native on more files. I noticed the last check-in had an entire file 532 changing because of an EOL style change, and setting this property prevents that from 533 happening in future. We may want to do this systematically for more of WebKit later. 534 535 * AccessibleBase.cpp: Added property svn:eol-style. 536 * AccessibleBase.h: Added property svn:eol-style. 537 * AccessibleDocument.cpp: Added property svn:eol-style. 538 * AccessibleDocument.h: Added property svn:eol-style. 539 * AccessibleImage.cpp: Added property svn:eol-style. 540 * AccessibleImage.h: Added property svn:eol-style. 541 * COMVariantSetter.h: Added property svn:eol-style. 542 * FullscreenVideoController.cpp: Added property svn:eol-style. 543 * FullscreenVideoController.h: Added property svn:eol-style. 544 * WebCoreSupport/EmbeddedWidget.cpp: Added property svn:eol-style. 545 * WebCoreSupport/EmbeddedWidget.h: Added property svn:eol-style. 546 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added property svn:eol-style. 547 * WebCoreSupport/WebDesktopNotificationsDelegate.h: Added property svn:eol-style. 548 * WebCoreSupport/WebFrameLoaderClient.cpp: Added property svn:eol-style. 549 * WebCoreSupport/WebInspectorDelegate.cpp: Added property svn:eol-style. 550 * WebCoreSupport/WebInspectorDelegate.h: Added property svn:eol-style. 551 * WebCoreSupport/WebPlatformStrategies.cpp: Added property svn:eol-style. 552 * WebCoreSupport/WebPlatformStrategies.h: Added property svn:eol-style. 553 * WebCoreSupport/WebPluginHalterClient.cpp: Added property svn:eol-style. 554 * WebCoreSupport/WebPluginHalterClient.h: Added property svn:eol-style. 555 556 2011-03-28 Patrick Gansterer <paroga (a] webkit.org> 557 558 Unreviewed build fix. 559 560 * COMPropertyBag.h: Added missing include. 561 * WebKitCOMAPI.h: Ditto. 562 * WebCoreSupport/WebFrameLoaderClient.h: Added missing forward declaration. 563 564 2011-03-25 Sam Weinig <sam (a] webkit.org> 565 566 Reviewed by Jon Honeycutt. 567 568 WebScrollBar not updating when calling WebScrollBar::setValue. 569 <rdar://problem/9143871> 570 571 * WebScrollBar.cpp: 572 (WebScrollBar::setValue): 573 Call scrollToOffsetWithoutAnimation to actually update the scroll position. 574 575 2011-03-25 Andy Estes <aestes (a] apple.com> 576 577 Reviewed by Adele Peterson. 578 579 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js 580 https://bugs.webkit.org/show_bug.cgi?id=49016 581 582 Update objectContentType() implementation to handle the 583 shouldPreferPlugInsForImages flag. 584 585 * WebFrame.cpp: 586 (WebFrame::objectContentType): 587 * WebFrame.h: 588 589 2011-03-24 Sheriff Bot <webkit.review.bot (a] gmail.com> 590 591 Unreviewed, rolling out r81916 and r81917. 592 http://trac.webkit.org/changeset/81916 593 http://trac.webkit.org/changeset/81917 594 https://bugs.webkit.org/show_bug.cgi?id=57071 595 596 broke a test on platforms that do not have QuickTime installed 597 (Requested by estes on #webkit). 598 599 * WebFrame.cpp: 600 (WebFrame::objectContentType): 601 * WebFrame.h: 602 603 2011-03-24 Andy Estes <aestes (a] apple.com> 604 605 Reviewed by Darin Adler. 606 607 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js 608 https://bugs.webkit.org/show_bug.cgi?id=49016 609 610 Update objectContentType() implementation to handle the 611 shouldPreferPlugInsForImages flag. 612 613 * WebFrame.cpp: 614 (WebFrame::objectContentType): 615 * WebFrame.h: 616 617 2011-03-23 Brady Eidson <beidson (a] apple.com> 618 619 Reviewed by Sam Weinig. 620 621 Change IconDatabase opening to allow for arbitrary filenames 622 https://bugs.webkit.org/show_bug.cgi?id=56977 623 624 * WebIconDatabase.cpp: 625 (WebIconDatabase::startUpIconDatabase): 626 627 2011-03-22 Brady Eidson <beidson (a] apple.com> 628 629 Reviewed by Sam Weinig. 630 631 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876 632 WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread 633 634 Note that while the new client calls always come through on the main thread, our mechanisms to 635 route dispatches to the main thread are still valid and will still work. 636 637 Update to the new IconDatabaseClient interface: 638 * WebIconDatabase.cpp: 639 (WebIconDatabase::performImport): 640 (WebIconDatabase::didRemoveAllIcons): 641 (WebIconDatabase::didImportIconURLForPageURL): 642 (WebIconDatabase::didImportIconDataForPageURL): 643 (WebIconDatabase::didChangeIconForPageURL): 644 (WebIconDatabase::didFinishURLImport): 645 * WebIconDatabase.h: 646 647 2011-03-17 Brady Eidson <beidson (a] apple.com> 648 649 Reviewed by Sam Weinig. 650 651 https://bugs.webkit.org/show_bug.cgi?id=56425 652 More groundwork for WebKit2 IconDatabase 653 654 Update already-used function names: 655 * WebIconDatabase.cpp: 656 (WebIconDatabase::iconForURL): 657 (WebIconDatabase::iconURLForURL): 658 (WebIconDatabase::hasIconForURL): 659 660 2011-03-18 Pavel Podivilov <podivilov (a] chromium.org> 661 662 Reviewed by Yury Semikhatsky. 663 664 Web Inspector: implement inspector session storage. 665 https://bugs.webkit.org/show_bug.cgi?id=56643 666 667 * WebCoreSupport/WebInspectorClient.cpp: 668 (WebInspectorClient::saveSessionSetting): 669 (WebInspectorClient::loadSessionSetting): 670 (WebInspectorFrontendClient::saveSessionSetting): 671 (WebInspectorFrontendClient::loadSessionSetting): 672 * WebCoreSupport/WebInspectorClient.h: 673 674 2011-03-11 Brady Eidson <beidson (a] apple.com> 675 676 More Windows build fix for https://bugs.webkit.org/show_bug.cgi?id=56216 677 678 * WebCoreStatistics.cpp: 679 * WebIconDatabase.cpp: 680 681 2011-03-09 Peter Kasting <pkasting (a] google.com> 682 683 Reviewed by Mihai Parparita. 684 685 Unify Windows version checks. 686 https://bugs.webkit.org/show_bug.cgi?id=55979 687 688 * WebView.cpp: 689 (WebView::standardUserAgentWithApplicationName): 690 (webKitVersionString): 691 692 2011-03-07 Sam Weinig <sam (a] webkit.org> 693 694 Reviewed by Anders Carlsson. 695 696 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse 697 https://bugs.webkit.org/show_bug.cgi?id=55827 698 699 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse 700 and pass the entire response, instead of just the MIMEType. 701 702 * WebFrame.cpp: 703 (WebFrame::dispatchDecidePolicyForResponse): 704 * WebFrame.h: 705 706 2011-03-04 Steve Falkenburg <sfalken (a] apple.com> 707 708 Reviewed by Darin Adler. 709 710 Adopt VersionStamper tool for Windows WebKit DLLs 711 https://bugs.webkit.org/show_bug.cgi?id=55784 712 713 Calculate the WebKit version for the useragent via autoversion.h 714 instead of reading it back from the DLL. 715 716 We now use a tool to stamp the version number onto the Apple WebKit DLLs 717 during the post-build step. 718 719 * WebKit.vcproj/WebKit.rc: Removed. This file wasn't used. 720 * WebKit.vcproj/WebKitLibCommon.vsprops: Fetch version from a string resource. 721 * WebView.cpp: 722 (WebView::standardUserAgentWithApplicationName): Use __BUILD_NUMBER_SHORT__ for the version. 723 (osVersion): Removed 724 725 2011-03-03 Anders Carlsson <andersca (a] apple.com> 726 727 Reviewed by Sam Weinig. 728 729 Get rid of Page::globalHistoryItem 730 https://bugs.webkit.org/show_bug.cgi?id=55738 731 732 * WebCoreSupport/WebFrameLoaderClient.cpp: 733 (WebFrameLoaderClient::updateGlobalHistoryItemForPage): 734 Get the current history item and update it using WebView::setGlobalHistoryItem. 735 736 * WebCoreSupport/WebFrameLoaderClient.h: 737 * WebView.cpp: 738 (WebView::globalHistoryItem): 739 (WebView::setGlobalHistoryItem): 740 * WebView.h: 741 742 2011-03-03 Brent Fulgham <bfulgham (a] webkit.org> 743 744 Unreviewed build correction. 745 746 * WebFrame.cpp: 747 (scaleFactor): Update after 77286 to replace right/bottom 748 with new maxX/maxY terminology. 749 750 2011-03-03 Brady Eidson <beidson (a] apple.com> 751 752 Reviewed by Darin Adler. 753 754 https://bugs.webkit.org/show_bug.cgi?id=55721 755 Global IconDatabase should be returned by reference, not as a pointer 756 757 * WebCoreStatistics.cpp: 758 (WebCoreStatistics::iconPageURLMappingCount): 759 (WebCoreStatistics::iconRetainedPageURLCount): 760 (WebCoreStatistics::iconRecordCount): 761 (WebCoreStatistics::iconsWithDataCount): 762 * WebIconDatabase.cpp: 763 (WebIconDatabase::init): 764 (WebIconDatabase::startUpIconDatabase): 765 (WebIconDatabase::iconForURL): 766 (WebIconDatabase::retainIconForURL): 767 (WebIconDatabase::releaseIconForURL): 768 (WebIconDatabase::removeAllIcons): 769 (WebIconDatabase::iconURLForURL): 770 (WebIconDatabase::isEnabled): 771 (WebIconDatabase::setEnabled): 772 (WebIconDatabase::hasIconForURL): 773 (WebIconDatabase::getOrCreateDefaultIconBitmap): 774 * WebKitDLL.cpp: 775 (shutDownWebKit): 776 777 2011-03-03 Alexey Proskuryakov <ap (a] apple.com> 778 779 Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included 780 via ChromeClient.h 781 782 * WebCoreSupport/WebChromeClient.h: 783 784 2011-03-02 Alexey Proskuryakov <ap (a] apple.com> 785 786 Reviewed by Darin Adler. 787 788 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access 789 https://bugs.webkit.org/show_bug.cgi?id=55633 790 <rdar://problem/8963023> 791 792 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::keyboardUIMode): 793 * WebCoreSupport/WebChromeClient.h: 794 Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since 795 this platform doesn't observe or have full keyboard access state. 796 797 2011-03-03 Peter Kasting <pkasting (a] google.com> 798 799 Reviewed by James Robinson. 800 801 Drop redundant "Windows; " from the Windows-specific User Agent string. 802 https://bugs.webkit.org/show_bug.cgi?id=54567 803 804 * WebView.cpp: 805 (WebView::standardUserAgentWithApplicationName): 806 807 2011-03-01 Brian Weinstein <bweinstein (a] apple.com> 808 809 Reviewed by Adam Roben. 810 811 Part of WebKit2: Need a way to send notifications to client when cookies change 812 https://bugs.webkit.org/show_bug.cgi?id=55427 813 <rdar://problem/9056027> 814 815 Add stubs for CookiesStrategy on Windows WebKit1. 816 817 * WebCoreSupport/WebPlatformStrategies.cpp: 818 (WebPlatformStrategies::createCookiesStrategy): 819 (WebPlatformStrategies::notifyCookiesChanged): 820 * WebCoreSupport/WebPlatformStrategies.h: 821 822 2011-02-28 Chang Shu <cshu (a] webkit.org> 823 824 Reviewed by Ryosuke Niwa. 825 826 Remove the support of Frame::isContentEditable and its dependencies. 827 https://bugs.webkit.org/show_bug.cgi?id=54292 828 829 Remove the WebKit side implementation. 830 831 * WebCoreSupport/WebEditorClient.cpp: 832 * WebCoreSupport/WebEditorClient.h: 833 834 2011-02-28 Adam Roben <aroben (a] apple.com> 835 836 Build TestWebKitAPIInjectedBundle on Windows 837 838 Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows 839 840 Reviewed by Darin Adler. 841 842 * WebKit.vcproj/WebKit.sln: Added TestWebKitAPIInjectedBundle. Let VS simplify the paths to 843 the project files. 844 845 2011-02-28 Sheriff Bot <webkit.review.bot (a] gmail.com> 846 847 Unreviewed, rolling out r78789. 848 http://trac.webkit.org/changeset/78789 849 https://bugs.webkit.org/show_bug.cgi?id=55409 850 851 Incorrect canvas fallback implementation (Requested by 852 inferno-sec on #webkit). 853 854 * AccessibleBase.cpp: 855 (MSAARole): 856 857 2011-02-26 Vsevolod Vlasov <vsevik (a] chromium.org> 858 859 Reviewed by Pavel Feldman. 860 861 DumpRenderTree should reset frame opener between tests. 862 https://bugs.webkit.org/show_bug.cgi?id=54874 863 864 Added clearOpener method to IWebFramePrivate. 865 Touched WebKit.idl to trigger build scripts. 866 867 * Interfaces/IWebFramePrivate.idl: 868 * Interfaces/WebKit.idl: 869 * WebFrame.cpp: 870 (WebFrame::clearOpener): 871 * WebFrame.h: 872 873 2011-02-26 Sheriff Bot <webkit.review.bot (a] gmail.com> 874 875 Unreviewed, rolling out r79764. 876 http://trac.webkit.org/changeset/79764 877 https://bugs.webkit.org/show_bug.cgi?id=55295 878 879 "broke Chromium builds" (Requested by rniwa on #webkit). 880 881 * Interfaces/IWebFramePrivate.idl: 882 * Interfaces/WebKit.idl: 883 * WebFrame.cpp: 884 * WebFrame.h: 885 886 2011-02-26 Vsevolod Vlasov <vsevik (a] chromium.org> 887 888 Reviewed by Pavel Feldman. 889 890 DumpRenderTree should reset frame opener between tests. 891 https://bugs.webkit.org/show_bug.cgi?id=54874 892 893 Added clearOpener method to IWebFramePrivate. 894 Touched WebKit.idl to trigger build scripts. 895 896 * Interfaces/IWebFramePrivate.idl: 897 * Interfaces/WebKit.idl: 898 * WebFrame.cpp: 899 (WebFrame::clearOpener): 900 * WebFrame.h: 901 902 2011-02-24 Peter Kasting <pkasting (a] google.com> 903 904 Reviewed by Eric Seidel. 905 906 Drop the "U; " encryption level from the User Agent string. 907 https://bugs.webkit.org/show_bug.cgi?id=54566 908 909 * WebView.cpp: 910 (WebView::standardUserAgentWithApplicationName): 911 912 2011-02-24 Andrew Wilson <atwilson (a] chromium.org> 913 914 Unreviewed, rolling out r79570. 915 http://trac.webkit.org/changeset/79570 916 https://bugs.webkit.org/show_bug.cgi?id=54874 917 918 Breaks chromium build because glue/mocks/mock_web_frame.h/cc 919 was not updated 920 921 * Interfaces/IWebFramePrivate.idl: 922 * Interfaces/WebKit.idl: 923 * WebFrame.cpp: 924 * WebFrame.h: 925 926 2011-02-24 Vsevolod Vlasov <vsevik (a] chromium.org> 927 928 Reviewed by Alexey Proskuryakov. 929 930 DumpRenderTree should reset frame opener between tests. 931 https://bugs.webkit.org/show_bug.cgi?id=54874 932 933 Added clearOpener method to IWebFramePrivate. 934 Touched WebKit.idl to trigger build scripts. 935 936 * Interfaces/IWebFramePrivate.idl: 937 * Interfaces/WebKit.idl: 938 * WebFrame.cpp: 939 (WebFrame::clearOpener): 940 * WebFrame.h: 941 942 2011-02-23 Patrick Gansterer <paroga (a] webkit.org> 943 944 Reviewed by Darin Adler. 945 946 Rename PLATFORM(CF) to USE(CF) 947 https://bugs.webkit.org/show_bug.cgi?id=53540 948 949 * WebView.cpp: 950 951 2011-02-22 Laszlo Gombos <laszlo.1.gombos (a] nokia.com> 952 953 Reviewed by Alexey Proskuryakov. 954 955 Drop the language tag part from the User Agent string 956 https://bugs.webkit.org/show_bug.cgi?id=54560 957 958 * WebView.cpp: 959 (WebView::standardUserAgentWithApplicationName): 960 961 2011-02-19 Charlie Reis <creis (a] chromium.org> 962 963 Reviewed by Mihai Parparita. 964 965 Ensure loading has stopped in HistoryController::goToItem 966 https://bugs.webkit.org/show_bug.cgi?id=54517 967 968 Add a FrameLoaderClient callback for whether to stop loading before goToItem. 969 970 Test: http/tests/navigation/forward-to-fragment-fires-onload.html 971 972 * WebCoreSupport/WebFrameLoaderClient.cpp: 973 (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added. 974 * WebCoreSupport/WebFrameLoaderClient.h: 975 976 2011-02-16 David Hyatt <hyatt (a] apple.com> 977 978 Reviewed by Dan Bernstein. 979 980 https://bugs.webkit.org/show_bug.cgi?id=54244 981 982 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding 983 hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats. 984 985 The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have 986 been changed as well. 987 988 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height). 989 990 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting. 991 992 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes 993 still have a precise floating point position. 994 995 Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already 996 be rounding justification spacing in their font code. 997 998 Many layout test results change on Mac, since rounding hacks were used there and are now gone. 999 1000 * WebKitGraphics.cpp: 1001 (CenterTruncateStringToWidth): 1002 (RightTruncateStringToWidth): 1003 1004 2011-02-10 Luiz Agostini <luiz.agostini (a] openbossa.org> 1005 1006 Reviewed by Adam Roben. 1007 1008 HTML5 <details> and <summary>: localized text 1009 https://bugs.webkit.org/show_bug.cgi?id=54260 1010 1011 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to 1012 provide the default label to be used by a <details> tag that has no <summary> child. 1013 1014 * WebCoreSupport/WebPlatformStrategies.cpp: 1015 (WebPlatformStrategies::defaultDetailsSummaryText): 1016 * WebCoreSupport/WebPlatformStrategies.h: 1017 1018 2011-02-16 Dominic Mazzoni <dmazzoni (a] google.com> 1019 1020 Reviewed by Chris Fleizach. 1021 1022 Add new role for canvas elements. 1023 1024 https://bugs.webkit.org/show_bug.cgi?id=50126 1025 1026 Test: accessibility/canvas-fallback-content.html 1027 1028 * AccessibleBase.cpp: 1029 (MSAARole): 1030 1031 2011-02-15 Kenneth Russell <kbr (a] google.com> 1032 1033 Unreviewed. Remove whitespace-only change from 1034 http://trac.webkit.org/changeset/78620 (https://bugs.webkit.org/show_bug.cgi?id=54312) 1035 now that the patch has passed the Windows build bots. 1036 1037 * Interfaces/WebKit.idl: 1038 1039 2011-02-15 Kenneth Russell <kbr (a] google.com> 1040 1041 Reviewed by Darin Fisher. 1042 1043 Allow controlling minimum DOMTimer interval on a per-page basis 1044 https://bugs.webkit.org/show_bug.cgi?id=54312 1045 1046 Added needed methods to implement LayoutTestController's new 1047 setMinimumTimerInterval method. Includes whitespace-only change to 1048 WebKit.idl to trigger proper rebuild on bots; will be removed in 1049 subsequent checkin. 1050 1051 * Interfaces/IWebViewPrivate.idl: 1052 * Interfaces/WebKit.idl: 1053 * WebView.cpp: 1054 (WebView::initWithFrame): 1055 (WebView::defaultMinimumTimerInterval): 1056 (WebView::setMinimumTimerInterval): 1057 * WebView.h: 1058 1059 2011-01-26 MORITA Hajime <morrita (a] google.com> 1060 1061 Reviewed by Ryosuke Niwa. 1062 1063 Refactoring: Extract TextCheckerClient from EditorClient 1064 https://bugs.webkit.org/show_bug.cgi?id=53213 1065 1066 * WebCoreSupport/WebEditorClient.h: 1067 (WebEditorClient::textChecker): 1068 1069 2011-02-07 Ryosuke Niwa <rniwa (a] webkit.org> 1070 1071 Reviewed by Adam Barth. 1072 1073 Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard 1074 https://bugs.webkit.org/show_bug.cgi?id=52417 1075 1076 Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently 1077 not implemented. 1078 1079 * WebCoreSupport/WebEditorClient.cpp: 1080 (WebEditorClient::canCopyCut): Added. 1081 (WebEditorClient::canPaste): Added. 1082 * WebCoreSupport/WebEditorClient.h: 1083 1084 2011-02-14 Brian Weinstein <bweinstein (a] apple.com> 1085 1086 Reviewed by Brady Eidson. 1087 1088 Need WebKit API to determine whether we have a site icon for a given URL 1089 https://bugs.webkit.org/show_bug.cgi?id=54400 1090 1091 This patch implements IWebIconDatabase::hasIconForURL which tells us whether or not 1092 we have a site icon for the given URL. 1093 1094 * Interfaces/IWebIconDatabase.idl: Added new function. 1095 * Interfaces/WebKit.idl: Touched to make sure Interfaces rebuilds. 1096 * WebIconDatabase.cpp: 1097 (WebIconDatabase::hasIconForURL): Call IconDatabase::iconForPageURL to make sure we 1098 load the icon from disk, and call iconURLForPageURL to determine whether or not 1099 we actually have an icon. 1100 * WebIconDatabase.h: 1101 1102 2011-02-11 Geoffrey Garen <ggaren (a] apple.com> 1103 1104 Reviewed by Oliver Hunt. 1105 1106 A little more encapsulation for the heap: Removed CollectorHeapIterator 1107 https://bugs.webkit.org/show_bug.cgi?id=54298 1108 1109 * WebCoreStatistics.cpp: 1110 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts): 1111 1112 2011-02-09 Pavel Feldman <pfeldman (a] chromium.org> 1113 1114 Reviewed by Yury Semikhatsky. 1115 1116 Web Inspector: follow up on InspectorAgent split - 1117 removing unnecessary methods from InspectorController. 1118 https://bugs.webkit.org/show_bug.cgi?id=54093 1119 1120 * WebInspector.cpp: 1121 (WebInspector::showConsole): 1122 (WebInspector::toggleProfilingJavaScript): 1123 1124 2011-02-08 Adam Barth <abarth (a] webkit.org> 1125 1126 Reviewed by Eric Seidel. 1127 1128 Remove orphan code from old parser 1129 https://bugs.webkit.org/show_bug.cgi?id=53984 1130 1131 * WebCoreSupport/WebChromeClient.h: 1132 1133 2011-02-08 David Hyatt <hyatt (a] apple.com> 1134 1135 Reviewed by Adam Roben. 1136 1137 <rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed 1138 1139 Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this 1140 value, Windows got broken. Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height 1141 argument. 1142 1143 * WebFrame.cpp: 1144 (WebFrame::setPrinting): 1145 (WebFrame::setInPrintingMode): 1146 * WebFrame.h: 1147 1148 2011-02-02 Ilya Tikhonovsky <loislo (a] chromium.org> 1149 1150 Reviewed by Yury Semikhatsky. 1151 1152 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController. 1153 1154 https://bugs.webkit.org/show_bug.cgi?id=53169 1155 1156 Minor change enforced by major changes in WebCore/inspector/InspectorController. 1157 1158 * WebInspector.cpp: 1159 (WebInspector::isTimelineProfilingEnabled): 1160 1161 2011-02-07 Enrica Casucci <enrica (a] apple.com> 1162 1163 Reviewed Adam Roben and Darin Adler. 1164 1165 WebKit2: drag and drop support on Windows. 1166 https://bugs.webkit.org/show_bug.cgi?id=52775 1167 1168 Removed createDragImageForLink from DragClient. 1169 1170 * WebCoreSupport/WebDragClient.cpp: 1171 (WebDragClient::startDrag): 1172 * WebCoreSupport/WebDragClient.h: 1173 1174 2011-02-06 Ryosuke Niwa <rniwa (a] webkit.org> 1175 1176 Reviewed by Darin Adler. 1177 1178 OwnArraryPtr.h uses deleteOwnedPtr but doesnt include OwnPtrCommon.h 1179 https://bugs.webkit.org/show_bug.cgi?id=52867 1180 1181 * WebHistory.cpp: 1182 (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr. 1183 * WebPreferences.cpp: 1184 (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto. 1185 1186 2011-02-03 Yury Semikhatsky <yurys (a] chromium.org> 1187 1188 Reviewed by Pavel Feldman. 1189 1190 Web Inspector: remove settings related methods from InspectorClient 1191 https://bugs.webkit.org/show_bug.cgi?id=53686 1192 1193 * WebCoreSupport/WebInspectorClient.cpp: 1194 (WebInspectorClient::openInspectorFrontend): 1195 (WebInspectorFrontendClient::WebInspectorFrontendClient): 1196 * WebCoreSupport/WebInspectorClient.h: 1197 1198 2011-02-03 Adam Langley <agl (a] chromium.org> 1199 1200 Reviewed by Adam Barth. 1201 1202 Plumb mixed script URL to FrameLoaderClient 1203 https://bugs.webkit.org/show_bug.cgi?id=52384 1204 1205 Regressions covered by http/tests/security/mixedContent/* 1206 1207 * WebCoreSupport/WebFrameLoaderClient.cpp: 1208 (WebFrameLoaderClient::didRunInsecureContent): 1209 * WebCoreSupport/WebFrameLoaderClient.h: 1210 1211 2011-02-02 David Hyatt <hyatt (a] apple.com> 1212 1213 Reviewed by Darin Adler. 1214 1215 Removal of right()/bottom(), converting to maxX()/maxY(). 1216 1217 * DOMHTMLClasses.cpp: 1218 (DOMHTMLInputElement::rectOnScreen): 1219 * WebCoreSupport/EmbeddedWidget.cpp: 1220 (EmbeddedWidget::frameRectsChanged): 1221 * WebFrame.cpp: 1222 (WebFrame::computePageRects): 1223 * WebScrollBar.cpp: 1224 (WebScrollBar::frameRect): 1225 * WebView.cpp: 1226 (WebView::addToDirtyRegion): 1227 (WebView::visibleContentRect): 1228 (WebView::prepareCandidateWindow): 1229 1230 2011-01-31 Brady Eidson <beidson (a] apple.com> 1231 1232 Reviewed by Adam Roben. 1233 1234 Fix the clean Windows build. 1235 1236 * WebKitGraphics.cpp: 1237 (WebDrawText): 1238 1239 2011-01-28 Jon Honeycutt <jhoneycutt (a] apple.com> 1240 1241 Downloads in WK2 on Windows should write resume data to bundle 1242 https://bugs.webkit.org/show_bug.cgi?id=53282 1243 <rdar://problem/8753077> 1244 1245 Reviewed by Alice Liu. 1246 1247 * WebDownload.cpp: 1248 (WebDownload::bundlePathForTargetPath): 1249 Use the new WebCore::DownloadBundle function. 1250 (WebDownload::request): 1251 1252 * WebDownload.h: 1253 Removed declarations for functions that were moved to a new location. 1254 1255 * WebDownloadCFNet.cpp: 1256 (WebDownload::initToResumeWithBundle): 1257 Use the new WebCore::DownloadBundle function. 1258 (WebDownload::cancelForResume): 1259 Fix a leak of the resume data CFDataRef by using adoptCF(). Use the new 1260 WebCore::DownloadBundle function. 1261 1262 2011-01-28 Dan Bernstein <mitz (a] apple.com> 1263 1264 Reviewed by Sam Weinig. 1265 1266 <select> can't display right-to-left (rtl) languages 1267 https://bugs.webkit.org/show_bug.cgi?id=19785 1268 1269 * WebCoreSupport/WebChromeClient.cpp: 1270 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. 1271 * WebCoreSupport/WebChromeClient.h: 1272 1273 2011-01-27 Nate Chapin <japhet (a] chromium.org> 1274 1275 Reviewed by Adam Barth. 1276 1277 Use Document::url() instead of FrameLoader::url(). 1278 https://bugs.webkit.org/show_bug.cgi?id=41165 1279 1280 * WebFrame.cpp: 1281 (WebFrame::url): 1282 1283 2011-01-27 Sam Weinig <sam (a] webkit.org> 1284 1285 Reviewed by Adam Roben. 1286 1287 Fix scrollbars in Safari's Downloads window and Bookmarks view by 1288 implementing two needed functions from ScrollableArea. 1289 1290 * WebScrollBar.cpp: 1291 (WebScrollBar::horizontalScrollbar): Return the WebCore::Scrollbar if 1292 we are a horizontal scrollbar. 1293 (WebScrollBar::verticalScrollbar): Return the WebCore::Scrollbar if we 1294 are a vertical scrollbar. 1295 * WebScrollBar.h: 1296 1297 2011-01-27 Adam Roben <aroben (a] apple.com> 1298 1299 Trim down #includes in WebView.h 1300 1301 Rubber-stamped by Steve Falkenburg. 1302 1303 * WebView.cpp: Moved some #includes here from the header file. 1304 1305 * WebView.h: Replaced some broader #includes with more specific ones, plus a 1306 forward-declaration. 1307 1308 2011-01-25 Steve Falkenburg <sfalken (a] apple.com> 1309 1310 Windows production build fix. 1311 Build correct configuration of Interfaces for Debug_All. 1312 1313 * WebKit.vcproj/WebKit.submit.sln: 1314 1315 2011-01-25 Steve Falkenburg <sfalken (a] apple.com> 1316 1317 Rubber-stamped by Adam Roben. 1318 1319 Windows production build fix. 1320 Use correct environment variable escaping 1321 1322 * WebKit.vcproj/WebKit.make: 1323 1324 2011-01-24 Chris Marrin <cmarrin (a] apple.com> 1325 1326 Reviewed by Eric Seidel. 1327 1328 Change ENABLE_3D_CANVAS to ENABLE_WEBGL 1329 https://bugs.webkit.org/show_bug.cgi?id=53041 1330 1331 * WebView.cpp: 1332 (WebView::notifyPreferencesChanged): 1333 1334 2011-01-25 Yury Semikhatsky <yurys (a] chromium.org> 1335 1336 Reviewed by Pavel Feldman. 1337 1338 Web Inspector: remove "attached" state related methods from InspectorAgent 1339 https://bugs.webkit.org/show_bug.cgi?id=53086 1340 1341 * WebCoreSupport/WebInspectorClient.cpp: 1342 (WebInspectorFrontendClient::attachWindow): 1343 (WebInspectorFrontendClient::detachWindow): 1344 (WebInspectorFrontendClient::showWindowWithoutNotifications): 1345 * WebCoreSupport/WebInspectorClient.h: 1346 1347 2011-01-24 Adam Roben <aroben (a] apple.com> 1348 1349 Windows Production build fix 1350 1351 * WebKit.vcproj/WebKit.make: Update for move of WebKit into Source. 1352 1353 2011-01-21 Nikolas Zimmermann <nzimmermann (a] rim.com> 1354 1355 Reviewed by Dirk Schulze. 1356 1357 Introduce FontMetrics abstraction 1358 https://bugs.webkit.org/show_bug.cgi?id=51456 1359 1360 * FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics. 1361 (FullscreenVideoController::draw): 1362 * WebCoreSupport/WebDragClient.cpp: Ditto. 1363 (WebDragClient::createDragImageForLink): 1364 * WebKitGraphics.cpp: Ditto. 1365 (FontMetrics): 1366 1367 2011-01-21 Chris Rogers <crogers (a] google.com> 1368 1369 Reviewed by Darin Fisher. 1370 1371 Add run-time enable support for the web audio API 1372 https://bugs.webkit.org/show_bug.cgi?id=52741 1373 1374 * WebPreferenceKeysPrivate.h: 1375 * WebView.cpp: 1376 (WebView::notifyPreferencesChanged): 1377 1378 2011-01-21 Sam Weinig <sam (a] webkit.org> 1379 1380 Fix windows build. 1381 1382 * WebScrollBar.h: 1383 1384 2011-01-21 Sam Weinig <sam (a] webkit.org> 1385 1386 Reviewed by Anders Carlsson. 1387 1388 Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship" 1389 https://bugs.webkit.org/show_bug.cgi?id=52779 1390 1391 Rename ScrollbarClient -> ScrollableArea. 1392 1393 * WebScrollBar.cpp: 1394 (WebScrollBar::scroll): 1395 * WebScrollBar.h: 1396 1397 2011-01-20 Adam Roben <aroben (a] apple.com> 1398 1399 Update for CACFLayerTreeHost changes 1400 1401 Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in 1402 CACFLayerTreeHost, but shouldn't be 1403 1404 Reviewed by Simon Fraser. 1405 1406 * WebView.cpp: 1407 (WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back 1408 to our own flushing function if needed. 1409 1410 * WebView.h: Removed shouldRender, which is no longer used or needed. 1411 1412 2011-01-21 Adam Roben <aroben (a] apple.com> 1413 1414 Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename 1415 1416 Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match. 1417 1418 Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't 1419 1420 Reviewed by Simon Fraser. 1421 1422 * WebPreferences.cpp: 1423 * WebView.cpp: 1424 (WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree 1425 host before we get rid of the layer tree host itself. 1426 * WebView.h: 1427 1428 2011-01-21 Adam Roben <aroben (a] apple.com> 1429 1430 Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes" 1431 1432 This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as 1433 opposed to just "layer" because there are cases where we flush changes to CACFLayers that 1434 don't have a corresponding GraphicsLayer. 1435 1436 Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in 1437 WKCACFLayerRenderer and friends is confusing 1438 1439 Reviewed by Simon Fraser. 1440 1441 * WebCoreSupport/WebChromeClient.cpp: 1442 (WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes. 1443 1444 * WebView.cpp: 1445 (WebView::paint): Updated for rename. 1446 (WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync. 1447 (WebView::notifySyncRequired): Updated for rename. 1448 (WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState. 1449 1450 * WebView.h: Did the renames. 1451 1452 2011-01-20 Sam Weinig <sam (a] webkit.org> 1453 1454 Reviewed by Dave Hyatt. 1455 1456 Cleanup Scrollbar/ScrollbarClient relationship 1457 https://bugs.webkit.org/show_bug.cgi?id=52779 1458 1459 * WebScrollBar.cpp: 1460 (WebScrollBar::WebScrollBar): 1461 (WebScrollBar::setValue): 1462 (WebScrollBar::value): 1463 (WebScrollBar::scroll): 1464 (WebScrollBar::scrollPosition): 1465 (WebScrollBar::setScrollOffset): 1466 * WebScrollBar.h: 1467 1468 2011-01-19 Adam Roben <aroben (a] apple.com> 1469 1470 Update for WKCACFLayerRenderer changes 1471 1472 Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be 1473 ref-counted 1474 1475 Reviewed by Simon Fraser. 1476 1477 * WebView.cpp: 1478 (WebView::~WebView): Added some assertions to make sure we've gotten rid of our 1479 compositing-related members. My biggest concern was making sure that m_layerRenderer was 1480 gone, which would also mean we had nulled out its client pointer. 1481 (WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead 1482 of passing the client into create(), and to clear out the client before nulling out 1483 m_layerRenderer. 1484 1485 * WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr. 1486 1487 2011-01-19 Adam Roben <aroben (a] apple.com> 1488 1489 Teach WebView::scrollBackingStore about compositing mode 1490 1491 Test: 1492 compositing/scroll-painted-composited-content.html 1493 1494 Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in 1495 WebView::scrollBackingStore when scrolling page with composited content 1496 1497 Reviewed by Anders Carlsson. 1498 1499 * WebView.cpp: 1500 (WebView::scrollBackingStore): Do something sensible (though naive) when in compositing 1501 mode, rather than incorrectly asserting that this function is never called in that case. For 1502 now we just repaint the entire scrolled region; someday hopefully we can avoid having to 1503 repaint the areas that have just been moved. 1504 1505 2011-01-19 Simon Fraser <simon.fraser (a] apple.com> 1506 1507 Reviewed by Sam Weinig. 1508 1509 GraphicsLayers in subframes can get sync'd multiple times 1510 https://bugs.webkit.org/show_bug.cgi?id=52489 1511 1512 * WebView.cpp: 1513 (WebView::syncCompositingState): syncCompositingStateRecursive() 1514 was renamed to syncCompositingStateIncludingSubframes(). 1515 1516 2011-01-17 Adam Roben <aroben (a] apple.com> 1517 1518 Update for WKCACFLayerRenderer changes 1519 1520 Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use 1521 1522 Reviewed by Chris Marrin. 1523 1524 * WebView.cpp: 1525 (WebView::WebViewWndProc): Removed call to layerRendererBecameVisible 1526 when handling WM_SHOWWINDOW. All this did was try to create the 1527 renderer, but it had already been created in setAcceleratedCompositing, 1528 so wasn't needed. 1529 (WebView::setAcceleratedCompositing): Removed call to createRenderer; 1530 setHostWindow does this for us now. 1531 1532 * WebView.h: Removed animationsStarted and layerRendererBecameVisible. 1533 1534 2011-01-17 Adam Roben <aroben (a] apple.com> 1535 1536 Paint directly into a GraphicsLayer when using accelerated compositing 1537 1538 Before this patch, we were painting into our normal backing store 1539 HBITMAP, wrapping it in a CGImage, and handing it off to Core 1540 Animation. This had at least two disadvantages: 1541 1) The bitmap could be modified while Core Animation was using it. 1542 2) It introduced extra complexity. 1543 1544 When entering accelerated compositing mode, WebView now creates a 1545 GraphicsLayer to draw into. This GraphicsLayer sits between the root 1546 layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When 1547 WebView invalidates, it just calls setNeedsDisplayInRect on its 1548 GraphicsLayer. When WebView paints, it just tells its 1549 WKCACFLayerRenderer to paint, which will call back to WebView to draw 1550 into the GraphicsLayer if it has a dirty region. This is very similar 1551 to the current implementation of LayerBackedDrawingArea in WebKit2. 1552 1553 Fixes <http://webkit.org/b/52582> WebView should paint directly into a 1554 GraphicsLayer when in accelerated compositing mode 1555 1556 Reviewed by Simon Fraser and Chris Marrin. 1557 1558 * WebCoreSupport/WebChromeClient.cpp: 1559 (WebChromeClient::attachRootGraphicsLayer): 1560 (WebChromeClient::scheduleCompositingLayerSync): 1561 Updated for WebView changes. 1562 1563 * WebView.cpp: 1564 (WebView::repaint): When using accelerated compositing, just invalidate 1565 our backing layer. This matches the behavior of LayerBackedDrawingArea. 1566 (WebView::deleteBackingStore): Removed accelerated compositing code. 1567 The WKCACFLayerRenderer doesn't need to know about our backing store 1568 anymore; we don't use it at all when in accelerated compositing mode. 1569 (WebView::addToDirtyRegion): When using accelerated compositing, just 1570 invalidate our backing layer. 1571 (WebView::scrollBackingStore): Added an assertion that this isn't 1572 called in accelerated compositing mode. 1573 (WebView::sizeChanged): Update our backing layer's size, too, and 1574 invalidate it. 1575 (WebView::updateBackingStore): Added an assertion that this isn't 1576 called in accelerated compositing mode. 1577 (WebView::paint): If we're in accelerated compositing mode, sync our 1578 compositing state. If we're *still* in accelerated compositing mode, 1579 just tell our WKCACFLayerRenderer to paint and clear our dirty region. 1580 (The later changes in this function are just un-indenting code that 1581 used to be inside an if.) 1582 1583 (WebView::paintIntoBackingStore): 1584 (WebView::paintIntoWindow): 1585 Added assertions that these aren't called in accelerated compositing 1586 mode. 1587 1588 (WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for 1589 removal of setRootLayerNeedsDisplay. 1590 (WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now 1591 set the layer as a child of our own backing layer. 1592 (WebView::scheduleCompositingLayerSync): Just call through to 1593 WKCACFLayerRenderer. 1594 (WebView::setAcceleratedCompositing): Create our backing layer and set 1595 it as the child of WKCACFLayerRenderer's root layer. 1596 (WebView::notifyAnimationStarted): Added. We never expect this 1597 GraphicsLayerClient override to be called, as we don't use animations 1598 on our backing layer. 1599 (WebView::notifySyncRequired): Added. Just schedule a sync. 1600 (WebView::paintContents): Added. Just clip and paint! 1601 1602 (WebView::showDebugBorders): 1603 (WebView::showRepaintCounter): 1604 Added. These just call through to Settings. 1605 1606 (WebView::syncCompositingState): Changed to first update layout, then 1607 sync state for our backing layer, then sync WebCore's state. This 1608 matches LayerBackedDrawingArea. 1609 1610 * WebView.h: WebView now implements the GraphicsLayerClient interface. 1611 Removed setRootLayerNeedsDisplay; it's been replaced by calling 1612 setNeedsDisplay on our backing layer and calling 1613 syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed 1614 updateRootLayerContents; that function was used to pass our backing 1615 store to Core Animation, which we no longer do. Added m_backingLayer. 1616 1617 2011-01-17 Tony Gentilcore <tonyg (a] chromium.org> 1618 1619 Reviewed by Alexey Proskuryakov. 1620 1621 Fix some headers with missing or misspelled #ifndef guards 1622 https://bugs.webkit.org/show_bug.cgi?id=52545 1623 1624 * WebKitStatistics.h: 1625 1626 2011-01-17 Pavel Feldman <pfeldman (a] chromium.org> 1627 1628 Reviewed by Yury Semikhatsky. 1629 1630 Web Inspector: simplify debugger enabling routine. 1631 https://bugs.webkit.org/show_bug.cgi?id=52472 1632 1633 * WebInspector.cpp: 1634 (WebInspector::toggleDebuggingJavaScript): 1635 1636 2011-01-16 Adam Barth <abarth (a] webkit.org> 1637 1638 Rubber-stamped by Eric Seidel. 1639 1640 Move WebKit into Source 1641 https://bugs.webkit.org/show_bug.cgi?id=52530 1642 1643 * WebKit.vcproj/Interfaces.vcproj: 1644 * WebKit.vcproj/WebKit.sln: 1645 * WebKit.vcproj/WebKit.vcproj: 1646 * WebKit.vcproj/WebKitGUID.vcproj: 1647 1648 2011-01-15 Adam Barth <abarth (a] webkit.org> 1649 1650 Rubber-stamped by Eric Seidel. 1651 1652 Move WebKit2 into Source 1653 https://bugs.webkit.org/show_bug.cgi?id=52438 1654 1655 Update reference to WebKit2. 1656 1657 * WebKit.vcproj/WebKit.sln: 1658 1659 2011-01-14 Yuzo Fujishima <yuzo (a] google.com> 1660 1661 Reviewed by Antti Koivisto. 1662 1663 Rename cache() to memoryCache() 1664 https://bugs.webkit.org/show_bug.cgi?id=52433 1665 1666 * WebCache.cpp: 1667 (WebCache::statistics): 1668 (WebCache::empty): 1669 (WebCache::setDisabled): 1670 (WebCache::disabled): 1671 * WebView.cpp: 1672 (WebView::setCacheModel): 1673 1674 2011-01-10 Geoffrey Garen <ggaren (a] apple.com> 1675 1676 Try to fix Windows build. 1677 1678 * WebJavaScriptCollector.cpp: Updated for rename to Heap.*. (Didn't catch 1679 this one before because it was miscapitalized.) 1680 1681 2011-01-09 Xianzhu Wang <phnixwxz (a] gmail.com> 1682 1683 Reviewed by Darin Fisher. 1684 1685 https://bugs.webkit.org/show_bug.cgi?id=41441 1686 createWindow method should only do window-creating without URL navigation 1687 1688 * WebCoreSupport/WebChromeClient.cpp: 1689 (WebChromeClient::createWindow): 1690 1691 2011-01-07 Adam Barth <abarth (a] webkit.org> 1692 1693 Rubber-stamped by Eric Seidel. 1694 1695 Move WebCore to Source 1696 https://bugs.webkit.org/show_bug.cgi?id=52050 1697 1698 * WebKit.vcproj/WebKit.sln: 1699 1700 2011-01-06 Gavin Barraclough <barraclough (a] apple.com> 1701 1702 Reviewed by Geoff Garen. 1703 1704 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe 1705 1706 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's 1707 destructor early, in order to release wrappers once we know we no longer intend to use them. 1708 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to 1709 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData. 1710 A sequence of events that triggers the bug would look like this: 1711 1712 (1) Create a DOMWrapperWorld. 1713 (2) Register a timer in the world. 1714 (3) Call unregisterWorld() on the world. 1715 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document. 1716 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've 1717 called forgetWorld() none exists. 1718 (6) Attempt to add a wrapper to a NULL map. 1719 1720 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away. 1721 1722 * WebScriptWorld.cpp: 1723 (WebScriptWorld::unregisterWorld): 1724 1725 2011-01-07 Chris Marrin <cmarrin (a] apple.com> 1726 1727 Rubber-stamped by Simon Fraser. 1728 1729 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations 1730 https://bugs.webkit.org/show_bug.cgi?id=49388 1731 1732 Change client API for the fullscreen video controller. It now uses a 1733 PlatformCALayerClient so it can use a PlaformCALayer directly. Also 1734 updated how to connect the layer tree to the view to reflect the updated 1735 hardware compositing logic. 1736 1737 * FullscreenVideoController.cpp: 1738 (FullscreenVideoController::LayerClient::LayerClient): 1739 (FullscreenVideoController::LayerClient::platformCALayerRespondsToLayoutChanges): 1740 (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted): 1741 (FullscreenVideoController::LayerClient::platformCALayerContentsOrientation): 1742 (FullscreenVideoController::LayerClient::platformCALayerPaintContents): 1743 (FullscreenVideoController::LayerClient::platformCALayerShowDebugBorders): 1744 (FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter): 1745 (FullscreenVideoController::LayerClient::platformCALayerIncrementRepaintCount): 1746 (FullscreenVideoController::LayerClient::platformCALayerContentsOpaque): 1747 (FullscreenVideoController::LayerClient::platformCALayerDrawsContent): 1748 (FullscreenVideoController::LayerClient::platformCALayerLayerDidDisplay): 1749 (FullscreenVideoController::LayerClient::platformCALayerLayoutSublayersOfLayer): 1750 (FullscreenVideoController::FullscreenVideoController): 1751 (FullscreenVideoController::~FullscreenVideoController): 1752 (FullscreenVideoController::enterFullscreen): 1753 * FullscreenVideoController.h: 1754 * WebCoreSupport/WebChromeClient.cpp: 1755 (WebChromeClient::attachRootGraphicsLayer): 1756 (WebChromeClient::scheduleCompositingLayerSync): 1757 * WebView.cpp: 1758 (WebView::setRootChildLayer): 1759 (WebView::animationsStarted): 1760 (WebView::syncCompositingState): 1761 * WebView.h: 1762 (WebView::setRootLayerNeedsDisplay): 1763 1764 2011-01-05 Steve Falkenburg <sfalken (a] apple.com> 1765 1766 Reviewed by Darin Adler. 1767 1768 Debug and Release builds on Windows clobber each other 1769 https://bugs.webkit.org/show_bug.cgi?id=49185 1770 1771 Changes the structure of WebKitBuild build products directory so we 1772 completely separate each build configuration into independent directories. 1773 1774 Although we previously had per-configuration directories for obj, this change adds 1775 per-configuration directories for bin, lib, obj, and include. Each configuration's 1776 build products are stored within a directory inside of WebKitBuild. 1777 1778 Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir), 1779 defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName). 1780 1781 * WebKit.vcproj/InterfacesCommon.vsprops: 1782 * WebKit.vcproj/InterfacesPostBuild.cmd: 1783 * WebKit.vcproj/InterfacesPreBuild.cmd: 1784 * WebKit.vcproj/WebKit.make: 1785 * WebKit.vcproj/WebKitGUID.vcproj: 1786 * WebKit.vcproj/WebKitGUIDCommon.vsprops: 1787 * WebKit.vcproj/WebKitGUIDPostBuild.cmd: 1788 * WebKit.vcproj/WebKitGUIDPreBuild.cmd: 1789 * WebKit.vcproj/WebKitLibCommon.vsprops: 1790 * WebKit.vcproj/WebKitLibPostBuild.cmd: 1791 * WebKit.vcproj/WebKitLibPreBuild.cmd: 1792 1793 2011-01-04 Chris Fleizach <cfleizach (a] apple.com> 1794 1795 Reviewed by Sam Weinig. 1796 1797 WK2: Support Accessibility 1798 https://bugs.webkit.org/show_bug.cgi?id=51859 1799 1800 Use rootObject() method to get the top of the AX tree. 1801 1802 * AccessibleDocument.cpp: 1803 (AccessibleDocument::AccessibleDocument): 1804 1805 2011-01-01 Adam Barth <abarth (a] webkit.org> 1806 1807 Reviewed by Eric Seidel. 1808 1809 Move JavaScriptCore to Source 1810 https://bugs.webkit.org/show_bug.cgi?id=51604 1811 1812 * WebKit.vcproj/WebKit.sln: 1813 - Point to JavaScriptCore in its new location. 1814 1815 2010-12-22 Sam Weinig <sam (a] webkit.org> 1816 1817 Reviewed by Darin Adler. 1818 1819 WebKit2 needs to mirror the frame tree in the UIProcess 1820 https://bugs.webkit.org/show_bug.cgi?id=51546 1821 1822 - Add client functions to notify that a frame has been added or 1823 removed from the page cache. 1824 1825 * WebCoreSupport/WebFrameLoaderClient.cpp: 1826 (WebFrameLoaderClient::didSaveToPageCache): 1827 (WebFrameLoaderClient::didRestoreFromPageCache): 1828 * WebCoreSupport/WebFrameLoaderClient.h: 1829 1830 2010-12-22 Dan Bernstein <mitz (a] apple.com> 1831 1832 Changed WebKitTools to Tools. 1833 1834 * WebKit.vcproj/WebKit.sln: 1835 1836 2010-12-14 Adam Roben <aroben (a] apple.com> 1837 1838 Always record the last-set cursor, even when the UI delegate is 1839 setting the cursor for us 1840 1841 Prior to r63339, the last-set cursor was recorded in Widget::setCursor. 1842 r63339 moved that code up to WebChromeClient, but failed to call it 1843 when the UI delegate was the one setting the cursor. 1844 1845 Fixes <http://webkit.org/b/45692> <rdar://problem/8423464> REGRESSION 1846 (r63339): Mouse cursor disappears when holding mouse button down on 1847 page 1848 1849 Reviewed by Ada Chan. 1850 1851 * WebCoreSupport/WebChromeClient.cpp: 1852 (WebChromeClient::setCursor): After the cursor is set, regardless of 1853 whether the UI delegate sets it or we set it, record the cursor that 1854 was just set. That way we'll be able to use the cursor later when 1855 responding to the WM_SETCURSOR message. 1856 1857 2010-12-13 Alexey Proskuryakov <ap (a] apple.com> 1858 1859 Reviewed by Adam Barth. 1860 1861 https://bugs.webkit.org/show_bug.cgi?id=50953 1862 DNS Prefetch should be an opt-in feature 1863 1864 * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default to NO. 1865 1866 2010-10-28 MORITA Hajime <morrita (a] google.com> 1867 1868 Reviewed by Ojan Vafai. 1869 1870 spellcheck does not check pasted text 1871 https://bugs.webkit.org/show_bug.cgi?id=40092 1872 1873 Added a stub implememntation. 1874 1875 * WebCoreSupport/WebEditorClient.h: 1876 (WebEditorClient::requestCheckingOfString): 1877 1878 2010-12-10 Chris Fleizach <cfleizach (a] apple.com> 1879 1880 Reviewed by Darin Adler. 1881 1882 AX: refactor AccessibilityRenderObject::doAccessibilityHitTest 1883 https://bugs.webkit.org/show_bug.cgi?id=50574 1884 1885 * AccessibleBase.cpp: 1886 (AccessibleBase::accHitTest): 1887 1888 2010-12-09 Brian Weinstein <bweinstein (a] apple.com> 1889 1890 Reviewed by Adam Roben. 1891 1892 Prep for WebKit2: Context menu support on Windows 1893 https://bugs.webkit.org/show_bug.cgi?id=50514 1894 1895 Update WebKit for the new CROSS_PLATFORM_CONTEXT_MENUS flag, and define customizeMenu 1896 instead of getCustomMenuFromDefaultItems. 1897 1898 * WebCoreSupport/WebContextMenuClient.cpp: 1899 (WebContextMenuClient::customizeMenu): getCustomMenuFromDefaultItems was turned into 1900 this function, with refactoring using nativeMenu instead of platformDescription. 1901 (WebContextMenuClient::contextMenuItemSelected): Use nativeMenu instead of platformDescription. 1902 * WebCoreSupport/WebContextMenuClient.h: 1903 * WebView.cpp: 1904 (WebView::handleContextMenuEvent): Call nativeMenu instead of platformDescription. 1905 (WebView::performContextMenuAction): Only call itemAtIndex with one argument, no need 1906 for the second. 1907 1908 2010-12-07 Brian Weinstein <bweinstein (a] apple.com> 1909 1910 Reviewed by John Sullivan. 1911 1912 Layering Violation in ContextMenu - member variable of type HitTestResult 1913 https://bugs.webkit.org/show_bug.cgi?id=50586 1914 1915 Update users of ContextMenu and ContextMenuController to match where the new functions 1916 are located. 1917 1918 * WebCoreSupport/WebContextMenuClient.cpp: 1919 (WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the 1920 ContextMenuController (from the page). 1921 (WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController. 1922 * WebView.cpp: 1923 (WebView::handleContextMenuEvent): Ditto. 1924 1925 2010-12-07 Jessie Berlin <jberlin (a] apple.com> 1926 1927 Build fix. Unreviewed. 1928 1929 * WebCoreSupport/WebContextMenuClient.cpp: 1930 (WebContextMenuClient::searchWithGoogle): 1931 FrameLoader::urlSelected does not take a SecurityOrigin as a parameter. 1932 1933 2010-12-06 Darin Adler <darin (a] apple.com> 1934 1935 Reviewed by Sam Weinig. 1936 1937 Pass security origin to make local file decision correctly 1938 https://bugs.webkit.org/show_bug.cgi?id=48603 1939 1940 * WebCoreSupport/WebContextMenuClient.cpp: 1941 (WebContextMenuClient::searchWithGoogle): Pass security origin. 1942 1943 2010-12-07 Kenichi Ishibashi <bashi (a] google.com> 1944 1945 Reviewed by Kent Tamura. 1946 1947 Let HTMLObjectElement be a form associated element 1948 https://bugs.webkit.org/show_bug.cgi?id=48821 1949 1950 Modified to use FormAssociatedElement instead of HTMLFormControlElement. 1951 1952 * WebFrame.cpp: 1953 (WebFrame::elementWithName): Modified to use FormAssociatedElement 1954 instead of HTMLFormControlElement. 1955 (WebFrame::controlsInForm): Ditto. 1956 1957 2010-12-05 Adam Roben <aroben (a] apple.com> 1958 1959 Windows production build fix 1960 1961 Put spaces after trailing backslashes when setting 1962 %WebKitVSPropsRedirectionDir%. According to MSDN 1963 <http://msdn.microsoft.com/en-us/library/2kzfk8c7(v=VS.80).aspx>: 1964 1965 A backslash ( \ ) followed by a newline character is interpreted as 1966 a space in the command; use a backslash at the end of a line to 1967 continue a command onto the next line. NMAKE interprets the 1968 backslash literally if any other character, including a space or 1969 tab, follows the backslash. 1970 1971 * WebKit.vcproj/WebKit.make: 1972 1973 2010-12-03 Sam Weinig <sam (a] webkit.org> 1974 1975 Reviewed by Maciej Stachowiak. 1976 1977 Enable <a ping> for Mac/Windows/WebKit2 builds 1978 <rdar://problem/8504473> 1979 https://bugs.webkit.org/show_bug.cgi?id=50488 1980 1981 * WebPreferences.cpp: 1982 (WebPreferences::initializeDefaultSettings): Enable "HyperlinkAuditing" by default. 1983 1984 2010-12-03 Brian Weinstein <bweinstein (a] apple.com> 1985 1986 Reviewed by Brady Eidson. 1987 1988 WebContextMenuClient::fixMenuReceivedFromOldSafari is no longer needed on Windows 1989 https://bugs.webkit.org/show_bug.cgi?id=50486 1990 1991 Remove the static fixMenuReceivedFromOldSafari and isPreInspectElementTagSafari methods 1992 from WebContextMenuClient. There were there for when WebKit had the Inspect Element context menu 1993 item, but Safari didn't support it. We don't support that old Safari, so that code can go. 1994 1995 * WebCoreSupport/WebContextMenuClient.cpp: 1996 (WebContextMenuClient::getCustomMenuFromDefaultItems): 1997 1998 2010-12-02 John Knottenbelt <jknotten (a] chromium.org> 1999 2000 Reviewed by Steve Block. 2001 2002 Move requestGeolocationPermissionForFrame to GeolocationClient 2003 https://bugs.webkit.org/show_bug.cgi?id=50061 2004 2005 This change facilitates client-based geolocation implementation by 2006 bringing together permission control into the geolocation client 2007 interface. 2008 2009 Move method ChromeClient::requestGeolocationPermissionForFrame to 2010 GeolocationClient::requestPermission. The moved code is unchanged 2011 except that requestPermission now takes only one argument (Geolocation*), 2012 the Frame parameter is retrieved from the Geolocation object and we need to 2013 call m_webView.get() as it is a COMPtr in GeolocationClient. 2014 2015 * WebCoreSupport/WebChromeClient.cpp: 2016 * WebCoreSupport/WebChromeClient.h: 2017 * WebCoreSupport/WebGeolocationClient.cpp: 2018 (WebGeolocationClient::requestPermission): 2019 * WebCoreSupport/WebGeolocationClient.h: 2020 (WebGeolocationClient::cancelPermissionRequest): 2021 2022 2010-12-01 Jia Pu <jpu (a] apple.com> 2023 2024 Reviewed by Darin Adler. 2025 2026 Support multiple correction candidates panel for misspelled word on Mac OS X. 2027 https://bugs.webkit.org/show_bug.cgi?id=50137 2028 <rdar://problem/8568059> 2029 2030 Adopted new function signature defined in base class. 2031 2032 * WebCoreSupport/WebEditorClient.cpp: 2033 (WebEditorClient::getGuessesForWord): 2034 * WebCoreSupport/WebEditorClient.h: 2035 2036 2010-12-01 Steve Falkenburg <sfalken (a] apple.com> 2037 2038 Reviewed by Adam Roben. 2039 2040 WinCairo build should not use link-time code generation (LTCG) 2041 https://bugs.webkit.org/show_bug.cgi?id=50353 2042 2043 * WebKit.vcproj/Interfaces.vcproj: 2044 * WebKit.vcproj/WebKit.vcproj: 2045 * WebKit.vcproj/WebKitGUID.vcproj: 2046 2047 2010-12-01 Steve Falkenburg <sfalken (a] apple.com> 2048 2049 Reviewed by Adam Roben. 2050 2051 vcproj changes can't be applied cleanly by the Windows EWS bot 2052 https://bugs.webkit.org/show_bug.cgi?id=50328 2053 2054 * WebKit.vcproj/Interfaces.vcproj: Modified property svn:eol-style. 2055 * WebKit.vcproj/InterfacesCommon.vsprops: Added property svn:eol-style. 2056 * WebKit.vcproj/WebKit.sln: Modified property svn:eol-style. 2057 * WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style. 2058 * WebKit.vcproj/WebKit.vcproj: Modified property svn:eol-style. 2059 * WebKit.vcproj/WebKitGUID.vcproj: Modified property svn:eol-style. 2060 * WebKit.vcproj/WebKitGUIDCommon.vsprops: Added property svn:eol-style. 2061 * WebKit.vcproj/WebKitLibCommon.vsprops: Added property svn:eol-style. 2062 2063 2010-11-30 Steve Falkenburg <sfalken (a] apple.com> 2064 2065 Reviewed by Adam Roben. 2066 2067 All projects on Windows should use cmd files for build events 2068 https://bugs.webkit.org/show_bug.cgi?id=50213 2069 2070 * WebKit.vcproj/InterfacesCommon.vsprops: 2071 * WebKit.vcproj/InterfacesPostBuild.cmd: Added. 2072 * WebKit.vcproj/InterfacesPreBuild.cmd: Added. 2073 * WebKit.vcproj/WebKitGUIDCommon.vsprops: 2074 * WebKit.vcproj/WebKitGUIDPostBuild.cmd: Added. 2075 * WebKit.vcproj/WebKitGUIDPreBuild.cmd: Added. 2076 * WebKit.vcproj/WebKitLibCommon.vsprops: 2077 * WebKit.vcproj/WebKitLibPostBuild.cmd: Added. 2078 * WebKit.vcproj/WebKitLibPreBuild.cmd: Added. 2079 2080 2010-11-29 Brent Fulgham <bfulgham (a] webkit.org> 2081 2082 Unreviewed build correction. 2083 2084 * WebKit.vcproj/WebKit.vcproj: Update WebKit project to 2085 use WinCairo.vsprops definition for appropriate build targets. 2086 2087 2010-11-22 Adam Roben <aroben (a] apple.com> 2088 2089 Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files 2090 2091 Apple's Windows build allows placing header files and import libraries for WebKit's 2092 dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the 2093 $WebKitLibrariesDir environment variable. This is both required for production builds and 2094 convenient for Apple-internal developer builds. Apple's production builds also require that 2095 WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production 2096 builds, the files are copied into that directory tree by the 2097 WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the 2098 copying is done by 2099 JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make. 2100 2101 This .vsprops copying is problematic in one very important case: when a developer updates 2102 their source tree and then tries to build. Visual Studio only reads .vsprops files when a 2103 project is first loaded. So, when Visual Studio is first opened after the .vsprops files are 2104 updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a 2105 build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into 2106 $WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build 2107 will proceed with out-of-date .vsprops files, which will likely result in a build failure. 2108 2109 To fix this, we now use normal relative paths to access the .vsprops files in the source 2110 tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment 2111 variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is 2112 unset, so the normal relative paths are used to read the .vsprops files out of the source 2113 tree directly. In production builds, this environment variable is set to a fake directory 2114 that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path 2115 is resolved. 2116 2117 For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops: 2118 2119 $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops 2120 2121 In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the 2122 files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds, 2123 JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to 2124 "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for 2125 FeatureDefines.vsprops becomes: 2126 2127 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops 2128 2129 which resolves to: 2130 2131 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops 2132 2133 (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3" 2134 actually exist since they are matched by an equal number of ".." path components.) 2135 2136 Note that Visual Studio still won't pick up changes made to .vsprops files while Visual 2137 Studio is open, but that problem hasn't seemed to cause developers many headaches so far. 2138 2139 Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are 2140 updated 2141 2142 Reviewed by Dave Hyatt. 2143 2144 * WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can 2145 find the .vsprops files. 2146 2147 * WebKit.vcproj/WebKit.vcproj: 2148 * WebKit.vcproj/Interfaces.vcproj: 2149 * WebKit.vcproj/WebKitGUID.vcproj: 2150 Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops 2151 files. 2152 2153 2010-11-19 Steve Falkenburg <sfalken (a] apple.com> 2154 2155 Reviewed by Adam Roben. 2156 2157 Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files 2158 https://bugs.webkit.org/show_bug.cgi?id=49819 2159 2160 * WebKit.vcproj/Interfaces.vcproj: 2161 * WebKit.vcproj/WebKit.sln: 2162 * WebKit.vcproj/WebKit.vcproj: 2163 * WebKit.vcproj/WebKitGUID.vcproj: 2164 2165 2010-11-19 Steve Falkenburg <sfalken (a] apple.com> 2166 2167 Reviewed by Darin Adler. 2168 2169 Normalize Cairo/CFLite project/solution configuration names 2170 https://bugs.webkit.org/show_bug.cgi?id=49818 2171 2172 * WebKit.vcproj/WebKit.sln: 2173 * WebKit.vcproj/WebKit.vcproj: 2174 2175 2010-11-18 Steve Falkenburg <sfalken (a] apple.com> 2176 2177 Reviewed by Adam Roben. 2178 2179 Windows vcproj configuration names should be normalized across projects 2180 https://bugs.webkit.org/show_bug.cgi?id=49776 2181 2182 * WebKit.vcproj/Interfaces.vcproj: 2183 * WebKit.vcproj/WebKit.sln: 2184 2185 2010-11-18 Steve Falkenburg <sfalken (a] apple.com> 2186 2187 Reviewed by Adam Roben. 2188 2189 Remove leftover Windows Debug_Internal configurations 2190 https://bugs.webkit.org/show_bug.cgi?id=49758 2191 2192 * WebKit.vcproj/WebKit.vcproj: 2193 * WebKit.vcproj/WebKitGUID.vcproj: 2194 2195 2010-11-18 Steve Falkenburg <sfalken (a] apple.com> 2196 2197 Reviewed by Adam Roben. 2198 2199 Debug_Internal Windows configuration is unnecessary, should be removed 2200 https://bugs.webkit.org/show_bug.cgi?id=49753 2201 2202 * WebKitPrefix.h: 2203 2204 2010-11-17 Steve Falkenburg <sfalken (a] apple.com> 2205 2206 Reviewed by Adam Roben. 2207 2208 WebKit Interfaces project should use vsprops file for common build settings 2209 https://bugs.webkit.org/show_bug.cgi?id=49713 2210 2211 * WebKit.vcproj/Interfaces.vcproj: 2212 * WebKit.vcproj/InterfacesCommon.vsprops: Added. 2213 2214 2010-11-16 Steve Falkenburg <sfalken (a] apple.com> 2215 2216 Reviewed by Adam Roben. 2217 2218 Disable LTCG for Windows Release builds. Add new Release_LTCG configuration. 2219 https://bugs.webkit.org/show_bug.cgi?id=49632 2220 2221 * WebKit.vcproj/Interfaces.vcproj: 2222 * WebKit.vcproj/WebKit.make: 2223 * WebKit.vcproj/WebKit.sln: 2224 * WebKit.vcproj/WebKit.submit.sln: 2225 * WebKit.vcproj/WebKit.vcproj: 2226 * WebKit.vcproj/WebKitGUID.vcproj: 2227 2228 2010-11-16 Dave Hyatt <hyatt (a] apple.com> 2229 2230 Reviewed by Dan Bernstein. 2231 2232 https://bugs.webkit.org/show_bug.cgi?id=11004 2233 2234 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector. 2235 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size, 2236 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version 2237 of the constructor rather than using [NSFont pointSize]. 2238 2239 https://bugs.webkit.org/show_bug.cgi?id=49582 2240 2241 Negative leading is not handled correctly. There are two bugs here. The first is that 2242 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have 2243 set them before so that we can allow them to be < 0. 2244 2245 The second issue is that we should understand where fonts will end up relative to 2246 our baseline (excluding line height), and only allow those boxes to impact ascent and 2247 descent if the actual font box (without factoring in line height) is above or below the 2248 root line box baseline. 2249 2250 Added fast/css/negative-leading.html 2251 2252 These two bug fixes have to land together to keep the Acid 3 test rendering correctly. 2253 2254 * WebPreferences.cpp: 2255 (WebPreferences::initializeDefaultSettings): 2256 2257 2010-11-16 Steve Falkenburg <sfalken (a] apple.com> 2258 2259 Reviewed by Adam Roben. 2260 2261 Use vsprops files for common settings in Windows WebKit 2262 https://bugs.webkit.org/show_bug.cgi?id=49622 2263 2264 * WebKit.vcproj/WebKit.vcproj: 2265 * WebKit.vcproj/WebKitCommon.vsprops: Added. 2266 2267 2010-11-16 Steve Falkenburg <sfalken (a] apple.com> 2268 2269 Rubber stamped by Adam Roben. 2270 2271 Remove unnecessary def file, remove outdated def files from vcproj. 2272 2273 * WebKit.vcproj/WebKit.vcproj: 2274 * WebKit.vcproj/WebKit_debug.def: Removed. 2275 2276 2010-11-12 John Knottenbelt <jknotten (a] chromium.org> 2277 2278 Reviewed by Steve Block. 2279 2280 Rename GeolocationControllerClient to GeolocationClient. 2281 https://bugs.webkit.org/show_bug.cgi?id=49259 2282 2283 * WebCoreSupport/WebGeolocationClient.cpp: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp. 2284 (WebGeolocationClient::WebGeolocationClient): 2285 (WebGeolocationClient::geolocationDestroyed): 2286 (WebGeolocationClient::startUpdating): 2287 (WebGeolocationClient::stopUpdating): 2288 (WebGeolocationClient::lastPosition): 2289 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h. 2290 (WebGeolocationClient::setEnableHighAccuracy): 2291 * WebKit.vcproj/WebKit.vcproj: 2292 * WebView.cpp: 2293 (WebView::initWithFrame): 2294 2295 2010-11-10 Csaba Osztrogonc <ossy (a] webkit.org> 2296 2297 Reviewed by David Hyatt. 2298 2299 HTML5 Ruby support should be mandatory feature 2300 https://bugs.webkit.org/show_bug.cgi?id=49272 2301 2302 * WebKitPrefix.h: Touch it to avoid incremental build failure on Windows. 2303 2304 2010-11-08 Alexey Proskuryakov <ap (a] apple.com> 2305 2306 Windows build fix. 2307 2308 * WebCoreSupport/WebChromeClient.h: Added namespace prefix. 2309 2310 2010-11-08 Alexey Proskuryakov <ap (a] apple.com> 2311 2312 Reviewed by Darin Adler. 2313 2314 https://bugs.webkit.org/show_bug.cgi?id=48685 2315 Notify UI process about focused frame 2316 2317 Added an empty implementation of the new ChromeClient method. 2318 2319 * WebCoreSupport/WebChromeClient.cpp: 2320 (WebChromeClient::focusedFrameChanged): 2321 * WebCoreSupport/WebChromeClient.h: 2322 2323 2010-11-07 Adam Barth <abarth (a] webkit.org> 2324 2325 Reviewed by Eric Seidel. 2326 2327 Rename Cache to MemoryCache 2328 https://bugs.webkit.org/show_bug.cgi?id=49159 2329 2330 * WebCache.cpp: 2331 (WebCache::statistics): 2332 * WebFrame.cpp: 2333 * WebView.cpp: 2334 2335 2010-11-05 Chris Marrin <cmarrin (a] apple.com> 2336 2337 Reviewed by Simon Fraser. 2338 2339 Move resumeAnimations/suspendAnimations from Frame to AnimationController. 2340 https://bugs.webkit.org/show_bug.cgi?id=49073 2341 2342 * WebFrame.cpp: 2343 (WebFrame::suspendAnimations): 2344 (WebFrame::resumeAnimations): 2345 2346 2010-11-05 Brian Weinstein <bweinstein (a] apple.com> 2347 2348 Reviewed by Anders Carlsson. 2349 2350 Assertion failure in PluginStream::~PluginStream when running userscripts/user-script-plugin-document.html 2351 https://bugs.webkit.org/show_bug.cgi?id=48751 2352 <rdar://problem/8615536> 2353 2354 Always call committedLoad in WebFrameLoaderClient::finishedLoading, even if we have a manual loader. We were 2355 running into a case where we were trying to load an empty plugin document, which uses a manual loader, and 2356 PluginStream::didFinishLoading was never being called. The stream was never being stopped, making us fire 2357 an assert in the PluginStream destructor. 2358 2359 * WebCoreSupport/WebFrameLoaderClient.cpp: 2360 (WebFrameLoaderClient::finishedLoading): 2361 2362 2010-11-05 Chris Marrin <cmarrin (a] apple.com> 2363 2364 Reviewed by Simon Fraser. 2365 2366 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state 2367 https://bugs.webkit.org/show_bug.cgi?id=46945 2368 2369 * WebFrame.cpp: 2370 (WebFrame::suspendAnimations): 2371 (WebFrame::resumeAnimations): 2372 2373 2010-11-05 Patrick Gansterer <paroga (a] webkit.org> 2374 2375 Reviewed by David Kilzer. 2376 2377 Replace ARRAYSIZE with WTF_ARRAY_LENGTH 2378 https://bugs.webkit.org/show_bug.cgi?id=48903 2379 2380 * WebCoreSupport/WebChromeClient.cpp: 2381 (WebChromeClient::exceededDatabaseQuota): 2382 * WebKitDLL.cpp: 2383 (DllGetClassObject): 2384 * WebView.cpp: 2385 (WebView::mouseWheel): 2386 2387 2010-11-02 Daniel Bates <dbates (a] rim.com> 2388 2389 Reviewed by Adam Barth. 2390 2391 For unnamed frames, window.name returns a generated name 2392 https://bugs.webkit.org/show_bug.cgi?id=6751 2393 2394 Part 1 of 2. 2395 2396 Substitute FrameTree::uniqueName() for FrameTree::name() in the Apple Windows port. 2397 2398 * WebFrame.cpp: 2399 (WebFrame::name): 2400 2401 2010-11-02 Brady Eidson <beidson (a] apple.com> 2402 2403 Reviewed by Anders Carlsson. 2404 2405 <rdar://problem/8346191> and https://bugs.webkit.org/show_bug.cgi?id=48868 2406 Implement IMutableWebRequest::setTimeoutInterval 2407 2408 * WebMutableURLRequest.cpp: 2409 (WebMutableURLRequest::setTimeoutInterval): 2410 2411 2010-11-02 Daniel Bates <dbates (a] rim.com> 2412 2413 Reviewed by Martin Robinson. 2414 2415 Set frame name before appending it to the frame tree in the Apple Windows, 2416 GTK, and EFL ports 2417 https://bugs.webkit.org/show_bug.cgi?id=48806 2418 2419 Make the frame creation process in the Apple Windows-port consistent 2420 with the Mac, Qt, and Haiku ports. In particular, set the name of 2421 the new frame before it's appended to the frame tree. 2422 2423 At this time we cannot test this change since it is being masked by 2424 HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>. 2425 We'll be able to test this once we fix bug #6751. 2426 2427 * WebCoreSupport/WebFrameLoaderClient.cpp: 2428 (WebFrameLoaderClient::createFrame): 2429 2430 2010-11-01 Jenn Braithwaite <jennb (a] chromium.org> 2431 2432 Reviewed by Adam Roben. 2433 2434 Windows: Update resource tracking when moving a frame between documents 2435 https://bugs.webkit.org/show_bug.cgi?id=48364 2436 2437 * Interfaces/IWebResourceLoadDelegatePrivate2.idl:Added 2438 Added removeIdentifierForRequest. 2439 * Interfaces/WebKit.idl: 2440 Added IWebResourceLoadDelegatePrivate2.idl. 2441 * WebCoreSupport/WebFrameLoaderClient.cpp: 2442 (WebFrameLoaderClient::transferLoadingResourceFromPage): 2443 2444 2010-11-01 Brady Eidson <beidson (a] apple.com> 2445 2446 Reviewed by Anders Carlsson. 2447 2448 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699 2449 Context menu support for WebKit 2. 2450 2451 * WebCoreSupport/WebChromeClient.h: 2452 (WebChromeClient::showContextMenu): 2453 2454 2010-11-01 Adam Roben <aroben (a] apple.com> 2455 2456 Cancel main resource loads after we hand them off to the media engine 2457 2458 This is the Windows equivalent of r51104. Clearly this code should be 2459 moved to a cross-platform location someday. 2460 2461 Fixes <http://webkit.org/b/48531> <rdar://problem/8606635> Assertion 2462 failure in DocumentLoader::commitData when loading a media document in 2463 WebKit1 on Windows 2464 2465 Reviewed by Dan Bernstein. 2466 2467 * WebCoreSupport/WebFrameLoaderClient.cpp: 2468 (WebFrameLoaderClient::committedLoad): Cancel the main resource load 2469 after handing off the load to the media engine. This code originally 2470 came from -[WebHTMLRepresentation receivedData:withDataSource:]. 2471 2472 * WebFrame.cpp: 2473 (WebFrame::shouldFallBack): Don't fall back when handing the resource 2474 load off to the media engine or a plugin. Added error domain checking 2475 so that we don't rely on error codes being unique. 2476 2477 2010-10-29 Daniel Bates <dbates (a] rim.com> 2478 2479 No review, rolling out 70971. 2480 http://trac.webkit.org/changeset/70971 2481 https://bugs.webkit.org/show_bug.cgi?id=6751 2482 2483 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since 2484 it caused layout test failures on all bots. In particular, the 2485 child count in a generated frame name differs after this patch. We need 2486 to look into this further. 2487 2488 * WebFrame.cpp: 2489 (WebFrame::name): 2490 2491 2010-10-28 Antonio Gomes <agomes (a] rim.com> 2492 2493 Reviewed by Ojan Vafai. 2494 2495 Needs a "LinuxEditingBehavior", perhaps with a better name 2496 https://bugs.webkit.org/show_bug.cgi?id=36627 2497 2498 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior. 2499 2500 * Interfaces/IWebPreferences.idl: 2501 2502 2010-10-29 Daniel Bates <dbates (a] rim.com> 2503 2504 Reviewed by Adam Barth. 2505 2506 For unnamed frames, window.name returns a generated name 2507 https://bugs.webkit.org/show_bug.cgi?id=6751 2508 2509 Modified Apple Windows-port to use FrameTree::uniqueName(). 2510 2511 * WebFrame.cpp: 2512 (WebFrame::name): 2513 2514 2010-10-29 Darin Adler <darin (a] apple.com> 2515 2516 Reviewed by Sam Weinig. 2517 2518 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring 2519 https://bugs.webkit.org/show_bug.cgi?id=48574 2520 2521 * WebBackForwardList.cpp: 2522 (backForwardListWrappers): 2523 (WebBackForwardList::WebBackForwardList): 2524 (WebBackForwardList::createInstance): 2525 * WebBackForwardList.h: 2526 * WebView.cpp: 2527 (WebView::backForwardList): 2528 Use BackForwardListImpl. 2529 2530 2010-10-29 Adam Roben <aroben (a] apple.com> 2531 2532 Windows build fix 2533 2534 * WebKitPrefix.h: Touched to force a rebuild. 2535 2536 2010-10-29 Alexey Proskuryakov <ap (a] apple.com> 2537 2538 Reviewed by Darin Adler. 2539 2540 https://bugs.webkit.org/show_bug.cgi?id=48576 2541 Let WebKit2 client know when a frame is a frameset 2542 2543 Added a blank implementation of the new FrameLoaderClient method. 2544 2545 * WebCoreSupport/WebFrameLoaderClient.h: 2546 * WebCoreSupport/WebFrameLoaderClient.cpp: 2547 (WebFrameLoaderClient::dispatchDidBecomeFrameset): 2548 2549 2010-10-26 Brent Fulgham <bfulgham (a] webkit.org> 2550 2551 Unreviewed build fix. 2552 2553 * WebView.cpp: Conditionalize includes for CFNetwork-specific 2554 Cookie implementation. 2555 * WebView.h: Conditionalize includes for ACCELERATED_COMPOSITION. 2556 WinCairo doesn't use CoreAnimation. 2557 2558 2010-10-26 Jenn Braithwaite <jennb (a] chromium.org> 2559 2560 Reviewed by Dmitry Titov. 2561 2562 Resource tracking failure when trying to move a frame between documents 2563 https://bugs.webkit.org/show_bug.cgi?id=44713 2564 2565 * WebCoreSupport/WebFrameLoaderClient.cpp: 2566 (WebFrameLoaderClient::transferLoadingResourceFromPage): 2567 Empty method. 2568 * WebCoreSupport/WebFrameLoaderClient.h: 2569 2570 2010-10-25 Patrick Gansterer <paroga (a] webkit.org> 2571 2572 Reviewed by David Kilzer. 2573 2574 Replace _countof with WTF_ARRAY_LENGTH 2575 https://bugs.webkit.org/show_bug.cgi?id=48229 2576 2577 * WebCoreSupport/WebContextMenuClient.cpp: 2578 (isPreInspectElementTagSafari): 2579 * WebView.cpp: 2580 (WebView::interpretKeyEvent): 2581 2582 2010-10-24 Dan Bernstein <mitz (a] apple.com> 2583 2584 Build fix. 2585 2586 * Interfaces/WebKit.idl: Touched. 2587 2588 2010-10-24 Dan Bernstein <mitz (a] apple.com> 2589 2590 Reviewed by Anders Carlsson. 2591 2592 Expose HitTestResult::absoluteMediaURL() via WebKit API 2593 https://bugs.webkit.org/show_bug.cgi?id=48219 2594 2595 * Interfaces/IWebView.idl: Added WebElementMediaURLKey. 2596 * WebElementPropertyBag.cpp: 2597 (WebElementPropertyBag::Read): Map WebElementMediaURLKey to absoluteMediaURL(). 2598 2599 2010-10-22 Andy Estes <aestes (a] apple.com> 2600 2601 Fix the Windows build. 2602 2603 * WebCookieManagerCFNet.cpp: Rename CookieStorageWin.h to CookieStorageCFNet.h. 2604 * WebView.cpp: Ditto. 2605 2606 2010-10-22 Jenn Braithwaite <jennb (a] chromium.org> 2607 2608 Reviewed by Adam Roben. 2609 2610 Windows client needs updating when live iframe element is moved between pages 2611 https://bugs.webkit.org/show_bug.cgi?id=46915 2612 2613 * WebCoreSupport/WebFrameLoaderClient.cpp: 2614 (WebFrameLoaderClient::didTransferChildFrameToNewDocument): 2615 Update WebView in WebFrame to match that of the current page. 2616 * WebFrame.cpp: 2617 (WebFrame::setWebView): 2618 Added. 2619 * WebFrame.h: 2620 2621 2010-10-22 Sam Weinig <sam (a] webkit.org> 2622 2623 Fix windows build. 2624 2625 * WebCoreSupport/WebChromeClient.h: 2626 2627 2010-10-22 Sam Weinig <sam (a] webkit.org> 2628 2629 Reviewed by Anders Carlsson. 2630 2631 WebKit2 needs to pass the current event modifier flags when requesting a new window 2632 https://bugs.webkit.org/show_bug.cgi?id=48140 2633 2634 * WebCoreSupport/WebChromeClient.cpp: 2635 (WebChromeClient::createWindow): 2636 * WebCoreSupport/WebFrameLoaderClient.cpp: 2637 (WebFrameLoaderClient::dispatchCreatePage): 2638 * WebCoreSupport/WebFrameLoaderClient.h: 2639 Add NavigationAction parameter. 2640 2641 2010-10-21 MORITA Hajime <morrita (a] google.com> 2642 2643 Unreviewed, touched it to fix the build. 2644 2645 * Interfaces/WebKit.idl: 2646 2647 2010-10-21 MORITA Hajime <morrita (a] google.com> 2648 2649 Reviewed by Kent Tamura. 2650 2651 [Win][DRT] should have LayoutTestController.hasSpellingMarker() 2652 https://bugs.webkit.org/show_bug.cgi?id=47885 2653 2654 Added IWebFramePrivate::hasSpellingMarker() and impelmented it for 2655 LayoutTestController. 2656 2657 * Interfaces/IWebFramePrivate.idl: 2658 * WebFrame.cpp: 2659 (WebFrame::hasSpellingMarker): 2660 * WebFrame.h: 2661 2662 2010-10-20 Dumitru Daniliuc <dumi (a] chromium.org> 2663 2664 Reviewed by David Levin. 2665 2666 Repost the DatabaseTracker notifications to the main thread, if needed. 2667 https://bugs.webkit.org/show_bug.cgi?id=40655 2668 2669 * WebDatabaseManager.cpp: 2670 (DidModifyOriginData::dispatchToMainThread): 2671 (DidModifyOriginData::DidModifyOriginData): 2672 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread): 2673 (WebDatabaseManager::dispatchDidModifyOrigin): 2674 (WebDatabaseManager::dispatchDidModifyDatabase): 2675 2676 2010-10-20 Dirk Schulze <krit (a] webkit.org> 2677 2678 Reviewed by Nikolas Zimmermann. 2679 2680 Merge ColorSpace and ImageColorSpace enums 2681 https://bugs.webkit.org/show_bug.cgi?id=47922 2682 2683 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB 2684 to follow webkit style rules. 2685 2686 * FullscreenVideoController.cpp: 2687 (HUDButton::draw): 2688 (HUDSlider::draw): 2689 (FullscreenVideoController::draw): 2690 * WebCoreSupport/WebDragClient.cpp: 2691 (WebDragClient::createDragImageForLink): 2692 * WebKitGraphics.cpp: 2693 (WebDrawText): 2694 2695 2010-10-18 Pavel Podivilov <podivilov (a] chromium.org> 2696 2697 Reviewed by Timothy Hatcher. 2698 2699 Web Inspector: disable private browsing for inspector 2700 https://bugs.webkit.org/show_bug.cgi?id=47827 2701 2702 * WebCoreSupport/WebInspectorClient.cpp: 2703 (WebInspectorClient::openInspectorFrontend): 2704 2705 2010-10-17 Adam Barth <abarth (a] webkit.org> 2706 2707 Reviewed by Dimitri Glazkov. 2708 2709 FrameLoader doesn't need an explicit userGesture parameter 2710 https://bugs.webkit.org/show_bug.cgi?id=47777 2711 2712 Update for the new API. 2713 2714 * WebCoreSupport/WebContextMenuClient.cpp: 2715 (WebContextMenuClient::searchWithGoogle): 2716 2717 2010-10-15 Brian Weinstein <bweinstein (a] apple.com> 2718 2719 Reviewed by Sam Weinig. 2720 2721 REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request. 2722 https://bugs.webkit.org/show_bug.cgi?id=47753 2723 <rdar://problem/8558242> 2724 2725 VerQueryValue returns a null terminated string, but we need to strip off the null terminating character 2726 when we turn it into a WebCore string, or else concatenation using this string will break. 2727 2728 * WebView.cpp: 2729 2730 2010-10-15 Jessie Berlin <jberlin (a] apple.com> 2731 2732 Windows build fix. Unreviewed. 2733 2734 * WebCoreSupport/WebInspectorClient.cpp: 2735 Add a missing include. 2736 2737 2010-10-15 Nikolas Zimmermann <nzimmermann (a] rim.com> 2738 2739 Reviewed by Dirk Schulze. 2740 2741 Replace some String::format() usages by StringConcatenate in WebKit 2742 https://bugs.webkit.org/show_bug.cgi?id=47714 2743 2744 * WebCoreSupport/WebInspectorClient.cpp: 2745 (WebInspectorFrontendClient::updateWindowTitle): 2746 * WebView.cpp: 2747 (WebView::standardUserAgentWithApplicationName): 2748 (osVersion): 2749 2750 2010-10-14 Ilya Tikhonovsky <loislo (a] chromium.org> 2751 2752 Reviewed by Pavel Feldman. 2753 2754 Web Inspector: inspector settings/properties/states management 2755 should be extracted into separate class. 2756 2757 We have a lot of flags/values in InspectorController. 2758 Some flags are persisting into profile. 2759 Others are part of inspector state for frontend. 2760 All these flags should keep their values after navigation. 2761 It'd be better to extract these flags/values into separate 2762 class which will care about theirs lifetime. 2763 2764 https://bugs.webkit.org/show_bug.cgi?id=47275 2765 2766 * WebCoreSupport/WebInspectorClient.cpp: 2767 (WebInspectorFrontendClient::attachWindow): 2768 (WebInspectorFrontendClient::detachWindow): 2769 (WebInspectorFrontendClient::showWindowWithoutNotifications): 2770 2771 2010-10-13 Gavin Barraclough <barraclough (a] apple.com> 2772 2773 Reviewed by Oliver Hunt. 2774 2775 https://bugs.webkit.org/show_bug.cgi?id=43987 2776 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder 2777 to construct their internal result string. Remove ScriptString (this is now 2778 redundant). 2779 2780 * WebCoreSupport/WebFrameLoaderClient.cpp: 2781 2782 2010-10-12 Adam Roben <aroben (a] apple.com> 2783 2784 Build TestWebKitAPI on Windows 2785 2786 Fixes <http://webkit.org/b/47552> <rdar://problem/8541708> Make 2787 TestWebKitAPI work on Windows 2788 2789 Reviewed by Sam Weinig. 2790 2791 * WebKit.vcproj/WebKit.sln: Added TestWebKitAPI and 2792 TestWebKitAPIGenerated and made them build just after 2793 WebKitTestRunner. 2794 2795 2010-10-11 Shinichiro Hamaji <hamaji (a] chromium.org> 2796 2797 Attempt to fix windows build failure. 2798 2799 Remove WebIconFetcher from WebKit and IconFetcher from WebCore 2800 https://bugs.webkit.org/show_bug.cgi?id=47523 2801 2802 * Interfaces/IWebFramePrivate.idl: s/unused1/unused2/ 2803 * Interfaces/WebKit.idl: Touched. 2804 * WebFrame.cpp: s/unused1/unused2/ 2805 (WebFrame::unused2): 2806 * WebFrame.h: s/unused1/unused2/ 2807 2808 2010-10-11 Anders Carlsson <andersca (a] apple.com> 2809 2810 Reviewed by Darin Adler. 2811 2812 Remove WebIconFetcher from WebKit and IconFetcher from WebCore 2813 https://bugs.webkit.org/show_bug.cgi?id=47523 2814 2815 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses. 2816 2817 * Interfaces/IWebFramePrivate.idl: 2818 * Interfaces/IWebIconFetcher.idl: Removed. 2819 * Interfaces/WebKit.idl: 2820 * WebFrame.cpp: 2821 (WebFrame::unused1): 2822 * WebFrame.h: 2823 * WebIconFetcher.cpp: Removed. 2824 * WebIconFetcher.h: Removed. 2825 * WebKit.vcproj/Interfaces.vcproj: 2826 * WebKit.vcproj/WebKit.vcproj: 2827 2828 2010-10-11 Jessie Berlin <jberlin (a] apple.com> 2829 2830 Reviewed by Darin Adler. 2831 2832 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal 2833 representation of a WebKit1 WebSerializedJSValue. 2834 https://bugs.webkit.org/show_bug.cgi?id=47439 2835 2836 * Interfaces/IWebSerializedJSValuePrivate.idl: 2837 Because it is taking a void** parameter, getInternalRepresentation must be declared [local]. 2838 2839 * WebSerializedJSValue.cpp: 2840 (WebSerializedJSValue::getInternalRepresentation): 2841 * WebSerializedJSValue.h: 2842 2843 2010-10-07 Jessie Berlin <jberlin (a] apple.com> 2844 2845 Reviewed by Sam Weinig. 2846 2847 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal 2848 representation of a WebKit2 WebSerializedScriptValue. 2849 https://bugs.webkit.org/show_bug.cgi?id=47390 2850 2851 * Interfaces/WebKit.idl: 2852 Generate IWebSerializedJSValuePrivate. 2853 2854 * Interfaces/IWebSerializedJSValuePrivate.idl: Added. 2855 Because it is taking a void* parameter, setInternalRepresentation must be declared [local]. 2856 2857 * WebKit.vcproj/Interfaces.vcproj: 2858 Add IWebSerializedJSValue.idl and IWebSerializedJSValuePrivate.idl. 2859 2860 * WebSerializedJSValue.cpp: 2861 (WebSerializedJSValue::QueryInterface): 2862 Since there are now two interfaces that inherit from IUnknown, do not try to cast to 2863 IUnknown* anymore. Cast to IWebSerializedJSValue* instead. 2864 (WebSerializedJSValue::setInternalRepresentation): 2865 Only set the internal representation if it hasn't already been set. 2866 * WebSerializedJSValue.h: 2867 2868 2010-10-04 Jon Honeycutt <jhoneycutt (a] apple.com> 2869 2870 Prevent an assertion failure when trying to create a protection space 2871 for file/data URLs. 2872 2873 Reviewed by Sam Weinig. 2874 2875 * WebURLProtectionSpace.cpp: 2876 (WebURLProtectionSpace::initWithHost): 2877 Remove the ASSERT_NOT_REACHED(). 2878 2879 2010-10-05 Brent Fulgham <bfulgham (a] webkit.org> 2880 2881 Unreviewed build correction. 2882 2883 * WebKit.vcproj/WebKit.sln: Turn the QTMovieWin project 2884 off for WinCairo release builds. Somehow this was 2885 incorrectly turned on. 2886 2887 2010-10-01 Mark Rowe <mrowe (a] apple.com> 2888 2889 Build fix. 2890 2891 Clear the executable bit from a number of source files. 2892 2893 * WebView.cpp: 2894 * WebView.h: 2895 2896 2010-09-30 Darin Adler <darin (a] apple.com> 2897 2898 Reviewed by Sam Weinig. 2899 2900 Remove remaining calls to deprecatedParseURL 2901 https://bugs.webkit.org/show_bug.cgi?id=26599 2902 2903 * WebCoreSupport/WebFrameLoaderClient.cpp: 2904 (WebFrameLoaderClient::dispatchDidFailToStartPlugin): 2905 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL. 2906 2907 2010-09-28 Jenn Braithwaite <jennb (a] chromium.org> 2908 2909 Reviewed by Dmitry Titov. 2910 2911 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument. 2912 https://bugs.webkit.org/show_bug.cgi?id=46663 2913 2914 * WebCoreSupport/WebFrameLoaderClient.cpp: 2915 (WebFrameLoaderClient::didTransferChildFrameToNewDocument): 2916 * WebCoreSupport/WebFrameLoaderClient.h: 2917 2918 2010-09-27 Andrey Kosyakov <caseq (a] chromium.org> 2919 2920 Unreviewed build fix (win; broken in r68371) 2921 2922 * WebFrame.cpp: remove include <WebCore/ResourceHandleWin.h> 2923 2924 2010-09-23 Matthew Delaney <mdelaney (a] apple.com> 2925 2926 Reviewed by Simon Fraser. 2927 2928 Reduce minimum DOMTimer interval 2929 https://bugs.webkit.org/show_bug.cgi?id=45362 2930 2931 * WebView.cpp: 2932 Updating set interval call to use Settings' static version inside 2933 one time init block. 2934 2935 2010-09-23 Nate Chapin <japhet (a] chromium.org> 2936 2937 Unreviewed, build fix. 2938 2939 Move hyperlinkAuditingEnabled to IWebPreferencesPrivate.idl 2940 and touch WebKit.idl 2941 2942 * Interfaces/IWebPreferences.idl: 2943 * Interfaces/IWebPreferencesPrivate.idl: 2944 * Interfaces/WebKit.idl: 2945 * WebView.cpp: 2946 (WebView::notifyPreferencesChanged): 2947 2948 2010-09-23 Nate Chapin <japhet (a] chromium.org> 2949 2950 Unreviewed, build fix. 2951 2952 Look for hyperlinkAuditingEnabled in the right set of preferences. 2953 2954 * WebView.cpp: 2955 (WebView::notifyPreferencesChanged): 2956 2957 2010-09-23 Nate Chapin <japhet (a] chromium.org> 2958 2959 Reviewed by Darin Fisher. 2960 2961 Add hyperlink auditing settings (i.e., <a ping>). 2962 https://bugs.webkit.org/show_bug.cgi?id=30458 2963 2964 * Interfaces/IWebPreferences.idl: 2965 * WebPreferenceKeysPrivate.h: 2966 * WebPreferences.cpp: 2967 (WebPreferences::initializeDefaultSettings): 2968 (WebPreferences::hyperlinkAuditingEnabled): 2969 (WebPreferences::setHyperlinkAuditingEnabled): 2970 * WebPreferences.h: 2971 * WebView.cpp: 2972 (WebView::notifyPreferencesChanged): 2973 2974 2010-09-23 Matthew Delaney <mdelaney (a] apple.com> 2975 2976 Reviewed by Adam Roben. 2977 2978 Create one time initialization block for WebView's initWithFrame 2979 https://bugs.webkit.org/show_bug.cgi?id=46307 2980 2981 * WebView.cpp: Added one time initialization block for webview code 2982 that needs only be run once and not for each webview. This is just as 2983 the mac version WebView.mm does. 2984 2985 2010-09-22 Brent Fulgham <bfulgham (a] webkit.org> 2986 2987 Reviewed by Martin Robinson. 2988 2989 [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build. 2990 https://bugs.webkit.org/show_bug.cgi?id=46303. 2991 2992 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and 2993 Release_Cairo configurations to select appropriate build 2994 targets for WebKitTestRunner and MiniBrowser. 2995 2996 2010-09-22 Brent Fulgham <bfulgham (a] webkit.org> 2997 2998 Reviewed by Martin Robinson. 2999 3000 [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.rt 3001 https://bugs.webkit.org/show_bug.cgi?id=46303. 3002 3003 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and 3004 Release_Cairo configurations to select appropriate build 3005 targets for InjectionBundle. 3006 3007 2010-09-22 Balazs Kelemen <kb (a] inf.u-szeged.hu> 3008 3009 Reviewed by Kenneth Rohde Christiansen. 3010 3011 PluginStrategy should satisfy the needs of Qt 3012 https://bugs.webkit.org/show_bug.cgi?id=45857 3013 No new functionality so no new tests. 3014 3015 * WebCoreSupport/WebPlatformStrategies.cpp: 3016 (WebPlatformStrategies::getPluginInfo): 3017 * WebCoreSupport/WebPlatformStrategies.h: 3018 3019 2010-09-20 Philippe Normand <pnormand (a] igalia.com> 3020 3021 Reviewed by Eric Carlson. 3022 3023 [GTK] enhanced context menu for media elements 3024 https://bugs.webkit.org/show_bug.cgi?id=45021 3025 3026 New localized strings for the media element context-menu. 3027 3028 * WebCoreSupport/WebPlatformStrategies.cpp: 3029 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): 3030 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): 3031 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): 3032 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): 3033 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls): 3034 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): 3035 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): 3036 (WebPlatformStrategies::contextMenuItemTagMediaPlay): 3037 (WebPlatformStrategies::contextMenuItemTagMediaPause): 3038 (WebPlatformStrategies::contextMenuItemTagMediaMute): 3039 * WebCoreSupport/WebPlatformStrategies.h: 3040 3041 2010-09-17 Darin Adler <darin (a] apple.com> 3042 3043 Reviewed by Sam Weinig. 3044 3045 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload 3046 https://bugs.webkit.org/show_bug.cgi?id=42863 3047 3048 * WebView.cpp: 3049 (WebView::setZoomMultiplier): 3050 Call functions on Frame instead of FrameView. 3051 3052 2010-09-17 Matthew Delaney <mdelaney (a] apple.com> 3053 3054 Reviewed by Simon Fraser. 3055 3056 Reduce minimum DOMTimer interval 3057 https://bugs.webkit.org/show_bug.cgi?id=45362 3058 3059 * WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms. 3060 3061 2010-09-17 Simon Fraser <simon.fraser (a] apple.com> 3062 3063 Reviewed by Chris Marrin. 3064 3065 Remove scroll and clip layers for WKCACFLayerRenderer 3066 https://bugs.webkit.org/show_bug.cgi?id=45922 3067 3068 WKCACFLayerRenderer no longer needs its own layers for managing scrolling 3069 and clipping, because RenderLayerCompositor provides this functionality. 3070 3071 * WebView.cpp: 3072 (WebView::sizeChanged): Moved code that handles the WM_SIZE message 3073 into this method. Use it to resize the layer renderer. 3074 (WebView::WebViewWndProc): Call sizeChanged(). 3075 (WebView::updateRootLayerContents): No need to call setScrollFrame() any more. 3076 (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline). 3077 * WebView.h: 3078 3079 2010-09-16 Darin Adler <darin (a] apple.com> 3080 3081 Reviewed by Andreas Kling. 3082 3083 Reduce use of HTMLInputElement::inputType so we can remove it later 3084 https://bugs.webkit.org/show_bug.cgi?id=45903 3085 3086 * WebFrame.cpp: 3087 (WebFrame::elementDoesAutoComplete): Use isPasswordField. 3088 (WebFrame::elementIsPassword): Use isPasswordField. 3089 3090 2010-09-14 Ada Chan <adachan (a] apple.com> 3091 3092 Reviewed by Adam Roben. 3093 3094 Add an IWebFramePrivate API to load string as plain text into the WebFrame. 3095 https://bugs.webkit.org/show_bug.cgi?id=45782 3096 3097 * Interfaces/IWebFramePrivate.idl: 3098 * Interfaces/WebKit.idl: Touch the file. 3099 * WebFrame.cpp: 3100 (WebFrame::loadPlainTextString): 3101 * WebFrame.h: 3102 3103 2010-09-13 Enrica Casucci <enrica (a] apple.com> 3104 3105 Reviewed by Sam Weinig. 3106 3107 Paste should be implemented in WebCore like Copy and Cut for Mac also. 3108 https://bugs.webkit.org/show_bug.cgi?id=45494 3109 <rdar://problem/7660537> 3110 3111 On the Mac platform, the implementation of the paste operation is all done 3112 at the WebKit level. In order to support it on WebKit2 it is necessary to 3113 refactor the code and move this functionality at the level of WebCore like 3114 we already have on Windows. 3115 The original code relies on some in AppKit functions that call back into 3116 WebKit causing problems in WebKit2. All this functionality has been moved 3117 at the level of the editor client where it can be dealt with appropriately. 3118 3119 * WebFrame.cpp: 3120 (WebFrame::canShowMIMETypeASHTML): Added. 3121 3122 2010-09-11 Adam Barth <abarth (a] webkit.org> 3123 3124 Reviewed by Sam Weinig. 3125 3126 Make SecurityOrigin::canDisplay an instance function 3127 https://bugs.webkit.org/show_bug.cgi?id=45219 3128 3129 * WebFrame.cpp: 3130 (WebFrame::allowsFollowingLink): 3131 3132 2010-09-10 Jesus Sanchez-Palencia <jesus.palencia (a] openbossa.org> 3133 3134 Reviewed by Darin Adler. 3135 3136 Add NetworkingContext to avoid layer violations 3137 https://bugs.webkit.org/show_bug.cgi?id=42292 3138 3139 * WebCoreSupport/WebFrameNetworkingContext.cpp: 3140 (WebFrameNetworkingContext::blockedError): 3141 * WebCoreSupport/WebFrameNetworkingContext.h: 3142 3143 2010-09-10 Jer Noble <jer.noble (a] apple.com> 3144 3145 Reviewed by Simon Fraser. 3146 3147 Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows) 3148 https://bugs.webkit.org/show_bug.cgi?id=45333 3149 3150 The rootChild layer must be set as flipped, otherwise transformed movies will appear 3151 incorrectly rotated. 3152 3153 * FullscreenVideoController.cpp: 3154 (FullscreenVideoController::enterFullscreen): 3155 3156 2010-09-10 Sam Weinig <sam (a] webkit.org> 3157 3158 Reviewed by Darin Adler. 3159 3160 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom. 3161 Precursor to <rdar://problem/7660657> 3162 https://bugs.webkit.org/show_bug.cgi?id=45522 3163 3164 * WebFrame.cpp: 3165 * WebFrame.h: 3166 Remove dead code. 3167 3168 * WebView.cpp: 3169 (WebView::WebView): 3170 (WebView::setZoomMultiplier): 3171 (WebView::zoomMultiplier): 3172 (WebView::canMakeTextLarger): 3173 (WebView::makeTextLarger): 3174 (WebView::canMakeTextSmaller): 3175 (WebView::makeTextSmaller): 3176 (WebView::notifyPreferencesChanged): 3177 * WebView.h: 3178 Move tracking of text only zoom here from WebCore. 3179 3180 2010-09-10 Brian Weinstein <bweinstein (a] apple.com> 3181 3182 Windows Build Fix. Fix some fallout from r67238, currentForm is now off of 3183 SelectionController instead of frame. Also fix a style issue. 3184 3185 * WebFrame.cpp: 3186 (WebFrame::currentForm): 3187 3188 2010-09-10 Adam Barth <abarth (a] webkit.org> 3189 3190 Reviewed by Darin Fisher. 3191 3192 Move code from WebKit-layer to DocumentLoader 3193 https://bugs.webkit.org/show_bug.cgi?id=45569 3194 3195 * WebCoreSupport/WebFrameLoaderClient.cpp: 3196 (WebFrameLoaderClient::committedLoad): 3197 * WebCoreSupport/WebFrameLoaderClient.h: 3198 3199 2010-09-09 Darin Adler <darin (a] apple.com> 3200 3201 Reviewed by Adam Barth. 3202 3203 Move functions from Frame to SelectionController as planned 3204 https://bugs.webkit.org/show_bug.cgi?id=45508 3205 3206 * WebView.cpp: 3207 (WebView::selectionRect): 3208 (WebView::centerSelectionInVisibleArea): 3209 Call functions on selection(). 3210 3211 2010-09-10 Adam Barth <abarth (a] webkit.org> 3212 3213 Reviewed by Eric Seidel. 3214 3215 Main resource bytes shouldn't bounce through FrameLoader 3216 https://bugs.webkit.org/show_bug.cgi?id=45496 3217 3218 Now return the bytes to the DocumentLoader. 3219 3220 * WebCoreSupport/WebFrameLoaderClient.cpp: 3221 (WebFrameLoaderClient::receivedData): 3222 3223 2010-09-09 Simon Fraser <simon.fraser (a] apple.com> 3224 3225 Reviewed by Adam Roben. 3226 3227 Scrollbars fail to render in composited iframes. 3228 https://bugs.webkit.org/show_bug.cgi?id=45335 3229 3230 Use LocalWindowsContext when painting scrollbars. 3231 3232 * WebCoreSupport/WebChromeClient.cpp: 3233 (WebChromeClient::paintCustomScrollbar): 3234 (WebChromeClient::paintCustomScrollCorner): 3235 3236 2010-09-08 Darin Adler <darin (a] apple.com> 3237 3238 Reviewed by Adam Barth. 3239 3240 Move functions from Frame to Editor as planned 3241 https://bugs.webkit.org/show_bug.cgi?id=45218 3242 3243 * WebCoreSupport/WebContextMenuClient.cpp: 3244 (WebContextMenuClient::searchWithGoogle): 3245 * WebFrame.cpp: 3246 (WebFrame::selectedString): 3247 * WebView.cpp: 3248 (WebView::selectedText): 3249 (WebView::prepareCandidateWindow): 3250 (WebView::onIMERequestCharPosition): 3251 Changed call sites to use editor(). 3252 3253 2010-09-08 Peter Kasting <pkasting (a] google.com> 3254 3255 Not reviewed, build fix. 3256 3257 * WebScrollBar.cpp: 3258 (WebScrollBar::setScrollOffsetFromAnimation): 3259 3260 2010-09-08 Peter Kasting <pkasting (a] google.com> 3261 3262 Not reviewed, build fix. 3263 3264 * WebScrollBar.cpp: 3265 (WebScrollBar::scrollSize): 3266 (WebScrollBar::setScrollOffsetFromAnimation): 3267 3268 2010-09-08 Peter Kasting <pkasting (a] google.com> 3269 3270 Not reviewed, build fix. 3271 3272 * WebScrollBar.cpp: 3273 (WebScrollBar::setValue): 3274 (WebScrollBar::scrollSize): 3275 (WebScrollBar::setScrollOffsetFromAnimation): 3276 * WebScrollBar.h: 3277 3278 2010-09-08 Adam Barth <abarth (a] webkit.org> 3279 3280 Attempted Window build fix. 3281 3282 * WebDataSource.cpp: 3283 (WebDataSource::subresourceForURL): 3284 3285 2010-09-08 Adam Barth <abarth (a] webkit.org> 3286 3287 Rubber-stamped by Eric Seidel. 3288 3289 Rename DocLoader to CachedResourceLoader because that's what it does. 3290 3291 * WebDataSource.cpp: 3292 3293 2010-09-07 Brent Fulgham <bfulgham (a] webkit.org> 3294 3295 Reviewed by Adam Roben. 3296 3297 Clean up a potential resource leak. 3298 https://bugs.webkit.org/show_bug.cgi?id=45198 3299 3300 Several bitmap device context were being created and used, 3301 and destroyed without returning the context to its original 3302 state. This showed up as bitmap leaks in BoundsChecker. 3303 3304 * FullscreenVideoController.cpp: 3305 * WebView.cpp: 3306 (WebView::scrollBackingStore): 3307 (WebView::paint): 3308 3309 2010-09-06 Adam Barth <abarth (a] webkit.org> 3310 3311 Reviewed by Darin Adler. 3312 3313 Rename SecurityOrigin::canLoad to canDisplay 3314 https://bugs.webkit.org/show_bug.cgi?id=45214 3315 3316 Propagate name change. 3317 3318 * WebFrame.cpp: 3319 (WebFrame::allowsFollowingLink): 3320 3321 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia (a] openbossa.org> 3322 3323 Reviewed by Darin Adler. 3324 3325 Add NetworkingContext to avoid layer violations 3326 https://bugs.webkit.org/show_bug.cgi?id=42292 3327 3328 Add Win's specific implementation of NetworkingContext. 3329 3330 * WebCoreSupport/WebFrameNetworkingContext.cpp: 3331 (WebFrameNetworkingContext::create): 3332 (WebFrameNetworkingContext::userAgent): 3333 (WebFrameNetworkingContext::referrer): 3334 * WebFrame.cpp: 3335 (WebFrame::createNetworkingContext): 3336 * WebFrame.h: 3337 3338 2010-09-03 Adam Roben <aroben (a] apple.com> 3339 3340 Attempt to fixing Windows nightlies again 3341 3342 The fix in r66438 should be sufficient, but we have to touch 3343 WebKit.idl to force that change to be picked up by the build. 3344 3345 * Interfaces/WebKit.idl: Touched this file to force a build. 3346 3347 2010-09-02 Yury Semikhatsky <yurys (a] chromium.org> 3348 3349 Reviewed by PavelFeldman. 3350 3351 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector 3352 https://bugs.webkit.org/show_bug.cgi?id=44230 3353 3354 * WebCoreSupport/WebInspectorClient.cpp: 3355 (WebInspectorFrontendClient::~WebInspectorFrontendClient): 3356 (WebInspectorFrontendClient::closeWindow): 3357 (WebInspectorFrontendClient::disconnectFromBackend): 3358 (WebInspectorFrontendClient::closeWindowWithoutNotifications): 3359 (WebInspectorFrontendClient::destroyInspectorView): 3360 * WebCoreSupport/WebInspectorClient.h: 3361 3362 2010-09-01 Jessie Berlin <jberlin (a] apple.com> 3363 3364 Reviewed by Adam Roben. 3365 3366 WebViews should allow their parent windows to handle WM_MOUSEACTIVATE messages. 3367 https://bugs.webkit.org/show_bug.cgi?id=45047 3368 3369 * WebView.cpp: 3370 (WebView::WebViewWndProc): 3371 3372 2010-08-31 Dave Hyatt <hyatt (a] apple.com> 3373 3374 Reviewed by Sam Weinig. 3375 3376 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that 3377 the former can occur in more places without having to do the latter. 3378 3379 * WebFrame.cpp: 3380 (WebFrame::paintDocumentRectToContext): 3381 * WebView.cpp: 3382 (WebView::updateBackingStore): 3383 3384 2010-08-30 Adam Roben <aroben (a] apple.com> 3385 3386 Fix crash on launch on Windows due to changing IWebFramePrivate's 3387 vtable 3388 3389 This regressed in r65107. 3390 3391 Fixes <http://webkit.org/b/44755>. 3392 3393 Rubber-stamped by Jon Honeycutt. 3394 3395 * Interfaces/IWebFramePrivate.idl: Moved suspendAnimations and 3396 resumeAnimations to the end of the interface so that the vtable will 3397 match what Safari expects. 3398 3399 2010-08-30 Sheriff Bot <webkit.review.bot (a] gmail.com> 3400 3401 Unreviewed, rolling out r66198. 3402 http://trac.webkit.org/changeset/66198 3403 https://bugs.webkit.org/show_bug.cgi?id=44856 3404 3405 It made tests crash on Qt bot (Requested by Ossy_ on #webkit). 3406 3407 * WebCoreSupport/WebInspectorClient.cpp: 3408 (WebInspectorFrontendClient::~WebInspectorFrontendClient): 3409 (WebInspectorFrontendClient::closeWindow): 3410 (WebInspectorFrontendClient::closeWindowWithoutNotifications): 3411 (WebInspectorFrontendClient::destroyInspectorView): 3412 * WebCoreSupport/WebInspectorClient.h: 3413 3414 2010-08-27 Yury Semikhatsky <yurys (a] chromium.org> 3415 3416 Reviewed by Pavel Feldman. 3417 3418 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector 3419 https://bugs.webkit.org/show_bug.cgi?id=44230 3420 3421 * WebCoreSupport/WebInspectorClient.cpp: 3422 (WebInspectorFrontendClient::~WebInspectorFrontendClient): 3423 (WebInspectorFrontendClient::closeWindow): 3424 (WebInspectorFrontendClient::disconnectFromBackend): 3425 (WebInspectorFrontendClient::closeWindowWithoutNotifications): 3426 (WebInspectorFrontendClient::destroyInspectorView): 3427 * WebCoreSupport/WebInspectorClient.h: 3428 3429 2010-08-26 Yury Semikhatsky <yurys (a] chromium.org> 3430 3431 Unreviewed. Revert r66103 since Qt tests are failing. 3432 3433 * WebCoreSupport/WebInspectorClient.cpp: 3434 (WebInspectorFrontendClient::~WebInspectorFrontendClient): 3435 (WebInspectorFrontendClient::closeWindow): 3436 (WebInspectorFrontendClient::closeWindowWithoutNotifications): 3437 (WebInspectorFrontendClient::destroyInspectorView): 3438 * WebCoreSupport/WebInspectorClient.h: 3439 3440 2010-08-26 Yury Semikhatsky <yurys (a] chromium.org> 3441 3442 Reviewed by Pavel Feldman. 3443 3444 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector 3445 https://bugs.webkit.org/show_bug.cgi?id=44230 3446 3447 * WebCoreSupport/WebInspectorClient.cpp: 3448 (WebInspectorFrontendClient::~WebInspectorFrontendClient): 3449 (WebInspectorFrontendClient::closeWindow): 3450 (WebInspectorFrontendClient::disconnectFromBackend): 3451 (WebInspectorFrontendClient::closeWindowWithoutNotifications): 3452 (WebInspectorFrontendClient::destroyInspectorView): 3453 * WebCoreSupport/WebInspectorClient.h: 3454 3455 2010-08-24 Ada Chan <adachan (a] apple.com> 3456 3457 Reviewed by Steve Falkenburg. 3458 3459 <rdar://problem/8185379> Possible null dereference in WebView::canShowMIMEType. 3460 https://bugs.webkit.org/show_bug.cgi?id=44564 3461 3462 * WebView.cpp: 3463 (WebView::canShowMIMEType): Null check m_page->pluginData() since that can return NULL 3464 if plugins are disabled. 3465 3466 2010-08-22 Daniel Bates <dbates (a] rim.com> 3467 3468 Reviewed by Eric Seidel. 3469 3470 Encapsulate document marker management into DocumentMarkerController 3471 https://bugs.webkit.org/show_bug.cgi?id=44383 3472 3473 Modify call sites in the Apple Windows port to use DocumentMarkerController. 3474 3475 No functionality was changed, so no new tests. 3476 3477 * WebFrame.cpp: 3478 (WebFrame::unmarkAllMisspellings): 3479 (WebFrame::unmarkAllBadGrammar): 3480 * WebView.cpp: 3481 (WebView::rectsForTextMatches): 3482 3483 2010-08-18 Jessie Berlin <jberlin (a] apple.com> 3484 3485 Reviewed by Adam Roben. 3486 3487 Bug 44180 - WebView::paint fails to paint a child WebView of a Layered Window. 3488 https://bugs.webkit.org/show_bug.cgi?id=44180 3489 3490 Decide to end painting if the m_backingStoreBitmap is null after the call to 3491 ensureBackingStore() instead of when the rcPaint rect filled by BeginPaint is empty. 3492 The rcPaint rect filled by BeginPaint is always empty for a child WebView of a Layered 3493 Window, even if GetUpdateRect and GetUpdateRgn report a non-empty region that needs 3494 painting. 3495 3496 * WebView.cpp: 3497 (WebView::paint): 3498 3499 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia (a] openbossa.org> 3500 3501 Reviewed by Darin Adler. 3502 3503 Add NetworkingContext to avoid layer violations 3504 https://bugs.webkit.org/show_bug.cgi?id=42292 3505 3506 Preparation: Just add the files to the build system. 3507 3508 * WebCoreSupport/WebFrameNetworkingContext.cpp: Added. 3509 Empty placeholder for now. 3510 * WebCoreSupport/WebFrameNetworkingContext.h: Added. 3511 Placeholder with tentative code that might be changed when landing 3512 the rest of it. 3513 * WebKit.vcproj/WebKit.vcproj: Added new files. 3514 3515 2010-08-17 Brady Eidson <beidson (a] apple.com> 3516 3517 Reviewed by Sam Weinig. 3518 3519 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed. 3520 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131 3521 3522 * WebView.cpp: 3523 (WebView::canGoBack): Return false if loads are deferred. 3524 (WebView::canGoForward): Ditto. 3525 3526 2010-08-16 Kinuko Yasuda <kinuko (a] chromium.org> 3527 3528 Unreviewed; build fix attempt for Windows. 3529 3530 * DefaultDownloadDelegate.cpp: 3531 3532 2010-08-12 Jeremy Orlow <jorlow (a] chromium.org> 3533 3534 Revert for now 3535 https://bugs.webkit.org/show_bug.cgi?id=43794 3536 3537 * WebView.cpp: 3538 (WebView::initWithFrame): 3539 3540 2010-08-12 Jeremy Orlow <jorlow (a] chromium.org> 3541 3542 Build fix. Matches solutions in qt and mac ports for 3543 https://bugs.webkit.org/show_bug.cgi?id=43794 3544 3545 * WebView.cpp: 3546 (WebView::initWithFrame): 3547 3548 2010-08-10 Gavin Barraclough <barraclough (a] apple.com> 3549 3550 Build fix (update more includes) 3551 3552 * WebKitDLL.h: 3553 * WebLocalizableStrings.cpp: 3554 * WebNotificationCenter.cpp: 3555 * WebPreferences.cpp: 3556 3557 2010-08-10 Chris Marrin <cmarrin (a] apple.com> 3558 3559 Reviewed by Oliver Hunt. 3560 3561 Add suspendAnimations/resumeAnimation API to DRT 3562 https://bugs.webkit.org/show_bug.cgi?id=43733 3563 3564 Win specific API 3565 3566 * Interfaces/IWebFramePrivate.idl: 3567 * WebFrame.cpp: 3568 (WebFrame::suspendAnimations): 3569 (WebFrame::resumeAnimations): 3570 * WebFrame.h: 3571 3572 2010-08-06 Gavin Barraclough <barraclough (a] apple.com> 3573 3574 Rubber stamped by Sam Weinig 3575 3576 Bug 43594 - Add string forwards to Forward.h 3577 This allows us to remove forward declarations for these classes from 3578 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::). 3579 3580 * COMVariantSetter.h: 3581 * MarshallingHelpers.h: 3582 * WebCoreSupport/WebContextMenuClient.h: 3583 * WebCoreSupport/WebPluginHalterClient.h: 3584 * WebHistory.h: 3585 3586 2010-08-06 Jessie Berlin <jberlin (a] apple.com> 3587 3588 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build. 3589 Unreviewed. 3590 3591 * COMVariantSetter.h: 3592 * MarshallingHelpers.h: 3593 * WebCoreSupport/WebContextMenuClient.h: 3594 * WebCoreSupport/WebPluginHalterClient.h: 3595 * WebHistory.h: 3596 3597 2010-08-05 Jessie Berlin <jberlin (a] apple.com> 3598 3599 Reviewed by Jon Honeycutt. 3600 3601 Bug 43593 - WebView::backingStore should check if m_backingStoreBitmap is NULL. 3602 https://bugs.webkit.org/show_bug.cgi?id=43593 3603 3604 * WebView.cpp: 3605 (WebView::backingStore): 3606 If m_backingStoreBitmap is NULL, return E_FAIL. 3607 3608 2010-08-05 Gavin Barraclough <barraclough (a] apple.com> 3609 3610 Rubber stamped by Sam Weinig 3611 3612 Bug 43594 - Add string forwards to Forward.h 3613 This allows us to remove forward declarations for these classes from 3614 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::). 3615 3616 * COMVariantSetter.h: 3617 * MarshallingHelpers.h: 3618 * WebCoreSupport/WebContextMenuClient.h: 3619 * WebCoreSupport/WebPluginHalterClient.h: 3620 * WebHistory.h: 3621 3622 2010-08-03 Adam Roben <aroben (a] apple.com> 3623 3624 Turn on PLATFORM_STRATEGIES on Windows 3625 3626 Fixes <http://webkit.org/b/43431>. 3627 3628 Reviewed by Anders Carlsson. 3629 3630 * WebCoreLocalizedStrings.cpp: Removed. 3631 * WebCoreSupport/WebPlatformStrategies.cpp: Added. Based on the Mac 3632 equivalent. 3633 (WebPlatformStrategies::initialize): Creates the singleton instance. 3634 (WebPlatformStrategies::WebPlatformStrategies): Registers the 3635 singleton instance as the PlatformStrategies instance for WebCore. 3636 3637 (WebPlatformStrategies::createPluginStrategy): 3638 (WebPlatformStrategies::createLocalizationStrategy): 3639 (WebPlatformStrategies::createVisitedLinkStrategy): 3640 Return ourselves as the strategy. 3641 3642 (WebPlatformStrategies::refreshPlugins): 3643 (WebPlatformStrategies::getPluginInfo): 3644 Moved code here from WebCore's PluginDataWin.cpp file. 3645 3646 (WebPlatformStrategies::searchableIndexIntroduction): 3647 (WebPlatformStrategies::submitButtonDefaultLabel): 3648 (WebPlatformStrategies::inputElementAltText): 3649 (WebPlatformStrategies::resetButtonDefaultLabel): 3650 (WebPlatformStrategies::fileButtonChooseFileLabel): 3651 (WebPlatformStrategies::fileButtonNoFileSelectedLabel): 3652 (WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow): 3653 (WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk): 3654 (WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard): 3655 (WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow): 3656 (WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk): 3657 (WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard): 3658 (WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow): 3659 (WebPlatformStrategies::contextMenuItemTagCopy): 3660 (WebPlatformStrategies::contextMenuItemTagGoBack): 3661 (WebPlatformStrategies::contextMenuItemTagGoForward): 3662 (WebPlatformStrategies::contextMenuItemTagStop): 3663 (WebPlatformStrategies::contextMenuItemTagReload): 3664 (WebPlatformStrategies::contextMenuItemTagCut): 3665 (WebPlatformStrategies::contextMenuItemTagPaste): 3666 (WebPlatformStrategies::contextMenuItemTagNoGuessesFound): 3667 (WebPlatformStrategies::contextMenuItemTagIgnoreSpelling): 3668 (WebPlatformStrategies::contextMenuItemTagLearnSpelling): 3669 (WebPlatformStrategies::contextMenuItemTagSearchWeb): 3670 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): 3671 (WebPlatformStrategies::contextMenuItemTagOpenLink): 3672 (WebPlatformStrategies::contextMenuItemTagIgnoreGrammar): 3673 (WebPlatformStrategies::contextMenuItemTagSpellingMenu): 3674 (WebPlatformStrategies::contextMenuItemTagCheckSpelling): 3675 (WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping): 3676 (WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling): 3677 (WebPlatformStrategies::contextMenuItemTagFontMenu): 3678 (WebPlatformStrategies::contextMenuItemTagBold): 3679 (WebPlatformStrategies::contextMenuItemTagItalic): 3680 (WebPlatformStrategies::contextMenuItemTagUnderline): 3681 (WebPlatformStrategies::contextMenuItemTagOutline): 3682 (WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu): 3683 (WebPlatformStrategies::contextMenuItemTagTextDirectionMenu): 3684 (WebPlatformStrategies::contextMenuItemTagDefaultDirection): 3685 (WebPlatformStrategies::contextMenuItemTagLeftToRight): 3686 (WebPlatformStrategies::contextMenuItemTagRightToLeft): 3687 (WebPlatformStrategies::contextMenuItemTagShowSpellingPanel): 3688 (WebPlatformStrategies::contextMenuItemTagInspectElement): 3689 (WebPlatformStrategies::searchMenuNoRecentSearchesText): 3690 (WebPlatformStrategies::searchMenuRecentSearchesText): 3691 (WebPlatformStrategies::searchMenuClearRecentSearchesText): 3692 (WebPlatformStrategies::AXWebAreaText): 3693 (WebPlatformStrategies::AXLinkText): 3694 (WebPlatformStrategies::AXListMarkerText): 3695 (WebPlatformStrategies::AXImageMapText): 3696 (WebPlatformStrategies::AXHeadingText): 3697 (WebPlatformStrategies::AXDefinitionListTermText): 3698 (WebPlatformStrategies::AXDefinitionListDefinitionText): 3699 (WebPlatformStrategies::AXButtonActionVerb): 3700 (WebPlatformStrategies::AXRadioButtonActionVerb): 3701 (WebPlatformStrategies::AXTextFieldActionVerb): 3702 (WebPlatformStrategies::AXCheckedCheckBoxActionVerb): 3703 (WebPlatformStrategies::AXUncheckedCheckBoxActionVerb): 3704 (WebPlatformStrategies::AXLinkActionVerb): 3705 (WebPlatformStrategies::AXMenuListActionVerb): 3706 (WebPlatformStrategies::AXMenuListPopupActionVerb): 3707 (WebPlatformStrategies::unknownFileSizeText): 3708 (WebPlatformStrategies::uploadFileText): 3709 (WebPlatformStrategies::allFilesText): 3710 (WebPlatformStrategies::missingPluginText): 3711 (WebPlatformStrategies::crashedPluginText): 3712 (WebPlatformStrategies::imageTitle): 3713 (WebPlatformStrategies::multipleFileUploadText): 3714 (WebPlatformStrategies::mediaElementLoadingStateText): 3715 (WebPlatformStrategies::mediaElementLiveBroadcastStateText): 3716 (WebPlatformStrategies::localizedMediaControlElementString): 3717 (WebPlatformStrategies::localizedMediaControlElementHelpText): 3718 (WebPlatformStrategies::localizedMediaTimeDescription): 3719 (WebPlatformStrategies::validationMessageValueMissingText): 3720 (WebPlatformStrategies::validationMessageTypeMismatchText): 3721 (WebPlatformStrategies::validationMessagePatternMismatchText): 3722 (WebPlatformStrategies::validationMessageTooLongText): 3723 (WebPlatformStrategies::validationMessageRangeUnderflowText): 3724 (WebPlatformStrategies::validationMessageRangeOverflowText): 3725 (WebPlatformStrategies::validationMessageStepMismatchText): 3726 Moved code here from WebCoreLocalizedStrings.cpp (and slightly cleaned 3727 it up). 3728 3729 (WebPlatformStrategies::isLinkVisited): 3730 (WebPlatformStrategies::addVisitedLink): 3731 Copied code from WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm. 3732 3733 * WebCoreSupport/WebPlatformStrategies.h: Added. 3734 3735 * WebKit.vcproj/WebKit.vcproj: Removed WebCoreLocalizedStrings, added 3736 WebPlatformStrategies. 3737 3738 * WebView.cpp: 3739 (WebView::initWithFrame): Initialize WebPlatformStrategies. 3740 3741 2010-08-03 Alexey Proskuryakov <ap (a] apple.com> 3742 3743 Reviewed by Sam Weinig. 3744 3745 https://bugs.webkit.org/show_bug.cgi?id=42939 3746 WebEditorClient::didBeginEditing is never called in WebKit2 3747 3748 * WebView.cpp: (WebView::WebViewWndProc): Removed a call to setFocusedFrame. WebCore will 3749 now set it to main frame, and besides, this call should have been before setFocused(), not 3750 after it. My understanding is that we weren't getting all the same editing delegates on Windows, 3751 so this change may make WebKit1 on Windows behave more like Mac - but I haven't tested it. 3752 3753 2010-07-27 Luiz Agostini <luiz.agostini (a] openbossa.org> 3754 3755 Reviewed by Darin Fisher. 3756 3757 PopupMenu refactoring in preparation to WebKit2 3758 https://bugs.webkit.org/show_bug.cgi?id=42592 3759 3760 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu 3761 instances, concrete classes that inherit from ChromeClient needed to be changed to 3762 implement the new methods. 3763 3764 * WebCoreSupport/WebChromeClient.cpp: 3765 (WebChromeClient::selectItemWritingDirectionIsNatural): 3766 (WebChromeClient::createPopupMenu): 3767 (WebChromeClient::createSearchPopupMenu): 3768 * WebCoreSupport/WebChromeClient.h: 3769 3770 2010-08-02 Jon Honeycutt <jhoneycutt (a] apple.com> 3771 3772 Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live. 3773 3774 Reviewed by Sam Weinig. 3775 3776 * WebKit.vcproj/WebKit.sln: 3777 3778 2010-08-02 Jeremy Orlow <jorlow (a] chromium.org> 3779 3780 Speculative revert of 64425 due to Chromium instability 3781 https://bugs.webkit.org/show_bug.cgi?id=43347 3782 3783 * WebCoreSupport/WebChromeClient.cpp: 3784 * WebCoreSupport/WebChromeClient.h: 3785 * WebView.cpp: 3786 (WebView::mouseWheel): 3787 3788 2010-07-31 Luiz Agostini <luiz.agostini (a] openbossa.org> 3789 3790 Build fix: Windows. 3791 3792 * WebView.cpp: 3793 (WebView::mouseWheel): 3794 3795 2010-07-27 Luiz Agostini <luiz.agostini (a] openbossa.org> 3796 3797 Reviewed by Darin Fisher. 3798 3799 PopupMenu refactoring in preparation to WebKit2 3800 https://bugs.webkit.org/show_bug.cgi?id=42592 3801 3802 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu 3803 instances, concrete classes that inherit from ChromeClient needed to be changed to 3804 implement the new methods. 3805 3806 * WebCoreSupport/WebChromeClient.cpp: 3807 (WebChromeClient::selectItemWritingDirectionIsNatural): 3808 (WebChromeClient::createPopupMenu): 3809 (WebChromeClient::createSearchPopupMenu): 3810 * WebCoreSupport/WebChromeClient.h: 3811 3812 2010-07-31 Sheriff Bot <webkit.review.bot (a] gmail.com> 3813 3814 Unreviewed, rolling out r64422. 3815 http://trac.webkit.org/changeset/64422 3816 https://bugs.webkit.org/show_bug.cgi?id=43304 3817 3818 Build fixes are needed for Snow Leopard and Windows. 3819 (Requested by lca on #webkit). 3820 3821 * WebCoreSupport/WebChromeClient.cpp: 3822 * WebCoreSupport/WebChromeClient.h: 3823 3824 2010-07-27 Luiz Agostini <luiz.agostini (a] openbossa.org> 3825 3826 Reviewed by Darin Fisher. 3827 3828 PopupMenu refactoring in preparation to WebKit2 3829 https://bugs.webkit.org/show_bug.cgi?id=42592 3830 3831 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu 3832 instances, concrete classes that inherit from ChromeClient needed to be changed to 3833 implement the new methods. 3834 3835 * WebCoreSupport/WebChromeClient.cpp: 3836 (WebChromeClient::selectItemWritingDirectionIsNatural): 3837 (WebChromeClient::createPopupMenu): 3838 (WebChromeClient::createSearchPopupMenu): 3839 * WebCoreSupport/WebChromeClient.h: 3840 3841 2010-07-31 Daniel Bates <dbates (a] rim.com> 3842 3843 Attempt to fix the Windows build after changeset 64409 <http://trac.webkit.org/changeset/64409>. 3844 3845 * WebFrame.cpp: 3846 (WebFrame::setPrinting): 3847 3848 2010-07-30 Dan Bernstein <mitz (a] apple.com> 3849 3850 Reviewed by Darin Adler. 3851 3852 <rdar://problem/8257783> Short documents may print a second blank page 3853 https://bugs.webkit.org/show_bug.cgi?id=43271 3854 3855 * WebFrame.cpp: 3856 (WebFrame::setPrinting): Updated for changes to Frame::setPrinting(). Passing 0 for the 3857 page height, which maintains existing behavior. 3858 3859 2010-07-30 Joseph Pecoraro <joepeck (a] webkit.org> 3860 3861 Reviewed by David Kilzer. 3862 3863 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) 3864 https://bugs.webkit.org/show_bug.cgi?id=40627 3865 3866 * WebCoreSupport/WebChromeClient.cpp: 3867 (WebChromeClient::reachedApplicationCacheOriginQuota): 3868 * WebCoreSupport/WebChromeClient.h: 3869 3870 2010-07-26 Steve Block <steveblock (a] google.com> 3871 3872 Reviewed by Jeremy Orlow. 3873 3874 Page clients should be passed to Page constructor via structure of pointers 3875 https://bugs.webkit.org/show_bug.cgi?id=42834 3876 3877 * WebView.cpp: 3878 (WebView::initWithFrame): 3879 3880 2010-07-27 Steve Block <steveblock (a] google.com> 3881 3882 Reviewed by Alexey Proskuryakov. 3883 3884 Client-based Geolocation does not pass enableHighAccuracy option to controller and client 3885 https://bugs.webkit.org/show_bug.cgi?id=40374 3886 3887 Stub out setEnableHighAccuracy method for the Win port. 3888 3889 * WebCoreSupport/WebGeolocationControllerClient.h: 3890 (WebGeolocationControllerClient::setEnableHighAccuracy): 3891 3892 2010-07-22 Sam Weinig <sam (a] webkit.org> 3893 3894 Reviewed by Maciej Stachowiak. 3895 3896 Fix for <rdar://problem/8222626> 3897 Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input. 3898 3899 The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we 3900 should migrate to a new function name eventually 3901 3902 * WebCoreSupport/WebEditorClient.cpp: 3903 (WebEditorClient::textDidChangeInTextField): 3904 3905 2010-07-21 Brady Eidson <beidson (a] apple.com> 3906 3907 Reviewed by Geoffrey Garen. 3908 3909 Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry 3910 https://bugs.webkit.org/show_bug.cgi?id=42783 3911 3912 * WebView.cpp: 3913 (WebView::registerURLSchemeAsLocal): 3914 (WebView::registerURLSchemeAsSecure): 3915 3916 2010-07-20 Steve Falkenburg <sfalken (a] apple.com> 3917 3918 Reviewed by Adam Roben. 3919 3920 WebKit on Windows should build optionally with an unversioned ICU DLL 3921 https://bugs.webkit.org/show_bug.cgi?id=42722 3922 <rdar://problem/8211767> WebKit needs to link against unversioned ICU 3923 3924 To get the proper value for U_DISABLE_RENAMING into all source files, we force 3925 the include of ICUVersion.h (our generated header) via the compiler options. 3926 3927 * WebKit.vcproj/WebKit.vcproj: Add forced include of ICUVersion.h. 3928 3929 2010-07-21 Adam Roben <aroben (a] apple.com> 3930 3931 Update WebKit.sln for InjectedBundle's Debug_Internal configuration 3932 3933 Fixes <http://webkit.org/b/42749> InjectedBundle's build 3934 configurations are screwy 3935 3936 Reviewed by Darin Adler. 3937 3938 * WebKit.vcproj/WebKit.sln: Build the Debug_Internal variant of 3939 InjectedBundle when we're using the Debug_Internal solution 3940 configuration. 3941 3942 2010-07-21 Adam Roben <aroben (a] apple.com> 3943 3944 Add MiniBrowser to WebKit.sln 3945 3946 It is the last project to build. 3947 3948 Fixes <http://webkit.org/b/42747> build-webkit should build 3949 MiniBrowser 3950 3951 Reviewed by Darin Adler. 3952 3953 * WebKit.vcproj/WebKit.sln: Added MiniBrowser, and made it depend on 3954 WebKitTestRunner. 3955 3956 2010-07-20 Adam Roben <aroben (a] apple.com> 3957 3958 Add WebKitTestRunner and friends to WebKit.sln 3959 3960 We added these projects to WebKit2.sln in r63585, but removed them 3961 again in r63600 because WebKitTestRunner required getopt, which 3962 doesn't exist in WebKitAuxiliaryLibrary. r63700 and r63788 removed the 3963 use of getopt in WebKitTestRunner, so we can now add it to WebKit.sln 3964 (which has replaced WebKit2.sln). 3965 3966 Fixes <http://webkit.org/b/42711> WebKit.sln should build 3967 WebKitTestRunner 3968 3969 Reviewed by Steve Falkenburg. 3970 3971 * WebKit.vcproj/WebKit.sln: Added the following projects to the end of 3972 the build order (in first-built to last-built order): 3973 InjectedBundleGenerated, InjectedBundle, WebKitTestRunner. Also 3974 removed an unnecessary dependency from testapi on WebKit2WebProcess. 3975 3976 2010-07-19 Daniel Bates <dbates (a] rim.com> 3977 3978 Reviewed by Adam Roben. 3979 3980 [Win] Implement LayoutTestController::markerTextForListItem() 3981 https://bugs.webkit.org/show_bug.cgi?id=37930 3982 3983 Implements support for markerTextForListItem in the Windows port. 3984 3985 * DOMCoreClasses.cpp: 3986 (DOMElement::markerTextForListItem): Added. 3987 * DOMCoreClasses.h: 3988 * Interfaces/DOMPrivate.idl: Added declaration for markerTextForListItem(). 3989 * Interfaces/IWebViewPrivate.idl: Added declaration for elementFromJS(). 3990 * Interfaces/WebKit.idl: Touch it to force a rebuild (and for good luck :-)). 3991 * WebView.cpp: 3992 (WebView::elementFromJS): Added. 3993 * WebView.h: 3994 3995 2010-07-16 Zhe Su <suzhe (a] chromium.org> 3996 3997 Reviewed by Darin Adler. 3998 3999 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms 4000 https://bugs.webkit.org/show_bug.cgi?id=42253 4001 4002 Dummy implementation of EditorClient::willSetInputMethodState. 4003 4004 * WebCoreSupport/WebEditorClient.cpp: 4005 (WebEditorClient::willSetInputMethodState): 4006 * WebCoreSupport/WebEditorClient.h: 4007 4008 2010-07-16 Mikhail Naganov <mnaganov (a] chromium.org> 4009 4010 Reviewed by Pavel Feldman. 4011 4012 Make JS memory stats available via 'Performance' object (Web Timing). 4013 This statistics is populated only if 'WebKitMemoryInfoEnabled' 4014 preference is set. 4015 4016 'console.memory' is kept until Web Timing object becomes visible by 4017 default (currently it is hidden under compile-time flag). These stats 4018 are guarded with the same preference. 4019 4020 https://bugs.webkit.org/show_bug.cgi?id=41617 4021 4022 * Interfaces/IWebPreferencesPrivate.idl: 4023 * WebPreferenceKeysPrivate.h: 4024 * WebPreferences.cpp: 4025 (WebPreferences::initializeDefaultSettings): 4026 (WebPreferences::memoryInfoEnabled): 4027 (WebPreferences::setMemoryInfoEnabled): 4028 * WebPreferences.h: 4029 * WebView.cpp: 4030 (WebView::notifyPreferencesChanged): 4031 4032 2010-07-14 Brent Fulgham <bfulgham (a] webkit.org> 4033 4034 Reviewed by Steve Falkenburg. 4035 4036 Patch for https://bugs.webkit.org/show_bug.cgi?id=42299 4037 Correct WinCairo build for new WebKit2 project structure. 4038 4039 * WebKit.vcproj/WebKit.sln: 4040 4041 2010-07-14 Sam Weinig <sam (a] webkit.org> 4042 4043 Reviewed by Darin Adler. 4044 4045 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232 4046 Make changing Cursors work in WebKit2. 4047 4048 * WebCoreSupport/WebChromeClient.cpp: 4049 (WebChromeClient::setCursor): 4050 We now need to grab the native cursor out of the WebCore cursor. 4051 4052 (WebChromeClient::setLastSetCursorToCurrentCursor): 4053 Sets the WebView's "last set cursor" to be the current cursor so that 4054 the cursor is set correctly for plugins. 4055 * WebCoreSupport/WebChromeClient.h: 4056 * WebView.cpp: 4057 (WebView::WebView): 4058 (WebView::WebViewWndProc): 4059 * WebView.h: 4060 (WebView::setLastCursor): 4061 Change the "last set cursor" to be stored as a member instead of a global. 4062 4063 2010-07-13 Steve Falkenburg <sfalken (a] apple.com> 4064 4065 Windows build fix. 4066 Make WebKit.sln build WebKit.dll as it used to in the past. 4067 (sln is updated to include necessary projects) 4068 4069 * WebKit.vcproj/WebKit.sln: 4070 4071 2010-07-13 Tor Arne Vestb <tor.arne.vestbo (a] nokia.com> 4072 4073 Windows build fix 4074 4075 * Interfaces/WebKit.idl: Touched to force a build 4076 4077 2010-07-07 Tor Arne Vestb <tor.arne.vestbo (a] nokia.com> 4078 4079 Reviewed by Darin Adler. 4080 4081 Prevent assertion/duplicate loads for non-deferred subtitute-data loads 4082 4083 https://bugs.webkit.org/show_bug.cgi?id=30879 4084 4085 MainResourceLoader uses the member m_initialRequest to store requests for future 4086 deferred loads. When doing the actual load in handleDataLoadNow(), we therefore 4087 have to clear this request so that subsequent entries into the loader will not 4088 start yet another load. 4089 4090 This can happen as a result of a PageGroupLoadDeferrer going out of scope when 4091 returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false), 4092 but only in the case of using both substitute-data and non-deferred main resource 4093 load together. That's why two new DRT functions were added: 4094 4095 * queueLoadHTMLString() 4096 * setDeferMainResourceLoad() 4097 4098 The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac 4099 and Win the hook uses new SPI in WebDataSource. For Qt a new static member was 4100 added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt. 4101 4102 * Interfaces/IWebDataSource.idl: 4103 * WebDataSource.cpp: 4104 (WebDataSource::setDeferMainResourceDataLoad): 4105 * WebDataSource.h: 4106 4107 2010-07-12 Steve Falkenburg <sfalken (a] apple.com> 4108 4109 Reviewed by Alice Liu. 4110 4111 <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL 4112 https://bugs.webkit.org/show_bug.cgi?id=40921 4113 4114 Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib. 4115 WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code. 4116 4117 This is a first step. We'll likely want to migrate the remainder of 4118 the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2. 4119 4120 * WebKit.vcproj/WebKit.def: Removed. 4121 * WebKit.vcproj/WebKit.make: Don't fail if WebKit doesn't produce a DLL. 4122 * WebKit.vcproj/WebKit.vcproj: Build WebKit as a static lib. 4123 Renamed project name to WebKitLib to avoid confusion and naming conflicts. 4124 Generate intermediate pdb file for debuggability of static lib. 4125 Removed DLL-related options. 4126 * WebKit.vcproj/deleteButton.png: Removed. 4127 * WebKit.vcproj/deleteButtonPressed.png: Removed. 4128 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Removed. 4129 * WebKit.vcproj/fsVideoAudioVolumeLow.png: Removed. 4130 * WebKit.vcproj/fsVideoExitFullscreen.png: Removed. 4131 * WebKit.vcproj/fsVideoPause.png: Removed. 4132 * WebKit.vcproj/fsVideoPlay.png: Removed. 4133 * WebKit.vcproj/missingImage.png: Removed. 4134 * WebKit.vcproj/nullplugin.png: Removed. 4135 * WebKit.vcproj/panEastCursor.png: Removed. 4136 * WebKit.vcproj/panIcon.png: Removed. 4137 * WebKit.vcproj/panNorthCursor.png: Removed. 4138 * WebKit.vcproj/panNorthEastCursor.png: Removed. 4139 * WebKit.vcproj/panNorthWestCursor.png: Removed. 4140 * WebKit.vcproj/panSouthCursor.png: Removed. 4141 * WebKit.vcproj/panSouthEastCursor.png: Removed. 4142 * WebKit.vcproj/panSouthWestCursor.png: Removed. 4143 * WebKit.vcproj/panWestCursor.png: Removed. 4144 * WebKit.vcproj/searchCancel.png: Removed. 4145 * WebKit.vcproj/searchCancelPressed.png: Removed. 4146 * WebKit.vcproj/searchMagnifier.png: Removed. 4147 * WebKit.vcproj/searchMagnifierResults.png: Removed. 4148 * WebKit.vcproj/textAreaResizeCorner.png: Removed. 4149 * WebKit.vcproj/verticalTextCursor.png: Removed. 4150 * WebKit.vcproj/zoomInCursor.png: Removed. 4151 * WebKit.vcproj/zoomOutCursor.png: Removed. 4152 4153 2010-07-08 Aaron Boodman <aa (a] chromium.org> 4154 4155 Reviewed by Timothy Hatcher. 4156 4157 Add the ability for user scripts and user styles to affect just the top frame. 4158 4159 https://bugs.webkit.org/show_bug.cgi?id=41529 4160 4161 * WebView.cpp: 4162 (WebView::addUserScriptToGroup): 4163 (WebView::addUserStyleSheetToGroup): 4164 4165 2010-07-08 Adele Peterson <adele (a] apple.com> 4166 4167 Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler. 4168 4169 Fix for https://bugs.webkit.org/show_bug.cgi?id=41721 4170 <rdar://problem/8158561> Missing plug-in indicator should have a pressed state 4171 4172 Implement shouldMissingPluginMessageBeButton. 4173 4174 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::shouldMissingPluginMessageBeButton): 4175 * WebCoreSupport/WebChromeClient.h: 4176 4177 2010-07-07 Anders Carlsson <andersca (a] apple.com> 4178 4179 Reviewed by Simon Fraser. 4180 4181 Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories 4182 https://bugs.webkit.org/show_bug.cgi?id=41781 4183 4184 * WebKit.vcproj/WebKit.sln: 4185 4186 2010-07-07 Sam Weinig <sam (a] webkit.org> 4187 4188 Reviewed by Anders Carlsson. 4189 4190 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772 4191 Add basic piping for BackForwardControllerClient. 4192 4193 * WebView.cpp: 4194 (WebView::initWithFrame): 4195 4196 2010-07-07 Adam Roben <aroben (a] apple.com> 4197 4198 Windows build fix 4199 4200 * Interfaces/WebKit.idl: Touched to force a build. 4201 4202 2010-07-06 Steve Falkenburg <sfalken (a] apple.com> 4203 4204 Reviewed by Simon Fraser. 4205 4206 Expose URL matching from WebUserContentURLPattern 4207 https://bugs.webkit.org/show_bug.cgi?id=41726 4208 <rdar://problem/7910144> 4209 4210 We previously had a way to construct WebUserContentURLPattern 4211 instances via WebKit, but no way for callers to perform matching. 4212 This patch adds the matchesURL functionality to allow for this. 4213 4214 * Interfaces/IWebUserContentURLPattern.idl: Added matchesURL. 4215 * Interfaces/IWebView.idl: Touch to force a build. 4216 * WebUserContentURLPattern.cpp: 4217 (WebUserContentURLPattern::matchesURL): Added. Calls through to WebCore::UserContentURLPattern::matches. 4218 * WebUserContentURLPattern.h: Added matchesURL. 4219 4220 2010-07-03 Jon Honeycutt <jhoneycutt (a] apple.com> 4221 4222 The missing plug-in indicator should be clickable 4223 4224 https://bugs.webkit.org/show_bug.cgi?id=41550 4225 <rdar://problem/8132162> 4226 4227 From an original patch by Kevin Decker. 4228 4229 Reviewed by Darin Adler. 4230 4231 * Interfaces/IWebUIDelegatePrivate.idl: 4232 Added a new delegate interface, and declare a function 4233 didPressMissingPluginButton(). 4234 4235 * Interfaces/WebKit.idl: 4236 Touch this file to force interfaces to be rebuilt. 4237 4238 * WebCoreSupport/WebChromeClient.cpp: 4239 (WebChromeClient::missingPluginButtonClicked): 4240 Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its 4241 didPressMissingPluginButton() function. 4242 4243 * WebCoreSupport/WebChromeClient.h: 4244 Declare an override of missingPluginButtonClicked(). 4245 4246 2010-07-03 Erik Arvidsson <arv (a] chromium.org> 4247 4248 Reviewed by Ojan Vafai. 4249 4250 Fix issue where a contextmenu event was reporting the wrong target 4251 if the context menu was shown due to pressing the context menu key 4252 (or Shift+F10). 4253 4254 * WebView.cpp: 4255 (WebView::handleContextMenuEvent): 4256 4257 2010-07-01 Steve Falkenburg <sfalken (a] apple.com> 4258 4259 Reviewed by Adele Peterson. 4260 4261 Provide a WebView preference to disable DNS prefetching on Windows 4262 https://bugs.webkit.org/show_bug.cgi?id=41504 4263 <rdar://problem/8151939> 4264 4265 * Interfaces/IWebPreferencesPrivate.idl: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled. 4266 * Interfaces/WebKit.idl: Touched to force IDL build. 4267 * WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey. 4268 * WebPreferences.cpp: 4269 (WebPreferences::initializeDefaultSettings): Default prefetch to true. 4270 (WebPreferences::setDNSPrefetchingEnabled): Added. 4271 (WebPreferences::isDNSPrefetchingEnabled): Added. 4272 * WebPreferences.h: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled. 4273 * WebView.cpp: 4274 (WebView::notifyPreferencesChanged): Propagate prefetch pref into settings. 4275 4276 2010-06-21 Nate Chapin <japhet (a] chromium.org> 4277 4278 Unreviewed, Windows build fix. 4279 4280 Update WebFrame to use FrameLoaderStateMachine in 4281 firstLayoutDone(). 4282 4283 * WebFrame.cpp: 4284 (WebFrame::firstLayoutDone): 4285 4286 2010-06-15 Dumitru Daniliuc <dumi (a] chromium.org> 4287 4288 Reviewed by Adam Barth. 4289 4290 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase. 4291 https://bugs.webkit.org/show_bug.cgi?id=39041 4292 4293 * WebView.cpp: 4294 (WebView::notifyPreferencesChanged): 4295 4296 2010-06-16 Adam Roben <aroben (a] apple.com> 4297 4298 Add a "forPrinting" boolean parameter to 4299 IWebFramePrivate::renderTreeAsExternalRepresentation 4300 4301 Fixes <http://webkit.org/b/40727> Respect 4302 LayoutTestController::isPrinting on Windows. 4303 4304 Reviewed by Dan Bernstein. 4305 4306 * Interfaces/IWebFramePrivate.idl: Renamed the current 4307 renderTreeAsExternalRepresentation to unused1, and added a new version 4308 that takes a boolean "forPrinting" parameter. 4309 4310 * Interfaces/WebKit.idl: Touched to force a build. 4311 4312 * WebFrame.cpp: 4313 (WebFrame::renderTreeAsExternalRepresentation): Added a boolean 4314 "forPrinting" parameter, and used it to tell externalRepresentation 4315 what kind of behavior to use. 4316 4317 * WebFrame.h: Renamed the old renderTreeAsExternalRepresentation and 4318 added the new one. 4319 4320 2010-06-15 Darin Adler <darin (a] apple.com> 4321 4322 Reviewed by Adam Barth. 4323 4324 Move functions out of Frame class that were marked "move to Chrome" 4325 https://bugs.webkit.org/show_bug.cgi?id=39636 4326 4327 * WebView.cpp: 4328 (WebView::shouldClose): Call shouldClose on FrameLoader instead of 4329 going through Frame. 4330 4331 2010-06-14 Adam Roben <aroben (a] apple.com> 4332 4333 Add WebKitLauncherWin to WebKit.sln 4334 4335 Fixes <http://webkit.org/b/40583>. 4336 4337 Reviewed by Darin Adler. 4338 4339 * WebKit.vcproj/WebKit.sln: Added WebKitLauncherWin.vcproj. It depends 4340 on WebKitAPITest, so is the last project to build. (Also removed 4341 QTMovieWin's direct dependency on JavaScriptCore, since it already has 4342 an indirect dependency on it.) 4343 4344 2010-06-14 Chang Shu <chang.shu (a] nokia.com> 4345 4346 Reviewed by Kenneth Rohde Christiansen. 4347 4348 [win] Make windows compile after API changes. 4349 4350 https://bugs.webkit.org/show_bug.cgi?id=40434 4351 4352 * WebKitGraphics.cpp: 4353 (WebDrawText): 4354 4355 2010-06-14 Ilya Tikhonovsky <loislo (a] chromium.org> 4356 4357 Reviewed by Pavel Feldman. 4358 4359 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc 4360 data from inspected page to WebInspector as JSON string via http. The native 4361 serialization to JSON string is supported by InspectorValue's classes. This patch 4362 has the implementation of sendMessageToFrontend function. WebKit version of it still 4363 uses ScriptFunctionCall and will be switched to another transport a little bit later. 4364 https://bugs.webkit.org/show_bug.cgi?id=40134 4365 4366 * WebCoreSupport/WebInspectorClient.cpp: 4367 (WebInspectorClient::WebInspectorClient): 4368 (WebInspectorClient::~WebInspectorClient): 4369 (WebInspectorClient::openInspectorFrontend): 4370 * WebCoreSupport/WebInspectorClient.h: 4371 4372 2010-06-10 Eric Seidel <eric (a] webkit.org> 4373 4374 Reviewed by Adam Barth. 4375 4376 Reduce FrameView.h includes to speed up build times 4377 https://bugs.webkit.org/show_bug.cgi?id=40408 4378 4379 Another fix for Windows. 4380 4381 * WebView.cpp: 4382 4383 2010-06-09 Sheriff Bot <webkit.review.bot (a] gmail.com> 4384 4385 Unreviewed, rolling out r60889. 4386 http://trac.webkit.org/changeset/60889 4387 https://bugs.webkit.org/show_bug.cgi?id=40365 4388 4389 gtk bot has some kind of memory corruption (Requested by 4390 loislo on #webkit). 4391 4392 * WebCoreSupport/WebInspectorClient.cpp: 4393 (WebInspectorClient::WebInspectorClient): 4394 (WebInspectorClient::~WebInspectorClient): 4395 (WebInspectorClient::openInspectorFrontend): 4396 * WebCoreSupport/WebInspectorClient.h: 4397 (WebInspectorClient::frontendClosing): 4398 4399 2010-06-07 Ilya Tikhonovsky <loislo (a] chromium.org> 4400 4401 Reviewed by Pavel Feldman. 4402 4403 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc 4404 data from inspected page to WebInspector as JSON string via http. The native 4405 serialization to JSON string is supported by InspectorValue's classes. This patch 4406 has the implementation of sendMessageToFrontend function. WebKit version of it still 4407 uses ScriptFunctionCall and will be switched to another transport a little bit later. 4408 https://bugs.webkit.org/show_bug.cgi?id=40134 4409 4410 * WebCoreSupport/WebInspectorClient.cpp: 4411 (WebInspectorClient::WebInspectorClient): 4412 (WebInspectorClient::~WebInspectorClient): 4413 (WebInspectorClient::openInspectorFrontend): 4414 * WebCoreSupport/WebInspectorClient.h: 4415 4416 2010-06-08 Antonio Gomes <tonikitoo (a] webkit.org> 4417 4418 Reviewed by Ojan Vafai and Darin Adler. 4419 4420 Refactor platform dependent editing behavior code out of Settings 4421 https://bugs.webkit.org/show_bug.cgi?id=39854 4422 4423 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to 4424 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly. 4425 4426 * WebView.cpp: 4427 (WebView::notifyPreferencesChanged): 4428 4429 2010-06-04 Alice Liu <alice.liu (a] apple.com> 4430 4431 Reviewed by Jon Honeycutt. 4432 4433 WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars 4434 https://bugs.webkit.org/show_bug.cgi?id=40034 4435 <rdar://problem/7799848> 4436 4437 * WebFrame.cpp: 4438 (WebFrame::paintScrollViewRectToContextAtPoint): Renamed from paintDocumentRectToContextAtPoint. 4439 Call paint() instead of paintContents(). Also move the dirtyRect to counteract the moving that happens in paint(). 4440 4441 Just renaming changes: 4442 * Interfaces/IWebFramePrivate.idl: 4443 * Interfaces/IWebViewPrivate.idl: 4444 * WebFrame.h: 4445 * WebView.cpp: 4446 (WebView::paintScrollViewRectToContextAtPoint): 4447 * WebView.h: 4448 4449 * Interfaces/WebKit.idl: Touched for rebuild. 4450 4451 2010-05-30 Daniel Bates <dbates (a] rim.com> 4452 4453 Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418. 4454 4455 * WebFrame.cpp: 4456 (WebFrame::elementWithName): 4457 (WebFrame::controlsInForm): 4458 4459 2010-05-22 Jer Noble <jer.noble (a] apple.com> 4460 4461 Reviewed by Adam Roben. 4462 4463 Full screen doesn't work for video elements 4464 https://bugs.webkit.org/show_bug.cgi?id=39557 4465 rdar://problem/8011813 4466 4467 Modified FullscreenVideoController to work with MediaPlayerPrivateFullscreenWindow. The FullscreenVideoController 4468 is now MediaPlayerPrivate agnostic.. 4469 4470 * FullscreenVideoController.cpp: 4471 (FullscreenVideoController::LayoutClient::LayoutClient): New helper class which implements WKCACFLayerLayoutClient. 4472 (FullscreenVideoController::LayoutClient::layoutSublayersOfLayer): 4473 (FullscreenVideoController::FullscreenVideoController): 4474 (FullscreenVideoController::~FullscreenVideoController): 4475 (FullscreenVideoController::enterFullscreen): 4476 (FullscreenVideoController::exitFullscreen): 4477 (FullscreenVideoController::fullscreenClientWndProc): Handle WM_KEYDOWN. 4478 (FullscreenVideoController::createHUDWindow): 4479 (FullscreenVideoController::hudWndProc): Handle WM_KEYDOWN. 4480 (FullscreenVideoController::onChar): 4481 (FullscreenVideoController::onKeyDown): New function: handles the VK_ESCAPE case more reliably than WM_CHAR. 4482 * FullscreenVideoController.h: 4483 * WebView.h: 4484 (WebView::viewWindow): Added a simple viewWindow() accessor. 4485 4486 2010-05-25 Brady Eidson <beidson (a] apple.com> 4487 4488 Reviewed by Darin Adler. 4489 4490 Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms) 4491 <rdar://problem/8013233> and https://bugs.webkit.org/show_bug.cgi?id=39486 4492 4493 * WebDatabaseManager.cpp: 4494 (WebKitInitializeWebDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on 4495 an already created tracker that already has its origins populated. 4496 * WebDatabaseManager.h: 4497 4498 * WebView.cpp: 4499 (WebView::initWithFrame): Call a renamed method instead. 4500 4501 2010-05-25 Ada Chan <adachan (a] apple.com> 4502 4503 Reviewed by Steve Falkenburg. 4504 4505 https://bugs.webkit.org/show_bug.cgi?id=39651 4506 4507 Make m_closeWindowTimer a SuspendableTimer, so it is properly suspended 4508 when page loading is deferred. 4509 4510 * WebView.cpp: 4511 (WebView::WebView): m_closeWindowTimer is now a pointer to a SuspendableTimer. 4512 (WindowCloseTimer::create): 4513 (WindowCloseTimer::WindowCloseTimer): 4514 (WindowCloseTimer::contextDestroyed): Make sure we delete the WindowCloseTimer in the end. 4515 (WindowCloseTimer::fired): 4516 (WebView::closeWindowSoon): 4517 (WebView::closeWindowTimerFired): 4518 (WebView::notifyPreferencesChanged): Can just check for the existence m_closeWindowTimer, since 4519 we only create it when we need to start the timer. 4520 * WebView.h: 4521 4522 2010-05-24 Darin Adler <darin (a] apple.com> 4523 4524 Reviewed by Eric Seidel. 4525 4526 Move view-related functions from Frame to FrameView 4527 https://bugs.webkit.org/show_bug.cgi?id=39366 4528 4529 * WebFrame.cpp: 4530 (WebFrame::setTextSizeMultiplier): Call function on FrameView. 4531 * WebView.cpp: 4532 (WebView::setZoomMultiplier): Ditto. 4533 4534 2010-05-24 Anders Carlsson <andersca (a] apple.com> 4535 4536 Yet another Windows build fix. 4537 4538 * WebView.cpp: 4539 (WebView::canShowMIMEType): 4540 Use the right capitalizatinon of 'MIME' (which also happens to be incorrect according to our guidelines). 4541 4542 2010-05-24 Anders Carlsson <andersca (a] apple.com> 4543 4544 Another Windows build fix. 4545 4546 * WebView.cpp: 4547 Don't include PlugInInfoStore.h, instead include PluginData.h 4548 4549 2010-05-24 Anders Carlsson <andersca (a] apple.com> 4550 4551 Fix Windows build. 4552 4553 * WebView.cpp: 4554 (WebView::canShowMIMEType): 4555 4556 2010-05-21 Steve Block <steveblock (a] google.com> 4557 4558 Reviewed by Jeremy Orlow. 4559 4560 Add DeviceOrientation and DeviceOrientationClient 4561 https://bugs.webkit.org/show_bug.cgi?id=39479 4562 4563 * WebView.cpp: 4564 (WebView::initWithFrame): 4565 4566 2010-05-20 Simon Fraser <simon.fraser (a] apple.com> 4567 4568 Build fix, no review. 4569 4570 Fix the non-accelerated-compositing Windows build with some 4571 #if USE(ACCELERATED_COMPOSITING) loving. 4572 4573 * WebView.cpp: 4574 * WebView.h: 4575 4576 2010-05-20 Simon Fraser <simon.fraser (a] apple.com> 4577 4578 Reviewed by Adam Roben. 4579 4580 Avoid flushing CA layers when a layout is pending 4581 https://bugs.webkit.org/show_bug.cgi?id=39463 4582 4583 <rdar://problem/7999463> 4584 4585 Avoid rendering the compositing layers to the screen if there's a layout pending, 4586 since the layer tree not in a state that should be presented to the user. 4587 4588 This fixes flashes in some types of content that dynamically add and remove layers. 4589 4590 Have the WebView implement WKCACFLayerRendererClient so that the 4591 WKCACFLayerRenderer can ask whether it's a good time to render. If the FrameView 4592 has a layout pending, say no. 4593 4594 * WebView.h: 4595 * WebView.cpp: 4596 (WebView::setAcceleratedCompositing): 4597 (WebView::shouldRender): 4598 4599 2010-05-18 Brent Fulgham <bfulgham (a] webkit.org> 4600 4601 Reviewed by Adam Roben. 4602 4603 [WinCairo] Correct scaling for print preview 4604 https://bugs.webkit.org/show_bug.cgi?id=39329 4605 4606 Cairo does not properly deal with Windows HDCs that have been 4607 scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and 4608 ViewportExt setting. 4609 (see http://bugs.freedesktop.org/show_bug.cgi?id=28161) 4610 4611 Instead, reset the HDC's WorldTransform to be unscaled, then 4612 scale the cairo context to the desired scaling, and perform 4613 the drawing operation. 4614 4615 * WebFrame.cpp: 4616 (WebFrame::drawHeader): Use pre-positioned context to simplify 4617 this method. 4618 (WebFrame::drawFooter): Use pre-positioned context to simplify 4619 this method. 4620 (WebFrame::spoolPage): Revise scaling logic to turn off HDC 4621 scaling, and scale using only Cairo. Revert scaling at end 4622 so that user-defined GDI-based routines (e.g., header/footer) 4623 will draw in the right position. 4624 (WebFrame::spoolPages): Identify print preview case, and 4625 retrieve scaling factors from preview context. Set the 4626 Cairo context to use these factors during the spoolPage 4627 operation. 4628 4629 2010-05-20 Martin Robinson <mrobinson (a] igalia.com> 4630 4631 Unreviewed. 4632 4633 Touch WebKit.idl to ensure that interfaces rebuild. 4634 4635 * Interfaces/WebKit.idl: Touched. 4636 4637 2010-05-20 Martin Robinson <mrobinson (a] igalia.com> 4638 4639 Reviewed by Adam Roben. 4640 4641 Fix the Windows build and move new IDL declarations to the bottom of the file. 4642 4643 * Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch. 4644 * WebPreferences.cpp: 4645 (WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type. 4646 4647 2010-05-20 Martin Robinson <mrobinson (a] igalia.com> 4648 4649 Unreviewed. 4650 4651 Fix the Windows build. 4652 4653 * WebView.cpp: 4654 (WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'. 4655 4656 2010-05-20 Martin Robinson <mrobinson (a] webkit.org> 4657 4658 Reviewed by Ojan Vafai. 4659 4660 Expose the editing behavior setting in DRT to test all editing code paths 4661 https://bugs.webkit.org/show_bug.cgi?id=38603 4662 4663 Expose the EditingBehavior setting in the Windows API. 4664 4665 * Interfaces/IWebPreferences.idl: Add the API point for setting the editing behavior. 4666 * WebPreferenceKeysPrivate.h: Add a key for the editing behavior setting. 4667 * WebPreferences.cpp: 4668 (WebPreferences::editingBehavior): Added. 4669 (WebPreferences::setEditingBehavior): Added. 4670 * WebPreferences.h: Add method declarations. 4671 * WebView.cpp: 4672 (WebView::notifyPreferencesChanged): Update the WebCore setting based on the WebPreferences setting. 4673 4674 2010-05-20 Chris Jerdonek <cjerdonek (a] webkit.org> 4675 4676 Reviewed by Eric Seidel. 4677 4678 Modified FrameLoader::urlSelected() to accept a KURL instead of a 4679 ResourceRequest. 4680 4681 https://bugs.webkit.org/show_bug.cgi?id=39320 4682 4683 Since ResourceRequest has non-explicit single-parameter constructors for 4684 String and KURL, urlSelected() previously accepted any of String, KURL, 4685 and ResourceRequest. This revision changes urlSelected() to accept only 4686 a KURL to make the API tighter and easier to refactor. 4687 4688 * WebCoreSupport/WebContextMenuClient.cpp: 4689 (WebContextMenuClient::searchWithGoogle): 4690 - Updated the call to urlSelected(). 4691 4692 2010-05-13 Brian Weinstein <bweinstein (a] apple.com> 4693 4694 Reviewed by Tim Hatcher. 4695 4696 <rdar://problem/7982652> 4697 4698 Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector. 4699 4700 * Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate. 4701 * Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild. 4702 * WebView.cpp: 4703 (WebView::reportException): Make sure the function was called with a context from a WebView, and call 4704 WebCore::reportException. 4705 * WebView.h: 4706 4707 2010-05-12 Jer Noble <jer.noble (a] apple.com> 4708 4709 Reviewed by Darin Adler. 4710 4711 Bug 38689: #34005 will break fullscreen video playback 4712 https://bugs.webkit.org/show_bug.cgi?id=38689 4713 4714 Use the new definition of PlatformMedia to check the actual type 4715 returned by MediaPlayer. 4716 4717 * FullscreenVideoController.cpp: 4718 (FullscreenVideoController::movie): 4719 4720 2010-05-11 Jer Noble <jer.noble (a] apple.com> 4721 4722 No Review. 4723 4724 Fix build error: The QTMovieWin project is dependent on the JavaScriptCore project. 4725 4726 * WebKit.vcproj/WebKit.sln: 4727 4728 2010-05-11 Alice Liu <alice.liu (a] apple.com> 4729 4730 Rubber-stamped by Gavin Barraclough. 4731 4732 Fix build error when enabling debugging block in WebKit win painting code 4733 4734 * WebView.cpp: 4735 (WebView::paintIntoBackingStore): 4736 4737 2010-05-11 Alice Liu <alice.liu (a] apple.com> 4738 4739 Reviewed by Steve Falkenburg. 4740 4741 https://bugs.webkit.org/show_bug.cgi?id=38937 4742 W7 window preview paints content at the wrong location 4743 4744 * WebFrame.cpp: 4745 (WebFrame::paintDocumentRectToContext): Revert r58895 4746 (WebFrame::paintDocumentRectToContextAtPoint): Added 4747 4748 * Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint 4749 * Interfaces/IWebViewPrivate.idl: ditto 4750 * Interfaces/WebKit.idl: touch to rebuild 4751 * WebFrame.h: ditto 4752 * WebView.cpp: ditto 4753 (WebView::paintDocumentRectToContextAtPoint): ditto 4754 * WebView.h: ditto 4755 4756 2010-05-07 Jer Noble <jer.noble (a] apple.com> 4757 4758 Reviewed by Adele Peterson. 4759 4760 Safari pegs CPU and drops tons of frames using HTML5 Vimeo player 4761 https://bugs.webkit.org/show_bug.cgi?id=34005 4762 4763 QTMovieWin is now QTMovieGWorld. 4764 * FullscreenVideoController.cpp: 4765 (FullscreenVideoController::movie): 4766 * FullscreenVideoController.h: 4767 4768 2010-05-06 Adam Roben <aroben (a] apple.com> 4769 4770 Bail out of WebView::paint when there's nothing to paint 4771 4772 Fixes <http://webkit.org/b/38670> <rdar://problem/7947105> REGRESSION 4773 (r58067): Crash in WebView::paint when Web Inspector is docked and 4774 window is resized so small that WebView disappears 4775 4776 When the WebView is 0-sized, ensureBackingStore() bails out without 4777 creating a bitmap, leaving m_backingStoreBitmap null. Before r58067, 4778 m_backingStoreBitmap was an HBITMAP, so we were happily passing along 4779 a null HBITMAP to various Windows APIs. These calls would fail but not 4780 crash. r58067 changed m_backingStoreBitmap to a RefCountedHBITMAP, and 4781 dereferencing a null RefCountedHBITMAP* of course crashes. 4782 4783 Reviewed by Steve Falkenburg. 4784 4785 * WebView.cpp: 4786 (WebView::paint): Bail if the rect to paint is empty. 4787 4788 2010-05-06 Steve Falkenburg <sfalken (a] apple.com> 4789 4790 Reviewed by Adam Roben. 4791 4792 WebFrame::paintDocumentRectToContext paints content at the wrong location 4793 https://bugs.webkit.org/show_bug.cgi?id=38651 4794 4795 * WebFrame.cpp: 4796 (WebFrame::paintDocumentRectToContext): 4797 4798 2010-05-05 Stuart Morgan <stuartmorgan (a] chromium.org> 4799 4800 Reviewed by Darin Fisher. 4801 4802 Update setFocus for the new boolean argument; no behavioral change. 4803 4804 https://bugs.webkit.org/show_bug.cgi?id=37961 4805 4806 * WebCoreSupport/EmbeddedWidget.cpp: 4807 (EmbeddedWidget::setFocus): 4808 * WebCoreSupport/EmbeddedWidget.h: 4809 4810 2010-05-03 Abhishek Arya <inferno (a] chromium.org> 4811 4812 Reviewed by Adam Barth. 4813 4814 Add support for controlling clipboard access from javascript. 4815 Clipboard access from javascript is disabled by default. 4816 https://bugs.webkit.org/show_bug.cgi?id=27751 4817 4818 * Interfaces/IWebPreferencesPrivate.idl: 4819 * WebPreferenceKeysPrivate.h: 4820 * WebPreferences.cpp: 4821 (WebPreferences::initializeDefaultSettings): 4822 (WebPreferences::javaScriptCanAccessClipboard): 4823 (WebPreferences::setJavaScriptCanAccessClipboard): 4824 * WebPreferences.h: 4825 * WebView.cpp: 4826 (WebView::notifyPreferencesChanged): 4827 4828 2010-05-03 Jens Alfke <snej (a] chromium.org> 4829 4830 Reviewed by Darin Fisher. 4831 4832 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient 4833 https://bugs.webkit.org/show_bug.cgi?id=38397 4834 4835 No tests (functionality is exposed only through native WebKit API.) 4836 4837 * WebFrame.h: 4838 4839 2010-04-30 Jon Honeycutt <jhoneycutt (a] apple.com> 4840 4841 Caret may fail to blink if a focus handler brings up a modal dialog 4842 https://bugs.webkit.org/show_bug.cgi?id=38372 4843 4844 Reviewed by Darin Adler. 4845 4846 * WebView.cpp: 4847 (WebView::handleMouseEvent): 4848 If the message is WM_CANCELMODE, which indicates that we our capturing 4849 of mouse events has been cancelled, tell the EventHandler. 4850 It's possible to re-enter this function if handling a mouse event allows 4851 the message loop to run; moved up the call to setMouseActivated(), so 4852 that if we do re-enter this function, the later mouse event will not be 4853 considered as activating the window. 4854 (WebView::WebViewWndProc): 4855 Handle WM_CANCELMODE by calling handleMouseEvent(). 4856 4857 2010-04-29 Anders Carlsson <andersca (a] apple.com> 4858 4859 Reviewed by Dan Bernstein. 4860 4861 First part of 4862 https://bugs.webkit.org/show_bug.cgi?id=20784 4863 move npapi.h to C99 integer types. 4864 4865 * WebKit.vcproj/WebKit.vcproj: 4866 4867 2010-04-28 Beth Dakin <bdakin (a] apple.com> 4868 4869 Reviewed by Darin Adler. 4870 4871 Fix for <rdar://problem/7474349> 4872 4873 Add a synchronous display mechanism for WKCACFLayerRenderer. 4874 4875 * Interfaces/IWebViewPrivate.idl: 4876 * Interfaces/WebKit.idl: 4877 * WebView.cpp: 4878 (WebView::WebView): 4879 (WebView::updateRootLayerContents): 4880 (WebView::nextDisplayIsSynchronous): 4881 * WebView.h: 4882 4883 2010-04-28 Steve Falkenburg <sfalken (a] apple.com> 4884 4885 Reviewed by Maciej Stachowiak. 4886 4887 WebView drawing code may access null backing store dirty region 4888 https://bugs.webkit.org/show_bug.cgi?id=38245 4889 <rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent) 4890 4891 * WebView.cpp: 4892 (WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion. 4893 4894 2010-04-27 Jon Honeycutt <jhoneycutt (a] apple.com> 4895 4896 <rdar://problem/7911140> Hitting the "delete" key goes back twice 4897 4898 Reviewed by Maciej Stachowiak. 4899 4900 * WebView.cpp: 4901 (WebView::keyDown): 4902 Return true if we navigated back or forward from the key event to 4903 prevent the event from being propagated further. 4904 4905 2010-04-25 Sam Weinig <sam (a] webkit.org> 4906 4907 Reviewed by Maciej Stachowiak. 4908 4909 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097 4910 Disentangle initializing the main thread from initializing threading 4911 4912 * WebKitClassFactory.cpp: 4913 (WebKitClassFactory::WebKitClassFactory): Add call to initializeMainThread. 4914 * WebView.cpp: 4915 (WebView::WebView): Ditto. 4916 4917 2010-04-25 Yury Semikhatsky <yurys (a] chromium.org> 4918 4919 Reviewed by Pavel Feldman. 4920 4921 Web Inspector: inspector client shouldn't check if it can be opened 4922 docked if it is already in that state. 4923 4924 https://bugs.webkit.org/show_bug.cgi?id=37946 4925 4926 * WebCoreSupport/WebInspectorClient.cpp: 4927 (WebInspectorFrontendClient::WebInspectorFrontendClient): 4928 (WebInspectorFrontendClient::showWindowWithoutNotifications): 4929 * WebCoreSupport/WebInspectorClient.h: 4930 4931 2010-04-24 Steve Falkenburg <sfalken (a] apple.com> 4932 4933 Reviewed by Sam Weinig. 4934 4935 Typo in Geolocation code causes crashes when updates are stopped 4936 https://bugs.webkit.org/show_bug.cgi?id=38089 4937 <rdar://problem/7904104> Crash closing geolocation tab after allowing to use geolocation 4938 4939 * WebCoreSupport/WebGeolocationControllerClient.cpp: 4940 (WebGeolocationControllerClient::stopUpdating): Call unregister instead of register. 4941 4942 2010-04-23 Andy Estes <aestes (a] apple.com> 4943 4944 Rubber stamped by Steve Falkenburg. 4945 4946 Roll out http://trac.webkit.org/changeset/55385. 4947 4948 <rdar://problem/7884444> 4949 4950 * Interfaces/IWebUIDelegatePrivate.idl: 4951 * Interfaces/WebKit.idl: 4952 * WebCoreSupport/WebFrameLoaderClient.cpp: 4953 (WebFrameLoaderClient::createPlugin): 4954 4955 2010-04-22 Dave Moore <davemoore (a] chromium.org> 4956 4957 Reviewed by Dimitri Glazkov. 4958 4959 Added notification when the favicons for a page are changed 4960 from a script. 4961 The Document object will notify the frame loader, which will 4962 notify the client. Implementations of FrameLoaderClient will 4963 have to add one method; dispatchDidChangeIcons(). 4964 4965 https://bugs.webkit.org/show_bug.cgi?id=33812 4966 4967 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: 4968 * WebCoreSupport/WebFrameLoaderClient.cpp: 4969 (WebFrameLoaderClient::dispatchDidChangeIcons): 4970 * WebCoreSupport/WebFrameLoaderClient.h: 4971 * WebFrame.cpp: 4972 (WebFrame::didChangeIcons): 4973 * WebFrame.h: 4974 4975 2010-04-22 Adam Barth <abarth (a] webkit.org> 4976 4977 Unreviewed, rolling out r58069. 4978 http://trac.webkit.org/changeset/58069 4979 https://bugs.webkit.org/show_bug.cgi?id=27751 4980 4981 Broke compile on Windows. 4982 4983 * Interfaces/IWebPreferencesPrivate.idl: 4984 * WebPreferenceKeysPrivate.h: 4985 * WebPreferences.cpp: 4986 (WebPreferences::initializeDefaultSettings): 4987 * WebPreferences.h: 4988 * WebView.cpp: 4989 (WebView::notifyPreferencesChanged): 4990 4991 2010-04-22 Abhishek Arya <inferno (a] chromium.org> 4992 4993 Reviewed by Adam Barth. 4994 4995 Add support for controlling clipboard access from javascript. 4996 Clipboard access from javascript is disabled by default. 4997 https://bugs.webkit.org/show_bug.cgi?id=27751 4998 4999 * Interfaces/IWebPreferencesPrivate.idl: 5000 * WebPreferenceKeysPrivate.h: 5001 * WebPreferences.cpp: 5002 (WebPreferences::initializeDefaultSettings): 5003 (WebPreferences::javaScriptCanAccessClipboard): 5004 (WebPreferences::setJavaScriptCanAccessClipboard): 5005 * WebPreferences.h: 5006 * WebView.cpp: 5007 (WebView::notifyPreferencesChanged): 5008 5009 2010-04-21 Andy Estes <aestes (a] apple.com> 5010 5011 Reviewed by Maciej Stachowiak. 5012 5013 Reference count WebView's backing store bitmap to prevent 5014 deleteBackingStore() from freeing the bitmap while it is still being 5015 referenced by Core Animation. 5016 5017 https://bugs.webkit.org/show_bug.cgi?id=37954 5018 5019 * WebView.cpp: 5020 (WebView::ensureBackingStore): 5021 (WebView::addToDirtyRegion): 5022 (WebView::scrollBackingStore): 5023 (WebView::updateBackingStore): 5024 (WebView::paint): 5025 (WebView::backingStore): 5026 (releaseBackingStoreCallback): deref m_backingStoreBitmap once Core 5027 Animation has dropeed its reference to the memory. 5028 (WebView::updateRootLayerContents): ref m_backingStoreBitmap before 5029 passing the memory to Core Animation to prevent deleteBackingStore() 5030 from freeing it while it is still referenced by CA. 5031 * WebView.h: Make m_backingStoreBitmap a RefCountedGDIHandle<HBITMAP>, 5032 and make m_backingStoreDirtyRegion a RefCountedGDIHandle<HRGN>. 5033 5034 2010-04-20 Adam Barth <abarth (a] webkit.org> 5035 5036 Reviewed by Eric Seidel. 5037 5038 Factor DocumentWriter out of FrameLoader 5039 https://bugs.webkit.org/show_bug.cgi?id=37175 5040 5041 Update these callsites because the method moved to DocumentWriter. 5042 5043 * WebCoreSupport/WebFrameLoaderClient.cpp: 5044 (WebFrameLoaderClient::receivedData): 5045 5046 2010-04-20 Kent Tamura <tkent (a] chromium.org> 5047 5048 Reviewed by Darin Adler. 5049 5050 Change a parameter type of chooseIconForFiles() 5051 https://bugs.webkit.org/show_bug.cgi?id=37504 5052 5053 * WebCoreSupport/WebChromeClient.cpp: 5054 (WebChromeClient::chooseIconForFiles): 5055 * WebCoreSupport/WebChromeClient.h: 5056 5057 2010-04-16 Gavin Barraclough <barraclough (a] apple.com> 5058 5059 Reviewed by NOBODY (Windows build fix). 5060 5061 * WebFrame.cpp: 5062 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): 5063 * WebView.cpp: 5064 (WebView::stringByEvaluatingJavaScriptFromString): 5065 5066 2010-04-16 Adam Roben <aroben (a] apple.com> 5067 5068 Make it possible for clients to instantiate a WebUserContentURLPattern 5069 5070 Reviewed by Tim Hatcher. 5071 5072 * ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which 5073 lists all our instantiatable classes. 5074 5075 * WebKitClassFactory.cpp: Added a now-required #include. 5076 5077 2010-04-15 Adam Roben <aroben (a] apple.com> 5078 5079 Expose UserContentURLPattern as WebKit SPI 5080 5081 Fixes <http://webkit.org/b/37354>. 5082 5083 Reviewed by Tim Hatcher. 5084 5085 * Interfaces/IWebUserContentURLPattern.idl: Added. 5086 5087 * Interfaces/WebKit.idl: Added WebUserContentURLPattern. 5088 5089 * WebKit.vcproj/Interfaces.vcproj: Added IWebUserContentURLPattern. 5090 5091 * WebKit.vcproj/WebKit.vcproj: Added WebUserContentURLPattern. 5092 5093 * WebUserContentURLPattern.cpp: Added. 5094 (WebUserContentURLPattern::WebUserContentURLPattern): 5095 (WebUserContentURLPattern::~WebUserContentURLPattern): 5096 (WebUserContentURLPattern::createInstance): 5097 (WebUserContentURLPattern::AddRef): 5098 (WebUserContentURLPattern::Release): 5099 (WebUserContentURLPattern::QueryInterface): 5100 Standard COM implementations. 5101 5102 (WebUserContentURLPattern::parse): Parse the string into a 5103 UserContentURLPattern and store it. 5104 5105 (WebUserContentURLPattern::isValid): 5106 (WebUserContentURLPattern::scheme): 5107 (WebUserContentURLPattern::host): 5108 (WebUserContentURLPattern::matchesSubdomains): 5109 Call through to UserContentURLPattern. 5110 5111 * WebUserContentURLPattern.h: Added. 5112 5113 2010-04-14 Adam Roben <aroben (a] apple.com> 5114 5115 Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows 5116 5117 Fixes <http://webkit.org/b/37619>. 5118 5119 Reviewed by Steve Falkenburg. 5120 5121 * Interfaces/IWebScriptWorld.idl: Added unregisterWorld. 5122 5123 * Interfaces/WebKit.idl: Touched to force a build. 5124 5125 * WebScriptWorld.cpp: 5126 (WebScriptWorld::unregisterWorld): 5127 * WebScriptWorld.h: 5128 Added. Just calls through to DOMWrapperWorld::unregisterWorld. 5129 5130 2010-04-12 Timothy Hatcher <timothy (a] apple.com> 5131 5132 SecurityOrigin needs a way to remove individual OriginAccessEntries 5133 https://bugs.webkit.org/show_bug.cgi?id=37449 5134 5135 Reviewed by Dave Hyatt. 5136 5137 * Interfaces/IWebViewPrivate.idl: 5138 * WebView.cpp: 5139 (WebView::removeOriginAccessWhitelistEntry): Call SecurityOrigin::removeOriginAccessWhitelistEntry. 5140 * WebView.h: Added removeOriginAccessWhitelistEntry. 5141 5142 2010-04-13 Timothy Hatcher <timothy (a] apple.com> 5143 5144 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry. 5145 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists. 5146 5147 SecurityOrigin needs a way to remove individual OriginAccessEntries 5148 https://bugs.webkit.org/show_bug.cgi?id=37449 5149 5150 Reviewed by Dave Hyatt. 5151 5152 * Interfaces/IWebViewPrivate.idl: 5153 * WebView.cpp: 5154 (WebView::addOriginAccessWhitelistEntry): 5155 (WebView::resetOriginAccessWhitelists): 5156 * WebView.h: 5157 5158 2010-04-11 Sheriff Bot <webkit.review.bot (a] gmail.com> 5159 5160 Unreviewed, rolling out r57468. 5161 http://trac.webkit.org/changeset/57468 5162 https://bugs.webkit.org/show_bug.cgi?id=37433 5163 5164 Broke the world... Must have applied the patch wrong 5165 (Requested by abarth on #webkit). 5166 5167 * WebCoreSupport/WebFrameLoaderClient.cpp: 5168 (WebFrameLoaderClient::receivedData): 5169 5170 2010-04-11 Adam Barth <abarth (a] webkit.org> 5171 5172 Reviewed by Eric Seidel. 5173 5174 Factor DocumentWriter out of FrameLoader 5175 https://bugs.webkit.org/show_bug.cgi?id=37175 5176 5177 Update these callsites because the method moved to DocumentWriter. 5178 5179 * WebCoreSupport/WebFrameLoaderClient.cpp: 5180 (WebFrameLoaderClient::receivedData): 5181 5182 2010-04-09 Adam Roben <aroben (a] apple.com> 5183 5184 Windows Debug/Release build fix after r57244 5185 5186 * WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or 5187 QuartzCoreInterface.dll in any configurations. r57244 made this change 5188 only for Debug_Internal. 5189 5190 2010-04-08 Steve Falkenburg <sfalken (a] apple.com> 5191 5192 Reviewed by Darin Adler. 5193 5194 WebView::isLoading should null check m_mainFrame 5195 https://bugs.webkit.org/show_bug.cgi?id=37294 5196 5197 * WebView.cpp: 5198 (WebView::isLoading): 5199 5200 2010-04-07 Chris Marrin <cmarrin (a] apple.com> 5201 5202 Reviewed by Steve Falkenburg. 5203 5204 Remove QuartzCoreInterface from the build 5205 5206 No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5). 5207 5208 * WebKit.vcproj/WebKit.vcproj:Removed delay load for QuartzCore and QuartzCoreInterface 5209 5210 2010-04-07 Andrey Kosyakov <caseq (a] chromium.org> 5211 5212 Reviewed by Yury Semikhatsky. 5213 5214 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest() 5215 https://bugs.webkit.org/show_bug.cgi?id=36949 5216 5217 * WebCoreSupport/WebFrameLoaderClient.cpp: 5218 * WebCoreSupport/WebFrameLoaderClient.h: 5219 5220 2010-04-05 Peter Nelson <charn.opcode (a] gmail.com> 5221 5222 Reviewed by Eric Seidel. 5223 5224 Fixed style errors in DOMCoreClasses.h to bring it up to scratch 5225 for https://bugs.webkit.org/show_bug.cgi?id=34979. 5226 5227 * DOMCoreClasses.h: 5228 (DOMObject::throwException): 5229 (DOMObject::callWebScriptMethod): 5230 (DOMObject::evaluateWebScript): 5231 (DOMObject::removeWebScriptKey): 5232 (DOMObject::stringRepresentation): 5233 (DOMObject::webScriptValueAtIndex): 5234 (DOMObject::setWebScriptValueAtIndex): 5235 (DOMObject::setException): 5236 (DOMNodeList::throwException): 5237 (DOMNodeList::callWebScriptMethod): 5238 (DOMNodeList::evaluateWebScript): 5239 (DOMNodeList::removeWebScriptKey): 5240 (DOMNodeList::stringRepresentation): 5241 (DOMNodeList::webScriptValueAtIndex): 5242 (DOMNodeList::setWebScriptValueAtIndex): 5243 (DOMNodeList::setException): 5244 (DOMDocument::throwException): 5245 (DOMDocument::callWebScriptMethod): 5246 (DOMDocument::evaluateWebScript): 5247 (DOMDocument::removeWebScriptKey): 5248 (DOMDocument::stringRepresentation): 5249 (DOMDocument::webScriptValueAtIndex): 5250 (DOMDocument::setWebScriptValueAtIndex): 5251 (DOMDocument::setException): 5252 (DOMDocument::nodeName): 5253 (DOMDocument::nodeValue): 5254 (DOMDocument::setNodeValue): 5255 (DOMDocument::nodeType): 5256 (DOMDocument::parentNode): 5257 (DOMDocument::childNodes): 5258 (DOMDocument::firstChild): 5259 (DOMDocument::lastChild): 5260 (DOMDocument::previousSibling): 5261 (DOMDocument::nextSibling): 5262 (DOMDocument::attributes): 5263 (DOMDocument::ownerDocument): 5264 (DOMDocument::insertBefore): 5265 (DOMDocument::replaceChild): 5266 (DOMDocument::removeChild): 5267 (DOMDocument::appendChild): 5268 (DOMDocument::hasChildNodes): 5269 (DOMDocument::cloneNode): 5270 (DOMDocument::isSupported): 5271 (DOMDocument::namespaceURI): 5272 (DOMDocument::prefix): 5273 (DOMDocument::setPrefix): 5274 (DOMDocument::localName): 5275 (DOMDocument::hasAttributes): 5276 (DOMDocument::isSameNode): 5277 (DOMDocument::isEqualNode): 5278 (DOMDocument::textContent): 5279 (DOMDocument::setTextContent): 5280 (DOMElement::throwException): 5281 (DOMElement::callWebScriptMethod): 5282 (DOMElement::evaluateWebScript): 5283 (DOMElement::removeWebScriptKey): 5284 (DOMElement::stringRepresentation): 5285 (DOMElement::webScriptValueAtIndex): 5286 (DOMElement::setWebScriptValueAtIndex): 5287 (DOMElement::setException): 5288 (DOMElement::nodeName): 5289 (DOMElement::nodeValue): 5290 (DOMElement::setNodeValue): 5291 (DOMElement::nodeType): 5292 (DOMElement::parentNode): 5293 (DOMElement::childNodes): 5294 (DOMElement::firstChild): 5295 (DOMElement::lastChild): 5296 (DOMElement::previousSibling): 5297 (DOMElement::nextSibling): 5298 (DOMElement::attributes): 5299 (DOMElement::ownerDocument): 5300 (DOMElement::insertBefore): 5301 (DOMElement::replaceChild): 5302 (DOMElement::removeChild): 5303 (DOMElement::appendChild): 5304 (DOMElement::hasChildNodes): 5305 (DOMElement::cloneNode): 5306 (DOMElement::isSupported): 5307 (DOMElement::namespaceURI): 5308 (DOMElement::prefix): 5309 (DOMElement::setPrefix): 5310 (DOMElement::localName): 5311 (DOMElement::hasAttributes): 5312 (DOMElement::isSameNode): 5313 (DOMElement::isEqualNode): 5314 (DOMElement::textContent): 5315 (DOMElement::setTextContent): 5316 5317 2010-04-05 Alexey Proskuryakov <ap (a] apple.com> 5318 5319 Reviewed by Darin Adler. 5320 5321 https://bugs.webkit.org/show_bug.cgi?id=37111 5322 <rdar://problem/7790327> Draw replacement text when plug-in host crashes 5323 5324 * WebCoreLocalizedStrings.cpp: (WebCore::crashedPluginText): Added a stub string for plug-in 5325 failure. 5326 5327 2010-04-02 Rafael Weinstein <rafaelw (a] chromium.org> 5328 5329 Reviewed by Adam Barth. 5330 5331 Clean up unused calls after changes to checkPermission and requestPermission argument lists. 5332 5333 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: 5334 (WebDesktopNotificationsDelegate::requestPermission): 5335 * WebCoreSupport/WebDesktopNotificationsDelegate.h: 5336 5337 2010-04-01 Chris Marrin <cmarrin (a] apple.com> 5338 5339 Reviewed by Simon Fraser. 5340 5341 Added layerTreeAsText function to DRT (for Mac) 5342 https://bugs.webkit.org/show_bug.cgi?id=36782 5343 5344 This is the WebKit side for Windows. It plumbs the 5345 call from WebCore to DRT. 5346 5347 * Interfaces/IWebFramePrivate.idl: 5348 * WebFrame.cpp:WebKit (Windows) side of plumbing 5349 (WebFrame::layerTreeAsText): 5350 * WebFrame.h: 5351 5352 2010-03-31 Marcus Bulach <bulach (a] chromium.org> 5353 5354 Reviewed by Jeremy Orlow. 5355 5356 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame. 5357 https://bugs.webkit.org/show_bug.cgi?id=35031 5358 5359 * WebCoreSupport/WebChromeClient.h: 5360 (WebChromeClient::cancelGeolocationPermissionRequestForFrame): 5361 5362 2010-03-30 Gavin Barraclough <barraclough (a] apple.com> 5363 5364 Rubber stamped by Sam Weinig. 5365 5366 https://bugs.webkit.org/show_bug.cgi?id=36866 5367 Move CString to WTF 5368 5369 * WebDownload.cpp: 5370 * WebDownloadCFNet.cpp: 5371 * WebDownloadCurl.cpp: 5372 * WebHistoryItem.cpp: 5373 * WebLocalizableStrings.cpp: 5374 * WebMutableURLRequest.cpp: 5375 * WebPreferences.cpp: 5376 (WebPreferences::migrateWebKitPreferencesToCFPreferences): 5377 * WebView.cpp: 5378 5379 2010-03-30 Adam Roben <aroben (a] apple.com> 5380 5381 Windows build fix 5382 5383 * Interfaces/WebKit.idl: Touched this to force a build. 5384 5385 2010-03-29 Steve Falkenburg <sfalken (a] apple.com> 5386 5387 Reviewed by Adele Peterson. 5388 5389 Default value of accelerated compositing should be false for Windows 5390 https://bugs.webkit.org/show_bug.cgi?id=36805 5391 5392 * WebPreferences.cpp: 5393 (WebPreferences::initializeDefaultSettings): 5394 5395 2010-03-29 Rafael Weinstein <rafaelw (a] chromium.org> 5396 5397 Reviewed by Adam Barth. 5398 5399 Change NotificationPresenter::checkPermission() to take the source frames full KURL, 5400 rather than its SecurityOrigin. This will aid chromium in having more fine grained 5401 permissions to control notification spam. 5402 5403 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: 5404 (WebDesktopNotificationsDelegate::checkPermission): 5405 * WebCoreSupport/WebDesktopNotificationsDelegate.h: 5406 5407 2010-03-26 Kenneth Rohde Christiansen <kenneth (a] webkit.org> 5408 5409 Reviewed by Antti Koivisto. 5410 5411 Change method name due to it dealing with both flattening 5412 of frame sets and inner frames. 5413 5414 * Interfaces/IWebPreferencesPrivate.idl: 5415 * WebPreferenceKeysPrivate.h: 5416 * WebPreferences.cpp: 5417 (WebPreferences::initializeDefaultSettings): 5418 (WebPreferences::isFrameFlatteningEnabled): 5419 (WebPreferences::setFrameFlatteningEnabled): 5420 * WebPreferences.h: 5421 * WebView.cpp: 5422 (WebView::notifyPreferencesChanged): 5423 5424 2010-03-24 Jon Honeycutt <jhoneycutt (a] apple.com> 5425 5426 <rdar://problem/7780798> Missing plug-ins should be represented by text 5427 only, instead of lego block 5428 5429 https://bugs.webkit.org/show_bug.cgi?id=36583 5430 5431 Reviewed by Dan Bernstein. 5432 5433 * WebCoreSupport/WebFrameLoaderClient.cpp: 5434 (WebFrameLoaderClient::createPlugin): 5435 Return 0 if we failed to initialize the plug-in, which causes the new 5436 "missing plug-in" text to draw. 5437 5438 2010-03-24 Kent Tamura <tkent (a] chromium.org> 5439 5440 Reviewed by Darin Adler. 5441 5442 Make Icon::createIconForFiles() optional. 5443 https://bugs.webkit.org/show_bug.cgi?id=35072 5444 5445 - Rename iconForFiles() to chooseIconForFiles(). 5446 - Call Icon::createIconForFiles() from chooseIconForFiles(). 5447 5448 * WebCoreSupport/WebChromeClient.cpp: 5449 (WebChromeClient::chooseIconForFiles): 5450 * WebCoreSupport/WebChromeClient.h: 5451 5452 2010-03-22 Darin Adler <darin (a] apple.com> 5453 5454 * WebCoreLocalizedStrings.cpp: 5455 (WebCore::missingPluginText): Fixed localization helper text to match the same 5456 string from Mac WebKit. 5457 5458 2010-03-22 Kevin Decker <kdecker (a] apple.com> 5459 5460 Reviewed by John Sullivan. 5461 5462 https://bugs.webkit.org/show_bug.cgi?id=36328 5463 5464 * WebCoreLocalizedStrings.cpp: 5465 (WebCore::missingPluginText): Added. 5466 5467 2010-03-17 Enrica Casucci <enrica (a] apple.com> 5468 5469 Reviewed by Darin Adler. 5470 5471 Missing support for showing compositing layers borders and repaint count on Windows. 5472 <rdar://problem/7760736> 5473 <https://bugs.webkit.org/show_bug.cgi?id=36197> 5474 5475 * Interfaces/IWebPreferencesPrivate.idl: 5476 * WebPreferenceKeysPrivate.h: 5477 * WebPreferences.cpp: 5478 (WebPreferences::initializeDefaultSettings): 5479 (WebPreferences::showDebugBorders): 5480 (WebPreferences::setShowDebugBorders): 5481 (WebPreferences::showRepaintCounter): 5482 (WebPreferences::setShowRepaintCounter): 5483 * WebPreferences.h: 5484 * WebView.cpp: 5485 (WebView::notifyPreferencesChanged): 5486 5487 2010-03-16 Yury Semikhatsky <yurys (a] chromium.org> 5488 5489 Reviewed by Pavel Feldman. 5490 5491 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost. 5492 5493 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder 5494 https://bugs.webkit.org/show_bug.cgi?id=35036 5495 5496 * WebCoreSupport/WebInspectorClient.cpp: 5497 (WebInspectorClient::WebInspectorClient): 5498 (WebInspectorClient::~WebInspectorClient): 5499 (WebInspectorClient::openInspectorFrontend): 5500 (WebInspectorClient::highlight): 5501 (WebInspectorClient::hideHighlight): 5502 (WebInspectorClient::updateHighlight): 5503 (WebInspectorFrontendClient::WebInspectorFrontendClient): 5504 (WebInspectorFrontendClient::~WebInspectorFrontendClient): 5505 (WebInspectorFrontendClient::frontendLoaded): 5506 (WebInspectorFrontendClient::localizedStringsURL): 5507 (WebInspectorFrontendClient::hiddenPanels): 5508 (WebInspectorFrontendClient::bringToFront): 5509 (WebInspectorFrontendClient::closeWindow): 5510 (WebInspectorFrontendClient::attachWindow): 5511 (WebInspectorFrontendClient::detachWindow): 5512 (WebInspectorFrontendClient::setAttachedWindowHeight): 5513 (WebInspectorFrontendClient::inspectedURLChanged): 5514 (WebInspectorFrontendClient::closeWindowWithoutNotifications): 5515 (WebInspectorFrontendClient::showWindowWithoutNotifications): 5516 (WebInspectorFrontendClient::destroyInspectorView): 5517 (WebInspectorFrontendClient::updateWindowTitle): 5518 (WebInspectorFrontendClient::onGetMinMaxInfo): 5519 (WebInspectorFrontendClient::onSize): 5520 (WebInspectorFrontendClient::onClose): 5521 (WebInspectorFrontendClient::onSetFocus): 5522 (WebInspectorFrontendClient::onWebViewWindowPosChanging): 5523 (WebInspectorWndProc): 5524 (WebInspectorFrontendClient::windowReceivedMessage): 5525 * WebCoreSupport/WebInspectorClient.h: 5526 (WebInspectorClient::frontendClosing): 5527 * WebInspector.cpp: 5528 (WebInspector::attach): 5529 (WebInspector::detach): 5530 5531 2010-03-14 Dan Bernstein <mitz (a] apple.com> 5532 5533 Reviewed by Darin Adler. 5534 5535 WebKit part of removing support for legacy versions of Core Graphics 5536 5537 * WebKitClassFactory.cpp: 5538 (WebKitClassFactory::WebKitClassFactory): Removed call to populateFontDatabase(). 5539 * WebKitGraphics.cpp: 5540 (makeFont): Ditto. 5541 * WebTextRenderer.cpp: 5542 (WebTextRenderer::registerPrivateFont): Removed call to wkAddFontsAtPath(). 5543 5544 2010-03-12 Enrica Casucci <enrica (a] apple.com> 5545 5546 Fixed broken build on Windows. 5547 Added contditional compilation for accelerated compositing. 5548 5549 * WebView.cpp: 5550 (WebView::deleteBackingStore): 5551 (WebView::addToDirtyRegion): 5552 (WebView::updateBackingStore): 5553 5554 2010-03-12 Beth Dakin <bdakin (a] apple.com> 5555 5556 Reviewed by Simon Fraser. 5557 5558 Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen 5559 API naming is inconsistent 5560 -and corresponding- 5561 <rdar://problem/7729165> 5562 5563 This patch changes all occurrences of "fullScreen" to the more 5564 popular "fullscreen." 5565 5566 * FullscreenVideoController.cpp: 5567 (FullscreenVideoController::onMouseDown): 5568 (FullscreenVideoController::onMouseMove): 5569 (FullscreenVideoController::onMouseUp): 5570 * FullscreenVideoController.h: 5571 (FullscreenVideoController::fullscreenToHUDCoordinates): 5572 5573 2010-03-12 Beth Dakin <bdakin (a] apple.com> 5574 5575 Reviewed by Adam Roben. 5576 5577 Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen 5578 video HUD stays on top when switching to another window (e.g. via 5579 Alt-Tab) 5580 -and corresponding- 5581 <rdar://problem/7547574> 5582 5583 The HUD was always on top because it had the WS_EX_TOPMOST style. 5584 So I removed the style and made m_videoWindow the owner of 5585 m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow 5586 is the focused window. 5587 5588 * FullscreenVideoController.cpp: 5589 (FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud. 5590 (FullscreenVideoController::createHUDWindow): 5591 5592 2010-03-12 Enrica Casucci <enrica (a] apple.com> 5593 5594 Reviewed by Simon Fraser. 5595 5596 Content of 3D tests appears at the bottom right corner sometimes. 5597 <rdar://problem/7556244> 5598 <https://bugs.webkit.org/show_bug.cgi?id=36027> 5599 5600 See detailed comments in WebCore/ChangeLog. 5601 5602 * WebView.cpp: 5603 (WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store. 5604 (WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the 5605 backing store dirty region. 5606 (WebView::updateBackingStore): Reset the dirty flag after painting into the backing store. 5607 (WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents. 5608 (WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame. 5609 We are passing width and height of the view content together with the offset for the scrolling. 5610 It was confusing to pass it all as a rectangle, when it is not a rectangle. 5611 5612 2010-03-11 Aaron Boodman <aa (a] chromium.org> 5613 5614 Kill WebDocument::applicationID() (part 1). 5615 5616 Modify interface to WebCore::NotificationPresenter::checkPermission() 5617 and remove implementation of WebDocument::applicationID(). Breaking 5618 API changes will be in a subsequent change. 5619 https://bugs.webkit.org/show_bug.cgi?id=35846 5620 5621 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: 5622 (WebDesktopNotificationsDelegate::checkPermission): 5623 * WebCoreSupport/WebDesktopNotificationsDelegate.h: 5624 5625 2010-03-11 Anders Carlsson <andersca (a] apple.com> 5626 5627 Reviewed by David Hyatt. 5628 5629 Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents. 5630 5631 * WebCoreSupport/WebChromeClient.cpp: 5632 * WebCoreSupport/WebChromeClient.h: 5633 5634 2010-03-10 Eric Uhrhane <ericu (a] chromium.org> 5635 5636 Reviewed by David Levin. 5637 5638 The build fix for my patch on bug #35763 wasn't quite right--it removed 5639 the call entirely, instead of replacing it with the new API. This adds 5640 the call to Database::setIsAvailable. 5641 5642 https://bugs.webkit.org/show_bug.cgi?id=35763 5643 5644 * WebView.cpp: Added a call to Database::setIsAvailable where change 55667 removed the old Settings API call <http://trac.webkit.org/changeset/55667>. 5645 (WebView::notifyPreferencesChanged): 5646 5647 2010-03-10 John Sullivan <sullivan (a] apple.com> 5648 5649 Reviewed by Tim Hatcher. 5650 5651 <rdar://problem/7735387> input type other than text won't work with autofill 5652 <https://bugs.webkit.org/show_bug.cgi?id=35963> 5653 5654 * WebFrame.cpp: 5655 (WebFrame::elementDoesAutoComplete): 5656 Return true for any text field that's not a password, rather than only 5657 for TEXT type. 5658 5659 2010-03-09 Brady Eidson <beidson (a] apple.com> 5660 5661 Reviewed by Tim Hatcher. 5662 5663 REGRESSION: WebInspector docking busted on Windows 5664 <rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953 5665 5666 * WebCoreSupport/WebInspectorClient.cpp: 5667 (WebInspectorClient::attachWindow): Use the InspectorController:: copy of the should attach settings key. 5668 (WebInspectorClient::detachWindow): Ditto. 5669 (WebInspectorClient::showWindowWithoutNotifications): Ditto. 5670 5671 2010-03-09 John Sullivan <sullivan (a] apple.com> 5672 5673 Fixed localized string key collision. update-webkit-localized-strings now 5674 runs without errors. 5675 5676 Reviewed by Adam Roben. 5677 5678 * WebCoreLocalizedStrings.cpp: 5679 (WebCore::AXMenuListPopupActionVerb): 5680 Used LPCTSTR_UI_STRING_KEY for the 2nd use of "press". 5681 5682 2010-03-08 Adam Treat <atreat (a] rim.com> 5683 5684 Unreviewed build fix for Windows. 5685 5686 * WebCoreSupport/WebChromeClient.cpp: 5687 (WebChromeClient::invalidateContents): 5688 5689 2010-03-02 Adam Treat <atreat (a] rim.com> 5690 5691 Reviewed by Dave Hyatt. 5692 5693 Adapt the win port to the refactoring of repaint methods. 5694 5695 https://bugs.webkit.org/show_bug.cgi?id=34214 5696 5697 * WebCoreSupport/WebChromeClient.cpp: 5698 (WebChromeClient::invalidateContents): 5699 (WebChromeClient::invalidateWindow): 5700 (WebChromeClient::invalidateContentsAndWindow): 5701 (WebChromeClient::invalidateContentsForSlowScroll): 5702 * WebCoreSupport/WebChromeClient.h: 5703 5704 2010-03-08 Daniel Bates <dbates (a] rim.com> 5705 5706 Unreviewed, build fix. 5707 5708 Attempt to fix the Windows builds by applying the corresponding change 5709 made in bug #35763 <https://bugs.webkit.org/show_bug.cgi?id=35763>. 5710 5711 * WebView.cpp: Removed call to settings->setDatabasesEnabled since this 5712 setting no longer exists following changeset 55666 <http://trac.webkit.org/changeset/55666>. 5713 (WebView::notifyPreferencesChanged): 5714 5715 2010-03-07 Mark Rowe <mrowe (a] apple.com> 5716 5717 Windows build fix. 5718 5719 * WebKitPrefix.h: Include CoreFoundation/CoreFoundation.h from the Windows prefix header 5720 since some WebCore headers rely on the types declared within being available via the prefix 5721 header. 5722 5723 2010-03-05 Chris Marrin <cmarrin (a] apple.com> 5724 5725 Reviewed by Simon Fraser. 5726 5727 Got rid of platformLayer use in WebView. 5728 https://bugs.webkit.org/show_bug.cgi?id=35798 5729 5730 WKCACFLayer no longer depends on GraphicsLayer, so I got rid of 5731 that dependency on WebView. Now WebChromeClient casts platformLayer 5732 to WKCACFLayer which will always be the case on Windows. 5733 5734 * WebCoreSupport/WebChromeClient.cpp: 5735 (WebChromeClient::attachRootGraphicsLayer): 5736 * WebView.cpp: 5737 (WebView::setRootChildLayer): 5738 * WebView.h: 5739 5740 2010-03-04 Beth Dakin <bdakin (a] apple.com> 5741 5742 Reviewed by Anders Carlsson. 5743 5744 WebCore::Page::setInstanceHandle() is now just 5745 WebCore::setInstanceHandle() 5746 5747 * WebKitDLL.cpp: 5748 (DllMain): 5749 5750 2010-03-03 Alice Liu <alice.liu (a] apple.com> 5751 5752 Reviewed by Jon Honeycutt. 5753 5754 Add a way to get an iframe's content frame 5755 5756 * DOMCoreClasses.cpp: 5757 (DOMElement::createInstance): 5758 Added case for DOMHTMLIFrameElement 5759 * DOMHTMLClasses.cpp: 5760 Adding the few DOMHTMLIFrameElement functions definitions that have 5761 distinct implementations (all others just call parent implementation) 5762 (DOMHTMLIFrameElement::QueryInterface): 5763 (DOMHTMLIFrameElement::contentFrame): 5764 * DOMHTMLClasses.h: 5765 Most of these function declarations have definitions that just call the parent implementation 5766 (DOMHTMLIFrameElement::DOMHTMLIFrameElement): 5767 (DOMHTMLIFrameElement::AddRef): 5768 (DOMHTMLIFrameElement::Release): 5769 (DOMHTMLIFrameElement::throwException): 5770 (DOMHTMLIFrameElement::callWebScriptMethod): 5771 (DOMHTMLIFrameElement::evaluateWebScript): 5772 (DOMHTMLIFrameElement::removeWebScriptKey): 5773 (DOMHTMLIFrameElement::stringRepresentation): 5774 (DOMHTMLIFrameElement::webScriptValueAtIndex): 5775 (DOMHTMLIFrameElement::setWebScriptValueAtIndex): 5776 (DOMHTMLIFrameElement::setException): 5777 (DOMHTMLIFrameElement::nodeName): 5778 (DOMHTMLIFrameElement::nodeValue): 5779 (DOMHTMLIFrameElement::setNodeValue): 5780 (DOMHTMLIFrameElement::nodeType): 5781 (DOMHTMLIFrameElement::parentNode): 5782 (DOMHTMLIFrameElement::childNodes): 5783 (DOMHTMLIFrameElement::firstChild): 5784 (DOMHTMLIFrameElement::lastChild): 5785 (DOMHTMLIFrameElement::previousSibling): 5786 (DOMHTMLIFrameElement::nextSibling): 5787 (DOMHTMLIFrameElement::attributes): 5788 (DOMHTMLIFrameElement::ownerDocument): 5789 (DOMHTMLIFrameElement::insertBefore): 5790 (DOMHTMLIFrameElement::replaceChild): 5791 (DOMHTMLIFrameElement::removeChild): 5792 (DOMHTMLIFrameElement::appendChild): 5793 (DOMHTMLIFrameElement::hasChildNodes): 5794 (DOMHTMLIFrameElement::cloneNode): 5795 (DOMHTMLIFrameElement::normalize): 5796 (DOMHTMLIFrameElement::isSupported): 5797 (DOMHTMLIFrameElement::namespaceURI): 5798 (DOMHTMLIFrameElement::prefix): 5799 (DOMHTMLIFrameElement::setPrefix): 5800 (DOMHTMLIFrameElement::localName): 5801 (DOMHTMLIFrameElement::hasAttributes): 5802 (DOMHTMLIFrameElement::isSameNode): 5803 (DOMHTMLIFrameElement::isEqualNode): 5804 (DOMHTMLIFrameElement::textContent): 5805 (DOMHTMLIFrameElement::setTextContent): 5806 (DOMHTMLIFrameElement::tagName): 5807 (DOMHTMLIFrameElement::getAttribute): 5808 (DOMHTMLIFrameElement::setAttribute): 5809 (DOMHTMLIFrameElement::removeAttribute): 5810 (DOMHTMLIFrameElement::getAttributeNode): 5811 (DOMHTMLIFrameElement::setAttributeNode): 5812 (DOMHTMLIFrameElement::removeAttributeNode): 5813 (DOMHTMLIFrameElement::getElementsByTagName): 5814 (DOMHTMLIFrameElement::getAttributeNS): 5815 (DOMHTMLIFrameElement::setAttributeNS): 5816 (DOMHTMLIFrameElement::removeAttributeNS): 5817 (DOMHTMLIFrameElement::getAttributeNodeNS): 5818 (DOMHTMLIFrameElement::setAttributeNodeNS): 5819 (DOMHTMLIFrameElement::getElementsByTagNameNS): 5820 (DOMHTMLIFrameElement::hasAttribute): 5821 (DOMHTMLIFrameElement::hasAttributeNS): 5822 (DOMHTMLIFrameElement::focus): 5823 (DOMHTMLIFrameElement::blur): 5824 (DOMHTMLIFrameElement::idName): 5825 (DOMHTMLIFrameElement::setIdName): 5826 (DOMHTMLIFrameElement::title): 5827 (DOMHTMLIFrameElement::setTitle): 5828 (DOMHTMLIFrameElement::lang): 5829 (DOMHTMLIFrameElement::setLang): 5830 (DOMHTMLIFrameElement::dir): 5831 (DOMHTMLIFrameElement::setDir): 5832 (DOMHTMLIFrameElement::className): 5833 (DOMHTMLIFrameElement::setClassName): 5834 (DOMHTMLIFrameElement::innerHTML): 5835 (DOMHTMLIFrameElement::setInnerHTML): 5836 (DOMHTMLIFrameElement::innerText): 5837 (DOMHTMLIFrameElement::setInnerText): 5838 * Interfaces/DOMHTML.idl: 5839 Added IDOMHTMLIFrameElement interface 5840 5841 2010-03-03 Chris Marrin <cmarrin (a] apple.com> 5842 5843 Reviewed by Simon Fraser. 5844 5845 Export acceleratedCompositing flag in IWebPreferences. 5846 https://bugs.webkit.org/show_bug.cgi?id=35610 5847 5848 * Interfaces/IWebPreferences.idl: 5849 5850 2010-03-02 Beth Dakin <bdakin (a] apple.com> 5851 5852 Reviewed by Darin Adler and Adam Roben. 5853 5854 Tiny WebKit portion of fix for <rdar://problem/7485289> WebKit 5855 crashes on systems that don't support CoreAnimation 5856 5857 setHostWindow() no longer calls createRenderer(), so now that has 5858 to be called manually. 5859 5860 * WebView.cpp: 5861 (WebView::setAcceleratedCompositing): 5862 5863 2010-03-02 Adam Roben <aroben (a] apple.com> 5864 5865 Add IWebViewPrivate::registerURLSchemeAsSecure 5866 5867 Fixes <http://webkit.org/b/35580> <rdar://problem/7706407> Expose 5868 SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI 5869 5870 Reviewed by Tim Hatcher. 5871 5872 * Interfaces/WebKit.idl: Touched to force a build. 5873 5874 * Interfaces/IWebViewPrivate.idl: 5875 * WebView.cpp: 5876 (WebView::registerURLSchemeAsSecure): 5877 * WebView.h: 5878 Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure. 5879 5880 2010-03-01 Jon Honeycutt <jhoneycutt (a] apple.com> 5881 5882 Remove Windows line endings from some files. 5883 5884 Rubber-stamped by Alice Liu. 5885 5886 * Interfaces/IWebEmbeddedView.idl: 5887 5888 * WebCoreSupport/EmbeddedWidget.cpp: 5889 (EmbeddedWidget::create): 5890 (EmbeddedWidget::~EmbeddedWidget): 5891 (EmbeddedWidget::createWindow): 5892 (EmbeddedWidget::invalidateRect): 5893 (EmbeddedWidget::setFrameRect): 5894 (EmbeddedWidget::frameRectsChanged): 5895 (EmbeddedWidget::setFocus): 5896 (EmbeddedWidget::show): 5897 (EmbeddedWidget::hide): 5898 (EmbeddedWidget::windowClipRect): 5899 (EmbeddedWidget::setParent): 5900 (EmbeddedWidget::attachToWindow): 5901 (EmbeddedWidget::detachFromWindow): 5902 (EmbeddedWidget::didReceiveResponse): 5903 (EmbeddedWidget::didReceiveData): 5904 (EmbeddedWidget::didFinishLoading): 5905 (EmbeddedWidget::didFail): 5906 5907 * WebCoreSupport/EmbeddedWidget.h: 5908 (EmbeddedWidget::EmbeddedWidget): 5909 5910 2010-03-01 Jon Honeycutt <jhoneycutt (a] apple.com> 5911 5912 Some WebKit DOMNode API is unimplemented. 5913 https://bugs.webkit.org/show_bug.cgi?id=35554 5914 5915 Reviewed by Alice Liu. 5916 5917 * DOMCoreClasses.cpp: 5918 (DOMNode::nextSibling): 5919 Create a DOMNode to wrap m_node's next sibling, and assign it to the 5920 out param 'result'. 5921 (DOMNode::insertBefore): 5922 Query for the DOMNode for newChild, and return early if we fail. Query 5923 refChild for DOMNode. Call insertBefore(), passing the newChild's 5924 WebCore node and refChild's WebCore node (if refChild is non-null). If 5925 we successfully insert the child, fill the result out param with 5926 newChild, ref it, and return S_OK. Otherwise, return E_FAIL. 5927 (DOMNode::removeChild): 5928 Query oldChild for DOMNode. If we fail, return E_FAIL. Call 5929 removeChild(), passing the node's WebCore node. If this fails, return 5930 E_FAIL. Otherwise, fill the result out param with oldChild, ref it, and 5931 return S_OK. 5932 5933 2010-03-01 Jakob Petsovits <jpetsovits (a] rim.com> 5934 5935 Reviewed by Adam Barth. 5936 5937 Adapt to the new ZoomMode enum. 5938 https://bugs.webkit.org/show_bug.cgi?id=35347 5939 5940 * WebFrame.cpp: 5941 (WebFrame::setTextSizeMultiplier): 5942 * WebView.cpp: 5943 (WebView::setZoomMultiplier): 5944 (WebView::zoomMultiplier): 5945 (WebView::canMakeTextLarger): 5946 (WebView::makeTextLarger): 5947 (WebView::canMakeTextSmaller): 5948 (WebView::makeTextSmaller): 5949 (WebView::notifyPreferencesChanged): 5950 5951 2010-02-26 Jon Honeycutt <jhoneycutt (a] apple.com> 5952 5953 <rdar://problem/7703368> IWebUIDelegatePrivate::embeddedViewWithArguments 5954 is passed wrong arguments 5955 5956 Reviewed by Adam Roben. 5957 5958 * Interfaces/IWebUIDelegatePrivate.idl: 5959 Update copyright strings. Added a new key for the plug-in source URL. 5960 5961 * Interfaces/WebKit.idl: 5962 Update copyright strings. 5963 5964 * WebCoreSupport/WebFrameLoaderClient.cpp: 5965 (WebFrameLoaderClient::createPlugin): 5966 Pass the URL of the plug-in as the source URL. Pass the document's 5967 base URI for the base URL. 5968 5969 2010-02-23 Brady Eidson <beidson (a] apple.com> 5970 5971 Reviewed by Tim Hatcher and Pavel Feldman. 5972 5973 Regression (r55107) - WebInspector docking is busted. 5974 https://bugs.webkit.org/show_bug.cgi?id=35274 5975 5976 * WebCoreSupport/WebInspectorClient.cpp: 5977 (WebInspectorClient::showWindowWithoutNotifications): Swap the order of the "should attach?" check 5978 to get the expected behavior. 5979 5980 2010-02-23 Steve Block <steveblock (a] google.com> 5981 5982 Reviewed by Darin Adler. 5983 5984 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame 5985 https://bugs.webkit.org/show_bug.cgi?id=34962 5986 5987 This method is required so that a Geolocation object can cancel an 5988 asynchronous permission request. This allows the chrome client to cancel 5989 any UI it is showing for the permission request. 5990 5991 * WebCoreSupport/WebChromeClient.h: 5992 (WebChromeClient::cancelGeolocationPermissionRequestForFrame): 5993 5994 2010-02-22 Steve Falkenburg <sfalken (a] apple.com> 5995 5996 Reviewed by Darin Adler. 5997 5998 WebKit on Windows should pick up system setting changes without requiring explicit API calls 5999 https://bugs.webkit.org/show_bug.cgi?id=35269 6000 6001 * WebKit.vcproj/WebKit.def: Removed WebKitSystemParameterChanged. 6002 * WebKit.vcproj/WebKit_debug.def: Removed WebKitSystemParameterChanged. 6003 * WebKitGraphics.cpp: Removed WebKitSystemParameterChanged. 6004 * WebKitGraphics.h: Removed WebKitSystemParameterChanged. 6005 * WebView.cpp: 6006 (systemParameterChanged): Call through to wkSystemFontSmoothingChanged for font changes. 6007 (WebView::windowReceivedMessage): Pick up WM_SETTINGCHANGE from windowReceivedMessage. 6008 6009 2010-02-22 Brady Eidson <beidson (a] apple.com> 6010 6011 Reviewed by Tim Hatcher. 6012 6013 Disable WebView docking to views that are too small. 6014 <rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254 6015 6016 * WebCoreSupport/WebInspectorClient.cpp: 6017 (WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector 6018 window attached if WebCore says it shouldn't be attached. 6019 6020 2010-02-17 Steve Falkenburg <sfalken (a] apple.com> 6021 6022 Reviewed by Dan Bernstein. 6023 6024 WebKit on Windows needs a mechanism to listen for WM_SETTINGCHANGED messages 6025 https://bugs.webkit.org/show_bug.cgi?id=35076 6026 6027 * WebKit.vcproj/WebKit.def: Added WebKitSystemParameterChanged. 6028 * WebKit.vcproj/WebKit_debug.def: Added WebKitSystemParameterChanged. 6029 * WebKitGraphics.cpp: 6030 (WebKitSystemParameterChanged): Call through to wkSystemFontSmoothingChanged for font smoothing changes. 6031 * WebKitGraphics.h: Added WebKitSystemParameterChanged. 6032 6033 2010-02-17 Dmitry Titov <dimich (a] chromium.org> 6034 6035 Reviewed by David Levin, Darin Fisher, Simon Hausmann. 6036 6037 When a live iframe element is moved between pages, it still depends on the old page. 6038 https://bugs.webkit.org/show_bug.cgi?id=34382 6039 6040 * WebCoreSupport/WebFrameLoaderClient.cpp: 6041 (WebFrameLoaderClient::didTransferChildFrameToNewDocument): 6042 Added empty implementation of a new virtual method. 6043 6044 * WebCoreSupport/WebFrameLoaderClient.h: 6045 6046 2010-02-17 Kent Tamura <tkent (a] chromium.org> 6047 6048 Reviewed by Eric Seidel. 6049 6050 Introduces new Icon loading interface in order to support 6051 asynchronous loading. 6052 https://bugs.webkit.org/show_bug.cgi?id=32054 6053 6054 Add an empty implementation of ChromeClient::iconForFiles(). 6055 6056 * WebCoreSupport/WebChromeClient.cpp: 6057 (WebChromeClient::iconForFiles): 6058 * WebCoreSupport/WebChromeClient.h: 6059 6060 2010-02-17 Shinichiro Hamaji <hamaji (a] chromium.org> 6061 6062 Unreviewed. Touch WebKit.idl to fix the build. 6063 6064 [Win] Implement test functions for printing 6065 https://bugs.webkit.org/show_bug.cgi?id=34570 6066 6067 * Interfaces/WebKit.idl: 6068 6069 2010-02-17 Shinichiro Hamaji <hamaji (a] chromium.org> 6070 6071 Reviewed by Eric Seidel. 6072 6073 [Win] Implement test functions for printing 6074 https://bugs.webkit.org/show_bug.cgi?id=34570 6075 6076 * Interfaces/IWebFramePrivate.idl: 6077 * WebFrame.cpp: 6078 (WebFrame::pageNumberForElementById): 6079 (WebFrame::numberOfPages): 6080 * WebFrame.h: 6081 6082 2010-02-16 Darin Adler <darin (a] apple.com> 6083 6084 Reviewed by Sam Weinig. 6085 6086 Generalize delayed plug-in start for background tabs for use for other media 6087 https://bugs.webkit.org/show_bug.cgi?id=34981 6088 6089 * WebView.cpp: 6090 (WebView::setCanStartPlugins): Change to call setCanStartMedia. 6091 In a later patch we can change the of the public function in the IDL file too, 6092 but for now this should be enough. 6093 6094 2010-02-15 Adam Roben <aroben (a] apple.com> 6095 6096 Add IWebFramePrivate::visibleContentRect 6097 6098 Fixes <http://webkit.org/b/34956> Add API to get a WebFrame's visible 6099 content rect 6100 6101 Reviewed by Jon Honeycutt. 6102 6103 * Interfaces/IWebFramePrivate.idl: Added visibleContentRect. 6104 6105 * Interfaces/WebKit.idl: Touched to force a build. 6106 6107 * WebFrame.cpp: 6108 (WebFrame::visibleContentRect): 6109 * WebFrame.h: 6110 Added. Calls through to FrameView::visibleContentRect. 6111 6112 2010-02-12 Brian Weinstein <bweinstein (a] apple.com> 6113 6114 Reviewed by Adam Roben. 6115 6116 onmouseout fired when moving over tooltip on Windows 6117 https://bugs.webkit.org/show_bug.cgi?id=16794 6118 <rdar://5762038>. 6119 6120 Add WS_EX_TRANSPARENT to out tooltip HWND so it isn't subject to hit testing, and when 6121 you mouse over the tooltip, it doesn't send a mouseout to the web content. 6122 6123 * WebView.cpp: 6124 (WebView::initializeToolTipWindow): Add WS_EX_TRANSPARENT. 6125 6126 2010-02-10 Jesus Sanchez-Palencia <jesus.palencia (a] openbossa.org> 6127 6128 Reviewed by Kenneth Rohde Christiansen. 6129 6130 Support frameset flattening 6131 https://bugs.webkit.org/show_bug.cgi?id=32717 6132 6133 Add support for enabling/disabling FrameSet Flattening on the Windows port. 6134 6135 * Interfaces/IWebPreferencesPrivate.idl: 6136 * WebPreferenceKeysPrivate.h: 6137 * WebPreferences.cpp: 6138 (WebPreferences::initializeDefaultSettings): 6139 (WebPreferences::isFrameSetFlatteningEnabled): 6140 (WebPreferences::setFrameSetFlatteningEnabled): 6141 * WebPreferences.h: 6142 * WebView.cpp: 6143 (WebView::notifyPreferencesChanged): 6144 6145 2010-02-10 Adam Roben <aroben (a] apple.com> 6146 6147 Remove unnecessary #include of shfolder.h 6148 6149 shfolder.h has been deprecated in newer versions of the Windows SDK. 6150 6151 Fixes <http://webkit.org/b/34803> WebPreferences.cpp fails to compile 6152 under VS2010 RC due to #include of shfolder.h. 6153 6154 Reviewed by Darin Adler. 6155 6156 * WebPreferences.cpp: Removed #include. 6157 6158 2010-02-08 Charlie Reis <creis (a] chromium.org> 6159 6160 Reviewed by Darin Adler. 6161 6162 onbeforeunload not called at window close + frame or iframe focused 6163 https://bugs.webkit.org/show_bug.cgi?id=27481 6164 6165 Chromium and WebKit on Windows will now fire beforeunload handlers 6166 even if an inner frame is focused. 6167 6168 Layout tests aren't able to test this bug, since it requires closing 6169 the actual browser window, not calling window.close(). Instead, 6170 test with WebCore/manual-tests/onbeforeunload-focused-iframe.html. 6171 6172 * WebView.cpp: 6173 (WebView::shouldClose): 6174 6175 2010-02-08 Brent Fulgham <bfulgham (a] webkit.org> 6176 6177 Reviewed by Adam Roben. 6178 6179 Include header position in World Transform used for plugin positioning. 6180 https://bugs.webkit.org/show_bug.cgi?id=34709 6181 6182 * WebFrame.cpp: 6183 (WebFrame::spoolPage): Correct WinCairo plugin print positioning to 6184 account for header size. Existing code ignored this, causing 6185 plugins to overlay other elements. 6186 6187 2010-02-04 Alice Liu <alice.liu (a] apple.com> 6188 6189 Reviewed by Jon Honeycutt. 6190 6191 https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error 6192 codes for most elements that arent listbox or menupopup related" 6193 <rdar://problem/7436861> 6194 6195 * AccessibleBase.cpp: 6196 (AccessibleBase::accSelect): 6197 - Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that 6198 aren't beneath listboxes or menupopups. This was too restrictive since 6199 any element can be selectable. 6200 - Correct the misinterpretation of MSDN's stipulation of situations involving 6201 adding, removing, and extending selection on single-select elements 6202 6203 2010-02-04 Brent Fulgham <bfulgham (a] webkit.org> 6204 6205 Reviewed by Adam Roben. 6206 6207 Properly handle margin settings when printing Plugins in WinCairo. 6208 https://bugs.webkit.org/show_bug.cgi?id=34613 6209 6210 * WebFrame.cpp: 6211 (WebFrame::spoolPage): Adjust the GraphicsContext passed to the 6212 paintContents method so that the World Transform is properly 6213 positioned to account for margin settings at the time that 6214 PluginViewWin.cpp processes the drawing operations. 6215 6216 2010-02-04 Brent Fulgham <bfulgham (a] webkit.org> 6217 6218 Reviewed by Adam Roben. 6219 6220 Properly handle margin settings in WinCairo. 6221 https://bugs.webkit.org/show_bug.cgi?id=34545 6222 6223 * WebFrame.cpp: 6224 (scaleFactor): Require the margin information as an input 6225 parameter, and use them when computing the scaling factor. 6226 (WebFrame::drawHeader): Pass margin size to scaleFactor. 6227 (WebFrame::drawFooter): Pass margin size to scaleFactor. 6228 (WebFrame::spoolPage): 6229 1. Pass margin size to scaleFactor. 6230 2. Recognize that the return value of printerMarginRect is 6231 already in device units, and therefore scale it so that 6232 the Cairo drawing is correct. 6233 3. Remove scaling call for margins in GDI code, as it is 6234 already in scaled units. 6235 6236 2010-02-03 Brian Weinstein <bweinstein (a] apple.com> 6237 6238 Reviewed by Steve Falkenburg. 6239 6240 Scroll does not work with IBM Thinkpad. 6241 <https://bugs.webkit.org/show_bug.cgi?id=14227> 6242 <rdar://7142545> 6243 6244 When initializing the WebView, add two scrollbar Windows inside of 6245 our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events. 6246 (similar to what Firefox did in: <https://bugzilla.mozilla.org/show_bug.cgi?id=507222>. 6247 6248 Only do this if the user has installed some kind of Trackpoint driver, using an algorithm 6249 like <https://bugzilla.mozilla.org/show_bug.cgi?id=514927>. 6250 6251 Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll 6252 the WebView. 6253 6254 * WebView.cpp: 6255 (WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down 6256 by lines or pages. 6257 (WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right 6258 by lines or pages. 6259 (WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL. 6260 (WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create 6261 vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages. 6262 (WebView::shouldInitializeTrackPointHack): Check if there is a registry key for 6263 the some kind of IBM Trackpoint driver. 6264 * WebView.h: 6265 6266 2010-02-02 Steve Falkenburg <sfalken (a] apple.com> 6267 6268 Reviewed by Darin Adler. 6269 6270 Copyright year updating for Windows version resources should be automatic 6271 https://bugs.webkit.org/show_bug.cgi?id=34503 6272 6273 * WebKit.vcproj/WebKit.rc: 6274 6275 2010-02-02 Adam Roben <aroben (a] apple.com> 6276 6277 Stop copying WebCore's IDL files from SRCROOT to OBJROOT 6278 6279 WebKit doesn't use these anymore (as of r52921). 6280 6281 Part of Bug 34496: Clean up WebCore's IDL/script copying 6282 <https://bugs.webkit.org/show_bug.cgi?id=34496> 6283 6284 Reviewed by Steve Falkenburg. 6285 6286 * WebKit.vcproj/WebKit.make: 6287 6288 2010-01-29 Gavin Barraclough <barraclough (a] apple.com> 6289 6290 Reviewed by Sam Weinig + Oliver Hunt. 6291 6292 Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds 6293 6294 Pass processeing user gensture flag to media play/pause methods. 6295 6296 * FullscreenVideoController.cpp: 6297 (FullscreenVideoController::play): 6298 (FullscreenVideoController::pause): 6299 6300 2010-01-29 Brian Weinstein <bweinstein (a] apple.com> 6301 6302 Reviewed by Adam Roben. 6303 6304 Drag and Drop: Windows uses "stop" sign as cursor when dragging 6305 https://bugs.webkit.org/show_bug.cgi?id=34305 6306 <rdar://problem/7589672> 6307 6308 Add a preference in WebKit (that defaults to false), for whether or not 6309 we should show the custom cursors during drag and drop. However, this is 6310 currently only used on Windows, and only used to hide the "drop not allowed" 6311 icon inside the WebView is the preference is set to true. 6312 6313 This will be off by default, so no change in behavior. 6314 6315 * Interfaces/IWebPreferencesPrivate.idl: Added new functions. 6316 * Interfaces/WebKit.idl: Touched to force Interfaces build. 6317 * WebDropSource.cpp: 6318 (WebDropSource::GiveFeedback): Implementation of conditional showing cursor 6319 logic. 6320 * WebPreferenceKeysPrivate.h: Added new preference key. 6321 * WebPreferences.cpp: Added new functions. 6322 (WebPreferences::setCustomDragCursorsEnabled): 6323 (WebPreferences::customDragCursorsEnabled): 6324 * WebPreferences.h: Added new functions. 6325 6326 2010-01-28 Jon Honeycutt <jhoneycutt (a] apple.com> 6327 6328 MSAA: Crash when posting a notification for a detached object 6329 6330 https://bugs.webkit.org/show_bug.cgi?id=34309 6331 <rdar://problem/7409759> 6332 6333 Reviewed by Darin Adler. 6334 6335 * AccessibleBase.cpp: 6336 (AccessibleBase::QueryService): 6337 If an unrecognized service ID is passed, return early. Otherwise, return 6338 the result of QueryInterface. 6339 (AccessibleBase::QueryInterface): 6340 Add static_casts. Check for new UUIDs. 6341 (AccessibleBase::isSameObject): 6342 Query the object for AccessibleBase. Return whether the pointers or the 6343 wrapped objects match. 6344 6345 * AccessibleBase.h: 6346 Give the class a UUID so we can query for it in isSameObject(). Inherit 6347 from IAccessibleComparable; inherit from IServiceProvider so clients can 6348 use QueryService to query for a custom interface. 6349 6350 * Interfaces/AccessibleComparable.idl: Added. Declares a function that 6351 can be called to compare to accessible objects. 6352 6353 * Interfaces/WebKit.idl: 6354 Include the new IDL. 6355 6356 * WebKit.vcproj/Interfaces.vcproj: 6357 Add the new IDL to the project. 6358 6359 2010-01-27 Aaron Boodman <aa (a] chromium.org> 6360 6361 Expand NotificationCenter::checkPermission() interface. 6362 It now passes the full URL instead of just the origin. 6363 6364 https://bugs.webkit.org/show_bug.cgi?id=34238 6365 6366 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: 6367 (WebDesktopNotificationsDelegate::checkPermission): 6368 * WebCoreSupport/WebDesktopNotificationsDelegate.h: 6369 6370 2010-01-27 Adam Roben <aroben (a] apple.com> 6371 6372 Make it possible to instantiate WebSerializedJSValue using 6373 WebKitCreateInstance 6374 6375 Reviewed by Dave Hyatt. 6376 6377 * ForEachCoClass.h: 6378 * WebKitClassFactory.cpp: 6379 Added WebSerializedJSValue. 6380 6381 2010-01-26 Steve Falkenburg <sfalken (a] apple.com> 6382 6383 Reviewed by Oliver Hunt. 6384 6385 Windows build references non-existent include paths 6386 https://bugs.webkit.org/show_bug.cgi?id=34175 6387 6388 * WebKit.vcproj/WebKit.vcproj: 6389 6390 2010-01-25 Steve Falkenburg <sfalken (a] apple.com> 6391 6392 Reviewed by Simon Fraser. 6393 6394 A WebGeolocationControllerClient is leaked for every WebView 6395 https://bugs.webkit.org/show_bug.cgi?id=34145 6396 6397 * WebCoreSupport/WebGeolocationControllerClient.cpp: 6398 (WebGeolocationControllerClient::geolocationDestroyed): Added. 6399 * WebCoreSupport/WebGeolocationControllerClient.h: 6400 6401 2010-01-23 Dan Bernstein <mitz (a] apple.com> 6402 6403 Reviewed by Maciej Stachowiak. 6404 6405 <rdar://problem/7569820> svg/custom/text-zoom.xhtml fails on Windows 6406 https://bugs.webkit.org/show_bug.cgi?id=34006 6407 6408 * WebPreferences.cpp: 6409 (WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey 6410 with a default value of true. 6411 6412 2010-01-20 Steve Falkenburg <sfalken (a] apple.com> 6413 6414 Reviewed by Sam Weinig. 6415 6416 Add missing implementation for WebGeolocationPosition::initWithTimestamp. 6417 6418 * WebGeolocationPosition.cpp: 6419 (WebGeolocationPosition::initWithTimestamp): Implemented. 6420 6421 2010-01-20 Jon Honeycutt <jhoneycutt (a] apple.com> 6422 6423 MSAA: accSelect() is not implemented 6424 6425 https://bugs.webkit.org/show_bug.cgi?id=33918 6426 <rdar://problem/7436861> 6427 6428 Reviewed by Darin Adler. 6429 6430 * AccessibleBase.cpp: 6431 (AccessibleBase::accSelect): 6432 If there is an invalid combination of state flags, return early. If the 6433 caller passed the "take focus" flag, focus the object. If the "take 6434 selection" flag was passed, check whether the parent object is an 6435 AccessibilityListBox; if so, call the object's setSelectedChildren() 6436 function. If the parent is an AccessibilityMenuListPopup, call the 6437 child object's setSelected() function. Otherwise, if the parent is some 6438 other, unsupported object, return early. 6439 If the selection flags include "add", "remove", or "extend" selection, 6440 and the parent object is not multi-selectable, return early. Otherwise, 6441 set or unset the child's selected flag based on the passed flag. 6442 6443 2010-01-20 Steve Falkenburg <sfalken (a] apple.com> 6444 6445 Reviewed by Darin Adler and Adam Roben. 6446 6447 Feature defines are difficult to maintain on Windows builds 6448 https://bugs.webkit.org/show_bug.cgi?id=33883 6449 6450 FeatureDefines.vsprops are now maintained in a way similar to 6451 Configurations/FeatureDefines.xcconfig, with the added advantage 6452 of having a single FeatureDefines file across all projects. 6453 6454 * WebKit.vcproj/Interfaces.vcproj: Add FeatureDefines.vsprops inherited property sheet. 6455 * WebKit.vcproj/WebKit.sln: Set up Cairo configuration for WebCoreGenerated. 6456 * WebKit.vcproj/WebKit.vcproj: Remove ENABLE_ preprocessor definitions. 6457 Add FeatureDefines.vsprops inherited property sheet. 6458 * WebKit.vcproj/WebKitGUID.vcproj: Add FeatureDefines.vsprops inherited property sheet. 6459 6460 2010-01-17 Jon Honeycutt <jhoneycutt (a] apple.com> 6461 6462 MSAA: The child <option> elements of a non-multiple <select> are not 6463 exposed 6464 6465 https://bugs.webkit.org/show_bug.cgi?id=33773 6466 <rdar://problem/7550556> 6467 6468 Reviewed by Alice Liu. 6469 6470 * AccessibleBase.cpp: 6471 (AccessibleBase::get_accState): 6472 If the object is invisible, set the invisible state flag. If the object 6473 is collapsed, set the collapsed state. If the object is a combo box, 6474 set the has popup flag, and if it's not collapsed, set the expanded 6475 flag. 6476 (MSAARole): 6477 Add new WebCore to MSAA role mappings. 6478 6479 * WebCoreLocalizedStrings.cpp: 6480 (WebCore::AXMenuListActionVerb): 6481 Return the action verb that Firefox uses for <select> elements with 6482 popups. 6483 (WebCore::AXMenuListPopupActionVerb): 6484 Return the verb that Firefox uses for a popup list. 6485 6486 2010-01-19 John Sullivan <sullivan (a] apple.com> 6487 6488 https://bugs.webkit.org/show_bug.cgi?id=33854 6489 Would like a variant of WebHTMLRepresentation's searchForLabelsBeforeElement that returns 6490 more info about where the result was found 6491 6492 Reviewed by Darin Adler 6493 6494 * Interfaces/IWebHTMLRepresentation.idl: 6495 Created variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove. 6496 6497 * Interfaces/WebKit.idl: 6498 Touched in order to get other idl change to propagate correctly. 6499 6500 * WebHTMLRepresentation.cpp: 6501 (WebHTMLRepresentation::deprecatedSearchForLabels): 6502 Renamed since iDL doesn't support two functions with the same name but different signatures. 6503 (WebHTMLRepresentation::searchForLabels): 6504 Implemented variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove. 6505 6506 * WebHTMLRepresentation.h: 6507 Declared variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove. 6508 6509 2010-01-19 Adam Roben <aroben (a] apple.com> 6510 6511 Windows build fix 6512 6513 * WebScriptWorld.cpp: Added missing #include. 6514 6515 2010-01-19 Dave Hyatt <hyatt (a] apple.com> 6516 6517 Build bustage fix. Make sure the newly added scriptWorldForGlobalContext function is [local] in the IDL. 6518 6519 * Interfaces/IWebScriptWorld.idl: 6520 6521 2010-01-19 Dave Hyatt <hyatt (a] apple.com> 6522 6523 Reviewed by Adam Roben. 6524 6525 Add an API to obtain a WebScriptWorld from a JSGlobalContextRef. 6526 6527 * Interfaces/IWebScriptWorld.idl: 6528 * WebScriptWorld.cpp: 6529 (WebScriptWorld::scriptWorldForGlobalContext): 6530 * WebScriptWorld.h: 6531 6532 2010-01-18 Adam Roben <aroben (a] apple.com> 6533 6534 Add IWebViewPrivate::setDomainRelaxationForbiddenForURLScheme 6535 6536 WebKit/win part of fixing <http://webkit.org/b/33806> 6537 <rdar://problem/7552837> Would like API to disallow setting of 6538 document.domain for pages with certain URL schemes 6539 6540 Reviewed by Sam Weinig. 6541 6542 * Interfaces/IWebViewPrivate.idl: Added 6543 setDomainRelaxationForbiddenForURLScheme. 6544 6545 * Interfaces/WebKit.idl: Touched to force a build. 6546 6547 * WebView.cpp: 6548 (WebView::setDomainRelaxationForbiddenForURLScheme): 6549 * WebView.h: 6550 Added. Calls through to SecurityOrigin. 6551 6552 2010-01-18 Chris Marrin <cmarrin (a] apple.com> 6553 6554 Reviewed by Darin Adler. 6555 6556 Use new setScrollFrame API 6557 https://bugs.webkit.org/show_bug.cgi?id=32279 6558 6559 * WebView.cpp: 6560 (WebView::updateRootLayerContents): 6561 6562 2010-01-15 Jon Honeycutt <jhoneycutt (a] apple.com> 6563 6564 MSAA: Screen rect for <option> elements is always the zero rect 6565 6566 https://bugs.webkit.org/show_bug.cgi?id=33758 6567 6568 Reviewed by Oliver Hunt. 6569 6570 * AccessibleBase.cpp: 6571 (AccessibleBase::accLocation): 6572 Use elementRect() rather than boundingBoxRect(), which 6573 AccessibilityListBoxOption overrides. 6574 6575 2010-01-15 Jon Honeycutt <jhoneycutt (a] apple.com> 6576 6577 get_accParent should try to retrieve parent AccessibilityObject, before 6578 calling upon window 6579 6580 https://bugs.webkit.org/show_bug.cgi?id=22893 6581 6582 Reviewed by Darin Adler. 6583 6584 * AccessibleBase.cpp: 6585 (AccessibleBase::get_accParent): 6586 If the object has a parent object, return it. If not, return the 6587 accessible for the WebView window. 6588 6589 2010-01-12 Jon Honeycutt <jhoneycutt (a] apple.com> 6590 6591 MSAA: selected, selectable, extended selectable, and multiple 6592 selectable states are not reported 6593 6594 https://bugs.webkit.org/show_bug.cgi?id=33574 6595 <rdar://problem/7536826> 6596 6597 Reviewed by Darin Adler. 6598 6599 * AccessibleBase.cpp: 6600 (AccessibleBase::get_accState): 6601 Remove the call to isMultiSelect(). Call the correctly-named 6602 isMultiSelectable(), and if it returns true, set both the "extended 6603 selectable" and "multiple selectable" states. Check whether the object 6604 is selected or selectable, and report those states. 6605 6606 2010-01-13 Steve Falkenburg <sfalken (a] apple.com> 6607 6608 Reviewed by Adam Roben. 6609 6610 Add additional Geolocation interfaces in WebKit for Windows. 6611 6612 * Interfaces/IWebGeolocationPolicyListener.idl: Added. 6613 * Interfaces/IWebUIDelegatePrivate.idl: Add decidePolicyForGeolocationRequest to IWebUIDelegatePrivate2. 6614 Append since this version hasn't shipped. 6615 * Interfaces/WebKit.idl: Add include of IWebGeolocationPolicyListener.idl. 6616 * WebCoreSupport/WebChromeClient.cpp: 6617 (WebChromeClient::requestGeolocationPermissionForFrame): Call into decidePolicyForGeolocationRequest. 6618 * WebCoreSupport/WebGeolocationControllerClient.cpp: 6619 (WebGeolocationControllerClient::WebGeolocationControllerClient): Moved *. 6620 * WebGeolocationPolicyListener.cpp: Added. 6621 * WebGeolocationPolicyListener.h: Added. 6622 * WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPolicyListener. 6623 * WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPolicyListener, WebGeolocationPolicyListener. 6624 * WebView.cpp: 6625 (WebView::setGeolocationProvider): Removed extraneous STDMETHODCALLTYPE. 6626 (WebView::geolocationProvider): Removed extraneous STDMETHODCALLTYPE. 6627 (WebView::geolocationDidChangePosition): Removed extraneous STDMETHODCALLTYPE. 6628 (WebView::geolocationDidFailWithError): Removed extraneous STDMETHODCALLTYPE. 6629 6630 2010-01-12 Steve Falkenburg <sfalken (a] apple.com> 6631 6632 Reviewed by Adam Roben, Sam Weinig. 6633 6634 Add Geolocation interfaces in WebKit for Windows. 6635 6636 * ForEachCoClass.h: Added WebGeolocationPosition. 6637 * Interfaces/IWebError.idl: 6638 * Interfaces/IWebGeolocationPosition.idl: Added. 6639 * Interfaces/IWebGeolocationProvider.idl: Added. 6640 * Interfaces/IWebViewPrivate.idl: 6641 * Interfaces/WebKit.idl: 6642 * WebCoreSupport/WebGeolocationControllerClient.cpp: Added. 6643 (WebGeolocationControllerClient::WebGeolocationControllerClient): 6644 (WebGeolocationControllerClient::startUpdating): 6645 (WebGeolocationControllerClient::stopUpdating): 6646 (WebGeolocationControllerClient::lastPosition): 6647 * WebCoreSupport/WebGeolocationControllerClient.h: Added. 6648 * WebGeolocationPosition.cpp: Added IWebGeolocationPosition implementation. 6649 * WebGeolocationPosition.h: Added IWebGeolocationPosition implementation. 6650 * WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPosition.idl, IWebGeolocationProvider.idl, 6651 relocated JavaScriptCoreAPITypes.idl, WebScrollbarTypes.idl 6652 * WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPosition.h/.cpp, WebGeolocationControllerClient.h/cpp, 6653 * WebKitClassFactory.cpp: Add WebGeolocationPosition include. 6654 * WebView.cpp: 6655 (WebView::initWithFrame): Create WebGeolocationControllerClient if Geolocation is enabled. 6656 (WebView::setGeolocationProvider): Added Geolocation-specific method. 6657 (WebView::geolocationProvider): Added Geolocation-specific method. 6658 (WebView::geolocationDidChangePosition): Added Geolocation-specific method. 6659 (WebView::geolocationDidFailWithError): Added Geolocation-specific method. 6660 * WebView.h: Added setGeolocationProvider, geolocationProvider, geolocationDidChangePosition, geolocationDidFailWithError. 6661 6662 2010-01-11 Jon Honeycutt <jhoneycutt (a] apple.com> 6663 6664 MSAA: Accessibility role of <select multiple> elements is wrong 6665 6666 https://bugs.webkit.org/show_bug.cgi?id=33522 6667 6668 Reviewed by Darin Adler. 6669 6670 * AccessibleBase.cpp: 6671 (MSAARole): 6672 Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA 6673 "list" and "list item" roles. 6674 6675 2010-01-08 Brent Fulgham <bfulgham (a] webkit.org> 6676 6677 Build fix, no review. 6678 6679 Protect video control logic inside ENABLE(VIDEO). 6680 6681 * WebView.cpp: 6682 (WebView::enterFullscreenForNode): 6683 (WebView::exitFullscreen): 6684 * WebView.h: 6685 6686 2010-01-08 Chris Marrin <cmarrin (a] apple.com> 6687 6688 Reviewed by Adam Roben. 6689 6690 Implement full-screen video for Windows 6691 https://bugs.webkit.org/show_bug.cgi?id=31318 6692 6693 This adds a full-screen controller, FullscreenVideoController, 6694 which manages going in and out of full-screen. The actual 6695 full-screen window is created and managed by logic added 6696 to QTMovieWin. FullscreenVideoController also creates and 6697 manages a HUD. The HUD renders and manages events to 6698 control the playing video. Movie controller events go to 6699 FullscreenVideoController which then sends them to HTMLMediaElement, 6700 which is passed to the controller by WebView, which gets the call 6701 to go into full-screen mode from HTMLMediaElement via 6702 ChromeClient. 6703 6704 I've also updated the icons so the related sets (Play/Pause and 6705 volume high/volume low/exit fullscreen) are the same size. This 6706 allows me to position them using common code. 6707 6708 * WebCoreSupport/WebChromeClient.cpp: 6709 (WebChromeClient::supportsFullscreenForNode): 6710 (WebChromeClient::enterFullscreenForNode): 6711 (WebChromeClient::exitFullscreenForNode): 6712 * WebCoreSupport/WebChromeClient.h: 6713 * WebKit.vcproj/WebKit.vcproj: 6714 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: 6715 * WebKit.vcproj/fsVideoAudioVolumeLow.png: 6716 * WebKit.vcproj/fsVideoExitFullscreen.png: 6717 * WebKit.vcproj/fsVideoPause.png: 6718 * WebKit.vcproj/fsVideoPlay.png: 6719 * WebKitDLL.cpp: 6720 (loadResourceIntoBuffer): 6721 * FullscreenVideoController.cpp: Added. 6722 * FullscreenVideoController.h: Added. 6723 * WebView.cpp: 6724 (WebView::enterFullscreenForNode): 6725 (WebView::exitFullscreen): 6726 * WebView.h: 6727 6728 2010-01-08 Brent Fulgham <bfulgham (a] webkit.org> 6729 6730 Unreviewed correction. 6731 6732 Accidentally left unnecessary modification to hdcFromContext 6733 in when landing r52995. 6734 6735 * WebFrame.cpp: 6736 (hdcFromContext): Back out unneeded modification. 6737 6738 2010-01-08 Brent Fulgham <bfulgham (a] webkit.org> 6739 6740 Reviewed by Adam Roben. 6741 6742 Use correct cairo surface data type for handling print operations. 6743 https://bugs.webkit.org/show_bug.cgi?id=33022. 6744 6745 * WebFrame.cpp: 6746 (scaleFactor): Handle 'scale = 0' case. 6747 (WebFrame::spoolPage): Use scaleFactor helper function. Account for 6748 margin size in region passed to header/footer routines. 6749 (WebFrame::spoolPages): Properly clean up Cairo surface. 6750 6751 2010-01-07 Kent Tamura <tkent (a] chromium.org> 6752 6753 Reviewed by Maciej Stachowiak. 6754 6755 Remove COM code generation files. 6756 https://bugs.webkit.org/show_bug.cgi?id=32854 6757 6758 * WebKit.vcproj/DerivedSources.make: Removed. 6759 * WebKit.vcproj/build-generated-files.sh: Removed. 6760 6761 2010-01-05 Adam Roben <aroben (a] apple.com> 6762 6763 Make IWebView::close and destroying a WebView's HWND optional for 6764 WebKit clients 6765 6766 WebView will now take care of these operations itself when its last 6767 reference is released, if they haven't already been done. 6768 6769 IWebView::close now also destroys the WebView's HWND. All WebKit 6770 clients were already performing these operations in succession anyway, 6771 or were attempting to by calling IWebView::close then destroying the 6772 WebView's host window (which actually resulted in the WebView's HWND 6773 leaking, and the crash in the below bug). 6774 6775 Fixes <rdar://problem/7374218> <http://webkit.org/b/32827> Crash when 6776 calling IWebView::close, then releasing the WebView, without calling 6777 DestroyWindow 6778 6779 Fixes a few WebViewDestruction tests, too. 6780 6781 Reviewed by Steve Falkenburg. 6782 6783 * WebView.cpp: 6784 (WebView::~WebView): Don't try to destroy m_viewWindow here. That 6785 should already have happened. Assert that this is the case. 6786 (WebView::close): If m_viewWindow isn't already being destroyed, 6787 destroy it now. Moved the call to revokeDragDrop() here from our 6788 WM_DESTROY handler because it needs to be done before m_viewWindow is 6789 nulled out. 6790 (WebView::WebViewWndProc): Removed call to revokeDragDrop() that 6791 close() now performs. 6792 (WebView::Release): If our last reference is being released, call 6793 close() so that clients don't have to. (It's harmless to call close() 6794 multiple times.) We do this here instead of in the destructor because 6795 close() can cause AddRef() and Release() to be called, and calling 6796 those from within the destructor leads to double-destruction. 6797 (WebView::setHostWindow): Removed an unnecessary (and now harmful) 6798 null-check. 6799 (WebView::revokeDragDrop): Changed an assertion into a run-time check, 6800 since this will now sometimes be called when m_viewWindow hasn't been 6801 created yet. Changed the IsWindow call to a null-check because we 6802 never hold onto a destroyed m_viewWindow. 6803 (WebView::windowAncestryDidChange): If we don't have a view window, 6804 stop tracking changes to our parent's active state. 6805 6806 2010-01-05 Adam Roben <aroben (a] apple.com> 6807 6808 Make it safe to call IWebView::close when IWebView::initWithFrame 6809 hasn't been called 6810 6811 Part of <rdar://problem/7374218> <http://webkit.org/b/32827> Crash 6812 when IWebView::close, then releasing the WebView, without calling 6813 DestroyWindow 6814 6815 Reviewed by Steve Falkenburg. 6816 6817 * WebView.cpp: 6818 (WebView::close): Null-check m_page and m_preferences before using 6819 them. They will be null if initWithFrame was never called. 6820 6821 2010-01-05 Adam Roben <aroben (a] apple.com> 6822 6823 Add assertions to catch double-destruction of WebViews earlier 6824 6825 I basically copied the m_deletionHasBegun logic from WTF::RefCounted. 6826 6827 Fixes <http://webkit.org/b/33219>. 6828 6829 Reviewed by Darin Adler. 6830 6831 * WebView.cpp: 6832 (WebView::WebView): Initialize m_deletionHasBegun 6833 (WebView::AddRef): Assert that deletion hasn't already begun. 6834 (WebView::Release): Assert that deletion hasn't already begun, then 6835 record when deletion *does* begin. 6836 6837 * WebView.h: Added m_deletionHasBegun. 6838 6839 2010-01-05 Adam Roben <aroben (a] apple.com> 6840 6841 Remove dead code in WebViewWndProc 6842 6843 Fixes <http://webkit.org/b/33218>. 6844 6845 Reviewed by Darin Adler. 6846 6847 * WebView.cpp: 6848 (WebView::WebViewWndProc): Removed a redundant isBeingDestroyed check. 6849 We bail out much earlier in this function if isBeingDestroyed is true. 6850 6851 2010-01-04 Jon Honeycutt <jhoneycutt (a] apple.com> 6852 6853 MSAA: Accessibility role of <select> elements is wrong 6854 6855 https://bugs.webkit.org/show_bug.cgi?id=33192 6856 6857 Reviewed by Sam Weinig. 6858 6859 * AccessibleBase.cpp: 6860 (MSAARole): 6861 Map WebCore::PopUpButtonRole to MSAA's ROLE_SYSTEM_COMBOBOX. 6862 6863 2010-01-04 Alexey Proskuryakov <ap (a] apple.com> 6864 6865 Reviewed by Darin Adler. 6866 6867 https://bugs.webkit.org/show_bug.cgi?id=33181 6868 The first letter is not removed properly from inline input hole 6869 6870 * WebView.cpp: (WebView::onIMEEndComposition): If composition is ended before it was 6871 confirmed, cancel it. 6872 6873 2010-01-04 Alexey Proskuryakov <ap (a] apple.com> 6874 6875 Reviewed by Darin Adler. 6876 6877 https://bugs.webkit.org/show_bug.cgi?id=33161 6878 Assertion failure in WebView when using Chinese Simplified IME 6879 6880 * WebView.cpp: (WebView::onIMERequestCharPosition): Changed the assertion into release mode 6881 check. We can't make assertions about arguments passed from outside WebKit. 6882 6883 2010-01-04 Alexey Proskuryakov <ap (a] apple.com> 6884 6885 Reviewed by Darin Adler. 6886 6887 https://bugs.webkit.org/show_bug.cgi?id=33157 6888 Implement TextInput logging channel on Windows 6889 6890 * WebKitLogging.cpp: (WebKitInitializeLoggingChannelsIfNecessary): 6891 * WebKitLogging.h: 6892 Added a TextInput channel in place of unused Network one. 6893 6894 * WebView.cpp: 6895 (WebView::WebViewWndProc): Changed onIMERequest to return result directly. We never forward 6896 it to DefWindowProc, so there is no need to return an unused boolean result for "handled". 6897 (WebView::onIMEStartComposition): Added logging. 6898 (imeCompositionArgumentNames): A helper function for detailed logging in onIMEComposition. 6899 (imeNotificationName): A helper function for detailed logging in onIMENotify. 6900 (imeRequestName): A helper function for detailed logging in onIMERequest. 6901 (WebView::onIMEComposition): Added logging. 6902 (WebView::onIMEEndComposition): Ditto. 6903 (WebView::onIMEChar): Ditto. 6904 (WebView::onIMENotify): Ditto. 6905 (WebView::onIMERequestCharPosition): Changed to return result directly. 6906 (WebView::onIMERequestReconvertString): Ditto. 6907 (WebView::onIMERequest): Changed to return result directly. Added logging. 6908 (WebView::onIMESelect): Added logging. 6909 (WebView::onIMESetContext): Added logging. 6910 6911 * WebView.h: onIMERequest functions now return result directly. 6912 6913 6914 2010-01-04 Adam Roben <aroben (a] apple.com> 6915 6916 Add WebKitAPITest 6917 6918 Fixes <http://webkit.org/b/33167>. 6919 6920 Reviewed by Sam Weinig. 6921 6922 * WebKit.vcproj/WebKit.sln: Added WebKitAPITest.vcproj. It builds just 6923 after DumpRenderTree.vcproj. 6924 6925 2010-01-04 Dan Bernstein <mitz (a] apple.com> 6926 6927 Reviewed by Ada Chan and Mark Rowe. 6928 6929 Updated copyright string 6930 6931 * WebKit.vcproj/WebKit.rc: 6932 6933 2009-12-22 Darin Adler <darin (a] apple.com> 6934 6935 Another try at fixing Windows build. 6936 6937 * WebKitPrefix.cpp: Touch it. 6938 6939 2009-12-22 Darin Adler <darin (a] apple.com> 6940 6941 Reviewed by Mark Rowe. 6942 6943 Turn off datagrid by default, at least for all platforms Apple ships. 6944 The datagrid implementation isn't ready for general web use yet. 6945 6946 * WebKit.vcproj/WebKit.vcproj: Turn off datagrid by default. 6947 6948 2009-12-21 Adam Roben <aroben (a] apple.com> 6949 6950 Fix non-ACCELERATED_COMPOSITING builds 6951 6952 * WebPreferences.cpp: 6953 (WebPreferences::acceleratedCompositingEnabled): Guard use of 6954 WKCACFLayerRenderer with USE(ACCELERATED_COMPOSITING). 6955 6956 2009-12-18 Adam Roben <aroben (a] apple.com> 6957 6958 Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled 6959 6960 Fixes <http://webkit.org/b/32745>. 6961 6962 Reviewed by Ada Chan. 6963 6964 * Interfaces/IWebPreferencesPrivate.idl: Added 6965 [set]AcceleratedCompositingEnabled. 6966 6967 * Interfaces/WebKit.idl: Touched to force a build. 6968 6969 * WebPreferenceKeysPrivate.h: Added 6970 WebKitAcceleratedCompositingEnabledPreferenceKey. 6971 6972 * WebPreferences.cpp: 6973 (WebPreferences::initializeDefaultSettings): Make accelerated 6974 compositing be on by default. 6975 (WebPreferences::setAcceleratedCompositingEnabled): Store the new 6976 value. 6977 (WebPreferences::acceleratedCompositingEnabled): If accelerated 6978 compositing isn't available, return false. Otherwise, return the value 6979 stored in preferences. 6980 6981 * WebPreferences.h: Added [set]AcceleratedCompositingAvailable. 6982 6983 * WebView.cpp: 6984 (WebView::notifyPreferencesChanged): Just pass the value from 6985 WebPreferences on down. 6986 6987 2009-12-17 Jon Honeycutt <jhoneycutt (a] apple.com> 6988 6989 MSAA: Accessibility role of list items is wrong 6990 6991 https://bugs.webkit.org/show_bug.cgi?id=32688 6992 6993 Reviewed by Adam Roben. 6994 6995 * AccessibleBase.cpp: 6996 (MSAARole): 6997 Make the WebCore list item role map to the MSAA list item role. 6998 6999 2009-12-17 Jon Honeycutt <jhoneycutt (a] apple.com> 7000 7001 MSAA: Accessibility role of list markers is wrong 7002 7003 https://bugs.webkit.org/show_bug.cgi?id=32687 7004 7005 Reviewed by Adam Roben. 7006 7007 * AccessibleBase.cpp: 7008 (MSAARole): 7009 Make the WebCore list marker role map to the MSAA static text role. 7010 7011 2009-12-18 Adam Roben <aroben (a] apple.com> 7012 7013 Add #includes needed after WebCore clean-up 7014 7015 Rubber-stamped by Anders Carlsson. 7016 7017 Fixes <http://webkit.org/b/32718>. 7018 7019 * WebCoreSupport/WebContextMenuClient.cpp: 7020 * WebDataSource.cpp: 7021 * WebHTMLRepresentation.cpp: 7022 * WebView.cpp: 7023 * WebView.h: 7024 7025 2009-12-17 Benjamin Otte <otte (a] gnome.org> 7026 7027 Reviewed by Adam Roben. 7028 7029 Don't include all JSC headers everywhere 7030 https://bugs.webkit.org/show_bug.cgi?id=32663 7031 7032 * WebCoreLocalizedStrings.cpp: Added now-needed #include of 7033 MathExtras.h. 7034 7035 2009-12-17 Adam Roben <aroben (a] apple.com> 7036 7037 Remove WebKit.sln's Debug_All and Debug_Internal configurations 7038 7039 These configurations aren't buildable by people outside of Apple, and 7040 Apple doesn't use this solution file. 7041 7042 Fixes <http://webkit.org/b/31000> Windows WebKit Build Configuration 7043 should default to Debug instead of Debug_all. 7044 7045 Rubber-stamped by Dan Bernstein. 7046 7047 * WebKit.vcproj/WebKit.sln: 7048 7049 2009-12-16 Jon Honeycutt <jhoneycutt (a] apple.com> 7050 7051 MSAA: Accessibility role of text nodes is wrong 7052 7053 https://bugs.webkit.org/show_bug.cgi?id=32631 7054 <rdar://problem/7369084> 7055 7056 Reviewed by Alice Liu. 7057 7058 * AccessibleBase.cpp: 7059 (MSAARole): 7060 If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT. 7061 (AccessibleBase::role): 7062 Call roleValueForMSAA(). 7063 7064 2009-12-14 Brent Fulgham <bfulgham (a] webkit.org> 7065 7066 Reviewed by Adam Roben. 7067 7068 Provide working printing support for WinCairo port. 7069 7070 * WebFrame.cpp: 7071 (WebFrame::spoolPage): Conditionalize initialization of 7072 PlatformGraphicsContext handling for CG vs. Cairo. 7073 (scaleFactor): Add helper function. 7074 (hdcFromContext): Add helper function. 7075 (WebFrame::drawHeader): Correct Cairo variation. 7076 (WebFrame::drawFooter): Correct Cairo variation. 7077 (WebFrame::spoolPages): Correct Cairo variation. 7078 7079 2009-12-13 Sam Weinig <sam (a] webkit.org> 7080 7081 Reviewed by Dan Bernstein. 7082 7083 Fix for https://bugs.webkit.org/show_bug.cgi?id=32499 7084 Add client based Geolocation provider 7085 7086 Add first cut of a client based Geolocation provider. This is guarded by 7087 ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a 7088 GeolocationControllerClient interface that no-one currently implements, 7089 but will in a subsequent patch. 7090 7091 * WebView.cpp: 7092 (WebView::initWithFrame): 7093 7094 2009-12-14 Adam Roben <aroben (a] apple.com> 7095 7096 Change IWebFramePrivate's vtable to be compatible with Safari 4.0.4 7097 7098 Reviewed by Steve Falkenburg. 7099 7100 Fixes <http://webkit.org/b/32433> REGRESSION (r51567): Right click on 7101 a link element crashes WebKit nightly 7102 7103 * Interfaces/IWebFramePrivate.idl: Moved pauseSVGAnimation to the end 7104 of the interface so the vtable that Safari 4.0.4 sees is unchanged. 7105 7106 2009-12-14 Adam Roben <aroben (a] apple.com> 7107 7108 Build fix 7109 7110 * WebKit.vcproj/WebKit.vcproj: Added $(DXSDK_DIR)\Lib\x86 to the 7111 libpath for all non-Cairo configurations (it was missing from most of 7112 them). 7113 7114 2009-12-11 Chris Marrin <cmarrin (a] apple.com> 7115 7116 Reviewed by Jon Honeycutt. 7117 7118 Added icons for full-screen video on Windows 7119 https://bugs.webkit.org/show_bug.cgi?id=31318 7120 7121 * WebKit.vcproj/WebKit.rc: 7122 * WebKit.vcproj/WebKit.vcproj: 7123 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Added. 7124 * WebKit.vcproj/fsVideoAudioVolumeLow.png: Added. 7125 * WebKit.vcproj/fsVideoExitFullscreen.png: Added. 7126 * WebKit.vcproj/fsVideoPause.png: Added. 7127 * WebKit.vcproj/fsVideoPlay.png: Added. 7128 * WebKit.vcproj/resource.h: 7129 7130 2009-12-11 Chris Marrin <cmarrin (a] apple.com> 7131 7132 Reviewed by Adam Roben. 7133 7134 Delay load DLLs for accelerated compositing 7135 https://bugs.webkit.org/show_bug.cgi?id=31856 7136 7137 If the DLLs (d3d9 and QuartzCore). are not present it 7138 turns off accelerated compositing and avoids calling 7139 any of the functions in the DLLs. 7140 7141 * WebView.cpp: 7142 (WebView::notifyPreferencesChanged): 7143 7144 2009-12-10 Jon Honeycutt <jhoneycutt (a] apple.com> 7145 7146 Pass more information about a plug-in to the PluginHalterDelegate 7147 7148 Reviewed by Adam Roben. 7149 7150 * Interfaces/IWebPluginHalterDelegate.idl: 7151 Add new parameters. 7152 7153 * WebCoreSupport/WebPluginHalterClient.cpp: 7154 (WebPluginHalterClient::shouldHaltPlugin): 7155 Update for new parameters. Pass them when making the delegate call. 7156 7157 * WebCoreSupport/WebPluginHalterClient.h: 7158 Update for new parameters. 7159 7160 2009-12-09 Brent Fulgham <bfulgham (a] webkit.org> 7161 7162 Revert incorrect commit-box update r51911. 7163 It mistakenly set the selectAll implementation in the 7164 deslectAll method. 7165 7166 * WebFrame.cpp: 7167 (WebFrame::deselectAll): 7168 7169 2009-12-09 Brent Fulgham <bfulgham (a] webkit.org> 7170 7171 Reviewed by Darin Adler. 7172 7173 Provide an implementation for 'selectAll' 7174 https://bugs.webkit.org/show_bug.cgi?id=32296 7175 7176 * WebFrame.cpp: 7177 (WebFrame::selectAll): Implement "SelectAll" command. 7178 7179 2009-12-09 Brent Fulgham <bfulgham (a] webkit.org> 7180 7181 Reviewed by Darin Adler. 7182 7183 Provide an implementation for 'selectAll' 7184 https://bugs.webkit.org/show_bug.cgi?id=32296 7185 7186 * WebFrame.cpp: 7187 (WebFrame::selectAll): Implement "SelectAll" command. 7188 7189 2009-12-08 Chris Marrin <cmarrin (a] apple.com> 7190 7191 Reviewed by Adam Roben. 7192 7193 Delay load DLLs for accelerated compositing 7194 https://bugs.webkit.org/show_bug.cgi?id=31856 7195 7196 If the DLLs (d3d9 and QuartzCore). are not present it 7197 turns off accelerated compositing and avoids calling 7198 any of the functions in the DLLs. 7199 7200 * WebView.cpp: 7201 * WebView.h: 7202 7203 2009-12-08 Adam Roben <aroben (a] apple.com> 7204 7205 Windows build fix 7206 7207 * Interfaces/WebKit.idl: Touched this to force Interfaces.vcproj to rebuild. 7208 7209 2009-12-08 John Sullivan <sullivan (a] apple.com> 7210 7211 Reviewed by Dan Bernstein 7212 7213 Split two-clause assertions into two separate assertions. 7214 7215 * DOMHTMLClasses.cpp: 7216 (DOMHTMLInputElement::isTextField): 7217 Split a two-clause assertion into two separate assertions. 7218 (DOMHTMLInputElement::rectOnScreen): 7219 Added the two assertions here that all other functions in this group shared. 7220 (DOMHTMLInputElement::selectedRange): 7221 Split a two-clause assertion into two separate assertions. 7222 (DOMHTMLInputElement::setAutofilled): 7223 Split a two-clause assertion into two separate assertions. 7224 (DOMHTMLInputElement::isAutofilled): 7225 Split a two-clause assertion into two separate assertions. 7226 7227 2009-12-08 Nikolas Zimmermann <nzimmermann (a] rim.com> 7228 7229 Rubber-stamped by Maciej Stachowiak. 7230 7231 Turn on (SVG) Filters for Win. 7232 https://bugs.webkit.org/show_bug.cgi?id=32224 7233 7234 * WebKit.vcproj/WebKit.vcproj: 7235 7236 2009-12-08 John Sullivan <sullivan (a] apple.com> 7237 7238 Add isAutofilled getter to match existing setter. 7239 7240 Reviewed by Ada Chan. 7241 7242 * DOMHTMLClasses.cpp: 7243 (DOMHTMLInputElement::isAutofilled): 7244 Implemented new cover function. 7245 7246 * DOMHTMLClasses.h: 7247 Declared new cover function. 7248 7249 * Interfaces/DOMPrivate.idl: 7250 Declared new interface. 7251 7252 2009-12-07 Gavin Barraclough <barraclough (a] apple.com> 7253 7254 Reviewed by NOBODY (Windows build fix part III). 7255 7256 * WebView.cpp: 7257 (WebView::stringByEvaluatingJavaScriptFromString): 7258 7259 2009-12-07 Gavin Barraclough <barraclough (a] apple.com> 7260 7261 Reviewed by NOBODY (Windows build fix part II). 7262 7263 * WebView.cpp: 7264 (WebView::stringByEvaluatingJavaScriptFromString): 7265 7266 2009-12-03 Brady Eidson <beidson (a] apple.com> 7267 7268 Reviewed by Sam Weinig. 7269 7270 <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API 7271 7272 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: 7273 * WebCoreSupport/WebFrameLoaderClient.cpp: 7274 (WebFrameLoaderClient::dispatchDidPushStateWithinPage): 7275 (WebFrameLoaderClient::dispatchDidReplaceStateWithinPage): 7276 (WebFrameLoaderClient::dispatchDidPopStateWithinPage): 7277 * WebCoreSupport/WebFrameLoaderClient.h: 7278 7279 2009-12-03 Pavel Feldman <pfeldman (a] dhcp-172-28-174-220.spb.corp.google.com> 7280 7281 Reviewed by Timothy Hatcher. 7282 7283 Web Inspector: Simplify the settings support in inspector controller. 7284 7285 https://bugs.webkit.org/show_bug.cgi?id=32076 7286 7287 * WebCoreSupport/WebInspectorClient.cpp: 7288 (WebInspectorClient::attachWindow): 7289 (WebInspectorClient::detachWindow): 7290 (WebInspectorClient::showWindowWithoutNotifications): 7291 * WebCoreSupport/WebInspectorClient.h: 7292 7293 2009-12-03 Ben Murdoch <benm (a] google.com> 7294 7295 Reviewed by Brady Eidson. 7296 7297 [Android] The FrameLoaderClient is unaware of BackForwardList changes. 7298 https://bugs.webkit.org/show_bug.cgi?id=31914 7299 7300 * WebCoreSupport/WebFrameLoaderClient.cpp: 7301 (WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug). 7302 (WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto. 7303 (WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto. 7304 * WebCoreSupport/WebFrameLoaderClient.h: 7305 7306 2009-12-02 Timothy Hatcher <timothy (a] apple.com> 7307 7308 Move setValueForUser to the end of the DOMHTMLInputElement interface 7309 so it is fine for binary compatibility. 7310 7311 Directed by Steve Falkenburg. 7312 7313 * Interfaces/DOMHTML.idl: 7314 7315 2009-12-02 Timothy Hatcher <timothy (a] apple.com> 7316 7317 Expose setValueForUser for the COM DOMHTMLInputElement. 7318 7319 <rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript 7320 7321 Reviewed by Dan Bernstein. 7322 7323 * DOMHTMLClasses.cpp: 7324 (DOMHTMLInputElement::setValueForUser): 7325 * Interfaces/DOMHTML.idl: 7326 7327 2009-12-01 Nikolas Zimmermann <nzimmermann (a] rim.com> 7328 7329 Not reviewed. Try to fix windows build. 7330 7331 * WebFrame.cpp: 7332 7333 2009-12-01 Nikolas Zimmermann <nzimmermann (a] rim.com> 7334 7335 Reviewed by Simon Fraser. 7336 7337 Add SVG animation test framework with 'snapshot' functionality 7338 https://bugs.webkit.org/show_bug.cgi?id=31897 7339 7340 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method, 7341 forwarding the call to SVGDocumentExtensions, if SVG is enabled. 7342 7343 Implemented just like the existing pauseAnimation* methods for CSS animations. 7344 7345 * Interfaces/IWebFramePrivate.idl: 7346 * WebFrame.cpp: 7347 (WebFrame::pauseSVGAnimation): 7348 * WebFrame.h: 7349 7350 2009-11-30 Adam Roben <aroben (a] apple.com> 7351 7352 Fix double-free of BSTRs passed to WebNavigationData::createInstance 7353 7354 WebFrameLoaderClient::updateGlobalHistory was converting 7355 WebCore::Strings to WebCore::BStrings, then passing them to 7356 WebNavigationData::createInstance. But the latter function takes BSTR 7357 parameters and adopts them into WebCore::BStrings. So the end result 7358 was that two WebCore::BStrings would end up freeing each underlying 7359 BSTR. 7360 7361 The fix is to only convert to WebCore::BString inside 7362 WebNavigationData. 7363 7364 Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION 7365 (r49564): Crash in updateGlobalHistory when running Javascript iBench 7366 test 7367 7368 I couldn't find a way to reproduce this in DumpRenderTree. 7369 7370 Reviewed by Steve Falkenburg. 7371 7372 * WebCoreSupport/WebFrameLoaderClient.cpp: 7373 (WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to 7374 WebNavigationData::createInstance. 7375 7376 * WebNavigationData.cpp: 7377 (WebNavigationData::WebNavigationData): 7378 (WebNavigationData::createInstance): 7379 * WebNavigationData.h: 7380 Changed to take const WebCore::String&s instead of BSTRs and to 7381 convert the Strings to BStrings at this level. 7382 7383 2009-11-30 Steve Falkenburg <sfalken (a] apple.com> 7384 7385 Reviewed by Adam Roben. 7386 7387 WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject 7388 https://bugs.webkit.org/show_bug.cgi?id=31986 7389 7390 * WebFrame.cpp: 7391 (WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned. 7392 7393 2009-11-24 Chris Marrin <cmarrin (a] apple.com> 7394 7395 Another Windows build fix 7396 7397 Got rid of d3d.lib and d3dx9.lib dependency. Not needed until 7398 we turn on ACCELERATED_COMPOSITING 7399 7400 * WebKit.vcproj/WebKit.vcproj: 7401 7402 2009-11-24 Chris Marrin <cmarrin (a] apple.com> 7403 7404 Fixed Windows build 7405 7406 Got rid of QuartzCore.lib dependency. Not needed until 7407 we turn on ACCELERATED_COMPOSITING 7408 7409 * WebKit.vcproj/WebKit.vcproj: 7410 7411 2009-11-24 Chris Marrin <cmarrin (a] apple.com> 7412 7413 Reviewed by Simon Fraser. 7414 7415 Implement accelerated compositing 7416 https://bugs.webkit.org/show_bug.cgi?id=27314 7417 7418 This is the WebKit side of the implementation. It plumbs the root layer 7419 from WebCore. It also makes changes to WebView which places the 7420 backing store of the page into the root compositing layer so it is 7421 properly composited with all the other layers. This deals with resizing, 7422 scrolling, and incremental repaint of the page. 7423 7424 * WebCoreSupport/WebChromeClient.cpp: 7425 (WebChromeClient::attachRootGraphicsLayer): 7426 (WebChromeClient::scheduleCompositingLayerSync): 7427 * WebCoreSupport/WebChromeClient.h: 7428 (WebChromeClient::setNeedsOneShotDrawingSynchronization): 7429 * WebKit.vcproj/WebKit.vcproj: 7430 * WebView.cpp: 7431 (WebView::WebView): 7432 (WebView::close): 7433 (WebView::repaint): 7434 (WebView::scrollBackingStore): 7435 (WebView::paint): 7436 (WebViewWndProc): 7437 (WebView::setRootChildLayer): 7438 (WebView::setAcceleratedCompositing): 7439 (WebView::setRootLayerContents): 7440 * WebView.h: 7441 (WebView::isAcceleratedCompositing): 7442 (WebView::resizeLayerWindow): 7443 (WebView::layerWindowBecameVisible): 7444 (WebView::setRootLayerNeedsDisplay): 7445 7446 2009-11-23 Laszlo Gombos <laszlo.1.gombos (a] nokia.com> 7447 7448 Reviewed by Kenneth Rohde Christiansen. 7449 7450 Include "config.h" to meet Coding Style Guidelines 7451 https://bugs.webkit.org/show_bug.cgi?id=31792 7452 7453 * GEN_DOMObject.cpp: 7454 * WebScriptObject.cpp: 7455 7456 2009-11-21 Jon Honeycutt <jhoneycutt (a] apple.com> 7457 7458 Windows build fix. Unreviewed. 7459 7460 * Interfaces/IWebSerializedJSValue.idl: 7461 7462 2009-11-20 Jon Honeycutt <jhoneycutt (a] apple.com> 7463 7464 DOMElement::tagName() is unimplemented 7465 7466 https://bugs.webkit.org/show_bug.cgi?id=31746 7467 7468 Reviewed by Darin Adler. 7469 7470 * DOMCoreClasses.cpp: 7471 (DOMElement::tagName): 7472 Create a BString from the element's tag name, and release its BSTR 7473 into result. 7474 7475 2009-11-20 Jon Honeycutt <jhoneycutt (a] apple.com> 7476 7477 DOMNode::childNodes() is unimplemented 7478 7479 https://bugs.webkit.org/show_bug.cgi?id=31745 7480 7481 Reviewed by Darin Adler. 7482 7483 * DOMCoreClasses.cpp: 7484 (DOMNode::childNodes): 7485 Create a DOMNodeList from the node's child nodes. 7486 7487 2009-11-20 Dave Hyatt <hyatt (a] apple.com> 7488 7489 Reviewed by Jon Honeycutt. 7490 7491 Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the 7492 serialization into a separate serialize() function that can be called after the object has been 7493 created. 7494 7495 Fix a typo in serialize() caused when fixing build bustage (put a ! back in). 7496 7497 * Interfaces/IWebSerializedJSValue.idl: 7498 * WebSerializedJSValue.cpp: 7499 (WebSerializedJSValue::WebSerializedJSValue): 7500 (WebSerializedJSValue::createInstance): 7501 (WebSerializedJSValue::serialize): 7502 (WebSerializedJSValue::deserialize): 7503 * WebSerializedJSValue.h: 7504 7505 2009-11-20 Brian Weinstein <bweinstein (a] apple.com> 7506 7507 Reviewed by Dave Hyatt. 7508 7509 Another go at the Windows Build Fix - this is a couple steps of it, 7510 so a little more involved than most build fixes. 7511 7512 * Interfaces/IWebSerializedJSValue.idl: 7513 * Interfaces/JavaScriptCoreAPITypes.idl: 7514 * WebKit.vcproj/Interfaces.vcproj: 7515 * WebSerializedJSValue.cpp: 7516 (WebSerializedJSValue::deserialize): 7517 * WebSerializedJSValue.h: 7518 7519 2009-11-20 Brian Weinstein <bweinstein (a] apple.com> 7520 7521 Reviewed by Dave Hyatt. 7522 7523 Build fix for Windows - only declare JSContextRef once, instead 7524 of in two different idl files. Create a new file to hold the 7525 definition of JSContextRef. 7526 7527 * Interfaces/IWebFrameLoadDelegate.idl: 7528 * Interfaces/IWebSerializedJSValue.idl: 7529 * Interfaces/JavaScriptCoreAPITypes.idl: Added. 7530 * Interfaces/WebKit.idl: 7531 * WebKit.vcproj/Interfaces.vcproj: 7532 7533 2009-11-20 Dave Hyatt <hyatt (a] apple.com> 7534 7535 Reviewed by Oliver Hunt and Jon Honeycutt. 7536 7537 Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore 7538 and exposes the ability to do JS value serialization/deserialization to WebKit clients. 7539 7540 * Interfaces/IWebSerializedJSValue.idl: Added. 7541 * Interfaces/WebKit.idl: 7542 * WebKit.vcproj/WebKit.vcproj: 7543 * WebSerializedJSValue.cpp: Added. 7544 (WebSerializedJSValue::WebSerializedJSValue): 7545 (WebSerializedJSValue::~WebSerializedJSValue): 7546 (WebSerializedJSValue::createInstance): 7547 (WebSerializedJSValue::AddRef): 7548 (WebSerializedJSValue::Release): 7549 (WebSerializedJSValue::QueryInterface): 7550 (WebSerializedJSValue::deserialize): 7551 * WebSerializedJSValue.h: Added. 7552 7553 2009-11-19 Alexey Proskuryakov <ap (a] apple.com> 7554 7555 Reviewed by Darin Adler. 7556 7557 https://bugs.webkit.org/show_bug.cgi?id=31690 7558 Make SocketStreamHandleCFNet work on Windows 7559 7560 * WebDownloadCFNet.cpp: 7561 (WebDownload::init): 7562 (WebDownload::initWithRequest): 7563 (WebDownload::initToResumeWithBundle): 7564 Update for loaderRunLoop() now being in its own header. 7565 7566 2009-11-19 Eric Carlson <eric.carlson (a] apple.com> 7567 7568 Reviewed by Dan Bernstein. 7569 7570 <rdar://problem/7035231> 7571 Support closed caption in <video> element 7572 7573 * WebCoreLocalizedStrings.cpp: 7574 (WebCore::localizedMediaControlElementString): 7575 (WebCore::localizedMediaControlElementHelpText): 7576 Add accessibility help strings for media controller closed caption button. 7577 7578 2009-11-18 Michelangelo De Simone <micdesim (a] gmail.com> 7579 7580 Reviewed by Darin Adler. 7581 7582 Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>. 7583 Support for validationMessage attribute, as per HTML5 specs. 7584 7585 * WebCoreLocalizedStrings.cpp: 7586 (WebCore::validationMessageValueMissingText): 7587 (WebCore::validationMessageTypeMismatchText): 7588 (WebCore::validationMessagePatternMismatchText): 7589 (WebCore::validationMessageTooLongText): 7590 (WebCore::validationMessageRangeUnderflowText): 7591 (WebCore::validationMessageRangeOverflowText): 7592 (WebCore::validationMessageStepMismatchText): 7593 7594 2009-11-18 Daniel Bates <dbates (a] webkit.org> 7595 7596 Reviewed by Darin Adler. 7597 7598 https://bugs.webkit.org/show_bug.cgi?id=31186 7599 7600 Changes associated with renaming RenderTextControl::isUserEdited. 7601 7602 * DOMHTMLClasses.cpp: 7603 (DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited. 7604 (DOMHTMLTextAreaElement::isUserEdited): Ditto. 7605 7606 2009-11-12 Jon Honeycutt <jhoneycutt (a] apple.com> 7607 7608 Implement DOMHTMLInputElement::replaceCharactersInRange(). 7609 7610 https://bugs.webkit.org/show_bug.cgi?id=31492 7611 7612 Reviewed by Dan Bernstein. 7613 7614 * DOMHTMLClasses.cpp: 7615 (DOMHTMLInputElement::replaceCharactersInRange): 7616 Get the text of the input field. Replace the given range with the 7617 replacement text, and set this new string as the input element's value. 7618 Select from index to the end of the field. This matches the 7619 implementation in the Obj-C bindings. 7620 7621 2009-11-12 Jon Honeycutt <jhoneycutt (a] apple.com> 7622 7623 DOMHTMLOptionElement is missing some functionality. 7624 7625 https://bugs.webkit.org/show_bug.cgi?id=31491 7626 7627 Reviewed by Dan Bernstein. 7628 7629 * DOMHTMLClasses.cpp: 7630 (DOMHTMLOptionElement::text): 7631 Cast m_element to an HTMLOptionElement, and call its text() function. 7632 (DOMHTMLOptionElement::label): 7633 Ditto, for label(). 7634 7635 2009-11-12 Jon Honeycutt <jhoneycutt (a] apple.com> 7636 7637 DOMHTMLSelectElement is missing some implementation. 7638 7639 https://bugs.webkit.org/show_bug.cgi?id=31489 7640 7641 Reviewed by Dan Bernstein. 7642 7643 * DOMHTMLClasses.cpp: 7644 (DOMHTMLSelectElement::options): 7645 Cast m_element to an HTMLSelectElement. If it has no options, return 7646 E_FAIL. Otherwise, create a DOMHTMLOptionsCollection to wrap the 7647 options, and return it. 7648 (DOMHTMLSelectElement::activateItemAtIndex): 7649 If the index is out of bounds, return E_FAIL. Otherwise, select the 7650 item. 7651 7652 2009-11-12 Jon Honeycutt <jhoneycutt (a] apple.com> 7653 7654 DOMHTMLOptionsCollection is missing some implementation. 7655 7656 https://bugs.webkit.org/show_bug.cgi?id=31488 7657 7658 Reviewed by Dan Bernstein. 7659 7660 * DOMHTMLClasses.cpp: 7661 (DOMHTMLOptionsCollection::DOMHTMLOptionsCollection): 7662 Initialize m_collection. 7663 (DOMHTMLOptionsCollection::createInstance): 7664 Create a DOMHTMLOptionsCollection. If we fail to query for 7665 IDOMHTMLOptionsCollection, delete it, and return 0. Otherwise, return 7666 the result. 7667 (DOMHTMLOptionsCollection::length): 7668 (DOMHTMLOptionsCollection::item): 7669 Create a DOMNode for the WebCore Node. If this is 0, return E_FAIL. 7670 (DOMHTMLOptionsCollection::namedItem): 7671 Correct the signature of this function. 7672 7673 * DOMHTMLClasses.h: 7674 Declare DOMHTMLOptionsCollection::createInstance(). Correct the 7675 signature of namedItem() to match IDOMHTMLOptionsCollection. Add a 7676 member to DOMHTMLOptionsCollection to hold the WebCore object. 7677 7678 2009-11-12 Jon Honeycutt <jhoneycutt (a] apple.com> 7679 7680 DOMHTMLInputElement::rectOnScreen() returns the wrong rect 7681 7682 https://bugs.webkit.org/show_bug.cgi?id=31487 7683 7684 Reviewed by Darin Adler. 7685 7686 * DOMHTMLClasses.cpp: 7687 (DOMHTMLInputElement::rectOnScreen): 7688 Return the rect on screen, not the rect in the window. 7689 7690 2009-11-17 Brent Fulgham <bfulgham (a] webkit.org> 7691 7692 Reviewed by NOBODY - Build Fix. 7693 7694 Correct build error in Debug_Cairo target after @49705. 7695 7696 * WebKit.vcproj/WebKit.vcproj: Revise JavaScriptCore.lib 7697 dependency to have proper "_debug" suffix needed by 7698 the Debug_Cairo target. 7699 7700 2009-11-17 Brian Weinstein <bweinstein (a] apple.com> 7701 7702 Reviewed by NOBODY - Build Fix. 7703 7704 Touch files to try to fix the build. 7705 7706 * Interfaces/IWebInspector.idl: 7707 * Interfaces/WebKit.idl: 7708 * WebKit.vcproj/Interfaces.vcproj: 7709 7710 2009-11-17 Pavel Feldman <pfeldman (a] chromium.org> 7711 7712 Reviewed by Timothy Hatcher. 7713 7714 Web Inspector: Make DRT show web inspector for tests in inspector/ folder. 7715 - Updated DRT to show/close inspector for all tests under /inspector 7716 - Introduced LayoutTestController::setTimelineProfilingEnabled and 7717 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled 7718 - Removed reload on each inspector test 7719 - Renamed fast/inspector to fast/inspector-support in order not to trigger 7720 inspector for those. 7721 - Reimplemented timeline tests in order to get rid of reload there. 7722 - Moved tests that don't require harness into the fast group. 7723 7724 https://bugs.webkit.org/show_bug.cgi?id=31472 7725 7726 * Interfaces/IWebInspector.idl: 7727 * WebInspector.cpp: 7728 (WebInspector::isTimelineProfilingEnabled): 7729 (WebInspector::setTimelineProfilingEnabled): 7730 * WebInspector.h: 7731 7732 2009-11-13 Adam Roben <aroben (a] apple.com> 7733 7734 Build fix 7735 7736 * Interfaces/WebKit.idl: Touch this to force interfaces to rebuild. 7737 7738 2009-11-13 Adam Roben <aroben (a] apple.com> 7739 7740 Tell the WebFrameLoadDelegate when window objects in isolated worlds 7741 are cleared 7742 7743 Fixes <http://webkit.org/b/31124>. 7744 7745 Reviewed by Dave Hyatt. 7746 7747 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added 7748 didClearWindowObjectForFrameInScriptWorld. 7749 7750 * WebFrame.cpp: 7751 (WebFrame::dispatchDidClearWindowObjectInWorld): 7752 * WebFrame.h: 7753 Replaced windowObjectCleared with this function. If the delegate 7754 implements IWebFrameLoadDelegatePrivate2, call 7755 didClearWindowObjectForFrameInScriptWorld. Otherwise, if the passed-in 7756 world is the mainThreadNormalWorld(), call 7757 didClearWindowObjectForFrame. 7758 7759 * WebScriptWorld.cpp: 7760 (allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in 7761 existence. 7762 (WebScriptWorld::WebScriptWorld): Add ourselves to allWorlds(). 7763 (WebScriptWorld::~WebScriptWorld): Remove ourselves from allWorlds(). 7764 (WebScriptWorld::standardWorld): Added this non-COM getter for the 7765 standard world, which the COM getter now calls through to. 7766 (WebScriptWorld::findOrCreateWorld): Added. Returns the existing 7767 WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't 7768 already exist. 7769 7770 * WebScriptWorld.h: Added new standardWorld overload, made one 7771 overload of createInstance private, and added findOrCreateWorld. 7772 7773 2009-11-13 Adam Roben <aroben (a] apple.com> 7774 7775 Build fix 7776 7777 * Interfaces/WebKit.idl: Un-sort the #includes again. Apparently they 7778 are order-dependent! 7779 7780 2009-11-13 Adam Roben <aroben (a] apple.com> 7781 7782 Touch WebKit.idl to fix the Windows build 7783 7784 * Interfaces/WebKit.idl: Sorted #includes. 7785 7786 2009-11-13 Adam Roben <aroben (a] apple.com> 7787 7788 Finish replacing worldIDs with world objects 7789 7790 The only remaining use of worldIDs was in a method only used by DRT 7791 for the isolated worlds tests. 7792 7793 Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects 7794 7795 Reviewed by Mark Rowe. 7796 7797 * Interfaces/IWebFramePrivate.idl: 7798 * WebFrame.cpp: 7799 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): 7800 * WebFrame.h: 7801 Renamed from stringByEvaluatingJavaScriptInIsolatedWorld. Now takes an 7802 IWebScriptWorld instead of a worldID, so we don't need to maintain a 7803 map of worldID -> world anymore. 7804 7805 2009-11-12 Shinichiro Hamaji <hamaji (a] chromium.org> 7806 7807 Reviewed by Darin Adler. 7808 7809 externalRepresentation should take Frame as the argument 7810 https://bugs.webkit.org/show_bug.cgi?id=31393 7811 7812 No new tests as this is just a refactoring. 7813 7814 * WebFrame.cpp: 7815 (WebFrame::renderTreeAsExternalRepresentation): 7816 7817 2009-11-12 Adam Roben <aroben (a] apple.com> 7818 7819 Replace worldIDs with world objects 7820 7821 WebScriptWorld is the new object that represents a world. The only 7822 place worldID is still used is in 7823 IWebFramePrivate::stringByEvaluatingJavaScriptInIsolatedWorld, but 7824 that will change soon. 7825 7826 Part of <http://webkit.org/b/31414> Implement new SPI for dealing with 7827 user scripts/stylesheets and isolated worlds 7828 7829 Reviewed by Sam Weinig. 7830 7831 * ForEachCoClass.h: Added WebScriptWorld. 7832 7833 * Interfaces/IWebFramePrivate.idl: Replaced contextForWorldID with 7834 contextForWorld. 7835 7836 * Interfaces/IWebScriptWorld.idl: Added. 7837 7838 * Interfaces/IWebViewPrivate.idl: Changed the user script/stylesheet 7839 functions to take an IWebScriptWorld instead of a worldID. 7840 7841 * Interfaces/WebKit.idl: Added WebScriptWorld. 7842 7843 * WebFrame.cpp: 7844 (WebFrame::contextForWorld): Renamed from contextForWorldID. Now takes 7845 an IWebScriptWorld. 7846 (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): Moved the 7847 bizarre world caching/creation logic that DRT depends on here from the 7848 findWorld function in ScriptController.cpp. Updated to use 7849 ScriptController::executeScriptInWorld instead of 7850 ScriptController::executeScriptInIsolatedWorld. 7851 7852 * WebFrame.h: Replaced contextForWorldID with contextForWorld. 7853 7854 * WebScriptWorld.cpp: Added. 7855 (WebScriptWorld::WebScriptWorld): 7856 (WebScriptWorld::~WebScriptWorld): 7857 (WebScriptWorld::createInstance): 7858 (WebScriptWorld::AddRef): 7859 (WebScriptWorld::Release): 7860 (WebScriptWorld::QueryInterface): 7861 Standard COM class implementations. 7862 7863 (WebScriptWorld::standardWorld): Returns a shared instance that represents 7864 WebCore's mainThreadNormalWorld(). 7865 7866 * WebScriptWorld.h: Added. 7867 (WebScriptWorld::world): Simple getter. 7868 7869 * WebKit.vcproj/Interfaces.vcproj: Added IWebScriptWorld.idl. 7870 7871 * WebKit.vcproj/WebKit.vcproj: Added WebScriptWorld. 7872 7873 * WebKitClassFactory.cpp: Added WebScriptWorld. 7874 7875 * WebView.cpp: 7876 (WebView::addUserScriptToGroup): 7877 (WebView::addUserStyleSheetToGroup): 7878 (WebView::removeUserScriptFromGroup): 7879 (WebView::removeUserStyleSheetFromGroup): 7880 (WebView::removeUserScriptsFromGroup): 7881 (WebView::removeUserStyleSheetsFromGroup): 7882 * WebView.h: 7883 Changed these functions to take an IWebScriptWorld instead of a worldID. 7884 7885 2009-11-12 Adam Roben <aroben (a] apple.com> 7886 7887 Small clean-up in WebView's user content functions 7888 7889 Preparation for <http://webkit.org/b/31414> Implement new SPI for 7890 dealing with user scripts/stylesheets and isolated worlds 7891 7892 Reviewed by Dave Hyatt. 7893 7894 * WebView.cpp: 7895 (toString): 7896 (toKURL): 7897 Added these helper functions to convert BSTRs to WebCore types. 7898 7899 (toStringVector): 7900 (WebView::addUserScriptToGroup): 7901 (WebView::addUserStyleSheetToGroup): 7902 (WebView::removeUserScriptFromGroup): 7903 (WebView::removeUserStyleSheetFromGroup): 7904 (WebView::removeUserScriptsFromGroup): 7905 (WebView::removeUserStyleSheetsFromGroup): 7906 (WebView::removeAllUserContentFromGroup): 7907 Use the new helper functions. 7908 7909 2009-11-11 Beth Dakin <bdakin (a] apple.com> 7910 7911 Build fix. No review needed. 7912 7913 * WebKitGraphics.cpp: 7914 (WebDrawText): 7915 7916 2009-11-10 Daniel Bates <dbates (a] webkit.org> 7917 7918 Reviewed by Oliver Hunt. 7919 7920 https://bugs.webkit.org/show_bug.cgi?id=30754 7921 7922 Modified WebDropSource::QueryContinueDrag so as to not call EventHandler::dragSourceMovedTo. 7923 7924 * WebDropSource.cpp: 7925 (WebDropSource::QueryContinueDrag): Removed call to EventHandler::dragSourceMovedTo. 7926 7927 2009-11-10 Alexey Proskuryakov <ap (a] apple.com> 7928 7929 Reviewed by Dan Bernstein. 7930 7931 https://bugs.webkit.org/show_bug.cgi?id=31312 7932 Decouple authentication panel callbacks from ResourceHandle 7933 7934 * WebCoreSupport/WebFrameLoaderClient.cpp: 7935 (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): 7936 * WebURLAuthenticationChallenge.cpp: 7937 (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): 7938 (WebURLAuthenticationChallenge::sender): 7939 * WebURLAuthenticationChallengeSender.cpp: 7940 (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender): 7941 (WebURLAuthenticationChallengeSender::createInstance): 7942 (WebURLAuthenticationChallengeSender::authenticationClient): 7943 * WebURLAuthenticationChallengeSender.h: 7944 * WebURLAuthenticationChallengeSenderCFNet.cpp: 7945 (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge): 7946 (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge): 7947 (WebURLAuthenticationChallengeSender::useCredential): 7948 Adjusted for WebCore changes. 7949 7950 2009-11-10 Brian Weinstein <bweinstein (a] apple.com> 7951 7952 Reviewed by NOBODY - Build Fix. 7953 7954 Updated fillRoundedRect to take a ColorSpace argument. 7955 7956 * WebCoreSupport/WebDragClient.cpp: 7957 (WebDragClient::createDragImageForLink): 7958 7959 2009-11-08 Janne Koskinen <janne.p.koskinen (a] digia.com> 7960 7961 Reviewed by Holger Freyther. 7962 7963 ResourceRequest to be class instead of struct 7964 https://bugs.webkit.org/show_bug.cgi?id=30670 7965 7966 Started as a compilation fix for Symbian where the compiler makes a distinction between 7967 class and struct in function argument signatures. 7968 Changed forward declaration of ResourceRequest to have class in the forward 7969 declaration instead of struct. 7970 7971 * WebDownload.h: 7972 7973 2009-11-05 Adam Roben <aroben (a] apple.com> 7974 7975 Make CFDictionaryPropertyBag::createInstance return a COMPtr 7976 7977 I also cleaned up CFDictionaryPropertyBag's class declaration a little 7978 while I was at it. 7979 7980 Part of <http://webkit.org/b/25294> <rdar://problem/6803127> All 7981 WebKit/win classes should return COMPtrs from their static constructor 7982 members 7983 7984 Reviewed by Steve Falkenburg. 7985 7986 * CFDictionaryPropertyBag.cpp: 7987 (CFDictionaryPropertyBag::CFDictionaryPropertyBag): Changed to 7988 initialize m_refCount to 0. m_refCount gets increased to 1 by 7989 createInstance. 7990 (CFDictionaryPropertyBag::createInstance): Changed to return a COMPtr. 7991 7992 * CFDictionaryPropertyBag.h: 7993 - Updated copyright years 7994 - Fixed header guard to match current style 7995 - Replaced #include of CoreFoundation.h with forward-declaration of 7996 CFMutableDictionaryRef 7997 - Added #include of COMPtr.h 7998 - Fixed opening brace placement in class declaration 7999 - Made createInstance return a COMPtr 8000 - Made constructor/destructor private 8001 - Made QueryInterface and IPropertyBag functions private 8002 - Removed unnecessary parameter names and MIDL comments 8003 8004 * WebCache.cpp: 8005 (WebCache::statistics): Updated for change to 8006 CFDictionaryPropertyBag::createInstance. Now uses releaseRef to place 8007 the IPropertyBag pointers into the s array. 8008 8009 * WebCoreSupport/WebFrameLoaderClient.cpp: 8010 (WebFrameLoaderClient::dispatchDidFailToStartPlugin): 8011 * WebDatabaseManager.cpp: 8012 (WebDatabaseManager::dispatchDidModifyDatabase): 8013 * WebFrame.cpp: 8014 (WebFrame::createJavaAppletWidget): 8015 Updated for change to CFDictionaryPropertyBag::createInstance. 8016 8017 * WebHistory.cpp: Removed releaseUserInfo, which is no longer needed. 8018 That function was also doing an unnecessary call to setDictionary(0). 8019 (createUserInfoFromArray): 8020 (createUserInfoFromHistoryItem): 8021 Changed to return COMPtr. 8022 8023 (WebHistory::loadFromURL): Updated for change to 8024 CFDictionaryPropertyBag::createInstance. 8025 8026 (WebHistory::removeAllItems): Updated for change to 8027 CFDictionaryPropertyBag::createInstance, which fixed a leak! We had 8028 forgotten to call releaseUserInfo here. 8029 8030 (WebHistory::removeItem): 8031 (WebHistory::addItem): 8032 (WebHistory::visitedURL): 8033 * WebIconDatabase.cpp: 8034 (postDidAddIconNotification): 8035 Updated for change to CFDictionaryPropertyBag::createInstance. 8036 8037 * WebKitClassFactory.cpp: 8038 (releaseRefFromCreateInstance): Added this overloaded function 8039 template to abstract away the difference between createInstance 8040 functions that return a ref'd pointer and createInstance functions 8041 that return a COMPtr. 8042 (WebKitClassFactory::CreateInstance): Changed to use 8043 releaseRefFromCreateInstance. 8044 8045 2009-11-03 Brian Weinstein <bweinstein (a] apple.com> 8046 8047 Reviewed by Steve Falkenburg. 8048 8049 WebActionModifierFlagsKey should return an unsigned, because 8050 flags imply a bitmask, and that is what other classes expect from 8051 it. 8052 8053 * WebActionPropertyBag.cpp: 8054 (WebActionPropertyBag::Read): 8055 8056 2009-11-02 Eric Carlson <eric.carlson (a] apple.com> 8057 8058 Reviewed by John Sullivan and Mark Rowe. 8059 8060 <rdar://problem/7356733> Voiceover does not read correct media controller time values 8061 8062 * WebCoreLocalizedStrings.cpp: 8063 (WebCore::localizedMediaTimeDescription): 8064 8065 2009-10-29 Jon Honeycutt <jhoneycutt (a] apple.com> 8066 8067 MSAA: Accessibility of headings is not correct 8068 8069 https://bugs.webkit.org/show_bug.cgi?id=30937 8070 8071 Reviewed by Alice Liu. 8072 8073 * AccessibleBase.cpp: 8074 (AccessibleBase::get_accDescription): 8075 Call the object's descriptionForMSAA(). Moved the comment to the 8076 WebCore file. 8077 (AccessibleBase::get_accRole): 8078 If the object has a string role, return that. Otherwise, return the 8079 integer role. 8080 8081 * AccessibleBase.h: 8082 Removed description(), as this was moved to WebCore. 8083 8084 2009-10-29 Jon Honeycutt <jhoneycutt (a] apple.com> 8085 8086 MSAA: Accessibility of links is wrong 8087 8088 https://bugs.webkit.org/show_bug.cgi?id=30928 8089 8090 Reviewed by Darin Adler. 8091 8092 * AccessibleBase.cpp: 8093 (AccessibleBase::get_accState): 8094 Check whether the element is linked, instead of whether the node is an 8095 anchor, so the child "linkable" elements of anchor elements will also 8096 be "linked". 8097 (AccessibleBase::name): 8098 Return the name for MSAA. 8099 (AccessibleBase::value): 8100 Return the string value for MSAA. 8101 8102 2009-10-30 Evan Stade <estade (a] chromium.org> 8103 8104 Reviewed by David Levin. 8105 8106 Notify the chrome when the focused node has changed. 8107 https://bugs.webkit.org/show_bug.cgi?id=30832 8108 8109 Added stub implementation for new ChromeClient function. 8110 8111 * WebCoreSupport/WebChromeClient.cpp: 8112 (WebChromeClient::focusedNodeChanged): 8113 * WebCoreSupport/WebChromeClient.h: 8114 8115 2009-10-30 Roland Steiner <rolandsteiner (a] chromium.org> 8116 8117 Reviewed by Eric Seidel. 8118 8119 Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak. 8120 8121 Bug 28420 - Implement HTML5 <ruby> rendering 8122 (https://bugs.webkit.org/show_bug.cgi?id=28420) 8123 8124 No new tests (no functional change). 8125 8126 * WebKit.vcproj/WebKit.vcproj: 8127 8128 2009-10-29 Mark Rowe <mrowe (a] apple.com> 8129 8130 Rubber-stamped by Dan Bernstein. 8131 8132 <http://webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch due to changes 8133 to IWebFramePrivate vtable ordering 8134 8135 * Interfaces/IWebFramePrivate.idl: Move the newly-added method to the end of the interface so that 8136 it doesn't affect the ordering of the vtable. 8137 8138 2009-10-28 Steve Falkenburg <sfalken (a] apple.com> 8139 8140 Reviewed by Sam "Horatio" Weinig. 8141 8142 Should not generate/build COM DOM bindings 8143 https://bugs.webkit.org/show_bug.cgi?id=30880 8144 8145 * Interfaces/WebKit.idl: Remove generated interfaces. 8146 * WebKit.vcproj/InterfacesGenerated.vcproj: Removed. 8147 * WebKit.vcproj/WebKit.sln: Remove InterfacesGenerated.vcproj. 8148 * WebKit.vcproj/WebKit.submit.sln: Remove InterfacesGenerated.vcproj. 8149 * WebKit.vcproj/WebKit.vcproj: Remove generated interfaces. 8150 8151 2009-10-27 Shinichiro Hamaji <hamaji (a] chromium.org> 8152 8153 Reviewed by Darin Adler. 8154 8155 Provide a way to get counter values with layoutTestContoller 8156 https://bugs.webkit.org/show_bug.cgi?id=30555 8157 8158 * Interfaces/IWebFramePrivate.idl: 8159 * WebFrame.cpp: 8160 (WebFrame::counterValueForElementById): 8161 * WebFrame.h: 8162 8163 2009-10-28 Joe Mason <jmason (a] rim.com> 8164 8165 Reviewed by Adam Treat. 8166 8167 Call the shared FrameLoader::defaultObjectContentType instead of 8168 copying code into FrameLoaderClient::objectContentType. This causes no 8169 behavioural change. 8170 8171 * WebFrame.cpp: 8172 (WebFrame::objectContentType): 8173 8174 2009-10-28 Holger Hans Peter Freyther <zecke (a] selfish.org> 8175 8176 Speculative build-fix for WebElementPropertyBag.cpp 8177 8178 * WebElementPropertyBag.cpp: Include RenderObject.h 8179 8180 2009-10-27 Holger Hans Peter Freyther <zecke (a] selfish.org> 8181 8182 Reviewed by Simon Fraser. 8183 8184 Change HitTestResult methods to use (3d) transformation aware methods 8185 https://bugs.webkit.org/show_bug.cgi?id=27347 8186 8187 The HitTestResult::boundingBox method was removed. The 8188 RenderObject must be used directly. In contrast to the 8189 old HitTestResult::boundingBox method this code must use 8190 a (3d) transformation aware method to not run into an 8191 assert in SVGRenderBase::mapLocalToContainer. 8192 8193 * WebElementPropertyBag.cpp: 8194 (WebElementPropertyBag::Read): Replace HitTestResult::boundingBox() 8195 8196 2009-10-26 Laszlo Gombos <laszlo.1.gombos (a] nokia.com> 8197 8198 Reviewed by Darin Adler. 8199 8200 Make .rc files compile on Windows without depending on MFC headers 8201 https://bugs.webkit.org/show_bug.cgi?id=30750 8202 8203 * WebKit.vcproj/WebKit.rc: Use winresrc.h because it exists even 8204 when MFC is not installed, and is all that's needed here. 8205 8206 2009-10-26 Sam Weinig <sam (a] webkit.org> 8207 8208 Rubber-stamped by Darin Adler. 8209 8210 Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection 8211 inherit from HTMLCollection. 8212 8213 * DOMCreateInstance.cpp: 8214 8215 2009-10-25 Dan Bernstein <mitz (a] apple.com> 8216 8217 Reviewed by John Sullivan. 8218 8219 Add contextForWorldID to the IWebFramePrivate interface. 8220 8221 * Interfaces/IWebFramePrivate.idl: 8222 * WebFrame.h: 8223 8224 2009-10-25 Sam Weinig <sam (a] webkit.org> 8225 8226 Another try at fixing windows. 8227 8228 * DOMCreateInstance.cpp: 8229 8230 2009-10-25 Sam Weinig <sam (a] webkit.org> 8231 8232 Touch WebKit.idl in an effort to try and regenerate the COM bindings. 8233 8234 * Interfaces/WebKit.idl: 8235 8236 2009-10-23 Mark Rowe <mrowe (a] apple.com> 8237 8238 Build fix. Include config.h before including other files. 8239 8240 * AccessibleImage.cpp: 8241 8242 2009-10-23 Gavin Barraclough <barraclough (a] apple.com> 8243 8244 Reviewed by Geoff Garen. 8245 8246 https://bugs.webkit.org/show_bug.cgi?id=30729 8247 Provide private API to request the global context for a specific world. 8248 Used to initialize parameters on the global object. 8249 8250 * WebFrame.cpp: 8251 (WebFrame::contextForWorldID): 8252 * WebFrame.h: 8253 8254 2009-10-23 Brian Weinstein <bweinstein (a] apple.com> 8255 8256 Reviewed by John Sullivan. 8257 8258 Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it. 8259 <http://webkit.org/b/30732> and <rdar://7332018>. 8260 8261 Turns off pan-scrolling on a WebView when it is about to lose focus. 8262 8263 * WebView.cpp: 8264 (WebViewWndProc): 8265 8266 2009-10-23 Jon Honeycutt <jhoneycutt (a] apple.com> 8267 8268 MSAA: Name for image elements should use alt attribute text 8269 8270 https://bugs.webkit.org/show_bug.cgi?id=30727 8271 <rdar://problem/7328291> 8272 8273 Reviewed by Alice Liu. 8274 8275 * AccessibleBase.cpp: 8276 (AccessibleBase::createInstance): 8277 If the AccessibilityObject is an image, return an AccessibleImage. 8278 8279 * AccessibleImage.cpp: Added. 8280 (AccessibleImage::AccessibleImage): 8281 Call the base constructor. 8282 (AccessibleImage::name): 8283 If the object is not an AccessibilityRenderObject, return the base's 8284 name(). Look first for an ARIA "labeled-by" attribute, then look for an 8285 alternate text attribute. Fall back to the base's name(). 8286 8287 * AccessibleImage.h: Added. 8288 (AccessibleImage::~AccessibleImage): 8289 8290 * WebKit.vcproj/WebKit.vcproj: 8291 Add AccessibleImage to the project. 8292 8293 2009-10-23 Sam Weinig <sam (a] webkit.org> 8294 8295 Try and fix the windows build. 8296 8297 * Interfaces/WebKit.idl: 8298 8299 2009-10-22 Gavin Barraclough <barraclough (a] apple.com> 8300 8301 Reviewed by Sam Weinig & Geoff Garen. 8302 8303 https://bugs.webkit.org/show_bug.cgi?id=30696 8304 Update to incorporate support for IsolatedWorlds in JSC bindings. 8305 8306 * Interfaces/IWebFramePrivate.idl: 8307 * WebFrame.cpp: 8308 (WebFrame::globalContext): 8309 (WebFrame::windowObjectCleared): 8310 (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): 8311 * WebFrame.h: 8312 8313 2009-10-20 Fumitoshi Ukai <ukai (a] chromium.org> 8314 8315 Reviewed by David Levin. 8316 8317 Removed WebSocket runtime settings. 8318 https://bugs.webkit.org/show_bug.cgi?id=29896 8319 8320 WebSocket runtime configuration is supported by chromium/v8 only. 8321 8322 * Interfaces/IWebPreferencesPrivate.idl: 8323 * WebPreferenceKeysPrivate.h: 8324 * WebPreferences.cpp: 8325 (WebPreferences::initializeDefaultSettings): 8326 (WebPreferences::experimentalNotificationsEnabled): 8327 * WebPreferences.h: 8328 * WebView.cpp: 8329 (WebView::notifyPreferencesChanged): 8330 8331 2009-10-19 Adam Roben <aroben (a] apple.com> 8332 8333 Fix crashes/assertions when calling WebLocalizedString from multiple 8334 threads concurrently 8335 8336 Fixes <http://webkit.org/b/30534> WebLocalizedString asserts if called 8337 from multiple threads concurrently 8338 8339 Reviewed by John Sullivan. 8340 8341 * WebLocalizableStrings.cpp: 8342 (mainBundleLocStringsMutex): 8343 (frameworkLocStringsMutex): 8344 Added these new getters. 8345 8346 (findCachedString): 8347 (cacheString): 8348 Lock the relevant mutex before accessing each string map. Otherwise 8349 bad things could happen if two threads end up here at the same time. 8350 8351 2009-10-19 Adam Roben <aroben (a] apple.com> 8352 8353 Get rid of a few static initializers/exit-time destructors in 8354 WebLocalizableStrings 8355 8356 Reviewed by Dan Bernstein. 8357 8358 * WebLocalizableStrings.cpp: 8359 (mainBundleLocStrings): 8360 (frameworkLocStrings): 8361 Added these functions instead of file-scope variables. 8362 8363 (findCachedString): 8364 (cacheString): 8365 Updated to use the new functions. 8366 8367 2009-10-19 Nate Chapin <japhet (a] chromium.org> 8368 8369 Unreviewed, build fix. 8370 8371 Update call to FrameLoader::urlSelected(). 8372 8373 * WebCoreSupport/WebContextMenuClient.cpp: 8374 (WebContextMenuClient::searchWithGoogle): 8375 8376 2009-10-16 Steve Falkenburg <sfalken (a] apple.com> 8377 8378 Reviewed by Dan Bernstein. 8379 8380 https://bugs.webkit.org/show_bug.cgi?id=30456 8381 Fixes for new Debug_All Windows build configuration. 8382 8383 * WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming. 8384 8385 2009-10-16 Jon Honeycutt <jhoneycutt (a] apple.com> 8386 8387 Add SPI to determine whether a plug-in has ever been halted. 8388 8389 Part of <rdar://problem/7312158>. 8390 8391 Reviewed by Dan Bernstein. 8392 8393 * Interfaces/IWebViewPrivate.idl: 8394 Add hasPluginForNodeBeenHalted(). 8395 8396 * WebView.cpp: 8397 (pluginViewForNode): 8398 Code factored out of isNodeHaltedPlugin(). 8399 (WebView::isNodeHaltedPlugin): 8400 Remove STDMETHODCALLTYPE, as it has no use at the definition. Use 8401 pluginViewForNode(). 8402 (WebView::restartHaltedPluginForNode): 8403 Ditto. 8404 (WebView::hasPluginForNodeBeenHalted): 8405 Get the PluginView for the given node. Return the result of 8406 PluginView::hasBeenHalted(). 8407 8408 * WebView.h: 8409 Declare hasPluginForNodeBeenHalted(). 8410 8411 2009-10-16 Steve Falkenburg <sfalken (a] apple.com> 8412 8413 Reviewed by Adam Roben. 8414 8415 Add a Debug_All configuration to build entire stack as debug. 8416 Change Debug_Internal to: 8417 - stop using _debug suffix for all WebKit/Safari binaries 8418 - not use _debug as a DLL naming suffix 8419 - use non-debug C runtime lib. 8420 8421 * WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all". 8422 * WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All. 8423 * WebKit.vcproj/WebKit.sln: Add Debug_All configuration. 8424 * WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration. 8425 * WebKit.vcproj/WebKit.vcproj: 8426 Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo. 8427 Add Debug_All configuration. 8428 * WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration. 8429 8430 2009-10-15 Jon Honeycutt <jhoneycutt (a] apple.com> 8431 8432 Add SPI to restart a halted plug-in. 8433 8434 Part of <rdar://problem/7273354> Halted plug-ins should restart on 8435 mouseover 8436 8437 https://bugs.webkit.org/show_bug.cgi?id=30151 8438 8439 Reviewed by Kevin Decker. 8440 8441 * Interfaces/IWebViewPrivate.idl: 8442 Add restartHaltedPluginForNode(). 8443 8444 * WebView.cpp: 8445 (WebView::restartHaltedPluginForNode): 8446 From the IDOMNode, query for the DOMNode. From the DOMNode, get the 8447 WebCore::Node. Get the node's renderer, and check whether it is a 8448 RenderWidget. If so, get its Widget, and check whether it's a 8449 PluginView. If so, call PluginView::restart(). 8450 8451 * WebView.h: 8452 Declare restartHaltedPluginForNode(). 8453 8454 2009-10-14 Jon Honeycutt <jhoneycutt (a] apple.com> 8455 8456 Add SPI to determine whether a node is a halted plug-in. 8457 8458 Part of <rdar://problem/7273354> Halted plug-ins should restart on 8459 mouseover 8460 8461 https://bugs.webkit.org/show_bug.cgi?id=30151 8462 8463 Reviewed by Darin Adler. 8464 8465 * Interfaces/IWebViewPrivate.idl: 8466 Add isNodehaltedPlugin(). 8467 8468 * WebView.cpp: 8469 (WebView::isNodeHaltedPlugin): 8470 From the IDOMNode, query for the DOMNode. From the DOMNode, get the 8471 WebCore::Node. Get the node's renderer, and check whether it is a 8472 RenderWidget. If so, get its Widget, and check whether it's a 8473 PluginView. If so, return the result of PluginView::isHalted(). 8474 8475 * WebView.h: 8476 Declare isNodeHaltedPlugin(). 8477 8478 2009-10-15 Daniel Bates <dbates (a] webkit.org> 8479 8480 Reviewed by Adam Roben. 8481 8482 https://bugs.webkit.org/show_bug.cgi?id=24731 8483 And 8484 rdar://problem/5015961 8485 8486 Implements support for DHTML drag-and-drop operations (i.e. ondragstart, ondragend) 8487 in the Windows build so that it conforms to the Mac OS X build. Hence, dropEffect is 8488 correctly set. 8489 8490 The WebView and WebDropSource drag-and-drop functions, as called by function 8491 DoDragDrop in its event loop, neither used the drop effect as specified by 8492 event.dataTransfer.dropEffect nor respected event.dataTransfer.effectsAllowed. 8493 Instead, these functions defaulted to some hardcoded drop effect and set of 8494 allowed drop effects, respectively. 8495 8496 Tests: fast/events/drag-and-drop.html 8497 8498 * WebCoreSupport/WebDragClient.cpp: 8499 (WebDragClient::startDrag): 8500 * WebDropSource.cpp: 8501 (WebDropSource::QueryContinueDrag): Moved call to EventHandler::dragSourceEndedAt 8502 into method WebDragClient::startDrag. 8503 * WebDropSource.h: 8504 * WebView.cpp: 8505 (WebView::keyStateToDragOperation): Fixes <rdar://problem/5015961>. Determines 8506 appropriate drop effect from state of keyboard and allowed effects 8507 m_page->dragController()->sourceDragOperation(). 8508 (WebView::DragEnter): 8509 (WebView::DragOver): 8510 (WebView::Drop): 8511 * WebView.h: 8512 8513 2009-10-14 Adam Roben <aroben (a] apple.com> 8514 8515 Windows build fix 8516 8517 * WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and 8518 IWebNavigationData from the build (they get #imported via WebKit.idl). 8519 8520 2009-10-14 Brady Eidson <beidson (a] apple.com> 8521 8522 Reviewed by Sam Weinig. 8523 8524 WebKit Win API should provide a delegate interface for global history. 8525 https://bugs.webkit.org/show_bug.cgi?id=29905 8526 8527 -Add IWebHistoryDelegate for clients to implement. 8528 -Add (I)WebNavigationData for the history delegate's use. 8529 -When it exists, call the history delegate instead of using WebHistory. 8530 8531 * Interfaces/IWebHistoryDelegate.idl: Added. 8532 * Interfaces/IWebHistoryPrivate.idl: 8533 * Interfaces/IWebNavigationData.idl: Added. 8534 * Interfaces/IWebViewPrivate.idl: 8535 * Interfaces/WebKit.idl: 8536 8537 * WebKit.vcproj/Interfaces.vcproj: 8538 * WebKit.vcproj/WebKit.vcproj: 8539 8540 * WebCoreSupport/WebChromeClient.cpp: 8541 (WebChromeClient::populateVisitedLinks): 8542 * WebCoreSupport/WebFrameLoaderClient.cpp: 8543 (WebFrameLoaderClient::updateGlobalHistory): 8544 (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): 8545 (WebFrameLoaderClient::setTitle): 8546 8547 * WebView.cpp: 8548 (WebView::close): 8549 (WebView::mainFrameURL): 8550 (WebView::setHistoryDelegate): 8551 (WebView::historyDelegate): 8552 (WebView::addVisitedLinks): 8553 * WebView.h: 8554 8555 * WebHistory.cpp: 8556 (WebHistory::setVisitedLinkTrackingEnabled): 8557 (WebHistory::removeAllVisitedLinks): 8558 * WebHistory.h: 8559 8560 * WebNavigationData.cpp: Added. 8561 (WebNavigationData::QueryInterface): 8562 (WebNavigationData::AddRef): 8563 (WebNavigationData::Release): 8564 (WebNavigationData::WebNavigationData): 8565 (WebNavigationData::~WebNavigationData): 8566 (WebNavigationData::createInstance): 8567 (WebNavigationData::url): 8568 (WebNavigationData::title): 8569 (WebNavigationData::originalRequest): 8570 (WebNavigationData::response): 8571 (WebNavigationData::hasSubstituteData): 8572 (WebNavigationData::clientRedirectSource): 8573 * WebNavigationData.h: Added. 8574 8575 2009-10-13 Dave Hyatt <hyatt (a] apple.com> 8576 8577 Fix more WebView bustage. 8578 8579 * WebView.cpp: 8580 (WebView::addUserScriptToGroup): 8581 (WebView::addUserStyleSheetToGroup): 8582 (WebView::removeUserScriptsFromGroup): 8583 (WebView::removeUserStyleSheetsFromGroup): 8584 8585 2009-10-13 Dave Hyatt <hyatt (a] apple.com> 8586 8587 Fix build bustage on Windows. 8588 8589 * WebView.cpp: 8590 (WebView::addUserScriptToGroup): 8591 (WebView::addUserStyleSheetToGroup): 8592 (WebView::removeUserScriptsFromGroup): 8593 (WebView::removeUserStyleSheetsFromGroup): 8594 8595 2009-10-13 Dave Hyatt <hyatt (a] apple.com> 8596 8597 Reviewed by Adam Roben.. 8598 8599 Split removal functions for user scripts and stylehseets based on type. 8600 8601 * Interfaces/IWebViewPrivate.idl: 8602 * WebView.cpp: 8603 (WebView::removeUserScriptFromGroup): 8604 (WebView::removeUserStyleSheetFromGroup): 8605 * WebView.h: 8606 8607 2009-10-09 Adam Barth <abarth (a] webkit.org> 8608 8609 Reviewed by Darin Adler. 8610 8611 Factor HistoryController out of FrameLoader 8612 https://bugs.webkit.org/show_bug.cgi?id=30246 8613 8614 Update API call. 8615 8616 * WebView.cpp: 8617 (WebView::loadBackForwardListFromOtherView): 8618 8619 2009-10-08 Jon Honeycutt <jhoneycutt (a] apple.com> 8620 8621 Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking 8622 for the existence of a PluginHalterDelegate. 8623 8624 Reviewed by Dan Bernstein. 8625 8626 * Interfaces/IWebPreferencesPrivate.idl: 8627 Remove the getter and setter. 8628 8629 * WebCoreSupport/WebPluginHalterClient.cpp: 8630 (WebPluginHalterClient::enabled): 8631 Return true if the delegate exists. 8632 8633 * WebCoreSupport/WebPluginHalterClient.h: 8634 Declare implementation of enabled(). 8635 8636 * WebPreferenceKeysPrivate.h: 8637 Removed the pref key. 8638 8639 * WebPreferences.cpp: 8640 (WebPreferences::initializeDefaultSettings): 8641 Removed initialization of the pref. 8642 8643 * WebPreferences.h: 8644 Removed declaration of the getter/setter. 8645 8646 * WebView.cpp: 8647 (WebView::notifyPreferencesChanged): 8648 Don't propagate the pref. 8649 8650 2009-10-08 Adam Barth <abarth (a] webkit.org> 8651 8652 Reviewed by Eric Seidel. 8653 8654 Move executeScript from FrameLoader to ScriptController 8655 https://bugs.webkit.org/show_bug.cgi?id=30200 8656 8657 Update API call. 8658 8659 * WebView.cpp: 8660 (WebView::stringByEvaluatingJavaScriptFromString): 8661 8662 2009-10-08 Anders Carlsson <andersca (a] apple.com> 8663 8664 Reviewed by Sam Weinig. 8665 8666 Remove the shouldLoadMediaElementURL implementation. 8667 8668 * Interfaces/IWebPolicyDelegatePrivate.idl: 8669 * WebCoreSupport/WebFrameLoaderClient.cpp: 8670 (WebFrameLoaderClient::shouldUsePluginDocument): 8671 * WebCoreSupport/WebFrameLoaderClient.h: 8672 8673 2009-10-08 Adam Roben <aroben (a] apple.com> 8674 8675 Make IWebInspectorPrivate be accessed in a more standard way 8676 8677 IWebViewPrivate::inspectorPrivate has been removed. Callers should 8678 instead use IWebViewPrivate::inspector and then use QueryInterface to 8679 get the IWebInspectorPrivate interface. This matches how our other COM 8680 classes work. 8681 8682 Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be 8683 accessed in a more standard way 8684 8685 Reviewed by John Sullivan and Tim Hatcher. 8686 8687 * Interfaces/IWebViewPrivate.idl: Removed inspectorPrivate. 8688 8689 * WebInspector.cpp: 8690 (WebInspector::QueryInterface): Support querying to 8691 IWebInspectorPrivate. 8692 8693 * WebView.cpp: 8694 * WebView.h: 8695 Removed inspectorPrivate. 8696 8697 2009-10-08 Adam Roben <aroben (a] apple.com> 8698 8699 Move the new IWebViewPrivate::inspectorPrivate function after all 8700 functions that existed when Safari 4.0.3 was released 8701 8702 Fixes <http://webkit.org/b/30085> REGRESSION (r49091): run-safari 8703 crashes in Safari.dll 8704 8705 Reviewed by John Sullivan. 8706 8707 * Interfaces/IWebViewPrivate.idl: Moved inspectorPrivate to the end of 8708 the interface, so it won't modify the vtable that Safari 4.0.3 sees. 8709 8710 2009-10-07 Adam Roben <aroben (a] apple.com> 8711 8712 Expose origin whitelisting in the WebKit API on Windows 8713 8714 Fixes <http://webkit.org/b/30185>. 8715 8716 Reviewed by Eric Seidel. 8717 8718 * Interfaces/IWebViewPrivate.idl: Added whiteListAccessFromOrigin and 8719 resetOriginAccessWhiteLists, to match the Mac SPI. 8720 8721 * WebView.cpp: 8722 (WebView::whiteListAccessFromOrigin): 8723 (WebView::resetOriginAccessWhiteLists): 8724 * WebView.h: 8725 Added. These just call through to SecurityOrigin. 8726 8727 2009-10-07 Adam Barth <abarth (a] webkit.org> 8728 8729 Reviewed by Darin Adler. 8730 8731 Factor PolicyChecker out of FrameLoader 8732 https://bugs.webkit.org/show_bug.cgi?id=30155 8733 8734 Move the policy callback to the policy object. 8735 8736 * WebFrame.cpp: 8737 (WebFrame::dispatchWillSubmitForm): 8738 (WebFrame::receivedPolicyDecision): 8739 (WebFrame::dispatchDecidePolicyForMIMEType): 8740 (WebFrame::dispatchDecidePolicyForNewWindowAction): 8741 (WebFrame::dispatchDecidePolicyForNavigationAction): 8742 8743 2009-10-07 Daniel Bates <dbates (a] webkit.org> 8744 8745 Reviewed by Darin Adler. 8746 8747 https://bugs.webkit.org/show_bug.cgi?id=30102 8748 And 8749 <rdar://problem/5015957> 8750 8751 Fixes an issue (in the Windows build) where the cursor does not change to the 8752 not-allowed cursor when the drag-and-drop operation is not allowed. 8753 8754 The allowed effects in WebDragClient::startDrag are hard-coded to be 8755 DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of 8756 allowed drop effects should be determined by the allowed operations of the 8757 drag source. 8758 8759 We cannot test this using DRT because DRT looks at the programmatic drop 8760 cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy. 8761 That is, there is a discrepancy in the Windows build between the Windows API-based 8762 drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer 8763 to determine the cursor, a manual test is needed. 8764 8765 * WebCoreSupport/WebDragClient.cpp: 8766 (draggingSourceOperationMaskToDragCursors): Added method. 8767 (WebDragClient::startDrag): 8768 8769 2009-10-07 Steve Falkenburg <sfalken (a] apple.com> 8770 8771 Reviewed by Darin Adler. 8772 8773 https://bugs.webkit.org/show_bug.cgi?id=30176 8774 <rdar://problem/7281553> Extra information in UA causes problems with gmail 8775 8776 * WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space. 8777 8778 2009-10-06 Pavel Feldman <pfeldman (a] chromium.org> 8779 8780 Reviewed by Timothy Hatcher. 8781 8782 Web Inspector: default to an attached inspector window on Windows (as on Mac). 8783 8784 https://bugs.webkit.org/show_bug.cgi?id=30134 8785 8786 * WebCoreSupport/WebInspectorClient.cpp: 8787 (WebInspectorClient::showWindowWithoutNotifications): 8788 8789 2009-10-06 Adam Barth <abarth (a] webkit.org> 8790 8791 Reviewed by Eric Seidel. 8792 8793 Move FrameLoader::canLoad to SecurityOrigin 8794 https://bugs.webkit.org/show_bug.cgi?id=30111 8795 8796 * WebFrame.cpp: 8797 (WebFrame::allowsFollowingLink): 8798 8799 2009-10-06 Pavel Feldman <pfeldman (a] chromium.org> 8800 8801 Reviewed by Timothy Hatcher. 8802 8803 Web Inspector: close inspector client view on 8804 InspectorController::close API call. 8805 8806 In order to run batch web inspector layout tests (and not affect 8807 subsequent tests) we should close inspector client's view upon 8808 InspectorController::close API call. 8809 8810 https://bugs.webkit.org/show_bug.cgi?id=30009 8811 8812 * WebCoreSupport/WebInspectorClient.cpp: 8813 (WebInspectorClient::createPage): 8814 8815 2009-10-06 David Levin <levin (a] chromium.org> 8816 8817 Reviewed by NOBODY (windows build fix). 8818 8819 Speculative build fix for windows (due to r49160). 8820 8821 * WebDownloadCFNet.cpp: 8822 (WebDownload::initToResumeWithBundle): 8823 * WebIconDatabase.cpp: 8824 (WebIconDatabase::dispatchDidAddIconForPageURL): 8825 8826 2009-10-05 Pavel Feldman <pfeldman (a] chromium.org> 8827 8828 Reviewed by Timothy Hatcher. 8829 8830 Web Inspector: add testing harness for Web Inspector. 8831 8832 https://bugs.webkit.org/show_bug.cgi?id=30010 8833 8834 * Interfaces/IWebInspectorPrivate.idl: Added. 8835 * Interfaces/IWebViewPrivate.idl: 8836 * Interfaces/WebKit.idl: 8837 * WebInspector.cpp: 8838 (WebInspector::evaluateInFrontend): 8839 * WebInspector.h: 8840 * WebView.cpp: 8841 (WebView::inspectorPrivate): 8842 * WebView.h: 8843 8844 2009-10-02 Dave Hyatt <hyatt (a] apple.com> 8845 8846 Reviewed by Adam Roben. 8847 8848 Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns. 8849 8850 * Interfaces/IWebViewPrivate.idl: 8851 * WebView.cpp: 8852 (toStringVector): 8853 (WebView::addUserScriptToGroup): 8854 (WebView::addUserStyleSheetToGroup): 8855 * WebView.h: 8856 8857 2009-10-02 Steve Falkenburg <sfalken (a] apple.com> 8858 8859 Reviewed by Mark Rowe. 8860 8861 <https://bugs.webkit.org/show_bug.cgi?id=29989> 8862 Safari version number shouldn't be exposed in WebKit code 8863 8864 For a WebKit version of 532.3.4: 8865 Product version is: 5.32.3.4 (was 4.0.3.0) 8866 File version is: 5.32.3.4 (was 4.532.3.4) 8867 8868 * WebKit.vcproj/WebKit.rc: 8869 8870 2009-09-30 Sam Weinig <sam (a] webkit.org> 8871 8872 Reviewed by Dan Bernstein. 8873 8874 Fix for <rdar://problem/7259706> 8875 Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window 8876 8877 * Interfaces/IWebFramePrivate.idl: 8878 * WebFrame.cpp: 8879 (WebFrame::allowsFollowingLink): 8880 * WebFrame.h: 8881 8882 2009-09-30 Dave Hyatt <hyatt (a] apple.com> 8883 8884 Reviewed by Adam Roben. 8885 8886 Add the ability to remove user stylesheets and scripts by URL. 8887 8888 * Interfaces/IWebViewPrivate.idl: 8889 * WebView.cpp: 8890 (WebView::removeUserContentWithURLFromGroup): 8891 * WebView.h: 8892 8893 2009-09-29 Kenneth Russell <kbr (a] google.com> 8894 8895 Reviewed by Dimitri Glazkov. 8896 8897 Add support for run-time flag for 3D canvas 8898 https://bugs.webkit.org/show_bug.cgi?id=29826 8899 8900 * WebView.cpp: 8901 (WebView::notifyPreferencesChanged): Enable experimental WebGL 8902 flag when 3D_CANVAS is enabled in the build. 8903 8904 2009-09-28 Alexey Proskuryakov <ap (a] apple.com> 8905 8906 Reviewed by Darin Adler and Sam Weinig. 8907 8908 Onclick not fired for an element copied with cloneContents() or cloneNode() 8909 https://bugs.webkit.org/show_bug.cgi?id=25130 8910 8911 * DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now. 8912 8913 * WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp. 8914 8915 2009-09-28 Fumitoshi Ukai <ukai (a] chromium.org> 8916 8917 Reviewed by Eric Seidel. 8918 8919 Add experimentalWebSocketsEnabled in WebPreferences. 8920 https://bugs.webkit.org/show_bug.cgi?id=28941 8921 8922 * Interfaces/IWebPreferencesPrivate.idl: 8923 * WebPreferenceKeysPrivate.h: 8924 * WebPreferences.cpp: 8925 (WebPreferences::initializeDefaultSettings): 8926 (WebPreferences::setExperimentalWebSocketsEnabled): 8927 (WebPreferences::experimentalWebSocketsEnabled): 8928 * WebPreferences.h: 8929 * WebView.cpp: 8930 (WebView::notifyPreferencesChanged): 8931 (core): 8932 8933 2009-09-25 Darin Adler <darin (a] apple.com> 8934 8935 Reviewed by Steve Falkenburg. 8936 8937 Speed up access to history items by caching date computation. 8938 8939 * History/WebHistory.mm: 8940 (getDayBoundaries): Refactored from timeIntervalForBeginningOfDay. 8941 Returns the beginning of the day that the passed time is within and 8942 the beginning of the next day. 8943 (beginningOfDay): Added. Uses getDayBoundaries so it can be fast for 8944 multiple dates within the same day, which is the common case. 8945 (dateKey): Added. Calls beginningOfDay and converts to an integer. 8946 (WebHistory::findKey): Changed to call dateKey instead of 8947 timeIntervalForBeginningOfDay. 8948 8949 2009-09-25 Adam Roben <aroben (a] apple.com> 8950 8951 Add SPI to invalidate a WebView's backing store 8952 8953 This is useful in conjunction with 8954 IWebUIDelegatePrivate2::drawBackground. This provides a way for the UI 8955 delegate to force WebView to get its background redrawn. 8956 8957 Fixes <http://webkit.org/b/29737> Need SPI to invalidate a WebView's 8958 backing store 8959 8960 Reviewed by Anders Carlsson. 8961 8962 * Interfaces/IWebViewPrivate.idl: Added invalidateBackingStore. 8963 * WebView.cpp: 8964 (WebView::invalidateBackingStore): If rect is 0, invalidate our whole 8965 client rect. Otherwise invalidate the intersection of rect with our 8966 client rect. 8967 * WebView.h: 8968 8969 2009-09-24 Jon Honeycutt <jhoneycutt (a] apple.com> 8970 8971 Add a mechanism for automatically halting plug-ins. 8972 8973 Reviewed by Oliver Hunt. 8974 8975 * Interfaces/IWebPluginHalterDelegate.idl: Added. Defines an interface 8976 for a delegate that determines whether plug-ins should be halted. 8977 8978 * Interfaces/IWebPreferencesPrivate.idl: 8979 Declare functions to get and set the enabled state of the plug-in 8980 halter and the plug-in allowed run time. 8981 8982 * Interfaces/IWebViewPrivate.idl: 8983 Declare functions to get and set the IWebPluginHalterDelegate. 8984 8985 * Interfaces/WebKit.idl: 8986 8987 * WebCoreSupport/WebPluginHalterClient.cpp: Added. 8988 (WebPluginHalterClient::WebPluginHalterClient): 8989 (WebPluginHalterClient::shouldHaltPlugin): 8990 Get the IWebPluginHalterDelegate for the WebView. Create a WebKit 8991 DOMNode for the WebCore Node. Call the delegate's shouldHaltPlugin(). 8992 If the call fails, return false. Otherwise, return the result of the 8993 call. 8994 8995 * WebCoreSupport/WebPluginHalterClient.h: Added. 8996 8997 * WebKit.vcproj/Interfaces.vcproj: 8998 Add IWebPluginHalterDelegate.idl. 8999 9000 * WebKit.vcproj/WebKit.vcproj: 9001 Add WebPluginHalterClient.{h,cpp}. 9002 9003 * WebPreferenceKeysPrivate.h: 9004 Define WebKitPluginHalterEnabledPreferenceKey and 9005 WebKitPluginAllowedRunTimePreferenceKey. 9006 9007 * WebPreferences.cpp: 9008 (WebPreferences::initializeDefaultSettings): 9009 Leave plug-in halting disabled by default. Set the default value for 9010 the plug-in allowed run time to the max value of an unsigned int. 9011 (WebPreferences::setPluginHalterEnabled): 9012 (WebPreferences::pluginHalterEnabled): 9013 (WebPreferences::setPluginAllowedRunTime): 9014 (WebPreferences::pluginAllowedRunTime): 9015 9016 * WebPreferences.h: 9017 9018 * WebView.cpp: 9019 (WebView::close): 9020 Clear the IWebPluginHalterDelegate. 9021 (WebView::initWithFrame): 9022 Pass a WebPluginHalterClient when creating the Page. 9023 (WebView::notifyPreferencesChanged): 9024 Set the new settings when the preferences changed notification is 9025 received. 9026 (WebView::setPluginHalterDelegate): 9027 (WebView::pluginHalterDelegate): 9028 9029 * WebView.h: 9030 Declare overrides of setPluginHalterDelegate() and 9031 pluginHalterDelegate(). Added a member to track the 9032 IWebPluginHalterDelegate. 9033 9034 2009-09-14 John Gregg <johnnyg (a] google.com> 9035 9036 Reviewed by Eric Seidel. 9037 9038 Enable switch for notifications (experimental) in Page Settings 9039 https://bugs.webkit.org/show_bug.cgi?id=28930 9040 9041 Adds support for the experimentalNotificationsEnabled flag in Settings through 9042 WebPreferencesPrivate interface. Also cleans up some issues accessing the 9043 notification delegate through DumpRenderTree. 9044 9045 * Interfaces/IWebPreferencesPrivate.idl: 9046 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: 9047 (WebDesktopNotificationsDelegate::hasNotificationDelegate): 9048 (WebDesktopNotificationsDelegate::notificationDelegate): 9049 * WebPreferenceKeysPrivate.h: 9050 * WebPreferences.cpp: 9051 (WebPreferences::initializeDefaultSettings): 9052 (WebPreferences::setExperimentalNotificationsEnabled): 9053 (WebPreferences::experimentalNotificationsEnabled): 9054 * WebPreferences.h: 9055 * WebView.cpp: 9056 (WebView::notifyPreferencesChanged): 9057 9058 2009-09-23 Anders Carlsson <andersca (a] apple.com> 9059 9060 Reviewed by Adam Roben. 9061 9062 <rdar://problem/7243354> 9063 REGRESSION(48580-48636): Crash clicking embedded QT preview button on apple.com/trailers 9064 9065 Check for a null IWebPolicyDelegatePrivate. 9066 9067 * WebCoreSupport/WebFrameLoaderClient.cpp: 9068 (WebFrameLoaderClient::shouldLoadMediaElementURL): 9069 9070 2009-09-22 Sam Weinig <sam (a] webkit.org> 9071 9072 Rubber-stamped by Adam Roben. 9073 9074 Remove accidentally left in declaration of reloadFromOrigin in IWebFramePrivate.idl 9075 9076 * Interfaces/IWebFramePrivate.idl: 9077 9078 2009-09-22 Sam Weinig <sam (a] webkit.org> 9079 9080 Reviewed by Steve Falkenburg. 9081 9082 Fix for <rdar://problem/6451745> 9083 Windows WebKit needs to implement reloadFromOrigin() 9084 9085 * Interfaces/IWebFrame.idl: 9086 * Interfaces/IWebFramePrivate.idl: 9087 * Interfaces/IWebView.idl: 9088 * WebFrame.cpp: 9089 (WebFrame::reloadFromOrigin): 9090 * WebFrame.h: 9091 * WebView.cpp: 9092 (WebView::reloadFromOrigin): 9093 * WebView.h: 9094 9095 2009-09-22 Adam Roben <aroben (a] apple.com> 9096 9097 Manage refcounts correctly in DefaultDownloadDelegate::willSendRequest 9098 9099 Fixes <http://webkit.org/b/29650> Crash in 9100 WebDownload::willSendRequest when using DefaultDownloadDelegate 9101 9102 Reviewed by Brady Eidson. 9103 9104 * DefaultDownloadDelegate.cpp: 9105 (DefaultDownloadDelegate::willSendRequest): Call AddRef() on the 9106 object we're returning via the finalRequest out-parameter. 9107 9108 2009-09-21 Anders Carlsson <andersca (a] apple.com> 9109 9110 Reviewed by Adam Roben. 9111 9112 <rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource 9113 9114 Implement WebFrameLoaderClient::shouldLoadMediaElementURL and have it call the new private policy 9115 delegate method. 9116 9117 * Interfaces/IWebPolicyDelegatePrivate.idl: Added. 9118 * Interfaces/WebKit.idl: 9119 * WebCoreSupport/WebFrameLoaderClient.cpp: 9120 (WebFrameLoaderClient::shouldLoadMediaElementURL): 9121 * WebCoreSupport/WebFrameLoaderClient.h: 9122 * WebKit.vcproj/Interfaces.vcproj: 9123 9124 2009-09-17 Kenneth Rohde Christiansen <kenneth (a] webkit.org> 9125 9126 Reviewed by Simon Hausmann. 9127 9128 Make PlatformWindow return something else than PlatformWidget 9129 https://bugs.webkit.org/show_bug.cgi?id=29085 9130 9131 Reflect the rename of platformWindow and it's return type. 9132 9133 * AccessibleBase.cpp: 9134 (AccessibleBase::get_accParent): 9135 * WebCoreSupport/WebChromeClient.cpp: 9136 (WebChromeClient::platformPageClient): 9137 * WebCoreSupport/WebChromeClient.h: 9138 9139 2009-09-17 Brian Weinstein <bweinstein (a] apple.com> 9140 9141 Reviewed by Adam Roben. 9142 9143 Remove assertions that were being hit by calls to 9144 m_verticalScrollbar->invalidate(). These assertions were valid, 9145 but they were causing tests to fail, so replacing with a FIXME 9146 until we can find out the real cause/solution that is being tracked 9147 by http://webkit.org/b/29350. 9148 9149 * WebView.cpp: 9150 (WebView::addToDirtyRegion): 9151 (WebView::paintIntoBackingStore): 9152 9153 2009-09-17 Ada Chan <adachan (a] apple.com> 9154 9155 Post WebViewDidChangeSelectionNotification when the text selection changes. 9156 9157 Fixes <http://webkit.org/b/29321> 9158 9159 Reviewed by Adam Roben. 9160 9161 * Interfaces/IWebView.idl: 9162 * WebCoreSupport/WebEditorClient.cpp: 9163 (WebEditorClient::respondToChangedSelection): 9164 9165 2009-09-17 Adam Roben <aroben (a] apple.com> 9166 9167 Fix a crash when a WebView's HWND is destroyed before IWebView::close 9168 is called 9169 9170 WebView's HWND was being sent a WM_TIMER message after the WebView was 9171 destroyed. This normally isn't possible (we call DestroyWindow inside 9172 WebView's destructor to ensure the HWND doesn't outlive the WebView), 9173 but r48060 changed WebView to call SetParent(m_viewWindow, 9174 HWND_MESSAGE) while handling WM_DESTROY, and apparently this puts the 9175 HWND into some weird half-destroyed state where it can still receive 9176 WM_TIMER messages. 9177 9178 Fixes <http://webkit.org/b/29337> <rdar://problem/7209897> REGRESSION 9179 (r48060): unrepro but frequent crash in WebViewWndProc 9180 9181 Reviewed by Steve Falkenburg. 9182 9183 * WebView.cpp: 9184 (WebViewWndProc): When handling WM_DESTROY, call setIsBeingDestroyed() 9185 before calling close(). This allows setHostWindow to detect that we're 9186 handling WM_DESTROY. No other code in close() cared whether 9187 isBeingDestroyed() was true or not. 9188 (WebView::setHostWindow): If our host window is being set to 0 and 9189 we're being destroyed, don't become a message-only window. Doing this 9190 while handling WM_DESTROY seems to lead to crashes. 9191 9192 2009-09-16 Adam Roben <aroben (a] apple.com> 9193 9194 Add a UI delegate callback to let the delegate draw a WebView's 9195 background 9196 9197 Fixes <http://webkit.org/b/29315>. 9198 9199 Reviewed by Dave Hyatt. 9200 9201 * Interfaces/IWebUIDelegatePrivate.idl: Added 9202 IWebUIDelegatePrivate2::drawBackground. 9203 9204 * WebView.cpp: 9205 (WebView::paintIntoBackingStore): After clearing or filling with 9206 white, let the delegate draw whatever background it wants. Also added 9207 an assertion that the dirty rect is within our bounds. 9208 9209 2009-09-16 Adam Roben <aroben (a] apple.com> 9210 9211 Prevent WebView from painting over sibling windows 9212 9213 Fixes <http://webkit.org/b/29300> <rdar://problem/7227960> WebView can 9214 paint over sibling windows 9215 9216 Reviewed by Darin Adler. 9217 9218 * WebView.cpp: 9219 (WebView::initWithFrame): Create the WebView's HWND with the 9220 WS_CLIPSIBLINGS style. 9221 9222 2009-09-14 Brady Eidson <beidson (a] apple.com> 9223 9224 Reviewed by Alexey Proskuryakov. 9225 9226 Safari 4 cannot be used to update firmware on Linksys routers. 9227 <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160 9228 9229 Adopt the new WebCore::CredentialStorage in WebKit/Win. 9230 9231 * WebDownloadCFNet.cpp: 9232 (WebDownload::didReceiveAuthenticationChallenge): 9233 9234 2009-09-11 Steve Falkenburg <sfalken (a] apple.com> 9235 9236 Reviewed by Dan Bernstein. 9237 9238 Properly propagate preference from WebPreferences to WebCore::Settings. 9239 https://bugs.webkit.org/show_bug.cgi?id=29192 9240 9241 * WebView.cpp: 9242 (WebView::initWithFrame): Apply setting when creating a new WebView. 9243 (WebView::notifyPreferencesChanged): Apply setting when preferences change. 9244 9245 2009-09-11 Steve Falkenburg <sfalken (a] apple.com> 9246 9247 Reviewed by Darin Adler. 9248 9249 Allow WebKit clients to opt out of high resolution timers on Windows. 9250 https://bugs.webkit.org/show_bug.cgi?id=29192 9251 9252 * Interfaces/IWebPreferencesPrivate.idl: Added getter/setter. 9253 Put this just after last 4.0.3 method for future merging. 9254 * Interfaces/WebKit.idl: Touched to force a rebuild. 9255 * WebPreferenceKeysPrivate.h: Added prefs key for high res timers. 9256 * WebPreferences.cpp: 9257 (WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled. 9258 (WebPreferences::setShouldUseHighResolutionTimers): Added. 9259 (WebPreferences::shouldUseHighResolutionTimers): Added. 9260 * WebPreferences.h: Added getter/setter. 9261 9262 2009-09-11 Adam Roben <aroben (a] apple.com> 9263 9264 Get user script/stylesheet tests running on Windows 9265 9266 Fixes <http://webkit.org/b/29181> User script/stylesheet tests are 9267 skipped on Windows 9268 9269 Reviewed by John Sullivan. 9270 9271 * Interfaces/IWebViewPrivate.idl: Added addUserScriptToGroup, 9272 addUserStyleSheetToGroup, removeUserContentFromGroup, 9273 removeAllUserContentFromGropu to match the Mac SPI. 9274 9275 * WebView.cpp: 9276 (WebView::addUserScriptToGroup): 9277 (WebView::addUserStyleSheetToGroup): 9278 (WebView::removeUserContentFromGroup): 9279 (WebView::removeAllUserContentFromGroup): 9280 * WebView.h: 9281 Added. Implementation was based on similar methods in WebView.mm. 9282 9283 2009-09-11 Jon Honeycutt <jhoneycutt (a] apple.com> 9284 9285 Fix crash on launch on Windows. 9286 9287 Rubber-stamped by Mark Rowe. 9288 9289 * WebKit.vcproj/WebKit.vcproj: 9290 Define ENABLE_WEB_SOCKETS for all configurations. 9291 9292 2009-09-07 Drew Wilson <atwilson (a] google.com> 9293 9294 Reviewed by David Levin. 9295 9296 Enable SHARED_WORKERS by default. 9297 https://bugs.webkit.org/show_bug.cgi?id=28959 9298 9299 * WebKit.vcproj/WebKit.vcproj: 9300 9301 2009-09-04 Adam Roben <aroben (a] apple.com> 9302 9303 Make WebView function without a parent window 9304 9305 When WebView has no parent window, it becomes a message-only window, 9306 which hides it from the screen and prevents it from appearing on the 9307 taskbar. 9308 9309 Fixes <http://webkit.org/b/28971> <rdar://problem/4976998> 9310 WebView::initWithFrame fails if there's no host window 9311 9312 Reviewed by Dave Hyatt. 9313 9314 * WebView.cpp: 9315 (WebView::initWithFrame): m_hostWindow is null, use HWND_MESSAGE as 9316 our parent window, which will make us a message-only window. 9317 (WebView::setHostWindow): If he new host window is null, use 9318 HWND_MESSAGE as our parent window, which will make us a message-only 9319 window. 9320 9321 2009-09-04 Adam Barth <abarth (a] webkit.org> 9322 9323 Unreviewed attempt at a build fix. 9324 9325 Added missing include. 9326 9327 * WebCoreSupport/WebFrameLoaderClient.cpp: 9328 9329 2009-09-04 Adam Barth <abarth (a] webkit.org> 9330 9331 Unreviewed attempt at a build fix. 9332 9333 Fix typo of IWebFrameLoadDelegatePrivate2 and make 9334 IWebFrameLoadDelegatePrivate inherit from IWebFrameLoadDelegatePrivate 9335 as requestd by Adam Roben. 9336 9337 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: 9338 * WebCoreSupport/WebFrameLoaderClient.cpp: 9339 (WebFrameLoaderClient::didDisplayInsecureContent): 9340 (WebFrameLoaderClient::didRunInsecureContent): 9341 9342 2009-09-04 Adam Barth <abarth (a] webkit.org> 9343 9344 Reviewed by Eric Seidel. 9345 9346 https://bugs.webkit.org/show_bug.cgi?id=24696 9347 9348 Plumb mixed content notifications to IWebFrameLoadDelegatePrivate. 9349 9350 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added. 9351 * Interfaces/WebKit.idl: 9352 * WebCoreSupport/WebFrameLoaderClient.cpp: 9353 (WebFrameLoaderClient::didDisplayInsecureContent): 9354 (WebFrameLoaderClient::didRunInsecureContent): 9355 * WebKit.vcproj/Interfaces.vcproj: 9356 9357 2009-09-03 Adam Barth <abarth (a] webkit.org> 9358 9359 Reviewed by eric (a] webkit.org. 9360 9361 https://bugs.webkit.org/show_bug.cgi?id=24696 9362 9363 Stub implementations of mixed content methods of FrameLoaderClient. 9364 9365 * WebCoreSupport/WebFrameLoaderClient.cpp: 9366 (WebFrameLoaderClient::didDisplayInsecureContent): 9367 (WebFrameLoaderClient::didRunInsecureContent): 9368 * WebCoreSupport/WebFrameLoaderClient.h: 9369 9370 2009-09-01 Adam Roben <aroben (a] apple.com> 9371 9372 Post a notification when a WebView is closing 9373 9374 This is useful for situations where some code wants to react to the 9375 WebView closing but isn't in charge of the WebView and can't otherwise 9376 be notified. This notification could replace 9377 IWebUIDelegatePrivate::webViewClosing if we decide that the 9378 notification system isn't too burdensome. 9379 9380 <http://webkit.org/b/28875> 9381 9382 Reviewed by John Sullivan. 9383 9384 * Interfaces/IWebViewPrivate.idl: Added the 9385 WebViewWillCloseNotification string constant. 9386 * WebKit.vcproj/WebKit.vcproj: Link against comsuppw.lib in all 9387 configurations so that we can use _bstr_t. 9388 * WebView.cpp: 9389 (WebView::close): Post the WebViewWillCloseNotification. 9390 9391 2009-08-31 Alexey Proskuryakov <ap (a] webkit.org> 9392 9393 Reviewed by Darin Adler. 9394 9395 https://bugs.webkit.org/show_bug.cgi?id=28852 9396 Rename KURL single argument constructor to avoid confusion 9397 9398 * WebURLResponse.cpp: (WebURLResponse::createInstance): Adapt to the change. 9399 9400 2009-08-20 Adam Roben <aroben (a] apple.com> 9401 9402 Give WebKit clients access to the window features specified in 9403 window.open 9404 9405 Reviewed by Steve Falkenburg. 9406 9407 * COMVariantSetter.h: Added COMVariantSetters for bool and float. 9408 9409 * Interfaces/IWebUIDelegatePrivate.idl: Added IWebUIDelegatePrivate2, 9410 which contains a new version of createWebViewWithRequest that also 9411 passes the window features as an IPropertyBag. This is analagous to 9412 the -createWebViewWithRequest:windowFeatures: method added to 9413 WebUIDelegate on Mac in r27452. Also added key strings for use with 9414 the window features property bag. 9415 9416 * WebCoreSupport/WebChromeClient.cpp: 9417 (createWindowFeaturesPropertyBag): Added this helper function to turn 9418 a WebCore::WindowFeatures into an IPropertyBag for passing to WebKit 9419 clients. 9420 (WebChromeClient::createWindow): If the UI delegate implements 9421 IWebUIDelegatePrivate2, call the new createWebViewWithRequest function 9422 that takes a window features property bag. If the delegate doesn't 9423 implement the new function, fall back to the old functions. 9424 9425 2009-08-20 Adam Roben <aroben (a] apple.com> 9426 9427 A little clean-up in WebChromeClient::createWindow 9428 9429 Reviewed by Steve Falkenburg. 9430 9431 * WebCoreSupport/WebChromeClient.cpp: 9432 (WebChromeClient::createWindow): Refactored to share more code between 9433 the dialog and non-dialog cases. 9434 9435 2009-08-28 Gustavo Noronha Silva <gustavo.noronha (a] collabora.co.uk> 9436 9437 Reviewed by Holger Freyther. 9438 9439 https://bugs.webkit.org/show_bug.cgi?id=25889 9440 [GTK] scrollbar policy for main frame is not implementable 9441 9442 Add empty implementation for new ChromeClient method. 9443 9444 * WebCoreSupport/WebChromeClient.h: 9445 (WebChromeClient::scrollbarsModeDidChange): 9446 9447 2009-08-27 Brent Fulgham <bfulgham (a] webkit.org> 9448 9449 Reviewed by Adam Roben. 9450 9451 Modify Release_Cairo target to build testapi using the 9452 Release_CFLite target so that the correct CoreFoundation 9453 (in this case, CFLite.dll) is linked. 9454 9455 * WebKit.vcproj/WebKit.sln: 9456 9457 2009-08-26 Adam Barth <abarth (a] webkit.org> 9458 9459 Reviewed by Oliver Hunt. 9460 9461 Don't let local files access web URLs 9462 https://bugs.webkit.org/show_bug.cgi?id=28480 9463 9464 * WebPreferences.cpp: 9465 (WebPreferences::initializeDefaultSettings): 9466 9467 2009-08-26 David Levin <levin (a] chromium.org> 9468 9469 Reviewed by Darin Fisher. 9470 9471 ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http. 9472 https://bugs.webkit.org/show_bug.cgi?id=28735 9473 9474 * WebMutableURLRequest.cpp: 9475 (WebMutableURLRequest::setHTTPShouldHandleCookies): 9476 9477 2009-08-25 Eric Carlson <eric.carlson (a] apple.com> 9478 9479 Reviewed by Oliver Hunt. 9480 9481 <video> and <audio> controller should be accessible 9482 https://bugs.webkit.org/show_bug.cgi?id=28081 9483 9484 * WebCoreLocalizedStrings.cpp: 9485 (WebCore::localizedMediaControlElementString): 9486 (WebCore::localizedMediaControlElementHelpText): 9487 (WebCore::localizedMediaTimeDescription): 9488 New. 9489 9490 2009-08-25 Brent Fulgham <bfulgham (a] webkit.org> 9491 9492 Build fix for Windows. 9493 9494 Revise Debug_Cairo build target to build testapi, jsc, WinLauncher, 9495 DumpRenderTree, and TestNetscapeAPI using WinCairo debug build 9496 settings so they link against the proper libraries. 9497 9498 * WebKit.vcproj/WebKit.sln: 9499 9500 2009-08-25 David Levin <levin (a] chromium.org> 9501 9502 Reviewed by Adam Roben. 9503 9504 PLATFORM(CFNETWORK) should be USE(CFNETWORK). 9505 https://bugs.webkit.org/show_bug.cgi?id=28713 9506 9507 Also, moved the #if header section after the other #includes. 9508 9509 * WebError.cpp: 9510 (WebError::localizedDescription): 9511 9512 2009-08-24 Brent Fulgham <bfulgham (a] webkit.org> 9513 9514 Reviewed by Steve Falkenburg. 9515 9516 Revise CFLite Debug build to emit DLL's with _debug label. 9517 https://bugs.webkit.org/show_bug.cgi?id=28695. 9518 9519 * WebKit.vcproj/WebKit.vcproj: Modify Debug_Cairo target to 9520 inherit from new debug_wincairo property sheet, instead of 9521 the current debug sheet. 9522 9523 2009-08-22 Adam Barth <abarth (a] webkit.org> 9524 9525 Revert 47684. We're going to do this later once clients have had a 9526 chance to opt into the setting they like. 9527 9528 * WebPreferences.cpp: 9529 (WebPreferences::initializeDefaultSettings): 9530 9531 2009-08-22 Adam Barth <abarth (a] webkit.org> 9532 9533 Reviewed by Eric Seidel. 9534 9535 Don't let local files access web URLs 9536 https://bugs.webkit.org/show_bug.cgi?id=28480 9537 9538 * WebPreferences.cpp: 9539 (WebPreferences::initializeDefaultSettings): 9540 9541 2009-08-20 Brian Weinstein <bweinstein (a] apple.com> 9542 9543 Reviewed by Adam Roben. 9544 9545 Fix of <http://webkit.org/b/27850>. Panning by emulating Mouse Wheel Events breaks Google Maps. 9546 9547 Switched to using RenderLayer::scrollByRecursively instead of emulating a mouse wheel, 9548 and switched to handling the hit testing in WebView from doing it as part of the mouse wheel event. 9549 One downside of this fix is that panning will not jump out of frames anymore (same behavior as pan-scrolling), but 9550 this is tracked in <http://webkit.org/b/28237>. 9551 9552 * WebView.cpp: 9553 (WebView::gestureNotify): Added hit testing here to figure out the node the user started the gesture on. 9554 (WebView::gesture): Switched from emulating mouse wheel events for panning to calling RenderLayer::scrollByRecursively. 9555 * WebView.h: 9556 9557 2009-08-18 Brian Weinstein <bweinstein (a] apple.com> 9558 9559 Reviewed by Oliver Hunt. 9560 9561 Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support 9562 LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota. 9563 9564 Added a setQuota interface method to IWebDatabaseManager and implemented it. 9565 9566 * Interfaces/IWebDatabaseManager.idl: 9567 * WebDatabaseManager.cpp: 9568 (WebDatabaseManager::setQuota): 9569 * WebDatabaseManager.h: 9570 9571 2009-08-18 Drew Wilson <atwilson (a] google.com> 9572 9573 Unreviewed (build break). 9574 9575 Added missing include for WebWorkersPrivate.h. 9576 9577 * WebKitClassFactory.cpp: 9578 9579 2009-08-18 Peter Kasting <pkasting (a] google.com> 9580 9581 Reviewed by Eric Seidel. 9582 9583 https://bugs.webkit.org/show_bug.cgi?id=28415 9584 Set svn:eol-style CRLF on all .sln and .vcproj files that don't already 9585 have it. 9586 9587 * WebKit.vcproj/InterfacesGenerated.vcproj: 9588 9589 2009-08-18 Drew Wilson <atwilson (a] google.com> 9590 9591 Reviewed by Eric Seidel. 9592 9593 Need to extend DumpRenderTree to expose number of worker threads 9594 https://bugs.webkit.org/show_bug.cgi?id=28292 9595 9596 Defined/implemented COM interfaces to expose WorkerThread::workerThreadCount() for DumpRenderTree. 9597 9598 * ForEachCoClass.h: 9599 Added WebWorkersPrivate. 9600 * Interfaces/IWebWorkersPrivate.idl: Added. 9601 * Interfaces/WebKit.idl: 9602 Added WebWorkersPrivate. 9603 * WebKit.vcproj/Interfaces.vcproj: 9604 * WebKit.vcproj/WebKit.vcproj: 9605 * WebWorkersPrivate.cpp: Added. 9606 Implementation of the IWebWorkersPrivate COM interface, to expose workerThreadCount() for DumpRenderTree. 9607 (WebWorkersPrivate::QueryInterface): 9608 (WebWorkersPrivate::AddRef): 9609 (WebWorkersPrivate::Release): 9610 (WebWorkersPrivate::workerThreadCount): 9611 (WebWorkersPrivate::createInstance): 9612 (WebWorkersPrivate::WebWorkersPrivate): 9613 (WebWorkersPrivate::~WebWorkersPrivate): 9614 * WebWorkersPrivate.h: Added. 9615 9616 2009-08-17 Peter Kasting <pkasting (a] google.com> 9617 9618 Reviewed by Steve Falkenburg. 9619 9620 https://bugs.webkit.org/show_bug.cgi?id=27323 9621 Only add Cygwin to the path when it isn't already there. This avoids 9622 causing problems for people who purposefully have non-Cygwin versions of 9623 executables like svn in front of the Cygwin ones in their paths. 9624 9625 * WebKit.vcproj/Interfaces.vcproj: 9626 * WebKit.vcproj/InterfacesGenerated.vcproj: 9627 * WebKit.vcproj/WebKit.vcproj: 9628 * WebKit.vcproj/WebKitGUID.vcproj: 9629 9630 2009-08-17 Simon Fraser <simon.fraser (a] apple.com> 9631 9632 Speculative fix for Windows build bustage. 9633 9634 * DOMHTMLClasses.cpp: 9635 (DOMHTMLElement::idName): 9636 9637 2009-08-13 Jon Honeycutt <jhoneycutt (a] apple.com> 9638 9639 Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit 9640 nightly (20866) 9641 9642 https://bugs.webkit.org/show_bug.cgi?id=20866 9643 9644 Reviewed by Oliver Hunt. 9645 9646 * AccessibleBase.cpp: 9647 (AccessibleBase::getAccessibilityObjectForChild): 9648 If the child ID is negative, negate it and treat it as an AXID. 9649 9650 2009-08-12 Brian Weinstein <bweinstein (a] apple.com> 9651 9652 Reviewed by Adam Roben. 9653 9654 Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down 9655 list detaches drop down. 9656 9657 Added a check in mouseWheel to see if our focus is currently in a popup, if so, close 9658 the popup (matches other browser behavior). 9659 9660 * WebView.cpp: 9661 (WebView::mouseWheel): 9662 9663 2009-08-12 Adam Roben <aroben (a] apple.com> 9664 9665 Make WebPreferenceKeysPrivate.h available for client use 9666 9667 Reviewed by Dave Hyatt. 9668 9669 Fixes <http://webkit.org/b/28227>. 9670 9671 * WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to 9672 $WebKitOutputDir, just like we do for a few other headers. Also let VS 9673 reorder some XML attributes. 9674 9675 * WebPreferenceKeysPrivate.h: Touched this file to force a build. 9676 9677 2009-08-11 Adam Roben <aroben (a] apple.com> 9678 9679 Remove support for a window resizer within the WebView 9680 9681 Starting with Safari 4, there is never a window resizer inside the 9682 WebView, so we no longer need to support that functionality. 9683 9684 Fixes <http://webkit.org/b/28190> Remove support for a window resizer 9685 within the WebView 9686 9687 Reviewed by Dave Hyatt. 9688 9689 * Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate 9690 functions related to the window resizer with unused*() functions. We 9691 can't remove them entirely because we need to keep the vtable 9692 unchanged so new versions of WebKit will work with old versions of 9693 Safari (e.g., for nightlies and WebKit development). 9694 9695 * WebCoreSupport/WebChromeClient.cpp: 9696 (WebChromeClient::windowResizerRect): Now always returns an empty 9697 rect. 9698 9699 * WebView.cpp: 9700 (WebView::paint): 9701 (WebView::handleMouseEvent): 9702 * WebView.h: 9703 Removed window-resizer-related code. 9704 9705 2009-08-11 John Gregg <johnnyg (a] google.com> 9706 9707 Reviewed by Maciej Stachowiak. 9708 9709 Move the accessor for notifications presenter from WebUIDelegate 9710 to WebUIDelegate2 which extends it. When making this call from 9711 WebCoreSupport, check using QueryInterface before calling. 9712 9713 https://bugs.webkit.org/show_bug.cgi?id=28198 9714 9715 * Interfaces/IWebUIDelegate.idl: 9716 * Interfaces/IWebUIDelegate2.idl: Added. 9717 * Interfaces/WebKit.idl: 9718 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: 9719 (WebDesktopNotificationsDelegate::show): 9720 (WebDesktopNotificationsDelegate::cancel): 9721 (WebDesktopNotificationsDelegate::notificationObjectDestroyed): 9722 (WebDesktopNotificationsDelegate::requestPermission): 9723 (WebDesktopNotificationsDelegate::checkPermission): 9724 (WebDesktopNotificationsDelegate::hasNotificationDelegate): 9725 (WebDesktopNotificationsDelegate::notificationDelegate): 9726 * WebCoreSupport/WebDesktopNotificationsDelegate.h: 9727 9728 2009-08-11 Drew Wilson <atwilson (a] google.com> 9729 9730 Reviewed by NOBODY (build break). 9731 9732 Speculative Windows build fix - undo previous unnecessary change. 9733 9734 * WebCoreSupport/WebDesktopNotificationsDelegate.h: 9735 9736 2009-08-11 Brian Weinstein <bweinstein (a] apple.com> 9737 9738 Reviewed by Steve Falkenburg. 9739 9740 Refactored MIMETypeforExtension to be a member of IWebViewPrivate 9741 instead of IWebView. 9742 9743 * Interfaces/IWebView.idl: 9744 * Interfaces/IWebViewPrivate.idl: 9745 * WebView.cpp: 9746 (WebView::MIMETypeForExtension): 9747 * WebView.h: 9748 9749 2009-08-11 Drew Wilson <atwilson (a] google.com> 9750 9751 Reviewed by NOBODY (build break) 9752 9753 Speculative fix for windows build break. 9754 9755 * WebKitSupport/WebDesktopNotificationsDelegate.h: 9756 WebCore/Notification*.h => WebCore/notifications/Notification*.h 9757 9758 2009-08-11 John Gregg <johnnyg (a] google.com> 9759 9760 Reviewed by Maciej Stachowiak. 9761 9762 Desktop Notifications API 9763 https://bugs.webkit.org/show_bug.cgi?id=25643 9764 9765 Adds test hooks for notification features to WebCoreSupport for 9766 use in DumpRenderTree. 9767 9768 * Interfaces/IWebDesktopNotificationsDelegate.idl: Added. 9769 * Interfaces/IWebUIDelegate.idl: 9770 * Interfaces/WebKit.idl: 9771 * WebCoreSupport/WebChromeClient.cpp: 9772 (WebChromeClient::WebChromeClient): 9773 * WebCoreSupport/WebChromeClient.h: 9774 (WebChromeClient::notificationPresenter): 9775 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added. 9776 (NotificationCOMWrapper::create): 9777 (NotificationCOMWrapper::NotificationCOMWrapper): 9778 (NotificationCOMWrapper::QueryInterface): 9779 (NotificationCOMWrapper::AddRef): 9780 (NotificationCOMWrapper::Release): 9781 (NotificationCOMWrapper::isHTML): 9782 (NotificationCOMWrapper::contentsURL): 9783 (NotificationCOMWrapper::iconURL): 9784 (NotificationCOMWrapper::title): 9785 (NotificationCOMWrapper::text): 9786 (NotificationCOMWrapper::notifyDisplay): 9787 (NotificationCOMWrapper::notifyError): 9788 (NotificationCOMWrapper::notifyClose): 9789 (WebDesktopNotificationsDelegate::WebDesktopNotificationsDelegate): 9790 (WebDesktopNotificationsDelegate::show): 9791 (WebDesktopNotificationsDelegate::cancel): 9792 (WebDesktopNotificationsDelegate::notificationObjectDestroyed): 9793 (WebDesktopNotificationsDelegate::requestPermission): 9794 (WebDesktopNotificationsDelegate::checkPermission): 9795 (WebDesktopNotificationsDelegate::notificationDelegate): 9796 * WebCoreSupport/WebDesktopNotificationsDelegate.h: Added. 9797 * WebCoreSupport/WebInspectorDelegate.h: 9798 (WebInspectorDelegate::desktopNotificationsDelegate): 9799 * WebKit.vcproj/Interfaces.vcproj: 9800 * WebKit.vcproj/WebKit.vcproj: 9801 9802 2009-08-11 Brian Weinstein <bweinstein (a] apple.com> 9803 9804 Reviewed by Adam Roben. 9805 9806 Fix of <rdar://5016504> SVG file cannot be dragged to webview, 9807 but can be opened via Open File. 9808 9809 Added a new function to IWebView that gets the MIME type for a given 9810 extension from the MIMETypeRegistry. 9811 9812 * Interfaces/IWebView.idl: 9813 * WebView.cpp: 9814 (WebView::MIMETypeForExtension): 9815 * WebView.h: 9816 9817 2009-08-11 Dmitry Titov <dimich (a] chromium.org> 9818 9819 Reviewed by Adam Roben. 9820 9821 Originally implemented by Glenn Wilson <gwilson (a] chromium.org>. 9822 9823 Added support for overriding default preferences per-test. 9824 See https://bugs.webkit.org/show_bug.cgi?id=20534 9825 9826 * Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest 9827 * WebPreferences.cpp: same. 9828 * WebPreferences.h: same. 9829 9830 2009-08-10 Dan Bernstein <mitz (a] apple.com> 9831 9832 Reviewed by Darin Adler. 9833 9834 Link drag images specify Lucida Grande on Windows and end up using Times 9835 New Roman 9836 <rdar://problem/7117835> 9837 9838 * WebCoreSupport/WebDragClient.cpp: 9839 (dragLabelFont): Added a RenderingMode parameter and changed to use the 9840 same typeface as the Windows small caption font. 9841 (WebDragClient::createDragImageForLink): Changed to respect the 9842 pages rendering mode. 9843 9844 2009-08-10 Brent Fulgham <bfulgham (a] webkit.org> 9845 9846 Reviewed by Adam Roben. 9847 9848 https://bugs.webkit.org/show_bug.cgi?id=28048. 9849 Move various WinCairo build settings into *.vsprops file. 9850 9851 * WebKit.vcproj/WebKit.vcproj: Add new cURL.vsprops property sheet 9852 (which contains link settings for cURL and its dependencies), and 9853 remove the corresponding entries from the vcproj file. Remove 9854 png, jpeg, cairo library linking flags from vcproj, now that they 9855 are in the WinCairo.vsprops file. 9856 9857 2009-08-09 Nikolas Zimmermann <nikolas.zimmermann (a] torchmobile.com> 9858 9859 Reviewed by George Staikos. 9860 9861 [WML] Deck access control is completly broken 9862 https://bugs.webkit.org/show_bug.cgi?id=27721 9863 9864 Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'. 9865 9866 * Interfaces/IWebFramePrivate.idl: 9867 9868 2009-08-09 Nikolas Zimmermann <nikolas.zimmermann (a] torchmobile.com> 9869 9870 Reviewed by Maciej Stachowiak. 9871 9872 FrameLoadType / WebFrameLoadType enums are out of sync 9873 https://bugs.webkit.org/show_bug.cgi?id=28132 9874 9875 Synchronize FrameLoadType <-> WebFrameLoadType enums (append missing 'WebFrameLoadTypeReloadFromOrigin' value) 9876 9877 * Interfaces/IWebFramePrivate.idl: 9878 9879 2009-08-06 Adam Barth <abarth (a] webkit.org> 9880 9881 Unreviewed revert. 9882 9883 http://bugs.webkit.org/show_bug.cgi?id=27879 9884 9885 Revert 46877 because it broke GTK. 9886 9887 * COMPropertyBag.h: 9888 9889 2009-08-06 Zoltan Horvath <hzoltan (a] inf.u-szeged.hu> 9890 9891 Reviewed by Adam Barth. 9892 9893 Change Noncopyable inheriting to public 9894 http://bugs.webkit.org/show_bug.cgi?id=27879 9895 9896 Since Noncopyable is inherited from FastAllocBase, 9897 Noncopyable's inheriting has been changed to public. 9898 9899 * COMPropertyBag.h: 9900 9901 2009-08-04 Alice Liu <alice.liu (a] apple.com> 9902 9903 "Shift + Enter" should behave like "Enter" in editable fields. 9904 Affects backward search in find-in-page in Safari for Windows 9905 9906 Reviewed by Jon Honeycutt. 9907 9908 * WebView.cpp: 9909 Register shift+enter as InsertNewline command, similar to other 9910 modifier+Enter combinations. 9911 9912 2009-07-29 Jon Honeycutt <jhoneycutt (a] apple.com> 9913 9914 Part of <rdar://problem/5698113> Safari shouldn't auto-activate 9915 plug-ins in background tabs (make Win consistent with Mac) 9916 9917 https://bugs.webkit.org/show_bug.cgi?id=27855 9918 9919 Reviewed by Adam Roben and Anders Carlsson. 9920 9921 * Interfaces/IWebViewPrivate.idl: 9922 Add setCanStartPlugins(). 9923 9924 * WebCoreSupport/WebFrameLoaderClient.cpp: 9925 (WebFrameLoaderClient::dispatchDidFailToStartPlugin): 9926 Added; code moved from createPlugin(). Modified to obtain the plug-in's 9927 page URL, the plug-ins "plug-ins page" parameter value, and the 9928 plug-in's MIME type by calling getter functions on the passed 9929 PluginView. 9930 (WebFrameLoaderClient::createPlugin): 9931 If the plug-in status is not "success," call 9932 dispatchDidFailToStartPlugin(). 9933 9934 * WebCoreSupport/WebFrameLoaderClient.h: 9935 Declare an override of dispatchDidFailToStartPlugin(). 9936 9937 * WebView.cpp: 9938 (WebViewWndProc): 9939 Add a missing ) to a comment. 9940 (WebView::setCanStartPlugins): 9941 Call the Page's setCanStartPlugins() function. 9942 9943 * WebView.h: 9944 9945 2009-07-30 Darin Adler <darin (a] apple.com> 9946 9947 Reviewed by David Levin. 9948 9949 Use checked casts for render tree 9950 https://bugs.webkit.org/show_bug.cgi?id=23522 9951 9952 * DOMHTMLClasses.cpp: 9953 (DOMHTMLInputElement::isUserEdited): 9954 (DOMHTMLTextAreaElement::isUserEdited): 9955 Use checked casts. 9956 9957 2009-07-31 Anders Carlsson <andersca (a] apple.com> 9958 9959 Reviewed by Dan Bernstein. 9960 9961 -Fix <rdar://problem/7104097> 9962 9963 Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count. 9964 9965 * WebCoreSupport/EmbeddedWidget.cpp: 9966 (EmbeddedWidget::create): 9967 * WebCoreSupport/EmbeddedWidget.h: 9968 9969 2009-07-29 Brian Weinstein <bweinstein (a] apple.com> 9970 9971 Was doing the build fix wrong, NotImplemented.h is in WebCore. 9972 9973 * WebCoreSupport/WebInspectorClient.cpp: 9974 9975 2009-07-29 Brian Weinstein <bweinstein (a] apple.com> 9976 9977 Windows build fix. 9978 9979 * WebCoreSupport/WebInspectorClient.cpp: 9980 9981 2009-07-29 Kevin McCullough <kmccullough (a] apple.com> 9982 9983 Reviewed by Darin Adler. 9984 9985 Added foundation work to allow a testing infrastructure for the Web 9986 Inspector. 9987 9988 * WebCoreSupport/WebInspectorClient.cpp: 9989 (WebInspectorClient::inspectorWindowObjectCleared): Empty definition 9990 to let Windows compile but we should implement this at some point so 9991 that the tests can be run on Windows too. 9992 * WebCoreSupport/WebInspectorClient.h: 9993 9994 2009-07-28 Tor Arne Vestb <tor.arne.vestbo (a] nokia.com> 9995 9996 Reviewed by Steve Falkenburg. 9997 9998 Add output directory for VS pre-build steps to enable out-of-tree builds 9999 10000 https://bugs.webkit.org/show_bug.cgi?id=27700 10001 10002 The tmp.obj file is now placed in the intermediate build directory. 10003 10004 * WebKit.vcproj/WebKit.vcproj: 10005 10006 2009-07-27 Brian Weinstein <bweinstein (a] apple.com> 10007 10008 Build fix for Windows. 10009 10010 * WebView.cpp: 10011 (WebView::stringByEvaluatingJavaScriptFromString): 10012 10013 2009-07-27 Alexey Proskuryakov <ap (a] webkit.org> 10014 10015 Reviewed by Darin Adler. 10016 10017 https://bugs.webkit.org/show_bug.cgi?id=27735 10018 Give a helpful name to JSLock constructor argument 10019 10020 * WebCoreStatistics.cpp: 10021 (WebCoreStatistics::javaScriptObjectsCount): 10022 (WebCoreStatistics::javaScriptGlobalObjectsCount): 10023 (WebCoreStatistics::javaScriptProtectedObjectsCount): 10024 (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount): 10025 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts): 10026 * WebJavaScriptCollector.cpp: 10027 (WebJavaScriptCollector::objectCount): 10028 * WebView.cpp: 10029 (WebView::stringByEvaluatingJavaScriptFromString): 10030 10031 2009-07-25 Kwang Yul Seo <skyul (a] company100.net> 10032 10033 Reviewed by Darin Adler. 10034 10035 Windows build break due to warning C4819 10036 https://bugs.webkit.org/show_bug.cgi?id=27416 10037 10038 Disable C4819 warning to fix build. 10039 10040 * WebKit.vcproj/WebKit.vcproj: 10041 10042 2009-07-24 Brent Fulgham <bfulgham (a] webkit.org> 10043 10044 Reviewed by Dave Hyatt. 10045 10046 Clean up dependencies on Apple support libraries for non-Apple build. 10047 http://bugs.webkit.org/show_bug.cgi?id=27532. 10048 10049 * DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h 10050 * WebDownload.h: Conditionalize include of CFNetwork.h 10051 * WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h 10052 10053 2009-07-24 Andrei Popescu <andreip (a] google.com> 10054 10055 Reviewed by Anders Carlsson. 10056 10057 ApplicationCache should have size limit 10058 https://bugs.webkit.org/show_bug.cgi?id=22700 10059 10060 * WebCoreSupport/WebChromeClient.cpp: 10061 (WebChromeClient::reachedMaxAppCacheSize): 10062 Adds empty implementation of the reachedMaxAppCacheSize callback. 10063 * WebCoreSupport/WebChromeClient.h: 10064 10065 2009-07-23 Brady Eidson <beidson (a] apple.com> 10066 10067 Reviewed by Geoff Garen. 10068 10069 WebFrameLoaderClient on Windows doesn't gracefully handle a null request returned from willSendRequest. 10070 https://bugs.webkit.org/show_bug.cgi?id=27595 10071 10072 * WebCoreSupport/WebFrameLoaderClient.cpp: 10073 (WebFrameLoaderClient::dispatchWillSendRequest): 10074 10075 2009-07-22 Takeshi Yoshino <tyoshino (a] google.com> 10076 10077 Reviewed by Darin Adler. 10078 10079 VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp 10080 https://bugs.webkit.org/show_bug.cgi?id=26375 10081 10082 Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp 10083 with hex escape sequences. 10084 10085 VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message ( 10086 treated as an error and stopped build). 10087 10088 WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be 10089 represented in the current code page (932). Save the file in Unicode format to prevent data loss 10090 10091 A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break 10092 localized string generation process. 10093 10094 * WebCoreLocalizedStrings.cpp: 10095 (WebCore::imageTitle): 10096 10097 2009-07-21 Roland Steiner <rolandsteiner (a] google.com> 10098 10099 Reviewed by David Levin. 10100 10101 Add ENABLE_RUBY to list of build options 10102 https://bugs.webkit.org/show_bug.cgi?id=27324 10103 10104 * WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY. 10105 10106 2009-07-20 Peter Kasting <pkasting (a] google.com> 10107 10108 Reviewed by Mark Rowe. 10109 10110 https://bugs.webkit.org/show_bug.cgi?id=27468 10111 Back out r46060, which caused problems for some Apple developers. 10112 10113 * WebKit.vcproj/Interfaces.vcproj: 10114 * WebKit.vcproj/InterfacesGenerated.vcproj: 10115 * WebKit.vcproj/WebKit.vcproj: 10116 * WebKit.vcproj/WebKitGUID.vcproj: 10117 10118 2009-07-17 Brian Weinstein <bweinstein (a] apple.com> 10119 10120 Reviewed by Adam Roben. 10121 10122 Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272) 10123 https://bugs.webkit.org/show_bug.cgi?id=14272 10124 10125 Implemented resizing of inspector window when it is in attached mode. Implemented setAttachedWindowHeight 10126 to set window sizes and redraw the inspector and the inspected web view, and used stored preferences 10127 in InspectorController.cpp to remember user's preferred height. 10128 10129 * WebCoreSupport/WebInspectorClient.cpp: 10130 10131 2009-07-17 Peter Kasting <pkasting (a] google.com> 10132 10133 Reviewed by Steve Falkenburg. 10134 10135 https://bugs.webkit.org/show_bug.cgi?id=27323 10136 Only add Cygwin to the path when it isn't already there. This avoids 10137 causing problems for people who purposefully have non-Cygwin versions of 10138 executables like svn in front of the Cygwin ones in their paths. 10139 10140 * WebKit.vcproj/Interfaces.vcproj: 10141 * WebKit.vcproj/InterfacesGenerated.vcproj: 10142 * WebKit.vcproj/WebKit.vcproj: 10143 * WebKit.vcproj/WebKitGUID.vcproj: 10144 10145 2009-07-16 Fumitoshi Ukai <ukai (a] chromium.org> 10146 10147 Reviewed by David Levin. 10148 10149 Add --web-sockets flag and ENABLE_WEB_SOCKETS define. 10150 https://bugs.webkit.org/show_bug.cgi?id=27206 10151 10152 Add ENABLE_WEB_SOCKETS 10153 10154 * WebKit.vcproj/WebKit.vcproj: add ENABLE_WEB_SOCKETS 10155 10156 2009-07-16 Xiaomei Ji <xji (a] chromium.org> 10157 10158 Reviewed by Darin Adler. 10159 10160 Fix tooltip does not get its directionality from its element's directionality. 10161 https://bugs.webkit.org/show_bug.cgi?id=24187 10162 10163 Per mitz's suggestion in comment #6, while getting the plain-text 10164 title, we also get the directionality of the title. How to handle 10165 the directionality is up to clients. Clients could ignore it, 10166 or use attribute or unicode control characters to display the title 10167 as what they want. 10168 10169 * WebCoreSupport/WebChromeClient.cpp: 10170 (WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet). 10171 * WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip(). 10172 * WebElementPropertyBag.cpp: 10173 (WebElementPropertyBag::Read): Change call of spellingToolTip() and title() due to signature change. 10174 10175 2009-07-15 Darin Adler <darin (a] apple.com> 10176 10177 Reviewed by Sam Weinig. 10178 10179 Renamed parseURL to deprecatedParseURL. 10180 10181 * WebCoreSupport/WebFrameLoaderClient.cpp: 10182 (WebFrameLoaderClient::createPlugin): Renamed. 10183 10184 2009-07-14 Steve Falkenburg <sfalken (a] apple.com> 10185 10186 Reorganize JavaScriptCore headers into: 10187 API: include/JavaScriptCore/ 10188 Private: include/private/JavaScriptCore/ 10189 10190 Reviewed by Darin Adler. 10191 10192 * WebKit.vcproj/WebKit.vcproj: 10193 10194 2009-07-14 Zoltan Horvath <hzoltan (a] inf.u-szeged.hu> 10195 10196 Reviewed by Darin Adler. 10197 10198 Change all Noncopyable inheriting visibility to public. 10199 https://bugs.webkit.org/show_bug.cgi?id=27225 10200 10201 Change all Noncopyable inheriting visibility to public because 10202 it is needed to the custom allocation framework (bug #20422). 10203 10204 * COMEnumVariant.h: 10205 * WebDatabaseManager.cpp: 10206 * WebInspector.h: 10207 * WebLocalizableStrings.cpp: 10208 10209 2009-07-13 Brent Fulgham <bfulgham (a] webkit.org> 10210 10211 Reviewed by Adam Roben. 10212 10213 Refactor WebFrame::spoolPages for easier sharing with Windows Cairo. 10214 https://bugs.webkit.org/show_bug.cgi?id=27240. 10215 10216 * WebFrame.cpp: 10217 (WebFrame::printHeader): New shared method to print the header. 10218 (WebFrame::printFooter): New shared method to print the footer. 10219 (WebFrame::spoolPage): New conditionally-compiled method to print 10220 a page. 10221 (WebFrame::spoolPages): Revised to call the platform-specific spoolPage 10222 for each page. 10223 * WebFrame.h: Add new method prototypes. 10224 10225 2009-07-13 Brent Fulgham <bfulgham (a] webkit.org> 10226 10227 Reviewed by Adam Roben. 10228 10229 Add new configuration flag for redistributable Windows build. 10230 https://bugs.webkit.org/show_bug.cgi=27087 10231 10232 * WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to 10233 Debug_Cairo and Release_Cairo targets. 10234 10235 2009-07-12 Brent Fulgham <bfulgham (a] gmail.com> 10236 10237 Speculative Windows build fix after http://trac.webkit.org/changeset/45786. 10238 10239 * WebCoreSupport/WebChromeClient.cpp: 10240 (WebChromeClient::addMessageToConsole): 10241 10242 2009-07-10 Adam Barth <abarth (a] webkit.org> 10243 10244 Reviewed by Sam Weinig with the power of Grayskull. 10245 10246 Enable XSSAuditor by default. 10247 10248 * WebPreferences.cpp: 10249 (WebPreferences::initializeDefaultSettings): 10250 10251 2009-07-09 Drew Wilson <atwilson (a] google.com> 10252 10253 Reviewed by Alexey Proskuryakov. 10254 10255 https://bugs.webkit.org/show_bug.cgi?id=26903 10256 10257 Turned on CHANNEL_MESSAGING by default because the MessageChannel API 10258 can now be implemented for Web Workers and is reasonably stable. 10259 10260 * WebKit.vcproj/WebKit.vcproj: 10261 10262 2009-07-09 Brian Weinstein <bweinstein (a] apple.com> 10263 10264 Reviewed by Alice Liu. 10265 10266 Fix of <rdar://5712929> Add preferences key to remember if the Inspector was docked (14271) 10267 https://bugs.webkit.org/show_bug.cgi?id=27140 10268 10269 Added a preference key to remember whether the user prefers the inspector detached or attached. 10270 10271 * WebCoreSupport/WebInspectorClient.cpp: 10272 (WebInspectorClient::showWindow): Pass both parameters into setWindowVisible 10273 (WebInspectorClient::closeWindow): Ditto 10274 (WebInspectorClient::attachWindow): Set preference to attached windows here 10275 (WebInspectorClient::detachWindow): Set preference to detached windows here 10276 (WebInspectorClient::showWindowWithoutNotifications): Read preference for attached vs. detached 10277 (WebInspectorClient::onClose): Pass both parameters into setWindowVisible 10278 10279 2009-07-09 Alexey Proskuryakov <ap (a] webkit.org> 10280 10281 Reviewed by Oliver Hunt. 10282 10283 <rdar://problem/6921671> Visit count shouldn't be incremented by redirects. 10284 10285 * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): 10286 Do not increase visit count if there is a redirect source. As a result, only pages that were 10287 explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking 10288 a link) will be counted. 10289 10290 * Interfaces/IWebHistoryItemPrivate.idl: 10291 * WebHistory.cpp: 10292 (WebHistory::visitedURL): 10293 * WebHistory.h: 10294 * WebHistoryItem.cpp: 10295 (WebHistoryItem::visitedWithTitle): 10296 * WebHistoryItem.h: 10297 Marshal this new argument all the way down to WebCore. 10298 10299 2009-07-09 Beth Dakin and Jon Honeycutt <bdakin (a] apple.com> 10300 10301 Reviewed by Dave Hyatt. 10302 10303 Make Widget RefCounted to fix: 10304 10305 <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 10306 at WebCore::Widget::afterMouseDown() after clicking To Do's close 10307 box 10308 <rdar://problem/6978804> WER #16: Repro Access Violation in 10309 WebCore::PluginView::bindingInstance (1310178023) 10310 -and- 10311 <rdar://problem/6991251> WER #13: Crash in WebKit! 10312 WebCore::PluginView::performRequest+203 (1311461169) 10313 10314 * WebCoreSupport/WebFrameLoaderClient.cpp: 10315 (WebFrameLoaderClient::createPlugin): 10316 * WebCoreSupport/WebFrameLoaderClient.h: 10317 * WebFrame.cpp: 10318 (WebFrame::createJavaAppletWidget): 10319 * WebFrame.h: 10320 10321 2009-07-09 Sam Weinig <sam (a] webkit.org> 10322 10323 Reviewed by Steve Falkenburg. 10324 10325 Roll out r43848. The quirk is no longer necessary. 10326 10327 * WebView.cpp: 10328 (WebView::userAgentForKURL): 10329 10330 2009-07-07 Ada Chan <adachan (a] apple.com> 10331 10332 Reviewed by Dave Hyatt. 10333 10334 Missed a call to FocusController::setFocused(true) when handling WM_SETFOCUS in WebView. 10335 https://bugs.webkit.org/show_bug.cgi?id=27057 10336 10337 * WebView.cpp: 10338 (WebViewWndProc): 10339 10340 2009-07-02 Erik Arvidsson <arv (a] chromium.org> 10341 10342 Reviewed by Adam Roben. 10343 10344 [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc 10345 https://bugs.webkit.org/show_bug.cgi?id=26699 10346 10347 * WebDropSource.cpp: 10348 (WebDropSource::QueryContinueDrag): 10349 10350 2009-07-02 Oliver Hunt <oliver (a] apple.com> 10351 10352 Reviewed by Anders Carlsson. 10353 10354 <rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670) 10355 <https://bugs.webkit.org/show_bug.cgi?id=26670> 10356 10357 Make windows loader client match mac behaviour more closely. 10358 10359 * WebCoreSupport/WebFrameLoaderClient.cpp: 10360 (WebFrameLoaderClient::forceLayout): 10361 10362 2009-06-30 Brent Fulgham <bfulgham (a] gmail.com> 10363 10364 Reviewed by Adam Roben. 10365 10366 Build DumpRenderTree under Cairo. 10367 https://bugs.webkit.org/show_bug.cgi?id=26457 10368 10369 * WebKit.vcproj/WebKit.sln: Add Cairo targets to the 10370 DumpRenderTree build, and use the in the Debug_Cairo 10371 and Release_Cairo targets. 10372 10373 2009-07-02 Eric Carlson <eric.carlson (a] apple.com> 10374 10375 Fix Windows build by including missing localized string methods. 10376 10377 * WebCoreLocalizedStrings.cpp: 10378 (WebCore::mediaElementLoadingStateText): 10379 (WebCore::mediaElementLiveBroadcastStateText): 10380 10381 2009-07-01 David Hyatt <hyatt (a] apple.com> 10382 10383 Reviewed by Tim Hatcher. 10384 10385 <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused, 10386 even though the field is not actually focused for keyboard input 10387 10388 Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the 10389 focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't 10390 have focus. 10391 10392 * WebView.cpp: 10393 (WebViewWndProc): 10394 10395 2009-06-29 David Hyatt <hyatt (a] apple.com> 10396 10397 Fix Windows bustage. Missed two configurations for enabling DATAGRID. 10398 10399 * WebKit.vcproj/WebKit.vcproj: 10400 10401 2009-06-29 Jessie Berlin <jberlin (a] apple.com> 10402 10403 Reviewed by Adam Roben. 10404 10405 Fix the windows build. 10406 10407 * WebCoreSupport/WebContextMenuClient.cpp: 10408 (WebContextMenuClient::isSpeaking): 10409 * WebCoreSupport/WebContextMenuClient.h: 10410 10411 2009-06-29 David Hyatt <hyatt (a] apple.com> 10412 10413 Reviewed by Adam Roben. 10414 10415 Make sure to patch all configurations to have datagrid enabled. 10416 10417 * WebKit.vcproj/WebKit.vcproj: 10418 10419 2009-06-29 David Hyatt <hyatt (a] apple.com> 10420 10421 Reviewed by Adam Roben. 10422 10423 Put <datagrid> behind an ifdef. 10424 10425 * WebKit.vcproj/WebKit.vcproj: 10426 10427 2009-06-26 Brian Weinstein <bweinstein (a] apple.com> 10428 10429 Reviewed by Simon Fraser. 10430 10431 https://bugs.webkit.org/show_bug.cgi?id=26695 10432 10433 Added hit testing on scrollbars, so if you start a gesture over a scrollbar, 10434 it isn't counted, and lets the user drag the scrollbar itself instead of a 10435 panning gesture. Also cleaned up code in gesture. 10436 10437 * WebView.cpp: 10438 (WebView::gestureNotify): 10439 (WebView::gesture): 10440 10441 2009-06-26 Jeremy Orlow <jorlow (a] chromium.org> 10442 10443 Reviewed by Adam Barth. 10444 10445 https://bugs.webkit.org/show_bug.cgi?id=26767 10446 10447 Fix a build break due to LocalStorage.h being included in WebKitDLL.cpp 10448 despite it being deleted from the repo by the following patch/commit: 10449 https://bugs.webkit.org/show_bug.cgi?id=26732 10450 http://trac.webkit.org/changeset/45290 10451 10452 * WebKitDLL.cpp: 10453 10454 2009-06-26 Yongjun Zhang <yongjun.zhang (a] nokia.com> 10455 10456 Reviewed by Eric Seidel. 10457 10458 Bug 20303: [Qt] Key events are not working in frames. 10459 10460 Move the scroll handling code to EventHandler so that other 10461 ports can share the functionality. 10462 10463 * WebView.cpp: 10464 (WebView::keyDown): 10465 (EnumTextMatches::QueryInterface): 10466 10467 2009-06-23 Anders Carlsson <andersca (a] apple.com> 10468 10469 Reviewed by Darin Adler. 10470 10471 WebKit side of <rdar://problem/6946094>. 10472 10473 * Interfaces/IWebUIDelegate.idl: 10474 Add a newPasteboard out parameter to willPerformDragSourceAction. 10475 10476 * WebCoreSupport/WebDragClient.cpp: 10477 (WebDragClient::willPerformDragSourceAction): 10478 Implement this. If the client returns a new pasteboard, use it for the drag. 10479 10480 * WebCoreSupport/WebInspectorDelegate.h: 10481 (WebInspectorDelegate::willPerformDragSourceAction): 10482 Add the new parameter. 10483 10484 2009-06-20 Darin Adler <darin (a] apple.com> 10485 10486 Reviewed by Sam Weinig. 10487 10488 <rdar://problem/6964221> Need more processing of pluginspage. 10489 10490 * WebCoreSupport/WebFrameLoaderClient.cpp: 10491 (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily. 10492 10493 2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen (a] openbossa.org> 10494 10495 Reviewed by Steve Falkenburg. 10496 10497 https://bugs.webkit.org/show_bug.cgi?id=26494 10498 Bug 26494: RenderTheme::themeForPage reads from Settings before it has 10499 been initialized by WebKit 10500 10501 Get the shouldPaintNativeControls preference and update the settings 10502 before initializing the page, as the page depends on it after the 10503 themeForPage change. 10504 10505 * WebView.cpp: 10506 (WebView::initWithFrame): 10507 10508 2009-06-19 Brian Weinstein <bweinstein (a] apple.com> 10509 10510 Reviewed by Steve Falkenburg. 10511 10512 https://bugs.webkit.org/show_bug.cgi?id=26488 10513 No Support for Single Finger or Two Finger Panning in Windows 7 10514 10515 Added the code necessary for single finger and two-finger panning with 10516 window bounce. We now register for WM_GESTURENOTIFY and WM_GESTURE messages, 10517 and interpret the panning command. Also, added WindowsTouch.h which contains 10518 structs and #defines from the Windows 7 SDK. 10519 10520 * WebKit.vcproj/WebKit.vcproj: 10521 * WebView.cpp: 10522 (WebView::gestureNotify): Checks if we are in a pannable region - IE: Not in the scrollbar 10523 (WebView::gesture): Handles the Panning gesture, creating the WheelEvent 10524 (WebViewWndProc): Added cases for WM_GESTURE and WM_GESTURENOTIFY 10525 * WebView.h: 10526 * WindowsTouch.h: Added. 10527 10528 2009-06-18 Adam Barth <abarth (a] webkit.org> 10529 10530 Reviewed by Sam Weinig. 10531 10532 https://bugs.webkit.org/show_bug.cgi?id=26199 10533 10534 Added preference to enable the XSSAuditor. 10535 10536 * Interfaces/IWebPreferencesPrivate.idl: 10537 * WebPreferenceKeysPrivate.h: 10538 * WebPreferences.cpp: 10539 (WebPreferences::initializeDefaultSettings): 10540 (WebPreferences::isXSSAuditorEnabled): 10541 (WebPreferences::setXSSAuditorEnabled): 10542 * WebPreferences.h: 10543 * WebView.cpp: 10544 (WebView::notifyPreferencesChanged): 10545 10546 2009-06-18 Brent Fulgham <bfulgham (a] gmail.com> 10547 10548 Reviewed by Dave Levin. 10549 10550 Remove some boilerplate using the BitmapInfo struct. 10551 https://bugs.webkit.org/show_bug.cgi?id=26425 10552 10553 * WebFrame.cpp: 10554 (WebFrame::spoolPages): 10555 * WebIconDatabase.cpp: 10556 (createDIB): 10557 * WebKit.vcproj/WebKit.sln: 10558 * WebNodeHighlight.cpp: 10559 (WebNodeHighlight::update): 10560 * WebView.cpp: 10561 (WebView::ensureBackingStore): 10562 10563 2009-06-17 Steve Falkenburg <sfalken (a] apple.com> 10564 10565 Consolidate WebKit COM interfaces. 10566 Moved IID from the highest numbered COM interface to the first interface and combined all methods. 10567 10568 Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces. 10569 10570 Reviewed by Adam Roben. 10571 10572 * Interfaces/IWebFrameLoadDelegate.idl: 10573 * Interfaces/IWebFrameLoadDelegatePrivate.idl: 10574 * Interfaces/IWebResourceLoadDelegatePrivate.idl: 10575 * Interfaces/IWebUIDelegate.idl: 10576 * Interfaces/IWebUIDelegatePrivate.idl: 10577 * Interfaces/WebKit.idl: 10578 * WebCoreSupport/WebChromeClient.cpp: 10579 * WebCoreSupport/WebChromeClient.h: 10580 * WebCoreSupport/WebContextMenuClient.cpp: 10581 * WebCoreSupport/WebFrameLoaderClient.cpp: 10582 * WebCoreSupport/WebInspectorDelegate.h: 10583 * WebFrame.cpp: 10584 * WebView.cpp: 10585 10586 2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen (a] openbossa.org> 10587 10588 Reviewed by Adam Roben. 10589 10590 Create a different RenderTheme per page, so that RenderTheme has 10591 access to page specific theming. This is needed for the Qt port, as Qt 10592 supports setting the theme (style) per widget. 10593 10594 This change was suggested and discussed with Dave Hyatt. 10595 10596 More detailed: 10597 10598 1) Create a theme per page or one global one, depending on the needs 10599 of the platform. 10600 2) Add an accesser to the theme from RenderObject. 10601 3) Change all uses of the theming to access the theme through 10602 RenderObject, using the global default theme as fallback, when the 10603 document of RenderObject has no page. 10604 When we don't have access to a RenderObject, use the default theme. 10605 4) Modify all RenderTheme platform implementations to work with the 10606 above changes, still creating only one global theme. 10607 10608 * WebView.cpp: 10609 (WebViewWndProc): Get the theme from the associated page. 10610 10611 2009-06-16 Brian Weinstein <bweinstein (a] apple.com> 10612 10613 Reviewed by Adam Roben. 10614 10615 Switch Control+Mousewheel Zooming definitions to match other browsers on Windows. 10616 Control+Mousewheel-Down now zooms out, Control+Mousewheel-Up now zooms in. 10617 https://bugs.webkit.org/show_bug.cgi?id=25875. 10618 <rdar://problem/6903976> 10619 10620 * WebView.cpp: 10621 (WebView::mouseWheel): 10622 10623 2009-06-16 Brent Fulgham <bfulgham (a] gmail.com> 10624 10625 Reviewed by Darin Adler. 10626 10627 Use consistent Windows GUID Comparison Functions. 10628 https://bugs.webkit.org/show_bug.cgi?id=26427. 10629 10630 * WebView.cpp: 10631 (EnumTextMatches::QueryInterface): 10632 10633 == Rolled over to ChangeLog-2009-06-16 == 10634
