Home | History | Annotate | Download | only in steps 
      1 # Copyright (C) 2010 Google Inc. All rights reserved.
      2 # 
      3 # Redistribution and use in source and binary forms, with or without
      4 # modification, are permitted provided that the following conditions are
      5 # met:
      6 # 
      7 #     * Redistributions of source code must retain the above copyright
      8 # notice, this list of conditions and the following disclaimer.
      9 #     * Redistributions in binary form must reproduce the above
     10 # copyright notice, this list of conditions and the following disclaimer
     11 # in the documentation and/or other materials provided with the
     12 # distribution.
     13 #     * Neither the name of Google Inc. nor the names of its
     14 # contributors may be used to endorse or promote products derived from
     15 # this software without specific prior written permission.
     16 # 
     17 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
     18 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
     19 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
     20 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
     21 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
     22 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
     23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
     24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
     25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
     26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
     27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     28 
     29 import os
     30 import re
     31 
     32 from webkitpy.common.checkout.changelog import ChangeLog
     33 from webkitpy.tool.steps.abstractstep import AbstractStep
     34 from webkitpy.tool.steps.options import Options
     35 from webkitpy.common.system.deprecated_logging import error, log
     36 
     37 
     38 # FIXME: Some of this logic should probably be unified with CommitterValidator?
     39 class ValidateReviewer(AbstractStep):
     40     # FIXME: This should probably move onto ChangeLogEntry
     41     def _has_valid_reviewer(self, changelog_entry):
     42         if changelog_entry.reviewer():
     43             return True
     44         if re.search("unreviewed", changelog_entry.contents(), re.IGNORECASE):
     45             return True
     46         if re.search("rubber[ -]stamp", changelog_entry.contents(), re.IGNORECASE):
     47             return True
     48         return False
     49 
     50     def run(self, state):
     51         # FIXME: For now we disable this check when a user is driving the script
     52         # this check is too draconian (and too poorly tested) to foist upon users.
     53         if not self._options.non_interactive:
     54             return
     55         for changelog_path in self.cached_lookup(state, "changelogs"):
     56             changelog_entry = ChangeLog(changelog_path).latest_entry()
     57             if self._has_valid_reviewer(changelog_entry):
     58                 continue
     59             reviewer_text = changelog_entry.reviewer_text()
     60             if reviewer_text:
     61                 log("%s found in %s does not appear to be a valid reviewer according to committers.py." % (reviewer_text, changelog_path))
     62             error('%s neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).' % changelog_path)
     63