Home | History | Annotate | Download | only in mac
      1 2006-02-09  Tim Omernick  <timo (a] apple.com>
      2 
      3         Reviewed by Darin Adler.
      4 
      5         <rdar://problem/4198378> Crash on a CFRelease when visiting http://www.akella.com/
      6 
      7         * Plugins/WebBaseNetscapePluginView.m:
      8         (-[WebBaseNetscapePluginView requestWithURLCString:]):
      9 	The true source of this crash is that the URL string is sometimes not NULL-terminated, which is the
     10 	Real Player plugin's fault.  That has been filed as 4439591.
     11 	However, we can be more bulletproof here by switching the URL string encoding from Windows Latin 1
     12 	to ISO Latin 1, so that any NULL-terminated string can be represented.  (As Darin and I found out
     13 	last night, Windows Latin 1 has "holes" in certain character ranges and	thus cannot encode arbitrary
     14 	C strings).
     15 
     16 2006-02-09  Maciej Stachowiak  <mjs (a] apple.com>
     17 
     18         Rubber stamped by Anders. 
     19         
     20         - Moved all the default delegate classes to their own directory.
     21 
     22         * DefaultDelegates: Added.
     23         * DefaultDelegates/WebDefaultContextMenuDelegate.h: Added.
     24         * DefaultDelegates/WebDefaultContextMenuDelegate.m: Added.
     25         * DefaultDelegates/WebDefaultEditingDelegate.h: Added.
     26         * DefaultDelegates/WebDefaultEditingDelegate.m: Added.
     27         * DefaultDelegates/WebDefaultFrameLoadDelegate.h: Added.
     28         * DefaultDelegates/WebDefaultFrameLoadDelegate.m: Added.
     29         * DefaultDelegates/WebDefaultPolicyDelegate.h: Added.
     30         * DefaultDelegates/WebDefaultPolicyDelegate.m: Added.
     31         * DefaultDelegates/WebDefaultResourceLoadDelegate.h: Added.
     32         * DefaultDelegates/WebDefaultResourceLoadDelegate.m: Added.
     33         * DefaultDelegates/WebDefaultScriptDebugDelegate.h: Added.
     34         * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Added.
     35         * DefaultDelegates/WebDefaultUIDelegate.h: Added.
     36         * DefaultDelegates/WebDefaultUIDelegate.m: Added.
     37         * WebKit.xcodeproj/project.pbxproj:
     38         * WebView/WebDefaultContextMenuDelegate.h: Removed.
     39         * WebView/WebDefaultContextMenuDelegate.m: Removed.
     40         * WebView/WebDefaultEditingDelegate.h: Removed.
     41         * WebView/WebDefaultEditingDelegate.m: Removed.
     42         * WebView/WebDefaultFrameLoadDelegate.h: Removed.
     43         * WebView/WebDefaultFrameLoadDelegate.m: Removed.
     44         * WebView/WebDefaultPolicyDelegate.h: Removed.
     45         * WebView/WebDefaultPolicyDelegate.m: Removed.
     46         * WebView/WebDefaultResourceLoadDelegate.h: Removed.
     47         * WebView/WebDefaultResourceLoadDelegate.m: Removed.
     48         * WebView/WebDefaultScriptDebugDelegate.h: Removed.
     49         * WebView/WebDefaultScriptDebugDelegate.m: Removed.
     50         * WebView/WebDefaultUIDelegate.h: Removed.
     51         * WebView/WebDefaultUIDelegate.m: Removed.
     52 
     53 2006-02-08  Justin Garcia  <justin.garcia (a] apple.com>
     54 
     55         Original patch by Graham Dennis, reviewed by me:
     56         
     57         <http://bugs.webkit.org/show_bug.cgi?id=3982>
     58         webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate
     59         
     60         Changes made by me, reviewed by thatcher:
     61         
     62         Made _setWindowHasFocus: and _setDisplaysWithFocusAttributes: into private SPI to allow
     63         for the testing of window.onFocus, window.onBlur, caret and focus halo painting, and 
     64         the focusing of content editable regions that happens as side effect of setting a selection,
     65         but only if the window has focus (7128).
     66 
     67         * WebCoreSupport/WebFrameBridge.m:
     68         (-[WebFrameBridge didBeginEditing]):
     69         (-[WebFrameBridge didEndEditing]):
     70         * WebView/WebHTMLView.m:
     71         (-[WebHTMLView updateFocusState]):
     72         (-[WebHTMLView _setWindowHasFocus:]):
     73         (-[WebHTMLView _setDisplaysWithFocusAttributes:]):
     74         * WebView/WebHTMLViewPrivate.h:
     75 
     76 2006-02-08  David Kilzer  <ddkilzer (a] kilzer.net>
     77 
     78         Reviewed by Darin.
     79 
     80         - Fix http://bugs.webkit.org/show_bug.cgi?id=3527
     81         Allow Safari to open postscript files in browser windows as well
     82 
     83         * WebView/WebPDFRepresentation.m:
     84         (+[WebPDFRepresentation postScriptMIMETypes]): Added.
     85         (+[WebPDFRepresentation supportedMIMETypes]): Include PostScript MIME types.
     86         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Added.
     87         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
     88         Handle PostScript conversion using new convertPostScriptDataSourceToPDF method.
     89 
     90 2006-02-07  Alexey Proskuryakov  <ap (a] nypop.com>
     91 
     92         Reviewed by Timothy.
     93 
     94         Convert JavaScript objects to appropriate AppleScript types, instead of only strings
     95         http://bugs.webkit.org/show_bug.cgi?id=7012
     96 
     97         Tests: fast/AppleScript/*
     98 
     99         * WebView/WebView.m:
    100         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Added.
    101         * WebView/WebViewPrivate.h:
    102 
    103 2006-02-06  Maciej Stachowiak  <mjs (a] apple.com>
    104 
    105         Reviewed by Eric.
    106 
    107         - fixed "remove frame, renderer and completed flag from ChildFrame, make Frame track these"
    108         http://bugs.webkit.org/show_bug.cgi?id=7125
    109         
    110         - fixed "onload event never called for iframe element with emtpy or about:blank src"
    111         http://bugs.webkit.org/show_bug.cgi?id=3609
    112 
    113         * WebCoreSupport/WebFrameBridge.h:
    114         * WebCoreSupport/WebFrameBridge.m:
    115         (-[WebFrameBridge initWithPage:webView:renderer:frameName:view:]): Pass along renderer.
    116         (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Pass along renderer.
    117         * WebCoreSupport/WebPageBridge.m:
    118         (-[WebPageBridge initWithMainFrameName:webView:frameView:]): Pass null for renderer.
    119         * WebView/WebView.m:
    120         * WebView/WebViewPrivate.h:
    121 
    122 2006-02-06  John Sullivan  <sullivan (a] apple.com>
    123 
    124         Reviewed by Maciej Stachowiak.
    125 
    126         * WebView/WebPDFView.m:
    127         (-[WebPDFView menuForEvent:]):
    128         Removed use of WKExecutableLinkedInTigerOrEarlier() by modifying backward-compatibility
    129         hack involving PDF view context menus. Now we only bother to make sure that the PDFKit-
    130         supplied context menu items are present in Safari, for the benefit of the open source
    131         folks using tip of tree WebKit but older released Safari; it's possible that some other
    132         existing WebKit apps won't show all the PDF view context menu items.
    133 
    134 2006-02-06  Maciej Stachowiak  <mjs (a] apple.com>
    135 
    136         Remove remaining .subproj references to fix release build.
    137 
    138         * WebKit.xcodeproj/project.pbxproj:
    139 
    140 2006-02-06  Maciej Stachowiak  <mjs (a] apple.com>
    141 
    142         Rubber stamped by Hyatt.
    143         
    144         - renamed subproject directories to not end with .subproj
    145 
    146         * Carbon: renamed from Carbon.subproj
    147         * DOM: renamed from DOM.subproj
    148         * History: renamed from History.subproj
    149         * Misc: renamed from Misc.subproj
    150         * Panels: renamed from Panels.subproj
    151         * Plugins: renamed from Plugins.subproj
    152         * WebCoreSupport: renamed from WebCoreSupport.subproj
    153         * WebInspector: renamed from WebInspector.subproj
    154         * WebView: renamed from WebView.subproj
    155         
    156 2006-02-06  Maciej Stachowiak  <mjs (a] apple.com>
    157 
    158         Ooops, I made a last-minute change to my last patch that broke the build - fixed.
    159 
    160         * WebView.subproj/WebFrame.m:
    161         (-[WebFrame _closeOldDataSources]):
    162         (-[WebFrame _detachFromParent]):
    163         (-[WebFrame _transitionToCommitted:]):
    164         (-[WebFrame _checkLoadCompleteForThisFrame]):
    165         (-[WebFrame _handledOnloadEvents]):
    166         (-[WebFrame _loadItem:withLoadType:]):
    167         (-[WebFrame _goToItem:withLoadType:]):
    168         (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
    169         (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
    170         (-[WebFrame _clientRedirectCancelled:]):
    171         * WebView.subproj/WebFramePrivate.h:
    172 
    173 2006-02-05  Maciej Stachowiak  <mjs (a] apple.com>
    174 
    175         Reviewed by Darin.
    176         
    177         - shuffle things around so that WebFrame no longer has a WebView backpointer, the backpointer is
    178         at the bridge level.
    179         http://bugs.webkit.org/show_bug.cgi?id=7093
    180 
    181         * WebCoreSupport.subproj/WebFrameBridge.h:
    182         * WebCoreSupport.subproj/WebFrameBridge.m:
    183         (-[WebFrameBridge initWithPage:webView:frameName:view:]):
    184         (-[WebFrameBridge page]):
    185         (-[WebFrameBridge mainFrame]):
    186         (-[WebFrameBridge webView]):
    187         (-[WebFrameBridge createWindowWithURL:frameName:]):
    188         (-[WebFrameBridge showWindow]):
    189         (-[WebFrameBridge areToolbarsVisible]):
    190         (-[WebFrameBridge setToolbarsVisible:]):
    191         (-[WebFrameBridge isStatusbarVisible]):
    192         (-[WebFrameBridge setStatusbarVisible:]):
    193         (-[WebFrameBridge setWindowFrame:]):
    194         (-[WebFrameBridge windowFrame]):
    195         (-[WebFrameBridge setWindowContentRect:]):
    196         (-[WebFrameBridge windowContentRect]):
    197         (-[WebFrameBridge setWindowIsResizable:]):
    198         (-[WebFrameBridge windowIsResizable]):
    199         (-[WebFrameBridge firstResponder]):
    200         (-[WebFrameBridge makeFirstResponder:]):
    201         (-[WebFrameBridge closeWindowSoon]):
    202         (-[WebFrameBridge runJavaScriptAlertPanelWithMessage:]):
    203         (-[WebFrameBridge runJavaScriptConfirmPanelWithMessage:]):
    204         (-[WebFrameBridge canRunBeforeUnloadConfirmPanel]):
    205         (-[WebFrameBridge runBeforeUnloadConfirmPanelWithMessage:]):
    206         (-[WebFrameBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]):
    207         (-[WebFrameBridge addMessageToConsole:]):
    208         (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]):
    209         (-[WebFrameBridge setStatusText:]):
    210         (-[WebFrameBridge startLoadingResource:withURL:customHeaders:]):
    211         (-[WebFrameBridge startLoadingResource:withURL:customHeaders:postData:]):
    212         (-[WebFrameBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
    213         (-[WebFrameBridge focusWindow]):
    214         (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
    215         (-[WebFrameBridge userAgentForURL:]):
    216         (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]):
    217         (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]):
    218         (-[WebFrameBridge defersLoading]):
    219         (-[WebFrameBridge setDefersLoading:]):
    220         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
    221         (-[WebFrameBridge _preferences]):
    222         (-[WebFrameBridge selectWordBeforeMenuEvent]):
    223         (-[WebFrameBridge historyLength]):
    224         (-[WebFrameBridge canGoBackOrForward:]):
    225         (-[WebFrameBridge goBackOrForward:]):
    226         (-[WebFrameBridge print]):
    227         (-[WebFrameBridge pollForAppletInView:]):
    228         (-[WebFrameBridge respondToChangedContents]):
    229         (-[WebFrameBridge respondToChangedSelection]):
    230         (-[WebFrameBridge undoManager]):
    231         (-[WebFrameBridge issueCutCommand]):
    232         (-[WebFrameBridge issueCopyCommand]):
    233         (-[WebFrameBridge issuePasteCommand]):
    234         (-[WebFrameBridge issuePasteAndMatchStyleCommand]):
    235         (-[WebFrameBridge canPaste]):
    236         (-[WebFrameBridge overrideMediaType]):
    237         (-[WebFrameBridge isEditable]):
    238         (-[WebFrameBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
    239         (-[WebFrameBridge shouldBeginEditing:]):
    240         (-[WebFrameBridge shouldEndEditing:]):
    241         (-[WebFrameBridge windowObjectCleared]):
    242         (-[WebFrameBridge spellCheckerDocumentTag]):
    243         (-[WebFrameBridge isContinuousSpellCheckingEnabled]):
    244         (-[WebFrameBridge didFirstLayout]):
    245         (-[WebFrameBridge dashboardRegionsChanged:]):
    246         (-[WebFrameBridge createModalDialogWithURL:]):
    247         (-[WebFrameBridge canRunModal]):
    248         (-[WebFrameBridge runModal]):
    249         * WebCoreSupport.subproj/WebPageBridge.h:
    250         * WebCoreSupport.subproj/WebPageBridge.m:
    251         (-[WebPageBridge initWithMainFrameName:webView:frameView:]):
    252         (-[WebPageBridge webView]):
    253         * WebView.subproj/WebDataSource.m:
    254         (-[WebDataSource _fileWrapperForURL:]):
    255         (-[WebDataSource _webView]):
    256         (-[WebDataSource _setLoading:]):
    257         (-[WebDataSource _startLoading:]):
    258         (-[WebDataSource _setTitle:]):
    259         (-[WebDataSource _setRequest:]):
    260         (-[WebDataSource _updateIconDatabaseWithURL:]):
    261         (-[WebDataSource _defersCallbacksChanged]):
    262         (-[WebDataSource _setWebFrame:]):
    263         * WebView.subproj/WebDataSourcePrivate.h:
    264         * WebView.subproj/WebFrame.m:
    265         (-[WebFrame _traverseNextFrameStayWithin::]):
    266         (-[WebFrame _detachFromParent]):
    267         (-[WebFrame _setDataSource:]):
    268         (-[WebFrame _loadDataSource:withLoadType:formState:]):
    269         (-[WebFrame _initWithWebFrameView:webView:bridge:]):
    270         (-[WebFrame dealloc]):
    271         (-[WebFrame finalize]):
    272         (-[WebFrame webView]):
    273         * WebView.subproj/WebFrameView.m:
    274         (-[WebFrameView _webView]):
    275         (-[WebFrameView _goBack]):
    276         (-[WebFrameView _goForward]):
    277         * WebView.subproj/WebFrameViewInternal.h:
    278         * WebView.subproj/WebView.m:
    279         (-[WebView _createFrameNamed:inParent:allowsScrolling:]):
    280         (-[WebView _commonInitializationWithFrameName:groupName:]):
    281 
    282 2006-02-04  Darin Adler  <darin (a] apple.com>
    283 
    284         Reviewed by Maciej.
    285 
    286         * Misc.subproj/WebCoreStatistics.h:
    287         * Misc.subproj/WebCoreStatistics.m:
    288         (+[WebCoreStatistics javaScriptRootObjectTypeCounts]):
    289         javaScriptRootObjecTypeCounts -> javaScriptRootObjectTypeCounts
    290 
    291 2006-02-04  Maciej Stachowiak  <mjs (a] apple.com>
    292 
    293         Reviewed by Hyatt.
    294 
    295         - change JavaScript collector statistics calls to use HashCountedSet instead
    296         of CFSet; other misc cleanup
    297         http://bugs.webkit.org/show_bug.cgi?id=7072
    298 
    299         * Misc.subproj/WebCoreStatistics.h:
    300         * Misc.subproj/WebCoreStatistics.m:
    301         (+[WebCoreStatistics javaScriptProtectedObjectsCount]): new
    302         (+[WebCoreStatistics javaScriptRootObjecTypeCounts]): new
    303         (+[WebCoreStatistics javaScriptRootObjectClasses]): deprecated
    304         (+[WebCoreStatistics javaScriptReferencedObjectsCount]): deprecated
    305         (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]): Just return 0. Deprecated.
    306 
    307 2006-02-03  Maciej Stachowiak  <mjs (a] apple.com>
    308 
    309         Reviewed by Darin.
    310         
    311         - change spellchecker preflighting to happen via class methods instead of
    312         object methods.
    313 
    314         * WebView.subproj/WebView.m:
    315         (-[WebView setContinuousSpellCheckingEnabled:]):
    316         (+[WebView _preflightSpellCheckerNow:]):
    317         (+[WebView _preflightSpellChecker]):
    318 
    319 2006-02-03  Timothy Hatcher  <timothy (a] apple.com>
    320 
    321         Reviewed by Justin.
    322 
    323         Renamed configuration names to Debug, Release and Production.
    324 
    325         * WebKit.xcodeproj/project.pbxproj:
    326 
    327 2006-02-02  David Hyatt  <hyatt (a] apple.com>
    328 
    329 	Fix for bug 6957, rewrite image rendering in C++ and move it to
    330         WebCore.  Animation now stops lazily and just uses the CachedObject
    331         notification system to push updates so that rects no longer need to
    332         be cached (or sets of animating renderers in specific views).
    333 
    334         Reviewed by darin
    335 
    336         * Misc.subproj/WebNSPasteboardExtras.h:
    337         * Misc.subproj/WebNSPasteboardExtras.m:
    338         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
    339         (-[NSPasteboard _web_declareAndWriteDragImage:element:URL:title:archive:source:]):
    340         * Misc.subproj/WebNSViewExtras.h:
    341         * Misc.subproj/WebNSViewExtras.m:
    342         (-[NSView _web_dragImage:element:rect:event:pasteboard:source:offset:]):
    343         * WebCoreSupport.subproj/WebImageData.m:
    344         (-[WebImageData init]):
    345         * WebCoreSupport.subproj/WebImageRendererFactory.m:
    346         (+[WebImageRendererFactory shouldUseThreadedDecoding]):
    347         (+[WebImageRendererFactory setShouldUseThreadedDecoding:]):
    348         (-[WebImageRendererFactory setPatternPhaseForContext:inUserSpace:]):
    349         (-[WebImageRendererFactory imageDataForName:]):
    350         * WebView.subproj/WebHTMLView.m:
    351         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
    352         (-[NSArray elementAtPoint:]):
    353         * WebView.subproj/WebImageView.m:
    354         (-[WebImageView writeImageToPasteboard:types:]):
    355         (-[WebImageView elementAtPoint:]):
    356         (-[WebImageView mouseDragged:]):
    357         * WebView.subproj/WebView.m:
    358         (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]):
    359 
    360 2006-01-31  John Sullivan  <sullivan (a] apple.com>
    361 
    362         Reviewed by Tim Omernick.
    363         
    364         - fixed <rdar://problem/4267144> REGRESSION (10.4.2): Safari pages auto-scroll too easily 
    365         during drag over content [5853]
    366         
    367         There were two issues here:
    368         (1) dragging over a non-editable webview (such as a typical Safari page) should not have
    369         auto-scrolled at all; the fact that it did was an uninentional side effect of making
    370         auto-scroll work for editable webviews a la Blot.
    371         (2) the speed & hot area of the auto-scroll changed between 10.4.1 and 10.4.2.
    372         
    373         I have a fix for (1), which is the much more important issue. I'll modify the bugzilla bug
    374         to be about the remaining issue.
    375 
    376         * WebView.subproj/WebView.m:
    377         (-[WebView _autoscrollForDraggingInfo:timeDelta:]):
    378         do nothing if not editable
    379         (-[WebView _shouldAutoscrollForDraggingInfo:]):
    380         return NO if not editable
    381 
    382 2006-01-31  John Sullivan  <sullivan (a] apple.com>
    383 
    384         Reviewed by Tim Omernick.
    385         
    386         Support for programmatic scrolling one line at a time for PDFs. (We already had support for
    387         programmatic scrolling one page at a time, and to top/end.)
    388 
    389         * WebView.subproj/WebPDFView.m:
    390         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
    391         generalized comment
    392         (-[WebPDFView scrollLineDown:]):
    393         pass a faked arrow-down key event
    394         (-[WebPDFView scrollLineUp:]):
    395         pass a faked arrow-up key event
    396 
    397 2006-01-31  Darin Adler  <darin (a] apple.com>
    398 
    399         Reviewed by Hyatt.
    400 
    401         * WebCoreSupport.subproj/WebFrameBridge.m:
    402         (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
    403         Updated for name change.
    404 
    405 2006-01-30  Timothy Hatcher  <timothy (a] apple.com>
    406 
    407         Reviewed by Tim O.
    408 
    409         Add -Wno-deprecated-declarations to the compile flags for WebNetscapePluginPackage.m.
    410         <rdar://problem/4427068> LMGetCurApRefNum, CloseConnection and GetDiskFragment now deprecated.
    411         When we workaround these we can remove this compile flag.
    412 
    413         * WebKit.xcodeproj/project.pbxproj:
    414 
    415 2006-01-30  Timothy Hatcher  <timothy (a] apple.com>
    416 
    417         Reviewed by Justin.
    418 
    419         Remove the only use of -[NSFont glyphPacking]. This method was deprecated in Tiger
    420         and always returns NSNativeShortGlyphPacking.
    421 
    422         * WebCoreSupport.subproj/WebTextRenderer.m:
    423         (-[WebTextRenderer initWithFont:]):
    424 
    425 2006-01-28  David Hyatt  <hyatt (a] apple.com>
    426 
    427         Clean up RenderImage, eliminating unneeded members and methods.
    428 	
    429         Reviewed by darin
    430 
    431         * WebCoreSupport.subproj/WebImageRenderer.h:
    432         * WebCoreSupport.subproj/WebImageRenderer.m:
    433         (-[WebImageRenderer copyWithZone:]):
    434         (-[WebImageRenderer size]):
    435         (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
    436 
    437 2006-01-26  Tim Omernick  <timo (a] apple.com>
    438 
    439         Reviewed by John Sullivan.
    440 
    441 	<rdar://problem/4422365>
    442 
    443         * WebView.subproj/WebHTMLView.m:
    444         (-[NSArray addSuperviewObservers]):
    445         In addition to registering for frame/bounds change notifications, call -_frameOrBoundsChanged.
    446         It will check the current size/scroll against the previous layout's size/scroll.  We need to
    447         do this here to catch the case where the WebView is laid out at one size, removed from its
    448         window, resized, and inserted into another window.  Our frame/bounds changed notifications
    449         will not be sent in that situation, since we only watch for changes while in the view hierarchy.
    450 
    451 	I have verified that this does not cause unnecessary layouts while running the PLT.
    452 
    453 2006-01-25  Vicki Murley  <vicki (a] apple.com>
    454 
    455         Reviewed by Beth Dakin.
    456 
    457 	- fix <rdar://problem/4351664> REGRESSION (420+): extra URL in b/f list - navigating back to 
    458 	previous page fails at apple.com/retail/)
    459  
    460         * WebView.subproj/WebFrame.m:
    461         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): grab the 
    462 	redirect flag of the current load before calling _loadURL, which clears this flag, 
    463         (-[WebFrame _transitionToCommitted:]): remove misleading comment
    464         * History.subproj/WebHistoryItem.m:
    465         (-[WebHistoryItem setURL:]): release resources in the page cache when setting
    466         the URL on a WebHistoryItem
    467 
    468 2006-01-25  Timothy Hatcher  <timothy (a] apple.com>
    469 
    470         Move off of -[NSFont widthOfString:] since it is now deprecated.
    471         Use the NSStringDrawing -[NSString sizeWithAttributes:] API.
    472 
    473         * WebCoreSupport.subproj/WebFileButton.m:
    474         (-[WebFileChooserButton bestVisualFrameSizeForCharacterCount:]):
    475 
    476 2006-01-23  Darin Adler  <darin (a] apple.com>
    477 
    478         - fixed some small localizable strings issues
    479 
    480         * WebInspector.subproj/WebInspector.m:
    481         (-[DOMNode _nodeTypeName]): Changed so we don't have two localizable strings that
    482         are both "Document". I'm not sure we want to localize the DOM inspector UI at all,
    483         but this fixes things for now.
    484         (-[DOMNode _displayName]): Ditto.
    485 
    486         * English.lproj/Localizable.strings: Updated.
    487         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
    488 
    489 2006-01-23  Justin Garcia  <justin.garcia (a] apple.com>
    490 
    491         Reviewed by thatcher
    492         
    493         Turned on -O2 for B&I build.
    494 
    495         * WebKit.xcodeproj/project.pbxproj:
    496 
    497 2006-01-22  Timothy Hatcher  <timothy (a] apple.com>
    498 
    499         Reviewed by Anders Carlsson.
    500         
    501         Makes the Inspector's Style pane take !important into account
    502         when marking overloaded properties.
    503 
    504         * WebInspector.subproj/webInspector/inspector.js:
    505 
    506 2006-01-21  Timothy Hatcher  <timothy (a] apple.com>
    507 
    508         Reviewed by Anders Carlsson.
    509 
    510         Make sure shorthand properties get striked-out if
    511         all the properties they expand into are overloaded.
    512 
    513         * WebInspector.subproj/webInspector/inspector.js:
    514 
    515 2006-01-21  Timothy Hatcher  <timothy (a] apple.com>
    516 
    517         Reviewed by Darin.
    518 
    519         Adds computed style to the Web Inspector.
    520         Adds a "mapped style" link to the mapped attributes.
    521 
    522         * WebInspector.subproj/webInspector/inspector.css:
    523         * WebInspector.subproj/webInspector/inspector.html:
    524         * WebInspector.subproj/webInspector/inspector.js:
    525 
    526 2006-01-20  Timothy Hatcher  <timothy (a] apple.com>
    527 
    528         Reviewed by John, some parts by Darin.
    529 
    530         Removes the old WebDebugDOMNode code, superseded by the ObjC DOM and the Web Inspector.
    531         Since Safari 2.0 still relies on these classes for the Debug menu's "Show DOM Tree", we remove
    532         that menu item to prevent a crash.
    533 
    534         * WebKit.exp: adds WebInspector, removes WebDebugDOMNode
    535         * WebKit.xcodeproj/project.pbxproj: added the REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM define so the new WebView code doesn't build in the Default config
    536         * WebView.subproj/WebDebugDOMNode.h: Removed.
    537         * WebView.subproj/WebDebugDOMNode.m: Removed.
    538         * WebView.subproj/WebView.m:
    539         (+[WebView initialize]): check if we are in Safari and IncludeDebugMenu is true then observe for NSApplicationDidFinishLaunchingNotification and call _finishedLaunching
    540         (+[WebView _finishedLaunching]): observe for NSMenuDidAddItemNotification now that the main menu is loaded and wait for the Debug menu to be added
    541         (+[WebView _removeDOMTreeMenuItem:]): when the debug menu is added remove the "Show DOM Tree" item
    542 
    543 2006-01-20  Timothy Hatcher  <timothy (a] apple.com>
    544 
    545         Reviewed by Hyatt.
    546 
    547         Corrects the cascade order for mapped attributes.
    548         Shows "inline stylesheet" rather than "null" for rules in <style> tags.
    549 
    550         * WebInspector.subproj/webInspector/inspector.js:
    551 
    552 2006-01-19  Timothy Hatcher  <timothy (a] apple.com>
    553 
    554         Reviewed by Eric.
    555 
    556         Adds inline style reporting and mapped attribute support to the Inspector Style pane.
    557         Cleans up the node attributes area with a more natural attr = "value" look.
    558         Slight optimization to only update visible scrollbars during a window resize.
    559 
    560         * WebInspector.subproj/webInspector/inspector.css:
    561         * WebInspector.subproj/webInspector/inspector.js:
    562 
    563 2006-01-19  Timothy Hatcher  <timothy (a] apple.com>
    564 
    565         Reviewed by Darin.
    566         
    567         http://bugs.webkit.org/show_bug.cgi?id=6631
    568         Inspector window has inappropriate maximum height
    569 
    570         * WebInspector.subproj/WebInspector.m:
    571         (-[WebInspector window]): removes the maximum size constraint
    572 
    573 2006-01-19  John Sullivan  <sullivan (a] apple.com>
    574 
    575         Reviewed by Tim Omernick.
    576 
    577         * WebKit.xcodeproj/project.pbxproj:
    578         made WebNSUserDefaultsExtras.h private (SPI) so its one method can be called from
    579         Safari, so Safari can stop calling the similar method in Foundation.
    580 
    581 2006-01-19  John Sullivan  <sullivan (a] apple.com>
    582 
    583         Reviewed by Tim Omernick.
    584         
    585         Made _webKit_guessedMIMEType SPI so Safari can use it in order to stop using
    586         the similar SPI method in Foundation. This involved splitting it out of the file
    587         it was in, to avoid creating any other new SPI here. Poor svn diff got mighty
    588         confused in the process.
    589 
    590         * Misc.subproj/WebNSDataExtras.h:
    591         removed _webkit_guessedMIMEType from here
    592         * Misc.subproj/WebNSDataExtrasPrivate.h: 
    593         Added. Contains only _webkit_guessedMIMEType. This file is private (SPI), whereas
    594         WebNSDataExtras.h is project-internal. I could have renamed WebNSDateExtras.h to
    595         WebNSDateExtrasInternal.h also, but I minimized the gratuitous change level here
    596         by not doing that.
    597         
    598         * Misc.subproj/WebNSDataExtras.m:
    599         Despite the great confusion of svn diff, all I actually did here was move 
    600         _webkit_guessedMIMEType and its helper _webkit_guessedMIMETypeForXML into a new
    601         category. No lines of code were harmed while creating this patch.
    602 
    603         * WebKit.xcodeproj/project.pbxproj:
    604         updated for new file
    605 
    606         * WebView.subproj/WebView.m:
    607         Added #import for new file since WebView uses _webkit_guessedMIMEType
    608 
    609 2006-01-19  John Sullivan  <sullivan (a] apple.com>
    610 
    611         Reviewed by Tim Omernick.
    612 
    613         * Misc.subproj/WebNSURLExtras.h:
    614         added declaration of _webkit_rangeOfURLScheme so Safari can call it as a step
    615         towards weaning Safari from Foundation SPI.
    616 
    617 2006-01-17  Justin Garcia  <justin.garcia (a] apple.com>
    618 
    619         Reviewed by eric
    620         
    621         Deployment builds now use -O2
    622 
    623         * WebKit.xcodeproj/project.pbxproj:
    624 
    625 2006-01-17  Beth Dakin  <bdakin (a] apple.com>
    626 
    627         Reviewed by Darin.
    628 
    629         Fix for <rdar://problem/4112029> With Quartz scaling on, Safari incorrectly 
    630         handles mouseover effects
    631 
    632         The location of an event in the window should be converted to the superview 
    633         of the contentView to do accurate hitTesting.
    634 
    635         * WebView.subproj/WebHTMLView.m:
    636         (-[WebHTMLView _updateMouseoverWithEvent:]): Convert the point to the
    637         contentView's superview from nil. 
    638 
    639 2006-01-16  Timothy Hatcher  <timothy (a] apple.com>
    640 
    641         Rubber stamped by Maciej.
    642 
    643         Check for a new "WebKitDeveloperExtras" default when
    644         including the "Inspect Element" context menu item.
    645         We should retire the other one eventually.
    646 
    647         * WebView.subproj/WebView.m:
    648         (-[WebView _menuForElement:defaultItems:]):
    649 
    650 2006-01-17  Anders Carlsson  <andersca (a] mac.com>
    651 
    652         Reviewed by Timothy Hatcher.
    653 
    654         - http://bugs.webkit.org/show_bug.cgi?id=6594
    655         Web Inspector: finish node attributes
    656         
    657         * WebInspector.subproj/webInspector/inspector.css:
    658         * WebInspector.subproj/webInspector/inspector.html:
    659         * WebInspector.subproj/webInspector/inspector.js:
    660         Add initial support for element attributes.
    661 
    662 2006-01-16  John Sullivan  <sullivan (a] apple.com>
    663 
    664         Reviewed by Vicki Murley.
    665         
    666         - fixed <rdar://problem/4409288> REGRESSION (TOT): When no selection is present on page, 
    667         Jump to Selection doesn't beep
    668 
    669         * WebView.subproj/WebHTMLView.m:
    670         (-[WebHTMLView _hasInsertionPoint]):
    671         new helper method
    672         (-[NSArray validateUserInterfaceItem:]):
    673         Don't validate this menu item (or a couple of others) if the selection is a caret and
    674         the page isn't editable. In that state, there is no visible selection so this menu item
    675         doesn't make sense. I suspect this was broken by some editing-related change that makes
    676         selectionState return WebSelectionStateCaret here where it used to return WebSelectionStateNone.
    677 
    678 2006-01-16  Tim Omernick  <timo (a] apple.com>
    679 
    680         Reviewed by John Sullivan.
    681 
    682 	WebKit part of <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla
    683 
    684         * Plugins.subproj/WebBaseNetscapePluginView.m:
    685         (-[WebBaseNetscapePluginView getVariable:value:]):
    686 	The returned window script object is expected to be retained, as described here:
    687 	<http://www.mozilla.org/projects/plugins/npruntime.html#browseraccess>
    688 
    689 2006-01-16  Anders Carlsson  <andersca (a] mac.com>
    690 
    691         Reviewed by Darin.
    692 
    693         * WebInspector.subproj/webInspector/inspector.js:
    694         Use defined NodeType values instead of integers.
    695 
    696 2006-01-15  Timothy Hatcher  <timothy (a] apple.com>
    697 
    698         Reviewed by Darin.
    699  
    700         New DOM Inspector that lives in WebKit and is accessible from any WebView.
    701         Accessible from a contextual menu when the WebKitEnableInspectElementContextMenuItem default is
    702         true or you have a development build. Browsing the tree, serialized HTML and CSS rules work.
    703  
    704         To always enable enter the following in the Terminal (change the bundle id to affect other WebKit apps):
    705         defaults write com.apple.Safari WebKitEnableInspectElementContextMenuItem -bool true
    706  
    707         http://bugs.webkit.org/show_bug.cgi?id=6571
    708 
    709         * English.lproj/Localizable.strings:
    710         * English.lproj/StringsNotToBeLocalized.txt: reorder of the entries
    711         * Misc.subproj/WebKitNSStringExtras.h:
    712         * Misc.subproj/WebKitNSStringExtras.m:
    713         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): collapses consecutive whitespace into a single space
    714         * WebCoreSupport.subproj/WebFrameBridge.m:
    715         (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): cleanup
    716         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): call the new UI delegate method
    717         * WebInspector.subproj: Added.
    718         * WebInspector.subproj/WebInspector.h: Added.
    719         * WebInspector.subproj/WebInspector.m: Added.
    720         (+[WebInspector sharedWebInspector]):
    721         (-[WebInspector init]):
    722         (-[WebInspector initWithWebFrame:]):
    723         (-[WebInspector dealloc]):
    724         (-[WebInspector window]):
    725         (-[WebInspector windowDidLoad]):
    726         (-[WebInspector windowWillClose:]):
    727         (-[WebInspector showWindow:]):
    728         (-[WebInspector setWebFrame:]):
    729         (-[WebInspector webFrame]):
    730         (-[WebInspector setRootDOMNode:]):
    731         (-[WebInspector rootDOMNode]):
    732         (-[WebInspector setFocusedDOMNode:]):
    733         (-[WebInspector focusedDOMNode]):
    734         (-[WebInspector setSearchQuery:]):
    735         (-[WebInspector searchQuery]):
    736         (-[WebInspector searchResults]):
    737         (-[WebInspector showOptionsMenu]):
    738         (-[WebInspector selectNewRoot:]):
    739         (-[WebInspector resizeTopArea:]):
    740         (-[WebInspector treeViewScrollTo:]):
    741         (-[WebInspector treeViewOffsetTop]):
    742         (-[WebInspector treeViewScrollHeight]):
    743         (-[WebInspector traverseTreeBackward]):
    744         (-[WebInspector traverseTreeForward]):
    745         (-[WebInspector _toggleIgnoreWhitespace:]):
    746         (-[WebInspector _highlightNode:]):
    747         (-[WebInspector _nodeHighlightExpired:]):
    748         (-[WebInspector _focusRootNode:]):
    749         (-[WebInspector _revealAndSelectNodeInTree:]):
    750         (-[WebInspector _showSearchResults:]):
    751         (-[WebInspector _refreshSearch]):
    752         (-[WebInspector _update]):
    753         (-[WebInspector _updateRoot]):
    754         (-[WebInspector _updateTreeScrollbar]):
    755         (+[WebInspector isSelectorExcludedFromWebScript:]):
    756         (+[WebInspector webScriptNameForSelector:]):
    757         (+[WebInspector isKeyExcludedFromWebScript:]):
    758         (-[WebInspector handleEvent:]):
    759         (-[WebInspector webView:didFinishLoadForFrame:]):
    760         (-[WebInspector webView:plugInViewWithArguments:]):
    761         (-[WebInspector outlineView:numberOfChildrenOfItem:]):
    762         (-[WebInspector outlineView:isItemExpandable:]):
    763         (-[WebInspector outlineView:child:ofItem:]):
    764         (-[WebInspector outlineView:objectValueForTableColumn:byItem:]):
    765         (-[WebInspector outlineView:willDisplayOutlineCell:forTableColumn:item:]):
    766         (-[WebInspector outlineViewItemDidCollapse:]):
    767         (-[WebInspector outlineViewSelectionDidChange:]):
    768         (-[WebInspectorPrivate dealloc]):
    769         (-[DOMHTMLElement _addClassName:]): Helper method for the Inspector to append style classes
    770         (-[DOMHTMLElement _removeClassName:]): Helper method for the Inspector to remove style classes
    771         (-[DOMNode _contentPreview]):
    772         (-[DOMNode _isAncestorOfNode:]):
    773         (-[DOMNode _isDescendantOfNode:]):
    774         (-[DOMNode _isWhitespace]):
    775         (-[DOMNode _lengthOfChildNodesIgnoringWhitespace]):
    776         (-[DOMNode _childNodeAtIndexIgnoringWhitespace:]):
    777         (-[DOMNode _nextSiblingSkippingWhitespace]):
    778         (-[DOMNode _previousSiblingSkippingWhitespace]):
    779         (-[DOMNode _firstChildSkippingWhitespace]):
    780         (-[DOMNode _lastChildSkippingWhitespace]):
    781         (-[DOMNode _firstAncestorCommonWithNode:]):
    782         (-[DOMNode _traverseNextNodeStayingWithin:]):
    783         (-[DOMNode _traverseNextNodeSkippingWhitespaceStayingWithin:]):
    784         (-[DOMNode _traversePreviousNode]):
    785         (-[DOMNode _traversePreviousNodeSkippingWhitespace]):
    786         (-[DOMNode _nodeTypeName]):
    787         (-[DOMNode _shortDisplayName]):
    788         (-[DOMNode _displayName]):
    789         * WebInspector.subproj/WebInspectorInternal.h: Added.
    790         * WebInspector.subproj/WebInspectorOutlineView.h: Added.
    791         * WebInspector.subproj/WebInspectorOutlineView.m: Added.
    792         (-[WebInspectorOutlineView isOpaque]):
    793         (-[WebInspectorOutlineView _highlightColorForCell:]):
    794         (-[WebInspectorOutlineView _highlightRow:clipRect:]):
    795         (-[WebInspectorOutlineView drawBackgroundInClipRect:]):
    796         * WebInspector.subproj/WebInspectorPanel.h: Added.
    797         * WebInspector.subproj/WebInspectorPanel.m: Added.
    798         (-[WebInspectorPanel canBecomeKeyWindow]):
    799         (-[WebInspectorPanel canBecomeMainWindow]):
    800         (-[WebInspectorPanel moveWindow:]):
    801         (-[WebInspectorPanel resizeWindow:]):
    802         (-[WebInspectorPanel sendEvent:]):
    803         * WebInspector.subproj/WebNodeHighlight.h: Added.
    804         * WebInspector.subproj/WebNodeHighlight.m: Added.
    805         (-[WebNodeHighlight initWithBounds:andRects:forView:]):
    806         (-[WebNodeHighlight dealloc]):
    807         (-[WebNodeHighlight fractionComplete]):
    808         (-[WebNodeHighlight expire]):
    809         (-[WebNodeHighlight redraw:]):
    810         * WebInspector.subproj/WebNodeHighlightView.h: Added.
    811         * WebInspector.subproj/WebNodeHighlightView.m: Added.
    812         (-[WebNodeHighlightView roundedRect:withRadius:]):
    813         (-[WebNodeHighlightView initWithHighlight:andRects:forView:]):
    814         (-[WebNodeHighlightView dealloc]):
    815         (-[WebNodeHighlightView isOpaque]):
    816         (-[WebNodeHighlightView drawRect:]):
    817         * WebInspector.subproj/webInspector: Added.
    818         * WebInspector.subproj/webInspector/Images: Added.
    819         * WebInspector.subproj/webInspector/Images/close.png: Added.
    820         * WebInspector.subproj/webInspector/Images/closePressed.png: Added.
    821         * WebInspector.subproj/webInspector/Images/downTriangle.png: Added.
    822         * WebInspector.subproj/webInspector/Images/menu.png: Added.
    823         * WebInspector.subproj/webInspector/Images/menuPressed.png: Added.
    824         * WebInspector.subproj/webInspector/Images/popupFill.png: Added.
    825         * WebInspector.subproj/webInspector/Images/popupFillPressed.png: Added.
    826         * WebInspector.subproj/webInspector/Images/popupLeft.png: Added.
    827         * WebInspector.subproj/webInspector/Images/popupLeftPressed.png: Added.
    828         * WebInspector.subproj/webInspector/Images/popupRight.png: Added.
    829         * WebInspector.subproj/webInspector/Images/popupRightPressed.png: Added.
    830         * WebInspector.subproj/webInspector/Images/rightTriangle.png: Added.
    831         * WebInspector.subproj/webInspector/Images/scrollThumbBottom.png: Added.
    832         * WebInspector.subproj/webInspector/Images/scrollThumbMiddle.png: Added.
    833         * WebInspector.subproj/webInspector/Images/scrollThumbTop.png: Added.
    834         * WebInspector.subproj/webInspector/Images/scrollTrackBottom.png: Added.
    835         * WebInspector.subproj/webInspector/Images/scrollTrackMiddle.png: Added.
    836         * WebInspector.subproj/webInspector/Images/scrollTrackTop.png: Added.
    837         * WebInspector.subproj/webInspector/Images/squareButtonRight.png: Added.
    838         * WebInspector.subproj/webInspector/Images/squareButtonRightPressed.png: Added.
    839         * WebInspector.subproj/webInspector/Images/upTriangle.png: Added.
    840         * WebInspector.subproj/webInspector/inspector.css: Added.
    841         * WebInspector.subproj/webInspector/inspector.html: Added.
    842         * WebInspector.subproj/webInspector/inspector.js: Added.
    843         * WebKit.xcodeproj/project.pbxproj: Adds Web Inspector files
    844         * WebView.subproj/WebUIDelegatePrivate.h: new UI delegate method to supply a replacement view for plugins
    845         * WebView.subproj/WebView.m:
    846         (-[WebView _menuForElement:defaultItems:]): Add a new context menu item for inspecting
    847         (-[WebView _inspectElement:]): Context menu item target for inspecting
    848 
    849 2006-01-14  Alexey Proskuryakov  <ap (a] nypop.com>
    850 
    851         Reviewed by Darin.
    852 
    853         - Fix http://bugs.webkit.org/show_bug.cgi?id=6531
    854         document.cookie="killmenothing" doesn't set the cookie
    855 
    856         * WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):
    857         Append an '=' to the cookie string if it has none, so that 
    858         +[NSHTTPCookie cookiesWithResponseHeaderFields:forURL:] can parse it.
    859 
    860 2006-01-14  Maciej Stachowiak  <mjs (a] apple.com>
    861 
    862         Reviewed by Eric.
    863 
    864         - added bridging infrastructure for Page class
    865         
    866         * WebCoreSupport.subproj/WebPageBridge.h: Added.
    867         * WebCoreSupport.subproj/WebPageBridge.m: Added.
    868         (-[WebPageBridge initWithMainFrameName:view:]): New class, somewhat obvious.
    869         * WebKit.xcodeproj/project.pbxproj:
    870         * WebView.subproj/WebView.m:
    871         (-[WebViewPrivate dealloc]): Don't use _mainFrameBrige, use _pageBridge
    872         (-[WebView _close]): ditto
    873         (-[WebView _commonInitializationWithFrameName:groupName:]): ditto
    874         (-[WebView mainFrame]): ditto
    875 
    876 2006-01-12  Maciej Stachowiak  <mjs (a] apple.com>
    877 
    878         Rubber stamped by Eric.
    879 
    880         - rename WebBridge to WebFrameBridge
    881         
    882         - also removed all tabs from WebFrameBridge.m
    883 
    884         * DOM.subproj/WebDOMOperations.m:
    885         (-[DOMNode _bridge]):
    886         (-[DOMNode webArchive]):
    887         (-[DOMRange _bridge]):
    888         (-[DOMRange webArchive]):
    889         * DOM.subproj/WebDOMOperationsPrivate.h:
    890         * English.lproj/StringsNotToBeLocalized.txt:
    891         * Misc.subproj/WebCoreStatistics.m:
    892         * Misc.subproj/WebNSViewExtras.h:
    893         * Misc.subproj/WebNSViewExtras.m:
    894         (-[NSView _bridge]):
    895         * Plugins.subproj/WebBaseNetscapePluginView.m:
    896         * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
    897         * Plugins.subproj/WebNetscapePluginStream.m:
    898         (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
    899         * Plugins.subproj/WebPluginContainerCheck.m:
    900         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
    901         * Plugins.subproj/WebPluginController.h:
    902         * Plugins.subproj/WebPluginController.m:
    903         (-[WebPluginController bridge]):
    904         * WebCoreSupport.subproj/WebBridge.h: Removed.
    905         * WebCoreSupport.subproj/WebBridge.m: Removed.
    906         * WebCoreSupport.subproj/WebFileButton.h:
    907         * WebCoreSupport.subproj/WebFileButton.m:
    908         (-[WebFileChooserButton initWithBridge:delegate:]):
    909         * WebCoreSupport.subproj/WebFrameBridge.h: Added.
    910         * WebCoreSupport.subproj/WebFrameBridge.m: Added.
    911         (-[WebFrameBridge mainFrame]):
    912         (-[WebFrameBridge createWindowWithURL:frameName:]):
    913         (-[WebFrameBridge canTargetLoadInFrame:]):
    914         (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
    915         (formDelegate):
    916         (-[WebFrameBridge createModalDialogWithURL:]):
    917         * WebCoreSupport.subproj/WebSubresourceLoader.m:
    918         * WebCoreSupport.subproj/WebTextRendererFactory.m:
    919         * WebCoreSupport.subproj/WebViewFactory.m:
    920         (-[WebViewFactory bridgeForView:]):
    921         * WebKit.xcodeproj/project.pbxproj:
    922         * WebView.subproj/WebDataSource.m:
    923         (-[WebDataSource _bridge]):
    924         (-[WebDataSource _receivedMainResourceError:complete:]):
    925         (-[WebDataSource _stringWithData:]):
    926         * WebView.subproj/WebDataSourcePrivate.h:
    927         * WebView.subproj/WebDebugDOMNode.m:
    928         * WebView.subproj/WebDefaultContextMenuDelegate.m:
    929         * WebView.subproj/WebFrame.m:
    930         (-[WebFrame _traverseNextFrameStayWithin::]):
    931         (Frame):
    932         (-[WebFrame _detachFromParent]):
    933         (-[WebFrame _bridge]):
    934         (-[WebFrame _initWithWebFrameView:webView:bridge:]):
    935         * WebView.subproj/WebFrameInternal.h:
    936         * WebView.subproj/WebFramePrivate.h:
    937         * WebView.subproj/WebFrameView.m:
    938         (-[WebFrameView webCoreBridge]):
    939         (-[WebFrameView _bridge]):
    940         * WebView.subproj/WebHTMLRepresentation.m:
    941         (+[WebHTMLRepresentation supportedMIMETypes]):
    942         (-[WebHTMLRepresentation _bridge]):
    943         (-[WebHTMLRepresentation documentSource]):
    944         * WebView.subproj/WebHTMLRepresentationPrivate.h:
    945         * WebView.subproj/WebHTMLView.m:
    946         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
    947         (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]):
    948         (-[WebHTMLView updateFocusState]):
    949         (-[NSArray validateUserInterfaceItem:]):
    950         (-[NSArray attributedString]):
    951         (-[NSArray selectedAttributedString]):
    952         (-[NSArray concludeDragForDraggingInfo:actionMask:]):
    953         (-[NSArray keyDown:]):
    954         (-[NSArray _alterCurrentSelection:direction:granularity:]):
    955         (-[NSArray _alterCurrentSelection:verticalDistance:]):
    956         (-[NSArray _expandSelectionToGranularity:]):
    957         (-[NSArray cut:]):
    958         (-[NSArray _applyStyleToSelection:withUndoAction:]):
    959         (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
    960         (-[NSArray pasteAsPlainText:]):
    961         (-[NSArray insertNewline:]):
    962         (-[NSArray insertLineBreak:]):
    963         (-[NSArray insertParagraphSeparator:]):
    964         (-[NSArray _changeWordCaseWithSelector:]):
    965         (-[NSArray startSpeaking:]):
    966         (-[NSArray selectToMark:]):
    967         (-[NSArray swapWithMark:]):
    968         (-[NSArray transpose:]):
    969         (-[WebHTMLView characterIndexForPoint:]):
    970         (-[WebHTMLView firstRectForCharacterRange:]):
    971         (-[WebHTMLView selectedRange]):
    972         (-[WebHTMLView attributedSubstringFromRange:]):
    973         (-[WebHTMLView _selectMarkedText]):
    974         (-[WebHTMLView _selectRangeInMarkedText:]):
    975         (-[WebHTMLView setMarkedText:selectedRange:]):
    976         (-[WebHTMLView _selectionIsInsideMarkedText]):
    977         (-[WebTextCompleteController _insertMatch:]):
    978         (-[WebTextCompleteController doCompletion]):
    979         (-[WebTextCompleteController endRevertingChange:moveLeft:]):
    980         * WebView.subproj/WebHTMLViewPrivate.h:
    981         * WebView.subproj/WebImageView.m:
    982         * WebView.subproj/WebMainResourceLoader.m:
    983         * WebView.subproj/WebRenderNode.m:
    984         * WebView.subproj/WebResource.m:
    985         (-[WebResource _stringValue]):
    986         * WebView.subproj/WebScriptDebugDelegate.m:
    987         * WebView.subproj/WebTextView.m:
    988         * WebView.subproj/WebView.m:
    989         (-[WebView _createFrameNamed:inParent:allowsScrolling:]):
    990         (-[WebView _commonInitializationWithFrameName:groupName:]):
    991         (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
    992         (-[WebView moveDragCaretToPoint:]):
    993         (-[WebView shouldClose]):
    994         (-[WebView editableDOMRangeForPoint:]):
    995         (-[WebView setEditable:]):
    996         (-[WebView deleteSelection]):
    997         (-[WebView _bridgeForSelectedOrMainFrame]):
    998         (-[WebView _bridgeAtPoint:]):
    999 
   1000 2006-01-13  Darin Adler  <darin (a] apple.com>
   1001 
   1002         - Replaced tabs with spaces in source files that had less than 10 lines with tabs.
   1003         - Set allow-tabs Subversion property in source files that have more than 10 lines with tabs.
   1004 
   1005 2006-01-12  John Sullivan  <sullivan (a] apple.com>
   1006 
   1007         Reviewed by Tim O.
   1008         
   1009         - fixed <rdar://problem/4406994> REGRESSION (TOT): zooming window at cnn.com 
   1010         makes window fill width of screen
   1011 
   1012         * WebView.subproj/WebFrameView.m:
   1013         (-[WebFrameView _largestChildWithScrollBars]):
   1014         now skips zero-area frames, used by some evil ads
   1015 
   1016 2006-01-10  John Sullivan  <sullivan (a] apple.com>
   1017 
   1018         Reviewed by Tim H.
   1019         
   1020         - fixed <rdar://problem/4265966> PDFs continue to show a (secondary) selection 
   1021         when the focus moves elsewhere
   1022 
   1023         * WebView.subproj/WebPDFView.h:
   1024         added trackedFirstResponder ivar
   1025         
   1026         * WebView.subproj/WebPDFView.m:
   1027         (-[WebPDFView dealloc]):
   1028         assert that trackedFirstResponder is nil, as it was released/cleared in viewWillMoveToWindow:
   1029         (-[WebPDFView _trackFirstResponder]):
   1030         If the tracked first responder was the PDFView's documentView, and the current first responder isn't,
   1031         deselect all. This is equivalent to overriding resignFirstResponder in the PDFView's 
   1032         documentView and deselecting all there, as other web document view classes do. Also, keep track of
   1033         the new first responder for next time.
   1034         (-[WebPDFView viewWillMoveToWindow:]):
   1035         stop observing NSWindowDidUpdateNotification on the old window
   1036         (-[WebPDFView viewDidMoveToWindow]):
   1037         start observing NSWindowDidUpdateNotification on the new window, with _trackFirstResponder
   1038         as the callback. Ideally we'd use a notification that tells us that the first responder is
   1039         changing, but there is no such notification, so we have to use this very frequent one instead.
   1040         The archaic 2573089 tracks the desire to have a responder-changed notification.
   1041         (-[WebPDFView becomeFirstResponder]):
   1042         removed comment about this bug that's now obsolete
   1043 
   1044 2006-01-11  Darin Adler  <darin (a] apple.com>
   1045 
   1046         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
   1047 
   1048 2006-01-09  Darin Adler  <darin (a] apple.com>
   1049 
   1050         * Makefile.am: Removed.
   1051 
   1052 2006-01-09  John Sullivan  <sullivan (a] apple.com>
   1053 
   1054         Reviewed by Beth Dakin.
   1055                 
   1056         - fixed <rdar://problem/4302263> CrashTracer: 504 crashes in Safari at 
   1057         com.apple.AppKit: NSTargetForSendAction + 1060
   1058         
   1059         The problem was that back/forward/stop/reload context menu items had nil targets,
   1060         and thus were relying on AppKit to start from the context menu target (the clicked-upon 
   1061         view) and use the responder chain to find the WebView to act as the target. In Tiger, 
   1062         context menus don't retain their implicit target (the clicked-upon view again), and
   1063         there was a race condition where the WebHTMLView could be dealloc'ed while the menu item
   1064         was being processed, eventually crashing in AppKit. The fix is to explicitly set the
   1065         target of these four menu items to the WebView, since the WebView is not dealloc'ed
   1066         in the loading process.
   1067         
   1068         This might be fixed in a future version of AppKit by making the context menu retain its
   1069         implicit target until it is dismissed, but with this change it will be fixed regardless
   1070         of potential AppKit changes.
   1071 
   1072         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   1073         (-[WebDefaultUIDelegate menuItemWithTag:target:]):
   1074         Added target: parameter and removed code that set the target for some menu items; now the
   1075         caller is responsible for supplying the target.
   1076         (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
   1077         Supply target (or nil) in calls to menuItemWithTag:target:. This matches existing behavior
   1078         except for Back/Forward/Stop/Reload, which used to supply no target but now supply the
   1079         WebView as the target.
   1080         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
   1081         Supply target (or nil) in calls to menuItemWithTag:target:
   1082 
   1083 2006-01-09  Geoffrey Garen  <ggaren (a] apple.com>
   1084 
   1085         Reviewed by Darin.
   1086         
   1087         - Second cut at fixing <rdar://problem/4268278> Submitting a form 
   1088         in onUnload event handler causes crash in 
   1089         -[WebDataSource(WebPrivate) _commitIfReady:].)
   1090 
   1091         - Fixes http://bugs.webkit.org/show_bug.cgi?id=6331
   1092         REGRESSION: form events don't fire after back/forward navigation, 
   1093         due to inconsistent load state
   1094         
   1095         * WebView.subproj/WebDataSource.m:
   1096         (-[WebDataSource _stopLoading]): 
   1097         (1) If there are no resource loaders to signal the WebView that we've
   1098         been canceled, manufacture the signal. Otherwise, the cancel gets 
   1099         ignored and nobody cleans up after the load. (We signal the WebView but
   1100         not the WebFrame because we don't want the WebFrame to tear down the 
   1101         data source.  Unlike most canceled data sources, this one has valid data 
   1102         because it's in the back/forward cache.)
   1103         (2) Update _private->stopping before returning because if the 
   1104         data source is in the back/forward cache it can be reused, so it 
   1105         needs to be in a consistent state. (We never encountered this 
   1106         situation before because we would always crash first.)
   1107         (-[WebDataSource _commitLoadWithData:]): Move _commitIfReady call 
   1108         inside retain block because the commit may cause an unload event 
   1109         to fire, which may start a new load, deallocating the current 
   1110         data source. (This is the same reason the rest of the function is 
   1111         in the retain block.)
   1112         * WebView.subproj/WebFrame.m:
   1113         (-[WebFrame _transitionToCommitted:]): If the unload handler 
   1114         started a new load, return early to avoid stomping it.
   1115         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): 
   1116         Undo previous incorrect fix.
   1117         (-[WebFrame stopLoading]): Remove misleading comment. Setting 
   1118         provisionalDataSource to nil is not optional but required for 
   1119         internal consistency.
   1120 
   1121 2006-01-09  Alexey Proskuryakov  <ap (a] nypop.com>
   1122 
   1123         Reviewed by Maciej.
   1124 
   1125         Affects many layout tests (when running with primary Russian language).
   1126 
   1127         - Fix http://bugs.webkit.org/show_bug.cgi?id=4759
   1128         'ex' length unit calculation (Some layout tests fail if the system primary language is Russian)
   1129 
   1130         * WebCoreSupport.subproj/WebTextRenderer.m:
   1131         (-[WebTextRenderer xHeight]): Use glyphForCharacter() instead of -[NSFont glyphWithName:].
   1132 
   1133 2006-01-07  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   1134 
   1135         Reviewed by Darin, landed by ap.
   1136         
   1137         Test: fast/text/atsui-small-caps-punctuation-size.html
   1138         
   1139         - fix http://bugs.webkit.org/show_bug.cgi?id=6397
   1140           ATSUI small caps use small punctuation
   1141           
   1142         * WebCoreSupport.subproj/WebTextRenderer.m:
   1143         (createATSULayoutParameters): Changed the characters for which size must
   1144         not change from !u_isbase() to the M* categories.
   1145 
   1146 2006-01-06  John Sullivan  <sullivan (a] apple.com>
   1147 
   1148         Reviewed by Vicki Murley (full credit) and Tim Omernick (half credit).
   1149         
   1150         - fixed <rdar://problem/4401102> REGRESSION (420+): When displaying a PDF, tabbing around stops working after reaching page
   1151 
   1152         * WebView.subproj/WebPDFView.m:
   1153         (-[WebPDFView setNextKeyView:]):
   1154         Use [PDFSubview documentView] rather than PDFSubview here, since that's the view that we now hand off first-responderhood to.
   1155 
   1156 2006-01-05  Tim Omernick  <timo (a] apple.com>
   1157 
   1158         Reviewed by Geoff.
   1159 
   1160 	<rdar://problem/4400804> Client-side redirect to a non-HTTP URL confuses Safari
   1161 
   1162         * WebView.subproj/WebFrame.m:
   1163         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
   1164 	If we were waiting for a quick redirect, but the policy delegate decided to ignore it, then we 
   1165 	need to report that the client redirect was cancelled.
   1166 	
   1167 2006-01-05  John Sullivan  <sullivan (a] apple.com>
   1168 
   1169         * WebView.subproj/WebPDFView.m:
   1170         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
   1171         Just added a FIXME comment about how to clean up this minor hack in the future.
   1172 
   1173 2006-01-05  John Sullivan  <sullivan (a] apple.com>
   1174 
   1175         Reviewed by Tim O.
   1176         
   1177         - fixed these bugs:
   1178         <rdar://problem/3021785> page up/down don't work on frameset pages unless you click        
   1179         <rdar://problem/3021788> Page Up/Down moves an unscrollable frame if you click on it first
   1180         
   1181         and the WebKit part of this (need new Safari too for complete fix):
   1182         <rdar://problem/4378905> Page up/down don't work in PDFs when address field is focused
   1183         
   1184         I moved some logic down from Safari that dealt with finding the largest scrollable child frame in a frameset,
   1185         and added support for standard scrolling-related selectors to WebPDFView. The latter was needed for 4378905;
   1186         the former was needed due to side effects of the Safari part of the change. As long as I was doing the former,
   1187         I also used that logic to fix 3021785 and 3021788.
   1188         
   1189         * WebView.subproj/WebFrameViewPrivate.h:
   1190         new currently-private methods _hasScrollBars and _largestChildWithScrollBars
   1191 
   1192         * WebView.subproj/WebFrameView.m:
   1193         (-[WebFrameView scrollToBeginningOfDocument:]):
   1194         if we don't have scroll bars, operate on our largest child with scroll bars instead
   1195         (-[WebFrameView scrollToEndOfDocument:]):
   1196         ditto
   1197         (-[WebFrameView _pageVertically:]):
   1198         ditto
   1199         (-[WebFrameView _pageHorizontally:]):
   1200         ditto
   1201         (-[WebFrameView _scrollLineVertically:]):
   1202         ditto
   1203         (-[WebFrameView _scrollLineHorizontally:]):
   1204         ditto
   1205         (-[WebFrameView keyDown:]):
   1206         where we were bailing out if ![self allowsScrolling], also check for whether there's a
   1207         child with scroll bars, and don't bail out if so
   1208         (-[WebFrameView _area]):
   1209         new helper method used to implement _largestChildWithScrollBars (code moved from Safari)
   1210         (-[WebFrameView _hasScrollBars]):
   1211         new method, just returns YES if either scroll bar is showing (code moved from Safari)
   1212         (-[WebFrameView _largestChildWithScrollBars]):
   1213         new method, returns the child with the largest area that is showing at least one scroll bar
   1214         (code moved from Safari and tweaked a little)
   1215         
   1216         * WebView.subproj/WebPDFView.m:
   1217         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
   1218         new method, hackaround for the fact that PDFView handles key downs from standard scrolling keys
   1219         but does not implement the standard responder selectors
   1220         (-[WebPDFView scrollPageDown:]):
   1221         use _fakeKeyEventWithFunctionKey: to get the PDFView to scroll appropriately
   1222         (-[WebPDFView scrollPageUp:]):
   1223         ditto
   1224         (-[WebPDFView scrollToBeginningOfDocument:]):
   1225         ditto
   1226         (-[WebPDFView scrollToEndOfDocument:]):
   1227         ditto
   1228         
   1229         * WebView.subproj/WebView.m:
   1230         add scrollToBeginningOfDocument and scrollToEndOfDocument to the list of responder operations
   1231         that we hand off appropriately to the responder chain. These two aren't defined in any header
   1232         but are generated by Home and End keys and used by the text system.
   1233 
   1234 2006-01-05  Geoffrey Garen  <ggaren (a] apple.com>
   1235 
   1236         Reviewed by Darin.
   1237 
   1238         - Fixed http://bugs.webkit.org/show_bug.cgi?id=6361
   1239         Add plugin support to DumpRenderTree
   1240 
   1241         * WebKit.exp: export WebPluginDatabase class, which DumpRenderTree
   1242         needs to add plugins to the runtime.
   1243 
   1244 2006-01-03  Maciej Stachowiak  <mjs (a] apple.com>
   1245 
   1246         Reviewed by Darin.
   1247 
   1248 	- move frame management and finding code from WebKit to WebCore
   1249 	http://bugs.webkit.org/show_bug.cgi?id=6368
   1250 
   1251         * Plugins.subproj/WebBaseNetscapePluginView.m:
   1252         (-[WebBaseNetscapePluginView loadPluginRequest:]): Set frame name straight on the bridge,
   1253 	instead of having it bubble through the view and frame.
   1254         * WebCoreSupport.subproj/WebBridge.m:
   1255         (-[WebBridge initWithFrameName:view:]): don't pass name to frame, we own it now; set it
   1256 	on ourselves directly
   1257 	(-[WebBridge findFrameNamed:]): removed
   1258         (-[WebBridge createWindowWithURL:frameName:]): set name on bridge, not webview
   1259         (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
   1260         (-[WebBridge runModal]): remove excess braces
   1261         * WebKit.xcodeproj/project.pbxproj:
   1262         * WebView.subproj/WebControllerSets.h: Removed.
   1263         * WebView.subproj/WebControllerSets.m: Removed.
   1264         * WebView.subproj/WebFrame.m:
   1265         (-[WebFramePrivate name]): removed
   1266         (-[WebFramePrivate setName:]): removed
   1267         (-[WebFramePrivate dealloc]): don't release name, we no longer have one
   1268         (-[WebFrame _appendChild:]): removed
   1269         (-[WebFrame _removeChild:]): removed
   1270         (-[WebFrame _createItem:]): removed stray space
   1271         (-[WebFrame _immediateChildFrameNamed:]): Just call the bridge
   1272         (-[WebFrame _setName:]): removed
   1273         (-[WebFrame _detachFromParent]): remove bridge from parent note self
   1274         (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
   1275         (-[WebFrame _addChild:]): Call appendChild: on bridge, not self
   1276         (-[WebFrame _nextFrameWithWrap:]): just call bridge (and moved helpers there)
   1277         (-[WebFrame _previousFrameWithWrap:]): just call bridge (and moved helpers there)
   1278         (-[WebFrame _initWithWebFrameView:webView:bridge:]): don't take a name any more
   1279         (-[WebFrame _setFrameNamespace:]): just call bridge
   1280         (-[WebFrame _frameNamespace]): just call bridge
   1281         (-[WebFrame _hasSelection]): remove excess braces
   1282         (-[WebFrame _clearSelection]): ditto
   1283         (-[WebFrame initWithName:webFrameView:webView:]): no more name
   1284         (-[WebFrame name]): just call bridge
   1285         (-[WebFrame findFrameNamed:]): just call bridge (and moved helpers there)
   1286         (-[WebFrame parentFrame]): fixed for new style
   1287         * WebView.subproj/WebFrameInternal.h:
   1288         * WebView.subproj/WebFramePrivate.h:
   1289         * WebView.subproj/WebView.m:
   1290         * WebView.subproj/WebViewPrivate.h:
   1291 
   1292 2006-01-03  Darin Adler  <darin (a] apple.com>
   1293 
   1294         Reviewed by Beth.
   1295 
   1296 	This is a fix for <rdar://problem/3710994> HiDPI: Link underlines are 
   1297 	still one pixel high even if the UI resolution is > 100%
   1298 
   1299 	This fix refactors -drawLineForCharacters to make its organization
   1300 	more logical. It changes behavior when printing to the screen by
   1301 	rounding the parameters of the line (x- and y-values, width, and 
   1302 	thickness) to integer boundaries in device space. Previously,
   1303 	this part of the routine just hardcoded a 1 pixel line.
   1304 
   1305         * WebCoreSupport.subproj/WebTextRenderer.m:
   1306         (drawHorizontalLine): This just takes care of drawing the line once everything
   1307 	has been calculated in -drawLineForCharacters
   1308         (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
   1309 	Now takes device space into account. Calls drawHorizontalLine
   1310 
   1311 2006-01-03  Maciej Stachowiak  <mjs (a] apple.com>
   1312 
   1313         Reviewed by Vicki.
   1314 
   1315         - moved frame traversal code across from bridge, also dropped the children
   1316 	array
   1317 
   1318         * WebCoreSupport.subproj/WebBridge.h:
   1319         * WebCoreSupport.subproj/WebBridge.m:
   1320         (-[WebBridge dealloc]): Don't release children array, that was moved
   1321 	down to WebCore.
   1322         (-[WebBridge saveDocumentState:]):
   1323 	- many methods moved to WebCore.
   1324         * WebView.subproj/WebFrame.m:
   1325         (Frame): New convenience method to get a WebFrame * from a method that
   1326 	returns WebCoreBridge *.
   1327         (-[WebFrame _firstChildFrame]): use Frame()
   1328         (-[WebFrame _lastChildFrame]): ditto
   1329         (-[WebFrame _previousSiblingFrame]): ditto
   1330         (-[WebFrame _nextSiblingFrame]): ditto
   1331         (-[WebFrame _traverseNextFrameStayWithin:]): ditto
   1332 
   1333 2006-01-03  Anders Carlsson  <andersca (a] mac.com>
   1334 
   1335         Reviewed by Darin.
   1336 
   1337         - Fix http://bugs.webkit.org/show_bug.cgi?id=6357
   1338         REGRESSION: iframe and target is broken
   1339         
   1340         * WebView.subproj/WebFrame.m:
   1341         (-[WebFrame _descendantFrameNamed:sourceFrame:]):
   1342         Return the correct frame.
   1343 
   1344 2006-01-02  Maciej Stachowiak  <mjs (a] apple.com>
   1345 
   1346         Reviewed by Eric.
   1347 
   1348 	    - moved frame traversal logic from WebFrame to WebBridge
   1349 	    http://bugs.webkit.org/show_bug.cgi?id=6341
   1350 
   1351 	    To do this, I had to invert the ownership so that WebBridge now
   1352 	    owns WebFrame instead of vice versa. As a result, WebView now owns
   1353 	    a WebBridge pointer and does not have a direct WebFrame pointer.
   1354 
   1355         * WebCoreSupport.subproj/WebBridge.h:
   1356         * WebCoreSupport.subproj/WebBridge.m:
   1357         (-[WebBridge initWithFrameName:view:]): The initializer is now responsible for creating
   1358 	the frame, so pass it what it needs to do that.
   1359         (-[WebBridge dealloc]): The bridge now owns the frame, so release it.
   1360         (-[WebBridge close]): ditto
   1361         (-[WebBridge firstChild]): Moved from WebFrame
   1362         (-[WebBridge lastChild]): ditto
   1363         (-[WebBridge childCount]): ditto
   1364         (-[WebBridge previousSibling]): ditto
   1365         (-[WebBridge nextSibling]): ditto
   1366         (-[WebBridge isDescendantOfFrame:]): ditto
   1367         (-[WebBridge traverseNextFrameStayWithin:]): ditto
   1368         (-[WebBridge appendChild:]): ditto
   1369         (-[WebBridge removeChild:]): ditto
   1370         * WebView.subproj/WebFrame.m:
   1371         (-[WebFrame _removeChild::]): Call WebBridge version
   1372         (-[WebFramePrivate dealloc]): ditto
   1373         (-[WebFrame _firstChildFrame]): ditto
   1374         (-[WebFrame _lastChildFrame]): ditto
   1375         (-[WebFrame _childFrameCount]): ditto
   1376         (-[WebFrame _previousSiblingFrame]): ditto
   1377         (-[WebFrame _nextSiblingFrame]): ditto
   1378         (-[WebFrame _traverseNextFrameStayWithin:]): ditto
   1379         (-[WebFrame _appendChild:]): ditto
   1380         (-[WebFrame _removeChild:]): ditto
   1381         (-[WebFrame _isDescendantOfFrame:]): ditto,
   1382         (-[WebFrame _detachFromParent]): reorder a bit to avoid losing our bridge
   1383 	pointer before the bridge is due to release us, and don't release the
   1384 	bridge any more since it now owns us
   1385         (-[WebFrame _initWithName:webFrameView:webView:bridge:]): new initializer,
   1386 	we no longer create the bridge, instead it is passed in
   1387         (-[WebFrame initWithName:webFrameView:webView:]): Call the new designated
   1388 	initializer, but this method is no longer viable and should be deprecated.
   1389         * WebView.subproj/WebFrameInternal.h:
   1390         
   1391 	* WebView.subproj/WebView.m: WebView was changed to hold onto
   1392 	the WebBridge for the main frame instead of the WebFrame.
   1393 	
   1394         (-[WebViewPrivate dealloc]): update for the fact that we hold
   1395 	a bridge now, not a frame.
   1396         (-[WebView _close]): ditto
   1397         (-[WebView _createFrameNamed:inParent:allowsScrolling:]): Create
   1398 	a bridge, not a frame.
   1399         (-[WebView _commonInitializationWithFrameName:groupName:]): ditto.
   1400         (-[WebView setDefersCallbacks:]): get mainFrame via method
   1401         (-[WebView mainFrame]): Update to get the main frame properly
   1402 
   1403 2005-12-30  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   1404 
   1405         Reviewed by Darin, landed by ap.
   1406         
   1407         Test: fast/text/justified-text-rect.html
   1408         
   1409         - WebKit part of fix for
   1410           http://bugs.webkit.org/show_bug.cgi?id=5461
   1411           Text width measured incorrectly when text-align: justify
   1412 
   1413         * WebCoreSupport.subproj/WebTextRenderer.m:
   1414         (-[WebTextRenderer selectionRectForRun:style:geometry:]): Added.
   1415         (CG_drawHighlight): Use new function CG_selectionRect.
   1416         (CG_selectionRect): New function to compute the selection rect.
   1417         Eliminated rounding hackery that was required for keeping the highlight
   1418         rect within the selection rect computed by
   1419         InlineTextBox::selectionRect, since the latter uses this function now.
   1420         The new selection rect is wider and matches AppKit more closely,
   1421         although the right hand side is roundf()ed instead of cielf()ed for
   1422         optimal caret positioning.
   1423         (ATSU_drawHighlight): Use new function ATSU_selectionRect.
   1424         (ATSU_selectionRect): New function to compute the selection rect.
   1425         Much like CG_selectionRect.
   1426 
   1427 2005-12-29  Geoffrey Garen  <ggaren (a] apple.com>
   1428 
   1429         Reviewed by Eric.
   1430 
   1431         Manual testcase added:
   1432         WebCore/manual-tests/onunload-form-submit-crash.html
   1433 
   1434         - Fixed <rdar://problem/4268278> Submitting a form in onUnload event 
   1435         handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:] 
   1436 
   1437         The problem is that the form submission in the unload event kicks off 
   1438         a new load in the midst of the load that caused the unload event to 
   1439         fire in the first place, so the two loads stomp each other.
   1440 
   1441         The solution is to cancel the first load and let the unload handler's 
   1442         load win. (Firefox does the same.)
   1443 
   1444         * WebView.subproj/WebFrame.m:
   1445         (-[WebFrame _transitionToCommitted:]): Moved call to -closeURL up
   1446         the call stack to _continueLoadRequest. (See below.) This has the 
   1447         side-effect of always firing the unload event, even if the new 
   1448         datasource never becomes committed, which seems like a good thing. 
   1449 
   1450         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
   1451         Call -closeURL here, instead of in _transitionToCommitted,  so that the
   1452         unload handler can fire before we initialize any part of the load.
   1453         
   1454         Check provisionalDataSource for nil to discover if the unload event
   1455         kicked off its own load.
   1456 
   1457         Cleared up some coments.
   1458 
   1459         (-[WebFrame _detachFromParent]):
   1460         It turns out that if you close the window instead of just navigating
   1461         to a new page, you get an alternate assertion failure/crash because
   1462         the load kicked off by the unload event handler generates resource
   1463         loader callbacks after the associated WebFrame/WebView has disappeared.
   1464 
   1465         The nifty solution here is just to reverse the order of calls to
   1466         -stopLoading and -closeURL, thus guaranteeing that -stopLoading has the
   1467         last word when you close a window.
   1468 
   1469 2005-12-30  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   1470 
   1471         Reviewed by Eric, committed by Maciej.
   1472         
   1473         - fix for http://bugs.webkit.org/show_bug.cgi?id=6288
   1474           HEAD build broken 12/29/2005
   1475 
   1476         * WebCoreSupport.subproj/WebTextRenderer.m:
   1477         (overrideLayoutOperation): Use previous character from the buffer
   1478         instead of ch which may be uninitialized on the first iteration.
   1479 
   1480 2005-12-29  Maciej Stachowiak  <mjs (a] apple.com>
   1481 
   1482         Reviewed by Eric.
   1483 
   1484         - finished frame traversal cleanup
   1485         http://bugs.webkit.org/show_bug.cgi?id=6293
   1486 
   1487         * WebCoreSupport.subproj/WebBridge.m:
   1488         (-[WebBridge childFrames]): Removed (this was unused)
   1489         * WebView.subproj/WebFrame.m:
   1490         (-[WebFrame _removeChild::]): Moved to FrameTraversal category.
   1491         (-[WebFrame _childFrameCount]): New frame traversal method to avoid
   1492 	getting the count from the array directly.
   1493         (-[WebFrame _appendChild:]): Factored out the parts of addChild: that
   1494 	seem directly relevant to adding a child.
   1495         (-[WebFrame _removeChild:]): Moved to FrameTraversal category.
   1496         (-[WebFrame _detachChildren]): Don't deallocate children array because
   1497 	there's no particular need to.
   1498         (-[WebFrame _setDataSource:]): make the assert use _childFrameCount
   1499         (-[WebFrame _opened]):
   1500         (-[WebFrame _checkLoadComplete]): Instead of checking all frames starting
   1501 	from the main frame, check this frame and all ancestors. If a resource
   1502 	for a frame completes, that con only possibly finish loading for that
   1503 	frame and its ancestors, not any other frame in the tree.
   1504 	(-[WebFrame _recursiveCheckLoadComplete]): Removed, no longer needed.
   1505         (-[WebFrame _childFramesMatchItem:]): Get child frame count in the new 
   1506 	approved way.
   1507         (-[WebFrame _internalChildFrames]): removed
   1508 	(-[WebFrame _addChild:]): Use _appendChild: for most of the work.
   1509         (-[WebFrame _generateFrameName]): Get child frame count in the new 
   1510 	approved way.
   1511         (-[WebFrame _stopLoadingSubframes]): Use new frame traversal mechanisms,
   1512 	upon further consideration there's no need to copy part of the frame tree here.
   1513         (-[WebFrame findFrameNamed:]): Remove extra braces.
   1514         (-[WebFrame childFrames]): Make a new array using the frame traversal methods.
   1515         * WebView.subproj/WebFramePrivate.h: Remove some methods.
   1516         * WebView.subproj/WebMainResourceLoader.m:
   1517         (-[WebMainResourceLoader didReceiveResponse:]): Do _checkLoadComplete on the current
   1518 	frame not the main frame (before there was no difference and now the new version is
   1519 	what is desired).
   1520         * WebView.subproj/WebView.m:
   1521         (-[WebView _finishedLoadingResourceFromDataSource:]): Remove stray space
   1522         (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]): Remove stray spaces
   1523 	and update FIXME comment.
   1524         (-[WebView _receivedError:fromDataSource:]): Remove stray space
   1525 
   1526 2005-12-29  Maciej Stachowiak  <mjs (a] apple.com>
   1527 
   1528         Reviewed by Darin.
   1529 
   1530 	- abstract frame traversal in WebFrame more
   1531 	http://bugs.webkit.org/show_bug.cgi?id=6283
   1532 	
   1533 	Rewrote most of the frame traversal code in WebFrame to use DOM-style 
   1534 	first/last/next/previous methods, to abstract access better in preparation 
   1535 	for moving it down. 
   1536 
   1537 	As an added bonus, many formerly recursive methods are now iterative.
   1538 
   1539         * WebKit.xcodeproj/project.pbxproj: Use gnu99 dialect of C, so that
   1540 	variables can be declared in for loop initializers.
   1541 
   1542 	- added new frame traversal methods, to avoid dealing with the children array
   1543 	directly:
   1544 	
   1545         * WebView.subproj/WebFrame.m:
   1546         (-[WebFrame _firstChildFrame]): New method.
   1547         (-[WebFrame _lastChildFrame]): New method.
   1548         (-[WebFrame _previousSiblingFrame]): New method.
   1549         (-[WebFrame _nextSiblingFrame]): New method.
   1550         (-[WebFrame _traverseNextFrameStayWithin:]): Like traverseNextNode() in the DOM;
   1551 	uses some of the previous.
   1552 
   1553 	- apply the new methods
   1554 	
   1555         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Rewrite loop
   1556 	to use new traversal methods.
   1557         (-[WebFrame _immediateChildFrameNamed:]): ditto, also added FIXME
   1558         (-[WebFrame _setName:]): Improved comment, removed gratuitous brace
   1559         (-[WebFrame _isDescendantOfFrame:]): Rewrote to chase parent pointers instead
   1560 	of looking in child arrays (duh)
   1561         (-[WebFrame _detachChildren]): Rewrite loop to use new traversal methods,
   1562 	still walk backwards for now.
   1563         (-[WebFrame _closeOldDataSources]): Rewrite using new traversal methods.
   1564         (-[WebFrame _childFramesMatchItem:]): ditto
   1565         (-[WebFrame _defersCallbacksChanged]): ditto
   1566         (-[WebFrame _viewWillMoveToHostWindow:]): ditto
   1567         (-[WebFrame _viewDidMoveToHostWindow]): ditto
   1568         (-[WebFrame _addChild:]): don't use childFrames method
   1569         (-[WebFrame _removeChild:]): Clear out the sibling pointers after unlinking from the list, 
   1570 	not obvious if anything needs this but it seems like the right thing to do.
   1571         (-[WebFrame _generateFrameName]): don't bother to nil-check children array, since
   1572 	calling count on nil still gives 0.
   1573         (-[WebFrame _saveDocumentAndScrollState]): Rewrite to use frame traversal methods
   1574         (-[WebFrame _deepLastChildFrame]): renamed from _lastChildFrame, rewrite to use child
   1575 	traversal methods.
   1576         (-[WebFrame _nextFrameWithWrap:]): Use new frame traversal stuff (mostly just
   1577 	a thin wrapper on _traverseNextFrameStayWithin: 
   1578         (-[WebFrame _previousFrameWithWrap:]): Use new traversal functions
   1579         (-[WebFrame _numPendingOrLoadingRequests:]): Rewrite loop with new tracrsal functions
   1580         (-[WebFrame _reloadForPluginChanges]): ditto
   1581         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): ditto
   1582         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): ditto
   1583         (-[WebFrame _documentViews]): ditto
   1584         (-[WebFrame _updateDrawsBackground]): ditto
   1585         (-[WebFrame _unmarkAllMisspellings]): ditto
   1586         (-[WebFrame _atMostOneFrameHasSelection]): ditto
   1587         (-[WebFrame _findFrameWithSelection]): ditto
   1588         (-[WebFrame _stopLoadingSubframes]): ditto
   1589         (-[WebFrame _subframeIsLoading]): ditto
   1590         (-[WebFrame _descendantFrameNamed:sourceFrame:]): ditto
   1591 
   1592 2005-12-29  Darin Adler  <darin (a] apple.com>
   1593 
   1594         * WebView.subproj/WebFrameView.m: (-[WebFrameViewPrivate dealloc]):
   1595         Removed unused "draggingTypes" instance variable.
   1596 
   1597 2005-12-29  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   1598 
   1599         Reviewed by darin 
   1600         
   1601         Test: fast/text/atsui-spacing-features.html
   1602 
   1603         - WebKit part of fix for
   1604           http://bugs.webkit.org/show_bug.cgi?id=3922
   1605           Variable word/letter spacing and full justification not supported for
   1606           ATSUI-rendered text
   1607 
   1608         * WebCoreSupport.subproj/WebTextRenderer.m:
   1609         (overrideLayoutOperation): Add letter- and word-spacing and padding for
   1610         justification.
   1611         (createATSULayoutParameters): Compute padding per space.
   1612 
   1613 2005-12-27  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   1614 
   1615         Reviewed by Maciej, landed by Darin.
   1616 
   1617         - fix http://bugs.webkit.org/show_bug.cgi?id=4844
   1618         Render "simple" Hebrew using the CG codepath
   1619 
   1620         * WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Exclude Hebrew letters and maqaf.
   1621 
   1622 2005-12-25  Maciej Stachowiak  <mjs (a] apple.com>
   1623 
   1624         Reviewed by Geoff
   1625 
   1626         - Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept
   1627         http://bugs.webkit.org/show_bug.cgi?id=6241
   1628 
   1629         * WebCoreSupport.subproj/WebBridge.h:
   1630         * WebCoreSupport.subproj/WebBridge.m:
   1631         (-[WebBridge canTargetLoadInFrame:]): Use bridge parent method instead of needlessly
   1632 	asking for parent via WebFrame
   1633         (-[WebBridge frameDetached]): Don't call _removeChild on the parent frame any more
   1634 	because WebFame's _detachFromParent takes care of that now.
   1635         * WebView.subproj/WebFrame.m:
   1636         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Fix stray spaces
   1637         (-[WebFrame _detachChildren]): Don't remove children as we loop any more, they
   1638 	can remove themselves.
   1639         (-[WebFrame _detachFromParent]): Remove self from parent; don't nil out bridge
   1640 	until we are done with it.
   1641         (-[WebFrame _transitionToCommitted:]): Remove some extra braces.
   1642         (-[WebFrame _goToItem:withLoadType:]): Use parentFrame method in assert instead of parent
   1643 	field directly.
   1644         (-[WebFrame _addChild:]): Don't poke at parent frame pointer in _private
   1645 	since it is not there any more.
   1646         (-[WebFrame _removeChild:]): Remove extra braces and don't clear parent pointer
   1647 	explicitly any more.
   1648         (-[WebFrame _addFramePathToString:]): Get parentFrame from method, not field.
   1649         (-[WebFrame _loadDataSource:withLoadType:formState:]): Remove extra braces.
   1650         (-[WebFrame _nextFrameWithWrap:]): Get parent in the proper way and clean up the
   1651 	coding style.
   1652         (-[WebFrame _previousFrameWithWrap:]): Ditto.
   1653         (-[WebFrame parentFrame]): Get parent from the bridge.
   1654 
   1655 2005-12-25  Maciej Stachowiak  <mjs (a] apple.com>
   1656 
   1657         Reviewed by Hyatt.
   1658 
   1659 	- fixed REGRESSION: world leak of WebDataSource
   1660 	http://bugs.webkit.org/show_bug.cgi?id=6242
   1661 
   1662         * WebView.subproj/WebDataSource.m:
   1663         (-[WebDataSource _stopLoading]): don't retain self until after
   1664 	the possible early return.
   1665 
   1666 2005-12-24  Maciej Stachowiak  <mjs (a] apple.com>
   1667 
   1668         Reviewed by Geoff.
   1669 
   1670 	- rearrange some code in WebDataSource so that more of the frame traversal logic
   1671 	is in WebFrame, in preparation for moving it down to WebBridge.
   1672 	http://bugs.webkit.org/show_bug.cgi?id=6239
   1673 
   1674         * WebView.subproj/WebDataSource.m:
   1675         (-[WebDataSource _archiveWithMarkupString:nodes:]): Assert that the
   1676 	data source is committed, doesn't make sense to archive otherwise.
   1677         (-[WebDataSource _subframeArchivesWithCurrentState:]): New helper method.
   1678         (-[WebDataSource _archiveWithCurrentState:]): Assert that the data source
   1679 	is committed. Use the helper.
   1680         (-[WebDataSource _setWebView:]): Comment that we won't tell subframes that
   1681 	defers callback changed.
   1682         (-[WebDataSource _startLoading]): Remove stray space.
   1683         (-[WebDataSource _stopLoading]): Only handle local _stopLoading business.
   1684 	Cound on WebFrame to tell subframes to stop loading. Fold in _stopLoadingInternal
   1685 	and remove _recursiveStopLoading.
   1686         (-[WebDataSource _startLoading:]): Clean up an assert slightly.
   1687         (-[WebDataSource _setTitle:]): Remove stray spaces.
   1688         (-[WebDataSource _defersCallbacksChanged]): Don't call subframes. WebFrame
   1689 	can do that.
   1690         (-[WebDataSource isLoading]): Move checking of subframes down to WebFrame.
   1691         (-[WebDataSource webArchive]): Return nil if the data source is not yet
   1692 	committed. It makes no sense to archive a provisional data source since it
   1693 	has no data yet.
   1694         (-[WebDataSource addSubresource:]): Replace an assert with an early return,
   1695 	ASSERT is not an appropriate way to flag problems with the argument of a public
   1696 	method.
   1697         * WebView.subproj/WebDataSourcePrivate.h:
   1698         * WebView.subproj/WebFrame.m:
   1699         (-[WebFrame _setLoadType:]): Remove stray space.
   1700         (-[WebFrame _checkLoadCompleteForThisFrame]): Stop loading subframes
   1701 	manually and add a FIXME about confusingness of stopping loading here.
   1702         (-[WebFrame _defersCallbacksChanged]): Tell our subframes.
   1703         (-[WebFrame _addChild:]): Remove stray space.
   1704         (-[WebFrame _stopLoadingSubframes]): New helper method.
   1705         (-[WebFrame _subframeIsLoading]): New helper method, code moved
   1706 	from WebDataSource.
   1707         (-[WebFrame stopLoading]): Tell subframes to stop loading.
   1708         (-[WebFrame reload]): Remove extra braces.
   1709         * WebView.subproj/WebFrameInternal.h:
   1710 
   1711 2005-12-23  Maciej Stachowiak  <mjs (a] apple.com>
   1712 
   1713         Reviewed by John.
   1714 
   1715 	- move more frame tree traversal code from WebView to WebFrame
   1716 
   1717         * WebView.subproj/WebFrame.m:
   1718         (-[WebFrame _atMostOneFrameHasSelection]): Moved this debug
   1719 	method from WebView, renamed it and changed it to return a boolean
   1720 	so it is appropriate for use in assertions instead of giving its own
   1721 	errors.
   1722         (-[WebFrame _accumulateFramesWithSelection:]): Helper for the above.
   1723         (-[WebFrame _findFrameWithSelection]):  Moved from WebView and renamed from
   1724 	_findSelectedFrame, also removed the skipping variant.
   1725         (-[WebFrame _clearSelectionInOtherFrames]): Moved from WebView and
   1726 	changed how the logic works. Instead of clearing selection in any frame
   1727 	but the focus frame, it clears selection in all but this one.
   1728         * WebView.subproj/WebFrameInternal.h:
   1729         * WebView.subproj/WebHTMLView.m:
   1730         (-[WebHTMLView becomeFirstResponder]): Call _clearSelectionInOtherFrames
   1731         * WebView.subproj/WebPDFView.m:
   1732         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Stop getting WebFrame
   1733 	in needlessly roundabout way.
   1734         (-[WebPDFView becomeFirstResponder]): Call _clearSelectionInOtherFrames
   1735         * WebView.subproj/WebTextView.m:
   1736         (-[WebTextView _webFrame]): New helper method.
   1737         (-[WebTextView _elementAtWindowPoint:]): Use it.
   1738         (-[WebTextView becomeFirstResponder]): Call _clearSelectionInOtherFrames
   1739         (-[WebTextView resignFirstResponder]): Fix style issue
   1740         (-[WebTextView clickedOnLink:atIndex:]): Use new helkper
   1741         * WebView.subproj/WebView.m:
   1742         (-[WebView selectedFrame]): Call to WebFrame as appropriate
   1743         (-[WebView _selectedOrMainFrame]): Fix style issue
   1744         * WebView.subproj/WebViewInternal.h:
   1745 
   1746 2005-12-22  Maciej Stachowiak  <mjs (a] apple.com>
   1747 
   1748         Reviewed by Eric.
   1749 
   1750 	- move a few more methods from WebView to WebFrame.	
   1751 
   1752         * WebView.subproj/WebFrame.m:
   1753         (-[WebFrame _hasSelection]): Renamed from _frameIsSelected: and moved from
   1754 	WebView.
   1755         (-[WebFrame _clearSelection]): Renamed from _deselectFrame: and moved from 
   1756 	WebView.
   1757         * WebView.subproj/WebFrameInternal.h:
   1758         * WebView.subproj/WebView.m:
   1759         (-[WebView searchFor:direction:caseSensitive:wrap:]): Update for renames.
   1760         (-[WebView _findSelectedFrameStartingFromFrame:skippingFrame:]): Ditto.
   1761         (-[WebView _debugCollectSelectedFramesIntoArray:startingFromFrame:]): Ditto.
   1762         (-[WebView _selectedFrameDidChange]):
   1763 
   1764 2005-12-21  Timothy Hatcher  <timothy (a] apple.com>
   1765 
   1766         * WebKit.xcodeproj/project.pbxproj:
   1767           Set tab width to 8, indent width to 4 and uses tabs to false per file.
   1768 
   1769 2005-12-20  Alexey Proskuryakov  <ap (a] nypop.com>
   1770 
   1771         Reviewed by justin
   1772         
   1773         <http://bugs.webkit.org/show_bug.cgi?id=4682>
   1774         -[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text
   1775 
   1776         * WebView.subproj/WebHTMLView.m:
   1777         (-[WebHTMLView firstRectForCharacterRange:]): 
   1778         Handle some large unsigned values the way NSTextView does.
   1779         Actually use the range passed in instead of _selectedRange,
   1780         use of _selectedRange was a workaround that is no longer necessary.
   1781 
   1782 2005-12-20  John Sullivan  <sullivan (a] apple.com>
   1783 
   1784         Reviewed by Darin Adler.
   1785         
   1786         - fixed http://bugs.webkit.org/show_bug.cgi?id=6146
   1787           (REGRESSION: Bold font used for Google search result pages is too thick)
   1788           
   1789         This is a problem with a particular font that was installed by Microsoft Office X. Though the
   1790         font and/or lower levels of font-handling code in the system are buggy, this bad symptom will
   1791         occur for users of Safari and other WebKit clients who happen to have one of these bad fonts.
   1792         This adds a workaround to avoid the problem.
   1793 
   1794         * WebCoreSupport.subproj/WebTextRendererFactory.m:
   1795         (-[WebTextRendererFactory fontWithFamilies:traits:size:]):
   1796         When we're going to synthesize bold or italic, yet the font we looked up was apparently a
   1797         match for the traits, try to look up a font that without the to-be-synthesized traits.
   1798         This way, instead of applying synthetic bold over Arial Bold, we'll apply synthetic
   1799         bold over Arial Regular, which is uglier than just using Arial Bold, but far less ugly
   1800         than using Arial Bold with synthetic bold too.
   1801 
   1802  2005-12-16  Justin Garcia  <justin.garcia (a] apple.com>
   1803  
   1804          <rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)
   1805          <rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const  436
   1806          
   1807          Reviewed by darin
   1808          
   1809          WebCore will crash when a selection that starts or ends in a node 
   1810          that has been removed from the document is modify()d.  This can occur:
   1811          (1) in non-editable regions (4103393 and 4330451), (2) in editable 
   1812          regions (4383146) as the result of arbitrary DOM operations, and (3) in 
   1813          Mail (4099739) as the result of an editing operation that sets a 
   1814          bad ending selection.
   1815          
   1816          Crashes of type (1) can occur when the user uses the arrow keys 
   1817          to interact with a web app, or when the user tries to use 
   1818          command-shift-arrow to switch tabs (this is a depricated
   1819          combo that will work if no one else responds to it). The easiest 
   1820          way to fix these crashes is to disallow editing'ish selection changes 
   1821          like moveDown:, selectWord:, pageDown:, etc, when the selection 
   1822          is in a non-editable region.
   1823          
   1824          Crashes of type (2) will require a more complicated fix (but occur 
   1825          much less often than type (1)).  Crashes of type (3) must be 
   1826          fixed by tracking down the editing operation that sets bad selections.
   1827          
   1828          Added a layout-test:
   1829          * editing/selection/selection-actions.html
   1830  
   1831          * WebView.subproj/WebHTMLView.m:
   1832          (-[WebHTMLView _canAlterCurrentSelection]):
   1833          (-[WebHTMLView _alterCurrentSelection:direction:granularity:]):
   1834          (-[WebHTMLView _alterCurrentSelection:verticalDistance:]):
   1835          (-[WebHTMLView _expandSelectionToGranularity:]):
   1836          * WebView.subproj/WebHTMLViewPrivate.h:
   1837 
   1838 2005-12-20  Justin Garcia  <justin.garcia (a] apple.com>
   1839 
   1840         Reviewed by mitz
   1841         
   1842         Fixed more uninitialized variable warnings, and 
   1843         removed an extra semicolon.
   1844 
   1845         * WebCoreSupport.subproj/WebTextRenderer.m:
   1846         (overrideLayoutOperation):
   1847         (createATSULayoutParameters):
   1848 
   1849 2005-12-20  Maciej Stachowiak  <mjs (a] apple.com>
   1850 
   1851         Reviewed by Darin.
   1852 
   1853 	- push more of frame lookup and management from WebView to
   1854 	WebFrame, this is in preparation for shifting this to WebCore
   1855 	http://bugs.webkit.org/show_bug.cgi?id=6163
   1856 	
   1857         * WebCoreSupport.subproj/WebBridge.m:
   1858         (-[WebBridge closeWindowSoon]): Adjust for change to WebFrameNamespaces
   1859         (-[WebBridge runModal]): ditto
   1860         * WebView.subproj/WebControllerSets.h:
   1861         * WebView.subproj/WebControllerSets.m:
   1862         (+[WebFrameNamespaces addFrame:toNamespace:]): This now operates in terms
   1863 	of WebFrames (expected to be the main frame) not WebViews.
   1864         (+[WebFrameNamespaces framesInNamespace:]): Ditto.
   1865         * WebView.subproj/WebFrame.m:
   1866         (-[WebFrame _setFrameNamespace:]): Set self, not WebView.
   1867         (-[WebFrame _shouldAllowAccessFrom:]): Moved this code above use
   1868 	to avoid prototyping the method.
   1869         (-[WebFrame _descendantFrameNamed:sourceFrame:]): Ditto.
   1870         (-[WebFrame _frameInAnyWindowNamed:sourceFrame:]): Copied logic
   1871 	over from WebView.
   1872         (-[WebFrame findFrameNamed:]): Do it all here, don't call WebView.
   1873         * WebView.subproj/WebFramePrivate.h:
   1874         * WebView.subproj/WebView.m:
   1875         * WebView.subproj/WebViewPrivate.h:
   1876 
   1877 2005-12-20  Geoffrey Garen  <ggaren (a] apple.com>
   1878 
   1879         Reviewed by adele.
   1880 
   1881         Fixed build failure due to missing 'b's in my last checkin.
   1882 
   1883         * WebCoreSupport.subproj/WebBridge.m:
   1884         (-[WebBridge isStatusbarVisible]): changed 'B' to 'b'
   1885         (-[WebBridge setStatusbarVisible:]): ditto
   1886 
   1887 2005-12-20  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   1888 
   1889         Reviewed by Darin, committed by Adele.
   1890 
   1891         - fix deployment builds broken by the ATSUI multiple renderers patch
   1892         http://bugs.webkit.org/show_bug.cgi?id=6153
   1893 
   1894         * WebCoreSupport.subproj/WebTextRenderer.m:
   1895         (createATSULayoutParameters): Assign initial values, which will never be used,
   1896         to substituteRenderer and firstSmallCap, to avoid uninitialized variable warnings.
   1897 
   1898 2005-12-20  Geoffrey Garen  <ggaren (a] apple.com>
   1899 
   1900         Reviewed by John.
   1901 
   1902         Part of fix for <rdar://problem/4310363> JavaScript window.open: Height
   1903         is 1 pixel short, and related bugs. See WebCore ChageLog.
   1904 
   1905         * WebCoreSupport.subproj/WebBridge.m:
   1906         (-[WebBridge webView]): Added method.
   1907 
   1908 2005-12-20  Eric Seidel  <eseidel (a] apple.com>
   1909 
   1910         Reviewed by mjs.
   1911 
   1912         Development-only build fix.
   1913 
   1914         * WebView.subproj/WebFrame.m:
   1915         (-[WebFramePrivate dealloc]): fixed typo
   1916 
   1917 2005-12-20  Maciej Stachowiak  <mjs (a] apple.com>
   1918 
   1919         Not reviewed.
   1920 
   1921 	- revert accidental commit of this file.
   1922 
   1923 2005-12-19  Maciej Stachowiak  <mjs (a] apple.com>
   1924 
   1925         Reviewed by Eric.
   1926 
   1927 	- Move handling of frame namespaces down to WebFrame.
   1928 	- Put some internal class declarations in the implementation file.
   1929 
   1930         * WebView.subproj/WebControllerSets.m:
   1931         (+[WebFrameNamespaces addWebView:toFrameNamespace:]):
   1932         (+[WebFrameNamespaces webViewsInFrameNamespace:]):
   1933         * WebView.subproj/WebFrame.m:
   1934         (-[WebFramePrivate dealloc]):
   1935         (-[WebFrame _setFrameNamespace:]):
   1936         (-[WebFrame _frameNamespace]):
   1937         * WebView.subproj/WebFrameInternal.h:
   1938         * WebView.subproj/WebFramePrivate.h:
   1939         * WebView.subproj/WebView.m:
   1940         (-[WebView _close]):
   1941         (-[WebView _findFrameNamed:sourceFrame:]):
   1942         (-[WebView setGroupName:]):
   1943         (-[WebView groupName]):
   1944         * WebView.subproj/WebViewInternal.h:
   1945 
   1946 2005-12-19  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   1947 
   1948         Reviewed by Darin, committed by Adele.
   1949         
   1950         Test: fast/text/atsui-multiple-renderers.html
   1951 
   1952         - fix http://bugs.webkit.org/show_bug.cgi?id=6139
   1953           ATSUI code path should implement small caps, synthetic bold and oblique and correct metrics for fallback fonts
   1954 
   1955         * WebCoreSupport.subproj/WebTextRenderer.m:
   1956         (overrideLayoutOperation): Fetch renderer info from the renderers array;
   1957         add synthetic bold offset; render only synthetic bold in the synthetic bold pass.
   1958         (drawGlyphs): Replaced 14 with new SYNTHETIC_OBLIQUE_ANGLE define.
   1959         (initializeATSUStyle): Apply a skewing transform for synthetic oblique.
   1960         (createATSUTextLayout): Merged into createATSUTextLayout.
   1961         (createATSULayoutParameters): Merged in createATSUTextLayout; allocate
   1962         and fill a renderers array and a character buffer for small caps and mirroring;
   1963         (applyMirroringToRun): Merged into createATSULayoutParameters.
   1964         (ATSU_drawHighlight): Deleted mirroring code.
   1965         (ATSU_draw): Deleted mirroring code; added second pass for synthetic bold.
   1966         (ATSU_pointToOffset): Deleted mirroring code.
   1967 
   1968 2005-12-19  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   1969 
   1970         Reviewed by Darin, committed by Adele.
   1971         
   1972         Test: fast/text/atsui-kerning-and-ligatures.html
   1973 
   1974         - fix http://bugs.webkit.org/show_bug.cgi?id=6137
   1975           Disable kerning and some ligatures in the ATSUI code path
   1976 
   1977         * WebCoreSupport.subproj/WebTextRenderer.m:
   1978         (initializeATSUStyle): Disable kerning; disable ligatures unless the font
   1979         does not contain 'a', in which case it is assumed to never be rendered
   1980         by the CG code path.
   1981 
   1982 2005-12-19  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   1983 
   1984         Reviewed by Darin, committed by Adele.
   1985         
   1986         Test: fast/text/should-use-atsui.html
   1987 
   1988         - fix for http://bugs.webkit.org/show_bug.cgi?id=6132
   1989           Incorrect selection highlighting for ATSUI text when selected range is "CG-safe"
   1990 
   1991         * WebCoreSupport.subproj/WebTextRenderer.m:
   1992         (shouldUseATSU): Always start scanning from 0 since drawing and
   1993         highlighting also measure everything up to run->from.
   1994 
   1995 2005-12-17  Maciej Stachowiak  <mjs (a] apple.com>
   1996 
   1997         Rubber stamped by Eric.
   1998 
   1999 	- remove some unused SPI headers.
   2000 
   2001         * DOM.subproj/WebDOMDocument.h: Removed.
   2002         * DOM.subproj/WebDOMElement.h: Removed.
   2003         * DOM.subproj/WebDOMNode.h: Removed.
   2004         * WebKit.xcodeproj/project.pbxproj:
   2005 
   2006 2005-12-17  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   2007 
   2008         Reviewed and landed by Darin.
   2009 
   2010         - fix http://bugs.webkit.org/show_bug.cgi?id=5479
   2011           Can't select text with RTL override rendered by ATSUI
   2012 
   2013         * WebCoreSupport.subproj/WebTextRenderer.m:
   2014         (overrideLayoutOperation): Update since the layout only includes from -> to now.
   2015         (-[WebTextRenderer pointToOffset:style:position:includePartialGlyphs:]): Remove
   2016         reversed parameter.
   2017         (CG_floatWidthForRun): Add code to handle RTL case.
   2018         (addDirectionalOverride): Put the override around the entire run.
   2019         (ATSU_drawHighlight): Rearrange and reuse ATSU_floatWidthForRun for more of the work.
   2020         Also round.
   2021         (ATSU_pointToOffset): Remove reversed parameter and run swapping.
   2022         (CG_pointToOffset): Remove reversed parameter, using rtl flag in style instead.
   2023 
   2024 2005-12-16  Evan Gross  <evan (a] rainmakerinc.com>
   2025 
   2026         Reviewed and landed by Darin.
   2027 
   2028         - fix http://bugs.webkit.org/show_bug.cgi?id=4680
   2029           WebHTMLView (WebNSTextInputSupport) - attributedSubstringFromRange "not yet implemented"
   2030 
   2031         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView attributedSubstringFromRange:]):
   2032         Implement by calling the same RTF conversion used when copying to the pasteboard.
   2033 
   2034 2005-12-16  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   2035 
   2036         Reviewed and landed by Darin.
   2037 
   2038         - fix http://bugs.webkit.org/show_bug.cgi?id=6090
   2039           REGRESSION: Assertion failure when choosing Copy from a WebImageView's contextual menu
   2040 
   2041         * WebView.subproj/WebImageView.m:
   2042         (-[WebImageView elementAtPoint:]): Use WebCoreElementImageRendererKey
   2043         for the image renderer and WebElementImageKey for the image.
   2044 
   2045 2005-12-15  Maciej Stachowiak  <mjs (a] apple.com>
   2046 
   2047         Reviewed by Darin.
   2048 
   2049 	- remove _frameForView: method from WebView and replace with a direct pointer on the WebFrameView in the WebFrame
   2050 
   2051         * Misc.subproj/WebNSViewExtras.m:
   2052         * WebView.subproj/WebFrame.m:
   2053         (-[WebFrame _detachFromParent]):
   2054         (-[WebFrame _loadDataSource:withLoadType:formState:]):
   2055         (-[WebFrame initWithName:webFrameView:webView:]):
   2056         * WebView.subproj/WebFrameView.m:
   2057         (-[WebFrameView _setWebFrame:]):
   2058         (-[WebFrameView webFrame]):
   2059         * WebView.subproj/WebFrameViewInternal.h:
   2060         * WebView.subproj/WebView.m:
   2061         * WebView.subproj/WebViewPrivate.h:
   2062 
   2063 2005-12-13  Maciej Stachowiak  <mjs (a] apple.com>
   2064 
   2065         Reviewed by Darin.
   2066 
   2067 	- remove the dead _frameForDataSource: method (WebDataSource now knows its WebFrame)
   2068 	http://bugs.webkit.org/show_bug.cgi?id=6072
   2069 	
   2070         * WebView.subproj/WebView.m:
   2071         * WebView.subproj/WebViewPrivate.h:
   2072 
   2073 === Safari-521~5 ===
   2074 
   2075 2005-12-12  Timothy Hatcher  <timothy (a] apple.com>
   2076 
   2077         Reviewed by nobody, simple build fix.
   2078 
   2079         Fixes a couple ambiguous selector build errors when building with GCC 3.3.
   2080 
   2081         * Misc.subproj/WebIconDatabase.m:
   2082         (-[WebIconDatabase releaseIconForURL:]):
   2083         * WebView.subproj/WebHTMLView.m:
   2084         (-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]):
   2085         (-[NSArray elementAtPoint:]):
   2086 
   2087 2005-12-12  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   2088 
   2089         Reviewed and checked in by John Sullivan.
   2090         
   2091         Fix for: http://bugs.webkit.org/show_bug.cgi?id=6053
   2092         WebIconDatabase returns the Accessibility Verifier app icon instead of
   2093         a generic document icon
   2094         
   2095         * Misc.subproj/WebIconDatabase.m:
   2096         (-[WebIconDatabase _iconForFileURL:withSize:]):
   2097         use file type iconForFileType:NSFileTypeForHFSTypeCode(kGenericDocumentIcon) instead of '????'
   2098         to get the generic document icon.
   2099 
   2100 2005-12-12  John Sullivan  <sullivan (a] apple.com>
   2101 
   2102         Reviewed by Tim Omernick.
   2103         
   2104         - Made protocol <WebDocumentSelection> include protocol <WebDocumentText>, for clarity.
   2105         This required moving some methods from WebTextView, which conformed to <WebDocumentText>,
   2106         up into superclass WebSearchableTextView, which conformed to <WebDocumentSelection>.
   2107 
   2108         * Misc.subproj/WebSearchableTextView.m:
   2109         (-[NSString supportsTextEncoding]):
   2110         moved this method (unchanged) from subclass WebTextView
   2111         (-[NSString string]):
   2112         ditto
   2113         (-[NSString attributedString]):
   2114         ditto
   2115         (-[NSString selectedString]):
   2116         ditto
   2117         (-[NSString selectedAttributedString]):
   2118         ditto
   2119         (-[NSString selectAll]):
   2120         ditto
   2121         (-[NSString deselectAll]):
   2122         ditto
   2123         
   2124         * WebView.subproj/WebDocumentPrivate.h:
   2125         made <WebDocumentSelection> incorporate <WebDocumentText> rather than just <NSObject>
   2126         * WebView.subproj/WebHTMLView.h:
   2127         removed <WebDocumentText> from protocol list since it's covered by <WebDocumentSelection>
   2128         * WebView.subproj/WebPDFView.h:
   2129         ditto
   2130         * WebView.subproj/WebTextView.h:
   2131         ditto
   2132         * WebView.subproj/WebTextView.m:
   2133         removed the methods that were moved into WebSearchableTextView.m
   2134 
   2135 2005-12-10  Darin Adler  <darin (a] apple.com>
   2136 
   2137         Reviewed by John Sullivan.
   2138 
   2139         - fix http://bugs.webkit.org/show_bug.cgi?id=6032
   2140           REGRESSION: Uncaught exception when image is dragged out of webpage
   2141 
   2142         * WebView.subproj/WebHTMLView.m:
   2143         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
   2144         Pass the image renderer, not the NSImage.
   2145         (-[WebHTMLView elementAtPoint:]): Add an NSImage to the dictionary, which now comes from
   2146         WebCore with only an image renderer.
   2147         * WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]):
   2148         Pass the image renderer, not the NSImage.
   2149 
   2150 2005-12-10  Darin Adler  <darin (a] apple.com>
   2151 
   2152         Was getting build failures related to "count" methods.
   2153         Made Tim's build fix Leopard-only.
   2154 
   2155         * WebView.subproj/WebPreferencesPrivate.h: Go back to <PDFKit/PDFKit.h> on Tiger.
   2156 
   2157 2005-12-09  John Sullivan  <sullivan (a] apple.com>
   2158 
   2159         Reviewed by Adele Peterson.
   2160         
   2161         - fixed <rdar://problem/4373905> Cannot paste in Tiger Mail using TOT WebKit
   2162 
   2163         * WebView.subproj/WebView.m:
   2164         (-[WebView _frameForCurrentSelection]):
   2165         I removed this method many moons ago when restructuring the code involving frames and selection.
   2166         Too bad Mail was still using it (d'oh!). In Leopard Mail has updated to use newer SPI (which should
   2167         become API), but to continue to work with Mail on Tiger we need this method to be around. Now it's
   2168         just a cover for the method _selectedOrMainFrame, to which it was renamed so very long ago.
   2169 
   2170 2005-12-09  Tim Omernick  <timo (a] apple.com>
   2171 
   2172         Reviewed by John Sullivan.
   2173 
   2174         * Carbon.subproj/HIWebView.m:
   2175         (UpdateCommandStatus):
   2176 	Don't call -performSelector:withObject: on a method that returns a BOOL; this is not guaranteed to work on all architectures.
   2177 	-performSelector:withObject:'s return value should only be checked if the method returns an object.
   2178 
   2179 2005-12-09  Timothy Hatcher  <timothy (a] apple.com>
   2180 
   2181         Reviewed by nobody, build fix.
   2182 
   2183         Using <PDFKit/PDFKit.h> was causing build failures for the Mail team.
   2184         The comment about getting an ambiguous signature conflict anywhere the
   2185         method "count" is used seems to no longer be an issue.
   2186 
   2187         * WebView.subproj/WebPreferencesPrivate.h: Use <Quartz/Quartz.h>
   2188 
   2189 2005-12-08  John Sullivan  <sullivan (a] apple.com>
   2190 
   2191         Reviewed by Tim Hatcher.
   2192         
   2193         Some cleanup of how selection rects are associated with NSViews.
   2194 
   2195         * WebView.subproj/WebDocumentPrivate.h:
   2196         Added a -selectionView method to <WebDocumentSelection>, and clarified that the
   2197         selectionRect is in the coordinate system of this view.
   2198 
   2199         * Misc.subproj/WebSearchableTextView.m:
   2200         (-[WebSearchableTextView selectionView]):
   2201         new method, returns self
   2202         
   2203         * WebView.subproj/WebHTMLView.m:
   2204         (-[WebHTMLView selectionView]):
   2205         new method, returns self
   2206         
   2207         * WebView.subproj/WebPDFView.m:
   2208         (-[WebPDFView selectionRect]):
   2209         translate result into coordinate system of [PDFSubview documentView]
   2210         (-[WebPDFView selectionView]):
   2211         new method, returns [PDFSubview documentView]
   2212 
   2213 2005-12-08  John Sullivan  <sullivan (a] apple.com>
   2214 
   2215         Reviewed by Tim Omernick and Dave Hyatt.
   2216         
   2217         - fixed these semi-legendary bugs:
   2218         <rdar://problem/4032405> Inline PDF doesn't get keyboard focus like web pages do, so can't scroll with keys without clicking
   2219         <rdar://problem/4265684> PDFs use secondary selection when displaying found text (4748)
   2220 
   2221         * WebView.subproj/WebPDFView.m:
   2222         (-[WebPDFView becomeFirstResponder]):
   2223         Discovered that there is indeed PDFKit API for accessing the view that becomes focused; now
   2224         passes the focus down to that view.
   2225 
   2226 2005-12-08  John Sullivan  <sullivan (a] apple.com>
   2227 
   2228         Reviewed by Tim Omernick.
   2229         
   2230         - Added WebKit mechanism to help correctly pass the first responder into the PDF view hierarchy,
   2231         in order to start addressing keyboard focus and selection highlight issues. Unfortunately this 
   2232         doesn't actually have any user effect yet due to problems that must be fixed in PDFKit.
   2233 
   2234         * WebView.subproj/WebPDFView.m:
   2235         (-[WebPDFView acceptsFirstResponder]):
   2236         Overridden to returns YES. Needed so NSClipView knows it's OK to pass focus down to this level.
   2237         (-[WebPDFView becomeFirstResponder]):
   2238         With setNextKeyView:, splices the PDF view into the focus-passing mechanism in much the same
   2239         way as NSScrollView and NSClipView.
   2240         (-[WebPDFView setNextKeyView:]):
   2241         With becomeFirstResponder:, splices the PDF view into the focus-passing mechanism in much the same
   2242         way as NSScrollView and NSClipView.
   2243         (-[WebPDFView resignFirstResponder]):
   2244         Removed this method because the WebPDFView itself is never first responder except transiently.
   2245 
   2246 2005-12-08  Maciej Stachowiak  <mjs (a] apple.com>
   2247 
   2248         Reviewed by John.
   2249 
   2250 	- some small changes towards frame tree refactoring
   2251 
   2252 	Renamed WebViewSets to WebFrameNamespaces, and put the method for
   2253 	performing a selector on all extant WebViews to WebView itself,
   2254 	with a separate set tracking live WebViews. This should allow
   2255 	moving the storage of this info down to WebCore more easily.
   2256 
   2257         * WebCoreSupport.subproj/WebBridge.m:
   2258         (-[WebBridge closeWindowSoon]):
   2259         (-[WebBridge runModal]):
   2260         * WebCoreSupport.subproj/WebViewFactory.m:
   2261         (-[WebViewFactory refreshPlugins:]):
   2262         * WebView.subproj/WebControllerSets.h:
   2263         * WebView.subproj/WebControllerSets.m:
   2264         (+[WebFrameNamespaces addWebView:toFrameNamespace:]):
   2265         (webView::if):
   2266         (+[WebFrameNamespaces webViewsInFrameNamespace:]):
   2267         * WebView.subproj/WebView.m:
   2268         (+[WebView _makeAllWebViewsPerformSelector:]):
   2269         (-[WebView _removeFromAllWebViewsSet]):
   2270         (-[WebView _addToAllWebViewsSet]):
   2271         (-[WebView _close]):
   2272         (-[WebView _findFrameNamed:sourceFrame:]):
   2273         (-[WebView _commonInitializationWithFrameName:groupName:]):
   2274         (-[WebView setGroupName:]):
   2275         * WebView.subproj/WebViewInternal.h:
   2276 
   2277 2005-12-08  Darin Adler  <darin (a] apple.com>
   2278 
   2279         Reviewed by Eric.
   2280 
   2281         - fixed http://bugs.webkit.org/show_bug.cgi?id=5689
   2282           add support for CSS "custom cursors" (cursor images)
   2283 
   2284         * WebCoreSupport.subproj/WebImageRenderer.h: Remove declaration of TIFFRepresentation and
   2285         image methods since both are required by the WebCoreImageRenderer protocol now and we don't
   2286         have to re-declare them.
   2287 
   2288         * Misc.subproj/WebNSPasteboardExtras.m: Add an import of the WebCoreImageRenderer.h file
   2289         since we need to use methods inherited from that protocol.
   2290         * Misc.subproj/WebNSViewExtras.m: Ditto.
   2291         * WebCoreSupport.subproj/WebImageRenderer.m: Ditto. (Use and implement.)
   2292 
   2293 2005-12-07  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   2294 
   2295         Reviewed by Maciej, landed by Darin.
   2296 
   2297         - fix http://bugs.webkit.org/show_bug.cgi?id=5878
   2298           REGRESSION (WebTextRenderer.m r1.201): pointToOffset always takes the CG code path
   2299 
   2300         * WebCoreSupport.subproj/WebTextRenderer.m:
   2301         (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]):
   2302         Added the missing "return".
   2303 
   2304 2005-12-07  John Sullivan  <sullivan (a] apple.com>
   2305 
   2306         Reviewed by Tim Omernick.
   2307         
   2308         - <rdar://problem/4331488> TOT Assertion failure in -[WebHTMLView nextValidKeyView] 
   2309         @ home.netscape.com
   2310 
   2311         * WebView.subproj/WebHTMLView.m:
   2312         (-[NSArray nextValidKeyView]):
   2313         Removed assert that I added a while back. In this case at least, the assertion is
   2314         overzealous, and I can't recreate the tortured chain of logic that led me to adding
   2315         this assertion in the first place.
   2316 
   2317 2005-12-06  David Harrison  <harrison (a] apple.com>
   2318 
   2319 	Reviewed by Darin.
   2320 
   2321 	- fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields
   2322 	
   2323 	Add use of NSAccessibilityHitTest to the list of exceptions.
   2324 
   2325 	* WebView.subproj/WebHTMLView.m:
   2326 	(-[WebHTMLView hitTest:]): check for NSFlagsChanged event. 
   2327 
   2328 2005-12-05  John Sullivan  <sullivan (a] apple.com>
   2329 
   2330         Reviewed by Darin Adler.
   2331 
   2332         * WebView.subproj/WebHTMLView.m:
   2333         (-[NSArray validateUserInterfaceItem:]):
   2334         one more tweak: moved jumpToSelection: to be validated the same way as
   2335         centerSelectionInVisibleArea:, since it now calls the same code. Might not
   2336         make a difference in any real code, but you never know.
   2337 
   2338 2005-12-05  John Sullivan  <sullivan (a] apple.com>
   2339 
   2340         Reviewed by Darin Adler.
   2341 
   2342         * WebView.subproj/WebHTMLView.m:
   2343         (-[NSArray validateUserInterfaceItem:]):
   2344         removed double handling of centerSelectionInVisibleArea
   2345 
   2346 2005-12-05  John Sullivan  <sullivan (a] apple.com>
   2347 
   2348         Reviewed by Tim Omernick.
   2349         
   2350         - WebKit part of fix for 
   2351         <rdar://problem/4365690> Find > Jump to Selection does nothing on plain-text documents (inc. source HTML)        
   2352 
   2353         * WebView.subproj/WebHTMLView.m:
   2354         (-[WebHTMLView jumpToSelection:]):
   2355         Reimplement jumpToSelection: to call centerSelectionInVisibleArea:, and added a comment explaining why
   2356         jumpToSelection: exists at all. Note that centerSelectionInVisibleArea: was already implemented here; it
   2357         was added as part of HTML editing implementation without us realizing that it was the API replacement
   2358         for jumpToSelection:.
   2359         (-[WebHTMLView validateUserInterfaceItem:]):
   2360         validate centerSelectionInVisibleArea: the same way we validate jumpToSelection: (we should have done
   2361         this when centerSelectionInVisibleArea: was implemented)
   2362         
   2363         * WebView.subproj/WebPDFView.m:
   2364         (-[WebPDFView centerSelectionInVisibleArea:]):
   2365         new method, same code that jumpToSelection: used to have
   2366         (-[WebPDFView jumpToSelection:]):
   2367         now calls centerSelectionInVisibleArea:, and there's now a comment about why it exists at all.
   2368         (-[WebPDFView validateUserInterfaceItem:]):
   2369         validate centerSelectionInVisibleArea: the same way we validate jumpToSelection:
   2370 
   2371 2005-12-04  Tim Omernick  <timo (a] apple.com>
   2372 
   2373         Reviewed by Dave Harrison, John Sullivan.
   2374 
   2375 	<rdar://problem/4364847> REGRESSION: QuickTime movies open without controller or don't open at all (5928)
   2376 
   2377 	I changed WebFrameView on 2005-11-29 so that it avoids creating duplicate WebPluginDocumentViews.
   2378 	Unfortunately, this change caused a regression due to the fact that it subtly changed when plugins are
   2379 	initialized.  Certain plugins (e.g. QuickTime) expect to be initialized after the WebPluginDocumentView
   2380 	has been "committed" (inserted into the view hierarchy).
   2381 
   2382 	My fix is to ensure that the plugin is initialized where we previously would have created that second
   2383 	WebPluginDocumentView -- that is, the plugin is created after the WebPluginDocumentView has been committed.
   2384 	
   2385         * Plugins.subproj/WebPluginDocumentView.m:
   2386         (-[WebPluginDocumentView setDataSource:]):
   2387 	Don't initialize the plugin if the WebPluginDocumentView has not been inserted into the view hierarchy.
   2388 	We assume here that a later call to -setDataSource: will pass this conditional, once the WebDocumentView
   2389 	has been committed.
   2390 	
   2391 2005-12-02  Justin Garcia <justin.garcia (a] apple.com>
   2392 
   2393         <rdar://problem/4345030>
   2394         Denver REGRESSION (10.4.2-10.4.3): Two identical warnings on "Back" from Amazon's package tracker
   2395         
   2396         Before checking the navigation policy for a request, the request is compared
   2397         against the last checked request.  If the two are the same, no check is done.
   2398         In the bug, the two requests are identical except for the boolean on
   2399         NSURLRequests that tells Foundation to support multipart loads for that request.
   2400         One request was the one that was used to start servicing "Back" operation, and
   2401         the second was being used to start loading the page (it needed to be reloaded 
   2402         because it was the result of a form submission). Set the boolean on all 
   2403         NSURLRequests, not just one's that are about to be used to start a load.   
   2404 
   2405         Reviewed by harrison
   2406 
   2407         * WebView.subproj/WebDataSource.m:
   2408         (-[WebDataSource _startLoading:]):
   2409         (-[WebDataSource initWithRequest:]):
   2410         * WebView.subproj/WebDataSourcePrivate.h:
   2411 
   2412 2005-12-01  Darin Adler <darin (a] apple.com>
   2413 
   2414         Reviewed by Vicki.
   2415 	
   2416 	- fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or 
   2417 	mousing up on menu item in applet does not open URL in new window at smartmoney.com
   2418 
   2419 	Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java 
   2420 	applets go through the standard NSView code path. Since this should only happen for Java, add a global
   2421 	so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.
   2422 
   2423         * WebView.subproj/WebHTMLView.m:
   2424         (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest
   2425         (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable  to force a WebHTMLView-style hit test from here
   2426         (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables 
   2427 
   2428 2005-11-29  Andrew Wellington  <proton (a] wiretapped.net>
   2429 
   2430         Reviewed by darin.  Committed by eseidel.
   2431 
   2432         Fix for: http://bugs.webkit.org/show_bug.cgi?id=4726
   2433         Drop of multiple non-image file URLs only yields one item
   2434 
   2435         * WebView.subproj/WebHTMLView.m:
   2436         (-[WebHTMLView _documentFragmentWithPaths:]):
   2437 
   2438 2005-11-29  Tim Omernick  <timo (a] apple.com>
   2439 
   2440         Reviewed by John Sullivan, Eric Seidel
   2441 
   2442 	<rdar://problem/4340787> Safari & Dashcode create 2 instances of the QC plug-in
   2443 	
   2444         * WebView.subproj/WebFrameView.m:
   2445         (-[WebFrameView _makeDocumentViewForDataSource:]):
   2446 	Instead of creating a new WebDocumentView, use the WebDataSource's representation if it is a WebDocumentView
   2447 	of the appropriate class.  Right now, this can only happen when the loading document is a standalone WebKit
   2448 	plugin, because WebPluginDocumentView is both the WebDocumentView and the WebDocumentRepresentation for that
   2449 	kind of page load.
   2450 	
   2451 	I have verified that this does not affect other kinds of page loads; in all other cases, the representation
   2452 	class is distinct from the document view class.
   2453 
   2454 	I talked with Chris Blumenberg about this change (he knows this code), and he agreed that this is the right
   2455 	approach.
   2456 
   2457 2005-11-28  Alexey Proskuryakov  <ap (a] nypop.com>
   2458 
   2459         Reviewed by Darin. Committed by Maciej.
   2460 
   2461 	- fixed "Word completion doesn't work at end of word (unless last word)"
   2462 	(http://bugs.webkit.org/show_bug.cgi?id=4062)
   2463 
   2464         * WebView.subproj/WebHTMLView.m:
   2465         (-[WebTextCompleteController doCompletion]):
   2466 
   2467 2005-11-28  John Sullivan  <sullivan (a] apple.com>
   2468 
   2469         Reviewed by Tim Omernick.
   2470         
   2471         Probable fix for <rdar://problem/4356060> crash in -[WebHistoryItem _mergeAutoCompleteHints:]
   2472 
   2473         * History.subproj/WebHistory.m:
   2474         (-[WebHistoryPrivate addItem:]):
   2475         retain/release oldEntry until we're done with it, since removing it from dictionary might
   2476         cause it to be dealloc'ed otherwise.
   2477         
   2478         * History.subproj/WebHistoryItem.m:
   2479         (-[WebHistoryItem _mergeAutoCompleteHints:]):
   2480         added an assert
   2481 
   2482 2005-11-26  Alexey Proskuryakov  <ap (a] nypop.com>
   2483 
   2484         Reviewed by mjs.  Committed by eseidel.
   2485 
   2486         Fix for http://bugs.webkit.org/show_bug.cgi?id=5230
   2487         "characterIndexForPoint: not yet implemented"
   2488 
   2489         * WebView.subproj/WebHTMLView.m:
   2490         (-[WebHTMLView characterIndexForPoint:]):
   2491         (-[WebHTMLView firstRectForCharacterRange:]):
   2492 
   2493 2005-11-22  Darin Adler  <darin (a] apple.com>
   2494 
   2495         * WebView.subproj/WebView.h: Fixed incorrect comment in public header.
   2496 
   2497 2005-11-18  Vicki Murley  <vicki (a] apple.com>
   2498 
   2499 	Changes by Tim H, reviewed by Vicki.
   2500 
   2501 	- call shouldClose on the bridge for the main frame
   2502 
   2503         * WebView.subproj/WebView.m:
   2504         (-[WebView shouldClose]):
   2505 
   2506 2005-11-18  Vicki Murley  <vicki (a] apple.com>
   2507 
   2508         Changes by Darin, reviewed by Beth and Vicki.
   2509 
   2510         - fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)
   2511 
   2512         * WebCoreSupport.subproj/WebBridge.m:
   2513         (-[WebBridge canRunBeforeUnloadConfirmPanel]):
   2514         (-[WebBridge runBeforeUnloadConfirmPanelWithMessage:]):
   2515         * WebView.subproj/WebFrame.m:
   2516         (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
   2517         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
   2518         * WebView.subproj/WebUIDelegatePrivate.h:
   2519         * WebView.subproj/WebView.m:
   2520         (-[WebView shouldClose]):
   2521         * WebView.subproj/WebViewPrivate.h:
   2522 
   2523 2005-11-10  Maciej Stachowiak  <mjs (a] apple.com>
   2524 
   2525         Build fix, not reviewed.
   2526 
   2527         * Plugins.subproj/WebBaseNetscapePluginViewInternal.h: Added.
   2528 
   2529 2005-11-10  Tim Omernick  <timo (a] apple.com>
   2530 
   2531         Reviewed by Geoff.
   2532 
   2533 	<rdar://problem/4237941> Dashboard needs a way to stop Netscape plug-ins from getting null events
   2534 
   2535         * Plugins.subproj/WebBaseNetscapePluginViewInternal.h: Added.
   2536 	Added WebInternal category, with -stopNullEvents and -restartNullEvents.  These methods already exist on WebBaseNetscapePluginView.
   2537 	I am just exposing them	to callers elsewhere within WebKit.
   2538 
   2539         * WebKit.xcodeproj/project.pbxproj:
   2540 	Added WebBaseNetscapePluginViewInternal.h.
   2541 
   2542         * WebView.subproj/WebFrame.m:
   2543         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
   2544 	Walks down the web frame hierarchy and calls -_pauseNullEventsForAllNetscapePlugins on each WebHTMLView.
   2545         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
   2546 	Same as above, but calls -_resumeNullEventsForAllNetscapePlugins.
   2547 	
   2548         * WebView.subproj/WebFramePrivate.h:
   2549 	Declared -_recursive_pauseNullEventsForAllNetscapePlugins and -_recursive_pauseNullEventsForAllNetscapePlugins.
   2550 	
   2551         * WebView.subproj/WebHTMLView.m:
   2552         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
   2553 	Checks subviews for WebBaseNetscapePluginViews, and calls -stopNullEvents on them.
   2554         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
   2555 	Same as above, but calls -restartNullEvents.
   2556 
   2557         * WebView.subproj/WebHTMLViewInternal.h:
   2558 	Declared -_pauseNullEventsForAllNetscapePlugins and -_resumeNullEventsForAllNetscapePlugins.
   2559 
   2560 2005-11-07  Geoffrey Garen  <ggaren (a] apple.com>
   2561 
   2562         Darin reviewed this a while back.
   2563 
   2564         - Fixed <rdar://problem/4161660> window.close followed by window.print
   2565         in onload handler crashes Safari in KJS::ScopeChain::bottom
   2566         (redmccombstoyota.com)
   2567         
   2568         Added a call to stopLoading inside closeWindowSoon to prevent load
   2569         events from firing after a window has torn down.
   2570         
   2571         Manual test case: WebCore/manual-tests/window-close-during-parsing.html
   2572 
   2573         * WebCoreSupport.subproj/WebBridge.m:
   2574         (-[WebBridge closeWindowSoon]):
   2575 
   2576 2005-11-03  Timothy Hatcher  <timothy (a] apple.com>
   2577 
   2578         Reviewed by Darin and Vicki.
   2579 
   2580         * WebKit.xcodeproj/project.pbxproj:
   2581           Change to use $(SYSTEM_LIBRARY_DIR) consistently and place
   2582           $(NEXT_ROOT) in a few spots to make build-root work.
   2583 
   2584 2005-11-01  Tim Omernick  <timo (a] apple.com>
   2585 
   2586         Reviewed by John Sullivan.
   2587 
   2588 	<rdar://problem/4318632>
   2589 
   2590 	I've added a new notification, WebPluginWillPresentNativeUserInterfaceNotification.  Plugins are expected to post this
   2591 	notification before presenting "native UI", such as dialog boxes.  A Dashboard client can observe this notification to
   2592 	hide the Dashboard layer when plugins present external UI.
   2593 	
   2594         * English.lproj/StringsNotToBeLocalized.txt:
   2595 	Added "WebPluginWillPresentNativeUserInterface".
   2596 
   2597         * Plugins.subproj/WebPluginsPrivate.h: Added.
   2598         * Plugins.subproj/WebPluginsPrivate.m: Added.
   2599 	Declare WebPluginWillPresentNativeUserInterfaceNotification.
   2600 
   2601         * WebKit.xcodeproj/project.pbxproj:
   2602 	Added WebPluginsPrivate.[hm]
   2603 
   2604 	* WebKit.exp:
   2605 	Added _WebPluginWillPresentNativeUserInterfaceNotification.
   2606 
   2607 2005-11-01  John Sullivan  <sullivan (a] apple.com>
   2608 
   2609         Reviewed by Darin Adler.
   2610         
   2611         fixed deployment build by hiding local variables used only in ASSERTs on builds for
   2612         which ASSERT_DISABLED is true.
   2613 
   2614         * History.subproj/WebHistory.m:
   2615         (-[WebHistoryPrivate removeItemForURLString:]):
   2616         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]):
   2617 
   2618 2005-11-01  John Sullivan  <sullivan (a] apple.com>
   2619 
   2620         Reviewed by Tim Omernick.
   2621         
   2622         - fixed <rdar://problem/4324104> Assertion failure (foundDate) in WebHistory
   2623         
   2624         WebFrame was updating the last visited date on a WebHistoryItem behind WebHistory's
   2625         back, causing WebHistory's caches of items by date to get out of sync with reality.
   2626         Changed to set the date through WebHistory rather than directly.
   2627 
   2628         * History.subproj/WebHistory.m:
   2629         (-[WebHistoryPrivate _removeItemFromDateCaches:]):
   2630         New method, extracted from removeItemForURLString.
   2631         (-[WebHistoryPrivate removeItemForURLString:]):
   2632         Now calls extracted method. Cleaned up white space a little.
   2633         (-[WebHistoryPrivate _addItemToDateCaches:]):
   2634         New method, extracted from addItem:
   2635         (-[WebHistoryPrivate addItem:]):
   2636         Now calls extracted method. Cleaned up white space a little.
   2637         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]):
   2638         New method, removes item from date caches, changes date, then adds item back to
   2639         date caches and sends notification.
   2640         (-[WebHistory setLastVisitedTimeInterval:forItem:]):
   2641         New method, cover for WebHistoryPrivate version.
   2642         
   2643         * History.subproj/WebHistoryItem.m:
   2644         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
   2645         Don't send notification here; send from new WebHistory method instead.
   2646         
   2647         * History.subproj/WebHistoryItemPrivate.h:
   2648         Added comment about avoiding incorrect use of _setLastVisitedTimeInterval:
   2649         * History.subproj/WebHistoryPrivate.h:
   2650         Added declarations for WebHistory and WebHistoryPrivate versions of 
   2651         setLastVisitedTimeInterval:forItem:
   2652         
   2653         * WebView.subproj/WebFrame.m:
   2654         (-[WebFrame _transitionToCommitted:]):
   2655         change history item's date via new WebHistory method rather than directly
   2656 
   2657 2005-10-25  Timothy Hatcher  <timothy (a] apple.com>
   2658 
   2659         Reviewed by Darin.
   2660 
   2661         Remove the use of a stamp file in the Frameworks symlink build phase.
   2662         This lets us pass the build verification.
   2663 
   2664         * WebKit.xcodeproj/project.pbxproj:
   2665 
   2666 2005-10-24  Darin Adler  <darin (a] apple.com>
   2667 
   2668         Reviewed by Geoff.
   2669 
   2670         - change internal methods in WebTextRenderer to be functions in case this
   2671           has any effect on speed (also makes things a bit clearer, in my opinion)
   2672 
   2673         * WebCoreSupport.subproj/WebTextRenderer.h: Made all fields public, which is
   2674         OK since this is really a private class. Made setAlwaysUseATSU: class method
   2675         public too for the same reason.
   2676 
   2677         * WebCoreSupport.subproj/WebTextRenderer.m: Change all methods to functions.
   2678         (destroy): Function name for method free.
   2679         (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]): Removed code to first subtract
   2680         lineSpacing - descent, then later add it back.
   2681         (getSmallCapsRenderer): Function name for method smallCapsRenderer.
   2682         (findSubstituteFont): Function name for method substituteFontForString:families:.
   2683         (findSubstituteRenderer): Function name for method substituteRendererForCharacters:length:families:.
   2684         (updateGlyphMapEntry): Function name for method updateGlyphEntryForCharacter:glyphID:substituteRenderer:.
   2685         (extendGlyphMap): Function name for method extendCharacterToGlyphMapToInclude:.
   2686         (extendWidthMap): Function name for method extendGlyphToWidthMapToInclude:.
   2687         (getTextBounds): Function name for method trapezoidForRun:style:atPoint:.
   2688 
   2689 2005-10-24  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   2690 
   2691         Reviewed by Darin.  Committed by David Harrison.
   2692 
   2693         http://bugs.webkit.org/show_bug.cgi?id=5415
   2694         "Left border of selection highlight leaves behind a trail"
   2695         
   2696         * manual-tests/drag_select_highlighting.html: Added.
   2697         (this test case was added to WebCore)
   2698    
   2699         * WebCoreSupport.subproj/WebTextRenderer.m:
   2700         (overrideLayoutOperation):
   2701         (-[WebTextRenderer CG_drawHighlightForRun:style:geometry:]):
   2702         (-[WebTextRenderer ATSU_drawHighlightForRun:style:geometry:]):
   2703         (advanceWidthIterator):
   2704 
   2705 
   2706 2005-10-23  Tim Omernick  <tomernick (a] apple.com>
   2707 
   2708         Reviewed by Dave Hyatt.
   2709 
   2710 	<http://bugs.webkit.org/show_bug.cgi?id=5365>
   2711 
   2712 	Send -webPlugInStop (or -pluginStop) and -webPluginDestroy (or -pluginDestroy)
   2713 	to complying plugins right when they're removed from the WebHTMLView, and also
   2714 	release them from the plugin controller's arrays.
   2715 	
   2716 	I think this patch makes WebKit behave more like plugins expect it to, which is
   2717 	the way it already behaves with Netscape plugins.
   2718 	
   2719 	I expect complying plugins to stop making noise when receiving the stop
   2720 	message, but QuickTime doesn't. If it's lucky, then it will be deallocated
   2721 	because of the release and will stop then. However, JS, for one, can retain the
   2722 	plugin (e.g. if you execute <javascript:document.getElementById('obj').width;>
   2723 	before clicking Remove OBJECT), in which case it will just keep playing.
   2724 	
   2725         * Plugins.subproj/WebPluginController.h:
   2726         * Plugins.subproj/WebPluginController.m:
   2727         (-[WebPluginController destroyPlugin:]):
   2728 	Stop and destroy the plugin.
   2729         * WebView.subproj/WebHTMLView.m:
   2730         (-[NSArray willRemoveSubview:]):
   2731 	Destroy plugins when they are removed from the HTML view.
   2732 	
   2733 2005-10-23  Geoffrey Garen  <ggaren (a] apple.com>
   2734 
   2735         Reviewed by Maciej.
   2736 
   2737         For better abstraction, made the tokenizer -- instead of the 
   2738         data source -- responsible for calling [WebFrame _checkLoadComplete]
   2739         when the tokenizer stops.
   2740 
   2741         * WebView.subproj/WebDataSource.m:
   2742         (-[WebDataSource _stopLoadingInternal]):
   2743 
   2744 2005-10-21  Geoffrey Garen  <ggaren (a] apple.com>
   2745 
   2746         Reviewed by darin.
   2747         
   2748         WebKit side of the fix for <rdar://problem/4184719> window.print() followed by 
   2749         window.close() causes world leak
   2750         
   2751         No test case added because I have another reviewed patch that will include a test
   2752         for this bug as well as many others.
   2753 
   2754         Under some conditions, [WebDataSource stopLoading] did not set [WebDataSource isLoading]
   2755         to false, so the didFInishLoad delegates never fired.
   2756         
   2757         The reason isLoading didn't become false was that the tokenizer was still running.
   2758         The fix here is to move the call to [WebCoreBridge stopLoading] above the early return
   2759         inside [WebDataSource stopLoading] -- since the tokenizer may still be running even if the
   2760         loader is finished loading -- and then to call [WebFrame _checkLoadComplete] to 
   2761         give the frame a chance to fire its delegates.
   2762         
   2763         * WebView.subproj/WebDataSource.m:
   2764         (-[WebDataSource _stopLoadingInternal]):
   2765 
   2766 2005-10-21  Beth Dakin  <bdakin (a] apple.com>
   2767 
   2768         Reviewed by Darin??
   2769 
   2770 	Fix for <rdar://problem/3853672> Malformed HTML using crashes Safari in NSFireTimer
   2771 
   2772 	The webFrame was being deleted prematurely by a call to stop(), so we changed it
   2773 	so that the calls to _receivedMainResourceError and _mainReceivedError happen 
   2774 	before the stop(), and we retain the bridge.
   2775 
   2776         * WebView.subproj/WebDataSource.m:
   2777         (-[WebDataSource _receivedMainResourceError:complete:]):
   2778 
   2779 2005-10-21  Geoffrey Garen  <ggaren (a] apple.com>
   2780 
   2781         Patch by TimO, Reviewed by hyatt, tested and landed by me.
   2782 
   2783         Found what appears to be a misguided optimization that actually causes a measurable performance problem.
   2784         A fixed-size buffer was allocated on the stack to pass into CFURLGetBytes(), presumably to avoid malloc()
   2785         for URLs less than 2048 bytes.  There was also a fallback which malloc()'ed a buffer in case the fixed-size
   2786         buffer was too small to hold the URL's bytes.  This malloc()'ed buffer was then wrapped in an NSData using
   2787         +dataWithBytesNoCopy:length:, avoiding a memory copy (yay!)
   2788 
   2789         The problem with this approach is two-fold:
   2790     
   2791         1. Regardless of how the buffer was allocated and filled, it is immediately wrapped in an NSData using
   2792         +dataWithBytes:length:, which copies the input bytes.  This is pretty much unavoidable; we need to get
   2793         the data into a malloc()'ed buffer to return it to the caller, unless the caller provides its own storage
   2794         (which would be super inconvenient).
   2795     
   2796         2. The size of the fixed buffer was large enough that it fit most (if not all) URLs involved in our Page
   2797         Load Test.  This means the unintentionally-inefficient case was by far the most *common* case!
   2798         
   2799         My fix is to malloc() the buffer from the start, and then use +[NSData dataWithBytes:length:freeWhenDone:]
   2800         to wrap the buffer in an NSData.  This avoids a memory copy for the normal case where a URL is less than
   2801         2048 bytes, and keeps the efficient behavior for the uncommon long URL case.
   2802 
   2803         * Misc.subproj/WebNSURLExtras.m:
   2804         (-[NSURL _web_originalData]):
   2805 
   2806 2005-10-21  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   2807 
   2808         Reviewed and landed by Darin.
   2809 
   2810         - fixed a couple regressions caused by my last check-in
   2811           http://bugs.webkit.org/show_bug.cgi?id=5437
   2812           http://bugs.webkit.org/show_bug.cgi?id=5443
   2813 
   2814         * WebCoreSupport.subproj/WebTextRenderer.m:
   2815         (-[WebTextRenderer CG_drawHighlightForRun:style:geometry:]): Compute background width
   2816         correctly, by subtracting position after run from position before run.
   2817         (addDirectionalOverride): Make the range include only the characters between the
   2818         directional override characters, not the directional override characters themselves.
   2819         (initializeWidthIterator): Correctly compute "widthToStart" based on the offset to
   2820         the beginning of the run, not to the end of the run!
   2821 
   2822 2005-10-19  Darin Adler  <darin (a] apple.com>
   2823 
   2824         Reviewed by Maciej.
   2825 
   2826         - optimizations for a total of about 1% speed-up on PLT
   2827 
   2828         * WebCoreSupport.subproj/WebTextRenderer.h: Updated to use bool instead of BOOL,
   2829         since BOOL is a signed char (which is not so efficient, at least on PPC).
   2830         * WebCoreSupport.subproj/WebTextRenderer.m:
   2831         (isSpace): Changed BOOL to bool and UniChar to UChar32. This actually fixes a
   2832         potential bug when the passed-in character is a non-BMP character (> FFFF).
   2833         (isRoundingHackCharacter): Ditto.
   2834         (widthForGlyph): Merged getUncachedWidth, widthFromMap, and widthForGlyph into
   2835         one function. Marked it inline. Changed to include syntheticBoldOffset in the
   2836         cached widths to save an add in the cached case. Instead of the special constant
   2837         UNINITIALIZED_GLYPH_WIDTH, just check for a width >= 0. This allows us to use
   2838         a negative number or NAN for the uninitialized width value -- I chose NAN.
   2839         (overrideLayoutOperation): Use bool instead of Boolean in one place.
   2840         (-[WebTextRenderer initWithFont:]): Use lroundf instead of ROUND_TO_INT.
   2841         (-[WebTextRenderer floatWidthForRun:style:]): Put the code to choose the ATSU
   2842         vs. CG code path back in here, because there are no callers inside the class
   2843         that need to call both.
   2844         (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
   2845         Use bool instead of BOOL.
   2846         (+[WebTextRenderer setAlwaysUseATSU:]): Ditto.
   2847         (fontContainsString): Ditto.
   2848         (-[WebTextRenderer computeWidthForSpace]): Ditto. Also use roundf instead of
   2849         using ROUND_TO_INT.
   2850         (-[WebTextRenderer setUpFont]): Use bool instead of BOOL.
   2851         (drawGlyphs): Ditto.
   2852         (-[WebTextRenderer CG_drawHighlightForRun:style:geometry:]): Restructure the
   2853         code so it can use the new advanceWidthIterator function instead of the old
   2854         widthForNextCharacter function.
   2855         (-[WebTextRenderer CG_drawRun:style:geometry:]): Use malloc instead of calloc
   2856         since we don't need initialization. Call CG_floatWidthForRun instead of
   2857         floatWidthForRun -- no need to re-check whether to use the CG or ATSU code path.
   2858         Removed code to handle a renderer of 0 since we no longer generate that in
   2859         the renderers array in advanceWidthIterator.
   2860         (CG_floatWidthForRun): Changed to call the new advanceWidthIterator instead of
   2861         the old widthForNextCharacter.
   2862         (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]): Use malloc instead of
   2863         calloc and explicitly initialize the one field that needs it. Fixed a potential
   2864         storage leak by adding a call to WKClearGlyphVector. Initialize the renderers
   2865         to self instead of to 0.
   2866         (-[WebTextRenderer extendGlyphToWidthMapToInclude:]): Initialize the widths to
   2867         NAN instead of UNINITIALIZED_GLYPH_WIDTH.
   2868         (addDirectionalOverride): Fixed bug where the first and last character in the buffer
   2869         could be uninitialized and where characters before and after the direction override
   2870         could be incorrect.
   2871         (-[WebTextRenderer ATSU_drawRun:style:geometry:]): Use bool instead of BOOL.
   2872         (-[WebTextRenderer ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   2873         Ditto.
   2874         (advanceWidthIteratorOneCharacter): Added new helper function for CG_pointToOffset.
   2875         (-[WebTextRenderer CG_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   2876         Reimplemented to use advanceWidthIteratorOneCharacter instead of widthForNextCharacter.
   2877         Also call CG_floatWidthForRun instead of floatWidthForRun since we don't need to
   2878         reconsider whether to use CG or ATSU.
   2879         (glyphForCharacter): Removed the map parameter and changed the renderer parameter to
   2880         be an in-out one. Removed uneeded special case for when map is 0 and always get the
   2881         renderer from the map. Also call extendCharacterToGlyphMapToInclude in here instead of
   2882         making that the caller's responsibility.
   2883         (initializeWidthIterator): Renamed to make the name shorter (removed "Character").
   2884         Streamlned common cases like "no padding" and removed some unneeded casts. Changed to
   2885         use advanceWidthIterator to compute width fo the first part of the run.
   2886         (normalizeVoicingMarks): Factored this out into a separate function, since it's not part
   2887         of the common case.
   2888         (advanceWidthIterator): Changed widthForNextCharacter to this, eliminating per-character
   2889         function overhead for iterating past a few characters. Merged the handling of surrogate
   2890         pairs and of voicing marks so that we typically only have to do one "if" to rule out both.
   2891         Merged the mirroring for RTL and uppercasing for small caps into a single boolean so that
   2892         we only need one "if" to rule out both. Call the new glyphForCharacter. Check for the
   2893         character '\t' first since that's cheaper than looking at tabWidth. Check tabWidth for 0
   2894         first so that we don't have to convert it to floating point when not using it. Changed
   2895         the special case for spaces to first check width, so that we don't bother with the rest
   2896         of the code for glyphs not the same width as spaces. Fixed substitution code to call
   2897         CG_floatWidthForRun -- no need to reconsider whether to use CG or ATSU. Also changed to
   2898         properly get width from the result of that function. Merged the handling of letter spacing,
   2899         padding, and word spacing into a single boolean so that we typically only have to do one
   2900         "if" to rule out all three. Check for letterSpacing of 0 first so that we don't have to
   2901         convert it to floating point when not using it. Same for padding and wordSpacing.
   2902         Move the work from ceilCurrentWidth in line into this function. Assume that either we have
   2903         all three pointers (widths, renderers, glyphs), or none of the three, to cut down on branches.
   2904         (fillStyleWithAttributes): Use bool instead of BOOL.
   2905         (shouldUseATSU): Ditto.
   2906 
   2907         * Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]): Update since
   2908         the floatWidthForRun method no longer takes a widths parameter.
   2909         * Misc.subproj/WebStringTruncator.m: (stringWidth): Ditto.
   2910 
   2911 2005-10-19  Tim Omernick  <tomernick (a] apple.com>
   2912 
   2913         Reviewed by eseidel & darin.
   2914 
   2915 	Changed some of the run measurement methods to C functions
   2916         to avoid overhead associated with objc_msgSend().
   2917 		
   2918         * WebCoreSupport.subproj/WebTextRenderer.m:
   2919         (-[WebTextRenderer floatWidthForRun:style:widths:]):
   2920 	Updated to call new run measurement functions instead
   2921         of calling ObjC methods.
   2922         (-[WebTextRenderer CG_drawRun:style:geometry:]): ditto
   2923         (floatWidthForRun): ditto
   2924         (CG_floatWidthForRun): ditto
   2925         (ATSU_floatWidthForRun): ditto
   2926         (widthForNextCharacter): ditto
   2927 
   2928 2005-10-14  Vicki Murley  <vicki (a] apple.com>
   2929 
   2930 	Changes by Mitz Pettel, reviewed by Maciej.
   2931 
   2932 	Fix http://bugs.webkit.org/show_bug.cgi?id=5029 (Assertion failure in -[NSPasteboard(WebExtras) 
   2933 	_web_writeImage:URL:title:archive:types:] when trying to drag an image from a site with no favicon)
   2934 
   2935         * Misc.subproj/WebNSPasteboardExtras.m:
   2936         (-[NSPasteboard _web_writeImage:URL:title:archive:types:]): Prefer the main resource if it is an image
   2937 
   2938 2005-10-12  Vicki Murley  <vicki (a] apple.com>
   2939 
   2940         Reviewed by Darin.
   2941 
   2942 	- fix <rdar://problem/4043643> iframe swallows events for overlapping elements (3449)
   2943 
   2944         * WebView.subproj/WebHTMLView.m:
   2945         (-[WebHTMLView hitTest:]): 
   2946         (-[WebHTMLView _updateMouseoverWithEvent:]): eliminate _hitViewForEvent hackery and self
   2947 	dependency from this function
   2948 
   2949 2005-10-12  Timothy Hatcher  <timothy (a] apple.com>
   2950 
   2951         Reviewed by Darin.
   2952         
   2953         Define WebNSInt and WebNSUInt to wrap around NSInt on Leopard and still build on Tiger
   2954         Once building on Tiger isn't needed we will drop WebNSInt and use NSInt
   2955 
   2956         * WebView.subproj/WebDefaultResourceLoadDelegate.m:
   2957         (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]):
   2958         * WebView.subproj/WebFrame.m:
   2959         (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
   2960         * WebView.subproj/WebLoader.m:
   2961         (-[NSURLProtocol didReceiveData:lengthReceived:]):
   2962         * WebView.subproj/WebResourceLoadDelegate.h:
   2963         * WebView.subproj/WebUIDelegate.h:
   2964         * WebView.subproj/WebView.h:
   2965         * WebView.subproj/WebView.m:
   2966         (-[WebView _mouseDidMoveOverElement:modifierFlags:]):
   2967         (-[WebView spellCheckerDocumentTag]):
   2968         * WebView.subproj/WebViewInternal.h:
   2969         * WebView.subproj/WebViewPrivate.h:
   2970 
   2971 2005-10-12  Darin Adler  <darin (a] apple.com>
   2972 
   2973         * WebView.subproj/WebPolicyDelegate.h: Fix a comment.
   2974 
   2975 2005-10-11  Timothy Hatcher  <timothy (a] apple.com>
   2976 
   2977         Reviewed by Darin.
   2978         
   2979         Test for 10.4 because of <rdar://problem/4243463>
   2980 
   2981         * WebView.subproj/WebHTMLView.m:
   2982         (-[WebHTMLView conversationIdentifier]):
   2983 
   2984 2005-10-11  Adele Peterson  <adele (a] apple.com>
   2985 
   2986         Rolling out fix for http://bugs.webkit.org/show_bug.cgi?id=5195
   2987         since it caused:
   2988 
   2989         REGRESSION text areas draw focus ring around each glyph, no caret in text fields
   2990         http://bugs.webkit.org/show_bug.cgi?id=5335
   2991 
   2992         * WebView.subproj/WebHTMLView.m:
   2993         (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]):
   2994         (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
   2995         (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
   2996 
   2997 2005-10-09  Darin Adler  <darin (a] apple.com>
   2998 
   2999         Reviewed by Maciej.
   3000 
   3001         - fixed http://bugs.webkit.org/show_bug.cgi?id=5195
   3002           Would like API to flush rendering of pending DOM changes
   3003 
   3004         This was actually a Tiger regression. When AppKit added a new code path for rendering
   3005         NSView, our special hack for doing layout when we draw didn't work any more. So we
   3006         were able to fix this without adding any API.
   3007 
   3008         * WebView.subproj/WebHTMLView.m:
   3009         (-[WebHTMLView _recursiveDisplayRectIgnoringOpacity:inContext:topView:]): Added.
   3010         Does the same thing that other _recursiveDisplay methods do.
   3011 
   3012 2005-10-08  Alexey Proskuryakov  <ap (a] nypop.com>
   3013 
   3014         Reviewed by Maciej.
   3015 
   3016         - fixed http://bugs.webkit.org/show_bug.cgi?id=5187
   3017           UTF-8 in long text files breaks at some point
   3018 
   3019         * WebView.subproj/WebTextRepresentation.m:
   3020         (-[WebTextRepresentation finishedLoadingWithDataSource:]):
   3021         Call flushReceivedData on the WebTextView so it can decode any final bytes.
   3022 
   3023         * WebView.subproj/WebTextView.h: Added WebCoreTextDecoder field and flushReceivedData method.
   3024         * WebView.subproj/WebTextView.m:
   3025         (-[WebTextView dealloc]): Release WebCoreTextDecoder.
   3026         (-[WebTextView appendReceivedData:fromDataSource:]): Create a WebCoreTextDecoder to decode
   3027         the text; use the textEncodingName from the data source. Use it to decode instead of the
   3028         data source's stringWithData.
   3029         (-[WebTextView flushReceivedData]): Call flush on the decoder and append any last bytes to
   3030         the text view.
   3031 
   3032 2005-10-07  John Sullivan  <sullivan (a] apple.com>
   3033 
   3034         Reviewed by Tim Omernick.
   3035         
   3036         WebKit support for allowing clients to know which frame originated a particular JavaScript alert/dialog.
   3037 
   3038         * WebView.subproj/WebUIDelegatePrivate.h:
   3039         New optional delegate methods for the three JavaScript alert/dialogs. These are just like the existing
   3040         ones in WebUIDelegate.h except that each adds a parameter specifying the frame that the JavaScript was
   3041         running in. Eventually we'll deprecate the old three methods in favor of these in the public API.
   3042         
   3043         * WebCoreSupport.subproj/WebBridge.m:
   3044         (-[WebBridge runJavaScriptAlertPanelWithMessage:]):
   3045         Call version of the delegate method that has the frame parameter if the delegate supports it.
   3046         (-[WebBridge runJavaScriptConfirmPanelWithMessage:]):
   3047         ditto
   3048         (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]):
   3049         ditto
   3050         
   3051         * WebView.subproj/WebDefaultUIDelegate.m:
   3052         (-[WebDefaultUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
   3053         Now implements the new version of the delegate method that includes the frame parameter. (Still
   3054         doesn't do anything though.)
   3055         (-[WebDefaultUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
   3056         Now implements the new version of the delegate method that includes the frame parameter. (Still
   3057         doesn't do anything though.)
   3058         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
   3059         Now implements the new version of the delegate method that includes the frame parameter. Doesn't
   3060         actually use the frame parameter here yet though.
   3061         
   3062 2005-10-06  Darin Adler  <darin (a] apple.com>
   3063 
   3064         - fixed compiling on Deployment
   3065 
   3066         * WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:]):
   3067         Put initialFont inside !LOG_DISABLED.
   3068 
   3069 2005-10-06  Darin Adler  <darin (a] apple.com>
   3070 
   3071         Reviewed by Eric.
   3072 
   3073         - tweaked formatting
   3074 
   3075         * WebCoreSupport.subproj/WebTextRenderer.m: Changed function names to remove underscores;
   3076         fixed formatting to match our coding guidelines, other related tweaks.
   3077 
   3078 2005-10-06  Darin Adler  <darin (a] apple.com>
   3079 
   3080         Reviewed by Eric.
   3081 
   3082         - fixed regression in drawing of text in non-flipped contexts from my last check-in
   3083 
   3084         * WebCoreSupport.subproj/WebTextRenderer.m:
   3085         (drawGlyphs): Only flip the matrix if the NSGraphicsContext is flipped.
   3086         (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): Use -[NSGraphicsContext isFlipped]
   3087         instead of [[NSView focusView] isFlipped].
   3088 
   3089 2005-10-06  Darin Adler  <darin (a] apple.com>
   3090 
   3091         Reviewed by Hyatt.
   3092 
   3093         - fixed <rdar://problem/3217793> Monaco bold comes out as Helvetica bold, very bad if you choose Monaco as your fixed-width font
   3094         - fixed <rdar://problem/3256269> CSS1: bold/italic font styles not programmatically created if font doesn't include them (3231)
   3095           also <http://bugs.webkit.org/show_bug.cgi?id=3231>
   3096 
   3097         * WebCoreSupport.subproj/WebTextRenderer.h: Removed public declarations of private structures that are not
   3098         used in the header. Removed the separate 16-bit character map; the difference in code size is only a few
   3099         bytes per page and there's no measurable performance difference by always using the 32-bit character version.
   3100         Removed substitute font width maps altogether, since we now use the width map in the substitute font's renderer.
   3101         Also removed a few more now-unused fields and methods. Changed initWithFont to take WebCoreFont. Changed
   3102         the setAlwaysUseATSU: method to remove the underscore prefix.
   3103 
   3104         * WebCoreSupport.subproj/WebTextRenderer.m:
   3105         (getUncachedWidth): Get font from WebCoreFont directly instead of taking a parameter, since we now use only
   3106         one NSFont per WebTextRenderer.
   3107         (widthFromMap): Removed NSFont parameter for same reason as above; simplified.
   3108         (widthForGlyph): Ditto.
   3109         (overrideLayoutOperation): Updated for change to WebCoreFont.
   3110         (-[WebTextRenderer initWithFont:]): Changed to use WebCoreFont. Removed code to deal with substitute font maps.
   3111         Changed lineGap computation to use floats instead of doubles. Added code to compute a synthetic bold offset.
   3112         Currently this is the font size divided by 24 and then rounded up to an integer.
   3113         (-[WebTextRenderer dealloc]): Updated for change to WebCoreFont and other related changes.
   3114         (-[WebTextRenderer finalize]): Ditto.
   3115         (-[WebTextRenderer xHeight]): Ditto.
   3116         (-[WebTextRenderer drawRun:style:geometry:]): Remove small caps case here; no longer needed. Also updated as above.
   3117         (-[WebTextRenderer floatWidthForRun:style:widths:]): Ditto.
   3118         (-[WebTextRenderer drawHighlightForRun:style:geometry:]): Ditto.
   3119         (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]): Ditto.
   3120         (+[WebTextRenderer setAlwaysUseATSU:]): Renamed to remove underscore prefix.
   3121         (-[WebTextRenderer smallCapsRenderer]): Ditto. Changed to create a renderer for the smaller sized font.
   3122         (-[WebTextRenderer _substituteFontForString:families:]): Reorganized this to be more readable and to call
   3123         the new rendererForAlternateFont method.
   3124         (-[WebTextRenderer rendererForAlternateFont:]): Added. Used to select an alternate font taking into account
   3125         bold and italic synthesis.
   3126         (-[WebTextRenderer substituteRendererForCharacters:length:families:]): Renamed to remove underscore prefix.
   3127         Updated to use rendererForAlternateFont.
   3128         (-[WebTextRenderer _computeWidthForSpace]): Updated for name changes and to remove unnecessary parameters.
   3129         (-[WebTextRenderer setUpFont]): Renamed to remove underscore prefix. Added code to get printer or screen
   3130         font as specified by WebCoreFont so calers don't need to do this.
   3131         (drawGlyphs): Renamed to remove underscore prefix. Added code for synthetic oblique (14 degree slant), and
   3132         synthetic bold (add offset and draw text a second time).
   3133         (-[WebTextRenderer _CG_drawRun:style:geometry:]): Keep an array of substitute renderers instead of fonts.
   3134         Changed around the loop to reverse the run to be a single loop instead of 3.
   3135         (-[WebTextRenderer floatWidthForRun:style:widths:substituteRenderers:glyphs:startPosition:numGlyphs:]):
   3136         Renamed to remove the underscore prefix.
   3137         (-[WebTextRenderer _CG_floatWidthForRun:style:widths:substituteRenderers:glyphs:startPosition:numGlyphs:]):
   3138         Changed to use subsitute renderers rather than fonts.
   3139         (-[WebTextRenderer updateGlyphEntryForCharacter:glyphID:substituteRenderer:]): Renamed to remove underscore
   3140         prefix and changed to use a substitute renderer rather than a substitute NSFont.
   3141         (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]): Updated to work with all characters, both ones
   3142         that fit into 16-bit and ones that don't.
   3143         (-[WebTextRenderer _extendGlyphToWidthMapToInclude:]): Removed NSFont parameter and simplified. This fixes
   3144         a bug where numberOfGlyphs was accidentally used from the main font instead of "subFont".
   3145         (glyphForCharacter): Changed to use subsitute renderers instead of substitute fonts.
   3146         (widthForNextCharacter): Ditto. Also removed small caps code no longer needed here and replaced it with
   3147         simpler small caps code that no longer assumes glyphs match.
   3148         (shouldUseATSU): Changed the code to check ranges in order to slightly reduce the number of cases and
   3149         to create earlier exit for lower character codes.
   3150 
   3151         * WebCoreSupport.subproj/WebTextRendererFactory.h: Added caches for synthesized font and oblique
   3152         variants so we can still use the NSFont as the dictionary key. Removed coalesceTextDrawing methods.
   3153         Changed methods to use WebCoreFont as the parameters and results instead of NSFont.
   3154         * WebCoreSupport.subproj/WebTextRendererFactory.m:
   3155         (-[WebTextRendererFactory clearCaches]): Clear all 8 caches.
   3156         (-[WebTextRendererFactory isFontFixedPitch:]): Changed code slightly so there's only one call to
   3157         the CFDictionarySetValue function.
   3158         (-[WebTextRendererFactory init]): Create all 8 caches.
   3159         (-[WebTextRendererFactory dealloc]): Release all 8 caches.
   3160         (-[WebTextRendererFactory rendererWithFont:]): Select the appropriate cache based on 3 booleans:
   3161         synthetic bold, synthetic oblique, and printer. Use WebCoreFont instead of NSFont.
   3162         (-[WebTextRendererFactory fontWithFamilies:traits:size:]): Set the synthetic bold and oblique flags
   3163         when returning a WebCoreFont based on requested traits that are not present in the NSFont.
   3164         (acceptableChoice): Ignore the synthesizable traits when deciding if a chosen font is acceptable.
   3165         (betterChoice): Rather than assuming that every font has all the desired traits, implement a rule
   3166         that says a font with an unwanted trait loses out over a font that does not have an unwanted trait.
   3167         This lets us chose a bold font over a non-bold font that could use synthesized bold but treat both
   3168         as candidates.
   3169 
   3170         * WebCoreSupport.subproj/WebGlyphBuffer.h: Removed.
   3171         * WebCoreSupport.subproj/WebGlyphBuffer.m: Removed.
   3172         * WebKit.xcodeproj/project.pbxproj: Removed WebGlyphBuffer source files.
   3173 
   3174         * Misc.subproj/WebKitNSStringExtras.m:
   3175         (-[NSString _web_drawAtPoint:font:textColor:]): Update to use WebCoreFont.
   3176         (-[NSString _web_widthWithFont:]): Ditto.
   3177         * Misc.subproj/WebStringTruncator.m:
   3178         (truncateString): Ditto.
   3179         (+[WebStringTruncator widthOfString:font:]): Ditto.
   3180 
   3181         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Removed text drawing coalesce method calls.
   3182         * WebView.subproj/WebTextView.m: (-[WebTextView setFixedWidthFont]): Updated to use cachedFontFromFamily
   3183         method, which we still have, rather than fontWithFamilies method which we don't (since it now uses WebCoreFont).
   3184         * WebView.subproj/WebView.m: (+[WebView _setAlwaysUseATSU:]): Updated for name change to underlying method.
   3185 
   3186 2005-10-05  Maciej Stachowiak  <mjs (a] apple.com>
   3187 
   3188         Reviewed by Eric.
   3189 
   3190 	<rdar://problem/4158439> Safari appears to hang when sending synchronous XMLHttpRequest that gets no server response
   3191 
   3192 	No testcase - not testable w/o network.
   3193 	
   3194         * WebCoreSupport.subproj/WebBridge.m:
   3195         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Set a timeout of 10.
   3196 
   3197 2005-10-04  Beth Dakin  <bdakin (a] apple.com>
   3198 
   3199         Reviewed by Darin
   3200 
   3201 	Fix for <rdar://problem/4285538> TOT fix for Denver Regression: Drawing glitch in the transparent dialog's cancel/ok 
   3202 	button in the widget manager. 
   3203 
   3204         * WebCoreSupport.subproj/WebImageData.m: Calls WKSetPatternPhaseInUserSpace() which is a new function that lies in 
   3205 						WebKitSystemInterface that and takes care of pattern-setting. Prevents 
   3206 						regression that occurred with image tiling in transparency layers. 
   3207         (-[WebImageData tileInRect:fromPoint:context:]):
   3208 
   3209 2005-10-03  Tim Omernick  <tomernick (a] apple.com>
   3210 
   3211         Reviewed by John Sullivan.
   3212 
   3213 	<rdar://problem/4281095> Denver regression: Seed: Safari HTML 4.01 <object ...> tag problem
   3214 
   3215         * WebCoreSupport.subproj/WebBridge.m:
   3216         (-[WebBridge determineObjectFromMIMEType:URL:]):
   3217 	If no view class is registered to handle the MIME type, check to see if there is a plugin registered which can handle it.
   3218 	This check is required because the Java plugin does not register an NSView class, so that Java files are downloaded when
   3219 	not embedded.
   3220 
   3221 	Prior to this fix, -determineObjectFromMIMEType:URL: would always return ObjectElementNone for Java applets (MIME type
   3222 	"application/x-java-applet"), which would cause Java applets embedded in <OBJECT> elements to not be loaded.
   3223 
   3224 	This broke on 05-03-2005, when we changed how we handle fallback content for <OBJECT> elements so that we could pass the
   3225 	Acid2 test.
   3226 
   3227 2005-09-28  Justin Garcia  <justin.garcia (a] apple.com>
   3228 
   3229         Reviewed by geoff
   3230         
   3231         Fixed <rdar://problem/4276596> multipart/x-mixed-replace: saved inline images appear only partially loaded
   3232         Fixed <rdar://problem/4265439> progress bar should look complete even if there is some more multipart content being loaded
   3233 
   3234         * WebCoreSupport.subproj/WebSubresourceLoader.h:
   3235         * WebCoreSupport.subproj/WebSubresourceLoader.m:
   3236         (-[WebSubresourceLoader didReceiveResponse:]):
   3237         Now calls signalFinish and saveResource.
   3238         
   3239         (-[WebSubresourceLoader signalFinish]): 
   3240         Added.  Does the part of didFinishLoading that signals to the WebDataSource and load delegates that the load is finished.
   3241         
   3242         (-[WebSubresourceLoader didFinishLoading]):
   3243         * WebView.subproj/WebLoader.h:
   3244         * WebView.subproj/WebLoader.m:
   3245         (-[NSURLProtocol signalFinish]):
   3246         Similar to above
   3247         
   3248         (-[NSURLProtocol didFinishLoading]):
   3249 
   3250 2005-09-28  Adele Peterson  <adele (a] apple.com>
   3251 
   3252         Reviewed by John.
   3253 
   3254         Moved _downloadWithLoadingConnection and _downloadWithRequestfrom WebDownload.h to WebDownloadInternal.h
   3255 
   3256         * Misc.subproj/WebDownload.h:
   3257         * Misc.subproj/WebDownloadInternal.h: Added.
   3258         * WebKit.xcodeproj/project.pbxproj: Added WebDownloadInternal.h
   3259         * WebView.subproj/WebMainResourceLoader.m: Added import of WebDownloadInternal.h
   3260         * WebView.subproj/WebView.m: ditto.
   3261 
   3262 2005-09-27  Adele Peterson  <adele (a] apple.com>
   3263 
   3264         Reviewed by Maciej.
   3265 
   3266         Changed ints to size_t where appropriate.
   3267 
   3268         * Misc.subproj/WebCoreStatistics.h:
   3269         * Misc.subproj/WebCoreStatistics.m:
   3270         (+[WebCoreStatistics javaScriptObjectsCount]):
   3271         (+[WebCoreStatistics javaScriptInterpretersCount]):
   3272         (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]):
   3273         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
   3274         * WebView.subproj/WebPreferences.m:
   3275         (-[WebPreferences _pageCacheSize]):
   3276         (-[WebPreferences _objectCacheSize]):
   3277         * WebView.subproj/WebPreferencesPrivate.h:
   3278 
   3279 2005-09-26  John Sullivan  <sullivan (a] apple.com>
   3280 
   3281         Reviewed by Tim Omernick.
   3282 
   3283         - fixed <rdar://problem/4118126> Drag-and-drop text with text containing a colon causes a crash
   3284         
   3285         There were two problems here. One is that dragging and dropping text within the same WebTextView
   3286         should have done nothing rather than try to navigate. The other is that navigating while processing
   3287         the end of the drag would dealloc the drag-initiating WebTextView, leading to a crash. Fixing the
   3288         former doesn't fix all cases of the latter, since dropping onto (e.g.) Safari's location field
   3289         could cause a navigation during the drag. So these two issues needed to be fixed separately.
   3290 
   3291         * WebView.subproj/WebTextView.m:
   3292         (-[WebTextView dragSelectionWithEvent:offset:slideBack:]):
   3293         Before drag, retain self, and tell WebView that the drag is self-initiated. After drag, do the
   3294         opposite. This is the same approach as WebImageView, but it can all be contained in one method
   3295         here due to NSTextView's dragging API, which wraps up some of the drag-machinery guts.
   3296 
   3297 2005-09-24  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   3298 
   3299         Reviewed and landed by Darin.
   3300 
   3301         - fixed http://bugs.webkit.org/show_bug.cgi?id=5100
   3302           -[WebTextRenderer _ATSU_drawRun:...] does not check view flippedness
   3303 
   3304         * WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_drawRun:style:geometry:]):
   3305         Set up a the CGContext with a matrix that flips the text if the view is not flipped.
   3306 
   3307 2005-09-24  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   3308 
   3309         Reviewed, tweaked a tiny bit, and landed by Darin.
   3310 
   3311         - fixed http://bugs.webkit.org/show_bug.cgi?id=4940
   3312           CG and ATSUI give different width to the same text
   3313 
   3314         * WebCoreSupport.subproj/WebTextRenderer.m:
   3315         (overrideLayoutOperation): Added. ATSU callback to do the rounding.
   3316         (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): Use the new createATSULayoutParameters
   3317         function instead of calling _createATSUTextLayoutForRun.
   3318         (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]): Use createATSULayoutParameters,
   3319         and also compute the width in a way that works for any direction combination.
   3320         (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): Use createATSULayoutParameters.
   3321         (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   3322         Use createATSULayoutParameters. Also put in code that seems to work around an ATSU bug.
   3323         (createATSULayoutParameters): Added.
   3324         (disposeATSULayoutParameters): Added.
   3325 
   3326 2005-09-24  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   3327 
   3328         Reviewed by Dave.
   3329         Landed by Darin.
   3330 
   3331         - fixed http://bugs.webkit.org/show_bug.cgi?id=4862
   3332           Incorrect layout of bidi overrides
   3333 
   3334         * WebCoreSupport.subproj/WebTextRenderer.m:
   3335         (addDirectionalOverride): Renamed, and made it work in both directions.
   3336         (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]): Updated to call addDirectionalOverride.
   3337         (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): More of the same.
   3338         (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]): Ditto.
   3339 
   3340 2005-09-24  Alexey Proskuryakov  <ap (a] nypop.com>
   3341 
   3342         Tweaked, reviewed, and landed by Darin.
   3343 
   3344         - fixed http://bugs.webkit.org/show_bug.cgi?id=4394
   3345           Mouse clicks ignored in inline input areas
   3346 
   3347         * WebView.subproj/WebHTMLView.m:
   3348         (-[NSArray mouseDown:]): Removed misleading comment and added code to send mouse event to input manager.
   3349         (-[NSArray mouseDragged:]): Added code to send mouse event to input manager.
   3350         (-[NSArray mouseUp:]): Ditto.
   3351         (-[WebHTMLView _discardMarkedText]): Umnmark text before calling markedTextAbandoned: to match behavior
   3352         of NSTextView (not sure why we did things in the opposite order before).
   3353         (-[WebHTMLView _updateSelectionForInputManager]): Ditto.
   3354 
   3355         - unrelated tweak
   3356 
   3357         * WebView.subproj/WebView.m:
   3358         (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
   3359         Fix typecast that used ... for no good reason.
   3360 
   3361 2005-09-23  Duncan Wilcox  <duncan (a] mclink.it>
   3362 
   3363         Reviewed and landed by Darin.
   3364 
   3365         - name changes to prepare for fixing bugzilla bug 4582
   3366 
   3367         * WebView.subproj/WebHTMLView.m: Changed names to match WebCore changes.
   3368 
   3369 2005-09-20  John Sullivan  <sullivan (a] apple.com>
   3370 
   3371         Reviewed by Tim Omernick.
   3372 
   3373         - fixed <rdar://problem/3228554> We should enforce one selection per WebView instead of per window
   3374         
   3375         Note that this checkin does not mean that we will always maintain a selection in a WebView when
   3376         the focus is elsewhere. Instead it means that there should never be more than one frame containing
   3377         a selection in a WebView, and that it's possible to maintain a selection in a WebView when the focus 
   3378         is elsewhere.
   3379 
   3380         * WebView.subproj/WebView.m:
   3381         (-[WebView searchFor:direction:caseSensitive:wrap:]):
   3382         removed unnecessary and somewhat confusing comment
   3383         (-[WebView selectedFrame]):
   3384         now calls the extracted method -_focusedFrame
   3385         (-[WebView _focusedFrame]):
   3386         new method, extracted from -selectedFrame; returns frame containing first responder, if any
   3387         (-[WebView _findSelectedFrameStartingFromFrame:skippingFrame:]):
   3388         added skippingFrame parameter, which is never returned
   3389         (-[WebView _findSelectedFrameSkippingFrame:]):
   3390         new method, starts from main frame and passes a frame to skip
   3391         (-[WebView _findSelectedFrame]):
   3392         now calls _findSelectedFrameSkippingFrame:nil
   3393         (-[WebView _selectedFrameDidChange]):
   3394         new method, called by WebDocumentText protocol implementors; calls -deselectAll on frame that
   3395         formerly displayed a selection, if any
   3396 
   3397         * WebView.subproj/WebViewInternal.h:
   3398         added category WebDocumentSelectionExtras, with the one method _selectedFrameDidChange
   3399 
   3400         * WebView.subproj/WebHTMLView.m:
   3401         (-[WebHTMLView becomeFirstResponder]):
   3402         call -[WebView _selectedFrameDidChange]
   3403 
   3404         * WebView.subproj/WebPDFView.m:
   3405         (-[WebPDFView becomeFirstResponder]):
   3406         call -[WebView _selectedFrameDidChange]
   3407         (-[WebPDFView resignFirstResponder]):
   3408         deselect all unless webview says not to; note that this doesn't work in all cases due to:
   3409         <rdar://problem/4265966> PDFs continue to show a (secondary) selection when the focus moves elsewhere        
   3410 
   3411         * WebView.subproj/WebTextView.m:
   3412         (-[WebTextView becomeFirstResponder]):
   3413         call -[WebView _selectedFrameDidChange]
   3414         (-[WebTextView resignFirstResponder]):
   3415         deselect all unless webview says not to
   3416 
   3417 2005-09-20  Eric Seidel  <eseidel (a] apple.com>
   3418 
   3419         Reviewed by mjs.
   3420 
   3421 	Moved MIME type support from a hard coded list
   3422         (in two places) to single lists in the corresponding
   3423         *Representation classes.  Also moved the list of types
   3424         supported by WebCore (WebHTMLRepresentation) into WebCore.
   3425         http://bugs.webkit.org/show_bug.cgi?id=5037
   3426 
   3427         * WebView.subproj/WebDataSource.m:
   3428         (addTypesFromClass): new inline function
   3429         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
   3430         * WebView.subproj/WebFrameView.m:
   3431         (addTypesFromClass): new inline function
   3432         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
   3433         * WebView.subproj/WebHTMLRepresentation.h:
   3434         * WebView.subproj/WebHTMLRepresentation.m:
   3435         (+[WebHTMLRepresentation supportedMIMETypes]):
   3436         * WebView.subproj/WebHTMLView.m:
   3437         (+[WebHTMLView supportedMIMETypes]):
   3438         * WebView.subproj/WebHTMLViewPrivate.h:
   3439         * WebView.subproj/WebImageRepresentation.h:
   3440         * WebView.subproj/WebImageRepresentation.m:
   3441         (+[WebImageRepresentation supportedMIMETypes]):
   3442         * WebView.subproj/WebImageView.h:
   3443         * WebView.subproj/WebImageView.m:
   3444         (+[WebImageView supportedMIMETypes]):
   3445         * WebView.subproj/WebPDFRepresentation.h:
   3446         * WebView.subproj/WebPDFRepresentation.m:
   3447         (+[WebPDFRepresentation supportedMIMETypes]):
   3448         * WebView.subproj/WebPDFView.h:
   3449         * WebView.subproj/WebPDFView.m:
   3450         (+[WebPDFView supportedMIMETypes]):
   3451         * WebView.subproj/WebTextRepresentation.h:
   3452         * WebView.subproj/WebTextRepresentation.m:
   3453         (+[WebTextRepresentation supportedMIMETypes]):
   3454         * WebView.subproj/WebTextView.h:
   3455         * WebView.subproj/WebTextView.m:
   3456         (+[WebTextView supportedMIMETypes]):
   3457         * WebView.subproj/WebView.m:
   3458         (+[WebView _viewClass:andRepresentationClass:forMIMEType:]):
   3459         (+[WebView MIMETypesShownAsHTML]): updated to match style
   3460         (+[WebView setMIMETypesShownAsHTML:]): ditto
   3461 
   3462 2005-09-16  John Sullivan  <sullivan (a] apple.com>
   3463 
   3464         * WebView.subproj/WebImageView.m:
   3465         (-[WebImageView copy:]):
   3466         fixed build-breaking silly error in previous checkin
   3467 
   3468 2005-09-16  John Sullivan  <sullivan (a] apple.com>
   3469 
   3470         Reviewed by Tim Omernick
   3471         
   3472         - fixed <rdar://problem/4256557> CrashTracer: 238 crashes in Safari at 
   3473         com.apple.AppKit: -[NSPasteboard setData:forType:] + 188
   3474 
   3475         * WebView.subproj/WebImageView.m:
   3476         (-[WebImageView copy:]):
   3477         declare types to pasteboard before starting to set their data
   3478         (-[WebImageView writeSelectionToPasteboard:types:]):
   3479         ditto
   3480 
   3481 2005-09-16  Adele Peterson  <adele (a] apple.com>
   3482 
   3483         Rolling out the fix for http://bugs.webkit.org/show_bug.cgi?id=4924
   3484             QPainter should use CGContext as much as possible rather than NSGraphicsContext 
   3485         since it caused a performance regression.
   3486 
   3487 2005-09-16  Adele Peterson  <adele (a] apple.com>
   3488 
   3489         Change by Darin, reviewed by me and Maciej.
   3490 
   3491         Fixes http://bugs.webkit.org/show_bug.cgi?id=4547
   3492         use int instead of long for 32-bit (to prepare for LP64 compiling)
   3493 
   3494         * Plugins.subproj/npapi.m: changed types to match those defined in npapi.h
   3495         (NPN_MemAlloc):
   3496         (NPN_MemFlush):
   3497         (NPN_PostURLNotify):
   3498         (NPN_PostURL):
   3499         (NPN_Write):
   3500 
   3501 2005-09-14  Justin Garcia  <justin.garcia (a] apple.com>
   3502 
   3503         Reviewed by john
   3504 
   3505         Fixes <rdar://problem/4237479> REGRESSION (Cambridge-Denver): old QuickTime movie continues to play sound after reload
   3506         We were adding the movie to the document twice after the changes were added to handle fallback content.
   3507         There are some errors for which we should not render fall back content
   3508 
   3509         * Misc.subproj/WebKitErrorsPrivate.h:
   3510         Introduced WebKitErrorPlugInWillHandleLoad to represent the cancel we do
   3511         to prevent loading plugin content twice
   3512         
   3513         * Plugins.subproj/WebPluginDocumentView.m:
   3514         (-[WebPluginDocumentView dataSourceUpdated:]): Ditto
   3515         
   3516         * WebView.subproj/WebDataSource.m:
   3517         (-[WebDataSource _receivedMainResourceError:complete:]):
   3518         Don't handleFallbackContent on WebKitErrorPlugInWillHandleLoad or on a user cancel
   3519 
   3520 2005-09-14  Timothy Hatcher  <thatcher (a] apple.com>
   3521 
   3522         Reviewed by Eric.
   3523         
   3524         * WebKit.xcodeproj/project.pbxproj:
   3525         made WebDashboardRegion.h a private header
   3526 
   3527 2005-09-14  Darin Adler  <darin (a] apple.com>
   3528 
   3529         Reviewed by Maciej.
   3530 
   3531         - fixed http://bugs.webkit.org/show_bug.cgi?id=4924
   3532           QPainter should use CGContext as much as possible rather than NSGraphicsContext
   3533 
   3534         * WebCoreSupport.subproj/WebImageRendererFactory.m: Remove setCGCompositeOperationFromString
   3535         method, no longer needed.
   3536 
   3537 2005-09-13  Tim Omernick  <tomernick (a] apple.com>
   3538 
   3539         Reviewed by Justin Garcia, Darin Adler.
   3540 
   3541 	- <rdar://problem/3163393> Safari does not support Windowless mode in Flash
   3542 
   3543         * Plugins.subproj/WebBaseNetscapePluginView.h:
   3544 	Added 'isTransparent' instance variable.
   3545 
   3546         * Plugins.subproj/WebBaseNetscapePluginView.m:	
   3547         (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):
   3548 	When updating a plugin in "windowless" (transparent) mode, clip drawing to the dirty
   3549 	region of the opaque ancestor.  This means that a partially-transparent plugin, which
   3550 	by definition does not clear its port on redraw, will not overdraw the valid parts
   3551 	of its port.
   3552         (-[WebBaseNetscapePluginView sendEvent:]):
   3553 	Disabled the "green debug background" for transparent plugins -- since they are not
   3554 	expected to cover their entire port every redraw, this debug code makes no sense.
   3555         (-[WebBaseNetscapePluginView setVariable:value:]):
   3556 	Implemented -setVariable:value:, which is called from NPN_SetValue() (previously
   3557 	unimplemented).
   3558 	Right now we only handle NPPVpluginTransparentBool; if we choose to handle the other
   3559 	plugin variables, then we may do so here.
   3560         * Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
   3561 	Added SPI for -[WebBaseNetscapePluginView setVariable:value].
   3562         * Plugins.subproj/npapi.m:
   3563         (NPN_SetValue):
   3564 	Implemented this function so that plugins may set state (such as window mode).
   3565 	
   3566 2005-09-11  Mark Rowe  <opendarwin.org (a] bdash.net.nz>
   3567 
   3568         Reviewed, tweaked, and landed by Darin.
   3569 
   3570         - fixed http://bugs.webkit.org/show_bug.cgi?id=4286
   3571           .Mac prefpane crashes when Safari using CVS WebKit is running
   3572 
   3573         * WebView.subproj/WebView.m: (-[WebView initWithFrame:frameName:groupName:]):
   3574         If ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH, and WEBKIT_UNSET_DYLD_FRAMEWORK_PATH
   3575         is set in the environment, then unset DYLD_FRAMEWORK_PATH.
   3576 
   3577         * WebKit.xcodeproj/project.pbxproj: Set ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH
   3578         in configurations other than Default -- we don't want that code in production
   3579         builds, but we want it in builds we do ourselves and nightly builds.
   3580 
   3581 2005-09-10  Ingmar J Stein  <IngmarStein (a] gmail.com>
   3582 
   3583         Reviewed and landed by Darin.
   3584 
   3585         * WebCoreSupport.subproj/WebImageRenderer.m:
   3586         (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
   3587         Removed unused local variable.
   3588 
   3589 2005-09-09  Tim Omernick  <tomernick (a] apple.com>
   3590 
   3591         Reviewed by John Sullivan.
   3592 
   3593         * History.subproj/WebBackForwardList.m:
   3594         (-[WebBackForwardList removeItem:]):
   3595 	SPI to remove a given WebHistoryItem.
   3596 
   3597         * History.subproj/WebBackForwardListPrivate.h: Added.
   3598 
   3599         * WebKit.xcodeproj/project.pbxproj:
   3600 	Added WebBackForwardListPrivate.h as a private header.
   3601 
   3602 2005-09-09  John Sullivan  <sullivan (a] apple.com>
   3603 
   3604         Reviewed by Tim Omernick.
   3605         
   3606         fixed http://bugs.webkit.org/show_bug.cgi?id=4070:
   3607         Find in plain text won't find only occurrence if it overlaps selection
   3608 
   3609         * Misc.subproj/WebSearchableTextView.m:
   3610         (-[NSString findString:selectedRange:options:wrap:]):
   3611         in the wrap case, extend the search range far enough that text overlapping the
   3612         selection (including the exact-match case) will be considered.
   3613 
   3614 2005-09-08  Justin Garcia  <justin.garcia (a] apple.com>
   3615 
   3616         Reviewed by darin
   3617         
   3618         WebKit portion of multipart/x-mixed-replace support
   3619 
   3620         * WebCoreSupport.subproj/WebSubresourceLoader.m:
   3621         (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
   3622         Subresource case: Check for Foundation level multipart support
   3623         (-[WebSubresourceLoader didReceiveResponse:]): 
   3624         Send previously received data in a multipart section to the coreLoader
   3625         (-[WebSubresourceLoader didReceiveData:lengthReceived:]): 
   3626         Don't send data to the coreLoader until it has been completely received
   3627         * WebView.subproj/WebDataSource.m:
   3628         (-[WebDataSource _startLoading:]): 
   3629         Main resource case: check for Foundation level multipart support 
   3630         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
   3631         Some server apps send data right after declaring content multipart/x-mixed-replace, and expect it to be treated as html
   3632         (-[WebDataSource _commitIfReady:]):
   3633         Don't ask the WebFrame to close its old WebDataSource when loading a multipart section, because we're going to reuse it
   3634         (-[WebDataSource _receivedData:]):
   3635         For non text/html multipart sections, we commit the data all at once, at the end
   3636         (-[WebDataSource _doesProgressiveLoadWithMIMEType:]):
   3637         Added heuristic for when to commit the load incrementally
   3638         (-[WebDataSource _commitLoadWithData:]):
   3639         Moved from _receivedData into its own function
   3640         (-[WebDataSource _revertToProvisionalState]):
   3641         (-[WebDataSource _setupForReplaceByMIMEType:]):
   3642         Commits the data received for the previous multipart section if it wasn't loaded progresively, clears out the WebFrame and WebDatasource for the next multipart section
   3643         * WebView.subproj/WebDataSourcePrivate.h:
   3644         * WebView.subproj/WebFrame.m:
   3645         (-[WebFrame _transitionToCommitted:]): 
   3646         The very first multipart section is treated as a normal load, so that the back/forward list and history are updated.
   3647         All later sections have a new load type, WebFrameLoadTypeReplace, and are treated like reloads
   3648         (-[WebFrame _checkLoadCompleteForThisFrame]): Ditto
   3649         (-[WebFrame _itemForRestoringDocState]): Ditto
   3650         (-[WebFrame _setupForReplace]):
   3651         Clears out the WebFrame for the next multipart section
   3652         * WebView.subproj/WebFrameInternal.h:
   3653         * WebView.subproj/WebFramePrivate.h:
   3654         * WebView.subproj/WebFrameView.m:
   3655         (+[WebFrameView _viewTypesAllowImageTypeOmission:]): See above
   3656         * WebView.subproj/WebLoader.h:
   3657         * WebView.subproj/WebLoader.m:
   3658         (-[NSURLProtocol clearResourceData]):
   3659         (-[NSURLProtocol setSupportsMultipartContent:]):
   3660         * WebView.subproj/WebMainResourceLoader.m: Straightforward
   3661         (-[WebMainResourceLoader didReceiveResponse:]):
   3662 
   3663 2005-09-06  Geoffrey Garen  <ggaren (a] apple.com>
   3664 
   3665         - fixed build bustage from last checkin.
   3666         
   3667         Reviewed by haytt.
   3668 
   3669         * History.subproj/WebBackForwardList.m:
   3670         (-[WebBackForwardList pageCacheSize]): updated debug printf since we no
   3671         longer have a variable called 'multiplier'
   3672 
   3673 2005-09-06  David Hyatt  <hyatt (a] apple.com>
   3674 
   3675 	Reduce the # of cached pages for a back/forward list.  The old cache would cache the
   3676 	following per tab:
   3677 	> 1gb memory = 16 pages per tab/window
   3678 	> 512mb memory = 8 pages per tab/window
   3679 	<= 512mb memory = 4 pages per tab/window
   3680 
   3681 	This consumes far too much memory and is way too aggressive.  The new cache sizes are
   3682 	as follows:
   3683 	>= 1gb memory = 3 pages per tab/window
   3684 	>= 512mb memory = 2 pages per tab/window
   3685 	< 512mb memory = 1 page per tab/window
   3686 
   3687         Reviewed by john
   3688 
   3689         * History.subproj/WebBackForwardList.m:
   3690         (-[WebBackForwardList pageCacheSize]):
   3691         * WebView.subproj/WebPreferences.m:
   3692         (+[WebPreferences initialize]):
   3693 
   3694 2005-09-05  Darin Adler  <darin (a] apple.com>
   3695 
   3696         Reviewed by John Sullivan.
   3697 
   3698         - fixed http://bugs.webkit.org/show_bug.cgi?id=4846
   3699           REGRESSION: Carbon WebKit applications don't work at all
   3700 
   3701         * Carbon.subproj/HIWebView.m: Remove lots of unneeded declarations of private stuff.
   3702         (Draw): Call WKNSWindowOverrideCGContext and WKNSWindowRestoreCGContext rather
   3703         than calling a non-existent setCGContext: method on the context.
   3704 
   3705 2005-09-05  John Sullivan  <sullivan (a] apple.com>
   3706 
   3707         Reviewed by Dave Hyatt.
   3708         
   3709         - change related to <rdar://problem/4211999> Safari quits when click-drag-hold an image 
   3710         that is set to automatically change.
   3711 
   3712         * WebView.subproj/WebHTMLView.m:
   3713         (-[NSArray namesOfPromisedFilesDroppedAtDestination:]):
   3714         handle nil wrapper with ERROR and early return rather than ASSERT, since we now know
   3715         of a way to reproduce this (written up as 4244861)
   3716 
   3717 2005-09-05  Darin Adler  <darin (a] apple.com>
   3718 
   3719         Reviewed by John Sullivan.
   3720 
   3721         - fixed http://bugs.webkit.org/show_bug.cgi?id=4357
   3722           crash related to animated GIFs, reproducible in non-Safari WebKit application
   3723 
   3724         * WebCoreSupport.subproj/WebImageData.m:
   3725         (removeAnimatingRendererFromView): Added.
   3726         (removeFromDictionary): Added.
   3727         (-[WebImageData removeAnimatingRenderer:]): Rewrote using CF functions rather than
   3728         NS functions so that we never retain the views, since this can be called from
   3729         a view's dealloc method.
   3730         (setNeedsDisplayInAnimationRect): Added.
   3731         (-[WebImageData _nextFrame:]): Rewrote as above, even though in this case it can't
   3732         be called from the dealloc method.
   3733 
   3734 2005-08-26  David Hyatt  <hyatt (a] apple.com>
   3735 
   3736 	Add support for a new scaling and tiling function so that border images from CSS3
   3737 	can be implemented.
   3738 	
   3739         Reviewed by darin
   3740 
   3741         * WebCoreSupport.subproj/WebImageData.h:
   3742         * WebCoreSupport.subproj/WebImageData.m:
   3743         (-[WebImageData scaleAndTileInRect:fromRect:withHorizontalTileRule:withVerticalTileRule:context:]):
   3744         * WebCoreSupport.subproj/WebImageRenderer.m:
   3745         (-[WebImageRenderer scaleAndTileInRect:fromRect:withHorizontalTileRule:withVerticalTileRule:context:]):
   3746         (-[WebImageRenderer setAnimationRect:]):
   3747         * WebView.subproj/WebHTMLView.m:
   3748         (-[WebHTMLView updateFocusState]):
   3749 
   3750 2005-08-26  Adele Peterson  <adele (a] apple.com>
   3751 
   3752         Reviewed by Beth.
   3753 
   3754         * WebKit.xcodeproj/project.pbxproj: Changed WebKit.Framework to WebKit.framework in UMBRELLA_FRAMEWORK.
   3755 
   3756 2005-08-25  David Harrison  <harrison (a] apple.com>
   3757 
   3758         Reviewed by Maciej.
   3759 
   3760         <rdar://problem/4227734> Denver Regression: WebCore selection bug on lines starting with tab (clownfish)
   3761 
   3762         The text is in a DIV styled with "white-space:pre", and uses newline characters as linebreaks.
   3763         WebKit's text renderer is erroneously considering the width of the lines leading up to the tab
   3764         character when calculating the width of the tab.
   3765         Easily fixed by having widthForNextCharacter ignore the widthToStart when working with tabWidth.
   3766         Any prior text that fits in the same line is already factored into the xpos, which is paid attention to.
   3767 
   3768         * WebCoreSupport.subproj/WebTextRenderer.m:
   3769         (widthForNextCharacter):
   3770         Ignore the widthToStart when working with tabWidth.
   3771 
   3772 2005-08-23  John Sullivan  <sullivan (a] apple.com>
   3773 
   3774         Reviewed by Beth Dakin.
   3775         
   3776         - fixed <rdar://problem/4229167> 14 leaks of WebFileButton and associated objects, 
   3777         seen after running webkit layout tests
   3778 
   3779         * WebCoreSupport.subproj/WebBridge.m:
   3780         (-[WebBridge fileButtonWithDelegate:]):
   3781         this method was returning a retained object; I added an autorelease
   3782 
   3783 2005-08-23  Darin Adler  <darin (a] apple.com>
   3784 
   3785         * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
   3786 
   3787 2005-08-23  Mitz Pettel  <opendarwin.org (a] mitzpettel.com>
   3788 
   3789         Reviewed and landed by Darin.
   3790 
   3791         - fixed http://bugs.webkit.org/show_bug.cgi?id=4604
   3792           LEAK -[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an ATSUTextLayout
   3793           <rdar://problem/4228787> ATSUTextLayout leak in _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs: (4604)
   3794 
   3795         * WebCoreSupport.subproj/WebTextRenderer.m:
   3796         (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   3797         Added missing call to ATSUDisposeTextLayout.
   3798 
   3799 2005-08-22  Geoffrey Garen  <ggaren (a] apple.com>
   3800 
   3801         - fixed <rdar://problem/4227011> Debugger SPI should be removed from WebView.h API
   3802         
   3803         Reviewed by mjs and adele.
   3804 
   3805         Cut and pasted debugging SPI from WebView to WebView(WebPendingPublic)
   3806         
   3807         * WebView.subproj/WebView.h:
   3808         * WebView.subproj/WebView.m:
   3809         (-[WebView setScriptDebugDelegate:]):
   3810         (-[WebView scriptDebugDelegate]):
   3811         * WebView.subproj/WebViewPrivate.h:
   3812 
   3813 2005-08-20  John Sullivan  <sullivan (a] apple.com>
   3814 
   3815         Reviewed by Darin Adler.
   3816         
   3817         - WebKit part of fix for 
   3818         <rdar://problem/3977607> ER: Safari should check framework versions at launch
   3819 
   3820         * WebView.subproj/WebViewPrivate.h:
   3821         * WebView.subproj/WebView.m:
   3822         (+[WebView _minimumRequiredSafariBuildNumber]):
   3823         new method, returns the minimum build number of Safari that this WebKit is
   3824         willing to work with. (The Safari version has to be new enough to check
   3825         for this value in order for this to have any effect.)
   3826 
   3827 2005-08-19  Justin Garcia  <justin.garcia (a] apple.com>
   3828 
   3829         Reviewed by rjw
   3830         
   3831         The boolean justOpenedForTargetedLink is never used to determine a course of action.  
   3832         It was added long ago for findOrCreateFramedNamed, which has since been removed.
   3833 
   3834         * WebView.subproj/WebDataSource.m:
   3835         * WebView.subproj/WebDataSourcePrivate.h:
   3836         * WebView.subproj/WebFrame.m:
   3837         (-[WebFrame _loadDataSource:withLoadType:formState:]):
   3838         * WebView.subproj/WebFramePrivate.h:
   3839 
   3840 2005-08-19  Darin Adler  <darin (a] apple.com>
   3841 
   3842         Reviewed by John.
   3843 
   3844         * English.lproj/Localizable.strings: Updated to include a new localizable string
   3845         that was added a long while back. Apprently no one has run into the code using
   3846         this string, because if they had, they'd have seen an assert.
   3847         * English.lproj/StringsNotToBeLocalized.txt: Updated for various recent changes.
   3848 
   3849 2005-08-17  Maciej Stachowiak  <mjs (a] apple.com>
   3850 
   3851         Reviewed by Darin.
   3852 
   3853 	- fix mysterious CGImageSource error message and possibly crash on layout tests.
   3854 
   3855         * WebView.subproj/WebMainResourceLoader.m:
   3856         (-[WebMainResourceLoader receivedError:]): Retain the data source since it may
   3857 	prematurely self-destruct otherwise.
   3858         (-[WebMainResourceLoader cancelWithError:]): ditto
   3859 
   3860 2005-08-17  Justin Garcia  <justin.garcia (a] apple.com>
   3861 
   3862         Reviewed by rjw
   3863         
   3864         Addresses <rdar://problem/4192534> new frame load delegate SPI needed for Dashboard
   3865             Added handledOnloadEvents delegate method (private for now)
   3866 
   3867         * WebCoreSupport.subproj/WebBridge.m:
   3868         (-[WebBridge handledOnloadEvents]):
   3869         * WebView.subproj/WebDefaultFrameLoadDelegate.m:
   3870         (-[WebDefaultFrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
   3871         * WebView.subproj/WebFrame.m:
   3872         (-[WebFrame _handledOnloadEvents]):
   3873         * WebView.subproj/WebFramePrivate.h:
   3874         * WebView.subproj/WebViewPrivate.h:
   3875 
   3876 2005-08-17  John Sullivan  <sullivan (a] apple.com>
   3877 
   3878         Reviewed by Geoff Garen.
   3879         
   3880         - fixed <rdar://problem/4219817> Particular icon database + bookmarks + history crashes Safari on launch
   3881 
   3882         * Misc.subproj/WebIconDatabase.m:
   3883         (-[WebIconDatabase releaseIconForURL:]):
   3884         Move line that might remove last reference to iconURL to the end of the block.
   3885 
   3886 2005-08-16  Darin Adler  <darin (a] apple.com>
   3887 
   3888         Reviewed by Trey.
   3889 
   3890 	- improved fix for <rdar://problem/4211631>, tiled images tiled incorrectly when printing or 
   3891 	  drawing offscreen
   3892 
   3893         * WebCoreSupport.subproj/WebImageData.m: (-[WebImageData tileInRect:fromPoint:context:]):
   3894         Fix pattern phase origin to use the image tile origin, which is clearly right, rather than
   3895         the image rectangle, which isn't right, but often is the same.
   3896 
   3897 2005-08-16  Adele Peterson  <adele (a] apple.com>
   3898 
   3899         Reviewed by John.
   3900 
   3901         - fixed <rdar://problem/4210320> URL tooltips should display a URL for elements that submit forms
   3902 
   3903         When the setShowsURLsInToolTips preference is set, we will display a tooltip containing 
   3904         the form's url when you mouse over a submit button.
   3905 
   3906         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]):
   3907 
   3908 2005-08-16  Darin Adler  <darin (a] apple.com>
   3909 
   3910         Reviewed by Beth Dakin.
   3911 
   3912         - removed Panther-only code that was not being compiled and was
   3913           simply "bit-rotting"
   3914 
   3915         * Misc.subproj/WebFileDatabase.m:
   3916         (-[WebFileDatabase _createLRUList:]):
   3917         (+[WebFileDatabase _syncLoop:]):
   3918         * Misc.subproj/WebKitErrors.m:
   3919         (registerErrors):
   3920         * Misc.subproj/WebNSObjectExtras.h:
   3921         (WebCFAutorelease):
   3922         * Misc.subproj/WebNSPasteboardExtras.m:
   3923         (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]):
   3924         * WebCoreSupport.subproj/WebImageData.h:
   3925         * WebCoreSupport.subproj/WebImageDecodeItem.h:
   3926         * WebCoreSupport.subproj/WebImageDecodeItem.m:
   3927         * WebCoreSupport.subproj/WebImageDecoder.h:
   3928         * WebCoreSupport.subproj/WebImageDecoder.m:
   3929         (decoderThread):
   3930         (startDecoderThread):
   3931         * WebCoreSupport.subproj/WebKeyGeneration.cpp: Removed.
   3932         * WebCoreSupport.subproj/WebKeyGeneration.h: Removed.
   3933         * WebCoreSupport.subproj/WebKeyGenerator.h:
   3934         * WebCoreSupport.subproj/WebTextRenderer.m:
   3935         (getUncachedWidth):
   3936         (_drawGlyphs):
   3937         * WebCoreSupport.subproj/WebViewFactory.m:
   3938         (-[WebViewFactory getBytes:fromTextMarker:length:]):
   3939         * WebKit.xcodeproj/project.pbxproj:
   3940         * WebKitPrefix.h:
   3941         * WebView.subproj/WebDataSource.m:
   3942         (-[WebDataSource _setPrimaryLoadComplete:]):
   3943         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
   3944         (-[WebDataSource isLoading]):
   3945         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   3946         (localizedMenuTitleFromAppKit):
   3947         (-[WebDefaultUIDelegate menuItemWithTag:]):
   3948         (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
   3949         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
   3950         * WebView.subproj/WebFormDataStream.m:
   3951         (formCanRead):
   3952         (webSetHTTPBody):
   3953         * WebView.subproj/WebFrameView.m:
   3954         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
   3955         * WebView.subproj/WebHTMLView.m:
   3956         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:chosePlainText:]):
   3957         (-[WebHTMLView resourceForData:preferredFilename:]):
   3958         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
   3959         (-[WebHTMLView validateUserInterfaceItem:]):
   3960         (-[WebHTMLView _attributeStringFromDOMRange:]):
   3961         (-[WebHTMLView toggleBaseWritingDirection:]):
   3962         (-[WebHTMLView changeBaseWritingDirection:]):
   3963         * WebView.subproj/WebPDFRepresentation.h:
   3964         * WebView.subproj/WebPDFRepresentation.m:
   3965         * WebView.subproj/WebPDFView.h:
   3966         * WebView.subproj/WebPDFView.m:
   3967         * WebView.subproj/WebPreferences.m:
   3968         (+[WebPreferences _systemCFStringEncoding]):
   3969         * WebView.subproj/WebView.m:
   3970         (-[WebView _commonInitializationWithFrameName:groupName:]):
   3971 
   3972 2005-08-16  Darin Adler  <darin (a] apple.com>
   3973 
   3974         Reviewed by Beth Dakin.
   3975 
   3976         - removed some unnecessary code
   3977 
   3978         * WebCoreSupport.subproj/WebGraphicsBridge.h: Removed pattern-phase related field and methods.
   3979         * WebCoreSupport.subproj/WebGraphicsBridge.m: Ditto.
   3980 
   3981         * WebCoreSupport.subproj/WebImageData.m: Tweaked formatting and removed some unused code
   3982         inside #if and comments.
   3983 
   3984         * WebCoreSupport.subproj/WebImageRenderer.h: Removed USE_CGIMAGEREF (which is always true now).
   3985         * WebCoreSupport.subproj/WebImageRenderer.m: Removed old non-CGImageRef code.
   3986 
   3987         * WebCoreSupport.subproj/WebImageRendererFactory.m:
   3988         (-[WebImageRendererFactory imageRendererWithMIMEType:]): Removed non-USE_CGIMAGEREF code.
   3989         (-[WebImageRendererFactory imageRendererWithData:MIMEType:]): Ditto.
   3990         (-[WebImageRendererFactory imageRendererWithSize:]): Ditto.
   3991         (-[WebImageRendererFactory imageRendererWithName:]): Ditto.
   3992 
   3993 2005-08-15  Darin Adler  <darin (a] apple.com>
   3994 	
   3995         Reviewed by Beth.
   3996 
   3997 	This is a fix for <rdar://problem/4211631> tiled images tiled incorrectly when printing or 
   3998 	drawing offscreen.
   3999 
   4000 	Cayenne found there was a problem when they were trying to take screen shots of widgets, and
   4001 	it was ultimately a problem with the way we tile images. Darin was able to fix the problem
   4002 	by replacing some confusing hacked code with CG calls.
   4003 
   4004         * WebCoreSupport.subproj/WebImageData.m:
   4005         (-[WebImageData tileInRect:fromPoint:context:]):
   4006         * WebCoreSupport.subproj/WebImageRenderer.m:
   4007         (-[WebInternalImage tileInRect:fromPoint:context:]):
   4008         * WebCoreSupport.subproj/WebTextRenderer.m:
   4009         (-[WebTextRenderer drawLineForMisspelling:withWidth:]):
   4010 
   4011 2005-08-14  Maciej Stachowiak  <mjs (a] apple.com>
   4012 
   4013         Reviewed by Darin.
   4014 
   4015 	- 1% speedup on HTML load speed iBench by avoiding icon database thrash
   4016 	http://bugs.webkit.org/show_bug.cgi?id=4423
   4017 	
   4018         * Misc.subproj/WebIconDatabase.m:
   4019         (-[WebIconDatabase _setIconURL:forURL:]): Be more aggressive about returning early, because
   4020 	updating the database does some expensive data structure copies.
   4021 	
   4022 
   4023 2005-08-14  Duncan Wilcox  <duncan (a] mclink.it>
   4024 
   4025         Reviewed and landed by Darin.
   4026 
   4027         WebKit part of fix for <http://bugs.webkit.org/show_bug.cgi?id=4011>:
   4028         "Editing delegate selection methods not called when using mouse"
   4029 
   4030         Clicking on editable content would move the cursor or alter the selection without
   4031         calling the appropriate editing delegate method
   4032         (webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:). The
   4033         core of the patch is in the KHTMLPart::handleMousePressEvent* methods, the rest
   4034         is glue needed to drill through all the layers.
   4035 
   4036         * WebCoreSupport.subproj/WebBridge.m:
   4037         (-[WebBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
   4038         Bridge glue.
   4039 
   4040         * WebView.subproj/WebView.m:
   4041         (-[WebView(WebViewEditingExtras) _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
   4042         Final step in glue, calling editing delegate.
   4043 
   4044         * WebView.subproj/WebViewInternal.h:
   4045         Added _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting: private method to WebViewEditingExtras
   4046         category.
   4047 
   4048 2005-08-11  Beth Dakin  <bdakin (a] apple.com>
   4049 
   4050         Reviewed by Vicki
   4051 
   4052 	This is a fix for <rdar://problem/4141161> REGRESSION (Tiger): WebKit does not display in composited Carbon windows.
   4053 	I basically did what Troy suggests in his bug comments, and everything seems to work fine!
   4054 
   4055         * Carbon.subproj/HIViewAdapter.m:
   4056         (-[HIViewAdapter setNeedsDisplayInRect:]):
   4057 
   4058 2005-08-10  Adele Peterson  <adele (a] apple.com>
   4059 
   4060         Bumping version to 420+
   4061 
   4062         * Info.plist:
   4063 
   4064 2005-08-08  Darin Adler  <darin (a] apple.com>
   4065 
   4066         Reviewed by John Sullivan.
   4067 
   4068         - fixed <rdar://problem/3996324> REGRESSION (1.2-2.0): scroll bars sometimes not updated properly (with >40 duplicate reports!)
   4069           also http://bugs.webkit.org/show_bug.cgi?id=3416
   4070 
   4071         * WebView.subproj/WebHTMLView.m:
   4072         (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
   4073         Propagate dirty rects after doing a layout, since a layout can create new dirty rects.
   4074 
   4075 2005-08-05  Adele Peterson  <adele (a] apple.com>
   4076 
   4077         Reviewed by Darin.
   4078 
   4079         * WebKit.xcodeproj/project.pbxproj: Unchecked 'statics are thread safe' option.
   4080 
   4081 2005-08-04  Justin Garcia  <justin.garcia (a] apple.com>
   4082 
   4083         Reviewed by darin
   4084         
   4085         Fix for:
   4086         <rdar://problem/3167884> Shockwave: 3D sprites rendered in OpenGL draw over the browser (3447)
   4087         also as <http://bugs.webkit.org/show_bug.cgi?id=3447>
   4088         
   4089         The WindowRef created by -[NSWindow windowRef] has a QuickDraw GrafPort that covers 
   4090         the entire window frame (or structure region in Carbon parlance) rather then just the window content.
   4091         
   4092         We filed this as an NSWindow bug <rdar://problem/4201099>
   4093 
   4094         To work around, we modify the CGrafPort to only cover the content area before we let the plug-in draw.
   4095 
   4096         * Plugins.subproj/WebBaseNetscapePluginView.m:
   4097         (-[WebBaseNetscapePluginView fixWindowPort]):
   4098         (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):
   4099 
   4100 2005-08-03  John Sullivan  <sullivan (a] apple.com>
   4101 
   4102         Reviewed by Geoff Garen.
   4103         
   4104         - fixed <rdar://problem/3918675> Remove code to replace authentication dialog 
   4105         with a subclass when out of localization freeze
   4106 
   4107         * Panels.subproj/WebAuthenticationPanel.h:
   4108         moved declaration of NonBlockingPanel here so it can be accessed by the nib
   4109         * Panels.subproj/WebAuthenticationPanel.m:
   4110         (-[WebAuthenticationPanel replacePanelWithSubclassHack]):
   4111         removed this method
   4112         (-[WebAuthenticationPanel loadNib]):
   4113         stop calling the removed method
   4114 
   4115         * Panels.subproj/English.lproj/WebAuthenticationPanel.nib/classes.nib:
   4116         * Panels.subproj/English.lproj/WebAuthenticationPanel.nib/info.nib:
   4117         * Panels.subproj/English.lproj/WebAuthenticationPanel.nib/objects.nib:
   4118         the panel in the nib now has custom class NonBlockingPanel
   4119 
   4120 2005-08-03  Beth Dakin  <bdakin (a] apple.com>
   4121 
   4122         Reviewed by cblu
   4123 
   4124 	Removing calls to WKCreateUncorrectedRGBColorSpace and
   4125         WKCreateUncorrectedGrayColorSpace in WebKit to patch up
   4126 	TOT...Eric removed them from WebCore last night.
   4127 
   4128         * WebCoreSupport.subproj/WebImageData.m:
   4129         * WebCoreSupport.subproj/WebImageRenderer.m:
   4130         (WebCGColorSpaceCreateRGB):
   4131         (WebCGColorSpaceCreateGray):
   4132 
   4133 2005-08-02  John Sullivan  <sullivan (a] apple.com>
   4134 
   4135         Reviewed by Darin Adler.
   4136         
   4137         Preemptively moved some WebMenuItemTag values from SPI to API, in anticipation of
   4138         approval from macosx-api-reviewers. Retitled one of them in response to API reviewers feedback:
   4139         WebMenuItemSearchInGoogle -> WebMenuItemSearchWeb
   4140         
   4141         Note that as a side effect of this change, the actual numbers used for these WebMenuItemTags has
   4142         changed from what it was in Tiger. This causes "Search in Spotlight", "Search in Google", and
   4143         "Look Up in Dictionary" to not appear in Tiger Safari if running on tip of tree WebKit.
   4144 
   4145         * WebView.subproj/WebUIDelegatePrivate.h:
   4146         removed WebMenuItemTagSearchInSpotlight, WebMenuItemTagSearchInGoogle, and WebMenuItemTagLookUpInDictionary
   4147 
   4148         * WebView.subproj/WebUIDelegate.h:
   4149         added WebMenuItemTagSearchInSpotlight, WebMenuItemTagSearchWeb, and WebMenuItemTagLookUpInDictionary
   4150 
   4151         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   4152         (-[WebDefaultUIDelegate menuItemWithTag:]):
   4153         updated for rename
   4154         (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
   4155         ditto
   4156         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
   4157         ditto
   4158         
   4159 2005-08-01  Geoffrey Garen  <ggaren (a] apple.com>
   4160 
   4161         -fixed <rdar://problem/3572585> window.open fails if name param = 
   4162         the name of a window just closed in same function
   4163 
   4164         Reviewed by darin.
   4165 
   4166         Test cases added:
   4167 
   4168         * manual-tests/open-after-close.html: Added.
   4169         * manual-tests/resources/open-after-close-popup.html: Added.
   4170 
   4171         * WebCoreSupport.subproj/WebBridge.m:
   4172         (-[WebBridge closeWindowSoon]): We now remove a WebView from 
   4173         WebViewSets when the WebView is *scheduled* to close.
   4174 
   4175 2005-08-01  John Sullivan  <sullivan (a] apple.com>
   4176 
   4177         * PublicHeaderChangesFromTiger.txt:
   4178         added a comment about isTextField -> _isTextField
   4179 
   4180 2005-08-01  John Sullivan  <sullivan (a] apple.com>
   4181 
   4182         Patch by Trey Matteson <trey (a] usa.net>
   4183         Reviewed by me.
   4184 
   4185         Fixed http://bugs.webkit.org/show_bug.cgi?id=4255
   4186           underlines still print too thick
   4187 
   4188         The real problem here is that we have code that scales a 0 width line to always
   4189         be width=1.0 in device space.  I'm leaving that in for the screen, but when printing
   4190         a width of 0.5 looks good.
   4191 
   4192         * WebCoreSupport.subproj/WebTextRenderer.m:
   4193         (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
   4194 
   4195 2005-08-01  Eric Seidel  <eseidel (a] apple.com>
   4196 
   4197         Reviewed by darin.
   4198 
   4199         * WebCoreSupport.subproj/WebGraphicsBridge.m:
   4200         removed create*ColorSpace methods, now using CG API directly.
   4201         http://bugs.webkit.org/show_bug.cgi?id=4211
   4202 
   4203 2005-07-31  John Sullivan  <sullivan (a] apple.com>
   4204 
   4205         Patch by Trey Matteson <trey (a] usa.net>
   4206         Reviewed by me.
   4207 
   4208         Fixed http://bugs.webkit.org/show_bug.cgi?id=4014
   4209           PDF files by default load with a poor choice of sizing
   4210 
   4211         For now the various PDF viewing settings are sticky, stored in 2 new defaults.  Since
   4212         there are a number of ways these settings are changed, I made a proxy for the PDFView
   4213         through which all view changing messages are sent.  The proxy adds the behavior of
   4214         updating the defaults upon any change.
   4215 
   4216         * Misc.subproj/WebNSDictionaryExtras.h:
   4217         * Misc.subproj/WebNSDictionaryExtras.m:
   4218         (-[NSMutableDictionary _webkit_setFloat:forKey:]):  New support method.
   4219         * WebView.subproj/WebPDFView.h:
   4220         * WebView.subproj/WebPDFView.m:
   4221         (-[WebPDFView initWithFrame:]):  Create proxy for PDFView.
   4222         (-[WebPDFView dealloc]):  Free proxy.
   4223         (-[WebPDFView _menuItemsFromPDFKitForEvent:]):  For relevant context menu items, set the
   4224             target to the proxy instead of the PDFView.
   4225         (-[WebPDFView _readPDFDefaults]):  Init PDFView with settings from defaults.
   4226         (-[WebPDFView layout]):  Call _readPDFDefaults, once.  This turned out to be the best hook.
   4227         (-[WebPDFView _makeTextSmaller:]):  Change PDFView via proxy
   4228         (-[WebPDFView _makeTextLarger:]):  Ditto
   4229         (-[WebPDFView _makeTextStandardSize:]):  Ditto
   4230         (-[PDFPrefUpdatingProxy initWithView:]):  trivial
   4231         (-[PDFPrefUpdatingProxy forwardInvocation:]):  Forward the msg, then update defaults
   4232         (-[PDFPrefUpdatingProxy methodSignatureForSelector:]):  Simple forwarding support.
   4233         * WebView.subproj/WebPreferenceKeysPrivate.h:
   4234         * WebView.subproj/WebPreferences.m:
   4235         (+[WebPreferences initialize]):  Set initial values for new PDF viewing defaults.
   4236         (-[WebPreferences _integerValueForKey:]):  Nuke stray comment.
   4237         (-[WebPreferences _floatValueForKey:]):  New simple support method.
   4238         (-[WebPreferences _setFloatValue:forKey:]):  Ditto.
   4239         (-[WebPreferences PDFScaleFactor]):  4 accessors for new defaults 
   4240         (-[WebPreferences setPDFScaleFactor:]):
   4241         (-[WebPreferences PDFDisplayMode]):
   4242         (-[WebPreferences setPDFDisplayMode:]):
   4243         * WebView.subproj/WebPreferencesPrivate.h:
   4244 
   4245 2005-08-01  Justin Garcia  <justin.garcia (a] apple.com>
   4246 
   4247         Patch by Trey Matteson <trey (a] usa.net>
   4248 
   4249         Reviewed by Maciej.
   4250 
   4251         Fixed <http://bugs.webkit.org/show_bug.cgi?id=4226>
   4252           link underlines print too thickly
   4253 
   4254         Reinstate the fix made by sullivan on 1/11/05.  There was a merge
   4255         error with an mjs fix on 1/13/05.
   4256 
   4257         * WebCoreSupport.subproj/WebTextRenderer.m:
   4258         (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
   4259 
   4260 2005-07-30  Maciej Stachowiak  <mjs (a] apple.com>
   4261 
   4262         Build fixes for previous change (missing includes)
   4263 
   4264         * WebView.subproj/WebFrame.m:
   4265         * WebView.subproj/WebScriptDebugDelegate.m:
   4266 
   4267 2005-07-29  Maciej Stachowiak  <mjs (a] apple.com>
   4268 
   4269         Changes by Michael Kahl, reviewed by me.
   4270 
   4271 	- fixed <rdar://problem/4164112> MASTER: JavaScript debugging support
   4272 	
   4273         * WebCoreSupport.subproj/WebBridge.m:
   4274         (-[WebBridge windowObjectCleared]):
   4275         * WebCoreSupport.subproj/WebSubresourceLoader.m:
   4276         * WebKit.xcodeproj/project.pbxproj:
   4277         * WebView.subproj/WebDefaultScriptDebugDelegate.h: Added.
   4278         * WebView.subproj/WebDefaultScriptDebugDelegate.m: Added.
   4279         (+[WebDefaultScriptDebugDelegate sharedScriptDebugDelegate]):
   4280         (-[WebDefaultScriptDebugDelegate webView:didParseSource:fromURL:sourceId:forWebFrame:]):
   4281         (-[WebDefaultScriptDebugDelegate webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
   4282         (-[WebDefaultScriptDebugDelegate webView:willExecuteStatement:sourceId:line:forWebFrame:]):
   4283         (-[WebDefaultScriptDebugDelegate webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
   4284         * WebView.subproj/WebFrame.m:
   4285         (-[WebFramePrivate dealloc]):
   4286         (-[WebFrame _attachScriptDebugger]):
   4287         * WebView.subproj/WebFramePrivate.h:
   4288         * WebView.subproj/WebScriptDebugDelegate.h: Added.
   4289         * WebView.subproj/WebScriptDebugDelegate.m: Added.
   4290         (-[WebScriptDebugger initWithWebFrame:]):
   4291         (-[WebScriptDebugger dealloc]):
   4292         (-[WebScriptDebugger globalObject]):
   4293         (-[WebScriptDebugger newWrapperForFrame:]):
   4294         (-[WebScriptDebugger parsedSource:fromURL:sourceId:]):
   4295         (-[WebScriptDebugger enteredFrame:sourceId:line:]):
   4296         (-[WebScriptDebugger hitStatement:sourceId:line:]):
   4297         (-[WebScriptDebugger leavingFrame:sourceId:line:]):
   4298         (-[WebScriptCallFrame _initWithFrame:]):
   4299         (-[WebScriptCallFrame dealloc]):
   4300         (-[WebScriptCallFrame setUserInfo:]):
   4301         (-[WebScriptCallFrame userInfo]):
   4302         (-[WebScriptCallFrame caller]):
   4303         (-[WebScriptCallFrame scopeChain]):
   4304         (-[WebScriptCallFrame functionName]):
   4305         (-[WebScriptCallFrame exception]):
   4306         (-[WebScriptCallFrame evaluateWebScript:]):
   4307         * WebView.subproj/WebScriptDebugDelegatePrivate.h: Added.
   4308         * WebView.subproj/WebView.h:
   4309         * WebView.subproj/WebView.m:
   4310         (-[WebViewPrivate dealloc]):
   4311         (-[WebView _scriptDebugDelegateForwarder]):
   4312         (-[WebView setScriptDebugDelegate:]):
   4313         (-[WebView scriptDebugDelegate]):
   4314         * WebView.subproj/WebViewInternal.h:
   4315         * WebView.subproj/WebViewPrivate.h:
   4316 
   4317 2005-07-26  Maciej Stachowiak  <mjs (a] apple.com>
   4318 
   4319         Reviewed by Dave Hyatt.
   4320 
   4321 	- fixed http://bugs.webkit.org/show_bug.cgi?id=4153
   4322 	
   4323         * WebView.subproj/WebFrame.m:
   4324         (-[WebFrame _purgePageCache]): Find the oldest candidate for
   4325 	purging that is not a snapback item.
   4326 
   4327 2005-07-29  David Harrison  <harrison (a] apple.com>
   4328 
   4329         Reviewed by Dave Hyatt (rendering) and Maciej (editing and performance improvements).
   4330 
   4331         Test cases added: Existing tab-related basic editing tests were updated.  More complex tests are coming soon.
   4332 
   4333         <rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)
   4334         
   4335         Basic strategy is to put tabs into spans with white-space:pre style, and
   4336         render them with tabs stops every 8th space, where the space width and
   4337         the left margin are those of the enclosing block.
   4338 
   4339         * WebCoreSupport.subproj/WebTextRenderer.m:
   4340         (isSpace):
   4341         (isRoundingHackCharacter):
   4342         (getUncachedWidth):
   4343         (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
   4344         (-[WebTextRenderer _computeWidthForSpace]):
   4345         (_drawGlyphs):
   4346         (-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]):
   4347         (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]):
   4348         (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]):
   4349         (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   4350         (glyphForCharacter):
   4351         (initializeCharacterWidthIterator):
   4352         (ceilCurrentWidth):
   4353         (widthForNextCharacter):
   4354 
   4355 2005-07-29  John Sullivan  <sullivan (a] apple.com>
   4356 
   4357         Reviewed by Dave Hyatt.
   4358         
   4359         - WebKit part of <rdar://problem/4187404> Redo form SPI so that it doesn't rely on NSViews
   4360         
   4361         Much of 4187404 was addressed in earlier checkins. This checkin completes the task.
   4362 
   4363         * WebView.subproj/WebHTMLRepresentation.h:
   4364         * WebView.subproj/WebHTMLRepresentation.m:
   4365         removed viewForElement:, which was the only remaining NSView-related SPI that Safari autofill was
   4366         still using. I added viewForElement a week ago as a transitional measure, so removing it won't
   4367         affect any other clients.
   4368 
   4369 2005-07-29  John Sullivan  <sullivan (a] apple.com>
   4370 
   4371         Reviewed by Chris Blumenberg.
   4372 
   4373         * WebView.subproj/WebFrameView.m:
   4374         (-[WebFrameView _firstResponderIsFormControl]):
   4375         renamed from _firstResponderIsControl for clarity. Explicitly rejects WebHTMLView, since
   4376         it's now a control.
   4377         (-[WebFrameView keyDown:]):
   4378         updated for renamed method.
   4379 
   4380 2005-07-28  John Sullivan  <sullivan (a] apple.com>
   4381 
   4382         Reviewed by Beth Dakin.
   4383         
   4384         - removed method -[WebHTMLRepresentation elementForView:], which was SPI used only for
   4385         Safari autofill. Tip of tree Safari no longer includes any calls to this method. Also, 
   4386         Tiger Safari never gets around to actually calling it due to the other recent form-SPI-related
   4387         changes, so removing this method doesn't break Tiger Safari running on tip of tree WebKit
   4388         (though autofill continues to not work in that configuration).
   4389 
   4390         * WebView.subproj/WebHTMLRepresentation.h:
   4391         * WebView.subproj/WebHTMLRepresentation.m:
   4392         (-[WebHTMLRepresentation elementForView:]): removed
   4393         
   4394 2005-07-27  John Sullivan  <sullivan (a] apple.com>
   4395 
   4396 	Patch by Trey Matteson <trey (a] usa.net>
   4397         Reviewed by me.
   4398 
   4399         Fixed http://bugs.webkit.org/show_bug.cgi?id=4169
   4400           scaling PDF view up leaves later HTML view scaled too
   4401 
   4402         An additional step of separating scaling of HTML and PDF.  If we do a zoom and there
   4403         are no docViews that track the common scaling factor, then don't change it.  Thus in
   4404         the common PDF case where it is the only doc view, scaling the PDF does not affect
   4405         HTML pages loaded in the same window.
   4406 
   4407         * WebView.subproj/WebView.m:
   4408         (-[WebView canMakeTextSmaller]):  Pass 0 for new scaling factor, since we just querying.
   4409         (-[WebView canMakeTextLarger]):  Ditto.
   4410         (-[WebView makeTextSmaller:]):  Pass new scaling factor.
   4411         (-[WebView makeTextLarger:]):  Ditto.
   4412         (-[WebView canMakeTextStandardSize]):  Pass 0 for new scaling factor.
   4413         (-[WebView makeTextStandardSize:]):  Pass new scaling factor.
   4414         (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
   4415           The meat of the change is that this Swiss Army Knife also takes a new scaling
   4416           factor, which it will set as the common scaling factor if it finds any doc views that
   4417           are able to be scaled which track the common scaling factor.
   4418 
   4419 2005-07-27  John Sullivan  <sullivan (a] apple.com>
   4420 
   4421 	Patch by Trey Matteson <trey (a] usa.net>
   4422         Reviewed by me.
   4423 
   4424         Fixed http://bugs.webkit.org/show_bug.cgi?id=4015
   4425           PDF views should remember viewing mode, scroll position across back/forward
   4426           Note this doesn't work within frames because of a PDFKit bug - see 4164
   4427         Fixed http://bugs.webkit.org/show_bug.cgi?id=4091
   4428           PDF views should keep a separate scaling factor from shared text scaling factor
   4429 
   4430         Basic idea #1 is that we now have a general mechanism for a WebDocView to save/restore some UI
   4431         state to the WebHistoryItem.
   4432         Basic idea #2 is that _WebDocumentTextSizing is expanded to allow for the case of a WebDocView
   4433         keeping its own notion of a scaling factor.  WebPDFView's -_tracksCommonSizeFactor has justification.
   4434 
   4435         * History.subproj/WebHistoryItem.m:
   4436         (-[WebHistoryItem setViewState:]):  New methods to hold PList of arbitrary WebView state
   4437         (-[WebHistoryItem viewState]):
   4438         * History.subproj/WebHistoryItemPrivate.h:
   4439         * WebKit.xcodeproj/project.pbxproj:  Add Quartz to framework path so we can import PDFKit files
   4440         * WebView.subproj/WebDocumentInternal.h:  New methods added to _WebDocumentTextSizing.
   4441           Also the _ prefix is sufficient instead of _web_WebDocumentTextSizing.
   4442           Added _WebDocumentViewState protocol.
   4443         * WebView.subproj/WebFrame.m:
   4444         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):  Rename of save/restore methods.
   4445         (-[WebFrame _detachFromParent]):  Ditto
   4446         (-[WebFrame _transitionToCommitted:]):  Ditto
   4447         (-[WebFrame _checkLoadCompleteForThisFrame]):  Ditto
   4448         (-[WebFrame _loadItem:withLoadType:]):  Ditto
   4449         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):  Ditto
   4450         (-[WebFrame _saveViewStateToItem:]):  Call doc view to retrieve view state.
   4451         (-[WebFrame _restoreViewState]):  Call doc view to set view state.
   4452         (-[WebFrame _scrollToTop]):  Nuked dead code.
   4453         (-[WebFrame _textSizeMultiplierChanged]):  This work now appears in WebView.
   4454         (-[WebFrame _saveDocumentAndScrollState]):  Same rename, one code cleanup.
   4455         (-[WebFrame _accumulateDocumentViews:]): Add our docview to the array, call kids.
   4456         (-[WebFrame _documentViews]):  New helper to return all docviews.
   4457         (-[WebFrame _didFirstLayout]):  Same name change.
   4458         * WebView.subproj/WebFrameInternal.h:
   4459         * WebView.subproj/WebFramePrivate.h:
   4460         * WebView.subproj/WebHTMLView.m:  Removed redundant category decl.
   4461         (-[WebHTMLView _makeTextSmaller:]):  Implement new protocol.
   4462         (-[WebHTMLView _makeTextLarger:]):
   4463         (-[WebHTMLView _makeTextStandardSize:]):
   4464         (-[WebHTMLView _tracksCommonSizeFactor]):
   4465         * WebView.subproj/WebPDFRepresentation.m:  Tweak #imports.
   4466         * WebView.subproj/WebPDFView.h:
   4467         * WebView.subproj/WebPDFView.m:
   4468         (-[WebPDFView _menuItemsFromPDFKitForEvent:]):  No longer intercept context menu text sizing items.
   4469         (-[WebPDFView setDataSource:]):  No longer track the WebView's scaling factor.
   4470         (-[WebPDFView scrollPoint]):  Dig through PDFKit view tree to get real scroll position
   4471         (-[WebPDFView setScrollPoint:]):  Ditto
   4472         (-[WebPDFView viewState]):  Return bundle of viewing params
   4473         (-[WebPDFView setViewState:]):  Restore bundle of viewing params
   4474         (-[WebPDFView _makeTextSmaller:]):  Implement new text sizing protocol
   4475         (-[WebPDFView _makeTextLarger:]):
   4476         (-[WebPDFView _makeTextStandardSize:]):
   4477         (-[WebPDFView _tracksCommonSizeFactor]):
   4478         (-[WebPDFView _canMakeTextSmaller]):
   4479         (-[WebPDFView _canMakeTextLarger]):
   4480         (-[WebPDFView _canMakeTextStandardSize]):
   4481         * WebView.subproj/WebTextView.m:
   4482         (-[WebTextView _makeTextSmaller:]):  Implement new text sizing protocol
   4483         (-[WebTextView _makeTextLarger:]):
   4484         (-[WebTextView _makeTextStandardSize:]):
   4485         (-[WebTextView _tracksCommonSizeFactor]):
   4486         * WebView.subproj/WebView.m:
   4487         (-[WebView setTextSizeMultiplier:]):  Calling docViews is now more complicates than just posting
   4488            a notification to the frame.
   4489         (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:]):  Workhorse
   4490            that sends the text sizing method to the right doc views.
   4491         (-[WebView canMakeTextSmaller]):  Call workhorse.
   4492         (-[WebView canMakeTextLarger]):  Ditto
   4493         (-[WebView makeTextSmaller:]):  Ditto
   4494         (-[WebView makeTextLarger:]):  Ditto
   4495         (-[WebView canMakeTextStandardSize]):  Ditto
   4496         (-[WebView makeTextStandardSize:]):  Ditto
   4497 
   4498 2005-07-26  Justin Garcia  <justin.garcia (a] apple.com>
   4499 
   4500         Patch by Trey Matteson <trey (a] usa.net>
   4501 
   4502         Reviewed by John Sullivan.
   4503         
   4504         Fixed <http://bugs.webkit.org/show_bug.cgi?id=4072>
   4505         Pressing back in browser misses out a page
   4506         
   4507         * WebView.subproj/WebFrame.m:
   4508         (-[WebFrame _transitionToCommitted:]):  When reloading the same page or refreshing the
   4509         page, update the URL in the b/f item with the URL that we wind up at.  Due to cookies,
   4510         it might be different than the result we just got when we loaded the same page.
   4511 
   4512 2005-07-26  David Hyatt  <hyatt (a] apple.com>
   4513 
   4514 	Make WebHTMLView inherit from NSControl instead of NSView.
   4515 	This change is necessary because the theme renderer for
   4516 	WebCore that draws controls with the Aqua appearance does so
   4517 	using NSCells.  NSCells must be hosted within a control view
   4518 	in order to paint properly.
   4519 
   4520 	The method updateCell must be overridden because it wants to
   4521 	repaint the whole control when the windows resigns/becomes
   4522 	key, and this would result in behavior that we don't want
   4523 	(the repainting of the whole view).  We already have hooks
   4524 	in WebHTMLView for the window resigning/becoming key so
   4525 	we will do our proper control updating there instead (in a
   4526 	future patch).
   4527 
   4528         Reviewed by john
   4529 
   4530         * WebView.subproj/WebHTMLView.h:
   4531         * WebView.subproj/WebHTMLView.m:
   4532         (-[WebHTMLView updateCell:]):
   4533         
   4534 2005-07-26  John Sullivan  <sullivan (a] apple.com>
   4535 
   4536         Reviewed by Chris Blumenberg.
   4537         
   4538         - more work to wean form-related SPI from NSView. All that's left (but this is a big "all")
   4539         is viewForElement: and elementForView:        
   4540 
   4541         * WebCoreSupport.subproj/WebBridge.m:
   4542         (-[WebBridge textField:doCommandBySelector:]):
   4543         changed signature to pass along DOMElement* rather than NSView*
   4544         
   4545         * WebView.subproj/WebFormDelegate.h:
   4546         * WebView.subproj/WebFormDelegate.m:
   4547         (-[WebFormDelegate textField:doCommandBySelector:inFrame:]):
   4548         ditto
   4549 
   4550 2005-07-25  John Sullivan  <sullivan (a] apple.com>
   4551 
   4552         Reviewed by Darin Adler.
   4553         
   4554         - big hunk of weaning form-related SPI from NSView; autofill continues to
   4555         work (but only on tip of tree Safari)
   4556         
   4557         * WebCoreSupport.subproj/WebBridge.m:
   4558         (-[WebBridge textFieldDidBeginEditing:]):
   4559         changed name from controlTextXXX:, now takes a DOMHTMLInputElement*
   4560         (-[WebBridge textFieldDidEndEditing:]):
   4561         ditto
   4562         (-[WebBridge textDidChangeInTextField:]):
   4563         ditto
   4564         (-[WebBridge textDidChangeInTextArea:]):
   4565         changed name from textDidChange:, now takes a DOMHTMLTextAreaElement*
   4566         (-[WebBridge control:textShouldBeginEditing:]):
   4567         removed this method as it wasn't being used by autofill, and did nothing in WebKit
   4568         (-[WebBridge control:textShouldEndEditing:]):
   4569         ditto
   4570         (-[WebBridge textField:shouldHandleEvent:]):
   4571         changed name from control:textView:shouldHandleEvent:, now takes a DOMHTMLInputElement*.
   4572         The textView parameter wasn't being used, so I eliminated it.
   4573         
   4574         * WebView.subproj/WebFormDelegate.h:
   4575         * WebView.subproj/WebFormDelegate.m:
   4576         (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]):
   4577         (-[WebFormDelegate textFieldDidEndEditing:inFrame:]):
   4578         (-[WebFormDelegate control:textShouldBeginEditing:inFrame:]):
   4579         (-[WebFormDelegate control:textShouldEndEditing:inFrame:]):
   4580         (-[WebFormDelegate textDidChangeInTextField:inFrame:]):
   4581         (-[WebFormDelegate textDidChangeInTextArea:inFrame:]):
   4582         (-[WebFormDelegate textField:shouldHandleEvent:inFrame:]):
   4583         These all changed in the same way as the WebBridge methods
   4584         
   4585 
   4586 2005-07-25  Vicki Murley <vicki (a] apple.com>
   4587 
   4588         Reviewed by Darin.
   4589  
   4590 	- fixed <rdar://problem/3470523> Safari's user agent should be changed to say Intel rather 
   4591 	than PPC on Intel machines
   4592 
   4593         * WebView.subproj/WebView.m: add conditional #defines for "PPC" and "Intel"
   4594         (-[WebView userAgentForURL:]): use this variable when constructing the user agent string
   4595 
   4596 2005-07-24  Justin Garcia  <justin.garcia (a] apple.com>
   4597 
   4598         Reviewed by mjs
   4599         
   4600         - Fixes <rdar://problem/4120535> deleteToEndOfLine: does not delete thew newline when at the end of a line
   4601             Fix to match NSTextView.  Delete the next character if deleteToEndOfLine fails
   4602 
   4603         * WebView.subproj/WebHTMLView.m:
   4604         (-[WebHTMLView deleteToEndOfLine:]):
   4605 
   4606 2005-07-24  Justin Garcia  <justin.garcia (a] apple.com>
   4607 
   4608         Patch by Trey Matteson <trey (a] apple.com>
   4609 
   4610         Reviewed by john
   4611         
   4612         Fixes <http://bugs.webkit.org/show_bug.cgi?id=3953> back-forward items have wrong titles after sub-frame navigations
   4613 
   4614         This was caused by a mistaken data structure, where WebDataSource tried to keep a list of
   4615         b/f items it was responsible for.  The problem arose in the case of frames, where a subframe
   4616         was loaded with new content.  When this happens a fresh tree of b/f items is created,
   4617         but the reference in the DataSource still pointed to the old item.
   4618 
   4619         Since the WebFrame does a lot of work to track the current b/f item, the easiest thing is to
   4620         get rid of the DataSource's reference, and have it ask the WebFrame to set the title on the
   4621         right b/f item.
   4622 
   4623         * WebView.subproj/WebDataSource.m:
   4624         (-[WebDataSourcePrivate dealloc]):
   4625         (-[WebDataSource _setTitle:]):
   4626         * WebView.subproj/WebDataSourcePrivate.h:
   4627         * WebView.subproj/WebFrame.m:
   4628         (-[WebFrame _createItem:]):
   4629         (-[WebFrame _transitionToCommitted:]):
   4630         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
   4631         (-[WebFrame _setTitle:]):
   4632         * WebView.subproj/WebFramePrivate.h:
   4633 
   4634 2005-07-24  Justin Garcia  <justin.garcia (a] apple.com>
   4635 
   4636         Reviewed by kevin
   4637         
   4638         Fixed make clean problem
   4639 
   4640         * Makefile.am:
   4641 
   4642 2005-07-23  Justin Garcia  <justin.garcia (a] apple.com>
   4643 
   4644         Patch by <opendarwin.org (a] mitzpettel.com>
   4645 
   4646         Reviewed by darin and hyatt
   4647         
   4648         Fixes <http://bugs.webkit.org/show_bug.cgi?id=3862>
   4649         The fix for <http://bugs.webkit.org/show_bug.cgi?id=3545> enclosed each run of visually ordered
   4650         hebrew with LRO and PDF control characters, but adjusted the run's to and from to include those characters,
   4651         so that they would be rendered if the font includes a glyph for bidi control characters.
   4652         
   4653         Also adding a manual test
   4654 
   4655         * WebCoreSupport.subproj/WebTextRenderer.m:
   4656         (reverseCharactersInRun):
   4657 
   4658 2005-07-22  John Sullivan  <sullivan (a] apple.com>
   4659 
   4660         Reviewed by Justin Garcia.
   4661         
   4662         Mail (running on tip of tree WebKit) was running into an assertion I recently added.
   4663         The assertion is actually correct, catching an old bug in this code.
   4664 
   4665         * WebView.subproj/WebView.m:
   4666         (-[WebView selectedFrame]):
   4667         if the first responder is a WebFrameView, then we've found the WebFrameView we're 
   4668         looking for, and we shouldn't look at its superviews.
   4669 
   4670 2005-07-22  John Sullivan  <sullivan (a] apple.com>
   4671 
   4672         Reviewed by Chris Blumenberg.
   4673 
   4674         - some changes in the direction of weaning all the form-related SPI from NSView
   4675 
   4676         * PublicHeaderChangesFromTiger.txt:
   4677         noted that the WebCore change to add -[DOMHTMLInputElement isTextField] to
   4678         DOMExtensions.h is a public header change.
   4679 
   4680         * WebView.subproj/WebHTMLRepresentation.h:
   4681         * WebView.subproj/WebHTMLRepresentation.m:
   4682         (-[WebHTMLRepresentation viewForElement:]):
   4683         added viewForElement: as a stopgap measure. This allowed me to convert controlsInForm:
   4684         to return DOMElements rather than NSViews, while keeping autocomplete working in
   4685         Safari tip of tree. When I finish the SPI conversion I'll delete this method. Note that
   4686         from this point on, autocomplete will not work in Tiger Safari with tip of tree WebKit
   4687         (it will always fail to find anything to autocomplete)
   4688 
   4689 2005-07-21  Adele Peterson  <adele (a] apple.com>
   4690 
   4691         Reviewed by Darin.
   4692 
   4693         Changing temporary #ifndef to #if
   4694 
   4695         * WebCoreSupport.subproj/WebImageData.m:
   4696         (-[WebImageData _checkSolidColor:]):
   4697 
   4698 2005-07-21  Adele Peterson  <adele (a] apple.com>
   4699 
   4700         Reviewed by Chris Blumenberg.
   4701 
   4702         - fixed <rdar://problem/4132797> don't register thin PPC WebKit plug-ins
   4703         Merged fix for:
   4704         <rdar://problem/4127100> [WebKit] 8B1016: After installing Acrobat Reader, can no longer see pdf's in Safari
   4705 
   4706         * Plugins.subproj/WebBasePluginPackage.h: Added isNativeLibraryData method.
   4707         * Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage isNativeLibraryData:]): Added isNativeLibraryData method.
   4708         * Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]):
   4709           calls isNativeLibraryData to determine whether or not to register the plug-in.
   4710         * Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): ditto.
   4711         * WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]): added comment for #ifdef.
   4712 
   4713 2005-07-21  Geoffrey Garen  <ggaren (a] apple.com>
   4714 
   4715         * WebKit.pbproj/project.pbxproj: Removed.
   4716 
   4717 2005-07-21  Geoffrey Garen  <ggaren (a] apple.com>
   4718 
   4719         * WebKit.xcodeproj/.cvsignore: Added.
   4720 
   4721 2005-07-21  Geoffrey Garen  <ggaren (a] apple.com>
   4722 
   4723         * WebKit.xcodeproj/project.pbxproj: Added.
   4724 
   4725 2005-07-21  Geoffrey Garen  <ggaren (a] apple.com>
   4726 
   4727         * Makefile.am:
   4728 
   4729 2005-07-20  John Sullivan  <sullivan (a] apple.com>
   4730 
   4731         Reviewed by Vicki Murley.
   4732 
   4733         - removed some form-related methods that weren't being used anywhere, in preparation
   4734         for weaning WebKit's WebFormDelegate protocol from NSView.
   4735 
   4736         * WebCoreSupport.subproj/WebBridge.m:
   4737         * WebView.subproj/WebFormDelegate.h:
   4738         * WebView.subproj/WebFormDelegate.m:
   4739         removed these methods:
   4740         -control:didFailToFormatString:errorDescription:
   4741         -control:didFailToValidatePartialString:errorDescription:
   4742         -control:isValidObject:
   4743 
   4744 2005-07-20  Adele Peterson  <adele (a] apple.com>
   4745 
   4746           Merged fix for:
   4747           <rdar://problem/4125127> [WebKit] horizontal rulers don't render on Safari on web.apple.com
   4748 
   4749           * WebCoreSupport.subproj/WebImageData.m:
   4750           (-[WebImageData _checkSolidColor:]):
   4751 
   4752 2005-07-20  Adele Peterson  <adele (a] apple.com>
   4753 
   4754         Merged fix for :
   4755         <rdar://problem/4118278> mail divide by zero navigating messages
   4756   
   4757         * WebCoreSupport.subproj/WebTextRenderer.m:
   4758         (-[WebTextRenderer _extendGlyphToWidthMapToInclude:font:]):
   4759 
   4760 2005-07-20  John Sullivan  <sullivan (a] apple.com>
   4761 
   4762         Reviewed by Adele Peterson.
   4763         
   4764         - added -[WebView selectedFrame] to SPI (pending public API), needed for 4180958
   4765 
   4766         * WebView.subproj/WebView.m:
   4767         (-[WebView selectedFrame]):
   4768         new method, extracted from _selectedOrMainFrame
   4769         (-[WebView _selectedOrMainFrame]):
   4770         now calls extracted method
   4771         
   4772         * WebView.subproj/WebViewPrivate.h:
   4773         add -selectedFrame to PendingPublic category
   4774 
   4775 2005-07-19  John Sullivan  <sullivan (a] apple.com>
   4776 
   4777         Reviewed by Darin Adler.
   4778         
   4779         - cleaned up code related to dealing with the "selected frame"; fixes radar bugs 4118830 and 4118820
   4780 
   4781         * WebView.subproj/WebTextView.m:
   4782         (-[WebTextView resignFirstResponder]):
   4783         call deselectAll here instead of replicating its guts, just for clarity
   4784         
   4785         * WebView.subproj/WebViewInternal.h:
   4786         eliminated category WebInternal; all of these methods were used only inside WebView.m, so I moved
   4787         them into the existing category WebFileInternal that was declared and implemented in WebView.m
   4788         
   4789         * WebView.subproj/WebView.m:
   4790         (-[WebView searchFor:direction:caseSensitive:wrap:]):
   4791         updated for name changes. Also, uses new _deselectFrame: to clear the selection if the found
   4792         text is in a different frame.
   4793         (-[WebView pasteboardTypesForSelection]):
   4794         (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
   4795         (-[WebView setSelectedDOMRange:affinity:]):
   4796         (-[WebView selectedDOMRange]):
   4797         (-[WebView selectionAffinity]):
   4798         (-[WebView setTypingStyle:]):
   4799         (-[WebView typingStyle]):
   4800         (-[WebView styleDeclarationWithText:]):        
   4801         (-[WebView replaceSelectionWithNode:]):
   4802         (-[WebView replaceSelectionWithText:]):
   4803         (-[WebView replaceSelectionWithMarkupString:]):
   4804         (-[WebView replaceSelectionWithArchive:]):
   4805         (-[WebView deleteSelection]):
   4806         (-[WebView applyStyle:]):
   4807         updated for name changes only
   4808         
   4809         (-[WebView _frameIsSelected:]):
   4810         new method, returns YES if given frame has a non-zero-length selection
   4811         (-[WebView _deselectFrame:]):
   4812         new method, clears selection from given frame
   4813         (-[WebView _findSelectedFrameStartingFromFrame:]):
   4814         new method, recursive helper used by _findSelectedFrame
   4815         (-[WebView _findSelectedFrame]):
   4816         new method, finds first frame that returns YES for _frameIsSelected, or nil
   4817         (-[WebView _debugCollectSelectedFramesIntoArray:startingFromFrame:]):
   4818         new method, recursive helper used by _debugCheckForMultipleSelectedFrames
   4819         (-[WebView _debugCheckForMultipleSelectedFrames]):
   4820         new method for debugging, fires an assertion if there's more than one selected frame.
   4821         (-[WebView _selectedOrMainFrame]):
   4822         renamed from _frameForCurrentSelection, which was a misleading name since the returned
   4823         frame does not necessarily have a selection (or even focus). Now checks for a selected
   4824         but non-focused frame if the first responder is not in any frame. Also, moved in file
   4825         from WebInternal category to WebFileInternal category.
   4826         (-[WebView _bridgeForSelectedOrMainFrame]):
   4827         renamed from _bridgeForCurrentSelection, which was a misleading name for the same
   4828         reasons as _frameForCurrentSelection. Also, moved in file from WebInternal category to
   4829         WebFileInternal category.
   4830         (-[WebView _isLoading]):
   4831         (-[WebView _frameViewAtWindowPoint:]):
   4832         (-[WebView _bridgeAtPoint:]):
   4833         just moved in file from WebInternal category to WebFileInternal category
   4834 
   4835 2005-07-19  Darin Adler  <darin (a] apple.com>
   4836 
   4837         Reviewed by Geoff Garen.
   4838 
   4839         - improve handling of plug-ins when the WebView or a superview is hidden with -[NSView setHidden]
   4840 
   4841         * Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):
   4842         Add "hidden" to the list of reasons to clip out all plug-in drawing.
   4843 
   4844 2005-07-18  John Sullivan  <sullivan (a] apple.com>
   4845         
   4846         Written by Trey Matteson  <trey (a] usa.net>
   4847         Reviewed by John Sullivan.
   4848 
   4849         Fixed http://bugs.webkit.org/show_bug.cgi?id=4049
   4850           scroll position not restored when going back/forward at ebay
   4851         Fixed http://bugs.webkit.org/show_bug.cgi?id=4061
   4852           When going back/forward to some pages, they redraw at top before restoring scroll position
   4853 
   4854         The short story is that attempting to restore the scroll position
   4855         at the time when the first layout finishes addresses both of these
   4856         issues.  An explanation of the underlying race condition is in
   4857         a large comment near -_restoreScrollPosition.
   4858 
   4859         * WebCoreSupport.subproj/WebBridge.m:
   4860         (-[WebBridge didFirstLayout]):  Pass through to WebFrame.
   4861         * WebView.subproj/WebFrame.m:
   4862         (-[WebFrame _transitionToCommitted:]):  Get rid of attempt to
   4863           restoreScrollPosition that never did anything because the
   4864           docView was always 0x0 size at that point.
   4865         (-[WebFrame _opened]):  Get rid of redundant call to restoreScrollPosition.
   4866           The imminent call to layoutCompleted makes the same call.
   4867         (-[WebFrame _didFirstLayout]):  Restore the scroll position on
   4868           first layout, if we're doing a b/f nav.
   4869         * WebView.subproj/WebFrameInternal.h:
   4870 
   4871 2005-07-18  John Sullivan  <sullivan (a] apple.com>
   4872 
   4873         Reviewed by Darin Adler.
   4874 
   4875         - fixed these bugs:
   4876         <rdar://problem/4158121> context menu in PDF view should contain the selection-based items like Copy
   4877         <rdar://problem/4184691> WebPDFView should conform to the WebDocumentElement protocol
   4878         <rdar://problem/4184663> "Search in Spotlight" is present but dimmed in context menu for plain-text documents
   4879 
   4880         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   4881         (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
   4882         added ASSERT and comments
   4883 
   4884         * WebView.subproj/WebHTMLView.m:
   4885         (-[WebHTMLView _searchWithGoogleFromMenu:]):
   4886         removed this method (now handled by WebView)
   4887         (-[WebHTMLView _searchWithSpotlightFromMenu:]):
   4888         ditto
   4889         (-[WebHTMLView validateUserInterfaceItem:]):
   4890         removed validation for removed items. The validation wasn't necessary anyway, since we only put these items
   4891         in the menu in the case where they should be enabled.
   4892 
   4893         * WebView.subproj/WebPDFView.h:
   4894         now conforms to WebDocumentElement protocol (which lets [WebView elementAtPoint:] work better)
   4895         * WebView.subproj/WebPDFView.m:
   4896         (-[WebPDFView copy:]):
   4897         added, hands off to PDFView, needed to enable Copy in context menu
   4898         (-[WebPDFView _pointIsInSelection:]):
   4899         new method, checks whether given point is in the selected bounds
   4900         (-[WebPDFView elementAtPoint:]):
   4901         add WebElementIsSelectedKey to returned element
   4902         (-[WebPDFView menuForEvent:]):
   4903         use actual point instead of dummy placeholder, now that we have code that pays attention to the point
   4904 
   4905         * WebView.subproj/WebView.m:
   4906         (-[WebView _searchWithGoogleFromMenu:]):
   4907         moved here from WebHTMLView so it will work for any documentView that conforms to WebDocumentText.
   4908         Rewrote slightly to be non-WebHTMLView-specific. (This menu item was always enabled in Safari because
   4909         Safari replaces its action, but it would not have been always enabled in other WebKit clients, though
   4910         it should have been.)
   4911         (-[WebView _searchWithSpotlightFromMenu:]):
   4912         moved here from WebHTMLView so it will work for any documentView that conforms to WebDocumentText.
   4913         Rewrote slightly to be non-WebHTMLView-specific.
   4914 
   4915 2005-07-18  John Sullivan  <sullivan (a] apple.com>
   4916 
   4917         Reviewed by Richard Williamson.
   4918         
   4919         - fixed <rdar://problem/4184366> WebPDFView should conform to the WebDocumentSelection protocol
   4920 
   4921         * Misc.subproj/WebNSAttributedStringExtras.h: Added.
   4922         * Misc.subproj/WebNSAttributedStringExtras.m: Added.
   4923         (-[NSAttributedString _web_attributedStringByStrippingAttachmentCharacters]):
   4924         New category on NSAttributedString, initially contains this one method that had been in WebHTMLView.
   4925         
   4926         * WebView.subproj/WebHTMLView.m:
   4927         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
   4928         now uses _web_attributedStringByStrippingAttachmentCharacters
   4929         
   4930         * WebView.subproj/WebPDFView.h:
   4931         now conforms to WebDocumentSelection protocol
   4932         * WebView.subproj/WebPDFView.m:
   4933         (-[WebPDFView selectionRect]):
   4934         new, implementation of WebDocumentSelection protocol method
   4935         (-[WebPDFView pasteboardTypesForSelection]):
   4936         ditto
   4937         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
   4938         ditto
   4939 
   4940         * WebKit.pbproj/project.pbxproj:
   4941         updated for new files
   4942 
   4943 2005-07-18  John Sullivan  <sullivan (a] apple.com>
   4944 
   4945         Reviewed by Chris Blumenberg.
   4946         
   4947         - some refactoring cleanup in the selection/searching code
   4948 
   4949         * Misc.subproj/WebSearchableTextView.h:
   4950         moved WebDocumentSelection protocol conformation to this class, was in subclass WebTextView
   4951         * Misc.subproj/WebSearchableTextView.m:
   4952         (-[WebSearchableTextView selectionRect]):
   4953         new method (moved here from Safari) to return a single rect encompassing all selected text
   4954         (-[WebSearchableTextView pasteboardTypesForSelection]):
   4955         moved here from WebTextView
   4956         (-[WebSearchableTextView writeSelectionWithPasteboardTypes:toPasteboard:]):
   4957         ditto
   4958         
   4959         * WebView.subproj/WebDocumentInternal.h:
   4960         moved WebDocumentSelection protocol out of here
   4961         
   4962         * WebView.subproj/WebDocumentPrivate.h:
   4963         moved WebDocumentSelection protocol into here, added selectionRect method
   4964         
   4965         * WebView.subproj/WebHTMLView.m:
   4966         (-[WebHTMLView selectionRect]):
   4967         new method, calls existing bridge method formerly called by _selectionRect
   4968         (-[WebHTMLView _selectionRect]):
   4969         now calls [self selectionRect]. We can't just delete _selectionRect because it's used by Mail.
   4970         
   4971         * WebView.subproj/WebHTMLViewPrivate.h:
   4972         removed _selectionRect since it's in WebDocumentSelection now
   4973         
   4974         * WebView.subproj/WebTextView.h:
   4975         removed WebDocumentSelection from protocol list since it's in superclass now
   4976         
   4977         * WebView.subproj/WebTextView.m:
   4978         removed old WebDocumentSelection methods because they are in superclass now
   4979 
   4980 2005-07-15  Adele Peterson  <adele (a] apple.com>
   4981 
   4982         Written by Trey Matteson  <trey (a] usa.net>
   4983         Reviewed by John Sullivan.
   4984 
   4985         Fixed http://bugs.webkit.org/show_bug.cgi?id=3910 - REGRESSION: Replying "Cancel" to the form repost nag leaves wrong b/f cursor
   4986 
   4987         * WebView.subproj/WebFrame.m:
   4988         (-[WebFrame _resetBackForwardList]):  new helper method
   4989         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
   4990           If the delegate bailed on the navigation, tell the main frame
   4991           to reset the b/f cursor back to where it was before we started.
   4992 
   4993 2005-07-15  John Sullivan  <sullivan (a] apple.com>
   4994 
   4995         Written by Trey Matteson
   4996         Reviewed by me.
   4997 
   4998         Fix for http://bugs.webkit.org/show_bug.cgi?id=4013
   4999                 text find doesn't wrap in PDF files
   5000 
   5001         This just works once WebPDFView implements the WebDocumentText protocol, which is
   5002         mostly just a matter of forwarding the methods to PDFKit appropriately.
   5003 
   5004         * WebView.subproj/WebPDFView.h:
   5005         * WebView.subproj/WebPDFView.m:
   5006         (-[WebPDFView supportsTextEncoding]):
   5007         (-[WebPDFView string]):
   5008         (-[WebPDFView attributedString]):
   5009         (-[WebPDFView selectedString]):
   5010         (-[WebPDFView selectedAttributedString]):
   5011         (-[WebPDFView selectAll]):
   5012         (-[WebPDFView deselectAll]):
   5013 
   5014 2005-07-15  John Sullivan  <sullivan (a] apple.com>
   5015 
   5016         Reviewed by Kevin Decker.
   5017         
   5018         - fixed <rdar://problem/4181884> Searching for text that overlaps selection works 
   5019         differently in PDFView than in HTMLView
   5020 
   5021         * WebView.subproj/WebPDFView.m:
   5022         (PDFSelectionsAreEqual):
   5023         new function, stand-in for nonexistent -[PDFSelection isEqual:] since calling isEqual:
   5024         on two identical PDFSelections returns NO
   5025         (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
   5026         Make search algorithm match that in WebCore: initially search inside selection, then check for the case
   5027         where the found text exactly matches the previous selection, and search from past the selection if so.
   5028         The implementation is slightly more complicated than it should be due to PDFKit API limitations (about
   5029         which I added FIXMEs and filed bugs)
   5030 
   5031 2005-07-15  John Sullivan  <sullivan (a] apple.com>
   5032 
   5033         Reviewed by Maciej Stachowiak.
   5034         
   5035         - fixed these bugs:
   5036         <rdar://problem/4181875> Searching for text that overlaps selection works differently in WebTextView than in HTMLView
   5037         <rdar://problem/3393678> Find not finding text in plain (non-HTML) if all text is selected
   5038 
   5039         * Misc.subproj/WebSearchableTextView.m:
   5040         (-[NSString findString:selectedRange:options:wrap:]):
   5041         Make search algorithm match that in WebCore: initially search inside selection, then check for the case
   5042         where the found text exactly matches the previous selection, and search from past the selection if so.
   5043 
   5044 2005-07-14  John Sullivan  <sullivan (a] apple.com>
   5045 
   5046         Reviewed by Dave Hyatt.
   5047 
   5048         - WebKit part of fix for: 
   5049         <rdar://problem/4181227> webpages incorrectly use standard instead of secondary highlighting in certain cases
   5050 
   5051         * WebCoreSupport.subproj/WebBridge.m:
   5052         (-[WebBridge formControlIsResigningFirstResponder:]):
   5053         Implementation of new method defined in WebCore, passes call along to WebHTMLView
   5054         
   5055         * WebView.subproj/WebHTMLViewInternal.h:
   5056         declare _formControlIsResigningFirstResponder: so bridge can call it
   5057 
   5058         * WebView.subproj/WebHTMLView.m:
   5059         (-[WebHTMLView updateFocusState]):
   5060         just moved in file so it could be called from a different category
   5061         (-[WebHTMLView _formControlIsResigningFirstResponder:]):
   5062         new method, updates focus state
   5063 
   5064 2005-07-14  John Sullivan  <sullivan (a] apple.com>
   5065 
   5066 	added missing #import to fix build
   5067 	* WebView.subproj/WebPDFView.m
   5068 
   5069 2005-07-14  Kevin Decker  <kdecker (a] apple.com>
   5070 
   5071         Reviewed by cblu
   5072 
   5073 	Fixed: <rdar://problem/4122282> clicking a link in an PDF file opens the link with NSWorkspace without the usual security checks or WebView delegate control
   5074 
   5075         * WebView.subproj/WebFrame.m:
   5076         (-[WebFrame _safeLoadURL:]): added
   5077         * WebView.subproj/WebFrameInternal.h:
   5078         * WebView.subproj/WebPDFView.m:
   5079         (-[WebPDFView initWithFrame:]):
   5080         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): prevents evilness with a call to _safeLoadURL
   5081         * WebView.subproj/WebTextView.m:
   5082         (-[WebTextView clickedOnLink:atIndex:]): factored calling out to the bridge, and instead call _safeLoadURL
   5083 
   5084 2005-07-14  Vicki Murley  <vicki (a] apple.com>
   5085 
   5086         Reviewed by Kocienda.
   5087 
   5088 	- WebKit part of fix for  <rdar://problem/4172380> [GENENTECH] window.opener 
   5089 	not available when child opened via target="_new"
   5090 
   5091 	Add a setOpener function to the WebCore bridge, and call this function when opening
   5092 	new windows through Web Kit.
   5093 
   5094         * WebView.subproj/WebFrame.m:
   5095         (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
   5096 
   5097 2005-07-13  Justin Garcia  <justin.garcia (a] apple.com>
   5098 
   5099         Reviewed by John
   5100         
   5101         Rolling in changes necessary to build with newer versions of gcc 4.0
   5102 
   5103         * History.subproj/WebHistoryItem.m:
   5104         (-[WebHistoryItem copyWithZone:]):
   5105         * Misc.subproj/WebNSPasteboardExtras.m:
   5106         (-[NSPasteboard _web_writeImage:URL:title:archive:types:]):
   5107         * Misc.subproj/WebNSURLExtras.m:
   5108         (-[NSURL _web_URLWithLowercasedScheme]):
   5109         (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
   5110         * WebCoreSupport.subproj/WebBridge.m:
   5111         (-[WebBridge MIMETypeForPath:]):
   5112         * WebCoreSupport.subproj/WebImageRendererFactory.m:
   5113         (-[WebImageRendererFactory imageRendererWithBytes:length:MIMEType:]):
   5114         * WebCoreSupport.subproj/WebTextRenderer.m:
   5115         (-[WebTextRenderer initWithFont:usingPrinterFont:]):
   5116         * WebView.subproj/WebFrame.m:
   5117         (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
   5118         * WebView.subproj/WebHTMLView.m:
   5119         (-[WebHTMLView _styleFromFontAttributes:]):
   5120         * WebView.subproj/WebView.m:
   5121         (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]):
   5122         (-[WebView mainFrameTitle]):
   5123 
   5124 2005-07-13  John Sullivan  <sullivan (a] apple.com>
   5125 
   5126         Reviewed by Maciej Stachowiak.
   5127 
   5128         - cleaned up Find-related experimental code that I checked in a while back
   5129 
   5130         * WebView.subproj/WebHTMLView.m:
   5131         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]):
   5132         remove variant of this method that had findInSelection flag; this method is now
   5133         the same as it was on Tiger.
   5134         
   5135         * WebView.subproj/WebView.m:
   5136         (-[WebView searchFor:direction:caseSensitive:wrap:]):
   5137         ditto
   5138 
   5139 2005-07-12  Geoffrey Garen  <ggaren (a] apple.com>
   5140 
   5141         -rolled in patch by opendarwin.org (a] mitzpettel.com 
   5142         for http://bugs.webkit.org/show_bug.cgi?id=3435
   5143         Parentheses are backwards in Hebrew text (no bidi mirroring?)
   5144         
   5145         Reviewed by mjs.
   5146 
   5147         Layout test added to WebCore.
   5148 
   5149         * WebCoreSupport.subproj/WebTextRenderer.h:
   5150         * WebCoreSupport.subproj/WebTextRenderer.m:
   5151         (-[WebTextRenderer _initializeATSUStyle]):
   5152         (applyMirroringToRun):
   5153         (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]):
   5154         (-[WebTextRenderer _ATSU_drawRun:style:geometry:]):
   5155         (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   5156 
   5157 2005-07-12  Ken Kocienda  <kocienda (a] apple.com>
   5158 
   5159         Reviewed by Chris Blumenberg
   5160 
   5161         * WebCoreSupport.subproj/WebBridge.m: Removed some glue that allowed one
   5162         of two unicode (TEC or ICU ) to be chosen at runtime. I just added this
   5163         dual support yesterday, and while Maciej and I agreed that it was good
   5164         to land in the tree in case we run into problems in the near future, we
   5165         also agreed that cutting over to using ICU full time right now is
   5166         probably the best way to find bugs.
   5167 
   5168 2005-07-11  Ken Kocienda  <kocienda (a] apple.com>
   5169 
   5170         Reviewed by Richard
   5171 
   5172         * WebCoreSupport.subproj/WebBridge.m:
   5173         (+[WebBridge setTextConversionMethod:]): New method to support switching text conversion method.
   5174         (+[WebBridge textConversionMethod]): Returns current text conversion method.
   5175 
   5176 2005-07-11  Kevin Decker  <kdecker (a] apple.com>
   5177 
   5178         Reviewed by cblu and mjs.
   5179 
   5180 	Fixed: <rdar://problem/4099552> REGRESSION: Safari 1.3 Netscape API NPN_PostURL[Notify] no longer allows manual headers
   5181 	
   5182 	Most plugins (flash) send 2 CRFL's between the header and body of their POST requests, while the adboe plugin sends two LF's. This caused us to send custom headers as part of the actual POST data itself, and correspondently, would skew Content-Length.
   5183 
   5184         * Plugins.subproj/WebBaseNetscapePluginView.m:
   5185         (-[NSData _web_locationAfterFirstBlankLine]): Look for two LF's as well
   5186 
   5187 2005-07-09  Maciej Stachowiak  <mjs (a] apple.com>
   5188 
   5189         - back out my revent page cache changes, turns out they cause a
   5190 	major performance regression on PLT
   5191 
   5192         * WebView.subproj/WebFrame.m:
   5193         (-[WebFrame _purgePageCache]):
   5194 
   5195 2005-07-09  Maciej Stachowiak  <mjs (a] apple.com>
   5196 
   5197         Reviewed by hyatt.
   5198 
   5199 	Replace int with unsigned, to avoid going into a huge loop when
   5200 	back list count is 0.
   5201 
   5202         * WebView.subproj/WebFrame.m:
   5203         (-[WebFrame _purgePageCache]):
   5204 
   5205 2005-07-09  Maciej Stachowiak  <mjs (a] apple.com>
   5206 
   5207         - fixed broken Development build
   5208 
   5209         * WebView.subproj/WebFrame.m:
   5210         (-[WebFrame _purgePageCache]):
   5211 
   5212 2005-07-09  Maciej Stachowiak  <mjs (a] apple.com>
   5213 
   5214         Reviewed by hyatt.
   5215 
   5216 	- fix page cache purging logic; this gets rid of a bug where the
   5217 	page cache would grow without bound if the oldest page cache item
   5218 	was the snapback item, and changed the rule a bit so page cache
   5219 	items farther back than the max size get purged, even if fewer
   5220 	than the max size are in current use.
   5221 
   5222         * WebView.subproj/WebFrame.m:
   5223         (-[WebFrame _purgePageCache]):
   5224 
   5225 2005-07-08  Geoffrey Garen  <ggaren (a] apple.com>
   5226 
   5227         Rolled in patch by opendarwin.org (a] mitzpettel.com
   5228 
   5229         -fixes http://bugs.webkit.org/show_bug.cgi?id=3818
   5230         Fallback font doesn't have requested weight in ATSUI-rendered text
   5231 
   5232         (See WebCore Changelog for layout test)
   5233 
   5234         Reviewed by mjs.
   5235 
   5236         * WebCoreSupport.subproj/WebTextRenderer.m:
   5237         (-[WebTextRenderer _createATSUTextLayoutForRun:style:]):
   5238 
   5239 2005-07-05  Adele Peterson  <adele (a] apple.com>
   5240 
   5241        Rolling out changes for <rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)
   5242        since it caused a 2% performance regression.
   5243 
   5244         * WebCoreSupport.subproj/WebTextRenderer.m:
   5245         (isSpace):
   5246         (-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]):
   5247         (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]):
   5248         (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]):
   5249         (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   5250         (initializeCharacterWidthIterator):
   5251         (widthForNextCharacter):
   5252 
   5253 2005-07-05  John Sullivan  <sullivan (a] apple.com>
   5254 
   5255         Reviewed by Chris Blumenberg.
   5256         
   5257         - fixed <rdar://problem/4158230> Zoom In/Zoom Out in PDF context menu don't update window's notion of text size
   5258 
   5259         * WebView.subproj/WebPDFView.m:
   5260         (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
   5261         Redirect Actual Size, Zoom In, and Zoom Out context menu items so that they behave exactly like Make Text Standard Size,
   5262         Make Text Larger, and Make Text Smaller.
   5263 
   5264 2005-07-01  John Sullivan  <sullivan (a] apple.com>
   5265 
   5266         Reviewed by Darin Adler.
   5267         
   5268         - fixed http://bugs.webkit.org/show_bug.cgi?id=3711: Displayed PDF have limited options in contextual menu
   5269         
   5270         This was a problem with using Tiger's version of Safari with tip of tree WebKit.
   5271 
   5272         * WebView.subproj/WebPDFView.m:
   5273         (-[WebPDFView _anyPDFTagsFoundInMenu:]):
   5274         new method, returns YES if the menu contains any items with any of the new PDF-related tags.
   5275         (-[WebPDFView menuForEvent:]):
   5276         If the executable was linked on Tiger or older (but it will never be older, since this code is
   5277         new to Tiger), force all of the PDF-related items into the menu if none of them were there 
   5278         after processing by the delegate.
   5279 
   5280 2005-06-30  Darin Adler  <darin (a] apple.com>
   5281 
   5282         Reviewed by John Sullivan.
   5283 
   5284         - fixed <http://bugs.webkit.org/show_bug.cgi?id=3774>
   5285           do renaming so that loaders are called "loader", not "client" or "delegate"
   5286 
   5287         * Misc.subproj/WebIconLoader.h:
   5288         * Plugins.subproj/WebNetscapePluginStream.h:
   5289         * Plugins.subproj/WebNetscapePluginStream.m:
   5290         (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
   5291         (-[WebNetscapePluginStream start]):
   5292         (-[WebNetscapePlugInStreamLoader didFinishLoading]):
   5293         (-[WebNetscapePlugInStreamLoader didFailWithError:]):
   5294         (-[WebNetscapePlugInStreamLoader cancelWithError:]):
   5295         * WebCoreSupport.subproj/WebBridge.m:
   5296         (-[WebBridge startLoadingResource:withURL:customHeaders:]):
   5297         (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]):
   5298         (-[WebBridge canRunModalNow]):
   5299         * WebCoreSupport.subproj/WebSubresourceClient.h: Removed.
   5300         * WebCoreSupport.subproj/WebSubresourceClient.m: Removed.
   5301         * WebCoreSupport.subproj/WebSubresourceLoader.h:
   5302         * WebCoreSupport.subproj/WebSubresourceLoader.m:
   5303         (-[WebSubresourceLoader initWithLoader:dataSource:]):
   5304         (-[WebSubresourceLoader dealloc]):
   5305         (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
   5306         (+[WebSubresourceLoader startLoadingResource:withURL:customHeaders:referrer:forDataSource:]):
   5307         (+[WebSubresourceLoader startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]):
   5308         (-[WebSubresourceLoader didReceiveResponse:]):
   5309         (-[WebSubresourceLoader didReceiveData:lengthReceived:]):
   5310         (-[WebSubresourceLoader didFinishLoading]):
   5311         (-[WebSubresourceLoader didFailWithError:]):
   5312         (-[WebSubresourceLoader cancel]):
   5313         * WebKit.pbproj/project.pbxproj:
   5314         * WebView.subproj/WebBaseResourceHandleDelegate.h: Removed.
   5315         * WebView.subproj/WebBaseResourceHandleDelegate.m: Removed.
   5316         * WebView.subproj/WebDataSource.m:
   5317         (-[WebDataSourcePrivate dealloc]):
   5318         (-[WebDataSource _setLoading:]):
   5319         (-[WebDataSource _updateLoading]):
   5320         (-[WebDataSource _setPrimaryLoadComplete:]):
   5321         (-[WebDataSource _startLoading:]):
   5322         (-[WebDataSource _addSubresourceLoader:]):
   5323         (-[WebDataSource _removeSubresourceLoader:]):
   5324         (-[WebDataSource _addPlugInStreamLoader:]):
   5325         (-[WebDataSource _removePlugInStreamLoader:]):
   5326         (-[WebDataSource _stopLoadingInternal]):
   5327         (-[WebDataSource _defersCallbacksChanged]):
   5328         (-[WebDataSource _stopLoadingWithError:]):
   5329         (-[WebDataSource data]):
   5330         (-[WebDataSource isLoading]):
   5331         * WebView.subproj/WebDataSourcePrivate.h:
   5332         * WebView.subproj/WebLoader.h:
   5333         * WebView.subproj/WebLoader.m:
   5334         * WebView.subproj/WebMainResourceClient.h: Removed.
   5335         * WebView.subproj/WebMainResourceClient.m: Removed.
   5336         * WebView.subproj/WebMainResourceLoader.h:
   5337         * WebView.subproj/WebMainResourceLoader.m:
   5338         (-[WebMainResourceLoader didReceiveResponse:]):
   5339 
   5340 2005-06-29  David Harrison  <harrison (a] apple.com>
   5341 
   5342         Reviewed by Dave Hyatt (rendering) and Maciej (editing).
   5343 
   5344         Test cases added:  Coming soon.  Will include with next round of changes for this bug.
   5345 
   5346         This is the first checkin for...
   5347         
   5348         <rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)
   5349         
   5350         Basic strategy is to put tabs into spans with white-space:pre style, and
   5351         render them with tabs stops every 8th space, where the space width and
   5352         the left margin are those of the enclosing block.
   5353         
   5354         What's left is to switch to implement white-space:pre-wrap so
   5355         that we can coalesce consecutive tabs while maintaining proper
   5356         line breaking.  That will keep the markup smaller.
   5357 
   5358         * WebCoreSupport.subproj/WebTextRenderer.m:
   5359         (isSpace):
   5360         (-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]):
   5361         (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]):
   5362         (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]):
   5363         (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   5364         (initializeCharacterWidthIterator):
   5365         (widthForNextCharacter):
   5366 
   5367 2005-06-29  John Sullivan  <sullivan (a] apple.com>
   5368 
   5369         Reviewed by Kevin.
   5370         
   5371         - deleted some never-used stub code
   5372 
   5373         * WebView.subproj/WebView.m:
   5374         * WebView.subproj/WebViewInternal.h:
   5375         * WebView.subproj/WebViewPrivate.h:
   5376 
   5377 2005-06-27  Justin Garcia  <justin.garcia (a] apple.com>
   5378 
   5379         Patch by Anders Carlsson <andersca (a] mac.com>
   5380 
   5381         Reviewed by Darin.
   5382 
   5383         - Fixes <http://bugs.webkit.org/show_bug.cgi?id=3489>
   5384         WebView's setSelectedDOMRange doesn't not implement clearing the selection as described in the WebView documentation:
   5385         <http://developer.apple.com/documentation/Cocoa/Reference/WebKit/ObjC_classic/Classes/WebView.html>
   5386 	
   5387         * WebView.subproj/WebView.m:
   5388         (-[WebView setSelectedDOMRange:affinity:]):
   5389         If range is nil, call deselectText.
   5390 
   5391 2005-06-24  Justin Garcia  <justin.garcia (a] apple.com>
   5392 
   5393         Patch contributed by Duncan Wilcox <duncan (a] mclink.it>
   5394 
   5395         Reviewed by Darin
   5396 
   5397         - Fixed <http://bugs.webkit.org/show_bug.cgi?id=3535>
   5398             Spelling suggestions in the context menu don't call the should* delegate methods
   5399 
   5400         * WebView.subproj/WebHTMLView.m:
   5401         (-[WebHTMLView _changeSpellingFromMenu:]):
   5402         give delegate's webView:shouldInsertText:replacingDOMRange:givenAction: a chance
   5403         to prevent replacing of selected text
   5404 
   5405 2005-06-22  John Sullivan  <sullivan (a] apple.com>
   5406 
   5407         Reviewed by Chris Blumenberg.
   5408         
   5409         - fixed <rdar://problem/3764645> please add a way to allow WebKit clients to override the WebPDFView context menu
   5410 
   5411         * PublicHeaderChangesFromTiger.txt: Added.
   5412         New file to keep track of changes made to public headers that haven't been through API review yet.
   5413         Initially lists the WebMenuItem enum tags added to WebUIDelegate.h as part of this change.
   5414         
   5415         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   5416         (-[WebDefaultUIDelegate appendDefaultItems:toArray:]):
   5417         new method, handles initial separator
   5418         (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
   5419         now has defaultMenuItems: parameter. Any menu items in this array are appended at the end of
   5420         the standard set.
   5421         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
   5422         ditto
   5423         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
   5424         This had a defaultMenuItems parameter before but it was always nil. Now it passes the defaultMenuItems
   5425         parameter on to the two methods that construct lists (one for editing, the other for viewing). Also
   5426         tweaked variable name and type for clarity.
   5427         
   5428         * WebView.subproj/WebHTMLView.m:
   5429         (-[WebHTMLView menuForEvent:]):
   5430         passes nil for new defaultItems parameter of _menuForElement:
   5431         
   5432         * WebView.subproj/WebImageView.m:
   5433         (-[WebImageView menuForEvent:]):
   5434         ditto
   5435         
   5436         * WebView.subproj/WebTextView.m:
   5437         (-[WebTextView menuForEvent:]):
   5438         ditto
   5439 
   5440         * WebView.subproj/WebPDFView.m:
   5441         (-[WebPDFView elementAtPoint:]):
   5442         new method to create the element dictionary needed for _menuForElement:defaultItems:. Only supplies the
   5443         webFrame at this point.
   5444         (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
   5445         new method to return copies of the menu items that PDFKit would include in the context menu, with
   5446         WebKit tags applied
   5447         (-[WebPDFView menuForEvent:]):
   5448         now calls standard WebKit context menu mechanism, so clients' delegates can modify the context menu as
   5449         desired. The initial set of items are the ones WebKit was already displaying for PDF context menus.
   5450         
   5451         * WebView.subproj/WebUIDelegate.h:
   5452         added enum values for the menu items in the PDF context menu
   5453         
   5454         * WebView.subproj/WebViewPrivate.h:
   5455         * WebView.subproj/WebView.m:
   5456         (-[WebView _menuForElement:defaultItems:]):
   5457         Added the defaultItems: parameter to this method, which is then passed along to WebDefaultUIDelegate.
   5458         All callers pass nil except for WebPDFView, at least for now.
   5459 
   5460 2005-06-22  Darin Adler  <darin (a] apple.com>
   5461 
   5462         Change by Mitz Pettel.
   5463         Reviewed by me.
   5464 
   5465         - fixed <http://bugs.webkit.org/show_bug.cgi?id=3618>
   5466           RTL runs drawn by CG not reversed properly
   5467 
   5468         * WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawRun:style:geometry:]):
   5469         Fix off-by-one mistake in order-swapping loops.
   5470 
   5471 2005-06-22  Darin Adler  <darin (a] apple.com>
   5472 
   5473         Change by Michael Gaiman.
   5474         Reviewed by me.
   5475 
   5476         - fixed <http://bugs.webkit.org/show_bug.cgi?id=3436>
   5477           Missing implementation of -[NSData(WebNSDateExtras) _webkit_parseRFC822HeaderFields]
   5478 
   5479         * Misc.subproj/WebNSDataExtras.h: Fixed name of category say NSData, not NSDate.
   5480         * Misc.subproj/WebNSDataExtras.m: (-[NSData _webkit_parseRFC822HeaderFields]): Fixed method name.
   5481 
   5482 2005-06-21  John Sullivan  <sullivan (a] apple.com>
   5483 
   5484         Reviewed by Vicki Murley
   5485         
   5486         - fixed assertion failure Vicki ran into
   5487 
   5488         * Misc.subproj/WebIconDatabase.m:
   5489         (-[WebIconDatabase _forgetIconForIconURLString:]):
   5490         Handle the case where there are no associated page URLs for the icon URL
   5491 
   5492 2005-06-20  John Sullivan  <sullivan (a] apple.com>
   5493 
   5494         Reviewed by Chris Blumenberg.
   5495         
   5496         - fixed <rdar://problem/4155182> icon database retain counts can be incorrect after removing all icons
   5497         
   5498         Replaced the concept of "future retain count per page URL" with a simpler concept of "retain count per
   5499         page URL", which is maintained even after the icon is actually loaded (unlike the future retain count).
   5500         The total retain count for an icon is now the sum of the retain counts per page URL along with any retain
   5501         count not associated with a page URL -- this is still needed for some internal housekeeping purposes.
   5502 
   5503         * Misc.subproj/WebIconDatabasePrivate.h:
   5504         renamed iconURLToURLs -> iconURLToPageURLs for clarity
   5505         renamed URLToIconURL -> pageURLToIconURL for clarity
   5506         renamed futureURLToRetainCount -> pageURLToRetainCount (there's no more "future" aspect)
   5507         renamed iconURLToRetainCount -> iconURLToExtraRetainCount (it now maintains only some of the retain count)
   5508         
   5509         * Misc.subproj/WebIconDatabase.m:
   5510         (+[WebIconDatabase sharedIconDatabase]):
   5511         updated for name changes only
   5512         (-[WebIconDatabase init]):
   5513         ditto
   5514         (-[WebIconDatabase iconForURL:withSize:cache:]):
   5515         ditto
   5516         (-[WebIconDatabase iconURLForURL:]):
   5517         ditto
   5518         (-[WebIconDatabase retainIconForURL:]):
   5519         just bump the retain count in pageURLToRetainCount, instead of behaving differently based on whether 
   5520         an icon had been loaded for this URL; this let me delete the internal method _retainFutureIconForURL:
   5521         (-[WebIconDatabase releaseIconForURL:]):
   5522         decrement the retain count in pageURLToRetainCount, then handle the case where the retain count for 
   5523         this page has gone to zero. I deleted the internal method _releaseFutureIconForURL: formerly called here.
   5524         (-[WebIconDatabase removeAllIcons]):
   5525         remove all the code that dealt with retain counts; this operation no longer affects retain counts
   5526         (-[WebIconDatabase _setIconURL:forURL:]):
   5527         remove the code that consolidated multiple retain counts for different page URLs into a single retain 
   5528         count; the multiple retain counts are now maintained even after the icon is loaded
   5529         (-[WebIconDatabase _clearDictionaries]):
   5530         updated for name changes only
   5531         (-[WebIconDatabase _loadIconDictionaries]):
   5532         ditto
   5533         (-[WebIconDatabase _updateFileDatabase]):
   5534         ditto
   5535         (-[WebIconDatabase _totalRetainCountForIconURLString:]):
   5536         new method, sums the retain counts associated with specific page URLs and the extra retain count
   5537         not associated with specific page URLs
   5538         (-[WebIconDatabase _retainIconForIconURLString:]):
   5539         updated for name changes
   5540         (-[WebIconDatabase _forgetIconForIconURLString:]):
   5541         no longer affects retain counts at all; this is up to callers
   5542         (-[WebIconDatabase _releaseIconForIconURLString:]):
   5543         this now distinguishes the case where the retain count not associated with any page URLs hits 
   5544         zero from the case where the total retain count hits zero, and handles both
   5545 
   5546 2005-06-20  John Sullivan  <sullivan (a] apple.com>
   5547 
   5548         Reviewed by Chris Blumenberg.
   5549         
   5550         - added support for emptying the icon database
   5551 
   5552         * Misc.subproj/WebIconDatabase.h: just fixed a typo
   5553         * Misc.subproj/WebIconDatabasePrivate.h:
   5554         added WebPendingPublic category with method removeAllIcons, and
   5555         declared WebIconDatabaseDidRemoveAllIconsNotification string.
   5556         
   5557         * Misc.subproj/WebIconDatabase.m:
   5558         (-[WebIconDatabase removeAllIcons]):
   5559         new method, removes all known icons from memory and disk. There's one loose end,
   5560         covered by radar bug 4155182, where it's possible for the icon database's retain
   5561         counts to get off after this operation. I plan to fix this next.
   5562         (-[WebIconDatabase _setIconURL:forURL:]):
   5563         just fixed some extra whitespace
   5564         (-[WebIconDatabase _forgetIconForIconURLString:]):
   5565         new method, extracted from _releaseIconForIconURLString
   5566         (-[WebIconDatabase _releaseIconForIconURLString:]):
   5567         now calls extracted method
   5568 
   5569         * WebKit.exp:
   5570         added _WebIconDatabaseDidRemoveAllIconsNotification
   5571 
   5572 2005-06-19  Darin Adler  <darin (a] apple.com>
   5573 
   5574 	Changes by Mitz Pettel
   5575         Reviewed by me.
   5576         
   5577         - fixed <http://bugs.webkit.org/show_bug.cgi?id=3466>
   5578           ATSUI text doesn't render at coordinates greater than 32K
   5579 
   5580         * WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_drawRun:style:geometry:]):
   5581         Translate the matrix of the CGContext instead of passing the appropriate coordinates to ATSU.
   5582 
   5583 2005-06-17  Richard Williamson   <rjw (a] apple.com>
   5584 
   5585 	Changes by Mitz Pettel
   5586         Reviewed by Richard Williamson.
   5587 
   5588 	Fixed http://bugs.webkit.org/show_bug.cgi?id=3545
   5589 
   5590         * WebCoreSupport.subproj/WebTextRenderer.m:
   5591         (reverseCharactersInRun):
   5592         (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   5593 
   5594 2005-06-17  John Sullivan  <sullivan (a] apple.com>
   5595 
   5596         Reviewed by Chris.
   5597 
   5598         - fixed <rdar://problem/4151001> Reloading javascript-spawned window with no URL erases its contents
   5599 
   5600         * WebView.subproj/WebFrame.m:
   5601         (-[WebFrame reload]):
   5602         do nothing if URL is zero-length
   5603 
   5604 2005-06-14  John Sullivan  <sullivan (a] apple.com>
   5605 
   5606         Changes by Devin Lane.
   5607         Reviewed by me.
   5608 
   5609         - fixed <rdar://problem/3766909> PDF viewing could use a zoom control other than the one in the context menu
   5610 
   5611         * WebView.subproj/WebPDFView.h:
   5612         now implements protocol _web_WebDocumentTextSizing
   5613         * WebView.subproj/WebPDFView.m:
   5614         (-[WebPDFView _updateScalingToReflectTextSize]):
   5615         new method, sets the PDF scaling from the text size multiplier
   5616         (-[WebPDFView setDataSource:]):
   5617         call _updateScalingToReflectTextSize
   5618         (-[WebPDFView _web_textSizeMultiplierChanged]):
   5619         implementation of protocol _web_WebDocumentTextSizing, calls _updateScalingToReflectTextSize
   5620 
   5621 2005-06-14  John Sullivan  <sullivan (a] apple.com>
   5622 
   5623         Reviewed by Dave Harrison.
   5624 
   5625         * WebView.subproj/WebHTMLView.m:
   5626         (-[WebHTMLView _delayedEndPrintMode:]):
   5627         After discussing this with Dave, I made this method both more debugger-friendly with asserts for
   5628         the cases we don't think could ever happen, and more paranoid by handling these cases in deployment
   5629         builds.
   5630 
   5631 2005-06-14  Darin Adler  <darin (a] apple.com>
   5632 
   5633         - fixed build for Xcode 2.1
   5634 
   5635         * WebKit.pbproj/project.pbxproj: Use BUILT_PRODUCTS_DIR instead of SYMROOT to search for the
   5636         WebKitSystemInterface.h file. We could re-jigger this again later, but for now this is consistent
   5637         with both the .a file's location and where build-webkit puts the file.
   5638 
   5639 2005-06-13  John Sullivan  <sullivan (a] apple.com>
   5640 
   5641         Reviewed by Dave Harrison and Maciej.
   5642 
   5643         * WebView.subproj/WebHTMLView.m:
   5644         (-[WebHTMLView _endPrintMode]):
   5645         new method, extracted from identical code in beginDocument and endDocument. This method must be called
   5646         once to counterbalance the code called from knowsPageRange that turns on "printing mode".
   5647         (-[WebHTMLView _delayedEndPrintMode:]):
   5648         new method, called from "perform after delay". Checks whether the same print operation is still underway
   5649         and, if so, delays further. Otherwise calls _endPrintMode directly.
   5650         (-[WebHTMLView knowsPageRange:]):
   5651         after turning on "printing mode", queue up a delayed call to _delayedEndPrintMode:. If there's an early
   5652         error in the print mechanism such that beginDocument is never called, this will cleanly end "printing
   5653         mode" and make the webview usable again.
   5654         (-[WebHTMLView beginDocument]):
   5655         cancel any delayed call to _delayedEndPrintMode:. If we get this far along in printing, then we don't need
   5656         the failsafe call to _delayedEndPrintMode: that was set up in knowsPageRange:. Also, call extracted method.
   5657         (-[WebHTMLView endDocument]):
   5658         call extracted method
   5659 
   5660 2005-06-13  Maciej Stachowiak  <mjs (a] apple.com>
   5661 
   5662         Reviewed by Chris Blumenberg and Adele.
   5663 
   5664 	- better fix for <rdar://problem/4142247> REGRESSION: List to browse widgets at Apple website failed. Closing tab afterwards caused Safari crash
   5665 	http://bugs.webkit.org/show_bug.cgi?id=3445
   5666 
   5667 	With this change and the matching WebKit change we'll still stop loading the moment you click
   5668 	a download link, but the unload event and detaching of event handlers will not happen early any more.
   5669 	
   5670         * WebView.subproj/WebDataSource.m:
   5671         (-[WebDataSource _stopLoadingInternal]): call stopLoading on bridge instead of closeURL.
   5672         * WebView.subproj/WebFrame.m:
   5673         (-[WebFrame _transitionToCommitted:]): Revert previous attempt at fix.
   5674         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): ditto
   5675         (-[WebFrame stopLoading]): ditto
   5676 
   5677 2005-06-13  Chris Petersen  <cpetersen (a] apple.com>
   5678 
   5679         Changes by Darin.
   5680         Reviewed by me.
   5681 
   5682         - fixed problems building deployment due to recent init change
   5683 
   5684         * WebView.subproj/WebArchive.m: (-[WebArchive initWithCoder:]):
   5685         Put the [super init] call and check for nil outside the exception handler.
   5686         * WebView.subproj/WebResource.m: (-[WebResource initWithCoder:]): Ditto.
   5687 
   5688 2005-06-12  Darin Adler  <darin (a] apple.com>
   5689 
   5690         Reviewed by Maciej.
   5691 
   5692         - fixed <rdar://problem/4141569> REGRESSION (412+): printing fails on any page with images, and for standalone images
   5693           also <http://bugs.webkit.org/show_bug.cgi?id=3318>
   5694 
   5695         * WebCoreSupport.subproj/WebImageData.m: Got rid of use of tabs instead of spaces throughout the file.
   5696         (-[WebImageData _checkSolidColor:]): Wrap use of NSGraphicsContext with an autorelease pool.
   5697         (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): Ditto.
   5698         (-[WebImageData tileInRect:fromPoint:context:]): Ditto.
   5699         (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]): Ditto.
   5700 
   5701 2005-06-12  Darin Adler  <darin (a] apple.com>
   5702 
   5703         Changes by Nick Zitzmann.
   5704         Reviewed by me.
   5705 
   5706         - fixed init methods that don't handle return values from the init methods they call
   5707 
   5708         * WebView.subproj/WebArchive.m:
   5709         (-[WebArchive init]): Use value returned by init, check it for nil too.
   5710         (-[WebArchive initWithMainResource:subresources:subframeArchives:]): Ditto.
   5711         (-[WebArchive _initWithPropertyList:]): Ditto.
   5712         (-[WebArchive initWithCoder:]): Ditto.
   5713         * WebView.subproj/WebClipView.m:
   5714         (-[WebClipView initWithFrame:]): Ditto.
   5715         * WebView.subproj/WebDebugDOMNode.m:
   5716         (-[WebDebugDOMNode initWithName:value:source:children:]): Ditto.
   5717         * WebView.subproj/WebFrame.m:
   5718         (-[WebFormState initWithForm:values:sourceFrame:]): Ditto.
   5719         (-[WebFrame initWithName:webFrameView:webView:]): Ditto.
   5720         * WebView.subproj/WebFrameView.m:
   5721         (-[WebFrameView initWithFrame:]): Ditto.
   5722         * WebView.subproj/WebHTMLRepresentation.m:
   5723         (-[WebHTMLRepresentation init]): Ditto.
   5724         * WebView.subproj/WebHTMLView.m:
   5725         (-[WebHTMLView initWithFrame:]): Ditto.
   5726         (-[WebTextCompleteController initWithHTMLView:]): Ditto.
   5727         * WebView.subproj/WebImageView.m:
   5728         (-[WebImageView initWithFrame:]): Ditto.
   5729         * WebView.subproj/WebPreferences.m:
   5730         (-[WebPreferences initWithIdentifier:]): Ditto.
   5731         * WebView.subproj/WebRenderNode.m:
   5732         (-[WebRenderNode initWithName:position:rect:view:children:]): Ditto.
   5733         * WebView.subproj/WebResource.m:
   5734         (-[WebResource init]): Ditto.
   5735         (-[WebResource initWithCoder:]): Ditto.
   5736         * WebView.subproj/WebView.m:
   5737         (-[WebViewPrivate init]): Call super init.
   5738         (-[_WebSafeForwarder initWithTarget:defaultTarget:templateClass:]): Use value returned by init, check it for nil too.
   5739         (-[WebView initWithFrame:]): Ditto.
   5740 
   5741 2005-06-12  Maciej Stachowiak  <mjs (a] apple.com>
   5742 
   5743         Reviewed by Chris Blumenberg.
   5744 
   5745 	- fixed <rdar://problem/4142247> REGRESSION: List to browse widgets at Apple website failed. Closing tab afterwards caused Safari crash
   5746 	http://bugs.webkit.org/show_bug.cgi?id=3445
   5747 	
   5748         * WebView.subproj/WebFrame.m:
   5749         (-[WebFrame _transitionToCommitted:]): Stop loading the non-provisional data
   5750 	source before swapping in the provisional.
   5751         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Stop only
   5752 	the provisional load here, we would not want to stop loading if this navigation
   5753 	later turns into a download or is cancelled before being committed.
   5754         (-[WebFrame stopLoading]): Factored a bit.
   5755         (-[WebFrame _cancelProvisionalLoad]): New method to stop only provisional load,
   5756 	and cancel any pending policy deicions.
   5757         (-[WebFrame _stopNonProvisionalLoadOnly]): New mthod that stops only the main
   5758 	load.
   5759 
   5760 2005-06-10  John Sullivan  <sullivan (a] apple.com>
   5761 
   5762         reviewed by Dave Harrison (first & second drafts) and Darin Adler (third draft)
   5763 
   5764         - WebKit part of fix for 
   5765         <rdar://problem/4145214> REGRESSION (412+): Can't drag URLs from the location bar
   5766 
   5767         * Misc.subproj/WebNSPasteboardExtras.m:
   5768         (+[NSPasteboard initialize]):
   5769         Reinstate variation of old code that uses CreatePasteboardFlavorTypeName to set up our new pasteboard types.
   5770         The newfangled way didn't work.
   5771 
   5772 2005-06-07  Darin Adler  <darin (a] apple.com>
   5773 
   5774         Change by Mark Rowe <opendarwin.org (a] bdash.net.nz>.
   5775         Reviewed by me.
   5776 
   5777         - fixed the WebKit half of build failure with spaces in the path
   5778           http://bugs.webkit.org/show_bug.cgi?id=3291
   5779 
   5780         * WebKit.pbproj/project.pbxproj: Quote DERIVED_FILE_DIR when it is substituted
   5781         into FRAMEWORK_SEARCH_PATHS, and SYMROOT when into HEADER_SEARCH_PATHS.
   5782 
   5783 2005-06-06  Darin Adler  <darin (a] apple.com>
   5784 
   5785         * Info.plist: Bumped version to 412+. For some reason it was set to 312.1!
   5786 
   5787 2005-06-05  Darin Adler  <darin (a] apple.com>
   5788 
   5789         Reviewed by Hyatt.
   5790 
   5791         - fixed build that I broke with the license change (some includes of WebException were still around)
   5792 
   5793         * WebKit.pbproj/project.pbxproj: Removed references to WebException.h/m.
   5794         * WebView.subproj/WebDataSource.m: Removed include of WebException.h.
   5795         * WebView.subproj/WebHTMLView.m: Ditto.
   5796         * WebView.subproj/WebView.m: Ditto.
   5797 
   5798         - fixed build under gcc 4.0 (some code moved here from Foundation had warnings)
   5799 
   5800         * Misc.subproj/WebNSDataExtras.m:
   5801         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use char instead of UInt8.
   5802         (-[NSData _webkit_guessedMIMEType]):  Use char instead of UInt8, and take out now-
   5803         unneeded type casts.
   5804 
   5805 2005-06-05  Darin Adler  <darin (a] apple.com>
   5806 
   5807         - added appropriate license headers to most files and updated copyright to reflect publication dates
   5808 
   5809         * LICENSE: Added.
   5810         * <lots of files>: Added license header.
   5811 
   5812         * WebKit.pbproj/project.pbxproj: Removed references to NP_objc.h.
   5813 
   5814         * API-Issues.rtf: Removed.
   5815         * Misc.subproj/WebException.h: Removed.
   5816         * Misc.subproj/WebException.m: Removed.
   5817         * Plugins.subproj/NP_objc.h: Removed.
   5818 
   5819 2005-06-01  Darin Adler  <darin (a] apple.com>
   5820 
   5821         Reviewed by John Sullivan.
   5822 
   5823         - WebKit part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
   5824 
   5825         * WebCoreSupport.subproj/WebBridge.m:
   5826         (-[WebBridge createModalDialogWithURL:]): Added. Calls the UI delegate, falling back to the generic
   5827         "create WebView" method.
   5828         (-[WebBridge canRunModal]): Added. Checks the UI delegate to see if it implements runModal.
   5829         (-[WebBridge canRunModalNow]): Added. Checks the "inConnectionCallback" field so we can prevent
   5830         deadlock since we can't do any I/O while inside a connection callback until this aspect of NSURLConnection
   5831         is changed.
   5832         (-[WebBridge runModal]): Added. Sets "defersCallbacks" on all other web views in the group, then
   5833         calls runModal on the UI delegate.
   5834 
   5835         * WebView.subproj/WebBaseResourceHandleDelegate.h: Added inConnectionCallback class method.
   5836         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   5837         (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Bump count and then
   5838         decrement count so we can tell if we are in a callback.
   5839         (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Ditto.
   5840         (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Ditto.
   5841         (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): Ditto.
   5842         (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): Ditto.
   5843         (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): Ditto.
   5844         (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Ditto.
   5845         (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): Ditto.
   5846         (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): Ditto.
   5847         (+[WebBaseResourceHandleDelegate inConnectionCallback]): Added. Return YES if count is not 0.
   5848 
   5849         * WebView.subproj/WebMainResourceClient.m:
   5850         (-[WebMainResourceClient receivedError:]): Changed to use the method without the connection: parameter
   5851         in the base class, since we no longer are overriding the connection: version.
   5852         (-[WebMainResourceClient willSendRequest:redirectResponse:]): Change to override the version without
   5853         the connection prefix/parameter; now only the base class overrides the actual connection delegate methods.
   5854         (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto.
   5855         (-[WebMainResourceClient didReceiveResponse:]): Ditto.
   5856         (-[WebMainResourceClient didReceiveData:lengthReceived:]): Ditto.
   5857         (-[WebMainResourceClient didFinishLoading]): Ditto.
   5858         (-[WebMainResourceClient didFailWithError:]): Ditto.
   5859         (-[WebMainResourceClient loadWithRequestNow:]): Call the method without the connection parameter.
   5860 
   5861         * WebView.subproj/WebUIDelegatePrivate.h: Added new SPI here that WebBrowser implements.
   5862 
   5863 2005-05-26  Darin Adler  <darin (a] apple.com>
   5864 
   5865         Reviewed by John.
   5866 
   5867         - fix build failure from when I removed WebCoreUnicode
   5868 
   5869         * WebCoreSupport.subproj/WebTextRenderer.m: Removed import of WebUnicode.h that I missed.
   5870         (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): Switch from our own macros
   5871         to the ICU macros for surrogate pairs.
   5872         (widthForNextCharacter): Ditto.
   5873 
   5874 2005-05-26  David Harrison  <harrison (a] apple.com>
   5875 
   5876         <rdar://problem/4120518> Mail: control-T in an empty message crashes mail
   5877 
   5878         * WebCoreSupport.subproj/WebBridge.m:
   5879         (-[WebBridge issueTransposeCommand]):
   5880         New, to support transpose in JS.
   5881 
   5882 2005-05-26  Darin Adler  <darin (a] apple.com>
   5883 
   5884         Reviewed by Richard and Dave Harrison.
   5885 
   5886         - eliminate WebCoreUnicode and use ICU directly instead
   5887 
   5888         * Misc.subproj/WebKitNSStringExtras.m: (canUseFastRenderer): Use u_charDirection directly.
   5889         * WebCoreSupport.subproj/WebTextRenderer.m: Removed import of <WebCore/WebCoreUnicode.h>.
   5890         * WebView.subproj/WebHTMLView.m: (+[WebHTMLView initialize]): Removed call to WebKitInitializeUnicode.
   5891 
   5892         * Misc.subproj/WebUnicode.h: Removed.
   5893         * Misc.subproj/WebUnicode.m: Removed.
   5894         * Misc.subproj/WebUnicodeTables.m: Removed.
   5895 
   5896         * WebKit.pbproj/project.pbxproj: Removed files.
   5897 
   5898 2005-05-24  Richard Williamson   <rjw (a] apple.com>
   5899 
   5900 	Fixed <rdar://problem/4097289> -[WebView elementAtPoint:] failing when WebView is nested and offset
   5901 
   5902 	Code to determine the correct frame under the window point was
   5903 	converting the point incorrectly.
   5904 
   5905         Reviewed by Chris.
   5906 
   5907         * WebView.subproj/WebView.m:
   5908         (-[WebView _frameViewAtWindowPoint:]):
   5909 
   5910 2005-05-23  John Sullivan  <sullivan (a] apple.com>
   5911 
   5912         Reviewed by Kevin.
   5913         
   5914         - WebKit part of <rdar://problem/4125783> WebKit needs a way to control whether textareas are resizable
   5915 
   5916         * WebView.subproj/WebPreferencesPrivate.h:
   5917         added private-for-now getter and setter for new preference
   5918         * WebView.subproj/WebPreferenceKeysPrivate.h:
   5919         added private preference key controlling whether textareas are resizable
   5920         * WebView.subproj/WebPreferences.m:
   5921         (+[WebPreferences initialize]):
   5922         initial value of new preference is NO, so other clients' behavior doesn't change
   5923         (-[WebPreferences textAreasAreResizable]):
   5924         new getter
   5925         (-[WebPreferences setTextAreasAreResizable:]):
   5926         new setter
   5927         
   5928         * WebView.subproj/WebView.m:
   5929         (-[WebView _updateWebCoreSettingsFromPreferences:]):
   5930         update this new setting in WebCore
   5931 
   5932         * English.lproj/StringsNotToBeLocalized.txt:
   5933         updated for these changes
   5934 
   5935 2005-05-23  Chris Blumenberg  <cblu (a] apple.com>
   5936 
   5937 	Changed type for identifier parameter in WebResourceLoadDelegate-related calls to id from NSString.
   5938 
   5939         Reviewed by kevin.
   5940 
   5941         * WebCoreSupport.subproj/WebBridge.m:
   5942         (-[WebBridge objectLoadedFromCacheWithURL:response:data:]):
   5943         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
   5944         * WebView.subproj/WebFrame.m:
   5945         (-[WebFrame _opened]):
   5946         (-[WebFrame _requestFromDelegateForRequest:identifier:error:]):
   5947         (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
   5948         (-[WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]):
   5949         * WebView.subproj/WebFrameInternal.h:
   5950 
   5951 2005-05-20  Chris Blumenberg  <cblu (a] apple.com>
   5952 
   5953 	Fixed: <rdar://problem/4098786> sync. XMLHttpRequest works w/o AllowNetworkAccess key because load delegate is not consulted
   5954 
   5955 	Synchronous loads did not cause the willSendRequest method on the resource load delegate to be called. This is the method that Dashboard uses to enforce AllowNetworkAccess and this must be called to avoid exploits.
   5956 
   5957         Reviewed by sullivan.
   5958 
   5959         * WebCoreSupport.subproj/WebBridge.m:
   5960         (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call [WebFrame _requestFromDelegateForRequest:identifier:error:] then 
   5961 	[WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:] so synthetic resource load delegate 
   5962 	methods are called and the data is saved as a WebResource for resources in the WebCore cache.
   5963 
   5964         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): call [WebFrame _requestFromDelegateForRequest:identifier:error:],
   5965 	respect its result, do the load and then call [WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:] 
   5966 	for synchronous loads
   5967 
   5968         * WebView.subproj/WebFrame.m:
   5969         (-[WebFrame _opened]): call [WebFrame _requestFromDelegateForRequest:identifier:error:] then 
   5970 	[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:] so synthetic resource load delegate methods are called 
   5971 	for subresrources in the page cache
   5972         
   5973 	(-[WebFrame _requestFromDelegateForRequest:identifier:error:]): new, was part of the removed _sendResourceLoadDelegateMessagesForURL:::
   5974 	This method calls identifierForInitialRequest and willSendRequest.
   5975 
   5976         (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): new, was part of the removed _sendResourceLoadDelegateMessagesForURL:::
   5977 	This method calls the remaining resource load delegate messages.
   5978 
   5979         (-[WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]): new, saves the resource and calls
   5980 	[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]
   5981 
   5982         * WebView.subproj/WebFrameInternal.h:
   5983 
   5984 2005-05-17  Chris Blumenberg  <cblu (a] apple.com>
   5985 	
   5986 	Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control
   5987 
   5988         Reviewed by mjs.
   5989 
   5990         * WebCoreSupport.subproj/WebBridge.m:
   5991         (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer]
   5992         (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
   5993         * WebView.subproj/WebTextView.m:
   5994         (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.
   5995 
   5996 2005-05-17  Chris Blumenberg  <cblu (a] apple.com>
   5997 
   5998 	Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead
   5999 
   6000         Reviewed by mjs.
   6001 
   6002         * WebView.subproj/WebBaseResourceHandleDelegate.h:
   6003         * WebView.subproj/WebMainResourceClient.m:
   6004         (-[WebMainResourceClient continueAfterContentPolicy:response:]): if the WebKit client has chosen to "use" a remote web archive, stop the load with an error
   6005 
   6006 2005-05-16  Darin Adler  <darin (a] apple.com>
   6007 
   6008         - attempt to get things building under "Saffron" development tools
   6009 
   6010         * WebKit.pbproj/project.pbxproj: Use BUILT_PRODUCTS_DIR instead of SYMROOT.
   6011 
   6012 2005-05-13  John Sullivan  <sullivan (a] apple.com>
   6013 
   6014         Reviewed by Kevin.
   6015         
   6016         - fixed <rdar://problem/4093306> Safari crashes if Esc key is held down during series 
   6017         of authentication sheets
   6018 
   6019         * Panels.subproj/WebAuthenticationPanel.m:
   6020         (-[WebAuthenticationPanel cancel:]):
   6021         retain and autorelease self. This is a workaround for an AppKit key-handling issue, which I wrote up as:
   6022         <rdar://problem/4118422> Key-down events can be sent to a closed window if a key is kept pressed down
   6023 
   6024 2005-05-12  John Sullivan  <sullivan (a] apple.com>
   6025 
   6026         Reviewed by Kevin.
   6027 
   6028         - rolled in changes from experimental-ui-branch to support resizable textareas
   6029         and find-as-you-type and confirming unsubmitted form changes. The files/functions 
   6030         modified are listed just below. After that are the ChangeLog comments from the branch.
   6031 
   6032         * WebCoreSupport.subproj/WebBridge.m:
   6033         (-[WebBridge textDidChange:]):
   6034         * WebView.subproj/WebFormDelegate.h:
   6035         * WebView.subproj/WebFormDelegate.m:
   6036         (-[WebFormDelegate textDidChange:inFrame:]):
   6037         * WebView.subproj/WebHTMLView.m:
   6038         (-[WebHTMLView maintainsInactiveSelection]):
   6039         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]):
   6040         (-[WebHTMLView _searchFor:direction:caseSensitive:wrap:findInSelection:]):
   6041         * WebView.subproj/WebView.m:
   6042         (-[WebView _searchFor:direction:caseSensitive:wrap:findInSelection:]):
   6043         (-[WebView searchFor:direction:caseSensitive:wrap:]):
   6044         (-[WebView makeTextStandardSize:]):
   6045         (-[WebView maintainsInactiveSelection]):
   6046         * WebView.subproj/WebViewPrivate.h:
   6047         
   6048         2005-04-18  John Sullivan  <sullivan (a] apple.com>
   6049 
   6050                 WebKit support for notifying a form delegate when a
   6051                 textarea's contents have changed (as opposed to a 
   6052                 textfield, which was already handled).
   6053 
   6054                 Reviewed by Maciej.
   6055 
   6056                 * WebView.subproj/WebFormDelegate.h:
   6057                 * WebView.subproj/WebFormDelegate.m:
   6058                 (-[WebFormDelegate textDidChange:inFrame:]):
   6059                 new form delegate method
   6060 
   6061                 * WebCoreSupport.subproj/WebBridge.m:
   6062                 (-[WebBridge textDidChange:]):
   6063                 new method, calls through to form delegate
   6064                 
   6065         2005-04-11  John Sullivan  <sullivan (a] apple.com>
   6066 
   6067                 Fixed inability to wrap around in Find in Page 
   6068 
   6069                 * WebView.subproj/WebView.m:
   6070                 (-[WebView _searchFor:direction:caseSensitive:wrap:findInSelection:]):
   6071                 changed wrapFlag from NO to YES on two lines (copy/paste error)
   6072 
   6073         2005-04-07  John Sullivan  <sullivan (a] apple.com>
   6074 
   6075                 WebKit support for find-as-you-type. Needed an additional parameter on
   6076                 a method from WebDocumentSearching protocol. Since that's a public protocol, 
   6077                 I couldn't just add the parameter. For now I hacked it with an undeclared
   6078                 internal method that's discovered via respondsToSelector. Probably the right
   6079                 long-term approach is to deprecate the WebDocumentSearching protocol and introduce
   6080                 a replacement that has a more flexible set of parameters for possible future
   6081                 expansion.
   6082 
   6083                 Reviewed by Dave Hyatt.
   6084 
   6085                 * WebView.subproj/WebHTMLView.m:
   6086                 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]):
   6087                 now calls new one-more-parameter version passing NO for new parameter to match old behavior
   6088                 (-[WebHTMLView _searchFor:direction:caseSensitive:wrap:findInSelection:]):
   6089                 new method, adds findInSelection parameter and passes it through to bridge
   6090                  
   6091                 * WebView.subproj/WebView.m:
   6092                 (-[WebView searchFor:direction:caseSensitive:wrap:]):
   6093                 now calls new one-more-parameter version passing NO for new parameter to match old behavior
   6094                 (-[WebView _searchFor:direction:caseSensitive:wrap:findInSelection:]):
   6095                 new method, adds findInSelection parameter and passes it through
   6096 
   6097         2005-04-07  John Sullivan  <sullivan (a] apple.com>
   6098 
   6099                 WebKit support to allow clients to control whether the selection is still
   6100                 drawn when the first responder is elsewhere. Formerly this was hardwired
   6101                 to be true only when -[WebView isEditable] was true.
   6102 
   6103                 Reviewed by Darin.
   6104 
   6105                 * WebView.subproj/WebHTMLView.m:
   6106                 (-[WebHTMLView maintainsInactiveSelection]):
   6107                 check [WebView maintainsInactiveSelection] rather than just [WebView isEditable]
   6108                 
   6109                 * WebView.subproj/WebViewPrivate.h:
   6110                 * WebView.subproj/WebView.m:
   6111                 (-[WebView maintainsInactiveSelection]):
   6112                 new method for clients to override, returns -[self isEditable]
   6113         
   6114 
   6115 2005-05-10  John Sullivan  <sullivan (a] apple.com>
   6116 
   6117         Reviewed by Kevin.
   6118         
   6119         - WebKit support for <rdar://problem/3795701> Menu item/keyboard shortcut to 
   6120         restore text zoom to normal
   6121 
   6122         * WebView.subproj/WebView.m:
   6123         (-[WebView validateUserInterfaceItem:]):
   6124         validate makeTextStandardSize by calling canMakeTextStandardSize
   6125         (-[WebView canMakeTextStandardSize]):
   6126         new method, returns YES unless text size multiplier is currently 1
   6127         (-[WebView makeTextStandardSize:]):
   6128         new method, sets text size multiplier to 1
   6129         
   6130         * WebView.subproj/WebViewPrivate.h:
   6131         add makeTextStandardSize: and canMakeTextStandardSize to pending public category
   6132 
   6133 2005-05-10  John Sullivan  <sullivan (a] apple.com>
   6134 
   6135         Reviewed by Chris.
   6136         
   6137         - fixed <rdar://problem/4067981> Mail places RTF flavor before RTFD flavor when dragging 
   6138         mixed image/text content.
   6139 
   6140         * WebView.subproj/WebHTMLView.m:
   6141         (+[WebHTMLView _selectionPasteboardTypes]):
   6142         put RTFD type before RTF type in array of types to declare
   6143 
   6144 2005-05-09  Chris Blumenberg  <cblu (a] apple.com>
   6145 
   6146 	Turned assertion into error message to prevent crash when encountering this bug:
   6147 	<rdar://problem/4067625> connection:willCacheResponse: is called inside of [NSURLConnection initWithRequest:delegate:]
   6148 	
   6149         * WebView.subproj/WebBaseResourceHandleDelegate.h:
   6150         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   6151         (-[WebBaseResourceHandleDelegate loadWithRequest:]): set flag to track when we're initializing the connection
   6152         (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): log error
   6153 
   6154 2005-05-09  Darin Adler  <darin (a] apple.com>
   6155 
   6156         * Makefile.am: Don't set up PBXIntermediatesDirectory explicitly;
   6157         Not needed to make builds work, spews undesirable error messages too.
   6158 
   6159 2005-05-06  Darin Adler  <darin (a] apple.com>
   6160 
   6161         Reviewed by Maciej.
   6162 
   6163         - make building multiple trees with make work better
   6164 
   6165         * Makefile.am: Set up Xcode build directory before invoking xcodebuild.
   6166 
   6167 2005-05-04  Darin Adler  <darin (a] apple.com>
   6168 
   6169         Reviewed by Dave Hyatt.
   6170 
   6171         - fixed layout tests
   6172 
   6173         * WebKit.pbproj/project.pbxproj: Set deployment target to 10.3 in the build styles.
   6174         When built without a build style (by Apple B&I) we want to get the target from the
   6175         environment. But when built with a build style (by Safari engineers and others), we want
   6176         to use 10.3. Because our deployment target was not set, we ran into this bug:
   6177 
   6178             <rdar://problem/4108717> CTFontGetGlyphWithName doesn't work with some strings
   6179 
   6180         * Makefile.am: Took out extra parameters that make command-line building different from
   6181         Xcode building. Now that this is fixed, you should not get a full rebuild if you switch
   6182         from command line to Xcode or back.
   6183 
   6184 2005-05-04  Chris Blumenberg  <cblu (a] apple.com>
   6185 
   6186 	Fixed: 
   6187 	<rdar://problem/4078417> REGRESSION (125-412): MLB gameday page doesn't update (Flash)
   6188 	<rdar://problem/4072280> XMLHttpRequest calls onReadyStateChange callback with bogus status value
   6189         
   6190 	Reviewed by john.
   6191 
   6192 	Our WebKit-level caching of subresources "dumbed-down" information held in NSURLResponse. This caused some loads to lack response headers and thus disabling cache directives. Status codes were also not retained and this caused XMLHttpRequest to fail frequently. The fix is to have WebResource retain the NSURLResponse and to use the NSURLResponse when we decide to load from WebResources.
   6193 
   6194         * WebCoreSupport.subproj/WebBridge.m:
   6195         (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call new [WebResource _initWithData:URL:response:]
   6196         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   6197         (-[WebBaseResourceHandleDelegate _canUseResourceWithResponse:]): new, checks response cache directives
   6198         (-[WebBaseResourceHandleDelegate loadWithRequest:]): call _canUseResourceWithResponse:
   6199         (-[WebBaseResourceHandleDelegate saveResource]): call new [WebResource _initWithData:URL:response:]
   6200         * WebView.subproj/WebResource.m:
   6201         (-[WebResourcePrivate dealloc]):
   6202         (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call renamed _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:
   6203         (-[WebResource initWithCoder:]): decode the NSURLReponse
   6204         (-[WebResource encodeWithCoder:]): encode the NSURLReponse
   6205         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): take the NSURLReponse
   6206         (-[WebResource _initWithData:URL:response:]): new
   6207         (-[WebResource _initWithPropertyList:]): decode the NSURLReponse
   6208         (-[WebResource _propertyListRepresentation]): encode the NSURLReponse
   6209         (-[WebResource _response]): return ivar if we have one
   6210         * WebView.subproj/WebResourcePrivate.h:
   6211 
   6212 2005-05-03  David Hyatt  <hyatt (a] apple.com>
   6213 
   6214 	Fix object element support so that fallback content works.  With this change Safari passes the Acid2 test.
   6215 	
   6216         Reviewed by Maciej
   6217 
   6218         * WebCoreSupport.subproj/WebBridge.m:
   6219         (-[WebBridge determineObjectFromMIMEType:URL:]):
   6220         * WebView.subproj/WebDataSource.m:
   6221         (-[WebDataSource _receivedMainResourceError:complete:]):
   6222         * WebView.subproj/WebMainResourceClient.m:
   6223         (-[WebMainResourceClient continueAfterContentPolicy:response:]):
   6224 
   6225 2005-05-03  Darin Adler  <darin (a] apple.com>
   6226 
   6227         * WebView.subproj/WebUIDelegate.h: Fixed incorrect comment.
   6228 
   6229 2005-05-01  Darin Adler  <darin (a] apple.com>
   6230 
   6231         - move to Xcode native targets and stop checking in generated files
   6232 
   6233         * WebKit.pbproj/project.pbxproj: Updated to use native targets and generate all the generated
   6234         files, so we don't have to check them in any more.
   6235         * Info.plist: Added. Native targets use a separate file for this.
   6236 
   6237         * Plugins.subproj/npapi.m: Fixed import statement to get npapi.h from <WebKit/> rather than current directory.
   6238 
   6239         * Makefile.am: Removed timestamp cleaning rules since we don't use it any more.
   6240 
   6241         * .cvsignore: Removed various timestamp files.
   6242 
   6243         * DOM.subproj/DOM-compat.h: Removed.
   6244         * DOM.subproj/DOM.h: Removed.
   6245         * DOM.subproj/DOMCSS.h: Removed.
   6246         * DOM.subproj/DOMCore.h: Removed.
   6247         * DOM.subproj/DOMEvents.h: Removed.
   6248         * DOM.subproj/DOMExtensions.h: Removed.
   6249         * DOM.subproj/DOMHTML.h: Removed.
   6250         * DOM.subproj/DOMPrivate.h: Removed.
   6251         * DOM.subproj/DOMRange.h: Removed.
   6252         * DOM.subproj/DOMStylesheets.h: Removed.
   6253         * DOM.subproj/DOMTraversal.h: Removed.
   6254         * DOM.subproj/DOMViews.h: Removed.
   6255         * Plugins.subproj/WebScriptObject.h: Removed.
   6256         * Plugins.subproj/npapi.h: Removed.
   6257         * Plugins.subproj/npruntime.h: Removed.
   6258         * copy-webcore-files-to-webkit: Removed.
   6259         * embed-frameworks.sh: Removed.
   6260         * force-clean-timestamp: Removed.
   6261 
   6262 2005-04-28  Darin Adler  <darin (a] apple.com>
   6263 
   6264         Reviewed by Maciej.
   6265 
   6266         - fixed problems preventing us from compiling with gcc 4.0
   6267 
   6268         * WebKit.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy
   6269         way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from
   6270         WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
   6271 
   6272         * History.subproj/WebHistoryItem.m: (-[WebHistoryItem pageCache]): Changed return type
   6273         to match the declaration.
   6274         * WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]):
   6275         Fixed a BOOL that should have been a Boolean.
   6276         * WebCoreSupport.subproj/WebTextRenderer.m: Removed redundant copy of ROUND_TO_INT, also in
   6277         a WebCore header.
   6278         (-[WebTextRenderer _computeWidthForSpace]): Had to add cast because of difference in type of
   6279         ROUND_TO_INT vs. CEIL_TO_INT.
   6280         (pathFromFont): Added a cast to convert UInt8 * to char *.
   6281         * WebView.subproj/WebFrameView.m:
   6282         (-[WebFrameView _setDocumentView:]): Fixed parameter type to match the declaration.
   6283         (-[WebFrameView documentView]): Fixed return type to match the declaration.
   6284         * WebView.subproj/WebHTMLView.m:
   6285         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
   6286         Initialized a variable to quiet an incorrect gcc 4.0 uninitialized variable warning.
   6287         (-[WebHTMLView deleteToMark:]): Switched from @try style to NS_DURING style of exception handler
   6288         because we can't pass -fobjc-exceptions just to Objective-C at the moment (see above).
   6289         (-[WebHTMLView selectToMark:]): Ditto.
   6290         (-[WebHTMLView swapWithMark:]): Ditto.
   6291 
   6292 2005-04-27  John Sullivan  <sullivan (a] apple.com>
   6293 
   6294         Reviewed by Dave Harrison.
   6295         
   6296         - fixed <rdar://problem/3547489> pop-up window blocking preference and 
   6297         menu item can easily get out of sync.
   6298 
   6299         * WebView.subproj/WebPreferences.m:
   6300         (-[WebPreferences _setStringValue:forKey:]):
   6301         save local value before setting value in NSUserDefaults, so clients reacting to NSUserDefaults
   6302         change notification but calling back on WebPreferences API will see the updated value.
   6303         (-[WebPreferences _setIntegerValue:forKey:]):
   6304         ditto
   6305         (-[WebPreferences _setBoolValue:forKey:]):
   6306         ditto
   6307 
   6308 2005-04-26  Richard Williamson   <rjw (a] apple.com>
   6309 
   6310 	Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla
   6311 
   6312         Reviewed by Chris.
   6313 
   6314         * Plugins.subproj/npfunctions.h:
   6315         * Plugins.subproj/npruntime.h:
   6316 
   6317 2005-04-26  Darin Adler  <darin (a] apple.com>
   6318 
   6319         Reviewed by John.
   6320 
   6321         - fixed <rdar://problem/3655817> please add support for mouse wheel events and the onmousewheel handler
   6322 
   6323         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollWheel:]): Call sendScrollWheelEvent: method
   6324         instead of the old scrollOverflowWithScrollWheelEvent: (just a name change).
   6325 
   6326 2005-04-18  Darin Adler  <darin (a] apple.com>
   6327 
   6328         Reviewed by Hyatt.
   6329 
   6330         - fixed <rdar://problem/4092614> REGRESSION (Tiger): progressively loaded background images "scroll around" instead of just appearing
   6331 
   6332         * WebCoreSupport.subproj/WebImageData.m:
   6333         (-[WebImageData _imageSourceOptions]): Moved a global inside this function, since it's only used here.
   6334         (-[WebImageData _cacheImages:allImages:]): Fixed a sizeof that was getting the size of the wrong thing.
   6335         (-[WebImageData _isSizeAvailable]): Used calloc in a more consistent way.
   6336         (drawPattern): Removed an unneeded cast.
   6337         (-[WebImageData tileInRect:fromPoint:context:]): Here's the actual bug fix. Don't use the image size
   6338         when deciding whether the image needs to be tiled as a pattern nor when creating the pattern: in both
   6339         cases, use the tile size. The old way was wrong, and the new way works perfectly. Also removed uneeded
   6340         error message when the image is not yet loaded enough to create a CGImageRef for it -- it's fine to
   6341         draw nothing in that case.
   6342 
   6343 2005-04-14  John Sullivan  <sullivan (a] apple.com>
   6344 
   6345         Reviewed by Chris.
   6346 
   6347         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   6348         (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]):
   6349         Beefed up assertion that's been bugging me and Chris to include
   6350         the two troublemaking values.
   6351 
   6352 2005-04-05  David Hyatt  <hyatt (a] apple.com>
   6353 
   6354 	Fix for 4077106, wheel scroll amount smaller in Tiger.  All along wheeling should have been 4x the default
   6355 	line height of 10 (just as arrow keys did).  Scroll arrows should have done this too for scroll views (they did
   6356 	already for overflow sections).  This patch puts the override into the scrollview itself, and removes the
   6357 	multipliers in the private frame methods.
   6358 	
   6359         Reviewed by darin
   6360 
   6361         * WebView.subproj/WebFrameView.m:
   6362         (-[WebFrameView _verticalKeyboardScrollDistance]):
   6363         (-[WebFrameView initWithFrame:]):
   6364         (-[WebFrameView _horizontalKeyboardScrollDistance]):
   6365 
   6366 === WebKit-312.1 ===
   6367 
   6368 2005-03-31  Chris Blumenberg  <cblu (a] apple.com>
   6369 
   6370 	Fixed: <rdar://problem/4070729> REGRESSION (125-311, Panther-only?): Safari crashes while reloading "My eBay" page
   6371 
   6372         Reviewed by rjw.
   6373 
   6374         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   6375         (-[WebBaseResourceHandleDelegate resourceData]): retain and autorelease resourceData since releaseResources (which releases resourceData) may be called before the caller of this method has an opporuntity to retain the returned data
   6376 
   6377 === Safari-412 ===
   6378 
   6379 === Safari-411 ===
   6380 
   6381 2005-03-23  Richard Williamson   <rjw (a] apple.com>
   6382 
   6383 	Use Patti Yeh's hack to determine the appropriate rectangle
   6384 	to place the "associated word" window.  
   6385 	If there is no marked text firstRectForCharacterRange: will
   6386 	use the selected range to determine the returned rectangle,
   6387 	ignoring the input range.  This is the fix from
   6388 	4029491 that I previously backed out.
   6389 
   6390         Reviewed by Vicki.
   6391 
   6392         * WebView.subproj/WebHTMLView.m:
   6393         (-[WebHTMLView firstRectForCharacterRange:]):
   6394 
   6395 2005-03-23  Richard Williamson   <rjw (a] apple.com>
   6396 
   6397 	Fixed <rdar://problem/4062490> REGRESSION (WebKit-408): no subresources reported in Activity window after going back at hrweb.apple.com
   6398 
   6399 	Stop collecting subresource responses after the document
   6400 	had loaded, not after it has been opened.
   6401 
   6402         Reviewed by Chris.
   6403 
   6404         * WebView.subproj/WebFrame.m:
   6405         (-[WebFrame _setState:]):
   6406         (-[WebFrame _opened]):
   6407 
   6408 2005-03-21  Maciej Stachowiak  <mjs (a] apple.com>
   6409 
   6410         Reviewed by Darin.
   6411 
   6412 	<rdar://problem/4051145> The QuickTime Cocoa plug-in needs an SPI that it can call to check for URL policy
   6413 
   6414         * Plugins.subproj/WebPluginContainerCheck.h: Added.
   6415         * Plugins.subproj/WebPluginContainerCheck.m: Added this new helper class to encapsulate
   6416 	an async plugin navigation check.
   6417         (+[WebPluginContainerCheck checkWithRequest:target:resultObject:selector:controller:]): Convenience allocator that gives autoreleased value.
   6418         (-[WebPluginContainerCheck initWithRequest:target:resultObject:selector:controller:]): Initializer.
   6419         (-[WebPluginContainerCheck finalize]): Just assert that we're done, it would
   6420 	be bad to deallocate this object while request is still outstanding.
   6421         (-[WebPluginContainerCheck dealloc]): Ditto.
   6422         (-[WebPluginContainerCheck _continueWithPolicy:]): Method to continue after async
   6423 	policy check.
   6424         (-[WebPluginContainerCheck _isDisallowedFileLoad]): Do "file: URL from remote content"
   6425 	check.
   6426         (-[WebPluginContainerCheck _actionInformationWithURL:]): Helper to make action
   6427 	dictionary.
   6428         (-[WebPluginContainerCheck _askPolicyDelegate]): Call policy delegate to let
   6429 	the app decide if this load is allowed.
   6430         (-[WebPluginContainerCheck start]): Start the check.
   6431         (-[WebPluginContainerCheck cancel]): Cancel a check in progress.
   6432         * Plugins.subproj/WebPluginController.h:
   6433         * Plugins.subproj/WebPluginController.m:
   6434         (-[WebPluginController initWithDocumentView:]): Initialize new _checksInProgress field.
   6435         (-[WebPluginController _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Implement
   6436 	this new SPI method.
   6437         (-[WebPluginController _cancelOutstandingChecks]): New helper to make sure to cancel
   6438 	all outstanding requests when destroying all plugins.
   6439         (-[WebPluginController destroyAllPlugins]): Call above helper.
   6440         (-[WebPluginController _webPluginContainerCheckIfAllowedToLoadRequest:inFrame:resultObject:selector:]): Implement this new plug-in SPI method.
   6441         (-[WebPluginController bridge]): New helper method.
   6442         (-[WebPluginController webView]): New helper method.
   6443         * WebView.subproj/WebPolicyDelegatePrivate.h: Add new navigation
   6444 	type WebNavigationTypePlugInRequest.
   6445         * WebKit.pbproj/project.pbxproj: Add new files.
   6446         * WebView.subproj/WebDefaultPolicyDelegate.m:
   6447         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Don't open externally on a plug-in request.
   6448 
   6449 2005-03-23  Richard Williamson   <rjw (a] apple.com>
   6450 
   6451 	Fixed <rdar://problem/4053515> REGRESSION (Mail): Kotoeri input method reconversion does not work in WebViews
   6452 
   6453 	We now use actual document NSRanges to represent both marked text
   6454 	ranges and selection ranges.
   6455 
   6456         Reviewed by Ken Kocienda.
   6457 
   6458         * WebView.subproj/WebHTMLView.m:
   6459         (-[WebHTMLView validAttributesForMarkedText]):
   6460         (-[WebHTMLView firstRectForCharacterRange:]):
   6461         (-[WebHTMLView selectedRange]):
   6462         (-[WebHTMLView markedRange]):
   6463         (-[WebHTMLView _selectMarkedText]):
   6464         (-[WebHTMLView setMarkedText:selectedRange:]):
   6465 
   6466 === Safari-410 ===
   6467 
   6468 2005-03-22  Darin Adler  <darin (a] apple.com>
   6469 
   6470         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
   6471 
   6472 === Safari-409 ===
   6473 
   6474 2005-03-20  Maciej Stachowiak  <mjs (a] apple.com>
   6475 
   6476         Reviewed by Darin.
   6477 
   6478 	<rdar://problem/4060020> Add stub version of security SPI for QuickTime plug-in so QuickTime team has something to compile and link against
   6479         
   6480 	* Plugins.subproj/WebPluginContainerPrivate.h: Added.
   6481         * Plugins.subproj/WebPluginController.m:
   6482         (-[WebPluginController _webPluginContainerCheckIfAllowedToLoadRequest:inFrame:resultObject:selector:]):
   6483         (-[WebPluginController _webPluginContainerCancelCheckIfAllowedToLoadRequest:]):
   6484         * WebKit.pbproj/project.pbxproj:
   6485 
   6486 2005-03-19  David Harrison  <harrison (a] apple.com>
   6487 
   6488         Reviewed by Maciej.
   6489         
   6490         <rdar://problem/4059479> Misspelling underline does underline the whole word, could go farther to the right
   6491 
   6492         * WebCoreSupport.subproj/WebTextRenderer.m:
   6493         (-[WebTextRenderer misspellingLinePatternGapWidth]):
   6494         (-[WebTextRenderer drawLineForMisspelling:withWidth:]):
   6495         Consider that the last pixel in the underline dot pattern is transparent.
   6496 
   6497 2005-03-19  Darin Adler  <darin (a] apple.com>
   6498 
   6499         Reviewed by Maciej (a while back).
   6500 
   6501         - fixed <rdar://problem/4059323> local-file security check is allowing plug-in streams, but must not
   6502 
   6503         * Plugins.subproj/WebNetscapePluginStream.m:
   6504         (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
   6505         Roll out change I made on 3-13. That change is needed for subresource, but not for plug-in streams.
   6506         For plug-in streams it's too risky, and leaves a serious security hole open.
   6507 
   6508 2005-03-19  Darin Adler  <darin (a] apple.com>
   6509 
   6510         Reviewed by Ken and John.
   6511 
   6512         - fixed <rdar://problem/4059123> REGRESSION (402-403): deleteWordForward: and deleteWordBackward: start deleting single characters after the first delete
   6513 
   6514         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]):
   6515         Fixed backwards logic in here and added missing check. Set action to one of the two typing actions only
   6516         if isTypingAction is YES.
   6517 
   6518 2005-03-19  David Harrison  <harrison (a] apple.com>
   6519 
   6520         Reviewed by me (written by Patti Yeh).
   6521         
   6522         <rdar://problem/4029491> <TCIM> CangJie: the candidate window appears at the top left hand corner during typing in Mail and iChat
   6523 
   6524         * WebView.subproj/WebHTMLView.m:
   6525         (-[WebHTMLView firstRectForCharacterRange:]):
   6526         Use selected range if there is no marked range.
   6527 
   6528 === Safari-408 ===
   6529 
   6530 2005-03-18  David Harrison  <harrison (a] apple.com>
   6531 
   6532         Reviewed by Darin.
   6533 
   6534         <rdar://problem/3584942> AX: Safari Accessibility parent-child mismatch
   6535 
   6536         * WebView.subproj/WebFrameView.m:
   6537         (-[WebFrameView webCoreBridge]):
   6538         New to conform to WebCoreBridgeHolder protocol.
   6539 
   6540 2005-03-18  Richard Williamson   <rjw (a] apple.com>
   6541 	
   6542 	Fixed <rdar://problem/4057004> Data from XMLHTTPRequest is never dealloced
   6543 
   6544 	WebDataSource keeps an array of all the NSURLResponses associated
   6545 	with the load for a page.  This is used to playback delegate messages
   6546 	when loading from the page cache.  However, after the document
   6547 	has completed it's initial load, we continue to keep track of responses. 
   6548 	So, this has the consequence of keeping all the responses for a page
   6549 	around for the life of the page.  NSURLResponses are now very
   6550 	heavy.  They indirectly reference the resource data (via the
   6551 	download assessment dictionary).  This fix will keep
   6552 	references to responses around for those resources loaded during initial
   6553 	page load, but not after that point.
   6554 
   6555         Reviewed by Ken.
   6556 
   6557         * WebView.subproj/WebDataSource.m:
   6558         (-[WebDataSource _addResponse:]):
   6559         (-[WebDataSource _stopRecordingResponses]):
   6560         * WebView.subproj/WebDataSourcePrivate.h:
   6561         * WebView.subproj/WebFrame.m:
   6562         (-[WebFrame _opened]):
   6563 
   6564 2005-03-18  Ken Kocienda  <kocienda (a] apple.com>
   6565 
   6566         Reviewed by Darin
   6567 
   6568         Fix for this bug:
   6569         
   6570         <rdar://problem/4053729> Copy/paste of page with frames into Blot or Mail does nothing and loses insertion point
   6571 
   6572         * WebView.subproj/WebHTMLView.m:
   6573         (-[WebHTMLView _selectedArchive]): Wrap frameset documents in an iframe, so they can be pasted into 
   6574         existing documents which will have a body or frameset of their own.
   6575 
   6576 === Safari-407 ===
   6577 
   6578 2005-03-17  Richard Williamson   <rjw (a] apple.com>
   6579 
   6580 	Fixed <rdar://problem/4055562> REGRESSION (Tiger): Safari doesn't draw progressively-loaded JPEGs (www.theregister.co.uk, www.titantalk.com)
   6581 
   6582 	Anothe side effect of lazy loading of image meta data.  We now
   6583 	don't cache image size until size meta data is actually available.
   6584 
   6585         Reviewed by Darin.
   6586 
   6587         * WebCoreSupport.subproj/WebImageData.m:
   6588         (-[WebImageData size]):
   6589 
   6590 2005-03-16  David Harrison  <harrison (a] apple.com>
   6591 
   6592         Reviewed by Maciej.
   6593         
   6594         <rdar://problem/4048506> Deleting from beginning of editable div deletes other document elements
   6595         
   6596         Also changed WebCore.
   6597 
   6598         * WebView.subproj/WebHTMLView.m:
   6599         (-[WebHTMLView _shouldDeleteRange:]):
   6600         Added call to new bridge method canDeleteRange.
   6601 
   6602 2005-03-16  Ken Kocienda  <kocienda (a] apple.com>
   6603 
   6604         Reviewed by Darin
   6605 
   6606         Fix for this bug:
   6607         
   6608         <rdar://problem/4042935> undo doesn't work properly during inline input
   6609 
   6610         * WebView.subproj/WebHTMLView.m:
   6611         (-[WebHTMLView setMarkedText:selectedRange:]): Call new -[WebCoreBridge replaceMarkedTextWithText:] instead of 
   6612         -[WebCoreBridge replaceSelectionWithText:selectReplacement:smartReplace:]. The former call was just added in 
   6613         order to provide a better mapping of international text input onto the typing command/undo design.
   6614 
   6615 2005-03-15  Richard Williamson   <rjw (a] apple.com>
   6616 
   6617 	Fixed <rdar://problem/4040321> Exception: Someone's trying to encode a WebDataRequestParameters instance
   6618 
   6619 	If client mutates request use new Foundation SPI to address remove applewebdata properties	from request.
   6620 
   6621         Reviewed by Ken Kocienda.
   6622 
   6623         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   6624         (-[WebBaseResourceHandleDelegate willSendRequest:redirectResponse:]):
   6625         * WebView.subproj/WebDataProtocol.h:
   6626         * WebView.subproj/WebDataProtocol.m:
   6627         (+[NSURLRequest _webDataRequestPropertyKey]):
   6628 
   6629 2005-03-15  Ken Kocienda  <kocienda (a] apple.com>
   6630 
   6631         Reviewed by Vicki
   6632 
   6633         Fox for this bug:
   6634         
   6635         <rdar://problem/4052642> Each delete keystroke is in its own undo group; not included in undo group with other typing
   6636 
   6637         Calling -[WebCore setSelectedDOMRange:range affinity:] had the result of "closing" any active set of typing
   6638         keystrokes grouped together in a single undo operation. My change on 27 Jan to route delete keystrokes 
   6639         through _deleteRange:killRing:... made this feature regress. Previous to that change, the backwards delete
   6640         key went through separate code that is no longer in the tree that did not set the selection in the way
   6641         it is done now.
   6642         
   6643         The solution is to add an extra argument to the set-selection call. The WebCoreBridge now offers this method:
   6644         -[WebCore setSelectedDOMRange:range affinity:closeTyping:]. Now, callers must indicate whether setting the 
   6645         selection will act to close typing or not. The code changes below all add this new argument with the
   6646         appropriate value for closeTyping.
   6647 
   6648         * WebView.subproj/WebHTMLView.m:
   6649         (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]): Passes NO for closeTyping when
   6650         deletionAction is deleteKeyAction or forwardDeleteKeyAction; YES when deleteSelectionAction.
   6651         (-[WebHTMLView _expandSelectionToGranularity:]): Passes YES for closeTyping.
   6652         (-[WebHTMLView selectToMark:]): Passes YES for closeTyping.
   6653         (-[WebHTMLView swapWithMark:]): Passes YES for closeTyping.
   6654         (-[WebHTMLView transpose:]): Passes YES for closeTyping.
   6655         (-[WebHTMLView _selectMarkedText]): Passes NO for closeTyping.
   6656         (-[WebHTMLView _selectRangeInMarkedText:]): Passes NO for closeTyping.
   6657         * WebView.subproj/WebView.m:
   6658         (-[WebView setSelectedDOMRange:affinity:]): Passes YES for closeTyping.
   6659 
   6660 2005-03-14  Richard Williamson   <rjw (a] apple.com>
   6661 
   6662 	Fix <rdar://problem/4051389> 8A413: gifs animating too fast
   6663 
   6664         Reviewed by Maciej.
   6665 
   6666 	Match Mozilla's policy for minimum frame duration, which is somewhat odd:
   6667 
   6668 	<= 0.01 sec use .1 sec, otherwise use specified duration.
   6669 
   6670         * WebCoreSupport.subproj/WebImageData.m:
   6671         (-[WebImageData _frameDurationAt:]):
   6672 
   6673 2005-03-14  Darin Adler  <darin (a] apple.com>
   6674 
   6675         Reviewed by Harrison.
   6676 
   6677         - fixed <rdar://problem/4049776> Seed: Mail: Disable spellcheck leaves red artifacts
   6678 
   6679         * WebView.subproj/WebFrameInternal.h: Added _unmarkAllMisspellings.
   6680         * WebView.subproj/WebFrame.m: (-[WebFrame _unmarkAllMisspellings]): Added.
   6681         Calls unmarkAllMisspellings on the bridge and self and all subframes.
   6682 
   6683         * WebView.subproj/WebView.m: (-[WebView setContinuousSpellCheckingEnabled:]):
   6684         Call _unmarkAllMisspellings on the main frame when turning continuous spell checking off.
   6685 
   6686 2005-03-14  Richard Williamson   <rjw (a] apple.com>
   6687 
   6688 	Fixed <rdar://problem/4027928> Tiger_8A394:Acrobat crashes while tried to remove the subscription errors by clicking on "Would you like to remove the subscription" from Tracker details view pane
   6689 
   6690 	The Acrobat application triggers loads of new documents in it's policy delegate.  This
   6691 	ultimately causes the WebHTMLView to be released before their event handlers have
   6692 	returned.  To bullet proof against this case we retain/release self before passing
   6693 	the event on for further handling.
   6694 	
   6695         Reviewed by Maciej.
   6696 
   6697         * WebView.subproj/WebHTMLView.m:
   6698         (-[WebHTMLView _updateMouseoverWithEvent:]):
   6699         (-[WebHTMLView scrollWheel:]):
   6700         (-[WebHTMLView mouseDown:]):
   6701         (-[WebHTMLView mouseDragged:]):
   6702         (-[WebHTMLView mouseUp:]):
   6703         (-[WebHTMLView keyDown:]):
   6704         (-[WebHTMLView keyUp:]):
   6705         (-[WebHTMLView performKeyEquivalent:]):
   6706 
   6707 2005-03-14  Vicki Murley  <vicki (a] apple.com>
   6708 
   6709 	- roll out the fix for 4040321, since it is still pending CCC review.
   6710 
   6711     2005-03-10  Richard Williamson   <rjw (a] apple.com>
   6712 
   6713         Fixed <rdar://problem/4040321> Exception: Someone's trying to encode a WebDataRequestParameters instance 
   6714 
   6715         Reviewed by Darin.
   6716 
   6717         If a delegate returns a mutated applewebdata: request in it's willSendRequest:
   6718         method, we don't load using the WebDataRequest.  Instead we do a normal load.
   6719         Unfortunately, if the request they return is mutated *copy* of the applewebdata: 
   6720         request it will hold the applewebdata: special properties.  These properties 
   6721         will be encoded into the cache.   They should not be.  So, to fix, we sanitize the
   6722         request, by removing the special properties from the request.
   6723 
   6724         Note that we had to dig into the private guts of NSURLRequest because there is
   6725         no public mechanism to remove properties from a request, see 4046775.
   6726 
   6727         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   6728         (-[WebBaseResourceHandleDelegate willSendRequest:redirectResponse:]):
   6729         * WebView.subproj/WebDataProtocol.h:
   6730         * WebView.subproj/WebDataProtocol.m:
   6731         (-[NSURLRequest _webDataRequestExternalRequest]):
   6732         (-[NSURLRequest _webDataRequestSanitize]):
   6733 
   6734 === Safari-406 ===
   6735 
   6736 2005-03-13  Darin Adler  <darin (a] apple.com>
   6737 
   6738         Reviewed by Ken and Maciej.
   6739 
   6740         - fixed <rdar://problem/4049040> REGRESSION (403-405): security check prevents user stylesheet from loading (Dictionary.app doesn't work at all!)
   6741 
   6742         * Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
   6743         Allow plug-in subresource streams to load with any URL, ignoring the "canLoadURL" method's restriction (only
   6744         file URLs can load other file URLs), which now applies only to main resources, like web pages in frames or
   6745         object tags and plug-in main resources.
   6746 
   6747         * WebCoreSupport.subproj/WebBridge.m:
   6748         (-[WebBridge startLoadingResource:withURL:customHeaders:]): Allow subresources to load with any URL, as above.
   6749         This allows things like images, stylesheets, and JavaScript to be loaded without the "canLoadURL" method's
   6750         restriction.
   6751         (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): Ditto.
   6752         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Ditto.
   6753 
   6754 2005-03-10  Richard Williamson   <rjw (a] apple.com>
   6755 
   6756 	Fixed <rdar://problem/4040321> Exception: Someone's trying to encode a WebDataRequestParameters instance 
   6757 
   6758         Reviewed by Darin.
   6759 
   6760 	If a delegate returns a mutated applewebdata: request in it's willSendRequest:
   6761 	method, we don't load using the WebDataRequest.  Instead we do a normal load.
   6762 	Unfortunately, if the request they return is mutated *copy* of the applewebdata: 
   6763 	request it will hold the applewebdata: special properties.  These properties 
   6764 	will be encoded into the cache.   They should not be.  So, to fix, we sanitize the
   6765 	request, by removing the special properties from the request.
   6766 
   6767 	Note that we had to dig into the private guts of NSURLRequest because there is
   6768 	no public mechanism to remove properties from a request, see 4046775.
   6769 
   6770         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   6771         (-[WebBaseResourceHandleDelegate willSendRequest:redirectResponse:]):
   6772         * WebView.subproj/WebDataProtocol.h:
   6773         * WebView.subproj/WebDataProtocol.m:
   6774         (-[NSURLRequest _webDataRequestExternalRequest]):
   6775         (-[NSURLRequest _webDataRequestSanitize]):
   6776 
   6777 === Safari-405 ===
   6778 
   6779 2005-03-10  Maciej Stachowiak  <mjs (a] apple.com>
   6780 
   6781         Reviewed by Vicki.
   6782 
   6783 	<rdar://problem/4046510> REGRESSION (TOT): All Flash and Shockwave plugin-based web content missing
   6784         
   6785 	* Plugins.subproj/WebNetscapePluginStream.m:
   6786         (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
   6787 
   6788 2005-03-10  John Sullivan  <sullivan (a] apple.com>
   6789 
   6790         Reviewed by Vicki.
   6791         
   6792         - fixed <rdar://problem/4045843> Going back/forward to error page 
   6793         hits assertion in -[WebDataSource(WebPrivate) _setData:]
   6794 
   6795         * WebView.subproj/WebDataSource.m:
   6796         (-[WebDataSource _setData:]):
   6797         Removed bogus assertion
   6798 
   6799 2005-03-09  Deborah Goldsmith  <goldsmit (a] apple.com>
   6800 
   6801         Reviewed by Darin.
   6802 
   6803         - fixed <rdar://problem/3997044> default encoding for non-Latin incorrect
   6804 
   6805 	* WebKit/WebView.subproj/WebPreferences.m: (+[WebPreferences _systemCFStringEncoding]):
   6806         Call __CFStringGetUserDefaultEncoding to get region, and TECGetWebTextEncodings to get
   6807         the first encoding to determine the default encoding.
   6808 
   6809 2005-03-09  Darin Adler  <darin (a] apple.com>
   6810 
   6811         Reviewed by Richard.
   6812 
   6813         - fixed <rdar://problem/4034175> REGRESSION (Mail): Can't use any font with style Light/Condensed/Semibold/Extrabold, etc
   6814 
   6815         * WebView.subproj/WebHTMLView.m:
   6816         (-[WebHTMLView _styleFromFontAttributes:]): Use a constant instead of hard-coded weight for clarity.
   6817         (-[WebHTMLView _originalFontA]): Ditto.
   6818         (-[WebHTMLView _originalFontB]): Ditto.
   6819         (-[WebHTMLView _addToStyle:fontA:fontB:]): Add code to detect the case where the family name is not good enough
   6820         to specify the font precisely. In that case, use the Postscript font name instead. Also change variable names
   6821         so it's easier to understand the method.
   6822 
   6823 2005-03-06  Maciej Stachowiak  <mjs (a] apple.com>
   6824 
   6825         Reviewed by Darin.
   6826 
   6827 	<rdar://problem/4005575> Arbitrary file disclosure vulnerability due to ability to load local html from remote content
   6828         
   6829 	* Plugins.subproj/WebBaseNetscapePluginView.m:
   6830         (-[WebBaseNetscapePluginView requestWithURLCString:]):
   6831         * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
   6832         (-[WebNetscapePluginEmbeddedView didStart]):
   6833         * Plugins.subproj/WebNetscapePluginStream.m:
   6834         (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
   6835         * WebCoreSupport.subproj/WebBridge.m:
   6836         (-[WebBridge createWindowWithURL:frameName:]):
   6837         (-[WebBridge startLoadingResource:withURL:customHeaders:]):
   6838         (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]):
   6839         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
   6840         (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
   6841         (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
   6842         (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
   6843         (-[WebBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
   6844         * WebView.subproj/WebFrame.m:
   6845         (-[WebFrame _loadURL:referrer:intoChild:]):
   6846         * WebView.subproj/WebFramePrivate.h:
   6847 
   6848 2005-03-09  Richard Williamson   <rjw (a] apple.com>
   6849 	
   6850 	Fixed <rdar://problem/4032938> Safari: text layout for MS P Gothic font is corrupted
   6851 
   6852 	The AppKit and ATS reports that MS P Gothic is fixed pitch.  It is
   6853 	not!  This is another case of "fixed pitch" being wrong.  I've
   6854 	coalesced all the special cases into our isFontFixedPitch:, and
   6855 	used a dictionary to improve speed.  No performance regression.
   6856 
   6857         Reviewed by Maciej.
   6858 
   6859         * WebCoreSupport.subproj/WebTextRenderer.m:
   6860         (-[WebTextRenderer _computeWidthForSpace]):
   6861         * WebCoreSupport.subproj/WebTextRendererFactory.m:
   6862         (-[WebTextRendererFactory clearCaches]):
   6863         (-[WebTextRendererFactory isFontFixedPitch:]):
   6864 
   6865 2005-03-09  Darin Adler  <darin (a] apple.com>
   6866 
   6867         Reviewed by Maciej.
   6868 
   6869         <rdar://problem/4040388> REGRESSION (172-173): nonrepro crash in -[NSString(WebNSURLExtras) _web_isUserVisibleURL]
   6870 
   6871         * Misc.subproj/WebNSURLExtras.m:
   6872         (-[NSString _web_isUserVisibleURL]): Fixed some pointer expressions that didn't include the index in the expression.
   6873         (readIDNScriptWhiteListFile): Removed NSLog statements in here since we decided they aren't useful and they will
   6874         write some messages on Tiger.
   6875 
   6876 2005-03-09  Darin Adler  <darin (a] apple.com>
   6877 
   6878         * DOM.subproj/DOMPrivate.h: Checked in file copied from WebCore.
   6879 
   6880 2005-03-08  Richard Williamson   <rjw (a] apple.com>
   6881 
   6882         Fixed <rdar://problem/4036949> many JPEG images fail to incremental-load due to change in ImageIO JPEG header parsing (to be fixed in WebKit)
   6883 	Fixed <rdar://problem/4042570> Need to check image properties for presence of width/height properties
   6884 
   6885 	ImageIO-55 changed how image properties are created.  They
   6886 	are now created incrementally.  So we need "re-get" the image
   6887 	properties if the properties we care about (width/height) aren't
   6888 	in the property dictionary.
   6889 
   6890         Reviewed by John.
   6891 
   6892         * WebCoreSupport.subproj/WebImageData.h:
   6893         * WebCoreSupport.subproj/WebImageData.m:
   6894         (-[WebImageData init]):
   6895         (-[WebImageData fileProperties]):
   6896         (-[WebImageData propertiesAtIndex:]):
   6897         (-[WebImageData _isSizeAvailable]):
   6898         (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]):
   6899         (-[WebImageData size]):
   6900 
   6901 2005-03-08  John Sullivan  <sullivan (a] apple.com>
   6902 
   6903         A couple of tweaks to the previous patch, from Darin's review.
   6904 
   6905         * Misc.subproj/WebNSPasteboardExtras.m:
   6906         (_writableTypesForImageWithoutArchive):
   6907         remove unnecessary _web prefix
   6908         (_writableTypesForImageWithArchive):
   6909         ditto
   6910         (+[NSPasteboard _web_writableTypesForImageIncludingArchive:]):
   6911         use mutableCopy rather than initWithArray:, and adjust for name changes
   6912 
   6913 2005-03-08  John Sullivan  <sullivan (a] apple.com>
   6914 
   6915         Reviewed by Ken.
   6916         
   6917         - fixed <rdar://problem/4031826> REGRESSION (Mail): standalone images from 
   6918         Safari can't be pasted into Mail (WebKit part of fix)
   6919         
   6920         We were always declaring webarchive-related pasteboard types, even in the standalone
   6921         image cases where we had no webarchive. Unfortunately, the WebView pasteboard-related
   6922         API doesn't prevent this kind of thing from happening, because the code that
   6923         declares the types isn't guaranteed to be anywhere near the code that writes
   6924         the pasteboard data.
   6925         
   6926         After this fix, I discovered that pasting standalone images into Mail still doesn't
   6927         work right, but the remaining issues seem to be entirely in Mail. I wrote up 4041671
   6928         to cover these.
   6929 
   6930         * Misc.subproj/WebNSPasteboardExtras.h:
   6931         (+[NSPasteboard _web_writableTypesForImageIncludingArchive:]):
   6932         Added boolean parameter; clients must specify whether or not there's an
   6933         archive involved, because the array of types is different if there is.
   6934 
   6935         * Misc.subproj/WebNSPasteboardExtras.m:
   6936         (_web_writableTypesForImageWithoutArchive):
   6937         new static function, constructs (once) and returns the array of types
   6938         for images that don't have archives
   6939         (_web_writableTypesForImageWithArchive):
   6940         new static function, constructs (once) and returns the array of types
   6941         for images that do have archives
   6942         (+[NSPasteboard _web_writableTypesForImageIncludingArchive:]):
   6943         added boolean parameter, now calls one of the two new static functions
   6944         
   6945         (-[NSPasteboard _web_writeImage:URL:title:archive:types:]):
   6946         added asserts that we aren't declaring the archive types if we don't have archive data
   6947         
   6948         (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]):
   6949         updated to pass parameter to _web_writableTypesForImageIncludingArchive:
   6950         
   6951         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   6952         (-[WebDefaultUIDelegate copyImageToClipboard:]):
   6953         updated to pass parameter to _web_writableTypesForImageIncludingArchive:
   6954 
   6955         * WebView.subproj/WebImageView.m:
   6956         (-[WebImageView copy:]):
   6957         updated to pass parameter to _web_writableTypesForImageIncludingArchive:
   6958 
   6959         * WebView.subproj/WebView.m:
   6960         (-[WebView pasteboardTypesForElement:]):
   6961         updated to pass parameter to _web_writableTypesForImageIncludingArchive:
   6962 
   6963 2005-03-07  Richard Williamson   <rjw (a] apple.com>
   6964 
   6965 	More bullet proofing for <rdar://problem/4038304> CrashTracer: ....9 crashes at com.apple.WebKit: -[WebTextRenderer initWithFont:usingPrinterFont:] + 840
   6966 
   6967 	Protect against removal of Times and Times New Roman from
   6968 	system.  If these fonts are removed attempt to get system font
   6969 	instead of FATAL_ALWAYS.
   6970 
   6971         Reviewed by John.
   6972 
   6973         * WebCoreSupport.subproj/WebTextRenderer.m:
   6974         (-[WebTextRenderer initWithFont:usingPrinterFont:]):
   6975 
   6976 === Safari-403 ===
   6977 
   6978 2005-03-06  Darin Adler  <darin (a] apple.com>
   6979 
   6980         - fixed obvious mistake in IDN script code (luckily it hasn't been in a submission yet!)
   6981 
   6982         * Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Use "index" to index into the array,
   6983         not "script", which is the script number, not the 32-bit-word index.
   6984 
   6985 2005-03-05  Kevin Decker  <kdecker (a] apple.com>
   6986 
   6987         Reviewed by Darin.
   6988 
   6989 	Fixed: <rdar://problem/4038529> Infinite progress bar loading webcams and other sites that use multipart/x-mixed-replace
   6990 
   6991 	The previous patch I landed prevented us from loading multipart/x-mixed-replace but did not always update the progress bar accordingly.  
   6992         This stops websites from having seemingly infinite progress in the browser UI.  
   6993 
   6994         * WebCoreSupport.subproj/WebSubresourceClient.m:
   6995         (-[WebSubresourceClient didReceiveResponse:]): If this is "multipart/x-mixed-replace", remove the WebBaseResourceHandleDelegate client from 
   6996         the datasource's subresource array, otherwise -[WebDataSource isLoading] incorrectly returns YES.   Also it's possible at this point in
   6997          time we're done loading now (loaded everything else except for the multipart/x-mixed-replace content) so go ahead and check to see if 
   6998          in fact we're complete. 
   6999         * WebView.subproj/WebMainResourceClient.m:
   7000         (-[WebMainResourceClient connection:didReceiveResponse:]): ditto
   7001 
   7002 2005-03-05  Richard Williamson   <rjw (a] apple.com>
   7003 
   7004 	Fixed panther build problem.  Shouldn't include
   7005 	changes for 3968753 on panther.
   7006 
   7007         Reviewed by John.
   7008 
   7009         * WebView.subproj/WebView.m:
   7010         (-[WebView _commonInitializationWithFrameName:groupName:]):
   7011 
   7012 2005-03-05  Darin Adler  <darin (a] apple.com>
   7013 
   7014         Reviewed by John.
   7015 
   7016         - fixed <rdar://problem/4034603> REGRESSION (185-188): RadarWeb can't send enclosures anymore
   7017 
   7018         * WebView.subproj/WebFormDataStream.m:
   7019         (closeCurrentStream): Release currentData when closing the stream.
   7020         (advanceCurrentStream): Set up and retain currentData when the current stream is reading that data, so the
   7021         data won't be released while in use.
   7022         (formCreate): Initialize currentData to NULL.
   7023 
   7024         - fixed <rdar://problem/4037562> Tiger8A402: Help Viewer crashed when viewing help for iChat (infinite recursion in WebView)
   7025 
   7026         * WebView.subproj/WebView.m: (-[WebView _responderValidateUserInterfaceItem:]):
   7027         Check for the case where we ourselves are the responder. This avoids an infinite loop.
   7028         The actual code to perform operations avoids this with a global variable, but this lighter weight
   7029         solution is sufficient here because validate operations don't call through to the next responder.
   7030 
   7031 2005-03-04  Richard Williamson   <rjw (a] apple.com>
   7032 
   7033 	Fixed <rdar://problem/3968753> REGRESSION: Poor performance with differing multiple animated GIFs (was fast in Panther)
   7034 
   7035 	Disable coalesced updates (in CG).  This restores the
   7036 	panther behavior.
   7037 
   7038         Reviewed by David Harrison.
   7039 
   7040         * WebView.subproj/WebView.m:
   7041         (-[WebView _commonInitializationWithFrameName:groupName:]):
   7042 
   7043 2005-03-04  Adele Amchan  <adele (a] apple.com>
   7044 
   7045         Reviewed by Darin.
   7046 
   7047         * English.lproj/StringsNotToBeLocalized.txt: added new strings "text/x-vcf" and "text/x-csv" to the list
   7048 
   7049 2005-03-04  Adele Amchan  <adele (a] apple.com>
   7050 
   7051         Reviewed by Chris.
   7052 
   7053         Fix for <rdar://problem/4032982> Sun iPlanet app: not able to import AddressBook CSV format addresses properly
   7054         Fix for <rdar://problem/4032985> Sun iPlanet app: not able to import vCard format addresses properly
   7055 
   7056         * WebView.subproj/WebTextView.m:
   7057         (+[WebTextView unsupportedTextMIMETypes]): added "text/x-csv" and "text/x-vcf" to the list of MIME types that our text view doesn't handle
   7058 
   7059 2005-03-04  Darin Adler  <darin (a] apple.com>
   7060 
   7061         Reviewed by John.
   7062 
   7063         - fixed <rdar://problem/4036817> REGRESSION: ctrl-y broken when a line + carriage return cut
   7064 
   7065         * WebView.subproj/WebHTMLView.m:
   7066         (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]): Merged _handleKillRing behavior
   7067         into this function, since there's now a more-complicated way the startNewKillRingSequence boolean needs to
   7068         be handled. Set the startNewKillRingSequence boolean after the entire process so changing the selection before
   7069         and during the editing dosn't clear it. Also change "isTypingAction" parameter to "deletionAction" so we can
   7070         handle forward delete with this method.
   7071         (-[WebHTMLView _deleteSelection]): Pass deleteSelectionAction for action rather than NO for isTypingAction,
   7072         which is the way to say the same thing using the new parameter.
   7073         (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Refactor to use the _deleteRange
   7074         method above. Also calls _shouldDeleteRange: for the pre-existing selection case; not doing that before was
   7075         a bug.
   7076         (-[WebHTMLView deleteToMark:]): Pass deleteSelectionAction for action rather than NO for isTypingAction,
   7077         which is the way to say the same thing using the new parameter.
   7078 
   7079 2005-03-04  Darin Adler  <darin (a] apple.com>
   7080 
   7081         Reviewed by John.
   7082 
   7083         - fixed <rdar://problem/4020413> REGRESSION (Mail): can't use fonts with names that start with "#" in Mail (Korean fonts)
   7084 
   7085         * WebView.subproj/WebHTMLView.m:
   7086         (-[WebHTMLView _styleFromFontAttributes:]): Quote font name when calling setFontFamily.
   7087         (-[WebHTMLView _addToStyle:fontA:fontB:]): Ditto.
   7088 
   7089 2005-03-04  Darin Adler  <darin (a] apple.com>
   7090 
   7091         Reviewed by John.
   7092 
   7093         - fixed <rdar://problem/3965666> IDN spoofing vulnerability caused by Unicode characters that look like ASCII characters
   7094 
   7095         * Misc.subproj/WebNSURLExtras.m:
   7096         (readIDNScriptWhiteListFile): Added. Reads file and parses script names.
   7097         (readIDNScriptWhiteList): Added. Calls readIDNScriptWhiteList on each of the white list locations in succession.
   7098         (allCharactersInIDNScriptWhiteList): Renamed from containsPossibleLatinLookalikes and changed sense.
   7099         Now calls readIDNScriptWhiteList first time, and then uses the read-in list to check the scripts.
   7100         (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call allCharactersInIDNScriptWhiteList instead of
   7101         containsPossibleLatinLookalikes.
   7102         * Resources/IDNScriptWhiteList.txt: Added.
   7103         * WebKit.pbproj/project.pbxproj: Added IDNScriptWhiteList.txt file.
   7104 
   7105         * Misc.subproj/WebKitLocalizableStrings.m: Removed. This is simply unused.
   7106         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
   7107 
   7108 2005-03-04  Darin Adler  <darin (a] apple.com>
   7109 
   7110         Reviewed by John.
   7111 
   7112         - fixed <rdar://problem/3937667> REGRESSION (Mail): Zooming a window from titlebar button doesn't paint newly-exposed portions of window
   7113 
   7114         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
   7115         Re-set-up the visRect if the bounds changes due to layout.
   7116 
   7117 === Safari-402 ===
   7118 
   7119 2005-03-03  Jens Alfke  <jens (a] apple.com>
   7120 
   7121         Reviewed by rjw.
   7122 
   7123 	<rdar://problem/3991818> REGRESSION: Images scale while loading
   7124 	The code could crop an image when not all the scanlines were available yet, and it could crop when only a sub-rect of the image was to be drawn; but if it had to do both at once, it got the coordinates wrong. Fixed that.
   7125 
   7126         * WebCoreSupport.subproj/WebImageData.m:
   7127         (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]):
   7128 
   7129 2005-03-01  David Hyatt  <hyatt (a] apple.com>
   7130 
   7131 	Fix for 3841186, scrollbar shows up disabled when it should not appear at all.  Make sure updateScrollers
   7132 	is never allowed to be re-entrant from any call point by moving the guard inside the function itself.
   7133 	
   7134         Reviewed by John Sullivan
   7135 
   7136         * WebView.subproj/WebDynamicScrollBarsView.m:
   7137         (-[WebDynamicScrollBarsView updateScrollers]):
   7138         (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
   7139 
   7140 2005-03-02  Chris Blumenberg  <cblu (a] apple.com>
   7141 
   7142 	Fixed: <rdar://problem/4029010> Expose method to retrieve drag image for WebView's selection
   7143 
   7144         Reviewed by sullivan.
   7145 
   7146         * WebView.subproj/WebHTMLView.m:
   7147         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): call _selectionDraggingImage
   7148         (-[WebHTMLView _selectionDraggingImage]): new SPI for Mail, factored from previous method
   7149         (-[WebHTMLView _selectionDraggingRect]): new SPI for Mail
   7150         * WebView.subproj/WebHTMLViewPrivate.h:
   7151 
   7152 2005-03-02  John Sullivan  <sullivan (a] apple.com>
   7153 
   7154         Reviewed by Adele.
   7155         
   7156         - fixed <rdar://problem/4023337> Safari stops loading any page (-[NSCFDictionary setObject:forKey:]: 
   7157         attempt to insert nil key)
   7158         
   7159         It is very likely that the exception being hit is caused by the same problem as WebFoundation
   7160         bug 4018486. This change makes the code robust against this kind of problem regardless.
   7161 
   7162         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   7163         (-[WebBaseResourceHandleDelegate saveResource]):
   7164         Don't call addSubresource if newly-created resource is nil (but do assert on debug builds).
   7165         Also assert that originalURL and MIMEType are not nil.
   7166         
   7167         * WebView.subproj/WebDataSource.m:
   7168         (-[WebDataSource addSubresource:]):
   7169         Don't add nil subresource to dictionary, but do assert on debug builds.
   7170 
   7171 === Safari-401 ===
   7172 
   7173 2005-03-01  John Sullivan  <sullivan (a] apple.com>
   7174 
   7175         Reviewed by Darin.
   7176         
   7177         - fixed <rdar://problem/3987482> Format>Style>Italic is not enabled when a 
   7178         compose window is empty (works in Blot)
   7179 
   7180         * WebView.subproj/WebHTMLView.m:
   7181         (-[WebHTMLView becomeFirstResponder]):
   7182         call _updateFontPanel here so NSFontManager knows the right font for the menu
   7183         items and the font panel
   7184 
   7185 2005-03-01  David Harrison  <harrison (a] apple.com>
   7186 
   7187         Reviewed by Chris.
   7188         
   7189         <rdar://problem/3915560> Mail would like an SPI to enable "smart" text paste/drop
   7190 
   7191         * WebView.subproj/WebHTMLView.m:
   7192         (-[WebHTMLView _smartDeleteRangeForProposedRange:]):
   7193         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]):
   7194         New.
   7195 
   7196 2005-02-28  John Sullivan  <sullivan (a] apple.com>
   7197 
   7198         Reviewed by Ken.
   7199         
   7200         - WebKit part of fix for <rdar://problem/4023490> REGRESSION (125-185): Tabbing through links 
   7201         on frameset page gets stuck at end (tivofaq.com)
   7202         
   7203         This tab-to-links stuff has been in shaky condition ever since AppKit futzed with
   7204         tabbing behavior in Tiger to add support for including the toolbar in the key loop.
   7205         I made some changes months ago to compensate for that, but some cases, such as this
   7206         one, still weren't fixed.
   7207 
   7208         * WebCoreSupport.subproj/WebBridge.m:
   7209         (-[WebBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]):
   7210         new bottleneck method, extracted from nextKeyViewOutsideWebFrameViews; handles
   7211         nextKeyView or nextValidKeyView depending on parameter.
   7212         (-[WebBridge nextKeyViewOutsideWebFrameViews]):
   7213         now calls extracted method
   7214         (-[WebBridge nextValidKeyViewOutsideWebFrameViews]):
   7215         new method, calls new bottleneck method
   7216         
   7217         * WebView.subproj/WebHTMLView.m:
   7218         (-[WebHTMLView nextValidKeyView]):
   7219         when we're stuck at the end of a nextKeyView chain inside a nexted frame, use
   7220         nextValidKeyViewOutsideWebFrameViews. Make sure we don't end up looking inside
   7221         the web frame views while doing this.
   7222 
   7223 2005-02-25  Darin Adler  <darin (a] apple.com>
   7224 
   7225         Reviewed by John.
   7226 
   7227         - fixed <rdar://problem/4025088> window onblur and onfocus don't fire when text field has focus
   7228 
   7229         * WebView.subproj/WebHTMLView.m:
   7230         (-[WebHTMLView updateFocusState]): Renamed from updateFocusDisplay. Added call to setWindowHasFocus: method.
   7231         (-[WebHTMLView viewDidMoveToWindow]): Call method by new name.
   7232         (-[WebHTMLView windowDidBecomeKey:]): Ditto.
   7233         (-[WebHTMLView windowDidResignKey:]): Ditto.
   7234         (-[WebHTMLView becomeFirstResponder]): Ditto.
   7235         (-[WebHTMLView resignFirstResponder]): Ditto.
   7236 
   7237 === Safari-400 ===
   7238 
   7239 2005-02-25  Richard Williamson   <rjw (a] apple.com>
   7240 
   7241 	Fixed <rdar://problem/4000962> 8A375: Help Viewer displays voiced sound and semi-voiced characters strangely (characters don't seem to be composed)
   7242 
   7243 	Added special case for voiced marks.
   7244 
   7245         Reviewed by John.
   7246 
   7247         * WebCoreSupport.subproj/WebTextRenderer.m:
   7248         (widthForNextCharacter):
   7249 
   7250 2005-02-25  Darin Adler  <darin (a] apple.com>
   7251 
   7252         Reviewed by John.
   7253 
   7254         - fixed <rdar://problem/4019823> Seed: Control-Y doesn't work
   7255 
   7256         * WebView.subproj/WebHTMLView.m:
   7257         (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Call _handleKillRing
   7258         after setting the selection, since it uses the selection to get the text.
   7259         (-[WebHTMLView _insertText:selectInsertedText:]): Check for empty string to avoid an assertion
   7260         on the other side of the bridge when you yank the empty string.
   7261 
   7262 2005-02-24  Richard Williamson   <rjw (a] apple.com>
   7263 
   7264 	Fixed <rdar://problem/3382926> Bidi neutrals at RTL/LTR boundaries not handled correctly.
   7265 
   7266 	If directionality is specified use that as initial directionality,
   7267 	rather than neutral directionality.	
   7268 
   7269         Reviewed by Hyatt.
   7270 
   7271         * WebCoreSupport.subproj/WebTextRenderer.m:
   7272         (widthForNextCharacter):
   7273 
   7274 2005-02-24  Adele Amchan  <adele (a] apple.com>
   7275 
   7276         Reviewed by Chris.
   7277        
   7278         Fix for <rdar://problem/4023393> Safari crashed in khtml::RenderObject::repaintAfterLayoutIfNeeded(QRect const&, QRect const&)
   7279 
   7280         We were crashing after hitting PageDown when viewing a pdf because 
   7281         WebKit was calling over to WebCore to scroll overflow areas.
   7282         Since this only needs to be done if we're dealing with a WebHTMLView, 
   7283         I added a wrapper function to check the documentView before calling
   7284         over to WebCore.
   7285 
   7286         * WebView.subproj/WebFrameView.m:
   7287         (-[WebFrameView _scrollOverflowInDirection:granularity:]): added wrapper function that checks if documentView is a WebHTMLView 
   7288         (-[WebFrameView scrollToBeginningOfDocument:]): uses new wrapper function now
   7289         (-[WebFrameView scrollToEndOfDocument:]): uses new wrapper function now
   7290         (-[WebFrameView _pageVertically:]): uses new wrapper function now
   7291         (-[WebFrameView _pageHorizontally:]): uses new wrapper function now
   7292         (-[WebFrameView _scrollLineVertically:]): uses new wrapper function now
   7293         (-[WebFrameView _scrollLineHorizontally:]): uses new wrapper function now
   7294 
   7295 2005-02-24  Richard Williamson   <rjw (a] apple.com>
   7296 
   7297 	Fixed <rdar://problem/3985889> REGRESSION (125-180): setting <img> src to GIF that already animated does not animate; just shows final frame
   7298 	
   7299         Reviewed by Hyatt.
   7300 
   7301         * WebCoreSupport.subproj/WebImageData.h:
   7302         * WebCoreSupport.subproj/WebImageData.m:
   7303         (-[WebImageData resetAnimation]):
   7304         * WebCoreSupport.subproj/WebImageRenderer.m:
   7305         (-[WebImageRenderer resetAnimation]):
   7306         (-[WebInternalImage resetAnimation]):
   7307         (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
   7308 
   7309 2005-02-24  Kevin Decker  <kdecker (a] apple.com>
   7310 
   7311         Reviewed by John.
   7312 
   7313 	Fixed <rdar://problem/3962401> Don't load multipart/x-mixed-replace content to prevent memory leak
   7314 
   7315 	Since we're not going to fix <rdar://problem/3087535> for Tiger, we should not load multipart/x-mixed-replace content.  Pages with such content contain what is essentially an infinite load and therefore may leak.
   7316 
   7317         * WebView.subproj/WebMainResourceClient.m: 
   7318         (-[WebMainResourceClient connection:didReceiveResponse:]):  Disabled loading of multipart/x-mixed-replace content until we fully implement server side push. 
   7319     	 * WebCoreSupport.subproj/WebSubresourceClient.m: 
   7320         (-[WebSubresourceClient didReceiveResponse:]): Ditto. Same exact thing for sub resources. 
   7321 
   7322 
   7323 2005-02-23  John Sullivan  <sullivan (a] apple.com>
   7324 
   7325         Reviewed by Ken.
   7326         
   7327         - fixed <rdar://problem/4021370> REGRESSION (Tiger): WebKit part of fix for 
   7328         shift-tab on tivofaq doing the wrong thing
   7329 
   7330         * WebView.subproj/WebFrameView.m:
   7331         (-[WebFrameView becomeFirstResponder]):
   7332         If our previousValidKeyView is nil or self (same as nil modulo AppKit oddness),
   7333         look out of the box and get the previousValidKeyView of our webview.
   7334 
   7335 2005-02-23  Darin Adler  <darin (a] apple.com>
   7336 
   7337         Reviewed by Hyatt.
   7338 
   7339         - fixed <rdar://problem/4010196> REGRESSION (125-186+): 8-character timestamps in gmail wrap to 2 lines (width:8ex; font-size:80%)
   7340 
   7341         * WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer xHeight]): Return the maximum
   7342         of the "x" height and width. Comment in the code explains why in more detail.
   7343 
   7344 2005-02-22  Richard Williamson   <rjw (a] apple.com>
   7345 
   7346 	Fixed <rdar://problem/3937203> when a div adds a scrollbar (overflow:auto) we do not get regions
   7347 
   7348 	Compare regions after automatice scroll regions have been
   7349 	added.
   7350 
   7351         Reviewed by Maciej.
   7352 
   7353         * WebCoreSupport.subproj/WebBridge.h:
   7354         * WebCoreSupport.subproj/WebBridge.m:
   7355         (-[WebBridge dealloc]):
   7356         (-[WebBridge _compareDashboardRegions:]):
   7357         (-[WebBridge dashboardRegionsChanged:]):
   7358 
   7359 2005-02-22  Richard Williamson   <rjw (a] apple.com>
   7360 
   7361 	Fixed <rdar://problem/4012463> Dashboard widgets don't work with authenticating proxies
   7362 
   7363 	Added new SPI for dashboard that just calls default delegate
   7364 	behavior.
   7365 
   7366         Reviewed by Maciej.
   7367 
   7368         * WebView.subproj/WebView.m:
   7369         (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
   7370         * WebView.subproj/WebViewPrivate.h:
   7371 
   7372 2005-02-22  Chris Blumenberg  <cblu (a] apple.com>
   7373 
   7374         Reviewed by mjs.
   7375 
   7376         * WebCoreSupport.subproj/WebBridge.m:
   7377         (-[WebBridge issuePasteAndMatchStyleCommand]): support for new "PasteAndMatchStyle" exec command
   7378 
   7379 === Safari-188 ===
   7380 
   7381 2005-02-21  David Harrison  <harrison (a] apple.com>
   7382 
   7383         Reviewed by Darin.
   7384 
   7385         <rdar://problem/3943090> REGRESSION (Mail): Spelling underline incompletely erased following certain steps
   7386 
   7387         * WebCoreSupport.subproj/WebTextRenderer.m:
   7388         (-[WebTextRenderer misspellingLineThickness]):
   7389         (-[WebTextRenderer misspellingLinePatternWidth]):
   7390         Replaced #defines with these methods, so others can get the same info.
   7391         
   7392         (-[WebTextRenderer drawLineForMisspelling:withWidth:]):
   7393         Keep underline within originally specified bounds.
   7394         
   7395 
   7396 2005-02-21  Darin Adler  <darin (a] apple.com>
   7397 
   7398         Reviewed by John.
   7399 
   7400         - fixed <rdar://problem/4016358> don't ever display IDN URLs with characters from "possible Latin look-alike" scripts
   7401 
   7402         * Misc.subproj/WebNSURLExtras.m:
   7403         (containsPossibleLatinLookalikes): Added.
   7404         (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call containsPossibleLatinLookalikes, and if true,
   7405         don't decode the host name.
   7406 
   7407 2005-02-19  Kevin Decker  <kdecker (a] apple.com>
   7408 
   7409         Reviewed by Chris.
   7410 
   7411 	Fixed <rdar://problem/4010765> Flash player can be used to arbitrarily open popup windows without user permission
   7412 	
   7413 	Our window.open() policy is to refuse the <script>window.open(...)</script> case and allow the inline the <a href="javascript:window.open('foo')> case.  Clever advertisers at some point realized that by executing their Javascript through the Flash plugin, Safari would always treat their code as the inline case, and thus, they were able to work around our popup blocker. 
   7414 
   7415         * Plugins.subproj/WebBaseNetscapePluginView.h: Addded currentEventIsUserGesture boolean ivar. 
   7416         * Plugins.subproj/WebBaseNetscapePluginView.m:
   7417         (-[WebBaseNetscapePluginView sendEvent:]): If at any point the user clicks or presses a key from within a plugin, set the currentEventIsUserGesture flag to true. This is important to differentiate legitimate window.open() calls originating from plugins;  we still want to allow those. 
   7418         (-[WebBaseNetscapePluginView initWithFrame:]): In our asynchronous load, pass along currentEventIsUserGesture to the PluginRequest. 
   7419         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Inform WebCore if this was a user originated gesture when calling executeScript(). 
   7420         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
   7421         (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
   7422         (-[WebPluginRequest isCurrentEventUserGesture]): Added. 
   7423 
   7424 2005-02-18  Chris Blumenberg  <cblu (a] apple.com>
   7425 
   7426 	Fixed: <rdar://problem/3945271> REGRESSION (Mail): pasted plain text should pick up typing style instead of being unstyled
   7427 
   7428         Reviewed by kocienda.
   7429 
   7430         * WebView.subproj/WebDataSource.m:
   7431         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): pass NO for matchStyle to replaceSelection
   7432         * WebView.subproj/WebHTMLView.m:
   7433         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:chosePlainText:]): return new chosePlainText parameter
   7434         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): pass chosePlainText for matchStyle to replaceSelection
   7435         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): ditto
   7436 
   7437 2005-02-17  Richard Williamson   <rjw (a] apple.com>
   7438 
   7439 	Removed code that should not have been checked in from
   7440 	last patch.
   7441 
   7442         * WebCoreSupport.subproj/WebTextRendererFactory.m:
   7443         (-[WebTextRendererFactory isFontFixedPitch:]):
   7444 
   7445 2005-02-17  Richard Williamson   <rjw (a] apple.com>
   7446 
   7447         Fixed <rdar://problem/3999467> when Osaka-Mono is specified as fixed width font, Osaka used instead
   7448 
   7449 	Fixed w/o introducing a performance regression.
   7450 
   7451         Reviewed by Vicki (and earlier by Dave Harrison).
   7452 
   7453         * WebCoreSupport.subproj/WebTextRenderer.m:
   7454         (-[WebTextRenderer _computeWidthForSpace]):
   7455         (widthForNextCharacter):
   7456         * WebCoreSupport.subproj/WebTextRendererFactory.h:
   7457         * WebCoreSupport.subproj/WebTextRendererFactory.m:
   7458         (-[NSFont _web_isFakeFixedPitch]):
   7459         (-[WebTextRendererFactory isFontFixedPitch:]):
   7460         (-[WebTextRendererFactory fontWithFamily:traits:size:]):
   7461 
   7462 2005-02-17  Richard Williamson   <rjw (a] apple.com>
   7463 
   7464 	Fixed <rdar://problem/3959304> PDF in img tag is not rendered correctly anymore
   7465 
   7466 	We were incorrectly adding image position when flipping coordinates.
   7467 
   7468         Reviewed by David Harrison.
   7469 
   7470         * WebCoreSupport.subproj/WebImageData.m:
   7471         (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
   7472 
   7473 2005-02-17  Richard Williamson   <rjw (a] apple.com>
   7474 
   7475 	Fixed <rdar://problem/4007262> Seed: Flight tracker scrolling moves to the left
   7476 
   7477 	Added SPI for dashboard to disable wheel scrolling of the WebClipView.
   7478 
   7479         Reviewed by Ken.
   7480 
   7481         * ChangeLog:
   7482         * WebView.subproj/WebClipView.m:
   7483         (-[WebClipView _focusRingVisibleRect]):
   7484         (-[WebClipView scrollWheel:]):
   7485         * WebView.subproj/WebView.m:
   7486         (-[WebViewPrivate init]):
   7487         (-[WebView drawRect:]):
   7488         (-[WebView _dashboardBehavior:]):
   7489         * WebView.subproj/WebViewInternal.h:
   7490         * WebView.subproj/WebViewPrivate.h:
   7491 
   7492 === Safari-187 ===
   7493 
   7494 2005-02-17  Vicki Murley <vicki (a] apple.com>
   7495 
   7496 	- roll out this change, since it causes a 1.5% performance regression
   7497 
   7498     2005-02-15  Richard Williamson   <rjw (a] apple.com>
   7499         
   7500         Fixed <rdar://problem/3999467> when Osaka-Mono is specified as fixed width font, Osaka used instead
   7501         
   7502         Lie about Osaka-Mono.  Treat it as fixed pitch, even though,
   7503         strictly speaking it isn't.  (Similar to what we do with
   7504         Courier New.)
   7505 
   7506         Reviewed by David Harrison.
   7507 
   7508         * WebCoreSupport.subproj/WebTextRenderer.m:
   7509         (-[WebTextRenderer _computeWidthForSpace]):
   7510         * WebCoreSupport.subproj/WebTextRendererFactory.h:
   7511         * WebCoreSupport.subproj/WebTextRendererFactory.m:
   7512         (-[NSFont _web_isFakeFixedPitch]): 
   7513         (-[WebTextRendererFactory isFontFixedPitch:]):
   7514         (-[WebTextRendererFactory fontWithFamily:traits:size:]):
   7515 
   7516 2005-02-17  John Sullivan  <sullivan (a] apple.com>
   7517 
   7518         Reviewed by Ken.
   7519         
   7520         - fixed <rdar://problem/3997185> The Web view on .Mac Prefs caused System Prefs 
   7521         to lockup (resolved by re-boot only)
   7522 
   7523         * WebCoreSupport.subproj/WebBridge.m:
   7524         (-[WebBridge nextKeyViewOutsideWebFrameViews]):
   7525         Don't allow recursion here; assert on debug build, return nil on deployment. I
   7526         couldn't get my machine into a state to repro this problem (and neither could the
   7527         originator), but it's obvious from the stack crawl that this method was recursing
   7528         when it shouldn't have.
   7529 
   7530 2005-02-16  John Sullivan  <sullivan (a] apple.com>
   7531 
   7532         Written by Darin, reviewed by me.
   7533         
   7534         - WebKit part of fix for <rdar://problem/4007384> 
   7535         FILTER: Bookmark of RSS with Japanese search word & multiple RSS pages loses filter
   7536 
   7537         * DOM.subproj/DOMPrivate.h:
   7538         updated this file, which is a copy of the WebCore version
   7539 
   7540 2005-02-16  Richard Williamson   <rjw (a] apple.com>
   7541 
   7542 	Fixed <rdar://problem/3966973> Tiger 8A357: Binary Compatiblity: frequent Webstractor.app crashes [WebImageData _nextFrame]
   7543 
   7544 	Webstractor.app was playing tricks to create thumbnails of
   7545 	pages.  This caused the 'focusView' to be incorrect during
   7546 	animated GIF frame rendering.
   7547 
   7548         Reviewed by Chris.
   7549 
   7550         * WebCoreSupport.subproj/WebImageRenderer.m:
   7551         (-[WebImageRenderer _startOrContinueAnimationIfNecessary]):
   7552 
   7553 2005-02-16  Vicki Murley  <vicki (a] apple.com>
   7554 
   7555         Reviewed by me, code change by Darin.
   7556 
   7557         - fixed the build on Panther
   7558 
   7559         * WebView.subproj/WebFormDataStream.m: (webSetHTTPBody):
   7560         Added a Panther-specific code path that just loads all the data into one big
   7561         NSData object. This means that bug 3686434 won't be fixed on SUPanWheat; we'll
   7562         still load the file into memory before sending it to the server on Panther.
   7563 
   7564 2005-02-15  Richard Williamson   <rjw (a] apple.com>
   7565 
   7566 	Fixed <rdar://problem/3998368> Tiger8A376: WebTextRenderer assertion failure in Safari while browsing news.bbc.co.uk
   7567 
   7568 	Removed use of FATAL_ALWAYS from getUncachedWidth().  It's unclear
   7569 	why we would trigger the FATAL_ALWAYS.  In the past we've seen
   7570 	the message triggered because of corrupt fonts.  Anyway, in this
   7571 	particular case, we will now return 0 for the character width,
   7572 	rather than exiting.
   7573 
   7574         Reviewed by David Harrison.
   7575 
   7576         * WebCoreSupport.subproj/WebTextRenderer.m:
   7577         (getUncachedWidth):
   7578 
   7579 2005-02-15  Richard Williamson   <rjw (a] apple.com>
   7580 
   7581 	Fixed <rdar://problem/3999467> when Osaka-Mono is specified as fixed width font, Osaka used instead
   7582 
   7583 	Lie about Osaka-Mono.  Treat it as fixed pitch, even though,
   7584 	strictly speaking it isn't.  (Similar to what we do with
   7585 	Courier New.)
   7586 
   7587         Reviewed by David Harrison.
   7588 
   7589         * WebCoreSupport.subproj/WebTextRenderer.m:
   7590         (-[WebTextRenderer _computeWidthForSpace]):
   7591         * WebCoreSupport.subproj/WebTextRendererFactory.h:
   7592         * WebCoreSupport.subproj/WebTextRendererFactory.m:
   7593         (-[NSFont _web_isFakeFixedPitch]):
   7594         (-[WebTextRendererFactory isFontFixedPitch:]):
   7595         (-[WebTextRendererFactory fontWithFamily:traits:size:]):
   7596 
   7597 2005-02-14  Darin Adler  <darin (a] apple.com>
   7598 
   7599         Reviewed by John.
   7600 
   7601         - fixed <rdar://problem/3686434> Safari uses too much RAM on file upload, leading to malloc errors and crashes (HP printers)
   7602 
   7603         * WebView.subproj/WebFormDataStream.h: Added webSetHTTPBody, which creates and connects an appropriate
   7604         stream to an NSMutableURLRequest.
   7605         * WebView.subproj/WebFormDataStream.m: Added implementation here.
   7606 
   7607         * WebCoreSupport.subproj/WebBridge.m:
   7608         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
   7609         Use webSetHTTPBody.
   7610         * WebCoreSupport.subproj/WebSubresourceClient.m:
   7611         (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]):
   7612         Use webSetHTTPBody.
   7613         * WebView.subproj/WebFrame.m:
   7614         (-[WebFrame _loadItem:withLoadType:]): Use webSetHTTPBody.
   7615         (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.
   7616 
   7617         * English.lproj/StringsNotToBeLocalized.txt: Updated for this change and other recent changes.
   7618 
   7619 2005-02-11  Richard Williamson   <rjw (a] apple.com>
   7620 
   7621 	Fixed <rdar://problem/4002505> 8A378: Endlessly animating gif's on http://www.entropy.ch
   7622 	
   7623 	If animated images had no loop count property we were incorrectly
   7624 	looping forver.  Note, that in the course of fixing this bug
   7625 	I found that ImageIO is incorrectly NOT reporting the loop count
   7626 	for a whole class of animated GIFs.
   7627 
   7628         Reviewed by Ken Kocienda.
   7629 
   7630         * WebCoreSupport.subproj/WebImageData.m:
   7631         (-[WebImageData _repetitionCount]):
   7632 
   7633 === Safari-186 ===
   7634 
   7635 2005-02-11  Vicki Murley  <vicki (a] apple.com>
   7636 
   7637         Reviewed by Darin.
   7638 
   7639 	- fix deployment build on Panther
   7640  
   7641         * WebView.subproj/WebHTMLView.m:
   7642         (-[WebHTMLView changeBaseWritingDirection:]): ifdef out NSWritingDirectionNatural
   7643         (-[WebHTMLView toggleBaseWritingDirection:]): fix a spacing issue
   7644 
   7645 2005-02-10  David Harrison  <harrison (a] apple.com>
   7646 
   7647         Reviewed by Richard.
   7648 
   7649         <rdar://problem/3991652> REGRESSION (Mail): Deleting entire line in reply deletes extra blank line and moves insertion point
   7650         
   7651         * WebView.subproj/WebHTMLView.m:
   7652         (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:isTypingAction:]):
   7653         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
   7654         (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]):
   7655         (-[WebHTMLView selectToMark:]):
   7656         (-[WebHTMLView swapWithMark:]):
   7657         (-[WebHTMLView transpose:]):
   7658         (-[WebHTMLView _selectMarkedText]):
   7659         (-[WebHTMLView _selectRangeInMarkedText:]):
   7660         Adopt new default affinity of NSSelectionAffinityDownstream as of <rdar://problem/3937447>.
   7661         
   7662 2005-02-10  Darin Adler  <darin (a] apple.com>
   7663 
   7664         Reviewed by Harrison.
   7665 
   7666         - fixed <rdar://problem/4002084> Setting ResourceLoadDelegate to nil can cause a crash
   7667 
   7668         * WebView.subproj/WebView.m: (-[WebView _cacheResourceLoadDelegateImplementations]):
   7669         Set booleans to either YES or NO, rather than setting them only in the YES case.
   7670 
   7671 2005-02-10  Darin Adler  <darin (a] apple.com>
   7672 
   7673         Reviewed by Harrison.
   7674 
   7675         - fixed <rdar://problem/3991225> Format->Style->Underline menu item does not get checked when selected text is underlined
   7676 
   7677         * WebView.subproj/WebHTMLView.m:
   7678         (-[WebHTMLView validateUserInterfaceItem:]): Added tons of additional cases in here for all the
   7679         "action" style methods in this class that don't always want to be valid. For the ones where state
   7680         makes sense, added the state-checking code too for the menu item case.
   7681         (-[WebHTMLView ignoreSpelling:]): Removed unnecessary "editable text only" check since this command
   7682         would work fine on a non-editable selection.
   7683         (-[WebHTMLView swapWithMark:]): Ditto.
   7684         (-[WebHTMLView changeBaseWritingDirection:]): Added. Like toggle, but based on the sender's tag.
   7685 
   7686 2005-02-08  Darin Adler  <darin (a] apple.com>
   7687 
   7688         "Reviewed" by Richard (he told me the file was obsolete).
   7689 
   7690         - got rid of an obsolete file
   7691 
   7692         * Plugins.subproj/npsap.h: Removed.
   7693         * copy-webcore-files-to-webkit: Removed npsap.h.
   7694 
   7695 2005-02-09  Richard Williamson   <rjw (a] apple.com>
   7696 
   7697 	Fixed <rdar://problem/4000073> non-screen font error on www.worldofwarcraft.com
   7698 
   7699         Reviewed by John Sullivan.
   7700 
   7701         * WebCoreSupport.subproj/WebTextRenderer.m:
   7702         (-[WebTextRenderer _smallCapsFont]):
   7703 
   7704 === Safari-185 ===
   7705 
   7706 2005-02-07  Chris Blumenberg  <cblu (a] apple.com>
   7707 
   7708 	Fixed: <rdar://problem/3993354> Safari claims to put RTFD on the pasteboard, but doesn't, in some cases
   7709 
   7710         Reviewed by john.
   7711 
   7712         * WebView.subproj/WebHTMLView.m:
   7713         (-[WebHTMLView _stripAttachmentCharactersFromAttributedString:]): moved
   7714         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]): take cachedAttributedString parameter in case the attributed string was gotten already
   7715         (-[WebHTMLView _writeSelectionToPasteboard:]): omit RTFD from the types list when there are no attachments
   7716 
   7717 2005-02-07  David Harrison  <harrison (a] apple.com>
   7718 
   7719         Reviewed by Ken.
   7720 
   7721         <rdar://problem/3990693> REGRESSION (8A373): ctrl-k now deletes just one character instead of line
   7722         
   7723         * WebView.subproj/WebHTMLView.m:
   7724         (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]):
   7725         Set the selection so that deleteKeyPressedWithSmartDelete knows what to delete.
   7726 
   7727 2005-02-06  Darin Adler  <darin (a] apple.com>
   7728 
   7729         Reviewed by Maciej.
   7730 
   7731         - fixed <rdar://problem/3963166> PDFView SPI print method is being deprecated, moving to PDFDocument; please update WebKit
   7732 
   7733         * WebView.subproj/WebPDFView.m: (-[WebPDFView printOperationWithPrintInfo:]): Target the document instead of the view.
   7734 
   7735         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes and also moved one translation to be a file-specific
   7736         item rather than a file-independent one.
   7737 
   7738 2005-02-05  Chris Blumenberg  <cblu (a] apple.com>
   7739 
   7740 	Fixed: <rdar://problem/3991974> REGRESSION: www.jabra.com world location screen does not work
   7741 
   7742         Reviewed by hyatt.
   7743 
   7744         * WebCoreSupport.subproj/WebBridge.m:
   7745         (-[WebBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): use the baseURL from the bridge rather than from the response
   7746 
   7747 2005-02-04  Chris Blumenberg  <cblu (a] apple.com>
   7748 
   7749 	Fixed: <rdar://problem/3802781> rtf->html pasteboard conversion using xhtml
   7750 
   7751         Reviewed by kocienda.
   7752 
   7753         * WebView.subproj/WebHTMLView.m:
   7754         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): new
   7755         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): call _excludedElementsForAttributedStringConversion
   7756 
   7757 2005-02-04  Chris Blumenberg  <cblu (a] apple.com>
   7758 
   7759 	Fixed: <rdar://problem/3832973> copy text from PowerPoint, paste into Blot (or presumably Mail) and get a single missing image icon
   7760 
   7761         Reviewed by john.
   7762 
   7763         * WebView.subproj/WebHTMLView.m:
   7764         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): prefer RTF and RTFD over images just as NSTextView does
   7765 
   7766 2005-02-03  Chris Blumenberg  <cblu (a] apple.com>
   7767 
   7768 	Fixed: <rdar://problem/3555137> REGRESSION (125-173): Flash animation can erase parts of chrome (bookmarks bar & tab bar)
   7769 
   7770 	convertRect:toView: returns incorrect results inside of viewWillMoveToWindow: with a nil window. Workaround this by catching this case.
   7771 
   7772         Reviewed by darin.
   7773 
   7774         * Plugins.subproj/WebBaseNetscapePluginView.m:
   7775         (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): new
   7776         (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): clip out the plug-in view when superviewsHaveSuperviews returns NO
   7777 
   7778 2005-02-03  Chris Blumenberg  <cblu (a] apple.com>
   7779 
   7780 	Fixed: <rdar://problem/3893513> Sun iPlanet app: when saving to a file it brings up a window with the thing to be saved instead
   7781 
   7782         Reviewed by adele.
   7783 
   7784         * WebView.subproj/WebTextView.m:
   7785         (+[WebTextView unsupportedTextMIMETypes]): added "text/ldif" to the list of MIME types that our text view doesn't handle
   7786 
   7787 === Safari-183 ===
   7788 
   7789 2005-02-03  Chris Blumenberg  <cblu (a] apple.com>
   7790 
   7791         * English.lproj/StringsNotToBeLocalized.txt: updated
   7792 
   7793 2005-02-03  Chris Blumenberg  <cblu (a] apple.com>
   7794 
   7795 	Fixed: <rdar://problem/3989611> Evite style "add vCalendar to calendar" do not work
   7796 
   7797         Reviewed by adele.
   7798 
   7799         * WebView.subproj/WebTextView.m:
   7800         (+[WebTextView unsupportedTextMIMETypes]): added "text/x-vcalendar" to the list of MIME types our text view doesn't handle
   7801 
   7802 2005-02-03  Vicki Murley  <vicki (a] apple.com>
   7803 
   7804         Reviewed by Darin.
   7805 
   7806 	- fix deployment build breakage on Panther
   7807  
   7808         * WebView.subproj/WebHTMLView.m:
   7809         (-[WebHTMLView toggleBaseWritingDirection:]):
   7810 
   7811 2005-02-02  John Sullivan  <sullivan (a] apple.com>
   7812 
   7813         Reviewed by Chris.
   7814         
   7815         - WebKit part of fix for <rdar://problem/3980651> REGRESSION (125-180): Huge number of pages printed from certain page, 
   7816         iFrame involved
   7817         
   7818         This also fixes the problems with printing from GMail, yay!
   7819 
   7820         * WebView.subproj/WebHTMLView.m:
   7821         (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
   7822         Don't adjust margins for header/footer here, because this is called for each subframe.
   7823         (-[WebHTMLView knowsPageRange:]):
   7824         Do adjust margins for header/footer here (analogous to WebTextView and WebImageView).
   7825         Also, round the page height to an integer here (noticed in passing).
   7826 
   7827 2005-02-02  Chris Blumenberg  <cblu (a] apple.com>
   7828 
   7829 	Fixed: <rdar://problem/3986546> Cut, delete, and paste menu items are active when a image is opened in window
   7830 
   7831         Reviewed by john.
   7832 
   7833         * WebView.subproj/WebView.m:
   7834         (-[WebView _responderValidateUserInterfaceItem:]): new, has the responder validate the item 
   7835         (-[WebView validateUserInterfaceItem:]): call VALIDATE for each repsonder selector using FOR_EACH_RESPONDER_SELECTOR macro
   7836         (-[WebView _performResponderOperation:with:]): call factored out method _responderForResponderOperations
   7837         (-[WebView _responderForResponderOperations]): new, code from _performResponderOperation:with:
   7838 
   7839 2005-02-02  Chris Blumenberg  <cblu (a] apple.com>
   7840 
   7841 	Fixed: <rdar://problem/3983628> control-click on WebView is not selecting the word under the cursor (Mail, non-editable WebView)
   7842 
   7843         Reviewed by rjw.
   7844 
   7845         * WebCoreSupport.subproj/WebBridge.m:
   7846         (-[WebBridge selectWordBeforeMenuEvent]): new
   7847         * WebView.subproj/WebView.m:
   7848         (-[WebView _selectWordBeforeMenuEvent]): new SPI
   7849         (-[WebView _setSelectWordBeforeMenuEvent:]): new SPI
   7850         * WebView.subproj/WebViewInternal.h:
   7851         * WebView.subproj/WebViewPrivate.h:
   7852 
   7853 2005-02-02  Chris Blumenberg  <cblu (a] apple.com>
   7854 
   7855 	Fixed: <rdar://problem/3986013> Assertion failure going back after page load error (no apparent problem in nondebug build)
   7856 
   7857         Reviewed by rjw.
   7858 
   7859         * WebView.subproj/WebDataSource.m:
   7860         (-[WebDataSource _setPrimaryLoadComplete:]): don't set the data source data when the main client is nil
   7861 
   7862 2005-02-02  Ken Kocienda  <kocienda (a] apple.com>
   7863 
   7864         Reviewed by Darin
   7865 
   7866         Fix for this bug:
   7867         
   7868         <rdar://problem/3823109> WebKit should support -toggleBaseWritingDirection: (bidi editing support)
   7869 
   7870         * WebView.subproj/WebHTMLView.m:
   7871         (-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]): New function that calls through to
   7872         new feature that allows callers to force all properties in a style to be applied as block styles.
   7873         (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]): Removed FIXME comment for something that has been fixed.
   7874         (-[WebHTMLView toggleBaseWritingDirection:]): Implemented.
   7875 
   7876 2005-02-01  Richard Williamson   <rjw (a] apple.com>
   7877 
   7878 	Fixed <rdar://problem/3977727> WebKit should use new SPI to support faster GIF rendering
   7879 
   7880 	Note:  This REQUIRES build >= 3A362 when building on Tiger.
   7881 
   7882         Reviewed by John.
   7883 
   7884         * WebCoreSupport.subproj/WebImageData.m:
   7885         (-[WebImageData _imageSourceOptions]):
   7886 
   7887 === Safari-182 ===
   7888 
   7889 2005-02-01  Richard Williamson   <rjw (a] apple.com>
   7890 
   7891 	Added new SPI for <rdar://problem/3967063> need spi on WebView to turn of lcd text for Dashboard
   7892 
   7893         Reviewed by Chris.
   7894 
   7895         * WebCoreSupport.subproj/WebTextRenderer.m:
   7896         (_drawGlyphs):
   7897         * WebView.subproj/WebView.m:
   7898         (-[WebView drawRect:]):
   7899         (-[WebView _dashboardBehavior:]):
   7900         (+[WebView _setShouldUseFontSmoothing:]):
   7901         (+[WebView _shouldUseFontSmoothing]):
   7902         * WebView.subproj/WebViewInternal.h:
   7903         * WebView.subproj/WebViewPrivate.h:
   7904 
   7905 2005-01-31  Chris Blumenberg  <cblu (a] apple.com>
   7906 
   7907 	Fixed: <rdar://problem/3949806> REGRESSION: Source window fails to refresh correctly on reload
   7908 
   7909 	The data method was being called on WebDataSource before the data was set. This fix makes WebDataSource set the data before releasing the main client instead of waiting for the main client to set it when it is dealloced.
   7910 
   7911         Reviewed by darin.
   7912 
   7913         * WebView.subproj/WebDataSource.m:
   7914         (-[WebDataSource _setData:]): moved within file
   7915         (-[WebDataSource _setPrimaryLoadComplete:]): call _setData: with the data from the main client before letting go of the main client
   7916         * WebView.subproj/WebDataSourcePrivate.h:
   7917         * WebView.subproj/WebMainResourceClient.m:
   7918         (-[WebMainResourceClient releaseResources]): removed call to _setData: since the data source may need the data before releaseResources is called
   7919 
   7920 2005-01-31  Chris Blumenberg  <cblu (a] apple.com>
   7921 
   7922 	Fixed: <rdar://problem/3946285> Seed: Safari crashed by selecting all at internet-moebel.com
   7923 
   7924         Reviewed by john.
   7925 
   7926         * WebView.subproj/WebHTMLView.m:
   7927         (-[WebHTMLView _hitViewForEvent:]): new, factored hit test hack to this method
   7928         (-[WebHTMLView _updateMouseoverWithEvent:): call _hitViewForEvent:
   7929         (-[WebHTMLView acceptsFirstMouse:]): call _setMouseDownEvent: and _isSelectionEvent: on the hit HTMLView or else when it's asked to drag it will assert
   7930         (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): ditto
   7931 
   7932 2005-01-31  David Harrison  <harrison (a] apple.com>
   7933 
   7934         Reviewed by Darin.
   7935 
   7936         <rdar://problem/3961239> AX Setting AXFocused on AXScrollArea of AXWebArea will cause keyboard selection change
   7937 
   7938         * WebView.subproj/WebHTMLView.m:
   7939         (-[WebHTMLView maintainsInactiveSelection]):
   7940         Keep the selection when the new first respomder is our own scrollview, in both editable and non-editaqble content.
   7941 
   7942 2005-01-31  Jens Alfke  <jens (a] apple.com>
   7943 
   7944         Reviewed by John.
   7945 
   7946 	- Fixed <rdar://problem/3903199> REGRESSION: Large background patterns slide around while loading
   7947 
   7948         * WebCoreSupport.subproj/WebImageData.m:
   7949         (drawPattern):
   7950         (-[WebImageData tileInRect:fromPoint:context:]):
   7951 
   7952 2005-01-30  Darin Adler  <darin (a] apple.com>
   7953 
   7954         Reviewed by John.
   7955 
   7956         - fixed <rdar://problem/3965265> Safari displays HTML as source when default encoding is Hebrew (due to direction overrides added by encoding converter)
   7957 
   7958         * WebView.subproj/WebPreferencesPrivate.h: Added _systemCFStringEncoding, and changed
   7959         _setInitialDefaultTextEncodingToSystemEncoding to be a class method.
   7960         * WebView.subproj/WebPreferences.m:
   7961         (+[WebPreferences _systemCFStringEncoding]): Added. New SPI to be used by Safari. Broken out of
   7962         _setInitialDefaultTextEncodingToSystemEncoding, but also added cases for MacArabic and MacHebrew.
   7963         (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Refactor to use _systemCFStringEncoding.
   7964 
   7965 2005-01-28  Jens Alfke  <jens (a] apple.com>
   7966 
   7967         Reviewed by Richard.
   7968 
   7969 	<rdar://problem/3727680> printing some page with WebKit generates a PDF with a 1x1 image with soft mask (causes Acrobat to hang during print spooling)
   7970 
   7971 	Detect 1x1 images, extract and cache color of single pixel, reduce draw and tile operations to a color fill (or to a no-op if the pixel is clear.)
   7972 
   7973         * WebCoreSupport.subproj/WebImageData.h:
   7974         * WebCoreSupport.subproj/WebImageData.m:
   7975         (-[WebImageData _invalidateImages]):
   7976         (-[WebImageData _checkSolidColor:]):
   7977         (-[WebImageData _cacheImages:allImages:]):
   7978         (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]):
   7979         (-[WebImageData tileInRect:fromPoint:context:]):
   7980 
   7981 2005-01-28  David Harrison  <harrison (a] apple.com>
   7982 
   7983         Reviewed by Darin.
   7984 
   7985         <rdar://problem/3584942> AX: Safari Accessibility parent-child mismatch
   7986 
   7987         Use AppKit SPI _accessibilityParentForSubview to return KWQAccObject parent of AppKit AX object.
   7988         
   7989         * WebView.subproj/WebHTMLView.m:
   7990         (-[WebHTMLView _accessibilityParentForSubview:]):
   7991         New.
   7992 
   7993 2005-01-28  Chris Blumenberg  <cblu (a] apple.com>
   7994 
   7995 	WebKit side of: <rdar://problem/3951283> can view pages from the back/forward cache that should be disallowed by Parental Controls
   7996 
   7997         Reviewed by john.
   7998 
   7999         * WebView.subproj/WebDefaultPolicyDelegate.m:
   8000         (-[WebDefaultPolicyDelegate webView:shouldGoToHistoryItem:]): new private delegate method
   8001         * WebView.subproj/WebFrame.m:
   8002         (-[WebFrame _goToItem:withLoadType:]): call new delegate method
   8003         * WebView.subproj/WebPolicyDelegatePrivate.h:
   8004 
   8005 2005-01-26  Maciej Stachowiak  <mjs (a] apple.com>
   8006 
   8007         Reviewed by Darin, Hyatt and Ken.
   8008 
   8009 	<rdar://problem/3790449> REGRESSION (Mail): underline behavior is flaky because of how CSS handles text-decoration
   8010 
   8011         * WebView.subproj/WebHTMLView.m:
   8012         (-[WebHTMLView _styleFromFontAttributes:]): Use new -khtml-text-decorations-in-effect
   8013 	property
   8014         (-[WebHTMLView _styleForAttributeChange:]): likewise
   8015         (-[WebHTMLView underline:]): likewise
   8016 
   8017 2005-01-27  Ken Kocienda  <kocienda (a] apple.com>
   8018 
   8019         Reviewed by Maciej
   8020 
   8021         * WebView.subproj/WebHTMLView.m:
   8022         (-[WebHTMLView _handleKillRing:prepend:]): New helper function. Code factored out from 
   8023          _deleteRange:killRing:prepend:smartDeleteOK:isTypingAction:.
   8024         (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:isTypingAction:]): No longer takes 
   8025         unused preflight argument. Now takes new isTypingAction argument. Uses isTypingAction to
   8026         determine which flavor of delete command to call.
   8027         (-[WebHTMLView _deleteSelection]): No longer passes unused preflight argument. Now passes new isTypingAction argument.
   8028         (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Rearranged code to call
   8029         correct flavor of delete command, based on whether typing should be preserved. Some other cleanups.
   8030         (-[WebHTMLView deleteForward:]): Add _isEditable check.
   8031         (-[WebHTMLView deleteBackward:]): Now calls _deleteWithDirection instead of having unique behavior different 
   8032         from forward delete.
   8033         (-[WebHTMLView deleteWordForward:]): Add new isTypingAction flag to _deleteWithDirection call.
   8034         (-[WebHTMLView deleteWordBackward:]): Ditto.
   8035         (-[WebHTMLView deleteToBeginningOfLine:]): Ditto.
   8036         (-[WebHTMLView deleteToEndOfLine:]): Ditto.
   8037         (-[WebHTMLView deleteToBeginningOfParagraph:]): Ditto.
   8038         (-[WebHTMLView deleteToEndOfParagraph:]): Ditto.
   8039         (-[WebHTMLView deleteToMark:]): Ditto.
   8040 
   8041 === Safari-181 ===
   8042 
   8043 2005-01-27  Chris Blumenberg  <cblu (a] apple.com>
   8044 
   8045 	Fixed: <rdar://problem/3973272> REGRESSION: Safari uses QT plugin to display PNG images
   8046 
   8047         Reviewed by john.
   8048 
   8049         * Plugins.subproj/WebBasePluginPackage.m: use renamed QT bundle ID
   8050 
   8051 2005-01-26  Darin Adler  <darin (a] apple.com>
   8052 
   8053         Reviewed by John.
   8054 
   8055         - fixed <rdar://problem/3829517> WebView still draws white when setDrawsBackground set to NO and no content loaded yet
   8056 
   8057         * WebView.subproj/WebFrameView.m: (-[WebFrameView drawRect:]): Check drawsBackground, and don't
   8058         draw the white "no document" background if it's NO. This fixes things for frames with no document.
   8059         * WebView.subproj/WebImageView.m: (-[WebImageView drawRect:]): Same as above. This fixes things
   8060         for frames with just an image.
   8061         * WebView.subproj/WebFrame.m: (-[WebFrame _updateDrawsBackground]): Call setDrawsBackground: on the
   8062         document view if it implements it. This fixes things for frames with plain text.
   8063 
   8064 2005-01-25  John Sullivan  <sullivan (a] apple.com>
   8065 
   8066         Reviewed by Chris.
   8067         
   8068         - WebKit part of fix for: <rdar://problem/3970670> Text context menu 
   8069           in WebKit needs "Look Up in Dictionary" item
   8070 
   8071         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   8072         (localizedMenuTitleFromAppKit):
   8073         return English string in the case where AppKit bundle is found but doesn't
   8074         contain the expected string. This case will be hit by people testing with
   8075         an older AppKit.
   8076         (-[WebDefaultUIDelegate menuItemWithTag:]):
   8077         create Look Up in Dictionary item
   8078         (-[WebDefaultUIDelegate contextMenuItemsForElement:]):
   8079         add Look Up in Dictionary item and separator
   8080         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:]):
   8081         ditto
   8082 
   8083         * WebView.subproj/WebHTMLView.m:
   8084         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
   8085         new method, handles bringing up the Dictionary window. Includes FIXMEs
   8086         for a couple of the known loose ends.
   8087         (-[WebHTMLView validateUserInterfaceItem:]):
   8088         handle Look Up in Dictionary item like the other new items
   8089         
   8090         * WebView.subproj/WebUIDelegatePrivate.h:
   8091         added SPI constant for Look Up in Dictionary menu item
   8092 
   8093 2005-01-24  Maciej Stachowiak  <mjs (a] apple.com>
   8094 
   8095         Fixed Panther build (missing ifdef)
   8096 
   8097         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   8098 
   8099 2005-01-24  John Sullivan  <sullivan (a] apple.com>
   8100 
   8101         Reviewed by Darin.
   8102         
   8103         - WebKit part of fix for <rdar://problem/3960231> Text context menu in WebKit needs Spotlight and Google items
   8104         
   8105         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   8106         (localizedMenuTitleFromAppKit):
   8107         new function, gets localized string from AppKit so we can avoid adding localized
   8108         strings to WebKit at this late date in Tiger. Returns the non-localized English
   8109         string if we can't find the localized string in AppKit.
   8110         (-[WebDefaultUIDelegate menuItemWithTag:]):
   8111         handle the two new menu items by tag name
   8112         (-[WebDefaultUIDelegate contextMenuItemsForElement:]):
   8113         add menu items for Search in Google and Search in Spotlight to selected-text menu item
   8114         for the noneditable case
   8115         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:]):
   8116         add menu items for Search in Google and Search in Spotlight to selected-text menu item
   8117         for the editable case
   8118 
   8119         * WebView.subproj/WebHTMLView.m:
   8120         (-[WebHTMLView _searchWithGoogleFromMenu:]):
   8121         implement this menu item action method, using same method name and implementation as NSTextView
   8122         (-[WebHTMLView _searchWithSpotlightFromMenu:]):
   8123         implement this menu item action method, using same basic implementation as NSTextView
   8124         (-[WebHTMLView validateUserInterfaceItem:]):
   8125         validate new menu items
   8126         
   8127         * WebView.subproj/WebUIDelegatePrivate.h:
   8128         define new tags for new menu items
   8129 
   8130         * English.lproj/StringsNotToBeLocalized.txt:
   8131         updated for these changes
   8132 
   8133 2005-01-24  Darin Adler  <darin (a] apple.com>
   8134 
   8135         * WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]):
   8136         Do the same check as for view types, so the representation types are consistent.
   8137 
   8138 2005-01-24  Darin Adler  <darin (a] apple.com>
   8139 
   8140         Reviewed by John.
   8141 
   8142         - fixed <rdar://problem/3791158> REGRESSION (Mail): copyFont: and pasteFont: copy and paste only the NSFont, not other attributes
   8143 
   8144         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): Added the last
   8145         few loose ends here: strikethrough and underline.
   8146 
   8147         - fixed <rdar://problem/3967393> add a user default that lets you turn off WebKit PDF support
   8148 
   8149         * WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
   8150         Leave the PDF-handling classes out of the dictionary if the secret default is set.
   8151 
   8152         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
   8153 
   8154 2005-01-20  Darin Adler  <darin (a] apple.com>
   8155 
   8156         Reviewed by Kristin Forster.
   8157 
   8158         - fixed <rdar://problem/3964972> update _initWithCGSEvent:eventRef: call in mouse moved workaround (breaks cursors in Carbon WebKit applications)
   8159 
   8160         * Carbon.subproj/HIWebView.m: (MouseMoved): Instead of munging the event record's window number directly
   8161         before calling _initWithCGSEvent, on Tiger we call _eventRelativeToWindow on the event after creating it.
   8162         Also added a check so that with Macromedia Contribute's workaround in place we don't do anything at all
   8163         to the event. Tested with both Contribute and CarbonWeb.
   8164 
   8165         * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
   8166 
   8167 2005-01-20  Richard Williamson   <rjw (a] apple.com>
   8168 
   8169 	Fixed <rdar://problem/3815672> REGRESSION (Mail): Japanese text cannot be made bold
   8170 
   8171 	The AppKit's font substitution API doesn't match font traits! 
   8172 	It only find fonts that contain the appropriate glyphs.  This
   8173 	patch attempts to find the best variation within a family.
   8174 
   8175         Reviewed by Maciej.
   8176 
   8177         * WebCoreSupport.subproj/WebTextRenderer.m:
   8178         (-[WebTextRenderer _substituteFontForString:families:]):
   8179 
   8180 === Safari-180 ===
   8181 
   8182 2005-01-20  Ken Kocienda  <kocienda (a] apple.com>
   8183 
   8184         Reviewed by John
   8185 
   8186         Fix for this bug:
   8187         
   8188         <rdar://problem/3786659> REGRESSION (Mail): editable WebViews don't work with "size up" and "size down" NSFontManager changes
   8189 
   8190         * WebView.subproj/WebHTMLView.m:
   8191         (-[WebHTMLView _addToStyle:fontA:fontB:]): This is the WebKit side of the fix. Replaced unimplemented code blocks
   8192         with FIXME's in them for make bigger and make smaller with real working code.
   8193 
   8194 2005-01-19  David Hyatt  <hyatt (a] apple.com>
   8195 
   8196 	Fix for 3513067, spaces being lost when RTL text is rendered.  Make sure not to allow hangers or spaces
   8197 	in the margin.
   8198 	
   8199         Reviewed by john
   8200 	
   8201         * WebCoreSupport.subproj/WebTextRenderer.m:
   8202         (-[WebTextRenderer _createATSUTextLayoutForRun:style:]):
   8203 
   8204 2005-01-19  Darin Adler <darin (a] apple.com>
   8205 
   8206         Reviewed by vicki
   8207 
   8208 	- fixed <rdar://problem/3962559> stopAnimationsInView leaks after cvs-base
   8209  
   8210         * WebCoreSupport.subproj/WebImageData.m: (+[WebImageData stopAnimationsInView:]): add a release
   8211 
   8212 2005-01-19  Chris Blumenberg  <cblu (a] apple.com>
   8213 
   8214 	Fixed: <rdar://problem/3961809> plug-in code attempts to load empty URL
   8215 
   8216         Reviewed by john.
   8217 
   8218         * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
   8219         (-[WebNetscapePluginEmbeddedView didStart]): don't start load if URL is empty
   8220 
   8221 2005-01-17  Darin Adler  <darin (a] apple.com>
   8222 
   8223         * DOM.subproj/DOMPrivate.h: Check in generated file.
   8224 
   8225 2005-01-17  Darin Adler  <darin (a] apple.com>
   8226 
   8227         Reviewed by John and Richard.
   8228 
   8229         - fixed <rdar://problem/3907453> printing a multi-page PDF document from Safari doesn't produce correct output
   8230 
   8231         * WebView.subproj/WebFrameViewPrivate.h: Added.
   8232         * WebView.subproj/WebFrameView.m:
   8233         (-[WebFrameView canPrintHeadersAndFooters]): Added. Returnes NO for documents that can't print headers or footers,
   8234         and delegates to the document view to answer the question. Defaults to NO, since only a view that actively does
   8235         the work is compatible with our header and footer code.
   8236         (-[WebFrameView printOperationWithPrintInfo:]): Added. Returns an NSPrintOperation set up for printing. The reason
   8237         we return this rather than an NSView is that in the PDFView case, the print info is changed around before creating
   8238         the NSPrintOperation, and also the PDFKit SPI works this way.
   8239 
   8240         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView canPrintHeadersAndFooters]): Added. Returns YES.
   8241         * WebView.subproj/WebImageView.m: (-[WebImageView canPrintHeadersAndFooters]): Ditto.
   8242         * WebView.subproj/WebTextView.m: (-[WebTextView canPrintHeadersAndFooters]): Ditto.
   8243 
   8244         * WebView.subproj/WebPDFView.m:
   8245         (-[WebPDFView canPrintHeadersAndFooters]): Added. Returns NO.
   8246         (-[WebPDFView printOperationWithPrintInfo:]): Added. Calls getPrintOperationForPrintInfo: autoRotate:YES on the PDFView.
   8247 
   8248         * WebKit.pbproj/project.pbxproj: Added WebFrameViewPrivate.h as a new private header.
   8249 
   8250 2005-01-13  Chris Blumenberg  <cblu (a] apple.com>
   8251 
   8252 	Fixed: <rdar://problem/3932107> Safari does not load QT Cocoa plug-in if the WebPluginMIMETypes key is not in the info.plist
   8253 
   8254 	Fixing this bug required that we allow WebKit plug-ins (as well as Netscape plug-ins) support BP_CreatePluginMIMETypesPreferences
   8255 	which allows plug-ins create an auxiliary MIME types file.
   8256 
   8257         Reviewed by adele.
   8258 
   8259         * Plugins.subproj/WebBasePluginPackage.h:
   8260         * Plugins.subproj/WebBasePluginPackage.m:
   8261         (+[WebBasePluginPackage preferredLocalizationName]): moved from WebNetscapePluginPackage
   8262         (-[WebBasePluginPackage pListForPath:createFile:]): ditto
   8263         (-[WebBasePluginPackage getPluginInfoFromPLists]): ditto
   8264         (-[WebBasePluginPackage isLoaded]): return isLoaded ivar
   8265         (-[WebBasePluginPackage load]): if loaded, get BP_CreatePluginMIMETypesPreferences symbol
   8266         * Plugins.subproj/WebNetscapePluginPackage.h:
   8267         * Plugins.subproj/WebNetscapePluginPackage.m:
   8268         (-[WebNetscapePluginPackage load]): call super when done so BP_CreatePluginMIMETypesPreferences can be initialized
   8269         * Plugins.subproj/WebPluginPackage.m:
   8270         (-[WebPluginPackage initWithPath:]): call getPluginInfoFromPLists
   8271         (-[WebPluginPackage load]): call super when done so BP_CreatePluginMIMETypesPreferences can be initialized
   8272 
   8273 2005-01-13  Richard Williamson   <rjw (a] apple.com>
   8274 
   8275 	Fixed <rdar://problem/3952809> WebJavaPlugIn.h comments need method name corrected (webPlugInCallJava)
   8276 
   8277         Reviewed by Maciej.
   8278 
   8279         * Plugins.subproj/WebJavaPlugIn.h:
   8280 
   8281 === Safari-179 ===
   8282 
   8283 2005-01-13  Vicki Murley <vicki (a] apple.com>
   8284 
   8285         Reviewed by Adele.
   8286 
   8287         - fix <rdar://problem/3946836> Safari about box lists 2004 instead of 2005
   8288 
   8289         * WebKit.pbproj/project.pbxproj: bump "2004" to "2005"
   8290 
   8291 2005-01-13  Richard Williamson   <rjw (a] apple.com>
   8292 
   8293 	Fixed <rdar://problem/3951911> REGRESSION: Animated GIF images with loop counts no longer update
   8294 
   8295 	Draw last image after animation loop terminates.  (We
   8296 	were drawing the image at index+1, which doesn't exist!)
   8297 
   8298         Reviewed by Darin.
   8299 
   8300         * WebCoreSupport.subproj/WebImageData.m:
   8301         (-[WebImageData _nextFrame:]):
   8302 
   8303 2005-01-13  Richard Williamson   <rjw (a] apple.com>
   8304 
   8305 	Fixed <rdar://problem/3952084> REGRESSION: Links at projectseven.com now draw and update incorrectly during hover
   8306 
   8307 	Turn off use of new CGContextStrokeLineSegments API.  We should
   8308 	turn back on when 3952944 is fixed.
   8309 
   8310         Reviewed by Darin.
   8311 
   8312         * WebCoreSupport.subproj/WebTextRenderer.m:
   8313         (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
   8314 
   8315 2005-01-13  Chris Blumenberg  <cblu (a] apple.com>
   8316 
   8317 	Fixed: <rdar://problem/3937663> repro assertion failure and crash dragging image that has PDF source
   8318 
   8319         Reviewed by adele.
   8320 
   8321         * Misc.subproj/WebNSViewExtras.m:
   8322         (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): if [WebImageRenderer image] returns nil, fallback to code that uses a file icon as the drag image
   8323         * WebCoreSupport.subproj/WebImageRendererFactory.m:
   8324         (-[WebImageRendererFactory supportedMIMETypes]): removed code that omits PDF and PostScript from the list since this omission is only needed in WebImageView
   8325         * WebView.subproj/WebImageView.m:
   8326         (+[WebImageView supportedImageMIMETypes]): added code that omits PDF and PostScript since we don't want WebImageView to render these types
   8327 
   8328 2005-01-10  Maciej Stachowiak  <mjs (a] apple.com>
   8329 
   8330         Reviewed by Darin.
   8331 
   8332 	<rdar://problem/3758033> REGRESSION (Mail): Support attributes in marked text (International input)
   8333         
   8334 	* WebCoreSupport.subproj/WebTextRenderer.m:
   8335         (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]): Changed to support
   8336 	underline thickness. Also added a bit of a hack here to move thickness 2 underlines down by
   8337 	.5 pixels, since the rendering engine can't give a fractional pixel offset.
   8338         * WebView.subproj/WebHTMLView.m:
   8339         (-[WebHTMLView validAttributesForMarkedText]): Support underline, underline color and marked
   8340 	clause attributes. Others that NSText supports are unimplemented for now.
   8341         (-[WebHTMLView firstRectForCharacterRange:]): Remove needless logging.
   8342         (-[WebHTMLView unmarkText]): Updated for new WebCore SPI.
   8343         (-[WebHTMLView _extractAttributes:ranges:fromAttributedString:]): New method to pull the attributes
   8344 	and ranges out of an attributed string.
   8345         (-[WebHTMLView setMarkedText:selectedRange:]): Extract attributes and pass to WebCore.
   8346         (-[WebHTMLView insertText:]): Add comment noting that we don't really handle attributed strings
   8347 	here.
   8348 
   8349 2005-01-12  Darin Adler  <darin (a] apple.com>
   8350 
   8351         Reviewed by Ken.
   8352 
   8353         - fixed <rdar://problem/3848257> WebView will draw more than AppKit asks it to, so views behind won't redraw enough (transparent WebView)
   8354 
   8355         * WebView.subproj/WebHTMLView.m:
   8356         (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]): As recommended by Troy Stephens, do the
   8357         layouts here in this call, since it's before propagating the dirty rects to our ancestors.
   8358         This fixes the bug, but we only do it if the WebView is not opaque, because otherwise we can
   8359         optimize by only doing layouts you really need, and doing them later on is safe because we
   8360         know we don't need to draw any of the views behind us.
   8361         (-[WebHTMLView _layoutIfNeeded]): Added. Factored out from the method below.
   8362         (-[WebHTMLView _web_layoutIfNeededRecursive]): Added. Like the other "layout if needed" call,
   8363         but unconditional.
   8364         (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]): Factored out the guts into the
   8365         _layoutIfNeeded method above. Otherwise unchanged.
   8366         (-[NSView _web_layoutIfNeededRecursive]): Added.
   8367 
   8368         * WebView.subproj/WebFrame.m: (-[WebFrame _updateDrawsBackground]): Call setDrawsBackground:NO
   8369         on the scroll view when changing the frame to no longer be in "draws background" mode. This
   8370         is needed because the frame manages the "draws background" mode of the scroll view. It won't
   8371         have any effect if you call setDrawsBackground:NO before starting to use a WebView, but without
   8372         it calling setDrawsBackground:NO later won't have an immediate effect (easily visible in Safari).
   8373         This was hidden before because the HTML view was filling with transparent color, which blew away
   8374         the fill that was done by NSScrollView.
   8375 
   8376         - fixed <rdar://problem/3921129> reproducible crash at www.funnychristmas.com in CFSet manipulation in WebImageData
   8377 
   8378         * WebCoreSupport.subproj/WebImageData.m:
   8379         (-[WebImageData _imageSourceOptions]): Changed types so we don't need a cast.
   8380         (+[WebImageData stopAnimationsInView:]): Instead of building a set of sets, by putting in the sets with addObject,
   8381         build a single set using unionSet, and then iterate the objects instead of having to iterate the sets and then the
   8382         objects in each set. The old code ended up sharing the sets with the live code, when the whole idea was to gather
   8383         all the renderers because the process of stopping modifies the active sets.
   8384 
   8385 2005-01-12  Richard Williamson   <rjw (a] apple.com>
   8386 
   8387 	Fixed <rdar://problem/3926825> Safari ignores GIF loop count
   8388 
   8389 	Get loop count from file properties, not image properties.
   8390 
   8391         Reviewed by Ken Kocienda.
   8392 
   8393         * WebCoreSupport.subproj/WebImageData.h:
   8394         * WebCoreSupport.subproj/WebImageData.m:
   8395         (-[WebImageData _commonTermination]):
   8396         (-[WebImageData fileProperties]):
   8397         (-[WebImageData _floatProperty:type:at:]):
   8398         (-[WebImageData _floatFileProperty:type:]):
   8399         (-[WebImageData _repetitionCount]):
   8400 
   8401 2005-01-11  Chris Blumenberg  <cblu (a] apple.com>
   8402 
   8403 	Fixed: <rdar://problem/3934749> assertion failure in WebBaseNetscapePluginView loading movie
   8404 
   8405         Reviewed by john.
   8406 
   8407         * Plugins.subproj/WebBaseNetscapePluginView.m:
   8408         (-[WebBaseNetscapePluginView start]): call canStart before asserting about the webView
   8409 
   8410 2005-01-11  John Sullivan  <sullivan (a] apple.com>
   8411 
   8412         Reviewed by Darin.
   8413         
   8414         - fixed <rdar://problem/3446838> REGRESSION (Mail): text decorations don't print 
   8415         (e.g. <strike>, underline)
   8416 
   8417         * WebCoreSupport.subproj/WebTextRenderer.m:
   8418         (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]):
   8419         This bottleneck routine for drawing a line was setting the linewidth to 0 when
   8420         the graphics context was not drawing to the screen. Thus, no lines. Now links
   8421         are underlined when printing from Safari (as well as Mail).
   8422 
   8423 2005-01-11  Richard Williamson   <rjw (a] apple.com>
   8424 
   8425 	Fixed 3949145.  CG has a much faster API for drawing lines.
   8426 	Switched over to that new API (CGContextStrokeLineSegments).
   8427 
   8428         Reviewed by John Sullivan.
   8429 
   8430         * WebCoreSupport.subproj/WebTextRenderer.m:
   8431         (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]):
   8432 
   8433 2005-01-10  Chris Blumenberg  <cblu (a] apple.com>
   8434 
   8435 	Fixed: <rdar://problem/3948862> REGRESSION: missing images when RTFD is pasted into editable WebView
   8436 
   8437 	This problem occurred because we were creating image elements before creating corresponding image resources. The fix is to have AppKit call us back to create the resources before it creates the elements.
   8438 
   8439         Reviewed by john.
   8440 
   8441         * WebView.subproj/WebHTMLView.m:
   8442         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): don't deal with subresources since that's now done by the following method
   8443         (-[WebHTMLView resourceForData:preferredFilename:]): new handler method called by AppKit
   8444 
   8445 === Safari-178 ===
   8446 
   8447 2005-01-06  David Harrison  <harrison (a] apple.com>
   8448 
   8449         Reviewed by Dave Hyatt
   8450 
   8451         <rdar://problem/3588548> AX: tabbing does not work correctly with the screen reader and a focused link; need AXFocusedUIElement to work.
   8452 
   8453         * WebView.subproj/WebHTMLView.m:
   8454         (-[WebHTMLView accessibilityFocusedUIElement]):
   8455         Implement this so that AppKit can use it from NSAccessibilityHandleFocusChanged.
   8456 
   8457 2005-01-05  Chris Blumenberg  <cblu (a] apple.com>
   8458 
   8459 	Fixed: <rdar://problem/3936865> REGRESSION: canvas.drawImage no longer scales properly
   8460 
   8461         Reviewed by john.
   8462 
   8463         * WebCoreSupport.subproj/WebImageData.m: use the height of the inRect instead of the fromRect when setting the origin of the context
   8464 
   8465 2005-01-04  Chris Blumenberg  <cblu (a] apple.com>
   8466 
   8467 	Fixed: <rdar://problem/3928329> WebKit should pass nil for "language" to checkSpellingOfString:
   8468 
   8469         Reviewed by kocienda.
   8470 
   8471         * WebView.subproj/WebHTMLView.m:
   8472         (-[WebHTMLView _isSelectionMisspelled]): pass nil not @"" for language
   8473 
   8474 2004-12-21  Maciej Stachowiak  <mjs (a] apple.com>
   8475 
   8476         Reviewed by Darin.
   8477 
   8478 	<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another
   8479 
   8480         Implement a security check on name frame visbility. This is the
   8481 	same rule as mozilla. You can only target frames by name if you
   8482 	are in the same window, have the same domain as the frame or an
   8483 	ancestor, or if it's a top level window have the same domain as
   8484 	the opener.
   8485 	
   8486         * WebView.subproj/WebFrame.m:
   8487         (-[WebFrame _shouldAllowAccessFrom:]):
   8488         (-[WebFrame _descendantFrameNamed:sourceFrame:]):
   8489         (-[WebFrame findFrameNamed:]):
   8490         * WebView.subproj/WebFramePrivate.h:
   8491         * WebView.subproj/WebView.m:
   8492         (-[WebView _findFrameInThisWindowNamed:sourceFrame:]):
   8493         (-[WebView _findFrameNamed:sourceFrame:]):
   8494         * WebView.subproj/WebViewPrivate.h:
   8495 
   8496 === Safari-177 ===
   8497 
   8498 === Safari-176 ===
   8499 
   8500 2004-12-20  Richard Williamson   <rjw (a] apple.com>
   8501 
   8502 	Add call to new API.  ImageIO deprecated some older (although
   8503 	quite new!) API.   This caused us to fail to build on 337 or later.
   8504 
   8505 	Developers wanting to build on older versions of Tiger must define
   8506 	USE_DEPRECATED_IMAGESOURCE_API in WebImageData.m.
   8507 
   8508         Reviewed by Vicki.
   8509 
   8510         * WebCoreSupport.subproj/WebImageData.m:
   8511         (-[WebImageData propertiesAtIndex:]):
   8512 
   8513 2004-12-20  Richard Williamson   <rjw (a] apple.com>
   8514 
   8515 	Don't call Tiger SPI on Panther.
   8516 
   8517         Reviewed by Vicki.
   8518 
   8519         * WebCoreSupport.subproj/WebTextRendererFactory.m:
   8520         (+[WebTextRendererFactory createSharedFactory]):
   8521 
   8522 2004-12-20  Richard Williamson   <rjw (a] apple.com>
   8523 
   8524 	Fixed <rdar://problem/3884448> WebKit should turn on CG local font cache
   8525 
   8526 	Enable mutli-tier font caching.  We should see a performance boost with this
   8527 	change.
   8528 
   8529         Reviewed by Chris.
   8530 
   8531         * WebCoreSupport.subproj/WebTextRendererFactory.m:
   8532         (+[WebTextRendererFactory createSharedFactory]):
   8533 
   8534 2004-12-20  Richard Williamson   <rjw (a] apple.com>
   8535 
   8536 	Fix image decoding to separately decode image meta data from actual image bits.  I
   8537 	incorrectly consolidated decode of meta data and image bits resulting in a huge
   8538 	performance regression.
   8539 
   8540 	Double size of WebCore cache on lower end machines.  On the PLT run on machines with
   8541 	256MB of memory, too many images were being evicted, causing a re-decode on the PLT.
   8542 	Upping the lower limit of the cache size ensure that no images are evicted (this
   8543 	goes hand-in-hand with the change to the minimum object size from 32K to 40K).
   8544 
   8545         Reviewed by Ken.
   8546 
   8547         * WebCoreSupport.subproj/WebImageData.h:
   8548         * WebCoreSupport.subproj/WebImageData.m:
   8549         (+[WebImageData initialize]):
   8550         (-[WebImageData _commonTermination]):
   8551         (-[WebImageData _invalidateImages]):
   8552         (-[WebImageData _invalidateImageProperties]):
   8553         (-[WebImageData imageAtIndex:]):
   8554         (-[WebImageData propertiesAtIndex:]):
   8555         (-[WebImageData _cacheImages:allImages:]):
   8556         (-[WebImageData decodeData:isComplete:callback:]):
   8557         (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]):
   8558         * WebView.subproj/WebPreferences.m:
   8559         (+[WebPreferences initialize]):
   8560 
   8561 2004-12-20  Richard Williamson   <rjw (a] apple.com>
   8562 
   8563 	Fixed build problem caused by change to ImageIO API.
   8564 
   8565         Reviewed by Adele.
   8566 
   8567         * WebCoreSupport.subproj/WebImageData.m:
   8568 
   8569 2004-12-19  Darin Adler  <darin (a] apple.com>
   8570 
   8571         Reviewed by Kevin.
   8572 
   8573         - some garbage collection fixes
   8574 
   8575         * Misc.subproj/WebNSObjectExtras.h: (WebCFAutorelease): Replaced the old WebNSRetainCFRelease with this
   8576         much-easier-to-understand function cribbed from what David Harrison did in WebCore.
   8577 
   8578         * Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): Use CFRelease here to
   8579         get rid of an unnecessary use of WebNSRetainCFRelease.
   8580         * Misc.subproj/WebNSURLExtras.m:
   8581         (+[NSURL _web_URLWithData:relativeToURL:]): Use WebCFAutorelease instead of WebNSRetainCFRelease and autorelease.
   8582         (-[NSURL _web_URLWithLowercasedScheme]): Ditto.
   8583         (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Use WebCFAutorelease here; the old code would not
   8584         work correctly under GC.
   8585         * Plugins.subproj/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage preferredLocalizationName]):
   8586         Use WebCFAutorelease here; the old code would not work correctly under GC.
   8587 
   8588 2004-12-18  Chris Blumenberg  <cblu (a] apple.com>
   8589 
   8590 	Fixed: <rdar://problem/3766915> PDF content needs search to work
   8591 
   8592         Reviewed by kevin, john.
   8593 
   8594         * WebView.subproj/WebPDFView.m:
   8595 	(-[WebPDFView searchFor:direction:caseSensitive:wrap:]): implemented
   8596         (-[WebPDFView takeFindStringFromSelection:]): new
   8597         (-[WebPDFView jumpToSelection:]): new
   8598         (-[WebPDFView validateUserInterfaceItem:]): new
   8599 
   8600 2004-12-17  Richard Williamson   <rjw (a] apple.com>
   8601 
   8602 	Make image decoding as lazy as possible for non threaded case; in some cases
   8603 	can avoid unnecessary decoding work.
   8604 
   8605         Reviewed by Chris.
   8606 
   8607         * WebCoreSupport.subproj/WebImageData.h:
   8608         * WebCoreSupport.subproj/WebImageData.m:
   8609         (-[WebImageData imageAtIndex:]):
   8610         (-[WebImageData propertiesAtIndex:]):
   8611         (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]):
   8612 
   8613 2004-12-16  John Sullivan  <sullivan (a] apple.com>
   8614 
   8615         Reviewed by Chris.
   8616         
   8617         One of the assertions from my previous checkin fired, so
   8618         I made this code more robust.
   8619 
   8620         * WebCoreSupport.subproj/WebBridge.m:
   8621         (-[WebBridge _preferences]):
   8622         new helper method, returns global preferences if webView is nil,
   8623         otherwise returns webView's preferences
   8624         (-[WebBridge getObjectCacheSize]):
   8625         use new helper method, remove now-unnecessary assert
   8626         (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]):
   8627         ditto
   8628 
   8629 2004-12-16  John Sullivan  <sullivan (a] apple.com>
   8630 
   8631         Reviewed by Darin.
   8632         
   8633         - fixed <rdar://problem/3913523> Mail needs SPI for adding tooltips to links
   8634         - cleaned up some calls to +[WebPreferences standardPreferences] that should
   8635           have been using -[WebView preferences]
   8636           
   8637         This adds a (currently SPI-only) new feature that shows the URL of the link
   8638         under the mouse in a toolTip. I tested this in Safari, but we're adding this
   8639         feature for Mail, and Safari won't use it (unless of course you know the
   8640         magic defaults command)
   8641 
   8642         * Plugins.subproj/WebBaseNetscapePluginView.m:
   8643         (-[WebBaseNetscapePluginView start]):
   8644         use -[WebView preferences] instead of +[WebPreferences standardPreferences]
   8645         
   8646         * WebCoreSupport.subproj/WebBridge.m:
   8647         (-[WebBridge getObjectCacheSize]):
   8648         ditto
   8649         (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]):
   8650         ditto
   8651         
   8652         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   8653         (-[WebBaseResourceHandleDelegate willCacheResponse:]):
   8654         ditto
   8655         
   8656         * WebView.subproj/WebFrame.m:
   8657         (-[WebFrame _transitionToCommitted:]):
   8658         ditto
   8659         (-[WebFrame _loadItem:withLoadType:]):
   8660         ditto
   8661         
   8662         * WebView.subproj/WebHTMLViewInternal.h:
   8663         private struct now keeps ivar for cached value of showsURLsInToolTips
   8664         so it doesn't have look it up in preferences a zillion times
   8665         
   8666         * WebView.subproj/WebHTMLView.m:
   8667         (-[WebHTMLView _updateMouseoverWithEvent:]):
   8668         if private->showsURLsInToolTips is true, set the toolTip from the URL.
   8669         Fall back to showing the title attribute in case some element has a title
   8670         attribute but no URL.
   8671         (-[WebHTMLView _mayStartDragAtEventLocation:]):
   8672         use -[WebView preferences] instead of +[WebPreferences standardPreferences]
   8673         (-[WebHTMLView _resetCachedWebPreferences:]):
   8674         get a fresh value for private->showsURLsInToolTips
   8675         (-[WebHTMLView initWithFrame:]):
   8676         call _resetCachedWebPreferences the first time, and listen for WebPreferencesChanged notifications
   8677         (-[WebHTMLView _handleStyleKeyEquivalent:]):
   8678         use -[WebView preferences] instead of +[WebPreferences standardPreferences]
   8679         
   8680         * WebView.subproj/WebPreferenceKeysPrivate.h:
   8681         added WebKitShowsURLsInToolTipsPreferenceKey
   8682         
   8683         * WebView.subproj/WebPreferences.m:
   8684         (+[WebPreferences initialize]):
   8685         initialize WebKitShowsURLsInToolTipsPreferenceKey to 0
   8686         (-[WebPreferences showsURLsInToolTips]):
   8687         return WebKitShowsURLsInToolTipsPreferenceKey value
   8688         (-[WebPreferences setShowsURLsInToolTips:]):
   8689         set WebKitShowsURLsInToolTipsPreferenceKey value
   8690         
   8691         * WebView.subproj/WebPreferencesPrivate.h:
   8692         add declarations for showsURLsInToolTips and setter
   8693         
   8694         * WebView.subproj/WebTextView.m:
   8695         (-[WebTextView _preferences]):
   8696         new helper method that gets preferences from webView if there is a webView,
   8697         otherwise gets global preferences
   8698         (-[WebTextView setFixedWidthFont]):
   8699         use new helper method rather than always using global preferences
   8700         (-[WebTextView initWithFrame:]):
   8701         observe WebPreferencesChangedNotification instead of unnecessarily general
   8702         NSUserDefaultsChangedNotification
   8703 
   8704 2004-12-14  John Sullivan  <sullivan (a] apple.com>
   8705 
   8706         Reviewed by Ken.
   8707         
   8708         - rest of WebKit fix for <rdar://problem/3790011> undoable operations all say "Undo" 
   8709         in the menu, no specific action names
   8710         
   8711         I only know of one loose end currently, which I wrote up as <rdar://problem/3920971> Edit menu 
   8712         says "Undo Change Attributes" when it should say "Undo Set Color", from font panel
   8713 
   8714         * WebView.subproj/WebHTMLView.m:
   8715         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
   8716         use WebUndoActionSetColor when dragging color swatch
   8717         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
   8718         new WebUndoAction parameter, passed across bridge
   8719         (-[WebHTMLView _toggleBold]):
   8720         use WebUndoActionSetFont
   8721         (-[WebHTMLView _toggleItalic]):
   8722         use WebUndoActionSetFont
   8723         (-[WebHTMLView pasteFont:]):
   8724         use WebUndoActionPasteFont
   8725         (-[WebHTMLView changeFont:]):
   8726         use WebUndoActionSetFont
   8727         (-[WebHTMLView changeAttributes:]):
   8728         use WebUndoActionChangeAttributes
   8729         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
   8730         new method, returns WebUndoActionSetBackgroundColor or WebUndoActionSetColor
   8731         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
   8732         now calls _undoActionFromColorPanelWithSelector
   8733         (-[WebHTMLView changeColor:]):
   8734         use WebUndoActionSetColor
   8735         (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]):
   8736         new WebUndoAction parameter, passed through
   8737         (-[WebHTMLView alignCenter:]):
   8738         use WebUndoActionCenter
   8739         (-[WebHTMLView alignJustified:]):
   8740         use WebUndoActionJustify
   8741         (-[WebHTMLView alignLeft:]):
   8742         use WebUndoActionAlignLeft
   8743         (-[WebHTMLView alignRight:]):
   8744         use WebUndoActionAlignRight
   8745         (-[WebHTMLView subscript:]):
   8746         use WebUndoActionAlignSubscript
   8747         (-[WebHTMLView superscript:]):
   8748         use WebUndoActionAlignSuperscript
   8749         (-[WebHTMLView unscript:]):
   8750         use WebUndoActionAlignUnscript
   8751         (-[WebHTMLView underline:]):
   8752         use WebUndoActionAlignUnderline
   8753         
   8754         * WebView.subproj/WebView.m:
   8755         (-[WebView setTypingStyle:]):
   8756         pass WebUndoActionUnspecified through as new parameter since we don't have any more specific info
   8757         (-[WebView applyStyle:]):
   8758         ditto
   8759 
   8760 2004-12-14  Richard Williamson   <rjw (a] apple.com>
   8761 
   8762 	Helper method to get URL of plugin view.
   8763 
   8764         Reviewed by Chris.
   8765 
   8766         * Misc.subproj/WebNSViewExtras.m:
   8767         (-[NSView _webViewURL]):
   8768 
   8769 2004-12-14  Vicki Murley <vicki (a] apple.com>
   8770 
   8771         Reviewed by rjw.
   8772  
   8773 	<rdar://problem/3855573> Remove reference to "WebScriptMethods" from WebScriptObject.h comments
   8774 
   8775         * Plugins.subproj/WebPlugin.h: changed instances of "WebScriptMethods" to "WebScripting" in this
   8776 	file as well, as requested in the bug report
   8777 
   8778 2004-12-13  Maciej Stachowiak  <mjs (a] apple.com>
   8779 
   8780         Reviewed by John.
   8781 
   8782 	<rdar://problem/3912488> Mail throws an exception after backspacing "away" inline input
   8783         
   8784 	* WebView.subproj/WebHTMLView.m:
   8785         (-[WebHTMLView setMarkedText:selectedRange:]): Don't try to set a selection if
   8786 	we end up with no marked text, since that case fails and is unnecessary.
   8787 
   8788 2004-12-14  John Sullivan  <sullivan (a] apple.com>
   8789 
   8790         Reviewed by Ken.
   8791 
   8792         - WebKit part of plumbing of fix for <rdar://problem/3790011> undoable operations all say "Undo" in the menu, 
   8793         no specific action names
   8794 
   8795         * WebCoreSupport.subproj/WebBridge.m:
   8796         (-[WebBridge nameForUndoAction:]):
   8797         renamed from setUndoActionNamePlaceholder, replaced arbitrary integers with enum values, and
   8798         handled new "unspecified" case as a fallback
   8799 
   8800 2004-12-13  Richard Williamson   <rjw (a] apple.com>
   8801 
   8802 	Fixed <rdar://problem/3887767> LiveConnect doesn't propagate Java exceptions back to JavaScript (prevents security suite from running)
   8803 
   8804         Reviewed by John.
   8805 
   8806         * Plugins.subproj/WebJavaPlugIn.h:
   8807 
   8808 2004-12-13  John Sullivan  <sullivan (a] apple.com>
   8809 
   8810         Reviewed by Maciej.
   8811         
   8812         - fixed <rdar://problem/3744583> Safari can not quit when a webpage has a login sheet 
   8813         that can't be cancelled.
   8814         
   8815         The proper fix for this would be to change the class of the NSPanel in the nib file.
   8816         But since this would require a localization change, I did a run-time hack instead.
   8817         I'll file a bug about fixing this when we're out of localization freeze.
   8818 
   8819         * Panels.subproj/WebAuthenticationPanel.m:
   8820         (-[WebAuthenticationPanel replacePanelWithSubclassHack]):
   8821         new method, creates a new panel that is identical to the original one except that
   8822         it's our subclass, and moves all the subviews of the original panel into the new one.
   8823         (-[WebAuthenticationPanel loadNib]):
   8824         call replacePanelWithSubclassHack
   8825         (-[NonBlockingPanel _blocksActionWhenModal:]):
   8826         only method of new NSPanel subclass; overrides this SPI to allow the user to quit
   8827         when one of these panels/sheets is on-screen
   8828 
   8829 2004-12-10  Richard Williamson   <rjw (a] apple.com>
   8830 
   8831 	Fixed <rdar://problem/3898708> REGRESSION (8A314-8A317): World Clock's short hand not displayed (ImageIO problem with PDF?)
   8832 	Fixed <rdar://problem/3914012> use CG directly for pdf images not ImageIO
   8833 
   8834 	Create a PDF document and draw that instead of using ImageIO to create a rasterized image.
   8835 
   8836         Reviewed by Maciej.
   8837 
   8838         * WebCoreSupport.subproj/WebImageData.h:
   8839         * WebCoreSupport.subproj/WebImageData.m:
   8840         (-[WebImageData setIsPDF:]):
   8841         (-[WebImageData isPDF]):
   8842         (-[WebImageData dealloc]):
   8843         (-[WebImageData decodeData:isComplete:callback:]):
   8844         (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]):
   8845         (-[WebImageData size]):
   8846         (-[WebImageData animate]):
   8847         (-[WebImageData _createPDFWithData:]):
   8848         (-[WebImageData _PDFDocumentRef]):
   8849         (-[WebImageData _PDFDrawInContext:]):
   8850         (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
   8851         * WebCoreSupport.subproj/WebImageRenderer.h:
   8852         * WebCoreSupport.subproj/WebImageRenderer.m:
   8853         (-[WebImageRenderer size]):
   8854         (-[WebImageRenderer incrementalLoadWithBytes:length:complete:callback:]):
   8855         (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
   8856         (_createImageRef):
   8857 
   8858 2004-12-10  John Sullivan  <sullivan (a] apple.com>
   8859 
   8860         Reviewed by Ken.
   8861         
   8862         - fixed <rdar://problem/3855127> Error while printing w/o sheet, then window is left in a bad state, 
   8863         if there's no default printer set
   8864 
   8865         * WebView.subproj/WebHTMLView.m:
   8866         (-[WebHTMLView beginDocument]):
   8867         Our implementation of knowsPageRange puts the WebHTMLView into a special "printing mode". We must
   8868         exit the "printing mode" to return to normal behavior. This is normally done in endDocument.
   8869         However, it turns out that if there's an exception in [super beginDocument], then endDocument
   8870         will not be called (lame-o AppKit API). So, we handle that case by catching the exception and
   8871         exiting the "printing mode" in beginDocument when it occurs.
   8872 
   8873 2004-12-09  Richard Williamson   <rjw (a] apple.com>
   8874 
   8875 	Fixed <rdar://problem/3905789> Burn Disc image vibrates rapidly
   8876 
   8877 	Restrict our support for animated images to GIF.  We used to
   8878 	use presence of more than one image in a resource to determine
   8879 	if an image should be animated.  This caused us to animate icns!
   8880 	If we ever support any other animated image formats we'll have
   8881 	to extend.
   8882 
   8883         Reviewed by Hyatt.
   8884 
   8885         * WebCoreSupport.subproj/WebImageData.h:
   8886         * WebCoreSupport.subproj/WebImageData.m:
   8887         (-[WebImageData shouldAnimate]):
   8888         * WebCoreSupport.subproj/WebImageRenderer.m:
   8889         (-[WebImageRenderer _startOrContinueAnimationIfNecessary]):
   8890 
   8891 2004-12-09  Richard Williamson   <rjw (a] apple.com>
   8892 
   8893 	Make WebPluginDatabase.h private (Dashboard needs SPI).
   8894 
   8895         * WebKit.pbproj/project.pbxproj:
   8896 
   8897 === Safari-175 ===
   8898 
   8899 2004-12-09  Chris Blumenberg  <cblu (a] apple.com>
   8900 
   8901 	Workaround for this exception being raised during download:
   8902 	[WebDownload connection:willStopBufferingData:]: selector not recognized
   8903 
   8904         Reviewed by john.
   8905 
   8906         * Misc.subproj/WebDownload.m:
   8907         (-[WebDownload connection:willStopBufferingData:]): implement this method so no exception is raised. It is a bug in Foundation that this method is being called, but it's too late to fix Foundation since it has already been submitted this week. This workaround will prevent any problems from affecting users.
   8908 
   8909 2004-12-08  Richard Williamson   <rjw (a] apple.com>
   8910 
   8911 	Fixed <rdar://problem/3911719> REGRESSION: Images no longer scale vertically
   8912 	Account for scaling correctly when taking into account progressively
   8913  	loaded images.
   8914 
   8915 	Also added implementation of repetition count for animated GIF images.
   8916 	Also replaced strings with new constants from CFImageProperties.h
   8917 
   8918 	Also fixed possible problem with -(NSSize)size implementation,
   8919 	relevant to Panther only.
   8920 
   8921         Reviewed by Chris.
   8922 
   8923         * WebCoreSupport.subproj/WebImageData.m:
   8924         (-[WebImageData _floatProperty:type:at:]):
   8925         (-[WebImageData _frameDurationAt:]):
   8926         (-[WebImageData _repetitionCount]):
   8927         * WebCoreSupport.subproj/WebImageRenderer.m:
   8928         (-[WebImageRenderer size]):
   8929 
   8930 2004-12-08  Chris Blumenberg  <cblu (a] apple.com>
   8931 
   8932 	Removed NPN wrappers since these no longer need to be defined to make the QT plug-in work
   8933 	since 3828925 has been fixed.
   8934 
   8935         Reviewed by john.
   8936 
   8937         * Plugins.subproj/WebNetscapePluginPackage.m:
   8938         (-[WebNetscapePluginPackage load]): use under-bar symbols since non-under-bar wrappers have been removed
   8939         * Plugins.subproj/npapi.m: removed NPN wrappers
   8940         * WebKit.exp: removed symbols
   8941 
   8942 2004-12-08  Ken Kocienda  <kocienda (a] apple.com>
   8943 
   8944         Reviewed by Darin
   8945 
   8946         * WebView.subproj/WebHTMLView.m:
   8947         (-[WebHTMLView drawRect:]): Work around for this bug:
   8948         <rdar://problem/3908282> REGRESSION (Mail): No drag image dragging selected text in Blot and Mail
   8949         The reason for the workaround is that this method is called explicitly from the code
   8950         to generate a drag image, and at that time, getRectsBeingDrawn:count: will return a zero count.
   8951         This code change uses the passed-in rect when the count is zero.
   8952 
   8953 2004-12-07  Administrator  <cblu (a] apple.com>
   8954 
   8955 	Support for fix for:
   8956 	<rdar://problem/3734309> Safari doesn't open folders in title bar menu with non-Roman names using Cmd+click
   8957 
   8958         Reviewed by john.
   8959 
   8960         * Misc.subproj/WebNSURLExtras.h:
   8961         * Misc.subproj/WebNSURLExtras.m:
   8962         (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): renamed to take relativeToURL parameter
   8963         (+[NSURL _web_URLWithUserTypedString:]): call _web_URLWithUserTypedString:relativeToURL: with nil for URL
   8964 
   8965 2004-12-07  Richard Williamson   <rjw (a] apple.com>
   8966 
   8967 	Fixed <rdar://problem/3905564> REGRESSION (Tiger); in History menu, pixel size appears but is wrong for standalone images in Safari.
   8968 
   8969         Reviewed by Chris.
   8970 
   8971         * WebCoreSupport.subproj/WebImageRenderer.m:
   8972         (-[WebImageRenderer size]):
   8973 
   8974 2004-12-07  Richard Williamson   <rjw (a] apple.com>
   8975 
   8976 	Support threaded image decoding on machines w/ >= 2 CPUs.
   8977 
   8978         Reviewed by Maciej and Chris.
   8979 
   8980         * Misc.subproj/WebKitSystemBits.h:
   8981         * Misc.subproj/WebKitSystemBits.m:
   8982         (WebSystemMainMemory):
   8983         (WebNumberOfCPUs):
   8984         * WebCoreSupport.subproj/WebImageData.h:
   8985         * WebCoreSupport.subproj/WebImageData.m:
   8986         (+[WebImageData initialize]):
   8987         (-[WebImageData init]):
   8988         (-[WebImageData _commonTermination]):
   8989         (-[WebImageData dealloc]):
   8990         (-[WebImageData _invalidateImages]):
   8991         (-[WebImageData _imageSourceOptions]):
   8992         (-[WebImageData imageAtIndex:]):
   8993         (-[WebImageData propertiesAtIndex:]):
   8994         (-[WebImageData _createImages]):
   8995         (-[WebImageData decodeData:isComplete:callback:]):
   8996         (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]):
   8997         (drawPattern):
   8998         (-[WebImageData tileInRect:fromPoint:context:]):
   8999         (-[WebImageData isNull]):
   9000         (-[WebImageData size]):
   9001         (-[WebImageData _frameDurationAt:]):
   9002         (-[WebImageData _frameDuration]):
   9003         (+[WebImageData stopAnimationsInView:]):
   9004         (-[WebImageData addAnimatingRenderer:inView:]):
   9005         (-[WebImageData removeAnimatingRenderer:]):
   9006         * WebCoreSupport.subproj/WebImageDecodeItem.h: Added.
   9007         * WebCoreSupport.subproj/WebImageDecodeItem.m: Added.
   9008         (+[WebImageDecodeItem decodeItemWithImage:data:isComplete:callback:]):
   9009         (-[WebImageDecodeItem initWithImage:data:isComplete:callback:]):
   9010         (-[WebImageDecodeItem finalize]):
   9011         (-[WebImageDecodeItem dealloc]):
   9012         * WebCoreSupport.subproj/WebImageDecoder.h: Added.
   9013         * WebCoreSupport.subproj/WebImageDecoder.m: Added.
   9014         (decoderNotifications):
   9015         (+[WebImageDecoder initialize]):
   9016         (+[WebImageDecoder notifyMainThread]):
   9017         (+[WebImageDecoder sharedDecoder]):
   9018         (+[WebImageDecoder performDecodeWithImage:data:isComplete:callback:]):
   9019         (+[WebImageDecoder imageDecodesPending]):
   9020         (+[WebImageDecoder decodeComplete:status:]):
   9021         (-[WebImageDecoder init]):
   9022         (-[WebImageDecoder dealloc]):
   9023         (-[WebImageDecoder finalize]):
   9024         (-[WebImageDecoder removeItem]):
   9025         (-[WebImageDecoder addItem:]):
   9026         (-[WebImageDecoder decodeItem:]):
   9027         (decoderThread):
   9028         (startDecoderThread):
   9029         * WebCoreSupport.subproj/WebImageRenderer.m:
   9030         (-[WebImageRenderer initWithData:MIMEType:]):
   9031         (-[WebImageRenderer initWithContentsOfFile:]):
   9032         (-[WebImageRenderer incrementalLoadWithBytes:length:complete:callback:]):
   9033         (-[WebInternalImage incrementalLoadWithBytes:length:complete:callback:]):
   9034         * WebKit.pbproj/project.pbxproj:
   9035         * WebView.subproj/WebImageRepresentation.m:
   9036         (-[WebImageRepresentation receivedData:withDataSource:]):
   9037         (-[WebImageRepresentation receivedError:withDataSource:]):
   9038         (-[WebImageRepresentation finishedLoadingWithDataSource:]):
   9039 
   9040 2004-12-07  Chris Blumenberg  <cblu (a] apple.com>
   9041 
   9042 	Fix for performance regression.
   9043 
   9044         Reviewed by kevin.
   9045 
   9046         * WebCoreSupport.subproj/WebBridge.m:
   9047         (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): construct the WebResource without copying the data
   9048 
   9049 2004-12-07  Chris Blumenberg  <cblu (a] apple.com>
   9050 
   9051 	Fixed: <rdar://problem/3909243> REGRESSION: large standalone images stop loading part way through
   9052 
   9053         Reviewed by kevin.
   9054 
   9055         * WebView.subproj/WebBaseResourceHandleDelegate.h:
   9056         * WebView.subproj/WebMainResourceClient.m:
   9057         (-[WebMainResourceClient addData:]): call super so it buffers the data
   9058 
   9059 2004-12-06  Richard Williamson   <rjw (a] apple.com>
   9060 
   9061 	Use the AppKit's font rendering mode.  This fixes 3905347, but we still need to track down
   9062 	and resolve why metrics have changed for Courier.  This may be caused by changes in
   9063 	AppKit for 3902394.
   9064 
   9065         Reviewed by John.
   9066 
   9067         * WebCoreSupport.subproj/WebTextRenderer.m:
   9068         (_AppkitGetCGRenderingMode):
   9069         (getUncachedWidth):
   9070         (_drawGlyphs):
   9071 
   9072 2004-12-06  Chris Blumenberg  <cblu (a] apple.com>
   9073 
   9074 	Forgot to commit copied header.
   9075 
   9076         * DOM.subproj/DOMPrivate.h:
   9077 
   9078 2004-12-06  Chris Blumenberg  <cblu (a] apple.com>
   9079 
   9080 	Fixed: <rdar://problem/3907381> NSURLConnection and WebKit buffer 2 copies of incoming data
   9081 
   9082         Reviewed by darin.
   9083 
   9084         * WebView.subproj/WebBaseResourceHandleDelegate.h:
   9085         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   9086         (+[WebBaseResourceHandleDelegate initialize]): cache check to see if Foundation supports access to its buffered data
   9087         (-[WebBaseResourceHandleDelegate addData:]): don't buffer data if Foundation is buffering it for us
   9088         (-[WebBaseResourceHandleDelegate saveResource]): when creating a WebResource, pass NO for copyData since we know it won't be mutated
   9089         (-[WebBaseResourceHandleDelegate resourceData]): return the buffered data from the connection if it supports it
   9090         (-[WebBaseResourceHandleDelegate willStopBufferingData:]): make a mutable copy of the data from NSURLConnection so we can continue buffering 
   9091         (-[WebBaseResourceHandleDelegate willCacheResponse:]): removed optimization that used the cached response data to save the resource since that is obsolete by this change
   9092         (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): new callback from NSURLConnection, informs us that NSURLConnection has given up buffering
   9093         * WebView.subproj/WebDataSource.m:
   9094         (-[WebDataSource _receivedData:]): removed buffering code since that's done by NSURLConnection and the main client
   9095         (-[WebDataSource _setData:]): removed unnecessary cast since the resourceData ivar is now an NSData instead of NSMutableData
   9096         (-[WebDataSource data]): return resourceData ivar, else return the resourceData from the main client
   9097         * WebView.subproj/WebDataSourcePrivate.h:
   9098         * WebView.subproj/WebMainResourceClient.m:
   9099         (-[WebMainResourceClient releaseResources]): store resourceData on the data source so it can continue to have data after the main client has gone away 
   9100         (-[WebMainResourceClient connection:didReceiveData:lengthReceived:]):don't call [dataSource data] just to get the length of data received since [dataSource data] can now cause data to be copied
   9101         (-[WebMainResourceClient connectionDidFinishLoading:]): ditto
   9102         * WebView.subproj/WebResource.m:
   9103         (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call following method with YES for copyData
   9104         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:copyData:]): new initializer, allows caller to choose whether or not the data is copied
   9105         * WebView.subproj/WebResourcePrivate.h:
   9106 
   9107 2004-12-06  Richard Williamson   <rjw (a] apple.com>
   9108 
   9109 	Fixed <rdar://problem/3903749> REGRESSION (8A321): WebKit gets incorrect glyph metrics due to change in how AppKit uses CGFont
   9110 
   9111 	Use CGFontRef direction when both getting font metrics and drawing
   9112 	glyphs, instead on depending on [NSFont set].
   9113 
   9114         Reviewed by John.
   9115 
   9116         * WebCoreSupport.subproj/WebTextRenderer.m:
   9117         (getUncachedWidth):
   9118         (_drawGlyphs):
   9119 
   9120 2004-12-06  Ken Kocienda  <kocienda (a] apple.com>
   9121 
   9122         Reviewed by Harrison
   9123         
   9124         Fix for this bug:
   9125         
   9126         <rdar://problem/3906930> Hitting return key in editable content inserts br elements instead of blocks
   9127 
   9128         * WebView.subproj/WebHTMLView.m:
   9129         (-[WebHTMLView insertNewline:]): One-line change to call insert-block rather than insert-br method 
   9130         on bridge.
   9131 
   9132 2004-12-04  Darin Adler  <darin (a] apple.com>
   9133 
   9134         Reviewed by John.
   9135 
   9136         - fixed <rdar://problem/3846079> assertion failure in WebHTMLView(WebPrivate) removeTrackingRect at boots.com
   9137         - fixed <rdar://problem/3857737> REGRESSION (165-166): clicking in a text field that's scrolled to the right causes it to scroll all the way left
   9138         - fixed <rdar://problem/3861952> REGRESSION (165-166): selection is cleared when you start to scroll a frame
   9139 
   9140         * WebView.subproj/WebHTMLViewInternal.h: Added handlingMouseDown flag.
   9141         * WebView.subproj/WebHTMLView.m:
   9142         (-[WebHTMLView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): Allow passing in a
   9143         tracking number of 0, which means no existing tracking number.
   9144         (-[WebHTMLView _addTrackingRects:owner:userDataList:assumeInsideList:trackingNums:count:]): Ditto.
   9145         (-[WebHTMLView removeTrackingRect:]): Allow removing a tracking number of 0, which is a no-op.
   9146         (-[WebHTMLView _removeTrackingRects:count:]): Ditto.
   9147         (-[WebHTMLView acceptsFirstResponder]): Changed check to use handlingMouseDown flag instead of mouseDownEvent
   9148         field since that field is set up too early in the mouse down event handling process.
   9149         (-[WebHTMLView mouseDown:]): Added code to set handlingMouseDown flag.
   9150 
   9151         - fixed part of <rdar://problem/3829808> Safari crashes when adding a DOM node that was removed from an XMLHTTP request result
   9152 
   9153         * WebCoreSupport.subproj/WebBridge.m:
   9154         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
   9155         Changed code around so that it won't try to create a WebResource when the load fails.
   9156 
   9157         - moved next/previous links into private structure with the rest of WebFrame fields
   9158           (We have a rule against putting new fields into obejcts that are part of our public API.)
   9159 
   9160         * WebView.subproj/WebFrame.h: Remove _nextSibling and _previousSibling.
   9161         * WebView.subproj/WebFramePrivate.h: Added nextSibling and previousSibling fields to private class.
   9162         * WebView.subproj/WebFrame.m: Got rid of some tabs in this file.
   9163         (-[WebFrame _addChild:]): Changed code to use fields inside _private.
   9164         (-[WebFrame _removeChild:]): Ditto.
   9165         (-[WebFrame _nextFrameWithWrap:]): Ditto.
   9166         (-[WebFrame _previousFrameWithWrap:]): Ditto.
   9167 
   9168 2004-12-04  Chris Blumenberg  <cblu (a] apple.com>
   9169 
   9170 	New fixes for:
   9171 	<rdar://problem/3685766> WebDataSource is missing subresources when they use cached WebCore data
   9172 	<rdar://problem/3722434> REGRESSION?: Assertion failure trying to drag image in iframe (itapema.sc.gov.br)
   9173 	<rdar://problem/3903173> REGRESSION (172-TOT): assertion failure and crash in slotAllData logging into hotmail account
   9174 	<rdar://problem/3902749> REGRESSION (Tiger): missing image symbol does not appear
   9175 
   9176         Reviewed by darin, rjw, kocienda.
   9177 
   9178         * WebCoreSupport.subproj/WebBridge.m:
   9179         (-[WebBridge objectLoadedFromCacheWithURL:response:data:]):
   9180         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
   9181         * WebCoreSupport.subproj/WebSubresourceClient.m:
   9182         (-[WebSubresourceClient didFinishLoading]):
   9183         * WebView.subproj/WebFrame.m:
   9184         (-[WebFrame _opened]):
   9185         (-[WebFrame _internalLoadDelegate]):
   9186         (-[WebFrame _sendResourceLoadDelegateMessagesForURL:response:length:]):
   9187         * WebView.subproj/WebFrameInternal.h:
   9188 
   9189 2004-12-04  Darin Adler  <darin (a] apple.com>
   9190 
   9191         Reviewed by Maciej.
   9192 
   9193         - fixed remaining bit of <rdar://problem/3814237> REGRESSION (Mail): Copy/paste style does not set color in Mail compose window
   9194 
   9195         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): When translating from
   9196         an attribute dictionary to a CSS declaration, treat missing values according to the defaults defined
   9197         in <AppKit/NSAttributedString.h>. Before the code was treating them as "no change", which is incorrect.
   9198 
   9199         * English.lproj/StringsNotToBeLocalized.txt: Add a string from the above change.
   9200 
   9201 === Safari-173 ===
   9202 
   9203 2004-12-03  Ken Kocienda  <kocienda (a] apple.com>
   9204 
   9205         Reviewed by me
   9206 
   9207         Roll out some recent changes by Chris that caused a performance regression.
   9208         Fix is in hand, but it is a little risky this close to a submission. So,
   9209         we have decided to roll back the change with the regression and roll in
   9210         the new code after we submit.
   9211 
   9212         * WebCoreSupport.subproj/WebBridge.m:
   9213         (-[WebBridge objectLoadedFromCacheWithURL:response:size:]):
   9214         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
   9215         * WebCoreSupport.subproj/WebSubresourceClient.m:
   9216         (-[WebSubresourceClient didFinishLoading]):
   9217         * WebView.subproj/WebFrame.m:
   9218         (-[WebFrame _opened]):
   9219         (-[WebFrame _internalLoadDelegate]):
   9220         * WebView.subproj/WebFrameInternal.h:
   9221 
   9222 2004-12-02  Richard Williamson   <rjw (a] apple.com>
   9223 
   9224 	Fixed <rdar://problem/3841332> REGRESSION (125.9-167u): repro crash in -[KWQPageState invalidate] involving .Mac images
   9225 
   9226 	Ensure that the document is cleared when leaving a non-HTML page.  This ensures that
   9227 	the b/f cache won't incorrectly trash the previous state when restoring.
   9228 
   9229         Reviewed by John.
   9230 
   9231         * WebView.subproj/WebFrame.m:
   9232         (-[WebFrame _setState:]):
   9233 
   9234 2004-12-02  Ken Kocienda  <kocienda (a] apple.com>
   9235 
   9236         Reviewed by Richard
   9237 
   9238         <rdar://problem/3748323> Problem with -[WebView editableDOMRangeForPoint:] (-isFlipped not taken into account?)
   9239         <rdar://problem/3852590> REGRESSION (Mail): Dropped content appears in wrong place if Mail message is scrolled down
   9240 
   9241         When implementing drag and drop, moveDragCaretToPoint: and editableDOMRangeForPoint: are used in
   9242         concert to track the mouse and determine a drop location, respectively. However, moveDragCaretToPoint:
   9243         did a conversion of the passed-in point to the document view's coordinate space, whereas 
   9244         editableDOMRangeForPoint: did not. Now it does.
   9245         
   9246         Note that I will need to coordinate with Grant to have him roll out some code in Mail that
   9247         attempts to work around this problem (unsuccessfully), and actually manages to block the
   9248         real fix (which needs to be in WebKit).
   9249 
   9250         * WebView.subproj/WebView.m:
   9251         (-[WebView editableDOMRangeForPoint:]): Convert the passed-in point to the document view's coordinate space.
   9252 
   9253 2004-12-02  Richard Williamson   <rjw (a] apple.com>
   9254 
   9255 	Fixed <rdar://problem/3895810> FATAL ERROR: <WebTextRenderer: 0x9328a20> unable to initialize with font "Times-Roman 16.00 pt. S ....
   9256 
   9257 	We have a hack to replace Times with Times New Roman if we fail
   9258         to setup Times.  If we then fail to setup Times New Roman we
   9259         don't attempt to further fallback to the system font.  Added
   9260         that additional fallback.
   9261 
   9262         Reviewed by Ken.
   9263 
   9264         * WebCoreSupport.subproj/WebTextRenderer.m:
   9265         (+[WebTextRenderer webFallbackFontFamily]):
   9266         (-[WebTextRenderer initWithFont:usingPrinterFont:]):
   9267 
   9268 2004-12-02  Richard Williamson   <rjw (a] apple.com>
   9269 
   9270 	Fixed build problem on Tiger8A821.  Private macro and function
   9271 	we were using have been deprecated,
   9272 
   9273         Reviewed by Vicki.
   9274 
   9275         * WebCoreSupport.subproj/WebTextRenderer.m:
   9276         (-[WebTextRenderer initWithFont:usingPrinterFont:]):
   9277 
   9278 2004-12-01  Chris Blumenberg  <cblu (a] apple.com>
   9279 
   9280 	Fixed: <rdar://problem/3879870> Flash Player unable to stop data stream from continuing to download by returning -1 from NPP_Write
   9281 	Also improved and cleaned-up the plug-in stream termination code.
   9282 
   9283         Reviewed by john.
   9284 
   9285         * Plugins.subproj/WebBaseNetscapePluginStream.h:
   9286         * Plugins.subproj/WebBaseNetscapePluginStream.m:
   9287         (+[WebBaseNetscapePluginStream reasonForError:]): return NPRES_DONE for a nil error
   9288         (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]): new, factored out from other methods
   9289         (-[WebBaseNetscapePluginStream errorForReason:]): new
   9290         (-[WebBaseNetscapePluginStream dealloc]): release MIME type
   9291         (-[WebBaseNetscapePluginStream setMIMEType:]): new
   9292         (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): call setMIMEType so we can use it in _pluginCancelledConnectionError, call renamed methods
   9293         (-[WebBaseNetscapePluginStream _destroyStream]): prepended underscore, replaced some early returns with asserts as the callers are now smarter
   9294         (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]): prepended underscore, only call _destroyStream if there is an error or if the load is complete and there is no more data to be streamed
   9295         (-[WebBaseNetscapePluginStream cancelLoadWithError:]): new, overridden by subclasses to cancel the actual NSURLConnection
   9296         (-[WebBaseNetscapePluginStream destroyStreamWithError:]): new, calls _destroyStreamWithReason
   9297         (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): call renamed methods
   9298         (-[WebBaseNetscapePluginStream _deliverData]): prepended underscore, call cancelLoadAndDestroyStreamWithError if NPP_Write returns a negative number
   9299         * Plugins.subproj/WebBaseNetscapePluginView.m:
   9300         (-[WebBaseNetscapePluginView destroyStream:reason:]): call cancelLoadAndDestroyStreamWithError
   9301         * Plugins.subproj/WebNetscapePluginRepresentation.m:
   9302         (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): call destroyStreamWithError
   9303         (-[WebNetscapePluginRepresentation cancelLoadWithError:]): new, override method, tell the data source to stop loading
   9304         * Plugins.subproj/WebNetscapePluginStream.m:
   9305         (-[WebNetscapePluginStream cancelLoadWithError:]): new, override method, tell the loader to stop
   9306         (-[WebNetscapePluginStream stop]): call cancelLoadAndDestroyStreamWithError
   9307         (-[WebNetscapePluginConnectionDelegate isDone]): new
   9308         (-[WebNetscapePluginConnectionDelegate didReceiveResponse:]): call cancelLoadAndDestroyStreamWithError
   9309         (-[WebNetscapePluginConnectionDelegate didFailWithError:]): call destroyStreamWithError
   9310 
   9311 2004-12-01  Kevin Decker  <kdecker (a] apple.com>
   9312 
   9313         Reviewed by Harrison.
   9314 
   9315 	Fixed: <rdar://problem/3228878> potential performance problem in finding in large framesets
   9316 
   9317 	Got rid of O(N^2) conditions in _nextSibling and _previousSibling of where we were looking up self in the parent array of frames.
   9318 
   9319         * WebView.subproj/WebFrame.h: Added two new pointers, one for the previous kid and one for the next kid
   9320         * WebView.subproj/WebFrame.m: 
   9321         (-[WebFrame _addChild:]): Updates the previous frame and the next frame after this child
   9322         (-[WebFrame _removeChild:]): ditto
   9323         (-[WebFrame _nextSibling]): just return the pointer now
   9324         (-[WebFrame _previousSibling]): ditto
   9325 
   9326 2004-11-30  Chris Blumenberg  <cblu (a] apple.com>
   9327 
   9328 	Fixed:
   9329 	<rdar://problem/3685766> WebDataSource is missing subresources when they use cached WebCore data
   9330 	<rdar://problem/3722434> REGRESSION?: Assertion failure trying to drag image in iframe (itapema.sc.gov.br)
   9331 
   9332         Reviewed by darin.
   9333 
   9334         * WebCoreSupport.subproj/WebBridge.m:
   9335         (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): renamed to pass all data for the resource, moved delegate code to new method
   9336         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): call renamed method
   9337         * WebCoreSupport.subproj/WebSubresourceClient.m:
   9338         (-[WebSubresourceClient didFinishLoading]): call renamed method
   9339         * WebView.subproj/WebFrame.m:
   9340         (-[WebFrame _opened]): call _sendResourceLoadDelegateMessagesForURL:response:length:, not objectLoadedFromCacheWithURL:response:data:
   9341         (-[WebFrame _internalLoadDelegate]):
   9342         (-[WebFrame _sendResourceLoadDelegateMessagesForURL:response:length:]): moved from objectLoadedFromCacheWithURL:response:data:
   9343         * WebView.subproj/WebFrameInternal.h:
   9344 
   9345 2004-11-29  Darin Adler  <darin (a] apple.com>
   9346 
   9347         Reviewed by John.
   9348 
   9349         - worked around bug in Panther where NSScroller calls _destinationFloatValueForScroller: on superview
   9350           without first checking if it's implemented
   9351 
   9352         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _destinationFloatValueForScroller:]):
   9353         Implemented. Calls floatValue on the scroller.
   9354 
   9355         * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
   9356 
   9357 2004-11-23  Chris Blumenberg  <cblu (a] apple.com>
   9358 
   9359 	Fixed: <rdar://problem/3890944> disable icon database for Dashboard
   9360 
   9361         Reviewed by kevin.
   9362 
   9363         * Misc.subproj/WebIconDatabase.h:
   9364         * Misc.subproj/WebIconDatabase.m:
   9365         (-[WebIconDatabase init]): don't create dictionaries if disabled
   9366         (-[WebIconDatabase iconForURL:withSize:cache:]): return default icon if disabled
   9367         (-[WebIconDatabase iconURLForURL:]): return nil if disabled
   9368         (-[WebIconDatabase retainIconForURL:]): return if disabled
   9369         (-[WebIconDatabase releaseIconForURL:]): ditto
   9370         (-[WebIconDatabase delayDatabaseCleanup]): ditto
   9371         (-[WebIconDatabase allowDatabaseCleanup]): ditto
   9372         (-[WebIconDatabase _isEnabled]): new
   9373         (-[WebIconDatabase _setIcon:forIconURL:]): assert if called when disabled, moved to own category implementation
   9374         (-[WebIconDatabase _setHaveNoIconForIconURL:]): ditto
   9375         (-[WebIconDatabase _setIconURL:forURL:]): ditto
   9376         (-[WebIconDatabase _createFileDatabase]): tweak
   9377         (-[WebIconDatabase _applicationWillTerminate:]): moved out of public code
   9378         * Misc.subproj/WebIconDatabasePrivate.h:
   9379         * Misc.subproj/WebIconLoader.m:
   9380         * WebView.subproj/WebDataSource.m:
   9381         (-[WebDataSource _updateIconDatabaseWithURL:]): assert if called when icon DB is disabled
   9382         (-[WebDataSource _loadIcon]): don't load icon if icon DB is disabled
   9383 
   9384 2004-11-22  David Hyatt  <hyatt (a] apple.com>
   9385 
   9386 	Make sure the WebCore cache grows at 512mb and at 1024mb exactly.
   9387 	
   9388         Reviewed by mjs
   9389 
   9390         * WebCoreSupport.subproj/WebBridge.m:
   9391         (-[WebBridge getObjectCacheSize]):
   9392 
   9393 2004-11-22  Richard Williamson   <rjw (a] apple.com>
   9394 
   9395 	Fixed <rdar://problem/3891737> WebPreferences do not work if they are set before set on the WebView
   9396 
   9397 	John found this problem and suggested the fix.
   9398 
   9399         Reviewed by John Louch.
   9400 
   9401         * WebView.subproj/WebView.m:
   9402         (-[WebView setPreferences:]):
   9403 
   9404 2004-11-22  Ken Kocienda  <kocienda (a] apple.com>
   9405 
   9406         Reviewed by Harrison
   9407 
   9408         * WebCoreSupport.subproj/WebBridge.m:
   9409         (-[WebBridge canPaste]): Call WebView _canPaste.
   9410         * WebView.subproj/WebView.m:
   9411         (-[WebView _canPaste]): Try to forward to document view's implementation. Only WebHTMLView
   9412         answers right now. Returns NO otherwise.
   9413         * WebView.subproj/WebViewInternal.h: Add _canPaste method to WebView.
   9414 
   9415 2004-11-22  Maciej Stachowiak  <mjs (a] apple.com>
   9416 
   9417 	Back  out the window closing fix, it seems to be causing crashes.
   9418 
   9419         * WebView.subproj/WebFrame.m:
   9420         (-[WebFrame _detachFromParent]):
   9421 
   9422 2004-11-20  Maciej Stachowiak  <mjs (a] apple.com>
   9423  
   9424         Reviewed by John.
   9425  
   9426  	<rdar://problem/3710101> _web_userVisibleString makes URL autocomplete roughly 2x slower
   9427          
   9428  	* Misc.subproj/WebNSURLExtras.h:
   9429         * Misc.subproj/WebNSURLExtras.m:
   9430         (-[NSString _web_isUserVisibleURL]): New SPI to check if a URL
   9431  	string is already in user-visible form (i.e. converting it to an
   9432  	NSURL and then back via _web_userVisibleString would not change
   9433  	anything).
   9434  
   9435 2004-11-19  Maciej Stachowiak  <mjs (a] apple.com>
   9436 
   9437         Reviewed by John.
   9438 
   9439 	<rdar://problem/3190977> closing window with many tabs in it can be quite slow
   9440         
   9441 	* WebView.subproj/WebFrame.m:
   9442         (-[WebFrame _detachFromParent]): autorelease bridge instead of releasing it,
   9443 	to make window and tab closing more responsive - this way the deallocation happens
   9444 	after the windoow or tab appears to close.
   9445 
   9446 === Safari-172 ===
   9447 
   9448 2004-11-19  Chris Blumenberg  <cblu (a] apple.com>
   9449 
   9450 	Fixed: <rdar://problem/3880387> REGRESSION: www.shockplay.com site gives "Unexpected server response"
   9451 
   9452         Reviewed by mjs.
   9453 
   9454         * Plugins.subproj/WebBaseNetscapePluginView.m:
   9455         (-[NSData _web_locationAfterFirstBlankLine]): support both formats ("\r\n\n" and "\r\n\r\n") for separating header data from body data because Shockwave still sends the prior format
   9456 
   9457 2004-11-19  Ken Kocienda  <kocienda (a] apple.com>
   9458 
   9459         Reviewed by Harrison
   9460 
   9461         Fix for this bug:
   9462 
   9463         <rdar://problem/3655241> setTypingStyle: does not set the real typing style, and typingStyle does not return it
   9464 
   9465         * WebCoreSupport.subproj/WebBridge.m:
   9466         (-[WebBridge respondToChangedContents]): No longer call through to WebKit to set the typing style. The call
   9467         was part of the misguided use of the setTypingStyle: and typingStyle as a cache of what was stored on
   9468         the WebCore side.
   9469         (-[WebBridge respondToChangedSelection]): Ditto.
   9470         * WebView.subproj/WebView.m:
   9471         (-[WebViewPrivate dealloc]): Object no longer has typingStyle ivar.
   9472         (-[WebView setTypingStyle:]): Call over the bridge to set typing style.
   9473         (-[WebView typingStyle]): Call over the bridge to retrieve typing style.
   9474         * WebView.subproj/WebViewInternal.h: Object no longer has typingStyle ivar.
   9475 
   9476 2004-11-18  John Sullivan  <sullivan (a] apple.com>
   9477 
   9478         Reviewed by Darin.
   9479         
   9480         - fixed <rdar://problem/3886042> should save history file as binary XML so serialization, 
   9481         parsing, reading and writing is faster
   9482 
   9483         * History.subproj/WebHistory.m:
   9484         (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]):
   9485         convert dictionary to binary data before saving
   9486 
   9487 2004-11-18  Chris Blumenberg  <cblu (a] apple.com>
   9488 
   9489         * WebView.subproj/WebHTMLRepresentation.m:
   9490         (-[WebHTMLRepresentation currentForm]): removed stray ";"
   9491 
   9492 2004-11-18  Chris Blumenberg  <cblu (a] apple.com>
   9493 
   9494 	Fixed development build failure.
   9495 
   9496         * Misc.subproj/WebIconDatabase.m:
   9497         (+[WebIconDatabase sharedIconDatabase]): call LOG not Log
   9498 
   9499 2004-11-18  Chris Blumenberg  <cblu (a] apple.com>
   9500 
   9501 	<rdar://problem/3885708> save memory in icon DB by not using NSSets when holding 1 object
   9502 	
   9503         Reviewed by sullivan.
   9504 
   9505         * Misc.subproj/WebIconDatabase.m:
   9506         (+[WebIconDatabase sharedIconDatabase]): added timing code
   9507         (-[WebIconDatabase _clearDictionaries]): new
   9508         (-[WebIconDatabase _loadIconDictionaries]): call _clearDictionaries in 2 places before we bail, use _web_setObjectUsingSetIfNecessary:forKey: when adding site URLs to the iconURLToURLs dictionary
   9509         (-[WebIconDatabase _updateFileDatabase]): fixed comment
   9510         (-[WebIconDatabase _setIconURL:forURL:]): use _web_setObjectUsingSetIfNecessary:forKey: when adding site URLs to the iconURLToURLs dictionary
   9511         (-[WebIconDatabase _releaseIconForIconURLString:]): handle NSString objects retured from iconURLToURLs
   9512         (-[NSMutableDictionary _web_setObjectUsingSetIfNecessary:forKey:]): new, puts a set on the dictionary when there are 2 or more object for s key
   9513 
   9514 2004-11-17  Richard Williamson   <rjw (a] apple.com>
   9515 
   9516 	Fixed <rdar://problem/3885073> REGRESSION: Tab images at top of news.com.com replicated and squished
   9517 
   9518 	Correctly account for scaled image size and clipping.
   9519 
   9520         Reviewed by Maciej.
   9521 
   9522         * WebCoreSupport.subproj/WebImageData.h:
   9523         * WebCoreSupport.subproj/WebImageData.m:
   9524         * WebCoreSupport.subproj/WebImageRenderer.m:
   9525         (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
   9526 
   9527 2004-11-17  Maciej Stachowiak  <mjs (a] apple.com>
   9528 
   9529         Reviewed by Richard.
   9530 
   9531 	<rdar://problem/3885076> Don't make IDN calls for all-ascii URLs to save about 3 pages
   9532 	at Safari startup.
   9533 	
   9534         * Misc.subproj/WebNSURLExtras.m:
   9535         (mapHostNames): If encoding and not decoding, then bail early if the URL is all ascii.
   9536         (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Remove earlier special-case
   9537 	check for localhost, no longer needed.
   9538 
   9539 2004-11-17  Richard Williamson   <rjw (a] apple.com>
   9540 
   9541 	Fixed <rdar://problem/3863601> Legacy font cache code in [WebTextRendererFactory createSharedFactory] may be unnecesary
   9542 
   9543 	and added call to SPI for
   9544 
   9545 	<rdar://problem/3884448> WebKit should turn on CG local font cache
   9546 
   9547 	currently disabled until a Tiger build shows up with the SPI.
   9548 
   9549         Reviewed by David Harrison.
   9550 
   9551         * WebCoreSupport.subproj/WebTextRendererFactory.m:
   9552         (+[WebTextRendererFactory createSharedFactory]):
   9553 
   9554 2004-11-17  Richard Williamson   <rjw (a] apple.com>
   9555 
   9556         Fixed <rdar://problem/3882212> REGRESSION: Images clipped instead of scaled
   9557         Fixed <rdar://problem/3884088> Crash terminating image load
   9558 
   9559         Also added code to turn off color correction for images created
   9560         via CGImageSources.  This code is currently disabled because CG  
   9561         can't change the color space of images loaded progressively.
   9562         Further, according to Dave Hayward, CG will no longer attempt
   9563         to color correct images that don't have embedded profiles as of
   9564         Tiger 8A306.
   9565 
   9566         Reviewed by Chris.
   9567 
   9568         * WebCoreSupport.subproj/WebImageData.m:
   9569         (-[WebImageData _commonTermination]):
   9570         (-[WebImageData dealloc]):
   9571         (-[WebImageData _invalidateImageProperties]):
   9572         (-[WebImageData imageAtIndex:]):
   9573         (-[WebImageData incrementalLoadWithBytes:length:complete:]):
   9574         (-[WebImageData propertiesAtIndex:]):
   9575 
   9576 2004-11-16  Chris Blumenberg  <cblu (a] apple.com>
   9577 
   9578 	Fixed: <rdar://problem/3882034> REGRESSION: Context menu incorrect for PDF content
   9579 
   9580         Reviewed by darin.
   9581 
   9582         * WebView.subproj/WebPDFView.m:
   9583         (-[WebPDFView hitTest:]): return self if the current event is a context menu event
   9584         (-[WebPDFView menuForEvent:]): use the PDFView subview
   9585 
   9586 2004-11-15  Chris Blumenberg  <cblu (a] apple.com>
   9587 
   9588 	Fixed: <rdar://problem/3880410> save 5 dirty pages by soft-linking against PDFKit framework
   9589 
   9590         Reviewed by john.
   9591 
   9592         * WebKit.pbproj/project.pbxproj:
   9593         * WebView.subproj/WebPDFRepresentation.m:
   9594         (+[WebPDFRepresentation PDFDocumentClass]): new
   9595         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): use PDFDocumentClass
   9596         * WebView.subproj/WebPDFView.h:
   9597         * WebView.subproj/WebPDFView.m:
   9598         (+[WebPDFView PDFKitBundle]): new
   9599         (+[WebPDFView PDFViewClass]): new
   9600         (-[WebPDFView initWithFrame:]): create a PDFView subview
   9601         (-[WebPDFView dealloc]): release the PDFView subview
   9602         (-[WebPDFView PDFSubview]): new
   9603 
   9604 2004-11-15  Chris Blumenberg  <cblu (a] apple.com>
   9605 
   9606 	Fixed: <rdar://problem/3879891> WebKit should link against PDFKit instead of Quartz
   9607 
   9608         Reviewed by darin.
   9609 
   9610         * WebKit.pbproj/project.pbxproj: link against PDFKit if it is present instead of Quartz.framework
   9611 
   9612 2004-11-15  Richard Williamson   <rjw (a] apple.com>
   9613 
   9614 	Fixed missing retain of image property data.
   9615 
   9616         Reviewed by John.
   9617 
   9618         * WebCoreSupport.subproj/WebImageData.h:
   9619         * WebCoreSupport.subproj/WebImageData.m:
   9620         (-[WebImageData dealloc]):
   9621         (-[WebImageData _invalidateImages]):
   9622         (-[WebImageData imageAtIndex:]):
   9623         (-[WebImageData propertiesAtIndex:]):
   9624         (-[WebImageData _frameDuration]):
   9625 
   9626 2004-11-15  Richard Williamson   <rjw (a] apple.com>
   9627 
   9628 	Cache image properties and frame durations.
   9629 	Create NSImage and TIFF representations from CGImage, lazily, as needed for
   9630 	dragging and element info dictionary.
   9631 
   9632         Reviewed by John.
   9633 
   9634         * WebCoreSupport.subproj/WebImageData.h:
   9635         * WebCoreSupport.subproj/WebImageData.m:
   9636         (-[WebImageData dealloc]):
   9637         (-[WebImageData size]):
   9638         (-[WebImageData propertiesAtIndex:]):
   9639         (-[WebImageData _frameDurationAt:]):
   9640         (-[WebImageData _frameDuration]):
   9641         * WebCoreSupport.subproj/WebImageRenderer.h:
   9642         * WebCoreSupport.subproj/WebImageRenderer.m:
   9643         (-[WebImageRenderer dealloc]):
   9644         (-[WebImageRenderer TIFFRepresentation]):
   9645         (-[WebImageRenderer image]):
   9646 
   9647 2004-11-14  Maciej Stachowiak  <mjs (a] apple.com>
   9648 
   9649         Reviewed by John.
   9650 
   9651 	<rdar://problem/3879226> WebKit needlessly uses extra memory to store icon refcounts as NSNumbers	
   9652 
   9653 	* Misc.subproj/WebIconDatabase.m:
   9654         (-[WebIconDatabase init]):
   9655         (-[WebIconDatabase _setIconURL:forURL:]):
   9656         (-[WebIconDatabase _retainIconForIconURLString:]):
   9657         (-[WebIconDatabase _releaseIconForIconURLString:]):
   9658         (-[WebIconDatabase _retainFutureIconForURL:]):
   9659         (-[WebIconDatabase _releaseFutureIconForURL:]):
   9660         * Misc.subproj/WebIconDatabasePrivate.h:
   9661 
   9662 2004-11-15  John Sullivan  <sullivan (a] apple.com>
   9663 
   9664         Reviewed by Ken.
   9665         
   9666         - fixed <rdar://problem/3879513> leak in [WebArchive _propertyListRepresentation] copying HTML to pasteboard
   9667 
   9668         * WebView.subproj/WebArchive.m:
   9669         (-[WebArchive _propertyListRepresentation]):
   9670         the array holding the subresources was not released after use, oops!
   9671 
   9672 2004-11-12  Chris Blumenberg  <cblu (a] apple.com>
   9673 
   9674 	Fixed: <rdar://problem/3874577> Opening restricted (parental) content in new window/tab reveals Safari's "Resources" folder
   9675 	
   9676         Reviewed by john.
   9677 
   9678         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   9679         (-[WebDefaultUIDelegate openFrameInNewWindow:]): use the unreachable URL if there is one
   9680 
   9681 === Safari-171 ===
   9682 
   9683 2004-11-11  Richard Williamson   <rjw (a] apple.com>
   9684 
   9685         Report actual size (not partial size) but use partial size
   9686         when drawing.
   9687 
   9688         Reviewed by Maciej.
   9689 
   9690         * WebCoreSupport.subproj/WebImageData.h:
   9691         * WebCoreSupport.subproj/WebImageData.m:
   9692         (-[WebImageData size]):
   9693 
   9694 2004-11-11  Darin Adler  <darin (a] apple.com>
   9695 
   9696         Reviewed by John.
   9697 
   9698         - added _wasFirstResponderAtMouseDownTime method to bridge so we can fix
   9699           <rdar://problem/3846152> REGRESSION (125-166): can't drag text out of <input type=text> fields
   9700           with a subsequent change to WebCore.
   9701 
   9702         * WebCoreSupport.subproj/WebBridge.m:
   9703         (wasFirstResponderAtMouseDownTime:): Added. Calls _wasFirstResponderAtMouseDownTime
   9704         on the WebHTMLView.
   9705         (_getPreSmartSet): Move global inside the function, add (void) for cleanliness.
   9706         (_getPostSmartSet): Ditto.
   9707 
   9708         * WebView.subproj/WebHTMLView.m:
   9709         (-[WebHTMLViewPrivate dealloc]): Release firstResponderAtMouseDownTime.
   9710         (-[WebHTMLView _setMouseDownEvent:]): Early exit if event is not changing.
   9711         Set firstResponderAtMouseDownTime to the first responder.
   9712         (-[WebHTMLView mouseDown:]): Release firstResponderAtMouseDownTime after handling
   9713         the mouseDown event.
   9714         (-[WebHTMLView _wasFirstResponderAtMouseDownTime:]): Added. Uses the
   9715         firstResponderAtMouseDownTime field.
   9716         * WebView.subproj/WebHTMLViewInternal.h: Added firstResponderAtMouseDownTime field
   9717         and _wasFirstResponderAtMouseDownTime method.
   9718 
   9719         * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
   9720 
   9721 2004-11-11  Richard Williamson   <rjw (a] apple.com>
   9722 
   9723         Reviewed by Chris.
   9724 
   9725 	Work-around to minimize impact of 3876764.  Cache frame durations
   9726 	after first call.  So we'll still leak 1K for each animated
   9727 	image, but that's better than 1K each time the frame is drawn!
   9728         * WebCoreSupport.subproj/WebImageData.h:
   9729         * WebCoreSupport.subproj/WebImageData.m:
   9730         (-[WebImageData _frameDuration]):
   9731 
   9732 	Simplified animation cleanup code.  Fixed leak due to 
   9733 	incorrect key passed to CFDictionaryRemoveValue.
   9734 	
   9735         (+[WebImageData stopAnimationsInView:]):
   9736         (-[WebImageData addAnimatingRenderer:inView:]):
   9737         (-[WebImageData removeAnimatingRenderer:]):
   9738         (-[WebImageData _stopAnimation]):
   9739 
   9740 2004-11-11  Darin Adler  <darin (a] apple.com>
   9741 
   9742         Reviewed by Maciej.
   9743 
   9744         - fixed <rdar://problem/3605906> Flash scrolled off the top and bottom cause CPU spin when combined with something dirty on the visible part of the page
   9745 
   9746         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
   9747         Work around AppKit bug by using rectangles from getRectsBeingDrawn:count: instead of
   9748         using the passed-in rectangle.
   9749 
   9750 2004-11-11  Richard Williamson   <rjw (a] apple.com>
   9751 
   9752         Work-arounds to make new ImageIO code work correctly.  Still
   9753         disabled for now.  Requires at least Tiger 300.  Testing does
   9754         show a 3% improvement in PLT tests!  That's huge!
   9755 
   9756         Reviewed by John.
   9757 
   9758         * WebCoreSupport.subproj/WebImageData.m:
   9759         (-[WebImageData imageAtIndex:]):
   9760         (-[WebImageData incrementalLoadWithBytes:length:complete:]):
   9761         (-[WebImageData isNull]):
   9762 
   9763 2004-11-10  Chris Blumenberg  <cblu (a] apple.com>
   9764 
   9765 	Fixed: <rdar://problem/3396872> ICONS: icon DB inconsistencies can cause slowness during startup, idle and quit
   9766 
   9767         Reviewed by john.
   9768 
   9769         * Misc.subproj/WebFileDatabase.m:
   9770         (-[WebFileDatabase objectForKey:]): added logging code
   9771         * Misc.subproj/WebIconDatabase.m:
   9772         (-[WebIconDatabase init]): use alloc, init rather than autorelease, retain
   9773         (-[WebIconDatabase _loadIconDictionaries]): use 1 object for mapping icon URLs to site URLs and vice versa rather than 3. This avoids inconsistencies and is faster.
   9774         (-[WebIconDatabase _updateFileDatabase]): write 1 object out
   9775 
   9776 2004-11-09  David Hyatt  <hyatt (a] apple.com>
   9777 
   9778 	Fix for 3873234, Safari UI is unresponsive when parsing multiple HTML docs and 3873233, Safari hangs when
   9779 	loading large local files.
   9780 	
   9781         Reviewed by mjs
   9782 
   9783         * WebCoreSupport.subproj/WebBridge.m:
   9784         (-[WebBridge tokenizerProcessedData]):
   9785         * WebView.subproj/WebDataSource.m:
   9786         (-[WebDataSource _receivedMainResourceError:complete:]):
   9787         (-[WebDataSource isLoading]):
   9788 
   9789 2004-11-09  Richard Williamson   <rjw (a] apple.com>
   9790 
   9791         Fixed <rdar://problem/3870964> 8A300: Safari not recognizing a PDF link (it displays raw data)
   9792 
   9793 	Add "text/pdf" as an acceptable PDF MIME type.
   9794 
   9795         Reviewed by Chris.
   9796 
   9797         * WebView.subproj/WebDataSource.m:
   9798         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
   9799         * WebView.subproj/WebFrameView.m:
   9800         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
   9801 
   9802 2004-11-08  Chris Blumenberg  <cblu (a] apple.com>
   9803 
   9804 	Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus
   9805 
   9806         Reviewed by john.
   9807 
   9808         * WebCoreSupport.subproj/WebBridge.m:
   9809         (-[WebBridge control:textView:shouldHandleEvent:]): new
   9810         * WebView.subproj/WebFormDelegate.h:
   9811         * WebView.subproj/WebFormDelegate.m:
   9812         (-[WebFormDelegate control:textView:shouldHandleEvent:inFrame:]): new
   9813 
   9814 2004-11-05  Chris Blumenberg  <cblu (a] apple.com>
   9815 
   9816 	Fixed: <rdar://problem/3854218> Safari is sometimes really slow because of increased null events to plug-ins
   9817 
   9818         * Plugins.subproj/WebBaseNetscapePluginView.m: reverted null event interval to 0.02
   9819 
   9820 2004-11-05  Chris Blumenberg  <cblu (a] apple.com>
   9821 
   9822 	Fixed: <rdar://problem/3838413> REGRESSION (Mail): "Smart" word paste adds spaces before/after special characters
   9823 
   9824         Reviewed by rjw.
   9825 
   9826         * WebCoreSupport.subproj/WebBridge.m:
   9827         (_getPreSmartSet): copied from AppKit
   9828         (_getPostSmartSet): ditto
   9829         (-[WebBridge isCharacterSmartReplaceExempt:isPreviousCharacter:]): new
   9830 
   9831 2004-11-05  Richard Williamson   <rjw (a] apple.com>
   9832 
   9833         Fixed <rdar://problem/3810702> _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector: ASSERTS when reentered from Xcode's man page viewer
   9834 
   9835         Reviewed by Maciej (a long time ago).
   9836 
   9837         * WebView.subproj/WebFrame.m:
   9838         (-[WebFrame _loadDataSource:withLoadType:formState:]):
   9839 
   9840         Fixed <rdar://problem/3845307> WebKit needs to export _HIWebViewRegisterClass so HIWebViews can work in Carbon nib files
   9841 
   9842         As suggested in the bug, the fix is to actually call 
   9843         HIWebViewRegisterClass in WebKitInitForCarbon, rather than
   9844         exporting the symbol.
   9845 
   9846         Reviewed by Chris.
   9847 
   9848         * Carbon.subproj/CarbonUtils.m:
   9849         (WebInitForCarbon):
   9850         * Carbon.subproj/HIWebView.m:
   9851         * WebKit.pbproj/project.pbxproj:
   9852 
   9853 === Safari-170 ===
   9854 
   9855 2004-11-05  Darin Adler  <darin (a] apple.com>
   9856 
   9857         Reviewed by Chris.
   9858 
   9859         - fixed <rdar://problem/3857151> Assertion failure in "trackingRectOwner" while moving mouse over Slashdot.org page
   9860 
   9861         * WebView.subproj/WebHTMLView.m:
   9862         (-[WebHTMLView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): Changed to no longer call
   9863         addTrackingRect to do the work for consistency with the new method below. Not too much copied and pasted code.
   9864         (-[WebHTMLView _addTrackingRects:owner:userDataList:assumeInsideList:trackingNums:count:]): Added an override
   9865         for this new method in Tiger. No harm in implementing it on Panther, although it won't be called.
   9866         (-[WebHTMLView _removeTrackingRects:count:]): Ditto.
   9867 
   9868 2004-11-04  David Hyatt  <hyatt (a] apple.com>
   9869 
   9870 	Make sure the dominant line direction is properly set for RTL runs so that spaces will reverse.
   9871 
   9872 	Change xHeight to measure the ascent of the x glyph, since the xHeight metrics appear to be
   9873 	totally bogus in both CG and AppKit.
   9874 	
   9875         Reviewed by darin
   9876 
   9877         * WebCoreSupport.subproj/WebTextRenderer.m:
   9878         (-[WebTextRenderer xHeight]):
   9879         (-[WebTextRenderer _createATSUTextLayoutForRun:style:]):
   9880         (-[WebTextRenderer _trapezoidForRun:style:atPoint:]):
   9881         (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]):
   9882         (-[WebTextRenderer _ATSU_drawRun:style:geometry:]):
   9883         (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   9884 
   9885 2004-11-02  Maciej Stachowiak  <mjs (a] apple.com>
   9886 
   9887         Reviewed by Dave Hyatt (when I originally coded it).
   9888 
   9889         Redid WebKit part of fix for:
   9890 
   9891         <rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:
   9892        
   9893         * WebView.subproj/WebHTMLView.m:
   9894         (-[WebHTMLView firstRectForCharacterRange:]): Call the appropriate new bridge method,
   9895         and translate to screen coordinates.
   9896 
   9897 2004-11-02  John Sullivan  <sullivan (a] apple.com>
   9898 
   9899         Reviewed by Hyatt.
   9900         
   9901         - [NSFont menuFontOfSize:], called from WebStringTruncator, was taking > 9% of the time creating a 
   9902         very large bookmarks menu, so I cached this one NSFont object.
   9903 
   9904         * Misc.subproj/WebStringTruncator.m:
   9905         (defaultMenuFont):
   9906         new function, caches the font used when no font is specified
   9907         (+[WebStringTruncator centerTruncateString:toWidth:]):
   9908         call new function
   9909 
   9910 2004-11-02  Ken Kocienda  <kocienda (a] apple.com>
   9911 
   9912         Reviewed by Hyatt
   9913 
   9914         WebCore now implements a command to insert a block in response to typing a return key, and
   9915         some names were improved in the course of this work.
   9916 
   9917         * WebView.subproj/WebHTMLView.m:
   9918         (-[WebHTMLView insertNewline:]): Now calls insertLineBreak on bridge object.
   9919         (-[WebHTMLView insertLineBreak:]): New method.
   9920         (-[WebHTMLView insertParagraphSeparator:]): Now implemented.
   9921         * WebView.subproj/WebView.m: 
   9922 
   9923 === Safari-169 ===
   9924 
   9925 2004-10-29  Chris Blumenberg  <cblu (a] apple.com>
   9926 
   9927         * WebKit.exp: added _WebPlugInModeKey, forgot to add it earlier
   9928 
   9929 2004-10-29  Darin Adler  <darin (a] apple.com>
   9930 
   9931         - fixed <rdar://problem/3855573> Remove reference to "WebScriptMethods" from WebScriptObject.h comments
   9932 
   9933         * Plugins.subproj/WebScriptObject.h: Removed unneeded #ifdef protection for multiple includes (since
   9934         this is an Objective-C header and we use #import for those). Fixed comments as requested in the bug
   9935         report to match the contents of the file.
   9936 
   9937 2004-10-27  Ken Kocienda  <kocienda (a] apple.com>
   9938 
   9939         Reviewed by Chris
   9940 
   9941         Added new SPI for Mail so it can get the behavior it needs when the user hits
   9942         the return key with the selection in quoted content.
   9943 
   9944         * WebView.subproj/WebView.m
   9945         * WebView.subproj/WebViewPrivate.h
   9946 
   9947 2004-10-26  Chris Blumenberg  <cblu (a] apple.com>
   9948 
   9949 	Fixed exception that Darin encountered in Mail.
   9950 
   9951         Reviewed by darin.
   9952 
   9953         * Plugins.subproj/WebPluginController.m:
   9954         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): if the plug-in returns a nil view, return nil
   9955 
   9956 2004-10-25  Chris Blumenberg  <cblu (a] apple.com>
   9957 
   9958 	Darin made an internal notification have the Web prefix.
   9959 
   9960         Reviewed by me.
   9961 
   9962         * Plugins.subproj/WebBaseNetscapePluginView.m:
   9963         (-[WebBaseNetscapePluginView addWindowObservers]):
   9964         (-[WebBaseNetscapePluginView removeWindowObservers]):
   9965         (ConsoleConnectionChangeNotifyProc):
   9966 
   9967 2004-10-25  John Sullivan  <sullivan (a] apple.com>
   9968 
   9969         Reviewed by Chris.
   9970         
   9971         - Cleanup from fix for <rdar://problem/3851676> bookmarks should not hold onto a WebHistoryItem object;
   9972           eliminated notificationsSuppressed mechanism, which was used only by WebBookmark
   9973 
   9974         * History.subproj/WebHistoryItem.m:
   9975         removed notificationsSuppressed ivar from private data object
   9976         (-[WebHistoryItem setAlternateTitle:]):
   9977         remove notificationsSuppressed guard
   9978         (-[WebHistoryItem setURLString:]):
   9979         ditto
   9980         (-[WebHistoryItem setOriginalURLString:]):
   9981         ditto
   9982         (-[WebHistoryItem setTitle:]):
   9983         ditto
   9984         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
   9985         ditto
   9986         (-[WebHistoryItem setNotificationsSuppressed:]):
   9987         removed this method
   9988         (-[WebHistoryItem notificationsSuppressed]):
   9989         ditto
   9990         
   9991         * History.subproj/WebHistoryItemPrivate.h:
   9992         removed notificationsSuppressed and setNotificationsSuppressed
   9993 
   9994 2004-10-22  Chris Blumenberg  <cblu (a] apple.com>
   9995 
   9996 	Fixed: <rdar://problem/3851491> installedPlugins being called for a page without plugins
   9997 
   9998         Reviewed by mjs.
   9999 
   10000         * WebView.subproj/WebFrameView.m:
   10001         (+[WebFrameView _canShowMIMETypeAsHTML:]): call _viewTypesAllowImageTypeOmission instead of using ivar since the ivar is nil until _viewTypesAllowImageTypeOmission is called, this was causing [WebView canShowMIMEType:] to check plug-ins 
   10002 
   10003 === Safari-168 ===
   10004 
   10005 2004-10-22  Ken Kocienda  <kocienda (a] apple.com>
   10006 
   10007         Reviewed by me
   10008 
   10009         * WebKit.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.
   10010 
   10011 2004-10-21  Darin Adler  <darin (a] apple.com>
   10012 
   10013         Reviewed by John.
   10014 
   10015         - fixed <rdar://problem/3847994> REGRESSION: reproducible exception in WebImageRenderer releasePatternColor; afterwards get crash or no more browsing
   10016 
   10017         * WebCoreSupport.subproj/WebImageRenderer.m:
   10018         (-[WebInternalImage createRendererIfNeeded]): Replaced retainOrCopyIfNeeded with this.
   10019         This returns nil if a copied renderer isn't needed, and returns a new renderer if a copy is.
   10020         The old version was sometimes returning a WebInternalImage and other times a WebImageRenderer.
   10021         (-[WebImageRenderer retainOrCopyIfNeeded]): Returns the result of createRendererIfNeeded
   10022         or retains self and returns self.
   10023 
   10024 2004-10-20  Darin Adler  <darin (a] apple.com>
   10025 
   10026         Reviewed by Dave.
   10027 
   10028         - fixed <rdar://problem/3470715> Pattern cache can get huge with use of css background-image in Safari
   10029 
   10030         * WebCoreSupport.subproj/WebImageRenderer.h: Change WebImageRenderer to be a subclass of NSObject
   10031         rather than NSImage and contain a pointer to a WebInternalImage.
   10032         * WebCoreSupport.subproj/WebImageRenderer.m:
   10033         (-[WebInternalImage releasePatternColor]): Added. Releases patternColor.
   10034         (-[WebImageRenderer initWithMIMEType:]): Added. Makes WebInternalImage and then self.
   10035         (-[WebImageRenderer initWithData:MIMEType:]): Ditto.
   10036         (-[WebImageRenderer initWithContentsOfFile:]): Ditto.
   10037         (-[WebImageRenderer dealloc]): Added. Calls releasePatternColor and then releases WebInternalImage.
   10038         (-[WebImageRenderer image]): Added. Returns pointer to image.
   10039         (-[WebImageRenderer MIMEType]): Added. Calls through to image.
   10040         (-[WebImageRenderer TIFFRepresentation]): Ditto.
   10041         (-[WebImageRenderer frameCount]): Ditto.
   10042         (-[WebImageRenderer setOriginalData:]): Added. Sets image data pointer.
   10043         (+[WebImageRenderer stopAnimationsInView:]): Added. Calls through to image.
   10044         (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Ditto.
   10045         (-[WebImageRenderer size]): Ditto.
   10046         (-[WebImageRenderer resize:]): Ditto.
   10047         (-[WebImageRenderer drawImageInRect:fromRect:]): Ditto.
   10048         (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]): Ditto.
   10049         (-[WebImageRenderer stopAnimation]): Ditto.
   10050         (-[WebImageRenderer tileInRect:fromPoint:context:]): Ditto.
   10051         (-[WebImageRenderer isNull]): Ditto.
   10052         (-[WebImageRenderer retainOrCopyIfNeeded]): Ditto.
   10053         (-[WebImageRenderer increaseUseCount]): Ditto.
   10054         (-[WebImageRenderer decreaseUseCount]): Ditto.
   10055         (-[WebImageRenderer flushRasterCache]): Ditto.
   10056         (-[WebImageRenderer imageRef]): Ditto.
   10057         (-[WebImageRenderer copyWithZone:]): Ditto.
   10058 
   10059         * Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]):
   10060         Update for slight changes to WebImageRenderer API.
   10061         * WebCoreSupport.subproj/WebImageRendererFactory.m:
   10062         (-[WebImageRendererFactory imageRendererWithMIMEType:]): Ditto.
   10063         (-[WebImageRendererFactory imageRendererWithData:MIMEType:]): Ditto.
   10064         (-[WebImageRendererFactory imageRendererWithSize:]): Ditto.
   10065         (-[WebImageRendererFactory imageRendererWithName:]): Ditto.
   10066         * WebView.subproj/WebImageView.m: (-[WebImageView image]): Ditto.
   10067 
   10068 2004-10-20  Chris Blumenberg  <cblu (a] apple.com>
   10069 	
   10070 	Fixed: <rdar://problem/3846943> REGRESSION: JNLP files are rendered instead of downloaded
   10071 
   10072         Reviewed by john.
   10073 
   10074         * Plugins.subproj/WebBasePluginPackage.h:
   10075         * Plugins.subproj/WebBasePluginPackage.m:
   10076         (-[WebBasePluginPackage isJavaPlugIn]): new
   10077         * Plugins.subproj/WebPluginDatabase.m:
   10078         (-[WebPluginDatabase refresh]): don't register the Java plug-in for a document view since Java file should be downloaded when not embedded.
   10079 
   10080 2004-10-20  Chris Blumenberg  <cblu (a] apple.com>
   10081 
   10082 	Fixed:
   10083 	<rdar://problem/3842030> WebKit needs to pass the mode (NP_FULL, NP_EMBED, etc) when calling plugInViewWithArguments
   10084 	<rdar://problem/3792852> Safari is loading the new QuickTime Cocoa plugin on Panther
   10085 
   10086         Reviewed by darin.
   10087 
   10088         * Plugins.subproj/WebPluginDocumentView.m:
   10089         (-[WebPluginDocumentView setDataSource:]): pass "full" as the mode
   10090         * Plugins.subproj/WebPluginPackage.m:
   10091         (-[WebPluginPackage initWithPath:]): load plug-in with the "webplugin" extension
   10092         * WebCoreSupport.subproj/WebBridge.m:
   10093         (-[WebBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): pass "embed" as the mode
   10094         * WebKit.pbproj/project.pbxproj:
   10095 
   10096 2004-10-19  Vicki Murley <vicki (a] apple.com>
   10097 
   10098 	- bump WebKit version to 167.1, so that we can do a quick dot submission for <rdar://problem/3843951> 
   10099 
   10100         * WebKit.pbproj/project.pbxproj:
   10101 
   10102 2004-10-19  Darin Adler  <darin (a] apple.com>
   10103 
   10104         Change suggested by Maciej during code review.
   10105 
   10106         * WebCoreSupport.subproj/WebTextRenderer.m: Changed rounding hack table to be const so it can be in shared instead
   10107         of private memory, and doesn't require an initialization function.
   10108         (+[WebTextRenderer initialize]): Removed initialization.
   10109 
   10110 2004-10-19  Darin Adler  <darin (a] apple.com>
   10111 
   10112         Reviewed by Maciej.
   10113 
   10114         - fixed <rdar://problem/3838934> Safari stops loading pages after rangeOfCharacterFromSet nil argument exception
   10115         - fixed <rdar://problem/3843951> REGRESSION (166-167): Safari crashes in widthForNextCharacter (belkin.com, at startup for others)
   10116         - fixed <rdar://problem/3841049> REGRESSION (109-110): control characters render as square boxes
   10117 
   10118         * WebCoreSupport.subproj/WebTextRenderer.m:
   10119         (isSpace): Merged in isAlternateSpace, never used.
   10120         (setupRoundingHackCharacterTable): Fixed size of table, was 1 entry too short. Got rid of unneeded call to bzero,
   10121         since globals start out zeroed automatically.
   10122         (isRoundingHackCharacter): Fixed backwards logic causing the crash in widthForNextCharacter.
   10123         Also removed explicit compare with 1; check for non-zero is just fine.
   10124         (fontContainsString): Change code so we'll just skip the font if the covered character set returns nil rather than
   10125         throwing an exception like the old version did. This should make bug 3838934 go away, although perhaps covering up
   10126         the underlying problem.
   10127         (-[WebTextRenderer _convertCharacters:length:toGlyphs:]): Removed unused skipControlCharacters: parameter and also
   10128         the unnecessary code to copy the buffer to change newline characters and non-break spaces to spaces.
   10129         (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): Removed unused local.
   10130         (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): Added code to set up special cases for control characters,
   10131         \n and non-break spaces.
   10132         (-[WebTextRenderer _createATSUTextLayoutForRun:]): Added comment about the cases this code does not handle that
   10133         are handled by the CG case.
   10134         (widthForNextCharacter): Call isSpace instead of checking specifically for the space character here. The old code
   10135         would not handle cases with '\n' coming across from WebCore properly.
   10136 
   10137 2004-10-18  Chris Blumenberg  <cblu (a] apple.com>
   10138 
   10139 	Fixed: <rdar://problem/3840916> GC: -[WebNetscapePluginPackage initWithPath:] leaks an NSURL
   10140 
   10141         Reviewed by kevin.
   10142 
   10143         * Plugins.subproj/WebNetscapePluginPackage.m:
   10144         (-[WebNetscapePluginPackage initWithPath:]): use executablePath on NSBundle instead of CFBundleCopyExecutableURL
   10145 
   10146 2004-10-18  Chris Blumenberg  <cblu (a] apple.com>
   10147 
   10148         * DOM.subproj/DOMPrivate.h: change to copied header that was never committed
   10149 
   10150 2004-10-18  John Sullivan  <sullivan (a] apple.com>
   10151 
   10152         Reviewed by Ken.
   10153         
   10154         - fixed <rdar://problem/3810183> Make WebHTMLView respect return value of webView:doCommandBySelector:
   10155 
   10156         * WebView.subproj/WebHTMLView.m:
   10157         (-[WebHTMLView doCommandBySelector:]):
   10158         only do default action if delegate returns NO; this works with Mail as of Tiger 8A275.
   10159 
   10160 === Safari-167 ===
   10161 
   10162 2004-10-14  Ken Kocienda  <kocienda (a] apple.com>
   10163 
   10164         Reviewed by John
   10165 
   10166         Final fix for these bugs:
   10167         
   10168         <rdar://problem/3806306> HTML editing puts spaces at start of line
   10169         <rdar://problem/3814252> HTML editing groups space with word causing wrapping
   10170 
   10171         This change sets some new CSS properties that have been added to WebCore to 
   10172         enable whitespace-handling and line-breaking features that make WebView work
   10173         more like a text editor.
   10174 
   10175         * WebView.subproj/WebHTMLRepresentation.m:
   10176         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Turn on special editing
   10177         CSS properties when loading an HTML document into a WebView that is editable.
   10178         * WebView.subproj/WebView.m:
   10179         (-[WebView setEditable:]): Add and remove special editing CSS properties in current
   10180         document being displayed.
   10181 
   10182 2004-10-14  Richard Williamson   <rjw (a] apple.com>
   10183 
   10184         Fixed <rdar://problem/3823026> making isRoundingHackCharacter use -O3 and an 8-bit lookup-table will speed "XBS" test up by 3% (actually < 1%)
   10185 
   10186         Careful testing shows a small performance gain on very large text files.  
   10187         I saw large variations in timings, but taking the lowest PLT timing 
   10188         with and without this change showed a 0.9% gain.  Note the cvs-base showed
   10189         no improvement.  The improvement was for the large page attached to the
   10190         bug.
   10191 
   10192         Reviewed by Ken.
   10193 
   10194         * WebCoreSupport.subproj/WebTextRenderer.m:
   10195         (setupRoundingHackCharacterTable):
   10196         (isRoundingHackCharacter):
   10197         (+[WebTextRenderer initialize]):
   10198 
   10199 2004-10-14  Ken Kocienda  <kocienda (a] apple.com>
   10200 
   10201         Reviewed by me
   10202 
   10203         Fix build breakage. These three functions need to return the values from their
   10204         calls to WebCGColorSpaceCreateXXX.
   10205 
   10206         * WebCoreSupport.subproj/WebGraphicsBridge.m:
   10207         (-[WebGraphicsBridge createRGBColorSpace])
   10208         (-[WebGraphicsBridge createGrayColorSpace])
   10209         (-[WebGraphicsBridge createCMYKColorSpace])
   10210 
   10211 2004-10-13  Richard Williamson   <rjw (a] apple.com>
   10212 
   10213 	Addressed concerns in <rdar://problem/3803117> RESP: High complexity in icu uidna_IDNToASCII called by [NSString(WebNSURLExtras) _web_mapHostNameWithRange:encode:makeString:]
   10214 
   10215 	In practice I saw NO improvement in performance.  Although,
   10216 	special-case tests could possibly show improvement.  Anyway,
   10217 	the changes don't hurt performance.
   10218 
   10219         Reviewed by Maciej.
   10220 
   10221         * Misc.subproj/WebNSURLExtras.m:
   10222         (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
   10223 
   10224 2004-10-13  Maciej Stachowiak  <mjs (a] apple.com>
   10225 
   10226         Reviewed by Ken.
   10227 
   10228 	<rdar://problem/3824626> Change to do colormatching for DeviceRGB colorspace causes ~11% Safari slowdown
   10229         
   10230 	- I fixed this by turning off all colormatching for WebKit
   10231 	content. We might turn it back on later. For now, it's possible to
   10232 	turn it on temporarily by defining COLORMATCH_EVERYTHING.
   10233 	
   10234 	* WebCoreSupport.subproj/WebGraphicsBridge.m:
   10235         (-[WebGraphicsBridge setFocusRingStyle:radius:color:]):
   10236         (-[WebGraphicsBridge additionalPatternPhase]):
   10237         (-[WebGraphicsBridge createRGBColorSpace]):
   10238         (-[WebGraphicsBridge createGrayColorSpace]):
   10239         (-[WebGraphicsBridge createCMYKColorSpace]):
   10240         * WebCoreSupport.subproj/WebImageData.m:
   10241         * WebCoreSupport.subproj/WebImageRenderer.h:
   10242         * WebCoreSupport.subproj/WebImageRenderer.m:
   10243         (-[WebImageRenderer _adjustSizeToPixelDimensions]):
   10244         (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]):
   10245         (-[WebImageRenderer _adjustColorSpace]):
   10246         (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):
   10247         (-[WebImageRenderer tileInRect:fromPoint:context:]):
   10248         (_createImageRef):
   10249         (WebCGColorSpaceCreateRGB):
   10250         (WebCGColorSpaceCreateGray):
   10251         (WebCGColorSpaceCreateCMYK):
   10252         * WebKitPrefix.h:
   10253 
   10254 2004-10-13  Richard Williamson   <rjw (a] apple.com>
   10255 
   10256 	Don't fill background with transparency unless debug flag
   10257 	is enabled.
   10258 
   10259         Reviewed by Hyatt.
   10260 
   10261         * WebView.subproj/WebHTMLView.m:
   10262         (-[WebHTMLView drawRect:]):
   10263 
   10264 2004-10-12  Richard Williamson   <rjw (a] apple.com>
   10265 
   10266         Fixed <rdar://problem/3829705> Need to remove filling w/ transparency when not drawing backgroundy.
   10267 
   10268         Reviewed by Ken.
   10269 
   10270         * WebView.subproj/WebHTMLView.m:
   10271         (-[WebHTMLView _transparentBackground]):
   10272         (-[WebHTMLView _setTransparentBackground:]):
   10273         (-[WebHTMLView drawRect:]):
   10274         * WebView.subproj/WebHTMLViewInternal.h:
   10275         * WebView.subproj/WebHTMLViewPrivate.h:
   10276 
   10277 2004-10-11  Chris Blumenberg  <cblu (a] apple.com>
   10278 
   10279 	Fixed: <rdar://problem/3802039> 8A259: Can't use Grab services to grab selection from screen
   10280 
   10281         Reviewed by john.
   10282 
   10283         * WebView.subproj/WebHTMLView.m:
   10284         (+[WebHTMLView initialize]): register service "return types" which are types that can be inserted into a WebView
   10285         (-[WebHTMLView writeSelectionToPasteboard:types:]): service protocol method, be sure to only write specified types
   10286         (-[WebHTMLView readSelectionFromPasteboard:]): new, service protocol method, insert types
   10287         (-[WebHTMLView validRequestorForSendType:returnType:]): moved, handle return types
   10288 
   10289 2004-10-11  Darin Adler  <darin (a] apple.com>
   10290 
   10291         Reviewed by John.
   10292 
   10293         - fixed <rdar://problem/3834130> nil-object-in-dictionary exception seen in -[WebView _elementAtWindowPoint:]
   10294 
   10295         * WebView.subproj/WebView.m: (-[WebView _elementAtWindowPoint:]): Added a check for nil frame.
   10296 
   10297 2004-10-11  Darin Adler  <darin (a] apple.com>
   10298 
   10299         Reviewed by John.
   10300 
   10301         - fixed <rdar://problem/3834166> <input type=file> sends onchange even when the same file is chosen twice
   10302 
   10303         * WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton chooseFilename:]):
   10304         Do nothing if filename is the same as before.
   10305 
   10306 2004-10-11  Ken Kocienda  <kocienda (a] apple.com>
   10307 
   10308         Reviewed by Darin
   10309 
   10310         * WebView.subproj/WebHTMLView.m:
   10311         (-[WebTextCompleteController doCompletion]): bridge call to get caret rect at a node
   10312         now takes an affinity: caretRectAtNode:offset:affinity:.
   10313 
   10314 2004-10-10  Ken Kocienda  <kocienda (a] apple.com>
   10315 
   10316         Reviewed by Chris
   10317 
   10318         Fix for this bug:
   10319         
   10320         <rdar://problem/3814236> REGRESSION (Mail): Can't set the color of text in Mail compose window using drag/drag from color panel
   10321 
   10322         * WebView.subproj/WebHTMLView.m:
   10323         (+[WebHTMLView _insertablePasteboardTypes]): Add NSColorPboardType to list.
   10324         (-[WebHTMLView _isNSColorDrag:]): New helper. Determines if drag is an NSColor drag.
   10325         (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Add a case for NSColor drags,
   10326         else do what we did before.
   10327         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Add a case for NSColor drags, which creates
   10328         a CSS style containing color info and calls the bridge to apply the style. Otherwise, do what we did before.
   10329 
   10330 2004-10-11  Darin Adler  <darin (a] apple.com>
   10331 
   10332         Reviewed by Ken.
   10333 
   10334         - fixed <rdar://problem/3833848> REGRESSION (133-134): each keydown event is getting sent multiple times
   10335 
   10336         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView performKeyEquivalent:]):
   10337         Don't send an event through WebCore if it has already been through once.
   10338 
   10339 2004-10-10  John Sullivan  <sullivan (a] apple.com>
   10340 
   10341         Reviewed by Ken.
   10342         
   10343         - fixed <rdar://problem/3777253> Crash in redirect mechanism trying to display error page for bad scheme
   10344 
   10345         * WebView.subproj/WebMainResourceClient.m:
   10346         (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]):
   10347         add retain/autorelease to the request returned from call to super. In this case, the return value
   10348         was being dealloc'ed before being returned.
   10349 
   10350 2004-10-09  Chris Blumenberg  <cblu (a] apple.com>
   10351 
   10352 	Fixed: 
   10353 	<rdar://problem/3625352> up and down arrow and page up/down keys don't work to scroll overflow:auto/scroll/overlay areas
   10354 	<rdar://problem/3397658> scroll wheel does not work to scroll overflow:auto/scroll/overlay areas (RSS)
   10355 
   10356         Reviewed by hyatt.
   10357 
   10358         * Plugins.subproj/WebBaseNetscapePluginStream.m:
   10359         (-[WebBaseNetscapePluginStream initWithRequestURL:pluginPointer:notifyData:sendNotification:]): fixed typo in comment
   10360         * Plugins.subproj/WebNetscapePluginStream.m:
   10361         (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): ditto
   10362         * WebView.subproj/WebFramePrivate.h:
   10363         * WebView.subproj/WebFrameView.m:
   10364         (-[WebFrameView _bridge]): new
   10365         (-[WebFrameView scrollToBeginningOfDocument:]): call the bridge to scroll, if that fails, scroll the document view
   10366         (-[WebFrameView scrollToEndOfDocument:]): ditto
   10367         (-[WebFrameView _pageVertically:]): ditto
   10368         (-[WebFrameView _pageHorizontally:]): ditto
   10369         (-[WebFrameView _scrollLineVertically:]): ditto
   10370         (-[WebFrameView _scrollLineHorizontally:]): ditto
   10371         * WebView.subproj/WebHTMLView.m:
   10372         (-[WebHTMLView scrollWheel:]): call the bridge to scroll, if that fails, pass to next responder
   10373 
   10374 === Safari-166 ===
   10375 
   10376 2004-10-05  Chris Blumenberg  <cblu (a] apple.com>
   10377 
   10378 	Fixed: <rdar://problem/3827002> assertion failure in WebBaseNetscapePluginStream on abc.go.com
   10379 
   10380         Reviewed by rjw.
   10381 
   10382         * Plugins.subproj/WebBaseNetscapePluginStream.m:
   10383         (-[WebBaseNetscapePluginStream initWithRequestURL:pluginPointer:notifyData:sendNotification:]): avoid assertion failure in dealloc by temporarily setting isTerminated to YES in case we are released in this method
   10384         * Plugins.subproj/WebNetscapePluginStream.m:
   10385         (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): ditto
   10386 
   10387 2004-10-05  John Sullivan  <sullivan (a] apple.com>
   10388 
   10389         * WebCoreSupport.subproj/WebBridge.m:
   10390         (-[WebBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]):
   10391         initialize "arguments" var to nil to satisfy compiler on deployment build.
   10392 
   10393 2004-10-05  Richard Williamson   <rjw (a] apple.com>
   10394 
   10395         Fixed <rdar://problem/3825442> first click lost for Dashboard
   10396 	Allow dashboard to force acceptsFirstMouse:
   10397 
   10398         Reviewed by Chris.
   10399 
   10400         * WebView.subproj/WebHTMLView.m:
   10401         (-[WebHTMLView acceptsFirstMouse:]):
   10402         * WebView.subproj/WebView.m:
   10403         (-[WebView _dashboardBehavior:]):
   10404         * WebView.subproj/WebViewInternal.h:
   10405         * WebView.subproj/WebViewPrivate.h:
   10406 
   10407         * WebCoreSupport.subproj/WebImageRenderer.h:
   10408         Comment change only
   10409 
   10410 2004-10-05  Chris Blumenberg  <cblu (a] apple.com>
   10411 
   10412 	Fixed: <rdar://problem/3760920> Need to record plugin view instances
   10413 	
   10414         Reviewed by rjw.
   10415 
   10416         * Plugins.subproj/WebPluginController.h:
   10417         * Plugins.subproj/WebPluginController.m:
   10418         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): new, creates plug-in view and adds it to global list
   10419         (+[WebPluginController isPlugInView:]): new, checks if the plug-in view is in the global list
   10420         (-[WebPluginController destroyAllPlugins]): remove the plug-in from the global list 
   10421         * Plugins.subproj/WebPluginDocumentView.m:
   10422         (-[WebPluginDocumentView setDataSource:]): call [WebPluginController plugInViewWithArguments:fromPluginPackage:]
   10423         * WebCoreSupport.subproj/WebBridge.m:
   10424         (-[WebBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): ditto
   10425         * WebView.subproj/WebFrame.m:
   10426         (-[WebFrame _reloadForPluginChanges]): call [WebPluginController isPlugInView:]
   10427         * WebView.subproj/WebHTMLView.m:
   10428         (-[WebHTMLView addSubview:]): ditto
   10429 
   10430 2004-10-05  David Hyatt  <hyatt (a] apple.com>
   10431 
   10432 	Fix to make selection more like NSTextView.  All gap painting is now done by WebCore, so WebKit no longer
   10433 	needs to try to fill gaps around text.
   10434 	
   10435         Reviewed by kocienda
   10436 
   10437         * WebCoreSupport.subproj/WebTextRenderer.m:
   10438         (-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]):
   10439         (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]):
   10440 
   10441 2004-10-05  Darin Adler  <darin (a] apple.com>
   10442 
   10443         Reviewed by John.
   10444 
   10445         - fixed <rdar://problem/3577255> custom file icon shows up upside down in <input type=file>
   10446 
   10447         * WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton setFilename:]): Added a call to
   10448         setFlipped that fixes the problem, even though I don't know why.
   10449 
   10450 2004-10-04  Darin Adler  <darin (a] apple.com>
   10451 
   10452         Reviewed by Maciej.
   10453 
   10454         - fixed <rdar://problem/3814237> REGRESSION (Mail): Copy/paste style does not set color in Mail compose window
   10455 
   10456         * WebView.subproj/WebHTMLView.m:
   10457         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Changed to call new bridge method
   10458         named fontAttributesForSelectionStart, deleted the method this used to use, and renamed
   10459         this to have the word "start" in it.
   10460         (-[WebHTMLView copyFont:]): Updated for name change.
   10461 
   10462         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
   10463 
   10464 2004-10-04  Chris Blumenberg  <cblu (a] apple.com>
   10465 
   10466         * WebView.subproj/WebFrameInternal.h: removed constant declarations that I committed by mistake
   10467 
   10468 2004-10-04  Chris Blumenberg  <cblu (a] apple.com>
   10469 
   10470 	Fixed: <rdar://problem/3798948> NPP_URLNotify is not called if plug-in calls NPN_*URLNotfy
   10471 	Fixed a number of FIXME's related to notifying plug-ins of loaded pages.
   10472 
   10473         Reviewed by rjw.
   10474 
   10475         * Plugins.subproj/WebBaseNetscapePluginStream.h: 
   10476 		- replaced URL ivar with requestURL and responseURL ivars since we need to pass both to plug-ins
   10477         	- added sendNotification boolean. Relying on notifyData not being NULL was not information to know whether to call NPP_URLNotify or not.
   10478 		- added isTerminated boolean because determining whether or not stream.ndata is NULL is not enough to know if the stream has been cancelled.
   10479 	* Plugins.subproj/WebBaseNetscapePluginStream.m:
   10480         (+[WebBaseNetscapePluginStream reasonForError:]): new, factored out from receivedError:
   10481         (-[WebBaseNetscapePluginStream initWithRequestURL:pluginPointer:notifyData:sendNotification:]): new
   10482         (-[WebBaseNetscapePluginStream dealloc]): release new ivars
   10483         (-[WebBaseNetscapePluginStream finalize]): added assert
   10484         (-[WebBaseNetscapePluginStream setRequestURL:]): new
   10485         (-[WebBaseNetscapePluginStream setResponseURL:]): new
   10486         (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): renamed, use responseURL as it basically did before
   10487         (-[WebBaseNetscapePluginStream startStreamWithResponse:]): call renamed method
   10488         (-[WebBaseNetscapePluginStream destroyStream]): 
   10489 		- do nothing if terminated
   10490 		- call NPP_StreamAsFile and NPP_DestroyStream if stream.ndata is not NULL
   10491 		- call NPP_URLNotify if sendNotification is YES regardless of value of notifyData
   10492         (-[WebBaseNetscapePluginStream receivedError:]): call reasonForError
   10493         (-[WebBaseNetscapePluginStream deliverData]): use renamed ivar
   10494         * Plugins.subproj/WebBaseNetscapePluginView.h:
   10495 		- added observingFrameLoadNotification boolean
   10496 		- renamed dictionary ivar to pendingFrameLoads which has WebFrame keys and WebPluginRequest values
   10497         * Plugins.subproj/WebBaseNetscapePluginView.m:
   10498         (-[WebBaseNetscapePluginView addFrameLoadObserver]): new
   10499         (-[WebBaseNetscapePluginView removeFrameLoadObserver]): new
   10500         (-[WebBaseNetscapePluginView stop]): call removeFrameLoadObserver
   10501         (-[WebBaseNetscapePluginView initWithFrame:]): use renamed pendingFrameLoads ivar
   10502         (-[WebBaseNetscapePluginView dealloc]): ditto
   10503         (-[WebBaseNetscapePluginView requestWithURLCString:]): set referrer on the request just as IE does
   10504         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): 
   10505 		- call NPP_URLNotify depending of value of sendNotification
   10506 		- call new init method on WebBaseNetscapePluginStream rather then setting variables individually
   10507         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]): new, calls NPP_URLNotify at the right time with the right value
   10508         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithError:]): new, delegate method called from WebFrame
   10509         (-[WebBaseNetscapePluginView loadPluginRequest:]): call addFrameLoadObserver
   10510         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): take new sendNotification parameter and pass it
   10511         (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): pass YES for sendNotification
   10512         (-[WebBaseNetscapePluginView getURL:target:]): pass NO for sendNotification
   10513         (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): take new sendNotification parameter and pass it
   10514         (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): pass YES for sendNotification
   10515         (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): pass NO for sendNotification
   10516         (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:]): take new sendNotification parameter
   10517         (-[WebPluginRequest sendNotification]): new
   10518         * Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
   10519         * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
   10520         (-[WebNetscapePluginEmbeddedView didStart]): set referrer on the request just as IE does
   10521         * Plugins.subproj/WebNetscapePluginRepresentation.m:
   10522         (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): set the request URL on the stream
   10523         * Plugins.subproj/WebNetscapePluginStream.h:
   10524         * Plugins.subproj/WebNetscapePluginStream.m:
   10525         (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): take new sendNotification parameter and pass it
   10526         (-[WebNetscapePluginStream dealloc]): use renamed ivar
   10527         (-[WebNetscapePluginStream start]): ditto
   10528         * WebView.subproj/WebFrame.m:
   10529         (-[WebFrame _setState:]): removed notification posting code. This was only used by WebBaseNetscapePluginView and it was the wrong notification to send.
   10530         (-[WebFrame _checkLoadCompleteForThisFrame]): call internal load delegate to tell it that the load has finished
   10531         (-[WebFrame _loadItem:withLoadType:]): ditto
   10532         (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): ditto
   10533         (-[WebFrame _setInternalLoadDelegate:]): new
   10534         (-[WebFrame _internalLoadDelegate]): new
   10535         * WebView.subproj/WebFrameInternal.h:
   10536         * WebView.subproj/WebFramePrivate.h:
   10537 
   10538 2004-10-04  Chris Blumenberg  <cblu (a] apple.com>
   10539 
   10540 	Fixed: <rdar://problem/3758113> REGRESSION: Macromedia ColdFusion page doesn't show main content
   10541 
   10542 	After bumping up our plug-in version, Flash now sends 2 CRLF's between the headers and body of their POST request. Our code was not prepared for this.
   10543 
   10544         Reviewed by darin.
   10545 
   10546         * Plugins.subproj/WebBaseNetscapePluginView.m:
   10547         (-[NSData _web_locationAfterFirstBlankLine]): looks for 2 CRLF's, not for 2 LF's
   10548 
   10549 2004-10-04  Darin Adler  <darin (a] apple.com>
   10550 
   10551         Reviewed by Ken.
   10552 
   10553         - fixed a potential storage leak when we turn on CGImageRef image rendering
   10554 
   10555         * WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer dealloc]): Fix potential storage leak
   10556         by adding [super dealloc], but leak was not real yet because the code is commented out.
   10557 
   10558         - make paste style work with color as part of fix to <rdar://problem/3814237> REGRESSION (Mail):
   10559           Copy/paste style does not set color in Mail compose window
   10560 
   10561         * WebView.subproj/WebHTMLView.m:
   10562         (-[WebHTMLView _selectionFontAttributes]): Change structure so it's easy to add more attributes.
   10563         For now I haven't added any yet.
   10564         (-[WebHTMLView _colorAsString:]): Moved this earlier in the file.
   10565         (-[WebHTMLView _shadowAsString:]): Ditto.
   10566         (-[WebHTMLView _styleFromFontAttributes:]): Add background color, foreground color, and text shadow.
   10567 
   10568 2004-09-30  Richard Williamson   <rjw (a] apple.com>
   10569 
   10570 	Fixed <rdar://problem/3821215> NPN hasMethod and hasProperty functions should take NPObjects, not NPClass
   10571 
   10572 	Also changed dashboard regions dictionary to use "control"
   10573 	for scroller region label, instead of "scroller, per
   10574 	request from ouch. 
   10575 		
   10576         Reviewed by Chris.
   10577 
   10578         * Plugins.subproj/npruntime.h:
   10579         * WebView.subproj/WebView.m:
   10580         (-[WebView _addScrollerDashboardRegions:from:]):
   10581 
   10582 2004-09-30  Chris Blumenberg  <cblu (a] apple.com>
   10583 
   10584 	Fixed: <rdar://problem/3498680> switching back and forth between tabs stops calling anything in a plug-in
   10585 
   10586         Reviewed by darin.
   10587 
   10588         * Plugins.subproj/WebBaseNetscapePluginView.m:
   10589         (-[WebBaseNetscapePluginView sendEvent:]): call setWindowIfNecessary because the window may have changed
   10590         (-[WebBaseNetscapePluginView updateAndSetWindow]): new
   10591         (-[WebBaseNetscapePluginView setWindowIfNecessary]): was setWindow, this method now just sets the window
   10592         (-[WebBaseNetscapePluginView start]): call updateAndSetWindow
   10593         (-[WebBaseNetscapePluginView viewDidMoveToWindow]): ditto
   10594         (-[WebBaseNetscapePluginView viewHasMoved:]): ditto
   10595 
   10596 2004-09-30  Chris Blumenberg  <cblu (a] apple.com>
   10597 
   10598 	Fixed: <rdar://problem/3498668> switching out of tab doesn't send loseFocusEvent to plug-in
   10599 
   10600         Reviewed by rjw.
   10601 
   10602         * Plugins.subproj/WebBaseNetscapePluginView.h:
   10603         * Plugins.subproj/WebBaseNetscapePluginView.m:
   10604         (-[WebBaseNetscapePluginView setHasFocus:]): new, sends events to plug-in
   10605         (-[WebBaseNetscapePluginView becomeFirstResponder]): call setHasFocus
   10606         (-[WebBaseNetscapePluginView resignFirstResponder]): ditto 
   10607         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): ditto
   10608 
   10609 2004-09-30  Chris Blumenberg  <cblu (a] apple.com>
   10610 
   10611 	Fixed:
   10612 	Assertion failure when loading standalone netscape plug-in content.
   10613 	Document loads of WebKit plug-in content should be cancelled since the plug-in does its own loading.
   10614 
   10615         Reviewed by john.
   10616 
   10617         * Misc.subproj/WebKitErrors.m: removed deprecated method
   10618         * Misc.subproj/WebKitErrorsPrivate.h:
   10619         * Plugins.subproj/WebNetscapePluginDocumentView.m:
   10620         (-[WebNetscapePluginDocumentView setDataSource:]): fixed the assertion statement
   10621         * Plugins.subproj/WebPluginDocumentView.h:
   10622         * Plugins.subproj/WebPluginDocumentView.m:
   10623         (-[WebPluginDocumentView dealloc]): remove retained plug-in
   10624         (-[WebPluginDocumentView setDataSource:]): retain the plug-in, cancel the laod
   10625 
   10626 2004-09-29  Chris Blumenberg  <cblu (a] apple.com>
   10627 	
   10628 	Fixed:
   10629 	<rdar://problem/3763832> Safari-155: Non-Embeded movies fail to open in Cocoa QT plug-in
   10630 	<rdar://problem/3820517> "*** -[WebPluginPackage NPP_New]: selector not recognized [self = 0x5552c10]"
   10631 
   10632         Reviewed by rjw.
   10633 
   10634         * History.subproj/WebHistoryItem.m:
   10635         * Misc.subproj/WebNSViewExtras.h:
   10636         * Misc.subproj/WebNSViewExtras.m:
   10637         (-[NSView _web_firstResponderCausesFocusDisplay]):
   10638         (-[NSView _webView]):
   10639         (-[NSView _frame]):
   10640         (-[NSView _bridge]):
   10641         (-[NSView _dataSource]):
   10642         * Plugins.subproj/WebBasePluginPackage.h:
   10643         * Plugins.subproj/WebBasePluginPackage.m:
   10644         (-[WebBasePluginPackage hash]):
   10645         (-[WebBasePluginPackage isQuickTimePlugIn]):
   10646         * Plugins.subproj/WebNetscapePluginDocumentView.m:
   10647         (-[WebNetscapePluginDocumentView setDataSource:]):
   10648         * Plugins.subproj/WebNetscapePluginRepresentation.m:
   10649         * Plugins.subproj/WebPluginController.h:
   10650         * Plugins.subproj/WebPluginController.m:
   10651         (-[WebPluginController initWithDocumentView:]):
   10652         (-[WebPluginController addPlugin:]):
   10653         (-[WebPluginController destroyAllPlugins]):
   10654         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
   10655         (-[WebPluginController webPlugInContainerShowStatus:]):
   10656         (-[WebPluginController webPlugInContainerSelectionColor]):
   10657         (-[WebPluginController webFrame]):
   10658         * Plugins.subproj/WebPluginDatabase.h:
   10659         * Plugins.subproj/WebPluginDatabase.m:
   10660         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
   10661         (-[WebPluginDatabase refresh]):
   10662         (WebPluginDocumentView::while):
   10663         * Plugins.subproj/WebPluginDocumentView.h: Added.
   10664         * Plugins.subproj/WebPluginDocumentView.m: Added.
   10665         (-[WebPluginDocumentView initWithFrame:]):
   10666         (-[WebPluginDocumentView dealloc]):
   10667         (-[WebPluginDocumentView drawRect:]):
   10668         (-[WebPluginDocumentView setDataSource:]):
   10669         (-[WebPluginDocumentView setNeedsLayout:]):
   10670         (-[WebPluginDocumentView layout]):
   10671         (-[WebPluginDocumentView currentWindow]):
   10672         (-[WebPluginDocumentView viewWillMoveToWindow:]):
   10673         (-[WebPluginDocumentView viewDidMoveToWindow]):
   10674         (-[WebPluginDocumentView viewWillMoveToHostWindow:]):
   10675         (-[WebPluginDocumentView viewDidMoveToHostWindow]):
   10676         (-[WebPluginDocumentView receivedData:withDataSource:]):
   10677         (-[WebPluginDocumentView receivedError:withDataSource:]):
   10678         (-[WebPluginDocumentView finishedLoadingWithDataSource:]):
   10679         (-[WebPluginDocumentView canProvideDocumentSource]):
   10680         (-[WebPluginDocumentView documentSource]):
   10681         (-[WebPluginDocumentView title]):
   10682         * Plugins.subproj/npapi.m:
   10683         (NPN_ReleaseVariantValue):
   10684         (NPN_GetStringIdentifier):
   10685         (NPN_GetStringIdentifiers):
   10686         (NPN_GetIntIdentifier):
   10687         (NPN_IdentifierIsString):
   10688         (NPN_UTF8FromIdentifier):
   10689         (NPN_IntFromIdentifier):
   10690         (NPN_CreateObject):
   10691         (NPN_RetainObject):
   10692         (NPN_ReleaseObject):
   10693         (NPN_Invoke):
   10694         (NPN_InvokeDefault):
   10695         (NPN_Evaluate):
   10696         (NPN_GetProperty):
   10697         (NPN_SetProperty):
   10698         (NPN_RemoveProperty):
   10699         (NPN_HasProperty):
   10700         (NPN_HasMethod):
   10701         (NPN_SetException):
   10702         (NPN_Call):
   10703         * WebCoreSupport.subproj/WebBridge.m:
   10704         (-[WebBridge frameRequiredForMIMEType:URL:]):
   10705         * WebCoreSupport.subproj/WebViewFactory.m:
   10706         * WebKit.exp:
   10707         * WebKit.pbproj/project.pbxproj:
   10708         * WebView.subproj/WebDebugDOMNode.m:
   10709         * WebView.subproj/WebDocumentInternal.h:
   10710         * WebView.subproj/WebHTMLView.m:
   10711         (-[WebHTMLView initWithFrame:]):
   10712         * WebView.subproj/WebHTMLViewPrivate.h:
   10713         * WebView.subproj/WebImageRepresentation.h:
   10714         * WebView.subproj/WebRenderNode.m:
   10715         * WebView.subproj/WebView.m:
   10716 
   10717 2004-09-29  Richard Williamson   <rjw (a] apple.com>
   10718 
   10719 	Fixed <rdar://problem/3779998> bringing window to front or sending to back does not send focus/blur events to JavaScript window object
   10720 
   10721 	The fix has two parts, 1) make onblur and onfocus work for windows, 
   10722         and 2), allow the dashboard to override WebKit's special key/non-key
   10723         behaviors.
   10724 
   10725         Reviewed by Maciej.
   10726 
   10727         * Plugins.subproj/WebBaseNetscapePluginView.m:
   10728         (-[WebBaseNetscapePluginView restartNullEvents]):
   10729         * WebView.subproj/WebHTMLView.m:
   10730         (-[WebHTMLView addMouseMovedObserver]):
   10731         (-[WebHTMLView removeMouseMovedObserver]):
   10732         * WebView.subproj/WebView.m:
   10733         (-[WebView _dashboardBehavior:]):
   10734         * WebView.subproj/WebViewInternal.h:
   10735         * WebView.subproj/WebViewPrivate.h:
   10736 
   10737 2004-09-29  Maciej Stachowiak  <mjs (a] apple.com>
   10738 
   10739         Reviewed by John.
   10740 
   10741 	- consolidated OS version checks into prefix header
   10742 
   10743         * Misc.subproj/WebFileDatabase.m:
   10744         (-[WebFileDatabase _createLRUList:]):
   10745         (+[WebFileDatabase _syncLoop:]):
   10746         * Misc.subproj/WebKitErrors.m:
   10747         (registerErrors):
   10748         * Misc.subproj/WebNSObjectExtras.h:
   10749         (WebNSRetainCFRelease):
   10750         * Misc.subproj/WebNSPasteboardExtras.m:
   10751         (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]):
   10752         * Misc.subproj/WebUnicode.m:
   10753         (_unicodeDirection):
   10754         * WebCoreSupport.subproj/WebImageData.h:
   10755         * WebCoreSupport.subproj/WebImageRenderer.h:
   10756         * WebCoreSupport.subproj/WebKeyGenerator.h:
   10757         * WebCoreSupport.subproj/WebNewKeyGeneration.c:
   10758         * WebKitPrefix.h:
   10759         * WebView.subproj/WebDataSource.m:
   10760         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
   10761         (-[WebDataSource isLoading]):
   10762         * WebView.subproj/WebFrameView.m:
   10763         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
   10764         * WebView.subproj/WebHTMLView.m:
   10765         * WebView.subproj/WebPDFRepresentation.h:
   10766         * WebView.subproj/WebPDFRepresentation.m:
   10767         * WebView.subproj/WebPDFView.h:
   10768         * WebView.subproj/WebPDFView.m:
   10769 
   10770 2004-09-29  Ken Kocienda  <kocienda (a] apple.com>
   10771 
   10772         Reviewed by Hyatt
   10773 
   10774         Fix for this bug:
   10775         
   10776         <rdar://problem/3818296> REGRESSION (Mail): centerSelectionInVisibleArea does not work correctly
   10777 
   10778         * WebView.subproj/WebHTMLView.m:
   10779         (-[WebHTMLView centerSelectionInVisibleArea:]): Now calls new centerSelectionInVisibleArea
   10780         bridge function instead of ensureCaretVisible. Now handles caret selections and range
   10781         selections correctly.
   10782 
   10783 2004-09-28  Chris Blumenberg  <cblu (a] apple.com>
   10784 
   10785 	Added timing code so that Doug can time RTF conversion. 
   10786 
   10787         * WebView.subproj/WebHTMLView.m:
   10788         (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]):
   10789         (-[WebHTMLView _attributeStringFromDOMRange:]):
   10790 
   10791 2004-09-28  Richard Williamson   <rjw (a] apple.com>
   10792 
   10793         <rdar://problem/3817421> add getter for dashboard regions (debugging)
   10794         
   10795         <rdar://problem/3817417> NSScrollView need autoregions for dashboard
   10796 	Also KWQScrollBars
   10797 
   10798         Reviewed by Hyatt.
   10799 
   10800         * WebCoreSupport.subproj/WebBridge.m:
   10801         (-[WebBridge dashboardRegionsChanged:]):
   10802         * WebView.subproj/WebView.m:
   10803         (-[WebView _setInitiatedDrag:]):
   10804         (-[WebView _addScrollerDashboardRegions:from:]):
   10805         (-[WebView _addScrollerDashboardRegions:]):
   10806         (-[WebView _dashboardRegions]):
   10807         * WebView.subproj/WebViewPrivate.h:
   10808 
   10809 2004-09-27  John Sullivan  <sullivan (a] apple.com>
   10810 
   10811         - fixed <rdar://problem/3814705> 8A266: Safari authentication dialog "remember password" text should match Mail
   10812 
   10813         * Panels.subproj/English.lproj/WebAuthenticationPanel.nib:
   10814         changed "Remember this password" to "Remember this password in my keychain";
   10815         this will need to go through CCC for this week's build.
   10816 
   10817 2004-09-27  Chris Blumenberg  <cblu (a] apple.com>
   10818 
   10819 	Fixed: <rdar://problem/3594754> change null event interval from 20 ms to 10 ms to match speed on Windows
   10820 
   10821         Reviewed by John.
   10822 
   10823         * Plugins.subproj/WebBaseNetscapePluginView.m:
   10824 
   10825 2004-09-27  Chris Blumenberg  <cblu (a] apple.com>
   10826 
   10827 	Fixed: <rdar://problem/3502138> text files don't remember scroll position when going back or reloading
   10828 
   10829         Reviewed by john.
   10830 
   10831         * WebView.subproj/WebTextView.m:
   10832         (-[WebTextView layout]): implemented, call sizeToFit, without this scrollPoint: won't work
   10833 
   10834 2004-09-27  John Sullivan  <sullivan (a] apple.com>
   10835 
   10836         Reviewed by Ken.
   10837 
   10838         - WebKit part of fix for <rdar://problem/3734466> ER: Support standard editing keystrokes 
   10839         like Cmd-B while editing rich text
   10840 
   10841         * WebView.subproj/WebHTMLView.m:
   10842         (-[WebHTMLView _toggleBold]):
   10843         new method, toggles font-weight from "bold" to "normal"
   10844         (-[WebHTMLView _toggleItalic]):
   10845         new method, toggles font-style from "italic" to "normal"
   10846         (-[WebHTMLView _handleStyleKeyEquivalent:]):
   10847         new method, if the new preference is set and we're in an editable state, check for standard
   10848         key equivalents for toggling styles (just command-B and command-I for now).
   10849         (-[WebHTMLView performKeyEquivalent:]):
   10850         Moved in file, now calls _handleStyleKeyEquivalent:
   10851         
   10852         * WebView.subproj/WebPreferenceKeysPrivate.h:
   10853         new preference key WebKitRespectStandardStyleKeyEquivalentsPreferenceKey
   10854         * WebView.subproj/WebPreferences.m:
   10855         (+[WebPreferences initialize]):
   10856         initial value of WebKitRespectStandardStyleKeyEquivalentsPreferenceKey is NO (maybe we'll
   10857         change our minds about this, but this is more guaranteed to be backward-compatible)
   10858         (-[WebPreferences respectStandardStyleKeyEquivalents]):
   10859         read WebKitRespectStandardStyleKeyEquivalentsPreferenceKey
   10860         (-[WebPreferences setRespectStandardStyleKeyEquivalents:]):
   10861         write WebKitRespectStandardStyleKeyEquivalentsPreferenceKey
   10862         
   10863         * WebView.subproj/WebPreferencesPrivate.h:
   10864         declare getter and setter
   10865         
   10866         * English.lproj/StringsNotToBeLocalized.txt:
   10867         updated for these and other recent changes
   10868 
   10869 2004-09-27  Chris Blumenberg  <cblu (a] apple.com>
   10870 
   10871 	Fixed: <rdar://problem/3806649> assertion failure after control-click of webcam
   10872 
   10873         Reviewed by john.
   10874 
   10875         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   10876         (-[WebDefaultUIDelegate contextMenuItemsForElement:]): don't provide "Copy Image" if the image is not fully loaded
   10877 
   10878 2004-09-27  Chris Blumenberg  <cblu (a] apple.com>
   10879 
   10880 	Fixed: <rdar://problem/3814810> REGRESSION (125-164): Exception adding nil to dictionary in dragging code
   10881 
   10882         Reviewed by john.
   10883 
   10884         * WebView.subproj/WebHTMLView.m:
   10885         (-[WebHTMLView _setMouseDownEvent:]): new
   10886         (-[WebHTMLView acceptsFirstMouse:]): call _setMouseDownEvent
   10887         (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): ditto
   10888         (-[WebHTMLView mouseDown:]): ditto
   10889         (-[WebHTMLView _delegateDragSourceActionMask]): removed temp fix, assert that the mouse event is not nil
   10890 
   10891 2004-09-27  Darin Adler  <darin (a] apple.com>
   10892 
   10893         * WebKit.pbproj/project.pbxproj: Added WebDashboardRegion.h as a private header.
   10894 
   10895 2004-09-24  Chris Blumenberg  <cblu (a] apple.com>
   10896 
   10897         Reviewed by rjw.
   10898 
   10899         * WebView.subproj/WebHTMLView.m:
   10900         (-[WebHTMLView _selectedArchive]): added timing code for copying markup
   10901 
   10902 === Safari-165 ===
   10903 
   10904 2004-09-24  Chris Blumenberg  <cblu (a] apple.com>
   10905 
   10906 	Temp fix for: <rdar://problem/3814810> REGRESSION (125-164): Exception adding nil to dictionary in dragging code
   10907 
   10908         Reviewed by john.
   10909 
   10910         * WebView.subproj/WebHTMLView.m:
   10911         (-[WebHTMLView _delegateDragSourceActionMask]): return none if the mouse down event is nil
   10912 
   10913 2004-09-24  Ken Kocienda  <kocienda (a] apple.com>
   10914 
   10915         Reviewed by John
   10916 
   10917         Fix for this bug:
   10918         
   10919         <rdar://problem/3813917> REGRESSION (125-163): The font panel will change the font of any web page
   10920         
   10921         We were doing a laughably bad job at preventing edits in documents that were not editable.
   10922         This change fixes the specific case of the bug mentioned above, and makes an attempt to
   10923         fix similar bugs by checking for whether the view is in editing mode before making edits.
   10924 
   10925         * WebView.subproj/WebHTMLView.m:
   10926         (-[WebHTMLView _canEdit]): Renamed from _canType. Used in many more places in the code now.
   10927         (-[WebHTMLView _isMoveDrag]): Change around code to make the meaning more clear. This one
   10928         was actually performing a correct check before.
   10929         (-[WebHTMLView keyDown:]): Renamed _canType to _canEdit.
   10930         (-[WebHTMLView paste:]): Don't beep if can't paste. This matches AppKit. Any paste-related beeps
   10931         will come from failure to handle key equivalent. Menu validation will kick in to dim menu.
   10932         (-[WebHTMLView _applyStyleToSelection:]): Bail if !_canEdit.
   10933         (-[WebHTMLView pasteAsPlainText:]): Ditto.
   10934         (-[WebHTMLView _alignSelectionUsingCSSValue:]): Ditto.
   10935         (-[WebHTMLView insertNewline:]): Ditto.
   10936         (-[WebHTMLView insertParagraphSeparator:]): Ditto.
   10937         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
   10938         (-[WebHTMLView _deleteWithDirection:granularity:killRing:]): Ditto.
   10939         (-[WebHTMLView complete:]): Ditto.
   10940         (-[WebHTMLView _changeSpellingToWord:]): Ditto. Some code rearranging to eliminate bridge local variable.
   10941         (-[WebHTMLView ignoreSpelling:]): Ditto.
   10942         (-[WebHTMLView yank:]): Bail if !_canEdit.
   10943         (-[WebHTMLView yankAndSelect:]): Ditto.
   10944         (-[WebHTMLView deleteToMark:]): Ditto.
   10945         (-[WebHTMLView swapWithMark:]): Ditto.
   10946         (-[WebHTMLView transpose:]): Ditto.
   10947         (-[WebHTMLView _updateFontPanel]): Ditto. Some code rearranging to eliminate bridge local variable.
   10948         (-[WebHTMLView setMarkedText:selectedRange:]): Bail if !_canEdit.
   10949         (-[WebHTMLView _insertText:selectInsertedText:]): Ditto. Some code rearranging to eliminate bridge local variable.
   10950         * WebView.subproj/WebHTMLViewPrivate.h: Renamed _canType to _canEdit.
   10951 
   10952 2004-09-24  Ken Kocienda  <kocienda (a] apple.com>
   10953 
   10954         Reviewed by me
   10955 
   10956         * WebCoreSupport.subproj/WebDashboardRegion.h: Check in file copied from WebCore.
   10957 
   10958 2004-09-23  Maciej Stachowiak  <mjs (a] apple.com>
   10959 
   10960         Reviewed by Darin.
   10961 
   10962 	<rdar://problem/3685235> REGRESSION (Mail): links are not properly editable
   10963         
   10964         * WebView.subproj/WebDefaultUIDelegate.m: By default, don't allow
   10965 	link dragging if the element under the mouse pointer is
   10966 	editable. This way, you can drag-select starting inside a link.
   10967 
   10968 2004-09-23  John Sullivan  <sullivan (a] apple.com>
   10969 
   10970         Reviewed by Chris.
   10971         
   10972         - WebKit part of fix for <rdar://problem/3415264> 
   10973         Default encoding should initially be set to current system encoding
   10974 
   10975         * WebView.subproj/WebPreferences.m:
   10976         (-[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
   10977         new SPI that sets the initial value of the default text encoding to
   10978         be the system encoding, with a special-case conversion of MacRoman->Latin1.
   10979         This is not done automatically for WebKit clients for fear of breaking them.
   10980         
   10981         * WebView.subproj/WebPreferencesPrivate.h:
   10982         declare new SPI
   10983 
   10984 2004-09-23  Darin Adler  <darin (a] apple.com>
   10985 
   10986         Reviewed by Ken.
   10987 
   10988         - fixed <rdar://problem/3811584> REGRESSION (85-125): iframe.document undefined in function called from button onclick; works from img onclick
   10989 
   10990         The fix is to not let "defers callbacks" have any effect on loading "about:blank".
   10991         I also had to fix one bug in WebCore that could then be reproduced by going to "about:blank"
   10992         while using a button.
   10993 
   10994         * WebView.subproj/WebMainResourceClient.m:
   10995         (-[WebMainResourceClient connection:didReceiveResponse:]): Loosen asserts to allow this callback
   10996         for the specific case of "about:blank" even if the defers callbacks flag is true.
   10997         (-[WebMainResourceClient connectionDidFinishLoading:]): Ditto.
   10998         (-[WebMainResourceClient loadWithRequestNow:]): Added NSURLRequest return value. Loosened asserts
   10999         as above. Changed code to return a new request if we get a new request back that is not empty
   11000         when the defers callbacks flag is true.
   11001         (-[WebMainResourceClient loadWithRequest:]): If the defers callbacks flag is set, but the
   11002         URL is one that gives us an empty document, then do the work right away, don't defer it.
   11003 
   11004 2004-09-23  Darin Adler  <darin (a] apple.com>
   11005 
   11006         - fixed B&I builds by checking in generated file
   11007 
   11008         * WebCoreSupport.subproj/WebDashboardRegion.h: Added.
   11009 
   11010 2004-09-22  Richard Williamson   <rjw (a] apple.com>
   11011 
   11012 	Pass dashboard regions to UI delegate.
   11013 
   11014         Reviewed by Hyatt.
   11015 
   11016         * WebCoreSupport.subproj/WebBridge.m:
   11017         (-[WebBridge dashboardRegionsChanged:]):
   11018         * WebView.subproj/WebUIDelegatePrivate.h:
   11019         * copy-webcore-files-to-webkit:
   11020 
   11021 2004-09-22  Chris Blumenberg  <cblu (a] apple.com>
   11022 
   11023 	Fixed build that I just broke.
   11024 
   11025         * WebView.subproj/WebHTMLView.m:
   11026         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
   11027 
   11028 2004-09-22  Chris Blumenberg  <cblu (a] apple.com>
   11029 
   11030 	<rdar://problem/3812091> REGRESSION (Mail): double-clicked word is not smart inserted on drag
   11031 
   11032         Reviewed by john.
   11033 
   11034         * WebView.subproj/WebHTMLView.m:
   11035         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): pass value for smartMove
   11036 
   11037 2004-09-22  Chris Blumenberg  <cblu (a] apple.com>
   11038 
   11039 	Fixed:
   11040 	<rdar://problem/3667301> Frequent crashes in Mail when viewing HTML messages (CFURLGetByteRangeForComponent)
   11041 	<rdar://problem/3810354> WebResourceLoadDelegate can't refuse requests by returning nil; code asserts/crashes instead
   11042 
   11043         Reviewed by rjw.
   11044 
   11045         * WebCoreSupport.subproj/WebSubresourceClient.m:
   11046         (+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): removed broken code that handled loadWithRequest returning NO
   11047         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   11048         (-[WebBaseResourceHandleDelegate loadWithRequest:]): if nil is returned from the client for willSendRequest, report the cancelled error and return
   11049 
   11050 2004-09-22  Ken Kocienda  <kocienda (a] apple.com>
   11051 
   11052         Reviewed by Darin
   11053 
   11054         * WebView.subproj/WebFrameView.m:
   11055         (-[WebFrameView _webcore_effectiveFirstResponder]): New function to yield the correct responder
   11056         to check for firstResponder-ness before calling makeFirstResonder. This helps to prevent 
   11057         unwanted firstResponder switching.
   11058         * WebView.subproj/WebView.m:
   11059         (-[WebView _webcore_effectiveFirstResponder]): Ditto.
   11060 
   11061 2004-09-21  Chris Blumenberg  <cblu (a] apple.com
   11062 
   11063 	Fixed:
   11064 	<rdar://problem/3735071> REGRESSION (Mail): WebCore Editing must do smart paste
   11065 	<rdar://problem/3799163> REGRESSION (Mail): Deleting a word doesn't delete whitespace
   11066 
   11067         Reviewed by darin.
   11068 
   11069         * WebView.subproj/WebDataSource.m:
   11070         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): pass NO for smartReplace
   11071         * WebView.subproj/WebHTMLView.m:
   11072         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): pass parameter for smartReplace using _canSmartReplaceWithPasteboard
   11073         (-[WebHTMLView _changeSpellingFromMenu:]): pass NO for smartReplace
   11074         (-[WebHTMLView pasteboardTypesForSelection]): include WebSmartPastePboardType when _canSmartCopyOrDelete return YES
   11075         (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): ditto
   11076         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): pass parameter for smartReplace using _canSmartReplaceWithPasteboard
   11077         (-[WebHTMLView delete:]): call _deleteSelection
   11078         (-[WebHTMLView cut:]): don't call delegate twice, call _deleteRange to delete
   11079         (-[WebHTMLView pasteAsPlainText:]): pass parameter for smartReplace using _canSmartReplaceWithPasteboard
   11080         (-[WebHTMLView _changeWordCaseWithSelector:]): pass NO for smartReplace
   11081         (-[WebHTMLView deleteBackward:]): call _deleteSelection when there is a selected range
   11082         (-[WebHTMLView _changeSpellingToWord:]): pass NO for smartReplace
   11083         (-[WebHTMLView deleteToMark:]): pass NO for smartDeleteOK
   11084         (-[WebHTMLView transpose:]): pass NO for smartReplace
   11085         (-[WebHTMLView _shouldDeleteRange:]): moved
   11086         (-[WebHTMLView _deleteRange:preflight:killRing:prepend:smartDeleteOK:]): moved, handle smartDelete
   11087         (-[WebHTMLView _deleteWithDirection:granularity:killRing:]): moved
   11088         (-[WebHTMLView _deleteSelection]): new
   11089 	(-[WebHTMLView _canSmartReplaceWithPasteboard]): new
   11090 	(-[WebHTMLView _canSmartCopyOrDelete]): new
   11091         (-[WebHTMLView setMarkedText:selectedRange:]): pass NO for smartReplace
   11092         (-[WebHTMLView _discardMarkedText]): call _deleteSelection
   11093         (-[WebTextCompleteController _insertMatch:]): pass NO for smartReplace
   11094         (-[WebTextCompleteController endRevertingChange:moveLeft:]): pass NO for smartReplace
   11095         * WebView.subproj/WebHTMLViewInternal.h:
   11096         * WebView.subproj/WebView.m:
   11097         (-[WebView _commonInitializationWithFrameName:groupName:]): set smartInsertDeleteEnabled to YES
   11098         (-[WebView replaceSelectionWithNode:]): pass NO for smartReplace
   11099         (-[WebView replaceSelectionWithText:]): pass NO for smartReplace
   11100         (-[WebView replaceSelectionWithMarkupString:]): pass NO for smartReplace
   11101         (-[WebView deleteSelection]): call _deleteSelection on WebHTMLView
   11102 
   11103 2004-09-21  John Sullivan  <sullivan (a] apple.com>
   11104 
   11105         Reviewed by Darin.
   11106 
   11107         - WebKit part of fix for <rdar://problem/3618274> REGRESSION (125-135): 
   11108         Option-tab doesn't always work as expected
   11109 
   11110         * WebCoreSupport.subproj/WebBridge.m:
   11111         (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]):
   11112         Don't set WebCoreKeyboardAccessFull when setting WebCoreKeyboardAccessTabsToLinks
   11113         after all; these need to be tested independently to get the option-tab behavior
   11114         correct.
   11115 
   11116 2004-09-21  John Sullivan  <sullivan (a] apple.com>
   11117 
   11118         * WebView.subproj/WebHTMLView.m:
   11119         (-[WebHTMLView doCommandBySelector:]):
   11120         Commented out part of previous change; it breaks Mail editing until Mail
   11121         fixes bug 3810158.
   11122 
   11123 2004-09-21  John Sullivan  <sullivan (a] apple.com>
   11124 
   11125         Reviewed by Ken.
   11126 
   11127         * WebView.subproj/WebHTMLView.m:
   11128         (-[WebHTMLView doCommandBySelector:]):
   11129         Fix build failure from previous checkin, d'oh! Didn't set up webview variable.
   11130 
   11131 2004-09-21  John Sullivan  <sullivan (a] apple.com>
   11132 
   11133         Reviewed by Ken.
   11134         
   11135         - fixed <rdar://problem/3809477> WebHTMLView needs to pass doCommandBySelector through delegate
   11136 
   11137         * WebView.subproj/WebHTMLView.m:
   11138         (-[WebHTMLView doCommandBySelector:]):
   11139         Call through to editing delegate. If editing delegate returns YES, don't call super.
   11140 
   11141         * WebView.subproj/WebDefaultEditingDelegate.m:
   11142         (-[WebDefaultEditingDelegate webView:doCommandBySelector:]):
   11143         default implementation (which was never called) was returning YES, but it should
   11144         return NO to signal that it didn't handle the selector.
   11145         
   11146 2004-09-21  Chris Blumenberg  <cblu (a] apple.com>
   11147 
   11148 	Fixed: <rdar://problem/3647229> Safari does not play inline Windows Media Content on some sites (miggy.net and ministryofsound.com)
   11149 
   11150         Reviewed by john.
   11151 
   11152         * Plugins.subproj/WebBaseNetscapePluginView.m:
   11153         * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
   11154         (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:]): set the plug-in before calling setting the attributes, so we can avoid passing certain attributes to the WMP plug-in that cause it to crash
   11155 
   11156 2004-09-20  Chris Blumenberg  <cblu (a] apple.com>
   11157 
   11158 	Fixed: <rdar://problem/3781290> REGRESSION (Mail): Crash in ReplaceSelectionCommandImpl attaching file to new message
   11159 
   11160         Reviewed by kocienda.
   11161 
   11162         * WebView.subproj/WebView.m:
   11163         (-[WebView setEditable:]): call updateSelectionFromEmpty on the bridge if there is no selection
   11164 
   11165 2004-09-20  Chris Blumenberg  <cblu (a] apple.com>
   11166 
   11167 	Changes to implement renamed bridge methods.
   11168 
   11169         Reviewed by darin.
   11170 
   11171         * ChangeLog:
   11172         * DOM.subproj/WebDOMOperations.m:
   11173         (-[DOMDocument URLWithAttributeString:]): call renamed bridge method
   11174         * WebCoreSupport.subproj/WebBridge.m:
   11175         (-[WebBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): take 2 parameter arrays rather than 1 which will have to be parsed
   11176         (-[WebBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): ditto
   11177 
   11178 2004-09-20  Darin Adler  <darin (a] apple.com>
   11179 
   11180         Reviewed by Chris.
   11181 
   11182         * WebView.subproj/WebFramePrivate.h: Added back.
   11183         * WebView.subproj/WebFrameViewPrivate.h: Removed.
   11184 
   11185 2004-09-20  Darin Adler  <darin (a] apple.com>
   11186 
   11187         Reviewed by Ken.
   11188 
   11189         - fixed <rdar://problem/3655360> REGRESSION (Mail): Ctrl-V emacs key binding, -pageDown: method, unimplemented (and pageUp, and selection-modifying versions)
   11190         - fixed <rdar://problem/3792138> REGRESSION (Mail): Spell checker doesn't check current selected word
   11191 
   11192         * WebView.subproj/WebFrameViewInternal.h: Moved WebFrameViewPrivate inside the WebFrameView.m file.
   11193         Removed a bunch of methods that don't need to be seen in other files, and added _verticalPageScrollDistance.
   11194         * WebView.subproj/WebFrameViewPrivate.h: Removed. Renamed to WebFrameViewInternal.h.
   11195         * WebView.subproj/WebFrameView.m:
   11196         (-[WebFrameView _verticalKeyboardScrollDistance]): Move in the file because of internal vs. private.
   11197         (-[WebFrameView _shouldDrawBorder]): Ditto.
   11198         (-[WebFrameView _tile]): Ditto.
   11199         (-[WebFrameView _verticalPageScrollDistance]): Added. Separate method so it can be called
   11200         by the code to implement pageDown:.
   11201         (-[WebFrameView _drawBorder]): Move in the file because of internal vs. private.
   11202         (-[WebFrameView _goBack]): Ditto.
   11203         (-[WebFrameView _goForward]): Ditto.
   11204         (-[WebFrameView _scrollVerticallyBy:]): Ditto.
   11205         (-[WebFrameView _scrollHorizontallyBy:]): Ditto.
   11206         (-[WebFrameView _horizontalKeyboardScrollDistance]): Ditto.
   11207         (-[WebFrameView _horizontalPageScrollDistance]): Added. Separate method for consistency with
   11208         vertical method above.
   11209         (-[WebFrameView _pageVertically:]): Moved and changed to use _verticalPageScrollDistance.
   11210         (-[WebFrameView _pageHorizontally:]): Moved and changed to use _horizontalPageScrollDistance.
   11211         (-[WebFrameView _scrollLineVertically:]): Move in the file because of internal vs. private.
   11212         (-[WebFrameView _scrollLineHorizontally:]): Ditto.
   11213         (-[WebFrameView scrollPageUp:]): Ditto.
   11214         (-[WebFrameView scrollPageDown:]): Ditto.
   11215         (-[WebFrameView scrollLineUp:]): Ditto.
   11216         (-[WebFrameView scrollLineDown:]): Ditto.
   11217         (-[WebFrameView _firstResponderIsControl]): Ditto.
   11218         (-[WebFrameView keyDown:]): Changed to eliminate _pageLeft, _lineLeft, _pageRight, and _lineRight.
   11219 
   11220         * WebView.subproj/WebDataSource.m: Use WebFrameView.h instead of WebFrameViewPrivate.h.
   11221 
   11222         * WebView.subproj/WebHTMLView.m:
   11223         (-[WebHTMLView _alterCurrentSelection:verticalDistance:]): Added.
   11224         (-[WebHTMLView moveToBeginningOfDocument:]): Use WebSelectToDocumentBoundary.
   11225         (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): Ditto.
   11226         (-[WebHTMLView moveToEndOfDocument:]): Ditto.
   11227         (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): Ditto.
   11228         (-[WebHTMLView moveParagraphBackwardAndModifySelection:]): Added.
   11229         (-[WebHTMLView moveParagraphForwardAndModifySelection:]): Added.
   11230         (-[WebHTMLView pageUp:]): Added.
   11231         (-[WebHTMLView pageDown:]): Added.
   11232         (-[WebHTMLView pageUpAndModifySelection:]): Added.
   11233         (-[WebHTMLView pageDownAndModifySelection:]): Added.
   11234         (-[WebHTMLView showGuessPanel:]): Changed to call advanceToNextMisspellingStartingJustBeforeSelection.
   11235         This fixes the problem with spell checking.
   11236 
   11237         * WebView.subproj/WebImageView.m:
   11238         (-[WebImageView webView]): Changed to use _web_parentWebView.
   11239         (-[WebImageView menuForEvent:]): Changed to use [self webView].
   11240         (-[WebImageView mouseDown:]): Ditto.
   11241         (-[WebImageView mouseDragged:]): Ditto.
   11242         (-[WebImageView draggedImage:endedAt:operation:]): Ditto.
   11243 
   11244         * WebView.subproj/WebTextView.m:
   11245         (-[WebTextView _textSizeMultiplierFromWebView]): Changed to use _web_parentWebView.
   11246         (-[WebTextView menuForEvent:]): Ditto.
   11247         (-[WebTextView drawPageBorderWithSize:]): Ditto.
   11248         (-[WebTextView knowsPageRange:]): Ditto.
   11249 
   11250         * Plugins.subproj/WebPluginDatabase.m: Updated filename of WebFrameViewInternal.h.
   11251         * WebCoreSupport.subproj/WebBridge.m: Ditto.
   11252         * WebKit.pbproj/project.pbxproj: Ditto.
   11253         * WebView.subproj/WebFrame.m: Ditto.
   11254         * WebView.subproj/WebView.m: Ditto.
   11255         * Misc.subproj/WebNSViewExtras.m: Ditto.
   11256 
   11257 2004-09-20  Darin Adler  <darin (a] apple.com>
   11258 
   11259         Reviewed by Ken.
   11260 
   11261         - added helper method _web_parentWebView so fewer files need to get at WebFrame private methods
   11262 
   11263         * Misc.subproj/WebNSViewExtras.h: Added _web_parentWebView.
   11264         * Misc.subproj/WebNSViewExtras.m: (-[NSView _web_parentWebView]): Added.
   11265 
   11266 === Safari-164 ===
   11267 
   11268 2004-09-17  Chris Blumenberg  <cblu (a] apple.com>
   11269 	
   11270     	Fixed:
   11271 	<rdar://problem/3805757> don't unnecessarily put RTFD on the pasteboard
   11272 	<rdar://problem/3805756> strip attachments before generating RTF
   11273 
   11274         Reviewed by john.
   11275 
   11276         * WebView.subproj/WebHTMLView.m:
   11277         (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): only put RTFD on the pasteboard if it has attachments, strip attachments when writing RTF
   11278 
   11279 2004-09-16  Darin Adler  <darin (a] apple.com>
   11280 
   11281         Reviewed by John.
   11282 
   11283         - fixed <rdar://problem/3804648> 8A262: Safari crashed in -[WebView(WebPrivate) _editingDelegateForwarder] inside QuickTime Cocoa Plug-in during WebView deallocation
   11284 
   11285         * WebView.subproj/WebView.m: (-[WebView _editingDelegateForwarder]):
   11286         Check _private for nil before dereferencing it.
   11287 
   11288 2004-09-16  Chris Blumenberg  <cblu (a] apple.com>
   11289 
   11290 	Fixed: <rdar://problem/3779150> REGRESSION: images not copied when copying HTML in Safari and pasting into TextEdit
   11291 
   11292         Reviewed by john.
   11293 
   11294         * WebView.subproj/WebHTMLView.m:
   11295         (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): use RTFDFromRange:: for RTFD
   11296         * WebView.subproj/WebHTMLViewPrivate.h:
   11297 
   11298 2004-09-15  Darin Adler  <darin (a] apple.com>
   11299 
   11300         Reviewed by John.
   11301 
   11302         - fixed assertion I saw using the font panel
   11303 
   11304         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _colorAsString:]):
   11305         Convert color space before trying to get R, G, and B components.
   11306 
   11307 2004-09-15  Chris Blumenberg  <cblu (a] apple.com>
   11308 
   11309 	Fixed: <rdar://problem/3802232> REGRESSION (Mail): WebCore Editing must do smart copy
   11310 	
   11311         Reviewed by kocienda.
   11312 
   11313         * WebView.subproj/WebHTMLView.m:
   11314         (-[WebHTMLView _writeSelectionToPasteboard:]): call instance method not class method to get pasteboard types since the types depends on the current selection granularity
   11315         (-[WebHTMLView pasteboardTypesForSelection]): if the selection granularity is "word" include the smart pasteboard type
   11316         (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): put nil on the pasteboard for smart copy
   11317 
   11318 2004-09-14  Darin Adler  <darin (a] apple.com>
   11319 
   11320         Reviewed by Maciej.
   11321 
   11322         - fixed <rdar://problem/3788894> REGRESSION (Mail): ctrl-t emacs key binding does not work (transpose)
   11323         - fixed <rdar://problem/3798946> REGRESSION (Mail): Cursor does not disappear when typing
   11324 
   11325         * WebView.subproj/WebHTMLView.m:
   11326         (-[WebHTMLView keyDown:]): Hide cursor by calling setHiddenUntilMouseMoves:YES.
   11327         (-[WebHTMLView transpose:]): Added.
   11328 
   11329 2004-09-14  Richard Williamson   <rjw (a] apple.com>
   11330 
   11331         1.  Add class parameter to object allocation function.  This is somewhat redundant, given that
   11332         the allocation function is in the class function vector, but people wanted to use the same
   11333         allocation function for different classes.
   11334         
   11335         2.  Renamed NPN_Class to NPN_Invoke to match the name in the function vector.
   11336         
   11337         3.  Add support for a default function on an object.  This is a feature that ActiveX supports,
   11338         and will allow JavaScript code to be written that will look exactly the same for both ActiveX
   11339         plugins and Netscape or WebKit plugins.  There are implementations included for the 'C' and
   11340         'Objective-C' bindings.
   11341         
   11342         There bugs are covered by
   11343         
   11344         <rdar://problem/3776343> Support for default functions in the JavaScript bindings
   11345         <rdar://problem/3779186> NPN_Call needs to be renamed to NPN_Invoke
   11346         <rdar://problem/3674754> Need to implement latest npruntime.h
   11347 
   11348         Reviewed by John.
   11349 
   11350         * Plugins.subproj/WebNetscapePluginPackage.m:
   11351         (-[WebNetscapePluginPackage load]):
   11352         * Plugins.subproj/WebScriptObject.h:
   11353         * Plugins.subproj/npfunctions.h:
   11354         * Plugins.subproj/npruntime.h:
   11355 
   11356 2004-09-13  Richard Williamson   <rjw (a] apple.com>
   11357 
   11358         D'oh.  How many times can I screw up a simple fix!
   11359 
   11360         * WebCoreSupport.subproj/WebTextRenderer.m:
   11361         (-[WebTextRenderer initWithFont:usingPrinterFont:]):
   11362 
   11363 2004-09-13  Richard Williamson   <rjw (a] apple.com>
   11364 
   11365         Fixed snafu from 3782533 checkin.
   11366         
   11367         Reviewed by John.
   11368 
   11369         * WebCoreSupport.subproj/WebTextRenderer.m:
   11370         (-[WebTextRenderer initWithFont:usingPrinterFont:]):
   11371 
   11372 2004-09-12  Chris Blumenberg  <cblu (a] apple.com>
   11373 
   11374 	Support for: <rdar://problem/3794790> drop rate or time remaining from download status when window is too small to fit it
   11375 
   11376         Reviewed by john.
   11377 
   11378         * Misc.subproj/WebStringTruncator.h:
   11379         * Misc.subproj/WebStringTruncator.m:
   11380         (+[WebStringTruncator widthOfString:font:]): new
   11381 
   11382 2004-09-10  Richard Williamson   <rjw (a] apple.com>
   11383 
   11384         Fixed <rdar://problem/3782533> CrashTracer: .1459 crashes at com.apple.WebKit: -[WebTextRenderer initWithFont:usingPrinterFont:] + 0x138
   11385 
   11386         We were explicitly failing when we encountered deprecated fonts.
   11387         (Those with unsupported glyph packings).
   11388         Deprecated fonts should only appear on a system that have 
   11389         stuff migrated from OS 9.  Ugh, thats probably why we've never seen
   11390         the problem here.
   11391         
   11392         Reviewed by John.
   11393 
   11394         * WebCoreSupport.subproj/WebTextRenderer.m:
   11395         (-[WebTextRenderer initWithFont:usingPrinterFont:]):
   11396 
   11397 2004-09-10  John Sullivan  <sullivan (a] apple.com>
   11398 
   11399         Reviewed by Chris.
   11400         
   11401         - added _isFrameSet as a private method, so it can be used in WebBrowser.
   11402         This is needed to merge the fix for 3123987 to SUPanNavy.
   11403 
   11404         * WebView.subproj/WebFrame.m:
   11405         (-[WebFrame _isFrameSet]):
   11406         new method
   11407         
   11408         * WebView.subproj/WebFramePrivate.h:
   11409         declare new method
   11410 
   11411 2004-09-09  Chris Blumenberg  <cblu (a] apple.com>
   11412 
   11413 	Support for: <rdar://problem/3795485> debug menu item to enable RSS animation on first layout
   11414 
   11415         Reviewed by rjw.
   11416 
   11417         * WebCoreSupport.subproj/WebBridge.m:
   11418         (-[WebBridge didFirstLayout]): new
   11419         * WebView.subproj/WebDefaultFrameLoadDelegate.m:
   11420         (-[WebDefaultFrameLoadDelegate webView:didFirstLayoutInFrame:]): new
   11421         * WebView.subproj/WebViewPrivate.h:
   11422 
   11423 2004-09-09  Richard Williamson   <rjw (a] apple.com>
   11424 
   11425         Alternate implementation of image rendering.  Use CGImageRefs instead
   11426         of NSImages.
   11427         
   11428         Mostly works, but currently disabled because of issues w/ CG.
   11429         
   11430         Reviewed by Chris.
   11431 
   11432         * ChangeLog:
   11433         * WebCoreSupport.subproj/WebImageData.h: Added.
   11434         * WebCoreSupport.subproj/WebImageData.m: Added.
   11435         (-[WebImageData _commonTermination]):
   11436         (-[WebImageData dealloc]):
   11437         (-[WebImageData finalize]):
   11438         (-[WebImageData copyWithZone:]):
   11439         (-[WebImageData numberOfImages]):
   11440         (-[WebImageData currentFrame]):
   11441         (-[WebImageData _invalidateImages]):
   11442         (-[WebImageData imageAtIndex:]):
   11443         (-[WebImageData incrementalLoadWithBytes:length:complete:]):
   11444         (drawPattern):
   11445         (-[WebImageData tileInRect:fromPoint:context:]):
   11446         (-[WebImageData isNull]):
   11447         (-[WebImageData size]):
   11448         (-[WebImageData _frameDuration]):
   11449         (-[WebImageData _repetitionCount]):
   11450         (-[WebImageData isAnimationFinished]):
   11451         (+[WebImageData stopAnimationsInView:]):
   11452         (-[WebImageData addAnimatingRenderer:inView:]):
   11453         (-[WebImageData removeAnimatingRenderer:]):
   11454         (-[WebImageData _stopAnimation]):
   11455         (-[WebImageData _nextFrame:]):
   11456         (-[WebImageData animate]):
   11457         * WebCoreSupport.subproj/WebImageRenderer.h:
   11458         * WebCoreSupport.subproj/WebImageRenderer.m:
   11459         (-[WebImageRenderer initWithMIMEType:]):
   11460         (-[WebImageRenderer initWithData:MIMEType:]):
   11461         (-[WebImageRenderer initWithContentsOfFile:]):
   11462         (-[WebImageRenderer dealloc]):
   11463         (-[WebImageRenderer copyWithZone:]):
   11464         (-[WebImageRenderer retainOrCopyIfNeeded]):
   11465         (-[WebImageRenderer resize:]):
   11466         (-[WebImageRenderer size]):
   11467         (-[WebImageRenderer MIMEType]):
   11468         (-[WebImageRenderer frameCount]):
   11469         (-[WebImageRenderer isNull]):
   11470         (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]):
   11471         (-[WebImageRenderer drawImageInRect:fromRect:]):
   11472         (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
   11473         (-[WebImageRenderer tileInRect:fromPoint:context:]):
   11474         (-[WebImageRenderer _startOrContinueAnimationIfNecessary]):
   11475         (+[WebImageRenderer stopAnimationsInView:]):
   11476         (-[WebImageRenderer stopAnimation]):
   11477         (-[WebImageRenderer targetAnimationRect]):
   11478         (-[WebImageRenderer increaseUseCount]):
   11479         (-[WebImageRenderer decreaseUseCount]):
   11480         (-[WebImageRenderer flushRasterCache]):
   11481         (-[WebImageRenderer imageRef]):
   11482         (-[WebImageRenderer TIFFRepresentation]):
   11483         (-[WebImageRenderer image]):
   11484         * WebCoreSupport.subproj/WebImageRendererFactory.m:
   11485         (-[WebImageRendererFactory imageRendererWithMIMEType:]):
   11486         (-[WebImageRendererFactory imageRendererWithData:MIMEType:]):
   11487         (-[WebImageRendererFactory imageRendererWithSize:]):
   11488         (-[WebImageRendererFactory imageRendererWithName:]):
   11489         * WebKit.pbproj/project.pbxproj:
   11490         * WebView.subproj/WebImageView.m:
   11491         (-[WebImageView image]):
   11492 
   11493 === Safari-163 ===
   11494 
   11495 2004-09-09  Maciej Stachowiak  <mjs (a] apple.com>
   11496 
   11497         - rolled out last two changes, they seem to cause a performance regression
   11498 
   11499         * WebView.subproj/WebHTMLView.m:
   11500         (-[WebHTMLView firstRectForCharacterRange:]):
   11501 
   11502 2004-09-09  Maciej Stachowiak  <mjs (a] apple.com>
   11503 
   11504         - fixed build
   11505 
   11506         * WebView.subproj/WebHTMLView.m:
   11507         (-[WebHTMLView firstRectForCharacterRange:]):
   11508 
   11509 2004-09-08  Maciej Stachowiak  <mjs (a] apple.com>
   11510 
   11511         Reviewed by Dave.
   11512 
   11513 	WebKit part of fix for:
   11514 	
   11515 	<rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:
   11516 
   11517         * WebView.subproj/WebHTMLView.m:
   11518         (-[WebHTMLView firstRectForCharacterRange:]): Call the appropriate new bridge method,
   11519 	and translate to screen coordinates.
   11520 
   11521 2004-09-09  Darin Adler  <darin (a] apple.com>
   11522 
   11523         Reviewed by Ken.
   11524 
   11525         - fixed <rdar://problem/3790526> mark-related methods not implemented (needed for people with them in their key bindings files)
   11526 
   11527         * WebKit.pbproj/project.pbxproj: Update MACOSX_DEPLOYMENT_TARGET to 10.3 and add -fobjc-exceptions
   11528         so we can use new exceptions.
   11529 
   11530         * WebView.subproj/WebHTMLView.m:
   11531         (-[WebHTMLView setMark:]): Added.
   11532         (unionDOMRanges): Added.
   11533         (-[WebHTMLView deleteToMark:]): Added.
   11534         (-[WebHTMLView selectToMark:]): Added.
   11535         (-[WebHTMLView swapWithMark:]): Added.
   11536         (-[WebHTMLView markedRange]): Updated for change to bridge method names.
   11537         (-[WebHTMLView hasMarkedText]): Ditto.
   11538         (-[WebHTMLView unmarkText]): Ditto.
   11539         (-[WebHTMLView _selectMarkedText]): Ditto.
   11540         (-[WebHTMLView _selectRangeInMarkedText:]): Ditto.
   11541         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
   11542         (-[WebHTMLView _insertText:selectInsertedText:]): Removed check for empty string. An empty string
   11543         should not be filtered out here. We need to allow inserting an empty string.
   11544         (-[WebHTMLView _selectionIsInsideMarkedText]): Updated for change to bridge method names.
   11545         (-[WebHTMLView _updateSelectionForInputManager]): Ditto.
   11546 
   11547         * WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]):
   11548         Changed to use selectionDOMRange instead of selectionStart.
   11549 
   11550         * WebView.subproj/WebHTMLRepresentation.h: Removed unused setSelectionFrom method.
   11551         * WebView.subproj/WebHTMLRepresentation.m: Ditto.
   11552 
   11553 2004-09-08  John Sullivan  <sullivan (a] apple.com>
   11554 
   11555         Reviewed by Darin.
   11556         
   11557         - fixed the localization aspect of: 
   11558         <rdar://problem/3790011> undoable operations all say "Undo" in the menu, no specific action names
   11559         
   11560         We now have all the strings ready for localization; we just don't actually use them yet.
   11561 
   11562         * English.lproj/Localizable.strings:
   11563         updated for this change
   11564         
   11565         * WebCoreSupport.subproj/WebBridge.m:
   11566         (-[WebBridge setUndoActionNamePlaceholder]):
   11567         added this placeholder method whose purpose is to hold localizable strings for all the Undo
   11568         action names that NSTextView uses. Later we will use some or all of these, but we can do
   11569         that part after the localization freeze.
   11570 
   11571 2004-09-08  Chris Blumenberg  <cblu (a] apple.com>
   11572 
   11573 	Fixed: <rdar://problem/3778785> REGRESSION (Mail): copying from MS word and pasting into editable region leaves internal clipboard data
   11574 
   11575         Reviewed by kocienda.
   11576 
   11577         * WebView.subproj/WebHTMLView.m:
   11578         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): ignore Microsoft's header meta data
   11579 
   11580 2004-09-08  Chris Blumenberg  <cblu (a] apple.com>
   11581 
   11582 	Fixed: <rdar://problem/3792893> WebBaseResourceHandleDelegate always returns cached data for subresource loads
   11583 
   11584         Reviewed by rjw.
   11585 
   11586         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   11587         (-[WebBaseResourceHandleDelegate _canUseResourceForRequest:]): new
   11588         (-[WebBaseResourceHandleDelegate loadWithRequest:]): call _canUseResourceForRequest:
   11589 
   11590 2004-09-08  Chris Blumenberg  <cblu (a] apple.com>
   11591 
   11592 	Forgot to add this in previous check-in.	
   11593 
   11594         * English.lproj/WebViewEditingContextMenu.nib: Added.
   11595 
   11596 2004-09-08  Chris Blumenberg  <cblu (a] apple.com>
   11597 
   11598 	Fixed: <rdar://problem/3791240> WebKit uses the NSTextViewContextMenu nib from inside AppKit
   11599 
   11600         Reviewed by john.
   11601 
   11602         * English.lproj/StringsNotToBeLocalized.txt:
   11603         * WebKit.pbproj/project.pbxproj:
   11604         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   11605         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:]): use our copy of the nib
   11606 
   11607 2004-09-07  Darin Adler  <darin (a] apple.com>
   11608 
   11609         * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
   11610 
   11611 2004-09-07  Chris Blumenberg  <cblu (a] apple.com>
   11612 
   11613 	Fixed: <rdar://problem/3790143> exception raised when dragging a URL with 2-byte characters
   11614 
   11615 	(checked in with last check-in)
   11616 
   11617 2004-09-07  Chris Blumenberg  <cblu (a] apple.com>
   11618 
   11619 	Fixed:
   11620 	<rdar://problem/3080103> Need to pass cmd-modified keys to plug-ins
   11621 	<rdar://problem/3751509> can't use safari edit menu to copy and paste with Vantage Learning's My Access
   11622 
   11623         Reviewed by john.
   11624 
   11625         * Plugins.subproj/WebBaseNetscapePluginView.m: fake up command-key events for cut, copy, paste and select all so these menu items work for plug-ins
   11626         (-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
   11627         (-[WebBaseNetscapePluginView cut:]):
   11628         (-[WebBaseNetscapePluginView copy:]):
   11629         (-[WebBaseNetscapePluginView paste:]):
   11630         (-[WebBaseNetscapePluginView selectAll:]):
   11631 
   11632 2004-09-07  Darin Adler  <darin (a] apple.com>
   11633 
   11634         - fixed deployment build
   11635 
   11636         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteWithDirection:granularity:killRing:]):
   11637         Initialize prepend variable.
   11638 
   11639 2004-09-06  Darin Adler  <darin (a] apple.com>
   11640 
   11641         Reviewed by John.
   11642 
   11643         - fixed <rdar://problem/3696542> REGRESSION (Mail): Editable WebKit doesn't support underline yet (in the iChat profile window, at least)
   11644         - fixed <rdar://problem/3780249> REGRESSION (Mail): copy style/paste style doesn't work in HTML editing in Mail
   11645         - fixed <rdar://problem/3788857> REGRESSION (Mail): Home and End keys don't work in message composer
   11646         - fixed <rdar://problem/3788884> REGRESSION (Mail): ctrl-d emacs key binding does not work (delete forward)
   11647         - fixed <rdar://problem/3788890> REGRESSION (Mail): ctrl-k emacs key binding does not work (delete to end of paragraph)
   11648         - fixed <rdar://problem/3788899> REGRESSION (Mail): ctrl-y emacs key binding does not work (yank)
   11649         - fixed <rdar://problem/3788901> REGRESSION (Mail): ctrl-o emacs key binding does not work (insert newline in front of insertion point)
   11650         - fixed <rdar://problem/3788908> REGRESSION (Mail): ctrl-left-arrow emacs key binding does not work (move to beginning of line)
   11651         - fixed <rdar://problem/3788913> REGRESSION (Mail): ctrl-right-arrow emacs key binding does not work (move to end of line)
   11652         - implemented a first cut at other attribute changes from Text Panel besides underline (bugs?)
   11653         - dealt with a couple of FIXMEs in WebHTMLView.m
   11654         - updated list of not-yet-implemented methods in WebHTMLView.m
   11655         - fixed many deletion operations to call the correct editing delegate methods
   11656 
   11657         * WebView.subproj/WebFrameViewPrivate.h: Remove _scrollToTopLeft and _scrollToBottomLeft.
   11658         No one was calling them anyway, so they should really have been marked internal and not private.
   11659         * WebView.subproj/WebFrameView.m:
   11660         (-[WebFrameView scrollToBeginningOfDocument:]): Renamed _scrollToTopLeft to this, so the home key
   11661         would start working with the key bindings machinery.
   11662         (-[WebFrameView scrollToEndOfDocument:]): Same thing, for end key.
   11663         (-[WebFrameView keyDown:]): Update for name changes, and also make sure we don't try to grab
   11664         control-arrow keys here (probably not necessary, but good anyway).
   11665 
   11666         * WebView.subproj/WebHTMLViewInternal.h: Added keyDownEvent field, and startNewKillRingSequence
   11667         and nextResponderDisabledOnce flags.
   11668         * WebView.subproj/WebHTMLView.m:
   11669         Rearrange declarations at the top of the file so that external things are up with
   11670         the #import directives and things inside this file are declared below.
   11671         (-[WebHTMLView _shouldReplaceSelectionWithText:givenAction:]): Ditto.
   11672         (-[WebHTMLView _calculatePrintHeight]): Moved up into the "internal to file" category.
   11673         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
   11674         (-[WebHTMLView _selectedRange]): Added.
   11675         (-[WebHTMLView _openLinkFromMenu:]): Left this method lying around even though I deleted the
   11676         other APPKIT_CODE_FOR_REFERENCE in case this shows up in the context menu we are now sharing
   11677         with the AppKit. Chris will look at this later, and he can delete it then.
   11678         (+[WebHTMLView initialize]): Call _NSInitializeKillRing.
   11679         (-[WebHTMLView _documentRange]): Added.
   11680         (-[WebHTMLView string]): Call the bridge to get the plain text rather than making an attributed
   11681         string and then getting the text from there.
   11682         (-[WebHTMLView becomeFirstResponder]): Set startNewKillRingSequence flag, so that new deletions
   11683         will create a new kill ring entry.
   11684         (-[WebHTMLView moveToBeginningOfDocument:]): Use backward direction instead of left direction.
   11685         (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): Ditto.
   11686         (-[WebHTMLView moveToBeginningOfLine:]): Ditto.
   11687         (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]): Ditto.
   11688         (-[WebHTMLView moveToBeginningOfParagraph:]): Ditto, also use WebSelectToParagraphBoundary.
   11689         (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]): Ditto.
   11690         (-[WebHTMLView moveToEndOfDocument:]): Use forward direction instead of right direction.
   11691         (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): Ditto.
   11692         (-[WebHTMLView moveToEndOfLine:]): Ditto.
   11693         (-[WebHTMLView moveToEndOfLineAndModifySelection:]): Ditto.
   11694         (-[WebHTMLView moveToEndOfParagraph:]): Ditto, also use WebSelectToParagraphBoundary.
   11695         (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]): Ditto.
   11696         (-[WebHTMLView _shouldDeleteRange:]): Added.
   11697         (-[WebHTMLView _deleteRange:preflight:killRing:prepend:]): Added.
   11698         (-[WebHTMLView delete:]): Changed to call new _deleteRange method.
   11699         (-[WebHTMLView cut:]): Changed to preflight property and call new _deleteRange method.
   11700         (-[WebHTMLView _selectionFontAttributes]): Added.
   11701         (-[WebHTMLView _selectionFontAttributesAsRTF]): Added.
   11702         (-[WebHTMLView _fontAttributesFromFontPasteboard]): Added.
   11703         (-[WebHTMLView _emptyStyle]): Added.
   11704         (-[WebHTMLView _styleFromFontAttributes:]): Added.
   11705         (-[WebHTMLView _applyStyleToSelection:]): Added.
   11706         (-[WebHTMLView copyFont:]): Implemented.
   11707         (-[WebHTMLView pasteFont:]): Implemented.
   11708         (-[WebHTMLView _originalFontA]): Added.
   11709         (-[WebHTMLView _originalFontB]): Added.
   11710         (-[WebHTMLView _addToStyle:fontA:fontB:]): Added. Has code from the method that figures out
   11711         what the font manager is doing for changeFont:, now needed for changeAttribute: too.
   11712         (-[WebHTMLView _styleFromFontManagerOperation]): Renamed and now calls shared methods.
   11713         (-[WebHTMLView changeFont:]): Call shared method, still does the same thing.
   11714         (-[WebHTMLView _colorAsString:]): Added. Has code from the method we were using with the
   11715         color panel before.
   11716         (-[WebHTMLView _shadowAsString:]): Added.
   11717         (-[WebHTMLView _styleForAttributeChange:]): Added.
   11718         (-[WebHTMLView changeAttributes:]): Implemented.
   11719         (-[WebHTMLView _styleFromColorPanelWithSelector:]): Renamed and now calls shared methods.
   11720         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): Call method by new name.
   11721         (-[WebHTMLView changeDocumentBackgroundColor:]): Call method by new name.
   11722         (-[WebHTMLView changeColor:]): Changed around a bit; still doesn't work yet.
   11723         (-[WebHTMLView _alignSelectionUsingCSSValue:]): Call shared methods.
   11724         (-[WebHTMLView indent:]): Removed, since NSTextView doesn't implement this method. Added to list
   11725         of methods to possibly implement later in the file.
   11726         (-[WebHTMLView insertTab:]): Call insertText: to save code and so we get WebViewInsertActionTyped
   11727         instead of WebViewInsertActionPasted.
   11728         (-[WebHTMLView changeCaseOfLetter:]): Removed, since NSTextView doesn't implement this method.
   11729         Added to list of methods to possibly implement later in the file.
   11730         (-[WebHTMLView _deleteWithDirection:granularity:killRing:]): Added.
   11731         (-[WebHTMLView deleteForward:]): Implemented. This makes Control-D work.
   11732         (-[WebHTMLView deleteBackwardByDecomposingPreviousCharacter:]): Implemented by just calling
   11733         deleteBackward for now; probably better than doing nothing.
   11734         (-[WebHTMLView deleteWordForward:]): Changed to call new _delete method above. Fixes things
   11735         so that we delete the selection if there is one, get the appropriate delegate calls, handle
   11736         the kill ring properly, and don't do any selection if we can't delete.
   11737         (-[WebHTMLView deleteWordBackward:]): Ditto.
   11738         (-[WebHTMLView deleteToBeginningOfLine:]): Ditto.
   11739         (-[WebHTMLView deleteToEndOfLine:]): Ditto.
   11740         (-[WebHTMLView deleteToBeginningOfParagraph:]): Ditto.
   11741         (-[WebHTMLView deleteToEndOfParagraph:]): Ditto. Added additional behavior needed since this
   11742         is bound to Control-K, so it's not really just delete to end of paragraph.
   11743         (-[WebHTMLView insertNewlineIgnoringFieldEditor:]): Added. Calls insertNewline:.
   11744         (-[WebHTMLView insertTabIgnoringFieldEditor:]): Added. Calls insertTab:.
   11745         (-[WebHTMLView subscript:]): Added.
   11746         (-[WebHTMLView superscript:]): Added.
   11747         (-[WebHTMLView unscript:]): Added.
   11748         (-[WebHTMLView underline:]): Added.
   11749         (-[WebHTMLView yank:]): Added.
   11750         (-[WebHTMLView yankAndSelect:]): Added. Calls _insertText.
   11751         (-[WebHTMLView _arrowKeyDownEventSelectorIfPreprocessing:]): Added. Part of workaround for
   11752         control-arrow key trouble.
   11753         (-[WebHTMLView respondsToSelector:]): Added. More of workaround.
   11754         (-[WebHTMLView nextResponder:]): Added. More of workaround.
   11755         (-[WebHTMLView _selectionChanged]): Set startNewKillRingSequence flag, so that new deletions
   11756         will create a new kill ring entry.
   11757         (-[WebHTMLView _updateFontPanel]): Remove a bunch of code here that wasn't working very well
   11758         because it walked a DOM range incorrectly, and instead use the new method that does all the
   11759         right stuff on the other side of the bridge.
   11760         (-[WebHTMLView _insertText:selectInsertedText:]): Added new helper method for use by both
   11761         insertText and yankAndSelect, with most of the guts of insertText and one additional parameter.
   11762         (-[WebHTMLView insertText:]): Call the new _insertText.
   11763 
   11764         * WebView.subproj/WebView.m: Use macros to make the forwarding from WebView more terse.
   11765         Updated the list to include a few methods it didn't before.
   11766 
   11767 2004-09-06  John Sullivan  <sullivan (a] apple.com>
   11768 
   11769         Reviewed by Darin.
   11770         
   11771         - put preference keys in a private header file so Safari can use them for Managed Preferences
   11772 
   11773         * WebView.subproj/WebPreferenceKeysPrivate.h:
   11774         new Private header file, includes the #defines for NSUserDefaults preference keys
   11775         
   11776         * WebView.subproj/WebPreferences.m:
   11777         moved the preference key #defines out of here; now imports WebPreferenceKeysPrivate.h
   11778 
   11779         * WebKit.pbproj/project.pbxproj:
   11780         updated for new file
   11781 
   11782 2004-09-03  Chris Blumenberg  <cblu (a] apple.com>
   11783 
   11784 	Fixed: <rdar://problem/3782543> CrashTracer: ...87 crashes at com.apple.WebKit: -[WebNetscapePluginPackage initWithPath:] + 0x18c
   11785 
   11786         Reviewed by john.
   11787 
   11788         * Plugins.subproj/WebNetscapePluginPackage.m:
   11789         (-[WebNetscapePluginPackage initWithPath:]): make sure the file is at least 8 bytes long before calling memcmp
   11790 
   11791 2004-09-03  Chris Blumenberg  <cblu (a] apple.com>
   11792 	
   11793 	Fixed:
   11794 	<rdar://problem/3788328> assertion failure when moving an image
   11795 	<rdar://problem/3783628> REGRESSION (Mail): when I try to reorder an image, the image is duplicated
   11796 
   11797         * DOM.subproj/WebDOMOperations.m:
   11798         (-[DOMDocument _createRangeWithNode:]): new, convenience
   11799         (-[DOMDocument _documentRange]): use _ createRangeWithNode:
   11800         * DOM.subproj/WebDOMOperationsPrivate.h:
   11801         * WebView.subproj/WebHTMLView.m:
   11802         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): set the selection to the image when starting the drag. This allows "move selection" to work and this matches NSText's behavior
   11803 
   11804 === Safari-162 ===
   11805 
   11806 2004-09-02  Richard Williamson   <rjw (a] apple.com>
   11807 
   11808         Support for patterns in <canvas>.  
   11809         (These changes attempt to create a CGImageRef from a WebImageRenderer that
   11810         is used by the pattern drawing function.)
   11811         
   11812         Reviewed by Hyatt.
   11813 
   11814         * WebCoreSupport.subproj/WebImageRenderer.h:
   11815         * WebCoreSupport.subproj/WebImageRenderer.m:
   11816         (-[WebImageRenderer dealloc]):
   11817         (-[WebImageRenderer finalize]):
   11818         (-[WebImageRenderer imageRef]):
   11819         (_createImageRef):
   11820         * WebView.subproj/WebPDFView.h:
   11821         * WebView.subproj/WebPDFView.m:
   11822 
   11823 2004-09-01  Chris Blumenberg  <cblu (a] apple.com>
   11824 
   11825 	Fixed deployment build failure.
   11826 
   11827         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   11828         (-[WebDefaultUIDelegate menuItemWithTag:]):
   11829 
   11830 2004-08-31  Chris Blumenberg  <cblu (a] apple.com>
   11831 
   11832 	Fixed: 
   11833 	<rdar://problem/3699498> Context menu for editable WebViews should provide items like Cut and Paste
   11834 	<rdar://problem/3781535> REGRESSION (Mail): no context menu after ctrl-clicking a misspelled word
   11835 
   11836         Reviewed by kocienda.
   11837 
   11838         * English.lproj/Localizable.strings:
   11839         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   11840         (-[WebDefaultUIDelegate menuItemWithTag:]): updated to handle new menu items
   11841         (-[WebDefaultUIDelegate contextMenuItemsForElement:]): renamed from webView:contextMenuItemsForElement:defaultMenuItems:
   11842         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:]): new
   11843         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): moved, now call contextMenuItemsForElement: or editingContextMenuItemsForElement:
   11844         * WebView.subproj/WebDefaultUIDelegate.h:
   11845         * WebView.subproj/WebHTMLView.m:
   11846         (-[WebHTMLView _isSelectionMisspelled]): new
   11847         (-[WebHTMLView _guessesForMisspelledSelection]): new
   11848         (-[WebHTMLView _changeSpellingFromMenu:]): new
   11849         (-[WebHTMLView _ignoreSpellingFromMenu:]): new
   11850         (-[WebHTMLView _learnSpellingFromMenu:]): new
   11851         * WebView.subproj/WebHTMLViewPrivate.h:
   11852         * WebView.subproj/WebUIDelegate.h:
   11853 
   11854 2004-08-31  Darin Adler  <darin (a] apple.com>
   11855 
   11856         - fixed B&I build failure
   11857 
   11858         * WebView.subproj/WebHTMLView.m: (-[WebTextCompleteController _buildUI]):
   11859         Work around unwanted warning by adding a cast.
   11860 
   11861 2004-08-27  Maciej Stachowiak  <mjs (a] apple.com>
   11862 
   11863         Reviewed by John.
   11864 
   11865 	<rdar://problem/3778314> REGRESSION: Can't proceed to survey questions on Lominger's Apple website
   11866         
   11867 	Because we will stop parsing when there is a pending redirection,
   11868 	avoid setting one if no navigation would actually take place
   11869 	because the number of steps is out of range.
   11870 
   11871 	* WebCoreSupport.subproj/WebBridge.m:
   11872         (-[WebBridge canGoBackOrForward:]):
   11873 
   11874 2004-08-30  Darin Adler  <darin (a] apple.com>
   11875 
   11876         Reviewed by John.
   11877 
   11878         - part of fix for <rdar://problem/3637519> REGRESSION (125-128): unrepro crash in QListBox::sizeForNumberOfLines at istweb.apple.com
   11879 
   11880         * WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory clearCaches]):
   11881         Call [super clearCaches].
   11882 
   11883 2004-08-30  Darin Adler  <darin (a] apple.com>
   11884 
   11885         Reviewed by Chris.
   11886 
   11887         - did work to prepare for uploading files incrementally when submitting forms
   11888 
   11889         * History.subproj/WebHistoryItem.m:
   11890         (-[WebHistoryItem _setFormInfoFromRequest:]): Use NSArray instead of NSData for form data.
   11891         (-[WebHistoryItem formData]): Ditto.
   11892         * History.subproj/WebHistoryItemPrivate.h: Ditto.
   11893         * WebCoreSupport.subproj/WebBridge.m:
   11894         (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): Ditto.
   11895         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Ditto.
   11896         (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.
   11897         * WebCoreSupport.subproj/WebSubresourceClient.h: Ditto.
   11898         * WebCoreSupport.subproj/WebSubresourceClient.m:
   11899         (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): Ditto.
   11900         * WebView.subproj/WebFrame.m:
   11901         (-[WebFrame _loadItem:withLoadType:]): Ditto.
   11902         (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.
   11903         * WebView.subproj/WebFramePrivate.h: Ditto.
   11904 
   11905         * WebView.subproj/WebFormDataStream.h: Added.
   11906         * WebView.subproj/WebFormDataStream.m:
   11907         (-[WebFormDataStream initWithFormDataArray:]): Placeholder; not done yet.
   11908         (-[WebFormDataStream formDataArray]): Ditto.
   11909         * WebKit.pbproj/project.pbxproj: Added WebFormDataStream files.
   11910 
   11911 2004-08-30  John Sullivan  <sullivan (a] apple.com>
   11912 
   11913         Reviewed by Ken.
   11914 
   11915         - WebKit part of fix for <rdar://problem/3607720> myFrame.print() prints the window 
   11916         but should only print the frame
   11917 
   11918         * WebView.subproj/WebUIDelegatePrivate.h:
   11919         declare new delegate method that includes which frame to print
   11920 
   11921         * WebView.subproj/WebDefaultUIDelegate.m:
   11922         (-[WebDefaultUIDelegate webView:printFrameView:]):
   11923         implement default (no-op) version of new delegate method
   11924 
   11925         * WebCoreSupport.subproj/WebBridge.m:
   11926         (-[WebBridge print]):
   11927         call new delegate method if available, otherwise call old delegate method, for
   11928         backward compatibility.
   11929 
   11930 2004-08-27  Maciej Stachowiak  <mjs (a] apple.com>
   11931 
   11932         Reviewed by John. 
   11933         Checked in by Ken
   11934         
   11935         Ken comments: It looks like Maciej forgot to land this when he checked in the
   11936         WebCore portion of this change.
   11937 
   11938         <rdar://problem/3778314> REGRESSION: Can't proceed to survey questions on Lominger's Apple website
   11939             
   11940         Because we will stop parsing when there is a pending redirection,
   11941         avoid setting one if no navigation would actually take place
   11942         because the number of steps is out of range.
   11943     
   11944         * WebCoreSupport.subproj/WebBridge.m:
   11945         (-[WebBridge canGoBackOrForward:]):
   11946 
   11947 2004-08-27  Ken Kocienda  <kocienda (a] apple.com>
   11948 
   11949         Reviewed by Chris
   11950 
   11951         Fix for this bug:
   11952         
   11953         <rdar://problem/3756997> WebKit aggressive in making pasted text into a URL, even when it's not much like a URL
   11954 
   11955         * WebView.subproj/WebHTMLView.m:
   11956         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): Don't try so hard to coerce data
   11957         on the pasteboard into a URL, and do not make an anchor with an href for any URLs that are 
   11958         explicitly present on the pasteboard. Also, move URL pasteboard type check beneath the RTF
   11959         checks.
   11960 
   11961 === Safari-161 ===
   11962 
   11963 2004-08-26  Chris Blumenberg  <cblu (a] apple.com>
   11964 
   11965 	Fixed build failure on Panther.
   11966 
   11967         Reviewed by john.
   11968 
   11969         * WebView.subproj/WebHTMLView.m:
   11970         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): ifdef'd out call to AppKit SPI
   11971         (-[WebHTMLView _attributeStringFromDOMRange:]): ditto
   11972 
   11973 2004-08-26  Chris Blumenberg  <cblu (a] apple.com>
   11974 
   11975 	Tweak to last check-in.
   11976 
   11977         * WebView.subproj/WebHTMLView.m:
   11978         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]):
   11979 
   11980 2004-08-26  Chris Blumenberg  <cblu (a] apple.com>
   11981 
   11982 	Fixed: 
   11983 	<rdar://problem/3546412> support for pasting and drag and dropping of RTF and RTFD to editable WebViews
   11984 	<rdar://problem/3745345> use AppKit for converting from DOM to RTF
   11985 
   11986         Reviewed by rjw.
   11987 
   11988         * DOM.subproj/WebDOMOperations.m:
   11989         (-[DOMDocument _documentRange]): new
   11990         * DOM.subproj/WebDOMOperationsPrivate.h:
   11991         * WebView.subproj/WebHTMLView.m:
   11992         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): call AppKit SPI to get a document fragment from an attributed string
   11993         (-[WebHTMLView string]): added a FIXME
   11994         (-[WebHTMLView _attributeStringFromDOMRange:]): new, calls AppKit SPI that creates an attributed string from a DOM Range
   11995         (-[WebHTMLView attributedString]): call _attributeStringFromDOMRange:, fallback to old code if it returns nil
   11996         (-[WebHTMLView selectedAttributedString]): ditto
   11997 
   11998 2004-08-26  Chris Blumenberg  <cblu (a] apple.com>
   11999 
   12000 	Fixed: <rdar://problem/3774178> Plugin hooks for selected state aren't being called
   12001 
   12002         Reviewed by darin.
   12003 
   12004         * WebCoreSupport.subproj/WebBridge.m:
   12005         (-[WebBridge setIsSelected:forView:]): don't forget colons in method names
   12006 
   12007 2004-08-26  Chris Blumenberg  <cblu (a] apple.com>
   12008 
   12009 	Fixed: <rdar://problem/3768439> can't click in WebView in Carbon WebKit apps (GetEventPlatformEventRecord returns false)
   12010 
   12011         Reviewed by rjw.
   12012 
   12013         * Carbon.subproj/HIWebView.m:
   12014         (Click): use WebGetEventPlatformEventRecord not GetEventPlatformEventRecord
   12015         (MouseUp): ditto
   12016         (MouseMoved): ditto
   12017         (MouseDragged): ditto
   12018         (MouseWheelMoved): ditto
   12019         (WindowHandler): ditto
   12020         (HIWebViewEventHandler): ditto
   12021         (UpdateObserver): ditto
   12022         (WebGetEventPlatformEventRecord): Call GetEventPlatformEventRecord, if that fails fallback to the current event. This is code Eric Schlegel to me to use. 
   12023 
   12024 2004-08-24  Chris Blumenberg  <cblu (a] apple.com>
   12025 
   12026 	Fixed with help from Trey:
   12027 	<rdar://problem/3764856> REGRESSION !25-154): Safari accepts mouse clicks (follows links) when not key
   12028 
   12029         Reviewed by rjw.
   12030 
   12031         * WebView.subproj/WebHTMLView.m:
   12032         (-[WebHTMLView _isSelectionEvent:]): brought back from CVS
   12033         (-[WebHTMLView acceptsFirstMouse:]): only call eventMayStartDrag if _isSelectionEvent returns YES since we only want to allow selection dragging on the first mouse down
   12034         (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): ditto
   12035 
   12036 2004-08-24  Ken Kocienda  <kocienda (a] apple.com>
   12037 
   12038         Reviewed by Hyatt
   12039 
   12040         Improved the checks used to see if certain operations can be done based
   12041         on the state of the selection and whether the selection is editable. I
   12042         added some helpers and improved some others to assist in making these
   12043         determinations.
   12044         
   12045         This helps to fix this bug:
   12046         <rdar://problem/3764987> Crash after adding newline to quoted text
   12047         
   12048         Since some editing methods expect the the selection to be in a certain state 
   12049         in order to work, these checks help obviate crashes like 3764987.
   12050 
   12051         * WebView.subproj/WebHTMLView.m:
   12052         (-[WebHTMLView _writeSelectionToPasteboard:]): _haveSelection name changed to _hasSelection.
   12053         (-[WebHTMLView _canCopy]): Checks to see if state is appropriate to perform this operation.
   12054         (-[WebHTMLView _canCut]): Ditto. Function added.
   12055         (-[WebHTMLView _canDelete]): Ditto. Function refined.
   12056         (-[WebHTMLView _canPaste]): Ditto. Function refined.
   12057         (-[WebHTMLView _canType]): Ditto. Function added.
   12058         (-[WebHTMLView _hasSelection]): Name changed from _haveSelection.
   12059         (-[WebHTMLView _hasSelectionOrInsertionPoint]): Added.
   12060         (-[WebHTMLView _isEditable]): Added.
   12061         (-[WebHTMLView takeFindStringFromSelection:]): _haveSelection name changed to _hasSelection.
   12062         (-[WebHTMLView validateUserInterfaceItem:]): Ditto
   12063         (-[WebHTMLView validRequestorForSendType:returnType:]): Ditto
   12064         (-[WebHTMLView keyDown:]):
   12065         (-[WebHTMLView copy:]): Uses new _canCopy check.
   12066         (-[WebHTMLView cut:]): Uses new _canCut check.
   12067         (-[WebHTMLView delete:]): Now uses _canDelete check.
   12068         (-[WebHTMLView paste:]): Now uses _canPaste check.
   12069         (-[WebHTMLView _updateFontPanel]): _haveSelection name changed to _hasSelection.
   12070         * WebView.subproj/WebHTMLViewPrivate.h:
   12071         * WebView.subproj/WebView.m:
   12072         (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): Use selectionState check to
   12073         determine whether or not operation can be done.
   12074 
   12075 2004-08-24  Richard Williamson   <rjw (a] apple.com>
   12076 
   12077         Fixed <rdar://problem/3770469> Some PDFs open with line of previous page above PDF view
   12078 	
   12079         Set height resize flags on WebPDFView.
   12080 		
   12081         Reviewed by Chris.
   12082 
   12083         * WebView.subproj/WebPDFView.m:
   12084         (-[WebPDFView initWithFrame:]):
   12085 
   12086 2004-08-24  David Hyatt  <hyatt (a] apple.com>
   12087 
   12088 	Add Atom and RSS MIME types to set of supported XML types.
   12089 	
   12090         Reviewed by rjw
   12091 
   12092         * WebView.subproj/WebDataSource.m:
   12093         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
   12094         * WebView.subproj/WebFrameView.m:
   12095         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
   12096 
   12097 2004-08-23  Maciej Stachowiak  <mjs (a] apple.com>
   12098 
   12099         Reviewed by Kevin.
   12100 
   12101 	- remove annoying ERROR spew and replace with comment
   12102 	
   12103         * WebView.subproj/WebHTMLView.m:
   12104         (-[WebHTMLView validAttributesForMarkedText]):
   12105 
   12106 2004-08-23  Maciej Stachowiak  <mjs (a] apple.com>
   12107 
   12108         Reviewed by Richard.
   12109 
   12110 	- a bit of code cleanup
   12111 
   12112         * WebView.subproj/WebDataSource.m:
   12113         (-[WebDataSource _stringWithData:]): Call textEncodingName instead of
   12114 	copying it's code.
   12115         (-[WebDataSource textEncodingName]): Tweak formatting.
   12116 
   12117 2004-08-23  Chris Blumenberg  <cblu (a] apple.com>
   12118 
   12119 	Fixed build.
   12120 
   12121         * WebKit.pbproj/project.pbxproj: make sure we're doing -f on a file, not a directory
   12122 
   12123 2004-08-23  Chris Blumenberg  <cblu (a] apple.com>
   12124 
   12125 	Fixed: <rdar://problem/3674867> use new Security framework SPI's to reenable cert acquisition
   12126 
   12127         Reviewed by john.
   12128 
   12129         * WebCoreSupport.subproj/WebKeyGeneration.cpp:
   12130         * WebCoreSupport.subproj/WebKeyGeneration.h:
   12131         * WebCoreSupport.subproj/WebKeyGenerator.h:
   12132         * WebCoreSupport.subproj/WebKeyGenerator.m:
   12133         (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): re-enabled cert code, call Panther version on Panther, Tiger version on Tiger
   12134         (-[WebKeyGenerator addCertificatesToKeychainFromData:]): ditto
   12135         * WebCoreSupport.subproj/WebNewKeyGeneration.c: Added.
   12136         (gnrAddContextAttribute):
   12137         (gnrGetSubjPubKey):
   12138         (gnrNullAlgParams):
   12139         (gnrSign):
   12140         (gnrFreeCssmData):
   12141         (nssArraySize):
   12142         (signedPublicKeyAndChallengeString):
   12143         (addCertificateToKeychainFromData):
   12144         (addCertificatesToKeychainFromData):
   12145         * WebCoreSupport.subproj/WebNewKeyGeneration.h: Added.
   12146         * WebKit.pbproj/project.pbxproj:
   12147 
   12148 2004-08-20  David Hyatt  <hyatt (a] apple.com>
   12149 
   12150 	Fix the directionality of the unicode hyphen so that on Panther it now matches Tiger.
   12151 	
   12152         Reviewed by darin
   12153 
   12154         * Misc.subproj/WebUnicode.m:
   12155         (_unicodeDirection):
   12156 
   12157 2004-08-20  Richard Williamson   <rjw (a] apple.com>
   12158 
   12159 	    Implemented new JNI abstraction.  We no longer invoke Java methods
   12160 	    directly with JNI, rather we call into the plugin.  This allows the
   12161 	    plugin to dispatch the call to the appropriate VM thread.  This
   12162 	    change should (will?) fix a whole class of threading related problems with
   12163 	    the Java VM.
   12164 
   12165         Reviewed by Hyatt.
   12166 
   12167         * WebCoreSupport.subproj/WebBridge.m:
   12168         (-[WebBridge getAppletInView:]):
   12169 
   12170 2004-08-20  Trey Matteson  <trey (a] apple.com>
   12171 
   12172 	3655407 - Editing: -complete: method unimplemented (WebKit editing API)
   12173 
   12174 	This feature is mostly implemented.  The only loose ends I know of are:
   12175 
   12176 	3769654 - text insertions done via complete: should preserve case of full replacement string
   12177 	3769652 - positioning of complete: popup window wrong for right-to-left languages
   12178 
   12179         Reviewed by John
   12180 
   12181         * WebView.subproj/WebHTMLView.m:
   12182         (-[WebHTMLViewPrivate dealloc]):  Free new object.
   12183         (-[WebHTMLView menuForEvent:]):  Bail on completion session.
   12184         (-[WebHTMLView windowDidResignKey:]):  Ditto.
   12185         (-[WebHTMLView windowWillClose:]):  Ditto.
   12186         (-[WebHTMLView mouseDown:]):  Ditto.
   12187         (-[WebHTMLView resignFirstResponder]):  Ditto.
   12188         (-[WebHTMLView keyDown:]):  Bail on completion session if WebCore takes the event.
   12189 	Give the CompleteController a crack at the key event.
   12190         (-[WebHTMLView _expandSelectionToGranularity:]):  Adopt method rename
   12191         (-[WebHTMLView complete:]):  Make CompleteController, tell it to do its thing.
   12192         (-[WebHTMLView checkSpelling:]):  Add ERROR().
   12193         (-[WebHTMLView showGuessPanel:]): Add ERROR().
   12194         (-[WebHTMLView _changeSpellingToWord:]): Add ERROR().
   12195         (-[WebHTMLView ignoreSpelling:]): Add ERROR().
   12196 
   12197         (-[WebTextCompleteController initWithHTMLView:]):
   12198         (-[WebTextCompleteController dealloc]):
   12199         (-[WebTextCompleteController _insertMatch:]): Stick the new string into the doc.
   12200         (-[WebTextCompleteController _buildUI]):  Make popup window.
   12201         (-[WebTextCompleteController _placePopupWindow:]):  Position popup window.
   12202         (-[WebTextCompleteController doCompletion]):  Lookup matches, display window.
   12203         (-[WebTextCompleteController endRevertingChange:moveLeft:]):  Bail on complete: session.
   12204         (-[WebTextCompleteController filterKeyDown:]):  Process keys while popup is up.
   12205         (-[WebTextCompleteController _reflectSelection]):  Handle choice in popup.
   12206         (-[WebTextCompleteController tableAction:]):  Handle double click in popup
   12207         (-[WebTextCompleteController numberOfRowsInTableView:]):  Fill table with matches.
   12208         (-[WebTextCompleteController tableView:objectValueForTableColumn:row:]):  Ditto.
   12209         (-[WebTextCompleteController tableViewSelectionDidChange:]):  Handle selection change.
   12210         * WebView.subproj/WebHTMLViewInternal.h:
   12211 
   12212 2004-08-20  John Sullivan  <sullivan (a] apple.com>
   12213 
   12214         * English.lproj/StringsNotToBeLocalized.txt:
   12215         checked this in; the only difference is that
   12216         the strings were out of order.
   12217 
   12218 2004-08-19  Richard Williamson   <rjw (a] apple.com>
   12219 
   12220         Continue to call old pollForAppletInView: in Tiger until
   12221         we get an plugin that supports the new API.
   12222 		
   12223         Reviewed by Chris.
   12224 
   12225         * WebCoreSupport.subproj/WebBridge.m:
   12226         (-[WebBridge getAppletInView:]):
   12227         * WebKit.pbproj/project.pbxproj:
   12228 
   12229 === Safari-158 ===
   12230 
   12231 2004-08-19  Chris Blumenberg  <cblu (a] apple.com>
   12232 
   12233 	Fixed typo in comment.
   12234 
   12235         * Misc.subproj/WebIconDatabase.m:
   12236         (-[WebIconDatabase _updateFileDatabase]):
   12237 
   12238 2004-08-19  Chris Blumenberg  <cblu (a] apple.com>
   12239 
   12240 	Fixed: <rdar://problem/3566336> CrashTracer: .2403 crashes at com.apple.WebKit: -[WebFileDatabase performSetObject:forKey:] + 0x94
   12241 
   12242         Reviewed by trey.
   12243 
   12244         * Misc.subproj/WebIconDatabase.m:
   12245         (-[WebIconDatabase _updateFileDatabase]): pass WebFileDatabase copies of the mutable dictionaries or else they may be accessed on a separate thread as the main thread is modifying them
   12246 
   12247 2004-08-18  Richard Williamson   <rjw (a] apple.com>
   12248 
   12249         Replace horrible pollForAppletInView: with new
   12250         webPlugInGetApplet.  The details of how the applet instance
   12251         is provided now belong to the Java team.  Yeh.
   12252 		
   12253         Reviewed by Chris.
   12254 
   12255         * WebCoreSupport.subproj/WebBridge.m:
   12256         (-[WebBridge getAppletInView:]):
   12257 
   12258 2004-08-17  Richard Williamson   <rjw (a] apple.com>
   12259 
   12260         Fixed <rdar://problem/3759093> Need PDF context menu: "Open in Preview" or other external app
   12261 
   12262         Added support for "Open with ..." in PDF view.
   12263 		
   12264         Reviewed by Chris and Trey.
   12265 
   12266         * ChangeLog:
   12267         * English.lproj/Localizable.strings:
   12268         * English.lproj/StringsNotToBeLocalized.txt:
   12269         * WebView.subproj/WebPDFView.h:
   12270         * WebView.subproj/WebPDFView.m:
   12271         (-[WebPDFView initWithFrame:]):
   12272         (-[WebPDFView dealloc]):
   12273         (applicationInfoForMIMEType):
   12274         (-[WebPDFView path]):
   12275         (-[WebPDFView menuForEvent:]):
   12276         (-[WebPDFView setDataSource:]):
   12277         (-[WebPDFView layout]):
   12278         (-[WebPDFView viewDidMoveToHostWindow]):
   12279         (-[WebPDFView openWithFinder:]):
   12280 
   12281 2004-08-17  Richard Williamson   <rjw (a] apple.com>
   12282 
   12283         JNI needs both the jmethodID and return type.  Changed API to 
   12284         pass both.
   12285 		
   12286         Reviewed by Chris.
   12287 
   12288         * Plugins.subproj/WebJavaPlugIn.h:
   12289 
   12290 2004-08-17  Trey Matteson  <trey (a] apple.com>
   12291 
   12292 	3764147 - failure of subframe to load leaves links in parent doc broken
   12293 
   12294         Reviewed by Maciej.
   12295 
   12296         * WebView.subproj/WebDataSource.m:
   12297         (-[WebDataSource _receivedMainResourceError:complete:]):
   12298 	Need to call [bridge end] in the case of an error, so WC can clean up.
   12299 
   12300 === Safari-157 ===
   12301 
   12302 2004-08-15  Richard Williamson   <rjw (a] apple.com>
   12303 
   12304         More changes to np headers.
   12305         
   12306         Reviewed by Darin.
   12307 
   12308         * Plugins.subproj/WebNetscapePluginPackage.m:
   12309         (-[WebNetscapePluginPackage load]):
   12310         * Plugins.subproj/npapi.h:
   12311         * Plugins.subproj/npfunctions.h:
   12312         * Plugins.subproj/npruntime.h:
   12313 
   12314 2004-08-13  Darin Adler  <darin (a] apple.com>
   12315 
   12316         Reviewed by Chris.
   12317 
   12318         - fixed <rdar://problem/3760924> Carbon path passed in NPP_StreamAsFile must be in local character set, not UTF-8
   12319 
   12320         * Plugins.subproj/WebBaseNetscapePluginStream.m:
   12321         (CarbonPathFromPOSIXPath): Added. New function that uses the path pieces from an FSSpec.
   12322         This has many advantages; the big one that fixes the bug is that it gives the mangled names
   12323         that work even for files that have names that can't otherwise be encoded in Carbon-style
   12324         path names. I didn't write this from scratch: I started with the method in Foundation
   12325         and just changed it to use FSSpec.
   12326         (-[WebBaseNetscapePluginStream destroyStream]): Remove code that used NSString and just call
   12327         CarbonPathFromPOSIXPath instead.
   12328 
   12329         * Plugins.subproj/npapi.h: The Revision tag wanted to touch this file.
   12330         I think we are going to have some trouble with this; I'd like to take that out.
   12331 
   12332         * English.lproj/StringsNotToBeLocalized.txt: Updated.
   12333 
   12334 2004-08-12  Trey Matteson  <trey (a] apple.com>
   12335 
   12336         3761329 - query result links all dead in ingrammicro.com (sometimes)
   12337         3761328 - links in some docs dead when doc is loaded from WebArchive
   12338 
   12339         Nasty problem.  It turns out that these result pages are a parent frame with two child
   12340         frames.  One of the child frames is a 1 or 2 byte text document.  When the text child
   12341         is the last doc to complete, because we use a Text rep instead of an HTMLRep, it turns
   12342         out we never send [bridge end] from WebKit.  That mistake results in checkCompleted not
   12343         being called enough in the part, and we never realize the load is done.  WebCore does
   12344         not allow redirects to happen until the entire load is complete,  and  the links on this
   12345         results page are actually little pieces of JS that set location to a generated URL.  Since
   12346         redirects are not allowed these links all silently fail to do anything, and the doc never
   12347         achieves a completed state where they will work.
   12348 
   12349         Solution is to make sure we always call [bridge end] from the DataSource instead of only
   12350         the HTML rep doing it.
   12351 
   12352         Reviewed by Richard and Darin.
   12353 
   12354         * WebView.subproj/WebDataSource.m:
   12355         (-[WebDataSource _finishedLoading]):  Call [bridge end] here for all kinds of docs.
   12356         * WebView.subproj/WebHTMLRepresentation.m:
   12357         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):  Don't call is just for HTMLReps.
   12358 
   12359 2004-08-12  Richard Williamson   <rjw (a] apple.com>
   12360 
   12361         Bring npruntime.h and friends closer to compliance with
   12362         latest spec.
   12363 
   12364         Reviewed by Maciej.
   12365 
   12366         * Plugins.subproj/npapi.h:
   12367         * Plugins.subproj/npfunctions.h:
   12368         * Plugins.subproj/npruntime.h:
   12369         (_NPString::):
   12370         (_NPString::_NPVariant::):
   12371         * copy-webcore-files-to-webkit:
   12372 
   12373 2004-08-12  Chris Blumenberg  <cblu (a] apple.com>
   12374 
   12375 	Fixed: <rdar://problem/3761097> should be able to option-drag selection so HTML can be copied within a page
   12376 
   12377         Reviewed by rjw.
   12378 
   12379         * WebView.subproj/WebHTMLView.m:
   12380         (-[WebHTMLView _isMoveDrag]): new, take into account the option key
   12381         (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): call _isMoveDrag
   12382         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): call _isMoveDrag
   12383 
   12384 2004-08-12  Richard Williamson   <rjw (a] apple.com>
   12385 
   12386         Quick fix for 3760903.  The real fix is described in 3760920.  Needed
   12387         by Java plugin guys so they can be unblocked for feature freeze.
   12388 		
   12389         Reviewed by Chris.
   12390 
   12391         * WebView.subproj/WebFrame.m:
   12392         (-[WebFrame _reloadForPluginChanges]):
   12393         * WebView.subproj/WebHTMLView.m:
   12394         (-[WebHTMLView addSubview:]):
   12395 
   12396 2004-08-12  Chris Blumenberg  <cblu (a] apple.com>
   12397 
   12398 	Fixed: <rdar://problem/3760898> error pages in subframes attempt to load appledata URLs when reloaded
   12399 
   12400         Reviewed by darin.
   12401 
   12402         * WebView.subproj/WebFrame.m:
   12403         (-[WebFrame _createItem:]): when setting the original URL of the history item, use the unreachable URL
   12404 
   12405 === Safari-156 ===
   12406 
   12407 2004-08-11  Adele Amchan  <adele (a] apple.com>
   12408 
   12409         Reviewed by me, bug fix by Darin.
   12410 
   12411         - fixed <rdar://problem/3736477> Pages don't load if hard drive is named with non-ASCII Symbol
   12412 
   12413         * Plugins.subproj/WebBaseNetscapePluginStream.m:
   12414         (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]):
   12415         Use UTF8String instead of cString to convert the MIME type to a C string. Safer, since it can't
   12416         ever fail due to encoding problems even though this string should always be ASCII.
   12417         (-[WebBaseNetscapePluginStream destroyStream]): Use stringWithUTF8String to convert the path name
   12418         to an NSString, since stringWithCString is deprecated (doesn't really matter since the path is always
   12419         all ASCII). Fix the bug by calling fileSystemRepresentation on the NSString to turn it into a C
   12420         string form. Even though the POSIX path can't have any non-ASCII characters in it, the Carbon path
   12421         can, so we need to use this instead of cString which can fail depending on characters and encoding.
   12422 
   12423 2004-08-09  Maciej Stachowiak  <mjs (a] apple.com>
   12424 
   12425         Reviewed by Trey.
   12426 
   12427 	WebKit part of:
   12428 
   12429 	- made basic marked text highlighting work to complete basic level of <rdar://problem/3704359> input method support not yet implemented for HTML editing
   12430 
   12431         * WebView.subproj/WebHTMLView.m:
   12432         (-[WebHTMLView markedRange]): Use new bridge calls instead of internal marked range storage.
   12433         (-[WebHTMLView hasMarkedText]): Likewise.
   12434         (-[WebHTMLView unmarkText]): Likewise.
   12435         (-[WebHTMLView _selectMarkedText]): Likewise.
   12436         (-[WebHTMLView _selectRangeInMarkedText:]): Likewise.
   12437         (-[WebHTMLView _selectionIsInsideMarkedText]): Likewise.
   12438         (-[WebHTMLView _updateSelectionForInputManager]): Likewise.
   12439         (-[WebHTMLView setMarkedText:selectedRange:]): Use direct bridge call instead
   12440 	of private _selectMarkedDOMRange: method, which would now be trivial.
   12441         * WebView.subproj/WebHTMLViewInternal.h: Remove unneeded
   12442 
   12443 2004-08-10  Darin Adler  <darin (a] apple.com>
   12444 
   12445         Reviewed by Ken.
   12446 
   12447         - change name of WebMakeCollectable to WebNSRetainCFRelease so it fits into the
   12448           "NS and CF retain counts are separate" mental model, rather than the "think about
   12449           how garbage collection works" one
   12450 
   12451         * Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): Rename.
   12452         * Misc.subproj/WebNSObjectExtras.h: (WebNSRetainCFRelease): Ditto.
   12453         * Misc.subproj/WebNSURLExtras.m:
   12454         (+[NSURL _web_URLWithData:relativeToURL:]): Ditto.
   12455         (-[NSURL _web_URLWithLowercasedScheme]): Ditto.
   12456 
   12457 2004-08-09  Trey Matteson  <trey (a] apple.com>
   12458 
   12459 	3756599 - REGRESSION: hit assertion in KWQPageState invalidate
   12460 
   12461 	By inspection I found a flaw in the recently added logic, although
   12462 	I have no steps to repro.  My theoretical explanation is that we would
   12463 	get two errors and go through _receivedMainResourceError: twice, which
   12464 	would cause the pageState to be invalidated twice, which is the only
   12465 	way I can see to hit the assert.
   12466 
   12467         Reviewed by Darin
   12468 
   12469         * WebView.subproj/WebFrame.m:
   12470         (-[WebFrame _receivedMainResourceError:]):  Clear the pageState out
   12471 	of the history item after it's been invalidated by WebCore.
   12472 
   12473 2004-08-09  Richard Williamson   <rjw (a] apple.com>
   12474 
   12475         Inspired by Trey we have a much better approach for conditionally
   12476         linking Quart.framework.  Instead of multiple targets we use 
   12477         `` to invoke some inline script to extend COMMON_LDFLAGS as
   12478         necessary.  Thanks Trey!
   12479         
   12480         Reviewed by Trey.
   12481 
   12482         * WebKit.pbproj/project.pbxproj:
   12483 
   12484 2004-08-09  Trey Matteson  <trey (a] apple.com>
   12485 
   12486 	Hookup UI for "Continuous Spelling" menu item.
   12487 
   12488         Reviewed by Richard.
   12489 
   12490         * WebView.subproj/WebView.m:
   12491         (-[WebView validateUserInterfaceItem:]):  Enable and check the
   12492 	menu item to reflect our state.
   12493         (-[WebView toggleContinuousSpellChecking:]):  Change type to
   12494 	IBAction, just cosmetic.
   12495         * WebView.subproj/WebViewPrivate.h:
   12496 
   12497 2004-08-08  Trey Matteson  <trey (a] apple.com>
   12498 
   12499 	3745023 - Safari crashes trying to access anchor while downloading
   12500 
   12501 	I bet this is behind a few other crashers as well.  In this bug the start of the
   12502 	download leaves a KWQPageState hanging around, and when that is freed it damages
   12503 	the part and view.  If you're still using that page, you're dead.
   12504 
   12505 	The fix is to properly invalidate the PageState when we receive an error before
   12506 	reaching WebFrameCommitted state.  Normally this happens when a page is reheated
   12507 	from the PageState, but in this case we never manage to leave the page to begin
   12508 	with, although we've already created the PageState.
   12509 
   12510 	Other errors besides the synthetic one download generates would have caused similar
   12511 	crashing.  Another example would be clicking on a second link before the load
   12512 	caused by clicking on the first link reached committed state.
   12513 
   12514         Reviewed by Richard
   12515 
   12516         * WebView.subproj/WebDataSource.m:
   12517         (-[WebDataSource _receivedMainResourceError:complete:]):  Let the frame do the
   12518 	main work (since it has access to the pageCache state).  Also renamed to make
   12519 	it clear that this is about an error for the main resource.
   12520         * WebView.subproj/WebDataSourcePrivate.h:
   12521         * WebView.subproj/WebFrame.m:
   12522         (-[WebFrame _receivedMainResourceError:]):  Let WC know about the failure, as
   12523 	the DataSource used to, but now pass the pageCache state along too.
   12524         * WebView.subproj/WebFramePrivate.h:
   12525         * WebView.subproj/WebMainResourceClient.m:
   12526         (-[WebMainResourceClient receivedError:]):  Call renamed method.
   12527         (-[WebMainResourceClient cancelWithError:]):  Ditto.
   12528 
   12529 2004-08-08  Vicki Murley  <vicki (a] apple.com>
   12530 
   12531         Reviewed by vicki (changes by rjw)
   12532  
   12533 	- make "weak" linking with Quartz work with buildit
   12534 
   12535         * WebKit.pbproj/project.pbxproj: 
   12536 
   12537 2004-08-06  Ken Kocienda  <kocienda (a] apple.com>
   12538 
   12539         Reviewed by Maciej
   12540 
   12541         Finish off spellchecking support to HTML editing. Includes work to
   12542         enable continuous spellchecking.
   12543 
   12544         * WebCoreSupport.subproj/WebBridge.m:
   12545         (-[WebBridge isContinuousSpellCheckingEnabled]): Simple bridge method.
   12546         * WebCoreSupport.subproj/WebTextRenderer.m:
   12547         (-[WebTextRenderer drawLineForMisspelling:withWidth:]): New method to add
   12548         AppKit-style misspelling underline.
   12549 
   12550 === Safari-155 ===
   12551 
   12552 2004-08-05  Darin Adler  <darin (a] apple.com>
   12553 
   12554         * WebView.subproj/WebHTMLView.m: Added a list of methods that NSTextView implements that we don't.
   12555         All inside #if 0.
   12556 
   12557 2004-08-05  Chris Blumenberg  <cblu (a] apple.com>
   12558 
   12559         Fixed unnecessary import of NSURLFileTypeMappings.
   12560 
   12561         * WebView.subproj/WebMainResourceClient.m:
   12562 
   12563 2004-08-05  Richard Williamson   <rjw (a] apple.com>
   12564 
   12565         Make builds conditionally include -framework Quartz.
   12566 		
   12567         Reviewed by Chris.
   12568 
   12569         * WebKit.pbproj/project.pbxproj:
   12570 
   12571 2004-08-04  Darin Adler  <darin (a] apple.com>
   12572 
   12573         - fixed broken Deployment build
   12574 
   12575         * Carbon.subproj/HIWebView.m: (Click):
   12576         Remove code that checks err variable before setting it.
   12577 
   12578 2004-08-03  Richard Williamson   <rjw (a] apple.com>
   12579 
   12580         First cut at dirt simple PDF support.  This feature
   12581         depends on Quartz.framework (parent of PDFKit), which only exists
   12582         on Tiger.  So, we "weak" link against Quartz.
   12583 		
   12584         We do very basic PDF rendering.  Coming up are support for
   12585         "Find..." and linearized PDF (incremental).  Linearized PDF 
   12586         support will require API changes in PDFKit.
   12587 		
   12588         No UI is added to Safari, yet.
   12589 		
   12590         Reviewed by John.
   12591 
   12592         * WebKit.pbproj/project.pbxproj:
   12593         * WebView.subproj/WebDataSource.m:
   12594         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
   12595         * WebView.subproj/WebFrameView.m:
   12596         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
   12597         * WebView.subproj/WebPDFRepresentation.h: Added.
   12598         * WebView.subproj/WebPDFRepresentation.m: Added.
   12599         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
   12600         (-[WebPDFRepresentation canProvideDocumentSource]):
   12601         (-[WebPDFRepresentation documentSource]):
   12602         (-[WebPDFRepresentation title]):
   12603         * WebView.subproj/WebPDFView.h: Added.
   12604         * WebView.subproj/WebPDFView.m: Added.
   12605         (-[WebPDFView initWithFrame:]):
   12606         (-[WebPDFView setDataSource:]):
   12607         (-[WebPDFView dataSourceUpdated:]):
   12608         (-[WebPDFView setNeedsLayout:]):
   12609         (-[WebPDFView layout]):
   12610         (-[WebPDFView viewWillMoveToHostWindow:]):
   12611         (-[WebPDFView viewDidMoveToHostWindow]):
   12612 
   12613         Copied fix from Jaguar carbon/cocoa work.
   12614 		
   12615         Reviewed by Darin (Jaguar version)
   12616 
   12617         * Carbon.subproj/CarbonWindowAdapter.h:
   12618         * Carbon.subproj/CarbonWindowAdapter.m:
   12619         (-[CarbonWindowAdapter relinquishFocus]):
   12620         * Carbon.subproj/HIWebView.m:
   12621         (Click):
   12622         (OwningWindowChanged):
   12623         (WindowHandler):
   12624 
   12625 2004-08-03  David Hyatt  <hyatt (a] apple.com>
   12626 
   12627 	Add the text/xsl MIME type as one that can be displayed.
   12628 	
   12629         Reviewed by john
   12630 
   12631         * WebView.subproj/WebDataSource.m:
   12632         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
   12633         * WebView.subproj/WebFrameView.m:
   12634         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
   12635 
   12636 2004-08-03  Maciej Stachowiak  <mjs (a] apple.com>
   12637 
   12638         Reviewed by Ken.
   12639 
   12640 	- implemented enough of the NSTextInput protocol and added the
   12641 	proper calls to NSInputManager to allow input methods to
   12642 	work. However, the text is not marked yet.
   12643 
   12644         * WebView.subproj/WebHTMLViewInternal.h: Added new fields to track
   12645 	marked range.
   12646         * WebView.subproj/WebHTMLView.m:
   12647         (-[WebHTMLView markedRange]): Implemented
   12648         (-[WebHTMLView conversationIdentifier]): Implemented
   12649         (-[WebHTMLView hasMarkedText]): Implemented
   12650         (-[WebHTMLView unmarkText]): Implemented
   12651         (-[WebHTMLView setMarkedText:selectedRange:]): Implemented - does
   12652 	not yet handle attributes in attributed strings
   12653         (-[WebHTMLView insertText:]): Modified to handle replacing or abandoning
   12654 	the marked text when set.
   12655         (-[WebHTMLView _selectMarkedText]): new helper method, self-explanatory
   12656         (-[WebHTMLView _setMarkedDOMRange:]): hitto.
   12657         (-[WebHTMLView _selectRangeInMarkedText:]): ditto
   12658         (-[WebHTMLView _discardMarkedText]): ditto
   12659         (-[WebHTMLView _selectionIsInsideMarkedText]): ditto
   12660         (-[WebHTMLView _updateSelectionForInputManager]): ditto
   12661 
   12662 	- did a bit of refactoring while I was in here.
   12663 
   12664         * WebView.subproj/WebHTMLView.m:
   12665         (-[WebHTMLView _shouldReplaceSelectionWithText:givenAction:]): added this new
   12666 	helper method to simplify the common case of calling the shouldInsertText: delegate
   12667         (-[WebHTMLView pasteAsPlainText:]): use it
   12668         (-[WebHTMLView insertTab:]): ditto
   12669         (-[WebHTMLView insertNewline:]): ditto
   12670         (-[WebHTMLView _changeWordCaseWithSelector:]): ditto
   12671         (-[WebHTMLView _changeSpellingToWord:]): ditto
   12672         (-[WebHTMLView _selectionChanged]): ditto
   12673 
   12674 2004-08-03  Chris Blumenberg  <cblu (a] apple.com>
   12675 
   12676 	Fixed: <rdar://problem/3572737> Images not resizing at www.bmx-test.com (spoof nofix)
   12677 
   12678         Reviewed by darin.
   12679 
   12680         * WebCoreSupport.subproj/WebImageRendererFactory.m:
   12681         (-[WebImageRendererFactory supportedMIMETypes]): hard code image/pjpeg to the list of image mime types that we can handle
   12682 
   12683 2004-08-03  Darin Adler  <darin (a] apple.com>
   12684 
   12685         Reviewed by Ken.
   12686 
   12687         - fixed <rdar://problem/3740937> ER: A way to turn a DOMRange into text (equivalent of -innerText)
   12688 
   12689         * DOM.subproj/DOMPrivate.h: Added.
   12690         * WebKit.pbproj/project.pbxproj: Added DOMPrivate.h.
   12691         * copy-webcore-files-to-webkit: Added DOMPrivate.h.
   12692 
   12693 2004-08-02  John Sullivan  <sullivan (a] apple.com>
   12694 
   12695         Reviewed by Darin.
   12696 
   12697         WebKit part of fix for <rdar://problem/3631868> NSToolbar adoption: 
   12698         Tab key should cycle around toolbar and page content
   12699 
   12700         * WebView.subproj/WebHTMLView.m:
   12701         removed overrides of nextKeyView and previousKeyView
   12702         (-[WebHTMLView nextValidKeyView]):
   12703         call super only if we can't move the focus within the frame hierarchy
   12704         (-[WebHTMLView previousValidKeyView]):
   12705         ditto
   12706         * WebView.subproj/WebHTMLViewInternal.h:
   12707         removed nextKeyViewAccessShouldMoveFocus ivar
   12708 
   12709 2004-08-02  Ken Kocienda  <kocienda (a] apple.com>
   12710 
   12711         Reviewed by John
   12712 
   12713         Update name of firstResponderIsSelfOrDescendantView, adding _web_ prefix to this SPI call.
   12714         
   12715         Do some work to make caret blinking in newly-created editable WebView's that are 
   12716         similar in structure to Blot more "automatic".
   12717 
   12718         * Misc.subproj/WebNSViewExtras.h: Change name of firstResponderIsSelfOrDescendantView. Add _web_ prefix.
   12719         * Misc.subproj/WebNSViewExtras.m:
   12720         (-[NSView _web_firstResponderIsSelfOrDescendantView]): Name change.
   12721         (-[NSView _web_firstResponderCausesFocusDisplay]): Adds an additional check for whether the view's
   12722         is first responder. This helps to make the focus setting in viewDidMoveToWindow work right.
   12723         * WebView.subproj/WebHTMLView.m:
   12724         (-[WebHTMLView updateFocusDisplay]): Use _web_firstResponderCausesFocusDisplay now instead of 
   12725         firstResponderIsSelfOrDescendantView.
   12726         (-[WebHTMLView viewDidMoveToWindow]): Schedule call to updateFocusDisplay for the next crank of the
   12727         run loop. The reason is that placing the caret in the just-installed view requires the HTML/XML 
   12728         document to be available on the WebCore side, but it is not at the time this code is running. 
   12729         However, it will be there on the next crank of the run loop. Doing this helps to make a 
   12730         blinking caret appear in a new, empty window "automatic".
   12731         (-[WebHTMLView performKeyEquivalent:]):  _web_firstResponderIsSelfOrDescendantView name change.
   12732         * WebView.subproj/WebView.m:
   12733         (-[WebView _performResponderOperation:with:]): _web_firstResponderIsSelfOrDescendantView name change.
   12734 
   12735 2004-07-29  Maciej Stachowiak  <mjs (a] apple.com>
   12736 
   12737         Reviewed by John.
   12738 
   12739 	Added stubbed-out versions of all the NSTextInput protocol
   12740 	methods, and put comments in places where we will need to call the
   12741 	input manager to make input methods work 100%.
   12742 	
   12743         * WebCoreSupport.subproj/WebBridge.m:
   12744         (-[WebBridge respondToChangedSelection]):
   12745         * WebView.subproj/WebHTMLView.m:
   12746         (-[WebHTMLView mouseDown:]):
   12747         (-[WebHTMLView mouseDragged:]):
   12748         (-[WebHTMLView mouseUp:]):
   12749         (-[WebHTMLView _interceptEditingKeyEvent:]):
   12750         (-[WebHTMLView keyDown:]):
   12751         (-[WebHTMLView _selectionChanged]):
   12752         (-[WebHTMLView _delegateDragSourceActionMask]):
   12753         (-[WebHTMLView validAttributesForMarkedText]):
   12754         (-[WebHTMLView characterIndexForPoint:]):
   12755         (-[WebHTMLView firstRectForCharacterRange:]):
   12756         (-[WebHTMLView selectedRange]):
   12757         (-[WebHTMLView markedRange]):
   12758         (-[WebHTMLView attributedSubstringFromRange:]):
   12759         (-[WebHTMLView conversationIdentifier]):
   12760         (-[WebHTMLView hasMarkedText]):
   12761         (-[WebHTMLView unmarkText]):
   12762         (-[WebHTMLView setMarkedText:selectedRange:]):
   12763         (-[WebHTMLView doCommandBySelector:]):
   12764         (-[WebHTMLView insertText:]):
   12765         * WebView.subproj/WebHTMLViewInternal.h:
   12766         * WebView.subproj/WebView.m:
   12767 
   12768 === Safari-154 ===
   12769 
   12770 2004-07-29  Darin Adler  <darin (a] apple.com>
   12771 
   12772         Reviewed by Ken.
   12773 
   12774         - fill in some unimplemented methods
   12775 
   12776         * WebView.subproj/WebHTMLView.m:
   12777         (-[WebHTMLView moveToBeginningOfDocument:]): Implement, using new document granularity.
   12778         (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): Ditto.
   12779         (-[WebHTMLView moveToBeginningOfParagraph:]): Implement, even though the underlying WebCore
   12780         code is not yet implemented.
   12781         (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]): Ditto.
   12782         (-[WebHTMLView moveToEndOfDocument:]): More of the same.
   12783         (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): Ditto.
   12784         (-[WebHTMLView moveToEndOfParagraph:]): More of the same.
   12785         (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]): Ditto.
   12786         (-[WebHTMLView pageDown:]): Added comment describing desired behavior.
   12787         (-[WebHTMLView pageUp:]): Ditto.
   12788         (-[WebHTMLView copyFont:]): Ditto.
   12789         (-[WebHTMLView pasteFont:]): Ditto.
   12790         (-[WebHTMLView changeAttributes:]): Ditto.
   12791         (-[WebHTMLView indent:]): Ditto.
   12792 
   12793 2004-07-28  Chris Blumenberg  <cblu (a] apple.com>
   12794 
   12795 	Fixed: <rdar://problem/3737864> Can not download image from web by using drag and drop
   12796 
   12797         Reviewed by john.
   12798 
   12799         * Misc.subproj/WebNSPasteboardExtras.m:
   12800         (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]): On Tiger, to use NSFilesPromisePboardType with other pasteboard types, set the file types of the promise on the pasteboard as a property list instead of mucking with the NSFilePromiseDragSource class
   12801 
   12802 2004-07-28  Maciej Stachowiak  <mjs (a] apple.com>
   12803 
   12804         Reviewed by John.
   12805 
   12806 	- avoid triggering an assertion when using dead keys (like option-e)
   12807 
   12808         * WebView.subproj/WebHTMLView.m:
   12809         (-[WebHTMLView insertText:]): Don't pass zero-length strings to
   12810 	WebCore. Dead-key input seems to insert empty strings as a side
   12811 	effect.
   12812 
   12813 2004-07-28  Trey Matteson  <trey (a] apple.com>
   12814 
   12815 	Spellchecking, Part I.  Basic spellcheck is working.  Spelling panel is hooked up.
   12816 
   12817 	At this point, no special marking of misspellings, no grammar check, no context
   12818 	menu integration, no "check continually" mode.
   12819 
   12820         Reviewed by Ken.
   12821 
   12822         * WebCoreSupport.subproj/WebBridge.m:
   12823         (-[WebBridge spellCheckerDocumentTag]):  Typical bridge glue.
   12824         * WebView.subproj/WebHTMLView.m:
   12825         (-[WebHTMLView validateUserInterfaceItem:]):  Validate various spelling actions.
   12826         (-[WebHTMLView checkSpelling:]):  Call WC for real work, update panel.
   12827         (-[WebHTMLView showGuessPanel:]):  Show panel, call WC for real work.
   12828         (-[WebHTMLView _changeSpellingToWord:]):  Apply correction to our doc.
   12829         (-[WebHTMLView changeSpelling:]):  Simple pass through to above method.
   12830         (-[WebHTMLView ignoreSpelling:]):  Tell checker to ignore the word.
   12831         * WebView.subproj/WebView.m:
   12832         (-[WebView _close]):  Call AK's closeSpellDocumentWithTag: for proper cleanup.
   12833 
   12834 2004-07-27  John Sullivan  <sullivan (a] apple.com>
   12835 
   12836         Reviewed by Trey.
   12837         
   12838         WebKit part of fix for <rdar://problem/3622268> Reload failed pages when a 
   12839         network problem is corrected, inc. using Network Diagnostics
   12840 
   12841         * WebView.subproj/WebFrame.m:
   12842         (-[WebFrame reload]):
   12843         This method did not handle unreachableURLs at all. The reason Safari's Reload
   12844         did work with unreachableURLs was that Safari does "reloadObeyingLocationField"
   12845         which never actually calls -[WebFrame reload]. Fixed by creating a fresh
   12846         request for the previously-unreachable URL.
   12847 
   12848 2004-07-26  Richard Williamson   <rjw (a] apple.com>
   12849 
   12850         Fixed 3739737.  When setting the focus to a NSView, set the focus
   12851         carbon focus to kControlIndicatorPart.  kControlIndicatorPart is a
   12852         placeholder value for use to indicate that Cocoa has the focus.  
   12853 	
   12854         Reviewed by Ken.
   12855 
   12856         * Carbon.subproj/CarbonWindowAdapter.m:
   12857         (-[CarbonWindowAdapter makeFirstResponder:]):
   12858         * Carbon.subproj/HIWebView.m:
   12859         (Click):
   12860         (SetFocusPart):
   12861 
   12862 2004-07-26  Chris Blumenberg  <cblu (a] apple.com>
   12863 
   12864 	Fixed: <rdar://problem/3689734> dragging to an editable WebView does not scroll document
   12865 
   12866         Reviewed by rjw.
   12867 
   12868         * WebView.subproj/WebView.m:
   12869         (-[WebView documentViewAtWindowPoint:]): new, factored from draggingDocumentViewAtWindowPoint:
   12870         (-[WebView _draggingDocumentViewAtWindowPoint:]): call documentViewAtWindowPoint:
   12871         (-[WebView _autoscrollForDraggingInfo:timeDelta:]): forward call to the document view
   12872         (-[WebView _shouldAutoscrollForDraggingInfo:]): ditto
   12873 
   12874 === Safari-153 ===
   12875 
   12876 2004-07-23  Ken Kocienda  <kocienda (a] apple.com>
   12877 
   12878         Reviewed by Trey
   12879 
   12880         Fix for this bug:
   12881         
   12882         <rdar://problem/3738920> Caret blinks in inactive window
   12883 
   12884         As part of the fix, I cleaned up the way we handle special drawing that needs
   12885         to be done in the HTML view that is first responder in the key window (e.g the
   12886         drawing of text selection highlight and caret blinking).
   12887 
   12888         * WebView.subproj/WebHTMLView.m:
   12889         (-[WebHTMLView updateFocusDisplay]): New method that centralizes the changes
   12890         we need to make when the first responder-ness of the view or key-ness of the
   12891         window changes.
   12892         (-[WebHTMLView viewDidMoveToWindow]): Call new updateFocusDisplay helper.
   12893         (-[WebHTMLView windowDidBecomeKey:]): Ditto.
   12894         (-[WebHTMLView windowDidResignKey:]): Ditto.
   12895         (-[WebHTMLView becomeFirstResponder]): Ditto.
   12896         (-[WebHTMLView resignFirstResponder]): Ditto.
   12897 
   12898 2004-07-22  Darin Adler  <darin (a] apple.com>
   12899 
   12900         * Plugins.subproj/npruntime.h: Update with new version from newer JavaScriptCore.
   12901 
   12902 2004-07-21  Ken Kocienda  <kocienda (a] apple.com>
   12903 
   12904         Reviewed by Trey
   12905 
   12906         * WebCoreSupport.subproj/WebBridge.m: Remove interceptEditingKeyEvent
   12907         bridge call over. This method of handling editing key events is now
   12908         obsolete.
   12909         * WebView.subproj/WebHTMLView.m:
   12910         (-[WebHTMLView performKeyEquivalent:]): Send key event over to the 
   12911         DOM if this view is or contains the first responder. This now
   12912         happens unconditionally.
   12913         (-[WebHTMLView keyDown:]): Send key event to the DOM, then see if
   12914         the web view wants to interpret it an an editing key event. This
   12915         is the new place to intercept key events for editing.
   12916 
   12917 2004-07-21  Ken Kocienda  <kocienda (a] apple.com>
   12918 
   12919         Reviewed by John
   12920 
   12921         Add implementations for these methods. Formerly, they logged an error.
   12922 
   12923         * WebView.subproj/WebHTMLView.m:
   12924         (-[WebHTMLView moveToBeginningOfLine:]):
   12925         (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]):
   12926         (-[WebHTMLView moveToEndOfLine:]):
   12927         (-[WebHTMLView moveToEndOfLineAndModifySelection:]):
   12928 
   12929 2004-07-21  Ken Kocienda  <kocienda (a] apple.com>
   12930 
   12931         Reviewed by John
   12932 
   12933         Added some more handlers for standard Cocoa key bindings. 
   12934         These are "secrets" of NSText, meaning they are not public API, but we choose to mimic.
   12935 
   12936         * WebView.subproj/WebHTMLView.m:
   12937         (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]):
   12938         (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]):
   12939         (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]):
   12940         (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]):
   12941         (-[WebHTMLView moveToEndOfLineAndModifySelection:]):
   12942         (-[WebHTMLView moveToEndOfParagraph:]):
   12943         (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]):
   12944         * WebView.subproj/WebView.h: Add these declarations to the comment in the header listing
   12945         the responder-like methods we support.
   12946         * WebView.subproj/WebView.m:
   12947         (-[WebView moveToBeginningOfParagraphAndModifySelection:]):
   12948         (-[WebView moveToEndOfParagraphAndModifySelection:]):
   12949         (-[WebView moveToBeginningOfLineAndModifySelection:]):
   12950         (-[WebView moveToEndOfLineAndModifySelection:]):
   12951         (-[WebView moveToBeginningOfDocumentAndModifySelection:]):
   12952         (-[WebView moveToEndOfDocumentAndModifySelection:]):
   12953 
   12954 2004-07-20  Ken Kocienda  <kocienda (a] apple.com>
   12955 
   12956         Reviewed by Richard
   12957 
   12958         * Misc.subproj/WebNSEventExtras.h: Added helper that returns whether
   12959         a key event has a binding in the key binding manager.
   12960         * Misc.subproj/WebNSEventExtras.m: 
   12961         (-[NSEvent _web_keyBindingManagerHasBinding]): New helper mentioned above.
   12962         * Plugins.subproj/npruntime.h:
   12963         * WebView.subproj/WebHTMLView.m:
   12964         (-[WebHTMLView performKeyEquivalent:]): Add a check of whether the key event 
   12965         has a binding in the key binding manager. This works around the fact that
   12966         NSResponder's interpretKeyEvents does not return a value telling whether
   12967         or not the key was handled. This now makes it possible for us to trap
   12968         modified key events we know we can handle (like those command-key + arrow events 
   12969         used for text navigation), while letting all others pass.
   12970 
   12971 2004-07-20  Chris Blumenberg  <cblu (a] apple.com>
   12972 
   12973 	Fixed:
   12974 	<rdar://problem/3580589> REGRESSION (1.1-1.2): can't open a new window for an image that has not loaded
   12975 	<rdar://problem/3612691> Missing image icons (blue ?) lack context menu
   12976 
   12977         Reviewed by john.
   12978 
   12979         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   12980         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): if there is no image, but there is an image URL, provide image context menu items besides "Copy Image" 
   12981         * WebView.subproj/WebHTMLView.m:
   12982         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): don't drag an image with an actual image
   12983         (-[WebHTMLView _mayStartDragAtEventLocation:]): ditto
   12984 
   12985 2004-07-20  Maciej Stachowiak  <mjs (a] apple.com>
   12986 
   12987         Reviewed by Chris.
   12988 
   12989 	<rdar://problem/3721690> REGRESSION (125.7-148u) clicking on links at macosx.apple.com/Builds does not load new page in frame
   12990 	
   12991         * Plugins.subproj/npruntime.h:
   12992         * WebCoreSupport.subproj/WebBridge.m:
   12993         (-[WebBridge canTargetLoadInFrame:]): Don't apply the restrictions to frames
   12994 	that are in the same window (Mozilla does this too).
   12995 
   12996 2004-07-20  Richard Williamson   <rjw (a] apple.com>
   12997 
   12998 		Fix for 3728558.  Fixed the key event handling in the carbon/cocoa
   12999 		integration code.  This does not fix the arrow keys not working on
   13000 		initial focus problem also mentioned in the bug.
   13001 		
   13002 		Bumped the version of the NP function structures.
   13003 		
   13004         Reviewed by John.
   13005 
   13006         * Carbon.subproj/CarbonUtils.m:
   13007         (WebInitForCarbon):
   13008         (PoolCleaner):
   13009         * Carbon.subproj/HIWebView.m:
   13010         (OwningWindowChanged):
   13011         (WindowHandler):
   13012         * Plugins.subproj/npapi.h:
   13013 
   13014 2004-07-20  Trey Matteson  <trey (a] apple.com>
   13015 
   13016 	3733698	REGRESSION: sometimes dragging photos on homepage.mac.com leads to an assertion
   13017 
   13018 	Relax an assertion, as we ran into a valid case where it's not true.
   13019 
   13020         Reviewed by Chris.
   13021 
   13022         * WebView.subproj/WebHTMLView.m:
   13023         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
   13024 	Removing this assert allows for the oddball case of a drag gesture that
   13025 	starts on one element, but then the element is no longer there when
   13026 	the drag is about to start.
   13027 
   13028 2004-07-20  Ken Kocienda  <kocienda (a] apple.com>
   13029 
   13030         Reviewed by Hyatt
   13031 
   13032         Fix for this bug:
   13033         
   13034         <rdar://problem/3707505> HTMLCompose: blinking cursor in both an address text field and the message body
   13035 
   13036         * WebView.subproj/WebHTMLView.m:
   13037         (-[WebHTMLView setCaretVisible:]): New helper. Calls over bridge to do the work.
   13038         (-[WebHTMLView windowDidBecomeKey:]): This function cannot just assume that self is first responder
   13039         (and do things like adjusting text background color and restoring focus rings). 
   13040         First-responder-ness needs to be checked first. Now it is.
   13041         (-[WebHTMLView windowDidResignKey:]): Ditto.
   13042         (-[WebHTMLView becomeFirstResponder]): Call new helper to make caret visible.
   13043         (-[WebHTMLView resignFirstResponder]): Call new helper to make caret invisible.
   13044 
   13045 2004-07-12  Richard Williamson   <rjw (a] apple.com>
   13046 
   13047         Fixed 3721917.  The RealPlayer plugin doesn't support the new 
   13048         NPPVpluginScriptableNPObject variable passed to NPP_GetValue and
   13049         incorrectly returns NPERR_NO_ERROR.  We interpret this to the
   13050         mean the variable has been set.  The variable has not been set 
   13051         and will consequently be uninitialized.
   13052 
   13053         * Plugins.subproj/WebBaseNetscapePluginView.m:
   13054         (-[WebBaseNetscapePluginView pluginScriptableObject]):
   13055 
   13056 2004-07-19  Ken Kocienda  <kocienda (a] apple.com>
   13057 
   13058         Reviewed by Richard
   13059 
   13060         Fix for this bug:
   13061         
   13062         <rdar://problem/3707504> HTMLCompose: key events are stolen by Web(HTML)View
   13063 
   13064         * Misc.subproj/WebNSViewExtras.h:
   13065         * Misc.subproj/WebNSViewExtras.m:
   13066         (-[NSView firstResponderIsSelfOrDescendantView]): New helper to 
   13067         (-[WebHTMLView performKeyEquivalent:]): Do not pass key events through to the editing
   13068         key handler unless the WebHTMLView is first responder or contains the first responder.
   13069         This prevents the "stealing" of key events mentioned in the bug.
   13070         * WebView.subproj/WebView.m:
   13071         (-[WebView _performResponderOperation:with:]): Uses the new firstResponderIsSelfOrDescendantView
   13072         helper. The code I replaced used the same logic as the new helper.
   13073 
   13074 === Safari-152 ===
   13075 
   13076 2004-07-12  Maciej Stachowiak  <mjs (a] apple.com>
   13077 
   13078         Reviewed by Kevin.
   13079 
   13080 	<rdar://problem/3673988>: (REGRESSION(141-144): connection assertion failure at http://traffic.511.org/sfgate)
   13081 	
   13082         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   13083         (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]):
   13084 	Don't check connection consistency if this load got cancelled
   13085 	while finishing, because in this case we have cleared the
   13086 	connection field already. This can happen when a redirect fires
   13087 	from an onload handler.
   13088 
   13089 2004-07-12  Maciej Stachowiak  <mjs (a] apple.com>
   13090 
   13091         Reviewed by John.
   13092 
   13093 	<rdar://problem/3632570>: (REGRESSION: SocialText.net wiki keeps asking for auth, even though pages load)
   13094 
   13095         * Misc.subproj/WebIconLoader.m:
   13096         (-[WebIconLoader didReceiveAuthenticationChallenge:]): Ignore the challenge - we don't
   13097 	want an auth panel for favicons.
   13098         (-[WebIconLoader didCancelAuthenticationChallenge:]): Ignore cancel, since we are ignoring
   13099 	the challenge.
   13100 
   13101 2004-07-09  Chris Blumenberg  <cblu (a] apple.com>
   13102 	
   13103 	Allowed my change for 3715785 to compile on Jaguar.
   13104 
   13105         Reviewed by kocienda.
   13106 
   13107         * WebCoreSupport.subproj/WebBridge.m:
   13108         (-[WebBridge canTargetLoadInFrame:]): don't use the DOM API since it doesn't exist on Jaguar, instead call the new domain method on the bridge
   13109 
   13110 2004-07-09  Ken Kocienda  <kocienda (a] apple.com>
   13111 
   13112         Reviewed by John
   13113 
   13114         * Plugins.subproj/npruntime.h: Updated license to lawyer-approved 
   13115         joint Apple-Mozilla BSD-style license.
   13116 
   13117 2004-07-08  Chris Blumenberg  <cblu (a] apple.com>
   13118 
   13119 	Fixed: <rdar://problem/3720728> REGRESSION (125.8-146): Crash moving mouse over plugin at manray-photo.com
   13120 	
   13121         Reviewed by john.
   13122 
   13123         * Plugins.subproj/WebBaseNetscapePluginView.m:
   13124         (-[WebBaseNetscapePluginView pluginScriptableObject]): don't call NPP_GetValue unless the plug-in implements it
   13125 
   13126 2004-07-08  Chris Blumenberg  <cblu (a] apple.com>
   13127 
   13128 	Fixed: <rdar://problem/3706296> VIP: ifilm.com crashing reproducibly with Safari
   13129 
   13130         Reviewed by kocienda.
   13131 
   13132         * Plugins.subproj/WebNetscapePluginPackage.m:
   13133         (-[WebNetscapePluginPackage launchRealPlayer]): don't release a NULL appURL
   13134 
   13135 2004-07-08  Chris Blumenberg  <cblu (a] apple.com>
   13136 
   13137 	Fixed: <rdar://problem/3650140> reproducible assertion failure going to plugin page with JavaScript disabled
   13138 
   13139         Reviewed by john.
   13140 
   13141         * Plugins.subproj/WebBaseNetscapePluginView.m:
   13142         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): don't call NPP_NewStream and other stream methods if there is no JS result to deliver. This is what Mozilla does.
   13143         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Return NPERR_GENERIC_ERROR if JS is disabled. This is what Mozilla does.
   13144 
   13145 === Safari-151 ===
   13146 
   13147 2004-07-07  Trey Matteson  <trey (a] apple.com>
   13148 
   13149 	3719051 - Safari doesn't update form inputs when a page was refreshed by javascript window.location
   13150 	... and at least 5 other cases in Radar
   13151 
   13152 	Very similar problem to the Harvard PIN bug.  We need to be sure
   13153 	to not carry any state over when we are processing a client
   13154 	redirect, which reuses the same WebHistoryItem.
   13155 
   13156         Reviewed by John.
   13157 
   13158         * WebView.subproj/WebFrame.m:
   13159         (-[WebFrame _transitionToCommitted:]):  Comment
   13160         (-[WebFrame _opened]):  Clear form and scroll state on client redirect.
   13161 
   13162 2004-07-06  Chris Blumenberg  <cblu (a] apple.com>
   13163 
   13164 	Fixed: <rdar://problem/3715785> multiple frame injection vulnerability reported by Secunia, affects almost all browsers
   13165 	
   13166         Reviewed by john, trey, kocienda.
   13167 
   13168         * WebCoreSupport.subproj/WebBridge.m:
   13169         (-[WebBridge canTargetLoadInFrame:]): new method, return YES if the requesting frame is local, the target frame is an entire window or if the domain of the parent of the targeted frame equals this domain
   13170         (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): call canTargetLoadInFrame: to make sure we can load the request
   13171         (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
   13172 
   13173 2004-07-06  John Sullivan  <sullivan (a] apple.com>
   13174 
   13175         Reviewed by Trey.
   13176 
   13177         - fixed <rdar://problem/3717147> folder icon used for error page in back/forward 
   13178         menu when iTunes is not installed
   13179 
   13180         * WebView.subproj/WebFrame.m:
   13181         (-[WebFrame _transitionToCommitted:]):
   13182         When displaying the error page for an unreachable URL, leave the requested URL
   13183         in the WebHistoryItem; don't clobber it with a bogus one that represents the
   13184         error page. This not only avoids the wrong-icon problem, but should also help
   13185         in cases where an unreachable URL becomes reachable later on.
   13186 
   13187 2004-07-06  Trey Matteson  <trey (a] apple.com>
   13188 
   13189 	3716053 - www.theage.com.au has extra back/forward items due to ads
   13190 
   13191 	The real change was in WebKit.  Here was are just renaming a method and folding
   13192 	all the WebFrameLoadTypeOnLoadEvent uses to be WebFrameLoadTypeInternal, since there
   13193 	was never any difference anyway.
   13194 
   13195         Reviewed by Richard
   13196 
   13197         * WebCoreSupport.subproj/WebBridge.m:
   13198         (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):  rename part of the method.
   13199         * WebView.subproj/WebFrame.m:  Nuke WebFrameLoadTypeOnLoadEvent.
   13200         (-[WebFrame _transitionToCommitted:]):
   13201         (-[WebFrame _checkLoadCompleteForThisFrame]):
   13202         (-[WebFrame _loadItem:withLoadType:]):
   13203         (-[WebFrame _itemForRestoringDocState]):
   13204         * WebView.subproj/WebFramePrivate.h:
   13205 
   13206 2004-07-06  Ken Kocienda  <kocienda (a] apple.com>
   13207 
   13208         Reviewed by Trey
   13209         
   13210         Only register the editing delegate for those notifications for which it implements the callbacks.
   13211 
   13212         * WebView.subproj/WebView.m:
   13213         (-[WebView registerForEditingDelegateNotification:selector:]):
   13214         (-[WebView setEditingDelegate:]):
   13215 
   13216 2004-07-06  Trey Matteson  <trey (a] apple.com>
   13217 
   13218 	3294652 - Failed drag of links doesn't slide back
   13219 
   13220 	The only reason for this is that because of some hacks, we lie to
   13221 	AK about the drag image offset, which means we slide back to
   13222 	slightly the wrong place.  But it's very minor, so we should
   13223 	just fix it.
   13224 
   13225         Reviewed by Ken.
   13226 
   13227         * WebView.subproj/WebHTMLView.m:
   13228         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
   13229 	Ask for slideback.
   13230 
   13231 2004-07-02  Darin Adler  <darin (a] apple.com>
   13232 
   13233         Reviewed by Dave.
   13234 
   13235         - fixed problem where tabsToLinks and privateBrowsingEnabled did not work with non-
   13236           standard WebPreferences objects
   13237 
   13238         * WebView.subproj/WebPreferences.m:
   13239         (-[WebPreferences _valueForKey:]): New helper.
   13240         (-[WebPreferences _stringValueForKey:]): Use _valueForKey.
   13241         (-[WebPreferences _integerValueForKey:]): Use _valueForKey.
   13242         (-[WebPreferences _boolValueForKey:]): Use _valueForKey.
   13243         (-[WebPreferences tabsToLinks]): Use _boolValueForKey; this is the bug fix.
   13244         (-[WebPreferences privateBrowsingEnabled]): Ditto.
   13245         (+[WebPreferences _setIBCreatorID:]): Use copy instead of retain for keeping an NSString.
   13246 
   13247 2004-07-01  Trey Matteson  <trey (a] apple.com>
   13248 
   13249 	3556159 - Crashes in -[WebFrame(WebPrivate) _transitionToCommitted:] at www.mastercardbusiness.com
   13250 
   13251 	We know from the line number of the crash that it is due to [self parentFrame]==nil.
   13252 
   13253 	Looking at the HTML and that of the related bugs, they do special stuff with onload
   13254 	handlers.  It is no longer repro, presumably because the includes JS files changed,
   13255 	as the bugs only included the top level HTML.  I suspect that the problem is that the
   13256 	WebFrameLoadTypeOnLoadEvent case was added, and in some weird sequence specific to
   13257 	MasterCard, they hit a case where we would be in WebFrameLoadTypeOnLoadEvent mode but
   13258 	not have a parent frame.
   13259 
   13260 	So we guard in the code against hitting a nil parentFrame, and log an error just in
   13261 	case this ever crops up again and we can learn more about it.
   13262 
   13263         Reviewed by Richard.
   13264 
   13265         * WebView.subproj/WebFrame.m:
   13266         (-[WebFrame _transitionToCommitted:]):  Guard against nil parentFrame.
   13267 
   13268 2004-07-01  John Sullivan  <sullivan (a] apple.com>
   13269 
   13270         Reviewed by Trey.
   13271         
   13272         - fixed these bugs:
   13273         <rdar://problem/3709110> REGRESSION (Tiger): Pressing Tab key to move focus 
   13274         onto links skips every other link
   13275         <rdar://problem/3692576> focus ring is in odd place after clicking RSS button 
   13276         with "Tab to links" enabled
   13277         
   13278         WebHTMLView has some trickery by which we advance the focused link when nextKeyView
   13279         or previousKeyView is called within nextValidKeyView or previousValidKeyView. This
   13280         broke in Tiger because AppKit now (sometimes at least) calls nextKeyView more than
   13281         once within nextValidKeyView. Fixed 3709110 by making sure we only advance the focus 
   13282         once within a call to nextValidKeyView or previousValidKeyView.
   13283         
   13284         Also, this same trickery didn't work right with hidden views. Fixed 3692576 by checking
   13285         whether the view is hidden and bypassing the focus-moving trickery in that case.
   13286 
   13287         * WebView.subproj/WebHTMLViewInternal.h:
   13288         renamed inNextValidKeyView -> nextKeyViewAccessShouldMoveFocus
   13289         
   13290         * WebView.subproj/WebHTMLView.m:
   13291         (-[WebHTMLView nextKeyView]):
   13292         now clears nextKeyViewAccessShouldMoveFocus
   13293         (-[WebHTMLView previousKeyView]):
   13294         ditto
   13295         (-[WebHTMLView nextValidKeyView]):
   13296         now doesn't set focus-moving trigger ivar if view is hidden or has hidden ancestor
   13297         (-[WebHTMLView previousValidKeyView]):
   13298         ditto
   13299 
   13300 2004-06-30  Trey Matteson  <trey (a] apple.com>
   13301 
   13302 	Dragging within a web view should be allowed to start when the window isn't key.
   13303 
   13304 	A few months ago, Chris made this work, but it relied on the fact that all dragging
   13305 	was done in WebKit.  When WebCore got involved in dragging, it was broken.  Now we
   13306 	have a new scheme that gets it working again that properly involves WebCore.
   13307 
   13308 	The general idea is that when AK asks us whether to accept the first mouse and do
   13309 	"delayed window ordering", we must consult WC to see if we might start a drag.  In
   13310 	addition, instead of these drags in non-active windows being started as a special
   13311 	case in WK, they go through the normal WK-WC drag machinery.  Finally to work in
   13312 	frames we have to drill to the deepest hit view in acceptsFirstMouse, because previous
   13313 	hacks to hitTest make the top-most WebHTMLView field all events for its view tree
   13314 	(which leads to it fielding all acceptFirstMouse messages too).
   13315 
   13316         Reviewed by John.
   13317 
   13318         * WebCoreSupport.subproj/WebBridge.m:
   13319         (-[WebBridge mayStartDragAtEventLocation:]):  Glue change for new arg type.
   13320         * WebView.subproj/WebHTMLView.m:
   13321         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
   13322 	firstMouseDownEvent ivar is no longer needed.
   13323         (-[WebHTMLView _mayStartDragAtEventLocation:]):  Receives a location instead of a drag
   13324 	event, since we need to do this work when we have no drag event.  This means the
   13325 	check of the delay for text dragging is moved down to WebCore.
   13326         (-[WebHTMLView acceptsFirstMouse:]):  Respond based on whether we might do a drag.
   13327 	This includes drilling to the deepest view the event hits, whereas we used to only
   13328 	respond considering the topmost WebHTMLView.
   13329         (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):  Ditto.
   13330         (-[WebHTMLView mouseDown:]):  Get rid of special case where some activating
   13331 	mouseDown events weren't sent to WC.  We need to go through the whole pipeline
   13332 	now to get a drag started properly.
   13333         (-[WebHTMLView mouseDragged:]):  Ditto, let WC start the drag.
   13334         (-[WebHTMLView mouseUp:]):  firstMouseDownEvent ivar is no longer needed.
   13335         * WebView.subproj/WebHTMLViewInternal.h:
   13336         * WebView.subproj/WebHTMLViewPrivate.h:
   13337 
   13338 2004-06-25  Trey Matteson  <trey (a] apple.com>
   13339 
   13340 	Added new utility method.
   13341 
   13342         Reviewed by John.
   13343 
   13344         * WebView.subproj/WebFrame.m:
   13345         (-[WebFrame _isDescendantOfFrame:]):   New code.
   13346         * WebView.subproj/WebFramePrivate.h:
   13347 
   13348 2004-06-24  Richard Williamson   <rjw (a] apple.com>
   13349 
   13350 		Fixed <rdar://problem/3710313>: CGContext not zeroed when WebImageRenderer is copied
   13351 		The context ivar of WebImageRenderer wasn't being nil when the object was copied.
   13352 
   13353         Reviewed by Darin.
   13354 
   13355         * WebCoreSupport.subproj/WebImageRenderer.m:
   13356         (-[WebImageRenderer copyWithZone:]):
   13357         (-[WebImageRenderer dealloc]):
   13358         (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
   13359 
   13360 2004-06-24  Trey Matteson  <trey (a] apple.com>
   13361 
   13362 	3672725 - Assertion failure in URLCompletion code with particular set of bookmarks
   13363 
   13364 	Problem was caused by a URL with unescaped unicodes getting into
   13365 	the Bookmarks file, presumably from import from IE.  We now test
   13366 	for this case and convert the data on the way in as if it were
   13367 	user-entered.
   13368 
   13369         Reviewed by John and Darin.
   13370 
   13371         * History.subproj/WebHistoryItem.m:
   13372         (-[WebHistoryItem initFromDictionaryRepresentation:]):
   13373 
   13374 2004-06-24  Trey Matteson  <trey (a] apple.com>
   13375 
   13376 	3704950	drag image in DB ConfigBar has horizontal graphics turd	WebCore JavaScript
   13377 
   13378 	When we generate a drag image (or a selection image too, for that matter) we
   13379 	translate the CTM using a CG call.  Later, WebImageRenderer adjusts the pattern
   13380 	phase based on the CTM of the focused view, which doesn't include our translate.
   13381 	So we must inform WebKit about the additional phase adjustment.
   13382 
   13383         Reviewed by Richard
   13384 
   13385         * WebCoreSupport.subproj/WebGraphicsBridge.h:
   13386         * WebCoreSupport.subproj/WebGraphicsBridge.m:
   13387         (-[WebGraphicsBridge setAdditionalPatternPhase:]):  New trivial setter.
   13388         (-[WebGraphicsBridge additionalPatternPhase]):      ...and getter.
   13389         * WebCoreSupport.subproj/WebImageRenderer.m:
   13390         (-[WebImageRenderer tileInRect:fromPoint:context:]):  Take any additional phase
   13391 	adjustment into account when setting phase.
   13392 
   13393 2004-06-24  Trey Matteson  <trey (a] apple.com>
   13394 
   13395 	3693420 - onbeforecut and onbeforepaste need real implementaion
   13396 
   13397         Reviewed by Chris.
   13398 
   13399         * WebView.subproj/WebHTMLView.m:
   13400         (-[WebHTMLView validateUserInterfaceItem:]):  Check with WebCore
   13401 	to see if cut, copy, paste should be enabled.
   13402 
   13403 2004-06-24  John Sullivan  <sullivan (a] apple.com>
   13404 
   13405         Reviewed by Darin.
   13406         
   13407         - fixed <rdar://problem/3706792> 8A161: Choosing text encoding for 
   13408         error page opens finder window!?
   13409 
   13410         * WebView.subproj/WebFrame.m:
   13411         (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):
   13412         take unreachableURL into account
   13413 
   13414 2004-06-23  Richard Williamson   <rjw (a] apple.com>
   13415 
   13416 	Implemented changes for latest npruntime.h.
   13417 	Made npruntime.h public.
   13418 		
   13419         Reviewed by Chris.
   13420 
   13421         * Plugins.subproj/WebBaseNetscapePluginView.h:
   13422         * Plugins.subproj/WebBaseNetscapePluginView.m:
   13423         (-[WebBaseNetscapePluginView pluginScriptableObject]):
   13424         (-[WebBaseNetscapePluginView forceRedraw]):
   13425         (-[WebBaseNetscapePluginView getVariable:value:]):
   13426         * Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
   13427         * Plugins.subproj/WebNetscapePluginPackage.m:
   13428         (-[WebNetscapePluginPackage load]):
   13429         * Plugins.subproj/npapi.h:
   13430         * Plugins.subproj/npapi.m:
   13431         (NPN_GetValue):
   13432         * Plugins.subproj/npfunctions.h:
   13433         * Plugins.subproj/npruntime.h:
   13434         * WebKit.pbproj/project.pbxproj:
   13435 
   13436 2004-06-21  Darin Adler  <darin (a] apple.com>
   13437 
   13438         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
   13439 
   13440 2004-06-21  Chris Blumenberg  <cblu (a] apple.com>
   13441 
   13442 	Made WebKitErrorDescriptionPlugInCancelledConnection have its own description string
   13443 	(Not for software update branch)
   13444 
   13445         Reviewed by john.
   13446 
   13447         * English.lproj/Localizable.strings:
   13448         * Misc.subproj/WebKitErrors.m:
   13449 
   13450 2004-06-21  Chris Blumenberg  <cblu (a] apple.com>
   13451 
   13452 	Made WebKitErrorDescriptionPlugInCancelledConnection properly reuse an already localized string to avoid loc changes.
   13453 
   13454         Reviewed by john.
   13455 
   13456         * ChangeLog:
   13457         * Misc.subproj/WebKitErrors.m:
   13458 
   13459 2004-06-21  Chris Blumenberg  <cblu (a] apple.com>
   13460 
   13461 	Fixed: <rdar://problem/3701269> change in error handling behavior from 10.3.3 to 10.3.4 breaks unreleased Adobe PDF plug-in
   13462 
   13463         Reviewed by john.
   13464 
   13465         * Misc.subproj/WebKitErrors.m:
   13466         (registerErrors): register string for WebKitErrorPlugInCancelledConnection
   13467         * Misc.subproj/WebKitErrorsPrivate.h:
   13468         * Plugins.subproj/WebBaseNetscapePluginStream.h:
   13469         * Plugins.subproj/WebBaseNetscapePluginStream.m:
   13470         (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): use renamed WEB_REASON_PLUGIN_CANCELLED constant
   13471         (-[WebBaseNetscapePluginStream destroyStream]): ditto
   13472         * Plugins.subproj/WebNetscapePluginRepresentation.m:
   13473         (-[WebNetscapePluginRepresentation cancelWithReason:]): if the reason is WEB_REASON_PLUGIN_CANCELLED, cancel the load with WebKitErrorPlugInCancelledConnection
   13474         * Plugins.subproj/WebNetscapePluginStream.m:
   13475         (-[WebNetscapePluginStream cancelWithReason:]): ditto
   13476 
   13477 === Safari-146 ===
   13478 
   13479 2004-06-17  Richard Williamson   <rjw (a] apple.com>
   13480 
   13481 		Changed private headers to be pubic for npapi.h and npfunctions.h.  That
   13482 		API was approved but never marked as public in the project file.  This change does
   13483 		not make npruntime.h public, which contains the not yet approved changes
   13484 		for script-ability of netscape plugins.  Unfortunately, that API will not
   13485 		be public for WWDC.
   13486 				
   13487         Reviewed by Chris.
   13488 
   13489         * WebKit.pbproj/project.pbxproj:
   13490 
   13491 2004-06-17  Trey Matteson  <trey (a] apple.com>
   13492 
   13493 	3698514 - coordinates in ondragstart and ondrag events are wrong
   13494 
   13495 	This part fixes the ondrag coords.  I thought Cocoa passed us the mouse location
   13496 	in draggedImage:movedTo:, but no, it's the position of the dragged image.
   13497 	WebCore needs the mouse location, so to calc that we must save away the
   13498 	offset of the mouse relative to the image when we kick off the drag.
   13499 
   13500         Reviewed by Maciej.
   13501 
   13502         * Misc.subproj/WebNSViewExtras.h:
   13503         * Misc.subproj/WebNSViewExtras.m:
   13504         (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): Add the ability
   13505 	to return the offset of the cursor wrt to the drag image, since this routine
   13506 	generates its own drag image and positions it.
   13507         * WebView.subproj/WebHTMLView.m:
   13508         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
   13509 	Calc the offset of the cursor wrt to the drag image in the myriad of ways
   13510 	that we kick off the drag.	
   13511         (-[WebHTMLView draggedImage:movedTo:]):  Adjust the location by the
   13512 	offset we save when we kicked off the drag.
   13513         (-[WebHTMLView draggedImage:endedAt:operation:]):  Ditto.
   13514         * WebView.subproj/WebHTMLViewInternal.h:
   13515         * WebView.subproj/WebImageView.m:
   13516         (-[WebImageView mouseDragged:]):  Pass nil for new arg, we don't care.
   13517 
   13518 2004-06-16  David Hyatt  <hyatt (a] apple.com>
   13519 
   13520 	In order to support truncation in Emerson, enhance pointToOffset so that it needn't include partial
   13521 	character glyphs (the left half of a glyph).
   13522 	
   13523         Reviewed by mjs
   13524 
   13525         * WebCoreSupport.subproj/WebTextRenderer.m:
   13526         (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]):
   13527         (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   13528         (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]):
   13529 
   13530 === Safari-145 ===
   13531 
   13532 2004-06-16  Darin Adler  <darin (a] apple.com>
   13533 
   13534         - fixed <rdar://problem/3696081> REGRESSION: <WebKit/CarbonUtils.h> doesn't build any more
   13535 
   13536         Reviewed by Trey.
   13537 
   13538         * Carbon.subproj/CarbonUtils.h: Fixed include. Need to include <ApplicationServices/ApplicationServices.h>
   13539         to get CGImageRef; can't include an individual header.
   13540 
   13541 2004-06-15  Richard Williamson   <rjw (a] apple.com>
   13542 
   13543 	Fixed <rdar://problem/3695875>: Objective-C instances that are exported to JavaScript are too promiscuous
   13544 	
   13545 	Flip the policy for exposing Objective-C methods and properties.
   13546 	
   13547 	Reviewed by Trey.
   13548 	
   13549 	* Plugins.subproj/WebPluginPackage.m:
   13550 	(+[NSObject isSelectorExcludedFromWebScript:]):  Just return YES.
   13551 	(+[NSObject isKeyExcludedFromWebScript:]):  Just return YES.
   13552 
   13553 2004-06-15  Trey Matteson  <trey (a] apple.com>
   13554 
   13555 	3639321 - Harvard PIN authentication ends up sending PIN as clear text with POST action
   13556 
   13557 	When going back/forward to an item, if we went there originally via a POST, 
   13558 	we ask the user about rePOSTing, and if they say yes, we resend the POST. 
   13559 	This rePOST case is triggered by the form data that we saved on the b/f item.
   13560 	In the case of this bug, the overall navigation was accomplished by a POST,
   13561 	then a redirect, causing a GET.  When a load of type redirect achieves the Committed
   13562 	stage, we replace the current URL in the b/f item with the new URL (instead of
   13563 	adding a new item to the b/f list).
   13564 
   13565 	The bug is that at the same time we should also update the form data in
   13566 	the b/f item to match that of the new request.  I think this will normally
   13567 	mean nil'ing it out, unless there's some way for the result of the redirect
   13568 	to be another POST.
   13569  
   13570 	The security leak occurred because we did not clear the form data on the item,
   13571 	so when going back or forward to the page, we would go into the rePOSTing code,
   13572 	even though we eventually reached that page via a GET (caused by the redirect).
   13573 	So we would do a POST to the redirect URL containing the private data sent in
   13574 	the original POST.
   13575 
   13576         Reviewed by mjs and rjw.
   13577 
   13578         * History.subproj/WebHistoryItem.m:
   13579         (-[WebHistoryItem _setFormInfoFromRequest:]):  New method, just wraps 3 old set methods.
   13580         (-[WebHistoryItem formData]):  Diff being dumb, no change.
   13581         (-[WebHistoryItem formContentType]):  Ditto
   13582         (-[WebHistoryItem formReferrer]): Ditto
   13583         * History.subproj/WebHistoryItemPrivate.h:
   13584         * WebView.subproj/WebFrame.m:
   13585         (-[WebFrame _createItem:]):  Call new WebHistoryItem method - no change in real behavior
   13586         (-[WebFrame _transitionToCommitted:]):  Clear out the form data at the key time, to fix the bug.
   13587 
   13588 2004-06-15  Chris Blumenberg  <cblu (a] apple.com>
   13589 
   13590 	Fixed: <rdar://problem/3695724> WebKit plug-ins should only have to implement plugInViewWithArguments:
   13591 
   13592         Reviewed by rjw.
   13593 
   13594         * ChangeLog:
   13595         * Plugins.subproj/WebPluginViewFactory.h: mention that plugInViewWithArguments is required
   13596         * WebView.subproj/WebFrame.m:
   13597         (-[WebFrame _reloadForPluginChanges]): check for plugInViewWithArguments: not webPlugInInitialize
   13598         * WebView.subproj/WebHTMLView.m:
   13599         (-[WebHTMLView addSubview:]): ditto
   13600 
   13601 2004-06-15  Trey Matteson  <trey (a] apple.com>
   13602 
   13603 	3695240 - pasting plain text with newlines in it turns them into spaces
   13604 
   13605 	Easy fix, we just need to consume the incoming data as text instead of markup.
   13606 
   13607         Reviewed by John and Darin.
   13608 
   13609         * WebView.subproj/WebHTMLView.m:
   13610         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]):
   13611 
   13612 2004-06-15  Darin Adler  <darin (a] apple.com>
   13613 
   13614         - fixed crash introduced by my earlier change
   13615 
   13616         * WebCoreSupport.subproj/WebImageRenderer.m:
   13617         (-[WebImageContext dealloc]): Set _cgsContext to 0 before calling super as before.
   13618         (-[WebImageContext finalize]): Ditto.
   13619 
   13620 2004-06-14  Darin Adler  <darin (a] apple.com>
   13621 
   13622         Reviewed by Maciej.
   13623 
   13624         - fixed some things for GC that Patrick missed, or that happened after the branch
   13625 
   13626         * Carbon.subproj/HIWebView.m:
   13627         (HIWebViewConstructor): Use CFRetain instead of retain.
   13628         (HIWebViewDestructor): Use CFRelease instead of release.
   13629         * Misc.subproj/WebFileDatabase.m:
   13630         (-[WebFileDatabase initWithPath:]): Use release instead of dealloc.
   13631         * WebCoreSupport.subproj/WebImageRenderer.m:
   13632         (-[WebImageContext finalize]): Had [super dealloc] here by mistake; change to [super finalize].
   13633         * WebCoreSupport.subproj/WebTextRenderer.m:
   13634         (-[WebTextRenderer finalize]): Added.
   13635         * WebView.subproj/WebDebugDOMNode.m:
   13636         (-[WebDebugDOMNode initWithWebFrameView:]): Use release instead of dealloc.
   13637         * WebView.subproj/WebRenderNode.m:
   13638         (-[WebRenderNode initWithWebFrameView:]): Use release instead of dealloc.
   13639 
   13640 2004-06-15  Trey Matteson  <trey (a] apple.com>
   13641 
   13642 	Fix ASSERT/crash we get sometimes when dragging link images.  Turns
   13643 	out there was an uninitialized variable for the image size,
   13644 	so at random we would try to create huge images that could not
   13645 	be focused.
   13646 	
   13647         Reviewed by Maciej and Darin.
   13648 
   13649         * WebView.subproj/WebHTMLView.m:
   13650         (-[WebHTMLView _dragImageForLinkElement:]):  Trivial fix to
   13651 	not use += with uninited variable.
   13652 
   13653 2004-06-14  Darin Adler  <darin (a] apple.com>
   13654 
   13655         Reviewed by me, code changes by Patrick Beard.
   13656 
   13657         - fixed <rdar://problem/3671507>: (WebKit should adopt GC changes and compile with GC enabled)
   13658 
   13659         * WebKit.pbproj/project.pbxproj: Added WebNSObjectExtras.h.
   13660         * Misc.subproj/WebNSObjectExtras.h: Added. Includes WebMakeCollectable, a cover for
   13661         CFMakeCollectable that returns type id, for less casting, and works on Panther as well
   13662         as Tiger. Also declares finalize in NSObject so we can call super without warnings on Panther.
   13663 
   13664         * Carbon.subproj/CarbonWindowAdapter.m: Fixed header and includes a bit.
   13665         (-[CarbonWindowAdapter finalize]): Added.
   13666         * History.subproj/WebBackForwardList.m:
   13667         (-[WebBackForwardList dealloc]): Got count outside loop.
   13668         (-[WebBackForwardList finalize]): Added.
   13669         * History.subproj/WebHistoryItem.m:
   13670         (-[WebHistoryItem finalize]): Added.
   13671         * Misc.subproj/WebFileDatabase.m:
   13672         (-[WebFileDatabase _createLRUList:]): Use release on Panther, drain on Tiger.
   13673         (+[WebFileDatabase _syncLoop:]): Ditto.
   13674         (-[WebFileDatabase dealloc]): Removed, since we never deallocate objects of this class, and
   13675         the method was untested.
   13676         * Misc.subproj/WebKitErrors.m: (registerErrors): Use release on Panther, drain on Tiger.
   13677         * Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): Use
   13678         WebMakeCollectable. Also fixed indenting.
   13679         * Misc.subproj/WebNSURLExtras.m:
   13680         (+[NSURL _web_URLWithData:relativeToURL:]): Use WebMakeCollectable.
   13681         (-[NSURL _web_URLWithLowercasedScheme]): Use WebMakeCollectable.
   13682         (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Change code to use CFRelease
   13683         to balance CFURLCreateStringByReplacingPercentEscapes CFString creation, not release.
   13684         * Plugins.subproj/WebBaseNetscapePluginStream.m:
   13685         (-[WebBaseNetscapePluginStream finalize]): Added.
   13686         * Plugins.subproj/WebBaseNetscapePluginView.m:
   13687         (-[WebBaseNetscapePluginView freeAttributeKeysAndValues]): Added. Shared code for dealloc and finalize.
   13688         (-[WebBaseNetscapePluginView dealloc]): Call freeAttributeKeysAndValues.
   13689         (-[WebBaseNetscapePluginView finalize]): Added.
   13690         (-[WebBaseNetscapePluginView requestWithURLCString:]): Changed so that CFString objects are
   13691         released with CFRelease, not release.
   13692         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Fixed storage leak in
   13693         error case. Made sure CFString object is released with CFRelease, not release.
   13694         (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
   13695         Another CFString that needed to a CFRelease, not a release.
   13696         (-[WebBaseNetscapePluginView status:]): Ditto.
   13697         * Plugins.subproj/WebBasePluginPackage.m:
   13698         (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): Changed code to
   13699         CFRelease a CFURLRef, instead of release.
   13700         (-[WebBasePluginPackage finalize]): Added.
   13701         * WebCoreSupport.subproj/WebBridge.m:
   13702         (-[WebBridge fini]): Added. Shared code for dealloc and finalize.
   13703         (-[WebBridge dealloc]): Call fini.
   13704         (-[WebBridge finalize]): Added.
   13705         * WebCoreSupport.subproj/WebGlyphBuffer.m:
   13706         (-[WebGlyphBuffer finalize]): Added.
   13707         * WebCoreSupport.subproj/WebImageRenderer.m:
   13708         (-[WebImageContext initWithBounds:context:]): Use CGContextRetain to avoid cast.
   13709         (-[WebImageContext dealloc]): Tweaked.
   13710         (-[WebImageContext finalize]): Added.
   13711         (-[WebImageRenderer finalize]): Added.
   13712         (-[WebPDFDocument finalize]): Added.
   13713         * WebView.subproj/WebDataProtocol.m:
   13714         (+[NSURL _web_uniqueWebDataURL]): Changed so that CFString object is released with
   13715         CFRelease, not release.
   13716         * WebView.subproj/WebDataSource.m:
   13717         (-[WebDataSourcePrivate dealloc]): Took non-release work out of here.
   13718         (-[WebDataSource dealloc]): Moved it here.
   13719         (-[WebDataSource finalize]): Added.
   13720         (-[WebDataSource isLoading]): Use release on Panther, drain on Tiger.
   13721         * WebView.subproj/WebFrame.m:
   13722         (-[WebFramePrivate dealloc]): Took non-release work out of here.
   13723         (-[WebFrame dealloc]): Moved it here.
   13724         (-[WebFrame finalize]): Added.
   13725         * WebView.subproj/WebFrameView.m:
   13726         (-[WebFrameView finalize]): Added.
   13727         * WebView.subproj/WebHTMLRepresentation.m:
   13728         (-[WebHTMLRepresentation finalize]): Added.
   13729         * WebView.subproj/WebHTMLView.m:
   13730         (-[WebHTMLViewPrivate dealloc]): Moved non-release work out of here.
   13731         (-[WebHTMLView dealloc]): Moved it here.
   13732         (-[WebHTMLView finalize]): Added.
   13733         * WebView.subproj/WebImageView.m:
   13734         (-[WebImageView finalize]): Added.
   13735         * WebView.subproj/WebMainResourceClient.m:
   13736         (-[WebMainResourceClient finalize]): Added.
   13737         * WebView.subproj/WebTextView.m:
   13738         (-[WebTextView finalize]): Added.
   13739         * WebView.subproj/WebView.m:
   13740         (-[WebView finalize]): Added.
   13741 
   13742 2004-06-14  Ken Kocienda  <kocienda (a] apple.com>
   13743 
   13744         Reviewed by Darin
   13745         
   13746         Fix for this bug:
   13747         
   13748         <rdar://problem/3693202> WebView.h header unnecessarily lists NSResponder methods it overrides
   13749 
   13750         * WebView.subproj/WebView.h: NSResponder overrides now gathered in a comment section.
   13751 
   13752 2004-06-13  Trey Matteson  <trey (a] apple.com>
   13753 
   13754 	Support for DHTML cut/copy/paste.
   13755 
   13756         Reviewed by Chris
   13757 
   13758         * WebView.subproj/WebHTMLView.m:
   13759         (-[WebHTMLView copy:]):  Give DHTML first crack at executing the command.
   13760         (-[WebHTMLView cut:]):  Ditto
   13761         (-[WebHTMLView paste:]):  Ditto
   13762 
   13763 2004-06-14  Chris Blumenberg  <cblu (a] apple.com>
   13764 
   13765 	Fixed: <rdar://problem/3674456> make new drag & drop API compatible with DHTML dragging
   13766 
   13767         Reviewed by trey.
   13768 
   13769         * WebView.subproj/WebHTMLView.m:
   13770         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): tweak
   13771         * WebView.subproj/WebUIDelegate.h: removed old, added new methods
   13772         * WebView.subproj/WebUIDelegatePrivate.h: moved new methods to public header
   13773         * WebView.subproj/WebView.h: removed old, added new methods
   13774         * WebView.subproj/WebView.m: moved methods around
   13775         (-[WebView moveDragCaretToPoint:]): moved
   13776         (-[WebView removeDragCaret]): moved
   13777         (-[WebView _bridgeAtPoint:]): moved
   13778         (-[WebView editableDOMRangeForPoint:]): moved
   13779         * WebView.subproj/WebViewInternal.h: add new internal method
   13780         * WebView.subproj/WebViewPrivate.h: moved new methods to public header
   13781 
   13782 2004-06-14  Trey Matteson  <trey (a] apple.com>
   13783 
   13784 	Use a different hack, as recommended by Kristin, to force the drag
   13785 	manager to exit a modal event wait it is in.  The hack is required
   13786 	to update the drag image on the fly.  Instead of posting a CG
   13787 	event we post at the AppKit level.
   13788 
   13789         Reviewed by Louch
   13790 
   13791         * WebCoreSupport.subproj/WebGraphicsBridge.m:
   13792         (-[WebGraphicsBridge setDraggingImage:at:]):
   13793 
   13794 2004-06-14  Chris Blumenberg  <cblu (a] apple.com>
   13795 
   13796 	Fixed:
   13797 	<rdar://problem/3692668> REGRESSION: delay when images and links
   13798 	<rdar://problem/3692675> links should drag when dragging images that are links when drag source action is WebDragSourceActionLink
   13799 
   13800         Reviewed by trey.
   13801 
   13802         * WebView.subproj/WebHTMLView.m:
   13803         (-[WebHTMLView _mayStartDragWithMouseDragged:]): cleaned up, only use selection delay for selections, allow links to be dragged when image dragging is disabled 
   13804 
   13805 2004-06-12  Trey Matteson  <trey (a] apple.com>
   13806 
   13807 	Small rearrangement to support dynamic changing of the drag
   13808 	image during DHTML dragging.
   13809 
   13810         Reviewed by John
   13811 
   13812         * WebCoreSupport.subproj/WebBridge.m:  Bridge glue moved to WebGraphicsBridge.
   13813         * WebCoreSupport.subproj/WebGraphicsBridge.m:
   13814         (FlipImageSpec):  Code moved from WebHTMLView.m.
   13815         (-[WebGraphicsBridge setDraggingImage:at:]):  Ditto.  Plus, we've added a gross
   13816 	event posting hack to force CG drag manager to update the display when we set
   13817 	the drag image.
   13818         * WebView.subproj/WebHTMLView.m:  Code moved to WebGraphicsBridge.
   13819         * WebView.subproj/WebHTMLViewPrivate.h:
   13820 
   13821 2004-06-11  Chris Blumenberg  <cblu (a] apple.com>
   13822 
   13823 	Implemented the remainder of the drag & drop API.
   13824 
   13825         Reviewed by trey.
   13826 
   13827         * Misc.subproj/WebNSPasteboardExtras.h:
   13828         * Misc.subproj/WebNSPasteboardExtras.m:
   13829         (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]): new
   13830         * Misc.subproj/WebNSViewExtras.h:
   13831         * Misc.subproj/WebNSViewExtras.m:
   13832         (-[NSView _web_dragImage:rect:event:pasteboard:source:]): simplified, this method now just creates a drag image and starts the drag
   13833         * WebCoreSupport.subproj/WebBridge.m:
   13834         (-[WebBridge allowDHTMLDrag:UADrag:]): now calls _delegateDragSourceActionMask on WebHTMLView to interact with the delegate
   13835         * WebView.subproj/WebDefaultUIDelegate.m:
   13836         * WebView.subproj/WebHTMLView.m:
   13837         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): call new delegate method, cleaned-up a little
   13838         (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): call drag caret methods on WebView instead of WebBridge so WebView can make sure only 1 HTML view has a drag cursor
   13839         (-[WebHTMLView draggingCancelledWithDraggingInfo:]): ditto
   13840         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): ditto
   13841         (-[WebHTMLView _delegateDragSourceActionMask]): new, gets drag source action mask from delegate
   13842         * WebView.subproj/WebHTMLViewInternal.h:
   13843         * WebView.subproj/WebImageView.h:
   13844         * WebView.subproj/WebImageView.m:
   13845         (-[WebImageView mouseDown:]): get the drag source action mask from the delegate
   13846         (-[WebImageView mouseDragged:]): inform the delegate of the drag
   13847         * WebView.subproj/WebView.m:
   13848         (-[WebViewPrivate dealloc]): assert that dragCursorBridge is nil
   13849         (-[WebView _close]): release dragCursorBridge
   13850         (-[WebView _bridgeAtPoint:]): new
   13851         (-[WebView editableDOMRangeForPoint:]): new API
   13852         (-[WebView moveDragCaretToPoint:]): new API
   13853         (-[WebView removeDragCaret]): new API
   13854         (-[WebView _frameViewAtWindowPoint:]): moved so this can be called internally
   13855         * WebView.subproj/WebViewInternal.h:
   13856         * WebView.subproj/WebViewPrivate.h:
   13857 
   13858 2004-07-10  Trey Matteson  <trey (a] apple.com>
   13859 
   13860 	Prep work for latest delegate API for dragging.  In addition, I also straightened out all
   13861 	the cases of DHTML setting a drag image or setting pasteboard data, and how that would
   13862 	override WebKit's default behavior (which follows how WinIE does things).
   13863 
   13864         Reviewed by Chris.
   13865 
   13866         * Misc.subproj/WebNSViewExtras.h:
   13867         * Misc.subproj/WebNSViewExtras.m:
   13868         (-[NSView _web_dragImage:archive:rect:URL:title:event:dragImage:dragLocation:writePasteboard:]):
   13869 	New args to allow WebCore override of dragImage and pasteboard data.
   13870         * WebCoreSupport.subproj/WebBridge.m:
   13871         (-[WebBridge allowDHTMLDrag:UADrag:]):  New method to return the drag action info to WC.
   13872         (-[WebBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
   13873 	Pass along new args.
   13874         * WebView.subproj/WebHTMLView.m:
   13875         (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
   13876 	Allow WebCore to override drag image and pasteboard data for any type of drag.
   13877         (-[WebHTMLView mouseDragged:]):  Pass NO for new args.
   13878         * WebView.subproj/WebHTMLViewPrivate.h:
   13879         * WebView.subproj/WebImageView.m:
   13880         (-[WebImageView mouseDragged:]):  Pass NO/nil for new args.
   13881 
   13882 === Safari-144 ===
   13883 
   13884 2004-06-10  Kevin Decker  <kdecker (a] apple.com>
   13885 
   13886         Reviewed by John.
   13887 
   13888         * WebView.subproj/WebResource.m:
   13889         (-[WebResource description]):
   13890             -added per request of cblu
   13891         (-[WebResource _response]):
   13892             -added this method to the header
   13893         (-[WebResource _stringValue]):
   13894             - gives the string value of the NSData representation
   13895         * WebView.subproj/WebResourcePrivate.h:
   13896 
   13897 2004-06-10  Darin Adler  <darin (a] apple.com>
   13898 
   13899         Reviewed by Ken.
   13900 
   13901         * WebCoreSupport.subproj/WebBridge.m: Removed undo-related methods.
   13902         (-[WebBridge undoManager]): Added.
   13903 
   13904         * WebKit.pbproj/.cvsignore: Updated for new Xcode files.
   13905 
   13906 2004-06-09  Ken Kocienda  <kocienda (a] apple.com>
   13907 
   13908         Reviewed by Darin
   13909 
   13910         Fix for this bug:
   13911         
   13912         <rdar://problem/3672088>: "Editable WebViews should maintain a selection even when they're not firstResponder"
   13913 
   13914         Add some code to determine whether a WebHTMLView should maintain an
   13915         inactive selection when the view is not first responder. Traditionally,
   13916         these views have not maintained such selections, clearing them when the
   13917         view was not first responder. However, for appls embedding this view as
   13918         an editing widget, it is desirable to act more like an NSTextView. For
   13919         now, however, the view only acts in this way when the web view is set to
   13920         be editable with -[WebView setEditable:YES]. This will maintain
   13921         traditional behavior for WebKit clients dating back to before this
   13922         change, and will likely be a decent switch for the long term, since
   13923         clients to ste the web view to be editable probably want it to act like
   13924         a "regular" Cocoa view in terms of its selection behavior.
   13925 
   13926         * WebView.subproj/WebHTMLView.m:
   13927         (-[WebHTMLView updateTextBackgroundColor]): Add code to tell whether the view is resigning first responder,
   13928         and if it is, use the inactive text background color.
   13929         (-[WebHTMLView maintainsInactiveSelection]): New helper which does checks to see if the new selection
   13930         behavior should be used, or whether we should continue with traditional WebKit behavior.
   13931         (-[WebHTMLView resignFirstResponder]): Call new maintainsInactiveSelection helper. If true,
   13932         do not clear the selection.
   13933         * WebView.subproj/WebHTMLViewInternal.h: Add resigningFirstResponder flag.
   13934 
   13935 2004-06-09  Chris Blumenberg  <cblu (a] apple.com>
   13936 
   13937 	Implemented drag destination portion of the new drag & drop API.
   13938 
   13939         Reviewed by trey.
   13940 
   13941         * WebView.subproj/WebDefaultUIDelegate.m:
   13942         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]): new delegate implementation
   13943         (-[WebDefaultUIDelegate webView:willPerformDragDestinationAction:forDraggingInfo:]): ditto
   13944         * WebView.subproj/WebDocumentInternal.h:
   13945         * WebView.subproj/WebHTMLView.m:
   13946         (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): handle the action mask
   13947         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): ditto
   13948         * WebView.subproj/WebUIDelegate.h:
   13949         * WebView.subproj/WebUIDelegatePrivate.h:
   13950         * WebView.subproj/WebView.m:
   13951         (-[WebView _dragOperationForDraggingInfo:]): call new delegate methods
   13952         (-[WebView performDragOperation:]): ditto
   13953         * WebView.subproj/WebViewInternal.h:
   13954         * WebView.subproj/WebViewPrivate.h:
   13955 
   13956 2004-06-09  Richard Williamson   <rjw (a] apple.com>
   13957 
   13958         Implemented PDF rendering for the drawImage() function
   13959         in Context2D.  This allows PDF files to be drawn in scaled
   13960         or rotated context without rasterization artifacts.
   13961         
   13962         The PDF image is currently NOT cached.  Caching can/will be added
   13963         as an optimization.  The hooks are already in place to flush
   13964         the cache as necessary.
   13965         
   13966         Reviewed by John.
   13967 
   13968         * WebCoreSupport.subproj/WebImageRenderer.h:
   13969         * WebCoreSupport.subproj/WebImageRenderer.m:
   13970         (-[WebImageRenderer dealloc]):
   13971         (-[WebImageRenderer _needsRasterFlush]):
   13972         (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):
   13973         (-[WebImageRenderer _PDFDocumentRef]):
   13974         (-[WebImageRenderer _PDFDraw]):
   13975         (-[WebImageRenderer _PDFDrawFromRect:toRect:operation:alpha:flipped:]):
   13976         (-[WebImageRenderer MIMEType]):
   13977         (ReleasePDFDocumentData):
   13978         (-[WebPDFDocument initWithData:]):
   13979         (-[WebPDFDocument dealloc]):
   13980         (-[WebPDFDocument documentRef]):
   13981         (-[WebPDFDocument mediaBox]):
   13982         (-[WebPDFDocument bounds]):
   13983         (-[WebPDFDocument adjustCTM:]):
   13984         (-[WebPDFDocument setCurrentPage:]):
   13985         (-[WebPDFDocument currentPage]):
   13986         (-[WebPDFDocument pageCount]):
   13987 
   13988         Added back check for old plugin API.
   13989         
   13990         * WebView.subproj/WebFrame.m:
   13991         (-[WebFrame _reloadForPluginChanges]):
   13992         * WebView.subproj/WebHTMLView.m:
   13993         (-[WebHTMLView addSubview:]):
   13994         * WebCoreSupport.subproj/WebBridge.m:
   13995         (-[WebBridge frameRequiredForMIMEType:URL:]):
   13996 
   13997 2004-06-08  Trey Matteson  <trey (a] apple.com>
   13998 
   13999 	In DHTML dragging there is no notion of registering for types, so we'd
   14000 	like to just pass all types down to WebCore.  It turns out that the per-type
   14001 	registration doesn't matter as far as the underlying drag service is
   14002 	concerned, so Cocoa is already getting called for any type.  We just hack and
   14003 	override a private method to ensure we accept any type.
   14004 
   14005         Reviewed by Chris.
   14006 
   14007         * WebView.subproj/WebView.m:
   14008         (-[WebView _hitTest:dragTypes:]):  We accept any drag type if it is within
   14009 	our view, without overriding a subview's decision.
   14010 
   14011 2004-06-08  Trey Matteson  <trey (a] apple.com>
   14012 
   14013 	A DHTML drag source can now change the dragging image during the drag.  Currently
   14014 	it may only be set to a static image.
   14015 
   14016         Reviewed by John
   14017 
   14018         * WebCoreSupport.subproj/WebBridge.m:
   14019         (-[WebBridge setDraggingImage:at:]):  Typical bridge glue.
   14020         * WebView.subproj/WebHTMLView.m:
   14021         (FlipImageSpec):  New utility, copied from AppKit.
   14022         (-[WebHTMLView _setDraggingImage:at:]):  Mostly copied from AppKit.  Sets the drag
   14023 	image using CG API.
   14024         * WebView.subproj/WebHTMLViewPrivate.h:
   14025 
   14026 2004-06-08  Chris Blumenberg  <cblu (a] apple.com>
   14027 
   14028 	Fixed: <rdar://problem/3640423>: (REGRESSION: can't paste text copied from web page into Excel (due to HTML on the pasteboard?))
   14029 
   14030         Reviewed by darin.
   14031 
   14032         * WebView.subproj/WebHTMLView.m:
   14033         (+[WebHTMLView _selectionPasteboardTypes]): don't include NSHTMLPboardType
   14034         (-[WebHTMLView _selectedArchive]): removed markup string parameter
   14035         (_selectionPasteboardTypes::if): don't put NSHTMLPboardType on the pasteboard
   14036         * WebView.subproj/WebHTMLViewPrivate.h:
   14037 
   14038 2004-06-07  Darin Adler  <darin (a] apple.com>
   14039 
   14040         Reviewed by Chris.
   14041 
   14042         - fixed <rdar://problem/3676761>: (REGRESSION: Text Bigger/Smaller commands are always disabled in TOT)
   14043 
   14044         * WebView.subproj/WebHTMLView.m: Add @interface declaration for WebTextSizing category
   14045         on WebHTMLView. This must have gotten lost somewhere along the way.
   14046 
   14047 2004-06-05  Trey Matteson  <trey (a] apple.com>
   14048 
   14049         WebKit no longer causes an endless stream of dragexit events to
   14050         occur at the DHTML level when hovering over an element that is
   14051         not accepting the drag.
   14052 
   14053         Reviewed by Chris
   14054 
   14055         * WebView.subproj/WebView.m:
   14056         (-[WebView _dragOperationForDraggingInfo:]):  If the potential target refuses
   14057         the item, don't turn around and immediately tell it to cancel the drag, which is
   14058         what leads to the exit event happening at the DOM level.  If the target just
   14059         refused the drag, it should not have anything it needs to cancel.
   14060 
   14061 2004-06-03  Trey Matteson  <trey (a] apple.com>
   14062 
   14063         DHTML dragging uses the Cocoa NSDragOperation on both the source and dest ends.
   14064         Most of the real work is in WebCore.
   14065 
   14066         Reviewed by rjw
   14067 
   14068         * WebCoreSupport.subproj/WebBridge.m:
   14069         (-[WebBridge startDraggingImage:at:operation:event:]):  Pass the drag op along.
   14070         * WebView.subproj/WebHTMLView.m:
   14071         (-[WebHTMLView _startDraggingImage:at:operation:event:]):  Remember drag op from WC.
   14072         (-[WebHTMLView mouseDragged:]):  Pass None for the op (alternate code path that will
   14073         be going away).
   14074         (-[WebHTMLView draggingSourceOperationMaskForLocal:]):  Use the WC drag op.
   14075         * WebView.subproj/WebHTMLViewInternal.h:
   14076         * WebView.subproj/WebHTMLViewPrivate.h:
   14077 
   14078 === Safari-143 ===
   14079 
   14080 2004-06-04  Chris Blumenberg  <cblu (a] apple.com>
   14081 
   14082         Fixed: <rdar://problem/3674921>: (can't drag an image from Desktop to Blot document)
   14083 
   14084         Reviewed by mjs.
   14085 
   14086         * WebView.subproj/WebDataSource.m:
   14087         (-[WebDataSource _imageElementWithImageResource:]): factored out from _documentFragmentWithImageResource:
   14088         (-[WebDataSource _documentFragmentWithImageResource:]): call _imageElementWithImageResource:
   14089         * WebView.subproj/WebDataSourcePrivate.h:
   14090         * WebView.subproj/WebHTMLView.m:
   14091         (-[WebHTMLView _imageExistsAtPaths:]): new
   14092         (-[WebHTMLView _documentFragmentWithPaths:]): new
   14093         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): handle NSFilenamesPboardType
   14094         (+[WebHTMLView _insertablePasteboardTypes]): include NSFilenamesPboardType
   14095         (-[WebHTMLView _canProcessDragWithDraggingInfo:]): check for NSFilenamesPboardType and check that the files are images
   14096 
   14097 2004-06-04  Richard Williamson   <rjw (a] apple.com>
   14098 
   14099         Fixed crasher from last checkin.
   14100         
   14101         Reviewed by Ken.
   14102 
   14103         * Plugins.subproj/WebPluginDatabase.m:
   14104         (+[WebPluginDatabase setAdditionalWebPlugInPaths:]):
   14105         (pluginLocations):
   14106 
   14107 2004-06-03  Richard Williamson   <rjw (a] apple.com>
   14108 
   14109         Add SPI to allow setting of plugin load path.
   14110                 Reviewed by Hyatt.
   14111 
   14112         * Plugins.subproj/WebPluginDatabase.h:
   14113         * Plugins.subproj/WebPluginDatabase.m:
   14114         (+[WebPluginDatabase setAdditionalWebPlugInPaths:]):
   14115         (pluginLocations):
   14116 
   14117 2004-06-03  Darin Adler  <darin (a] apple.com>
   14118 
   14119         Reviewed by Chris.
   14120 
   14121         - fixed <rdar://problem/3677038>: (Need SPI to get URL of favicon for a site)
   14122 
   14123         * Misc.subproj/WebIconDatabase.h: Add iconURLForURL: method.
   14124         * Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconURLForURL:]): Added.
   14125 
   14126 2004-06-02  Ken Kocienda  <kocienda (a] apple.com>
   14127 
   14128         Reviewed by John
   14129 
   14130         Fix for these bugs:
   14131         
   14132         <rdar://problem/3675806>: "Make API name change for -webViewShouldBeginEditing:inDOMRange:"
   14133         <rdar://problem/3675809>: "Make API name change for -webViewShouldEndEditing:inDOMRange:"
   14134 
   14135         New names are -webView:shouldBeginEditingInDOMRange: and -webView:shouldEndEditingInDOMRange:, 
   14136         respectively.
   14137 
   14138         * WebView.subproj/WebDefaultEditingDelegate.m:
   14139         (-[WebDefaultEditingDelegate webView:shouldBeginEditingInDOMRange:]):
   14140         (-[WebDefaultEditingDelegate webView:shouldEndEditingInDOMRange:]):
   14141         * WebView.subproj/WebEditingDelegate.h:
   14142         * WebView.subproj/WebView.m:
   14143         (-[WebView _shouldBeginEditingInDOMRange:]):
   14144         (-[WebView _shouldEndEditingInDOMRange:]):
   14145 
   14146 2004-06-02  Richard Williamson   <rjw (a] apple.com>
   14147 
   14148         conformsToProtocol:@protocol(WebPlugin) becomes
   14149         respondsToSelector:@selector(webPlugInInitialize) because
   14150         protocol was changed to an informal protocol.
   14151                 Reviewed by Kevin.
   14152 
   14153         * WebCoreSupport.subproj/WebBridge.m:
   14154         (-[WebBridge frameRequiredForMIMEType:URL:]):
   14155         * WebView.subproj/WebHTMLView.m:
   14156         (-[WebHTMLView addSubview:]):
   14157 
   14158 2004-06-01  Trey Matteson  <trey (a] apple.com>
   14159 
   14160         First cut at source side of DHTML dragging.  Most of the work is in WebCore.
   14161 
   14162         Reviewed by hyatt.
   14163 
   14164         * WebCoreSupport.subproj/WebBridge.m:
   14165         (-[WebBridge startDraggingImage:at:event:]):  Added image and loc args for
   14166         when WC tells WK to start a drag.
   14167         * WebView.subproj/WebHTMLView.m:
   14168         (-[WebHTMLView _startDraggingImage:at:event:]):  New image and loc args coming
   14169         from WebCore.  Hysteresis is moved to WC.
   14170         (-[WebHTMLView mouseDragged:]):  Call new _startDragging method.
   14171         (-[WebHTMLView draggedImage:movedTo:]):  Pass event to WC.
   14172         (-[WebHTMLView draggedImage:endedAt:operation:]):  Pass event to WC.
   14173         (-[WebHTMLView mouseUp:]):  Reset firstMouseDownEvent.  Fixes bug where
   14174         we would occasionally short-circuit WC event handling due to aliasing
   14175         problem with this event.
   14176         * WebView.subproj/WebHTMLViewPrivate.h:
   14177 
   14178 2004-06-02  Darin Adler  <darin (a] apple.com>
   14179 
   14180         Reviewed by John.
   14181 
   14182         - fixed problem with timing of delegate callbacks in the back/forward cache case
   14183 
   14184         * WebView.subproj/WebFrame.m:
   14185         (-[WebFrame _transitionToCommitted:]): Move code to indicate page is done loading in the
   14186         back/forward cache case from here ...
   14187         (-[WebFrame _opened]): ... to here.
   14188 
   14189 2004-06-01  Richard Williamson   <rjw (a] apple.com>
   14190 
   14191         Fixed deployment build warning.
   14192 
   14193         * WebCoreSupport.subproj/WebImageRenderer.m:
   14194         (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]):
   14195 
   14196 2004-06-01  Richard Williamson   <rjw (a] apple.com>
   14197 
   14198         Added support for drawImage and drawImageFromRect to <CANVAS>
   14199         Added support for composite attribute to <CANVAS>
   14200 
   14201         Reviewed by Trey.
   14202 
   14203         * WebCoreSupport.subproj/WebImageRenderer.h:
   14204         * WebCoreSupport.subproj/WebImageRenderer.m:
   14205         (-[WebImageContext initWithBounds:context:]):
   14206         (-[WebImageContext dealloc]):
   14207         (-[WebImageContext saveGraphicsState]):
   14208         (-[WebImageContext restoreGraphicsState]):
   14209         (-[WebImageContext isDrawingToScreen]):
   14210         (-[WebImageContext focusStack]):
   14211         (-[WebImageContext setFocusStack:]):
   14212         (-[WebImageContext bounds]):
   14213         (-[WebImageContext isFlipped]):
   14214         (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]):
   14215         (-[WebImageRenderer dealloc]):
   14216         (-[WebImageRenderer _beginRedirectContext:]):
   14217         (-[WebImageRenderer _endRedirectContext:]):
   14218         (-[WebImageRenderer _needsRasterFlush]):
   14219         (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):
   14220         (-[WebImageRenderer drawImageInRect:fromRect:]):
   14221         (-[WebImageRenderer flushRasterCache]):
   14222         (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
   14223         (-[WebImageRenderer tileInRect:fromPoint:context:]):
   14224         * WebCoreSupport.subproj/WebImageRendererFactory.m:
   14225         (-[WebImageRendererFactory imageRendererWithMIMEType:]):
   14226         (-[WebImageRendererFactory imageRendererWithName:]):
   14227         (-[WebImageRendererFactory CGCompositeOperationInContext:]):
   14228         (-[WebImageRendererFactory setCGCompositeOperation:inContext:]):
   14229         (-[WebImageRendererFactory setCGCompositeOperationFromString:inContext:]):
   14230 
   14231 2004-06-01  John Sullivan  <sullivan (a] apple.com>
   14232 
   14233         Reviewed by Trey.
   14234         
   14235         Work on text-align API. Marked these bugs fixed:
   14236         <rdar://problem/3655380>: (Editing:-alignCenter:methodunimplemented(WebKiteditingAPI))
   14237         <rdar://problem/3655381>: (Editing:-alignJustified:methodunimplemented(WebKiteditingAPI))
   14238         <rdar://problem/3655383>: (Editing:-alignLeft:methodunimplemented(WebKiteditingAPI))
   14239         <rdar://problem/3655384>: (Editing:-alignRight:methodunimplemented(WebKiteditingAPI))        
   14240         
   14241         in favor of opening this bug:
   14242         <rdar://problem/3675191>: (Editing: -alignLeft: and friends mostly implemented but not 
   14243         yet working (WebKit editing API))        
   14244 
   14245         * English.lproj/StringsNotToBeLocalized.txt:
   14246         updated for these changes
   14247         
   14248         * WebView.subproj/WebHTMLView.m:
   14249         (-[WebHTMLView changeDocumentBackgroundColor:]):
   14250         added a FIXME about why this is still not quite right
   14251         (-[WebHTMLView _alignSelectionUsingCSSValue:]):
   14252         new method, bottleneck for the various values
   14253         (-[WebHTMLView alignCenter:]):
   14254         call _alignSelectionUsingCSSValue:@"center"
   14255         (-[WebHTMLView alignJustified:]):
   14256         call _alignSelectionUsingCSSValue:@"justify"
   14257         (-[WebHTMLView alignLeft:]):
   14258         call _alignSelectionUsingCSSValue:@"left"
   14259         (-[WebHTMLView alignRight:]):
   14260         call _alignSelectionUsingCSSValue:@"right"
   14261 
   14262 2004-06-01  John Sullivan  <sullivan (a] apple.com>
   14263 
   14264         Reviewed by Ken.
   14265         
   14266         - fixed <rdar://problem/3655378>: (Editing:-changeDocumentBackgroundColor:
   14267         methodunimplemented(WebKiteditingAPI))
   14268         - made startSpeaking: actually work; previous implementation raised a DOMException
   14269 
   14270         * WebView.subproj/WebHTMLView.m:
   14271         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
   14272         added range parameter
   14273         (-[WebHTMLView _entireDOMRange]):
   14274         new convenience method
   14275         (-[WebHTMLView changeDocumentBackgroundColor:]):
   14276         now affects entire document, not just selected range, a la NSTextView
   14277         (-[WebHTMLView changeColor:]):
   14278         now passes in a range to _changeCSSColorUsingSelector:inRange:
   14279         (-[WebHTMLView startSpeaking:]):
   14280         now uses _entireDOMRange
   14281 
   14282 2004-06-01  Chris Blumenberg  <cblu (a] apple.com>
   14283 
   14284         Fixed: <rdar://problem/3661505>: (REGRESSION (Safari-140) can't drag standalone images more than once)
   14285 
   14286         Reviewed by john.
   14287 
   14288         * WebView.subproj/WebImageView.m:
   14289         (-[WebImageView mouseDown:]): set ignoringMouseDraggedEvents to NO. This line of code was deleted somehow.
   14290 
   14291 2004-06-01  John Sullivan  <sullivan (a] apple.com>
   14292 
   14293         Reviewed by Darin.
   14294         
   14295         - fixed <rdar://problem/3657003>: (HTML Editing: Color panel doesn't work)
   14296 
   14297         * WebView.subproj/WebHTMLView.m:
   14298         (-[WebHTMLView _colorPanelColorAsStyleUsingSelector:]):
   14299         new method, returns a DOMCSSStyleDeclaration *
   14300         (-[WebHTMLView _changeCSSColorUsingSelector:]):
   14301         new method, sets a color-related style attribute on the selection
   14302         (-[WebHTMLView changeDocumentBackgroundColor:]):
   14303         call _changeCSSColorUsingSelector: with @selector(setBackgroundColor:)
   14304         (-[WebHTMLView changeColor:]):
   14305         call _changeCSSColorUsingSelector: with @selector(setColor:); also added
   14306         comments explaining why changeDocumentBackgroundColor: will never actually
   14307         be called until an AppKit code-incest mess is straighted out.
   14308 
   14309 2004-06-01  Ken Kocienda  <kocienda (a] apple.com>
   14310 
   14311         Reviewed by Darin
   14312 
   14313         * WebView.subproj/WebHTMLView.m:
   14314         (-[WebHTMLView _fontManagerOperationAsStyle]): Fixed typo in family-name code that caused
   14315         family names to match when they should not.
   14316 
   14317 2004-06-01  Chris Blumenberg  <cblu (a] apple.com>
   14318 
   14319         Made paste and drop ask the delegate before making any replacements.
   14320 
   14321         Reviewed by kocienda.
   14322 
   14323         * WebView.subproj/WebHTMLView.m:
   14324         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): renamed, now calls _shouldInsertFragment:replacingDOMRange:givenAction:
   14325         (-[WebHTMLView _shouldInsertFragment:replacingDOMRange:givenAction:]): new, asks delegate
   14326         (-[WebHTMLView concludeDragForDraggingInfo:]): now calls _shouldInsertFragment:replacingDOMRange:givenAction:
   14327         (-[WebHTMLView paste:]): call renamed _pasteWithPasteboard:allowPlainText:
   14328         (-[WebHTMLView pasteAsRichText:]): ditto
   14329 
   14330 2004-05-28  Darin Adler  <darin (a] apple.com>
   14331 
   14332         Reviewed by Maciej.
   14333 
   14334         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _fontManagerOperationAsStyle]):
   14335         First cut at figuring out what operation the font manager is doing without
   14336         digging into its private data structures.
   14337 
   14338 2004-05-28  Darin Adler  <darin (a] apple.com>
   14339 
   14340         Reviewed by Ken.
   14341 
   14342         - various editing-related improvements
   14343         - fixed <rdar://problem/3655366>: (Editing: -selectParagraph: method unimplemented (WebKit editing API))
   14344         - fixed <rdar://problem/3655367>: (Editing: -selectLine: method unimplemented (WebKit editing API))
   14345         - fixed <rdar://problem/3655369>: (Editing: -selectWord: method unimplemented (WebKit editing API))
   14346         - fixed <rdar://problem/3655392>: (Editing: -uppercaseWord: method unimplemented (WebKit editing API))
   14347         - fixed <rdar://problem/3655393>: (Editing: -lowercaseWord: method unimplemented (WebKit editing API))
   14348         - fixed <rdar://problem/3655394>: (Editing: -capitalizeWord: method unimplemented (WebKit editing API))
   14349 
   14350         * WebView.subproj/WebHTMLView.m:
   14351         (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): Removed the call to
   14352         ensureCaretVisible. This is now handled on the other side of the bridge.
   14353         (-[WebHTMLView moveDown:]): Changed to use WebSelectByLine granularity instead of
   14354         WebSelectDown direction.
   14355         (-[WebHTMLView moveDownAndModifySelection:]): Ditto.
   14356         (-[WebHTMLView moveUp:]): Ditto.
   14357         (-[WebHTMLView moveUpAndModifySelection:]): Ditto.
   14358         (-[WebHTMLView _expandSelectionToGranularity:]): Added.
   14359         (-[WebHTMLView selectParagraph:]): Implemented by calling _expandSelectionToGranularity.
   14360         (-[WebHTMLView selectLine:]): Ditto.
   14361         (-[WebHTMLView selectWord:]): Ditto.
   14362         (-[WebHTMLView _fontManagerOperationAsStyle]): Added. Placeholder for the job of figuring
   14363         out what style change to make based on NSFontManager.
   14364         (-[WebHTMLView changeFont:]): Implemented, but not really tested because guts are still
   14365         missing due to lack of above method.
   14366         (-[WebHTMLView insertTab:]): Removed the call to ensureCaretVisible.
   14367         (-[WebHTMLView insertNewline:]): Removed the call to ensureCaretVisible.
   14368         (-[WebHTMLView insertParagraphSeparator:]): Made this insert a newline for now.
   14369         (-[WebHTMLView _changeWordCaseWithSelector:]): Added.
   14370         (-[WebHTMLView uppercaseWord:]): Implemented by calling _changeWordCaseWithSelector.
   14371         (-[WebHTMLView lowercaseWord:]): Ditto.
   14372         (-[WebHTMLView capitalizeWord:]): Ditto.
   14373         (-[WebHTMLView deleteBackward:]): Removed the call to ensureCaretVisible.
   14374         (-[WebHTMLView checkSpelling:]): Put a pile of AppKit code in here as a placeholder.
   14375         (-[WebHTMLView startSpeaking:]): Use the new stringForRange: method instead of outerText.
   14376         That way we can handle cases where the entire document is selected.
   14377         (-[WebHTMLView insertText:]): Removed the call to ensureCaretVisible.
   14378 
   14379 2004-05-28  Chris Blumenberg  <cblu (a] apple.com>
   14380 
   14381         Fixed: <rdar://problem/3672129>: (selection deselects when clicking editable WebView in background window)
   14382 
   14383         Fixed this problem by using NSTextView's approach of only allowing dragging on first mouse down.
   14384 
   14385         Reviewed by john.
   14386 
   14387         * WebView.subproj/WebHTMLView.m:
   14388         (-[WebHTMLView acceptsFirstMouse:]): store the first mouse down
   14389         (-[WebHTMLView mouseDown:]): Don't tell WebCore about the first mouse down event since only dragging can occur on the first mouse down.
   14390         (-[WebHTMLView mouseDragged:]): Don't tell WebCore about the drags that occur after the first mouse down since only dragging can occur after the first mouse down.
   14391         * WebView.subproj/WebHTMLViewInternal.h:
   14392 
   14393 2004-05-28  Darin Adler  <darin (a] apple.com>
   14394 
   14395         * WebView.subproj/WebView.m: At Ken's suggestion, for better efficiency and safety,
   14396         use _cmd rather than explicit selector names in the forwarding methods.
   14397 
   14398 2004-05-28  Darin Adler  <darin (a] apple.com>
   14399 
   14400         Reviewed by Ken.
   14401 
   14402         - implemented a few more editing operations, moved code from WebView to WebHTMLView
   14403 
   14404         * WebCoreSupport.subproj/WebBridge.m:
   14405         (-[WebBridge respondToChangedContents]): Call _updateFontPanel on the WebHTMLView, not the WebView.
   14406         (-[WebBridge respondToChangedSelection]): Ditto.
   14407 
   14408         * WebView.subproj/WebHTMLView.m: Moved WebElementOrTextFilter class here from WebView and
   14409         gave it a prefix so it won't conflict with developers' class names.
   14410         (-[WebHTMLView _updateFontPanel]): Moved here from WebView.
   14411 
   14412         * WebView.subproj/WebView.m:
   14413         (-[WebView toggleSmartInsertDelete:]): Added.
   14414         (-[WebView toggleContinuousSpellChecking:]): Added.
   14415         (-[WebView isContinuousGrammarCheckingEnabled]): Added.
   14416         (-[WebView setContinuousGrammarCheckingEnabled:]): Added.
   14417         (-[WebView toggleContinuousGrammarChecking:]): Added.
   14418         (-[WebView setSmartInsertDeleteEnabled:]): Implemented. We have the flag now, although we
   14419         still don't actually have smart insert and delete implemented.
   14420         (-[WebView smartInsertDeleteEnabled]): Ditto.
   14421         (-[WebView setContinuousSpellCheckingEnabled:]): Implemented.
   14422         (-[WebView isContinuousSpellCheckingEnabled]): Implemented.
   14423         (-[WebView spellCheckerDocumentTag]): Implemented.
   14424         (-[WebView _preflightSpellCheckerNow:]): Added.
   14425         (-[WebView _preflightSpellChecker]): Added.
   14426         (-[WebView _continuousCheckingAllowed]): Added.
   14427 
   14428         * WebView.subproj/WebHTMLViewInternal.h: Added. We'll things here from WebHTMLViewPrivate so
   14429         they are internal to the framework, rather than SPI.
   14430         * WebKit.pbproj/project.pbxproj: Added WebHTMLViewInternal.h.
   14431         * WebView.subproj/WebHTMLViewPrivate.h: Moved WebHTMLViewPrivate into the internal header.
   14432         Despite its name, it's internal, not SPI.
   14433 
   14434         * WebView.subproj/WebViewPrivate.h: Moved WebViewPrivate into the internal header.
   14435         Despite its name, it's internal, not SPI. Added a number of new operations which should
   14436         be public API. We'll have to figure out what to do about API review and the WWDC deadline.
   14437         * WebView.subproj/WebViewInternal.h: Removed _updateFontPanel method.
   14438 
   14439         * English.lproj/StringsNotToBeLocalized.txt: Update.
   14440 
   14441 2004-05-27  Ken Kocienda  <kocienda (a] apple.com>
   14442 
   14443         Reviewed by John
   14444 
   14445         The font panel now updates correctly, reflecting the current selection. There may
   14446         still be some bugs and corner cases to handle, but this will work for a general
   14447         implementation of the feature.
   14448 
   14449         * WebView.subproj/WebView.m:
   14450         (+[ElementOrTextFilter filter]): Added. This filter will accept DOM elements and
   14451         text nodes and skip everything else. This filter is used when walking a selection
   14452         to determine the fonts in use.
   14453         (-[ElementOrTextFilter acceptNode:]): DOM node filter implementation method.
   14454         (-[WebView _fontFromStyle]): Removed, in lieu of new fontForCurrentPosition call on the bridge.
   14455         (-[WebView _updateFontPanel]): Reworked to use a TreeWalker instead of a NodeIterator. This
   14456         was done since the iterator must be rooted at the document root, but start iterating 
   14457         at the start of the selection. TreeWalker's setCurrentNode allows this to be done.
   14458 
   14459 2004-05-27  Kevin Decker  <kdecker (a] apple.com>
   14460 
   14461         * Plugins.subproj/WebScriptObject.h:
   14462 
   14463 2004-05-27  Kevin Decker  <kdecker (a] apple.com>
   14464 
   14465         Reviewed by Ken.
   14466         
   14467         - error messages (eg. from JavaScriptCore) sent to the bridge now 
   14468           get delievered to a new delegate method.  
   14469     
   14470         * WebCoreSupport.subproj/WebBridge.m:
   14471         (-[WebBridge addMessageToConsole:]):
   14472         * WebKit.pbproj/project.pbxproj:
   14473         * WebView.subproj/WebUIDelegatePrivate.h:
   14474 
   14475 === Safari-142 ===
   14476 
   14477 2004-05-27  Trey Matteson  <trey (a] apple.com>
   14478 
   14479         First cut at DHTML dragging, destination side.  Dragging text, files and URLs onto
   14480         elements works.  Type conversion from NSPasteboard to MIME types is hardwired.
   14481         No JS access yet to modifier keys, or operations mask.
   14482 
   14483         Reviewed by Chris.
   14484 
   14485         * WebView.subproj/WebHTMLView.m:
   14486         (-[WebHTMLView draggingUpdatedWithDraggingInfo:]): Call DHTML dragging via bridge.
   14487         (-[WebHTMLView draggingCancelledWithDraggingInfo:]): Ditto.
   14488         (-[WebHTMLView concludeDragForDraggingInfo:]): Ditto.
   14489         * WebView.subproj/WebHTMLViewPrivate.h:
   14490         * WebView.subproj/WebView.m:
   14491         (-[WebView _setWebKitDragRespondsToDragging:]):  New SPI for finer grained control than the
   14492         delegate currently has.
   14493         (-[WebView _webKitDragRespondsToDragging]): Ditto.
   14494         (-[WebView _commonInitializationWithFrameName:groupName:]):  Init new flag.
   14495         (-[WebView _dragOperationForDraggingInfo:]):  Comment.
   14496         * WebView.subproj/WebViewPrivate.h:
   14497 
   14498 2004-05-27  Darin Adler  <darin (a] apple.com>
   14499 
   14500         * WebView.subproj/WebFrameView.m: (-[WebFrameView _scrollVerticallyBy:]): Added comment.
   14501 
   14502 2004-05-27  Darin Adler  <darin (a] apple.com>
   14503 
   14504         Reviewed by Maciej.
   14505 
   14506         - fixed <rdar://problem/3667948>: (REGRESSION: Page Down key goes down two pages when smooth scrolling is on)
   14507 
   14508         * WebView.subproj/WebFrameView.m:
   14509         (-[WebFrameView _scrollVerticallyBy:]): Added return value to indicate if any scrolling was done.
   14510         This requires using secret AppKit methods; the public methods don't have a return value.
   14511         (-[WebFrameView _pageVertically:]): Added return value to indicate if any scrolling was done.
   14512         (-[WebFrameView scrollPageUp:]): Base call through to next responder on whether any scrolling was done,
   14513         using return value, rather than looking at new scroll position. This was the cause of the bug,
   14514         since with smooth scrolling no scrolling has happened yet when the function returns.
   14515         (-[WebFrameView scrollPageDown:]): Ditto.
   14516 
   14517         - removed temporary DOMDocument method from WebView
   14518 
   14519         * WebView.subproj/WebView.m:
   14520         (-[WebView computedStyleForElement:pseudoElement:]): Call getComputedStyle on the document that owns the
   14521         element rather than on the document that currently contains the selection.
   14522         (-[WebView _updateFontPanel]): Get the document from the DOM range rather than using the DOMDocument method.
   14523         (-[WebView styleDeclarationWithText:]): Change this method to not use the DOMDocument method, but do the same
   14524         job with inline code.
   14525 
   14526         * WebView.subproj/WebViewPrivate.h: Moved a recently-added category that is not SPI out of here.
   14527         * WebView.subproj/WebViewInternal.h: Moved the category in here. And removed the DOMDocument method from it.
   14528 
   14529         - other changes
   14530 
   14531         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
   14532 
   14533         * copy-webcore-files-to-webkit: Change tabs to spaces. Quiet the script down by
   14534         making it no longer echo each command or print messages about what it's doing by default.
   14535 
   14536 2004-05-27  Darin Adler  <darin (a] apple.com>
   14537 
   14538         Reviewed by Maciej.
   14539 
   14540         - moved to new symlink technique for embedding frameworks
   14541 
   14542         * WebKit.pbproj/project.pbxproj: Get rid of embed-frameworks build step
   14543         because we don't need it any more.
   14544 
   14545 2004-05-27  Darin Adler  <darin (a] apple.com>
   14546 
   14547         - fixed Deployment build
   14548 
   14549         * WebView.subproj/WebView.m: (-[WebView concludeDragOperation:]):
   14550         Got rid of ASSERT-only local variable.
   14551 
   14552 2004-05-26  Maciej Stachowiak  <mjs (a] apple.com>
   14553 
   14554         Reviewed by Dave.
   14555 
   14556         - fix further problems with Emerson feed: redirection for RSS feeds
   14557 
   14558         This is done by removing removing the calls to defer callbacks
   14559         while waiting for [... Maciej stopped typing here ...]
   14560 
   14561         * WebView.subproj/WebMainResourceClient.m:
   14562         (-[WebMainResourceClient continueAfterNavigationPolicy:formState:]):
   14563         (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]):
   14564         (-[WebMainResourceClient continueAfterContentPolicy:response:]):
   14565         (-[WebMainResourceClient checkContentPolicyForResponse:]):
   14566 
   14567 2004-05-26  Chris Blumenberg  <cblu (a] apple.com>
   14568 
   14569         Added and implemented proposed dragging API changes. These changes are necessary to make JS dragging work properly.
   14570 
   14571         Reviewed by trey.
   14572 
   14573         * WebView.subproj/WebDefaultUIDelegate.m:
   14574         (-[WebDefaultUIDelegate webView:shouldDetermineDragOperationForDraggingInfo:dragOperation:]): instead of calling back to the WebView to get the default drag operation, return YES. Return NO in order to return a custom drag operation. Removed element parameter since another new API provides a way to get that.
   14575         (-[WebDefaultUIDelegate webView:shouldProcessDragWithDraggingInfo:]): Removed element parameter since another new API provides a way to get that.
   14576         * WebView.subproj/WebDocumentInternal.h:
   14577         * WebView.subproj/WebHTMLView.m:
   14578         (-[WebHTMLView draggingUpdatedWithDraggingInfo:]): now returns a drag operation
   14579         (-[WebHTMLView draggingCancelledWithDraggingInfo:]): moved
   14580         * WebView.subproj/WebUIDelegatePrivate.h:
   14581         * WebView.subproj/WebView.m:
   14582         (-[WebView elementAtPoint:]): new proposed API
   14583         (-[WebView dragOperationForDraggingInfo:]): removed code from this API that should be removed
   14584         (-[WebView _dragOperationForDraggingInfo:]): call new API
   14585         (-[WebView concludeDragOperation:]): call new API
   14586 
   14587 2004-05-26  Darin Adler  <darin (a] apple.com>
   14588 
   14589         Reviewed by John.
   14590 
   14591         - moved HTML editing operations from WebView to WebHTMLView, leaving only forwarding machinery
   14592           at the WebView level
   14593 
   14594         - fixed <rdar://problem/3655412>: (Editing: -startSpeaking: method unimplemented (WebKit editing API))
   14595         - fixed <rdar://problem/3655414>: (Editing: -stopSpeaking: method unimplemented (WebKit editing API))
   14596         - fixed <rdar://problem/3655375>: (Editing: -pasteAsRichText: method unimplemented (WebKit editing API))
   14597 
   14598         * WebView.subproj/WebView.h: Added missing declaration of selectionAffinity. I think this
   14599         omission was an editorial mistake.
   14600 
   14601         * WebView.subproj/WebView.m:
   14602         (-[WebView searchFor:direction:caseSensitive:wrap:]): Use _frameForCurrentSelection directly,
   14603         since it no longer returns nil.
   14604         (-[WebView pasteboardTypesForSelection]): Use _frameForCurrentSelection instead of going through the bridge.
   14605         (-[WebView _frameForCurrentSelection]): Renamed from _currentFrame and changed to return main frame
   14606         rather than nil when called on WebView that has no current selection.
   14607         (-[WebView _bridgeForCurrentSelection]): Moved in file.
   14608         (-[WebView _updateFontPanel]): Removed the one call to _currentSelectionIsEditable here, since
   14609         it was the only one left in this file. Eventually this code will move to WebHTMLView.
   14610         (-[WebView _performResponderOperation:with:]): Name change.
   14611 
   14612         * WebView.subproj/WebDataSource.m: (-[WebDataSource _documentFragmentWithImageResource:]):
   14613         Build document fragment using DOM instead of composing HTML text.
   14614 
   14615         * WebView.subproj/WebHTMLView.m:
   14616         (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): Added allowPlainText boolean,
   14617         moved method into new location in file so it can be in the right category, changed link pasting
   14618         to use DOM instead of composing HTML text.
   14619         (-[WebHTMLView _replaceSelectionWithPasteboard:selectReplacement:allowPlainText:]): Added allowPlainText
   14620         boolean, moved method into new location in file so it can be in the right category.
   14621         (-[WebHTMLView concludeDragForDraggingInfo:]): Pass YES for allowPlainText.
   14622         (-[WebHTMLView keyDown:]): Set keyDownEvent field for use by workaround below.
   14623         (-[WebHTMLView centerSelectionInVisibleArea:]): Moved here from WebView.
   14624         (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): Ditto.
   14625         (-[WebHTMLView moveBackward:]): Ditto.
   14626         (-[WebHTMLView moveBackwardAndModifySelection:]): Ditto.
   14627         (-[WebHTMLView moveDown:]): Ditto.
   14628         (-[WebHTMLView moveDownAndModifySelection:]): Ditto.
   14629         (-[WebHTMLView moveForward:]): Ditto.
   14630         (-[WebHTMLView moveForwardAndModifySelection:]): Ditto.
   14631         (-[WebHTMLView moveLeft:]): Ditto.
   14632         (-[WebHTMLView moveLeftAndModifySelection:]): Ditto.
   14633         (-[WebHTMLView moveRight:]): Ditto.
   14634         (-[WebHTMLView moveRightAndModifySelection:]): Ditto.
   14635         (-[WebHTMLView moveToBeginningOfDocument:]): Ditto.
   14636         (-[WebHTMLView moveToBeginningOfLine:]): Ditto.
   14637         (-[WebHTMLView moveToBeginningOfParagraph:]): Ditto.
   14638         (-[WebHTMLView moveToEndOfDocument:]): Ditto.
   14639         (-[WebHTMLView moveToEndOfLine:]): Ditto.
   14640         (-[WebHTMLView moveToEndOfParagraph:]): Ditto.
   14641         (-[WebHTMLView moveUp:]): Ditto.
   14642         (-[WebHTMLView moveUpAndModifySelection:]): Ditto.
   14643         (-[WebHTMLView moveWordBackward:]): Ditto.
   14644         (-[WebHTMLView moveWordBackwardAndModifySelection:]): Ditto.
   14645         (-[WebHTMLView moveWordForward:]): Ditto.
   14646         (-[WebHTMLView moveWordForwardAndModifySelection:]): Ditto.
   14647         (-[WebHTMLView moveWordLeft:]): Ditto.
   14648         (-[WebHTMLView moveWordLeftAndModifySelection:]): Ditto.
   14649         (-[WebHTMLView moveWordRight:]): Ditto.
   14650         (-[WebHTMLView moveWordRightAndModifySelection:]): Ditto.
   14651         (-[WebHTMLView pageDown:]): Ditto.
   14652         (-[WebHTMLView pageUp:]): Ditto.
   14653         (-[WebHTMLView selectParagraph:]): Ditto.
   14654         (-[WebHTMLView selectLine:]): Ditto.
   14655         (-[WebHTMLView selectWord:]): Ditto.
   14656         (-[WebHTMLView copy:]): Moved down in file so it's in the right category.
   14657         (-[WebHTMLView cut:]): Ditto.
   14658         (-[WebHTMLView delete:]): Ditto.
   14659         (-[WebHTMLView paste:]): Ditto.
   14660         (-[WebHTMLView copyFont:]): Moved here from WebView.
   14661         (-[WebHTMLView pasteFont:]): Ditto.
   14662         (-[WebHTMLView pasteAsPlainText:]): Ditto.
   14663         (-[WebHTMLView pasteAsRichText:]): Implemented this by calling the paste code with
   14664         allowPlainText:NO; believe it or not, that's what this means in NSTextView.
   14665         (-[WebHTMLView changeFont:]): Moved here from WebView.
   14666         (-[WebHTMLView changeAttributes:]): Ditto.
   14667         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
   14668         (-[WebHTMLView changeColor:]): Ditto.
   14669         (-[WebHTMLView alignCenter:]): Ditto.
   14670         (-[WebHTMLView alignJustified:]): Ditto.
   14671         (-[WebHTMLView alignLeft:]): Ditto.
   14672         (-[WebHTMLView alignRight:]): Ditto.
   14673         (-[WebHTMLView indent:]): Ditto.
   14674         (-[WebHTMLView insertTab:]): Moved here from WebView, also call insertText rather than
   14675         replaceSelectionWithText so it's undoable like a typed character.
   14676         (-[WebHTMLView insertBacktab:]): Moved here from WebView.
   14677         (-[WebHTMLView insertNewline:]): Moved here from WebView, also call insertText rather than
   14678         replaceSelectionWithText so it's undoable like a typed character.
   14679         (-[WebHTMLView insertParagraphSeparator:]): Moved here from WebView.
   14680         (-[WebHTMLView changeCaseOfLetter:]): Ditto.
   14681         (-[WebHTMLView uppercaseWord:]): Ditto.
   14682         (-[WebHTMLView lowercaseWord:]): Ditto.
   14683         (-[WebHTMLView capitalizeWord:]): Ditto.
   14684         (-[WebHTMLView deleteForward:]): Ditto.
   14685         (-[WebHTMLView deleteBackward:]): Ditto.
   14686         (-[WebHTMLView deleteBackwardByDecomposingPreviousCharacter:]): Ditto.
   14687         (-[WebHTMLView deleteWordForward:]): Ditto.
   14688         (-[WebHTMLView deleteWordBackward:]): Ditto.
   14689         (-[WebHTMLView deleteToBeginningOfLine:]): Ditto.
   14690         (-[WebHTMLView deleteToEndOfLine:]): Ditto.
   14691         (-[WebHTMLView deleteToBeginningOfParagraph:]): Ditto.
   14692         (-[WebHTMLView deleteToEndOfParagraph:]): Ditto.
   14693         (-[WebHTMLView complete:]): Ditto.
   14694         (-[WebHTMLView checkSpelling:]): Ditto.
   14695         (-[WebHTMLView showGuessPanel:]): Ditto.
   14696         (-[WebHTMLView performFindPanelAction:]): Ditto.
   14697         (-[WebHTMLView startSpeaking:]): Implemented this.
   14698         (-[WebHTMLView stopSpeaking:]): Implemented this.
   14699         (-[WebHTMLView insertText:]): Moved here from WebView.
   14700 
   14701         * WebView.subproj/WebHTMLViewPrivate.h: Removed declarations of methods that are neither
   14702         SPI nor needed outside WebHTMLView.m.
   14703 
   14704         * WebView.subproj/WebViewInternal.h: Removed _currentFrame, and added _frameForCurrentSelection and
   14705         _bridgeForCurrentSelection.
   14706 
   14707 2004-05-25  Maciej Stachowiak  <mjs (a] apple.com>
   14708 
   14709         Reviewed by Richard.
   14710 
   14711         <rdar://problem/3652498>: new sniffing support is crashing
   14712         
   14713         * WebView.subproj/WebMainResourceClient.m:
   14714         (-[WebMainResourceClient checkContentPolicyForResponse:]): Retain
   14715         listener around call, in case delegate does something that ends up
   14716         invalidating it, like navigating to a new URL.
   14717 
   14718 2004-05-25  Chris Blumenberg  <cblu (a] apple.com>
   14719 
   14720         Fixed regression where undoing typing would undo character-by-character.
   14721 
   14722         Reviewed by kocienda.
   14723 
   14724         * WebView.subproj/WebView.m:
   14725         (-[WebView insertText:]): call insertText: rather than replaceSelectionWithText:: since text insertion via insertText: is coalesced and this is the behavior we want here
   14726 
   14727 2004-05-25  Ken Kocienda  <kocienda (a] apple.com>
   14728 
   14729         Reviewed by John
   14730 
   14731         Change postDidChangeSelectionNotification and postDidChangeNotification tp
   14732         respondToChangedSelection and respondToChangedContents, respectively, to
   14733         account for the fact that we do work in these calls other than post a
   14734         notification. The need to clear the typing style on both kinds of changes
   14735         inspired the name change.
   14736 
   14737         Add in support to set and access typing style. We don't do anything with it yet
   14738         except store and return it. Using the typing style is still to come.
   14739 
   14740         * WebCoreSupport.subproj/WebBridge.m:
   14741         (-[WebBridge respondToChangedContents]): Change name of functions as described.
   14742         (-[WebBridge respondToChangedSelection]): Change name of functions as described.
   14743         * WebView.subproj/WebView.m:
   14744         (-[WebView dealloc:]): Dealloc typing style ivar.
   14745         (-[WebView setTypingStyle:]): Change to set typing style ivar.
   14746         (-[WebView typingStyle]): Return new typing style ivar.
   14747         * WebView.subproj/WebViewPrivate.h: Add ivar for typing style.
   14748 
   14749 2004-05-25  Ken Kocienda  <kocienda (a] apple.com>
   14750 
   14751         Reviewed by John
   14752         
   14753         Improve _bridgeForCurrentSelection so that it is frame-savvy.
   14754         Fixup setSelectedDOMRange:affinity: so that it uses the right bridge.
   14755 
   14756         * WebView.subproj/WebView.m:
   14757         (-[WebView _bridgeForCurrentSelection]): Use _currentFrame not mainFrame. 
   14758         (-[WebView _currentFrame]): Moved to WebView (WebInternal) category so _bridgeForCurrentSelection can use it.
   14759         (-[WebView setSelectedDOMRange:affinity:]): Derive the bridge to use from the range passed in; _bridgeForCurrentSelection
   14760         is not the right way to get at the document for the range.
   14761         * WebView.subproj/WebViewInternal.h: Add _currentFrame declaration.
   14762 
   14763 2004-05-24  Darin Adler  <darin (a] apple.com>
   14764 
   14765         Reviewed by Ken.
   14766 
   14767         - fixed <rdar://problem/3666022>: (REGRESSION: crash from infinite regress in -[WebFrameView(WebPrivate) scrollPageDown:])
   14768 
   14769         * WebView.subproj/WebView.m:
   14770         (-[WebView _performResponderOperation:sender:]): Helper method that knows how to pass on operations
   14771         to the responder chain, allowing us to implement operations that will get passed to views inside
   14772         us as necessary. Moved a few methods to this, and soon will move even more.
   14773         (-[WebView scrollLineDown:]): Use the above method.
   14774         (-[WebView scrollLineUp:]): Ditto.
   14775         (-[WebView scrollPageDown:]): Ditto.
   14776         (-[WebView scrollPageUp:]): Ditto.
   14777         (-[WebView copy:]): Ditto.
   14778         (-[WebView cut:]): Ditto.
   14779         (-[WebView paste:]): Ditto.
   14780         (-[WebView delete:]): Ditto.
   14781         (-[WebView insertBacktab:]): Ditto.
   14782 
   14783 2004-05-24  Chris Blumenberg  <cblu (a] apple.com>
   14784 
   14785         Improved editing via drag
   14786  
   14787         Reviewed by kocienda.
   14788 
   14789         * WebView.subproj/WebDataSource.m: 
   14790         (-[WebDataSource _documentFragmentWithImageResource:]): made this method return a fragment instead of replace the selection so that the caller do other things with the fragment
   14791         (-[WebDataSource _documentFragmentWithArchive:]): ditto
   14792         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): call renamed methods
   14793         * WebView.subproj/WebDataSourcePrivate.h:
   14794         * WebView.subproj/WebDocumentInternal.h:
   14795         * WebView.subproj/WebHTMLView.m:
   14796         (-[WebHTMLView _documentFragmentFromPasteboard:]): made this method return a fragment instead of replace the selection so that the caller do other things with the fragment
   14797         (-[WebHTMLView _replaceSelectionWithPasteboard:selectReplacement:]): new
   14798         (-[WebHTMLView paste:]): call _replaceSelectionWithPasteboard:selectReplacement:
   14799         (-[WebHTMLView dragOperationForDraggingInfo:]): handle the case where the destination is editable, but the source is not
   14800         (-[WebHTMLView draggingCancelledWithDraggingInfo:]): new, removes drag caret
   14801         (-[WebHTMLView draggingUpdatedWithDraggingInfo:]): remove drag caret when we can't handle the drag
   14802         (-[WebHTMLView concludeDragForDraggingInfo:]): instead of calling paste, move the selection when doing a move and replace the drag caret when doing a copy
   14803         * WebView.subproj/WebHTMLViewPrivate.h:
   14804         * WebView.subproj/WebView.m:
   14805         (-[WebViewPrivate dealloc]):
   14806         (-[WebView _setDraggingDocumentView:]): new
   14807         (-[WebView _dragOperationForDraggingInfo:]): if the current dragging document view changes, tell the previous dragging document view that dragging cancelled 
   14808         (-[WebView draggingExited:]): new, tell the previous dragging document view that dragging cancelled
   14809         (-[WebView concludeDragOperation:]): release the dragging document view
   14810         (-[WebView replaceSelectionWithNode:]): pass the selectReplacement BOOL to the bridge
   14811         (-[WebView replaceSelectionWithText:]): ditto
   14812         (-[WebView replaceSelectionWithMarkupString:]): ditto
   14813         (-[WebView replaceSelectionWithArchive:]): ditto
   14814         (-[WebView pasteAsPlainText:]): ditto
   14815         (-[WebView insertTab:]): ditto
   14816         (-[WebView insertText:]): ditto
   14817         * WebView.subproj/WebViewPrivate.h: 
   14818 
   14819 2004-05-24  John Sullivan  <sullivan (a] apple.com>
   14820 
   14821         Reviewed by Dave.
   14822         
   14823         - added private RSSFeedReferrer field to WebHistoryItem so RSS feeds in the
   14824         back/forward list can remember what page (if any) they were initiated from.
   14825 
   14826         * History.subproj/WebHistoryItem.m:
   14827         new RSSFeedReferrer ivar in private structure
   14828         (-[WebHistoryItemPrivate dealloc]):
   14829         release RSSFeedReferrer
   14830         (-[WebHistoryItem copyWithZone:]):
   14831         copy RSSFeedReferrer
   14832         (-[WebHistoryItem RSSFeedReferrer]):
   14833         return RSSFeedReferrer
   14834         (-[WebHistoryItem setRSSFeedReferrer:]):
   14835         set RSSFeedReferrer
   14836 
   14837         * History.subproj/WebHistoryItemPrivate.h:
   14838         declare -RSSFeedReferrer and -setRSSFeedReferrer:
   14839 
   14840 2004-05-22  Darin Adler  <darin (a] apple.com>
   14841 
   14842         Reviewed by Ken.
   14843 
   14844         - implemented some of the trivial WebView editing operations; some had bug reports, to wit:
   14845         - fixed <rdar://problem/3655342>: (Editing: -centerSelectionInVisibleArea: method unimplemented (WebKit editing API))
   14846         - fixed <rdar://problem/3655398>: (Editing: -deleteWordBackward: method unimplemented (WebKit editing API))
   14847         - fixed <rdar://problem/3655397>: (Editing: -deleteWordForward: method unimplemented (WebKit editing API))
   14848         - fixed <rdar://problem/3655387>: (Editing: -insertBacktab: method unimplemented (WebKit editing API))
   14849         - fixed <rdar://problem/3655386>: (Editing: -insertTab: method unimplemented (WebKit editing API))
   14850         - fixed <rdar://problem/3655351>: (Editing: -moveWordBackward: method unimplemented (WebKit editing API))
   14851         - fixed <rdar://problem/3655352>: (Editing: -moveWordBackwardAndModifySelection: method unimplemented (WebKit editing API))
   14852         - fixed <rdar://problem/3655353>: (Editing: -moveWordForward: method unimplemented (WebKit editing API))
   14853         - fixed <rdar://problem/3655354>: (Editing: -moveWordForwardAndModifySelection: method unimplemented (WebKit editing API))
   14854         - fixed <rdar://problem/3655374>: (Editing: -pasteAsPlainText: method unimplemented (WebKit editing API))
   14855         - fixed <rdar://problem/3655362>: (Editing: -scrollLineDown: method unimplemented (WebKit editing API))
   14856         - fixed <rdar://problem/3655363>: (Editing: -scrollLineUp: method unimplemented (WebKit editing API))
   14857 
   14858         * WebView.subproj/WebView.m:
   14859         (-[WebView centerSelectionInVisibleArea:]): Implemented. The implementation isn't perfect, but it's hooked
   14860         up. It simply calls ensureCaretVisible for now.
   14861         (-[WebView moveBackward:]): Implemented. The WebCore API already has a way to specify backward as opposed
   14862         to left. A separate issue is the fact that these operations don't have bi-di-savvy implementations, but
   14863         now this method is hooked up and will work at least for left-to-right text.
   14864         (-[WebView moveBackwardAndModifySelection:]): Ditto.
   14865         (-[WebView moveForward:]): Ditto.
   14866         (-[WebView moveForwardAndModifySelection:]): Ditto.
   14867         (-[WebView moveWordBackward:]): Ditto.
   14868         (-[WebView moveWordBackwardAndModifySelection:]): Ditto.
   14869         (-[WebView moveWordForward:]): Ditto.
   14870         (-[WebView moveWordForwardAndModifySelection:]): Ditto.
   14871         (-[WebView scrollLineDown:]): Forward to WebFrameView.
   14872         (-[WebView scrollLineUp:]): Ditto.
   14873         (-[WebView scrollPageDown:]): Ditto.
   14874         (-[WebView scrollPageUp:]): Ditto.
   14875         (-[WebView delete:]): Implemented. Follows pattern used in cut, copy, and paste.
   14876         (-[WebView pasteAsPlainText:]): Implemented. Calls delegate, then replaceSelectionWithText: on the bridge.
   14877         (-[WebView insertTab:]): Implemented. Calls delegate, then replaceSelectionWithText: on the bridge.
   14878         (-[WebView insertBacktab:]): Implemented. Does nothing. If we ever change so that you can use a WebView as
   14879         a field editor, then we might have to add code here.
   14880         (-[WebView deleteWordForward:]): Implement by calling moveForwardAndModifySelection: and then delete:.
   14881         Might not be a perfect implementation in the presence of delegates who refuse to delete because it will
   14882         change the selection even if the delete is disallowed.
   14883         (-[WebView deleteWordBackward:]): Implement by calling moveBackwardAndModifySelection: and then delete:.
   14884         Same issue about about delegates as deleteWordForward:.
   14885 
   14886         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _pasteFromPasteboard:]): Added a FIXME.
   14887 
   14888         * DOM.subproj/DOMViews.h: Updated from recent change to WebCore.
   14889 
   14890 2004-05-21  Richard Williamson   <rjw (a] apple.com>
   14891 
   14892         Removed _bindObject:forFrame: SPI.
   14893 
   14894         Reviewed by Chris.
   14895 
   14896         * WebView.subproj/WebView.m:
   14897         * WebView.subproj/WebViewPrivate.h:
   14898 
   14899 === Safari-141 ===
   14900 
   14901 2004-05-21  Darin Adler  <darin (a] apple.com>
   14902 
   14903         Reviewed by Ken and Chris.
   14904 
   14905         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _pasteFromPasteboard:]): Call replaceSelectionWithText:
   14906         instead of replaceSelectionWithMarkupString: when pasting plain text.
   14907 
   14908         * WebView.subproj/WebDataSource.m: (-[WebDataSource _replaceSelectionWithMarkupString:baseURL:]):
   14909         Remove bogus check for empty markup. There's nothing wrong with an empty string, and no reason
   14910         that replacing with empty string should be a no-op instead of a delete.
   14911 
   14912 2004-05-20  Darin Adler  <darin (a] apple.com>
   14913 
   14914         Reviewed by Chris.
   14915 
   14916         - fixed <rdar://problem/3662383>: (REGRESSION: drag slide-back sometimes causes link to load)
   14917 
   14918         * WebCoreSupport.subproj/WebBridge.m: (-[WebBridge handleMouseDragged:]):
   14919         Added BOOL result to handleMouseDragged:.
   14920         * WebView.subproj/WebHTMLViewPrivate.h: Added BOOL result to _handleMouseDragged:.
   14921 
   14922         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _handleMouseDragged:]): Added BOOL result,
   14923         returning YES when the drag started, and no when the hysteresis has not yet been overcome.
   14924 
   14925 2004-05-20  Ken Kocienda  <kocienda (a] apple.com>
   14926 
   14927         Reviewed by Hyatt
   14928 
   14929         Provide the methods to glue the WebView's editing delegate so that these methods work:
   14930         
   14931         <rdar://problem/3655316>: "Editing: -webViewShouldBeginEditing:inDOMRange: method unimplemented (WebKit editing API)"
   14932         <rdar://problem/3655317>: "Editing: -webViewShouldEndEditing:inDOMRange: method unimplemented (WebKit editing API)"
   14933 
   14934         * WebCoreSupport.subproj/WebBridge.m:
   14935         (-[WebBridge shouldBeginEditing:]): New method used to glue delegate to focus shifts.
   14936         (-[WebBridge shouldEndEditing:]): Ditto.
   14937         * WebView.subproj/WebView.m:
   14938         (-[WebView _shouldBeginEditingInDOMRange:]): Ditto.
   14939         (-[WebView _shouldEndEditingInDOMRange:]): Ditto.
   14940         * WebView.subproj/WebViewPrivate.h: Ditto.
   14941 
   14942 2004-05-20  Richard Williamson   <rjw (a] apple.com>
   14943 
   14944         Fixed typo in header comment.
   14945 
   14946         Reviewed by Ken.
   14947 
   14948         * Plugins.subproj/WebScriptObject.h:
   14949 
   14950 2004-05-19  Chris Blumenberg  <cblu (a] apple.com>
   14951 
   14952         Fixed: <rdar://problem/3462627>: (API: Need a way to disable/customize dragging)
   14953 
   14954         Reviewed by john.
   14955 
   14956         * Misc.subproj/WebNSPasteboardExtras.m:
   14957         (-[NSPasteboard _web_writeImage:URL:title:archive:types:]): fixed bug that caused exception
   14958         * WebView.subproj/WebDefaultUIDelegate.m:
   14959         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): new, returns YES
   14960         (-[WebDefaultUIDelegate webView:dragOperationForDraggingInfo:overElement:]): new, returns [WebView dragOperationForDraggingInfo:]
   14961         (-[WebDefaultUIDelegate webView:shouldProcessDragWithDraggingInfo:overElement:]): new, returns YES
   14962         * WebView.subproj/WebDocumentInternal.h: added WebDocumentDragging and WebDocumentElement for document dragging
   14963         * WebView.subproj/WebDocumentPrivate.h: moved WebDocumentSelection to WebDocumentInternal.h
   14964         * WebView.subproj/WebFrame.m:
   14965         (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): 
   14966         * WebView.subproj/WebHTMLView.h:
   14967         * WebView.subproj/WebHTMLView.m:
   14968         (+[WebHTMLView _insertablePasteboardTypes]): new 
   14969         (-[WebHTMLView _handleMouseDragged:]): call shouldBeginDragForElement:::: delegate API
   14970         (-[WebHTMLView _mayStartDragWithMouseDragged:]): call renamed elementAtPoint SPI
   14971         (-[WebHTMLView initWithFrame:]): don't register for drag types since this is handled at the WebView
   14972         (-[WebHTMLView menuForEvent:]): call renamed elementAtPoint SPI
   14973         (-[WebHTMLView _isSelectionEvent:]): call renamed elementAtPoint SPI
   14974         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): rather than unregistering drag types on the WebView, just tell it that we're dragging
   14975         (-[WebHTMLView draggedImage:endedAt:operation:]): ditto
   14976         (-[WebHTMLView _canProcessDragWithDraggingInfo:]): new
   14977         (-[WebHTMLView dragOperationForDraggingInfo:]): new WebDocumentDragging SPI
   14978         (-[WebHTMLView draggingUpdatedWithDraggingInfo:]): ditto
   14979         (-[WebHTMLView concludeDragForDraggingInfo:]): ditto
   14980         (-[WebHTMLView elementAtPoint:]): renamed from _elementAtPoint since this is part of the WebDocumentElement SPI
   14981         * WebView.subproj/WebHTMLViewPrivate.h:
   14982         * WebView.subproj/WebImageView.h:
   14983         * WebView.subproj/WebImageView.m:
   14984         (-[WebImageView elementAtPoint:]): new
   14985         (-[WebImageView menuForEvent:]): call elementAtPoint
   14986         (-[WebImageView mouseDragged:]): rather than unregistering drag types on the WebView, just tell it that we're dragging
   14987         (-[WebImageView draggedImage:endedAt:operation:]): ditto
   14988         * WebView.subproj/WebTextView.h:
   14989         * WebView.subproj/WebTextView.m:
   14990         (-[WebTextView _elementAtWindowPoint:]): new
   14991         (-[WebTextView elementAtPoint:]): new
   14992         (-[WebTextView menuForEvent:]): call _elementAtWindowPoint
   14993         * WebView.subproj/WebView.h:
   14994         * WebView.subproj/WebView.m:
   14995         (-[WebViewPrivate dealloc]): removed draggedTypes ivar
   14996         (+[WebView URLFromPasteboard:]): implemented
   14997         (+[WebView URLTitleFromPasteboard:]): implemented
   14998         (-[WebView _registerDraggedTypes]): moved
   14999         (-[WebView _frameViewAtWindowPoint:]): new
   15000         (-[WebView _draggingDocumentViewAtWindowPoint:]): new
   15001         (-[WebView _elementAtWindowPoint:]): new
   15002         (-[WebView dragOperationForDraggingInfo:]): updated this API to handle subviews that may want to handle drags
   15003         (-[WebView _dragOperationForDraggingInfo:]): new, handles UI delegate for drag control
   15004         (-[WebView draggingEntered:]): call _dragOperationForDraggingInfo:
   15005         (-[WebView draggingUpdated:]): ditto
   15006         (-[WebView concludeDragOperation:]): work with the UI delegate and the subview to handle what happens
   15007         * WebView.subproj/WebViewPrivate.h:
   15008 
   15009 2004-05-19  Richard Williamson   <rjw (a] apple.com>
   15010 
   15011         Removed extraneous tabs that were added (by XCode?).
   15012         
   15013         * DOM.subproj/DOM-compat.h:
   15014         * Plugins.subproj/WebScriptObject.h:
   15015 
   15016 2004-05-19  Richard Williamson   <rjw (a] apple.com>
   15017 
   15018         Updated header copy script to only copy if modified headers
   15019         are different.
   15020 
   15021         * copy-webcore-files-to-webkit:
   15022 
   15023 2004-05-19  Ken Kocienda  <kocienda (a] apple.com>
   15024 
   15025         Reviewed by Hyatt and Darin
   15026 
   15027         Fix for this bug:
   15028         
   15029         <rdar://problem/3643230>: "can't tab out of contentEditable Elements"
   15030 
   15031         * WebCoreSupport.subproj/WebBridge.m:
   15032         (-[WebBridge interceptEditingKeyEvent:]): Renamed from _editingKeyDown. Also now returns
   15033         a BOOL to report whether the event was handled or not.
   15034         * WebView.subproj/WebView.m:
   15035         (-[WebView _interceptEditingKeyEvent:]): Also renamed from _editingKeyDown. Now includes
   15036         a check if the web view is editable and whether the event is a tab key event. If the former
   15037         is not true and the latter is, the key is not intercepted. This causes the tab to shift once
   15038         the key is processed by other non-editing key-handling mechanisms.
   15039         * WebView.subproj/WebViewPrivate.h: Changed declaration due to name change.
   15040 
   15041 2004-05-19  Ken Kocienda  <kocienda (a] apple.com>
   15042 
   15043         Reviewed by Hyatt
   15044 
   15045         * WebCoreSupport.subproj/WebBridge.m:
   15046         (-[WebBridge isEditable]): Return the isEditable value for the
   15047         WebView which contains this bridge's frame.
   15048 
   15049 2004-05-19  Darin Adler  <darin (a] apple.com>
   15050 
   15051         - fixed headers with licenses mangled by Xcode auto-indenting
   15052 
   15053         * DOM.subproj/DOMExtensions.h:
   15054         * WebCoreSupport.subproj/WebGraphicsBridge.h:
   15055         * WebCoreSupport.subproj/WebGraphicsBridge.m:
   15056 
   15057 2004-05-18  David Hyatt  <hyatt (a] apple.com>
   15058 
   15059         Improve layout scheduling.
   15060         Reviewed by kocienda
   15061 
   15062         * WebView.subproj/WebFrame.m:
   15063         (-[WebFrame _transitionToLayoutAcceptable]):
   15064         (-[WebFrame _checkLoadCompleteForThisFrame]):
   15065         * WebView.subproj/WebHTMLRepresentation.m:
   15066         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
   15067 
   15068 2004-05-18  Richard Williamson   <rjw (a] apple.com>
   15069 
   15070         Finished implementation of windowScriptObject.
   15071                 Reviewed by Maciej.
   15072 
   15073         * WebView.subproj/WebView.m:
   15074         (-[WebView windowScriptObject]):
   15075 
   15076 2004-05-18  Richard Williamson   <rjw (a] apple.com>
   15077 
   15078         Added WebKit portion of webView:windowScriptObjectAvailable:
   15079         implementation.  Still need to implement creating the WebScriptObject
   15080         wrapper on the WebCore side.
   15081         
   15082         Reviewed by Maciej.
   15083 
   15084         Removed "_" from _setPageWidthForPrinting:.  This method facilitates
   15085         a work-around for carbon printing.  At some point we may make this
   15086         method public API.
   15087                 Reviewed by Chris.
   15088 
   15089         * WebCoreSupport.subproj/WebBridge.m:
   15090         (-[WebBridge overrideMediaType]):
   15091         (-[WebBridge windowObjectCleared]):
   15092         * WebView.subproj/WebDefaultFrameLoadDelegate.m:
   15093         (-[WebDefaultFrameLoadDelegate webView:windowScriptObjectAvailable:]):
   15094         * WebView.subproj/WebHTMLView.m:
   15095         (-[WebHTMLView setPageWidthForPrinting:]):
   15096 
   15097 2004-05-18  Darin Adler  <darin (a] apple.com>
   15098 
   15099         Reviewed by John.
   15100 
   15101         - fixed <rdar://problem/3520322>: "can't use <WebKit/HIWebView.h> or <WebKit/CarbonUtils.h> from non-Objective C"
   15102 
   15103         * Carbon.subproj/CarbonUtils.h: Added ifdefs so file compiles when included from non-Objective-C.
   15104         Changed style to match other Carbon headers a bit more closely. Also remove unnecessary includes.
   15105         * Carbon.subproj/HIWebView.h: Ditto.
   15106 
   15107         - fixed <rdar://problem/3648505>: "this text file scrolls to the second line instead of first when pressing home"
   15108 
   15109         * WebView.subproj/WebFrameView.m:
   15110         (-[WebFrameView _scrollToTopLeft]): Scroll to origin.y instead of assuming that top is 0; can be non-0 for text view.
   15111         (-[WebFrameView _scrollToBottomLeft]): Use NSMaxY instead of height for the same reason.
   15112 
   15113 2004-05-17  David Hyatt  <hyatt (a] apple.com>
   15114 
   15115         Fix for performance regression in PLT caused by not setting _timeOfLastCompletedLoad, causing
   15116         page cache to release during the benchmark.
   15117         * WebView.subproj/WebFrame.m:
   15118         (-[WebFrame _setState:]):
   15119 
   15120 2004-05-17  Chris Blumenberg  <cblu (a] apple.com>
   15121 
   15122         Implemented new WebView pasteboard methods. Made a lot of factoring changes related to pasteboard management.
   15123 
   15124         Reviewed by john.
   15125 
   15126         * Misc.subproj/WebNSPasteboardExtras.h:
   15127         * Misc.subproj/WebNSPasteboardExtras.m:
   15128         (+[NSPasteboard _web_writableTypesForURL]): renamed to not include "drag" these types are also used for copying
   15129         (+[NSPasteboard _web_writableTypesForImage]): new
   15130         (-[NSPasteboard _web_bestURL]): tweak
   15131         (-[NSPasteboard _web_writeURL:andTitle:types:]): take an array of types that this method should write, don't declare the types since this complicates things for the caller
   15132         (-[NSPasteboard _web_writeImage:URL:title:archive:types:]): ditto
   15133         * Misc.subproj/WebNSViewExtras.m:
   15134         (-[NSView _web_dragImage:archive:rect:URL:title:event:]): call renamed methods
   15135         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   15136         (-[WebDefaultUIDelegate copyLinkToClipboard:]): call code factored out to WebView
   15137         (-[WebDefaultUIDelegate copyImageToClipboard:]): ditto
   15138         * WebView.subproj/WebDocumentPrivate.h:
   15139         * WebView.subproj/WebHTMLView.h:
   15140         * WebView.subproj/WebHTMLView.m:
   15141         (-[WebHTMLView _selectedRTFData]): new factored out method
   15142         (-[WebHTMLView _writeSelectionToPasteboard:]): factored code out to writeSelectionWithPasteboardTypes:toPasteboard:
   15143         (-[WebHTMLView _dragImageForLinkElement:]): tweak
   15144         (-[WebHTMLView _handleMouseDragged:]): call renamed methods
   15145         (-[WebHTMLView pasteboardTypesForSelection]): new
   15146         (-[WebTextView writeSelectionWithPasteboardTypes:toPasteboard:]): new, code moved from _writeSelectionToPasteboard:
   15147         * WebView.subproj/WebHTMLViewPrivate.h:
   15148         * WebView.subproj/WebImageView.h:
   15149         * WebView.subproj/WebImageView.m:
   15150         (-[WebImageView writeImageToPasteboard:types:]): call renamed methods
   15151         (-[WebImageView copy:]):
   15152         (-[WebImageView writeSelectionToPasteboard:types:]): call renamed methods
   15153         * WebView.subproj/WebTextView.h:
   15154         * WebView.subproj/WebTextView.m:
   15155         (-[WebTextView pasteboardTypesForSelection]): new
   15156         (-[WebTextView writeSelectionWithPasteboardTypes:toPasteboard:]): new
   15157         * WebView.subproj/WebView.m:
   15158         (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]): new
   15159         (-[WebView _writeLinkElement:withPasteboardTypes:toPasteboard:]): mew
   15160         (-[WebView dragOperationForDraggingInfo:]): implemented API
   15161         (-[WebView draggingEntered:]): call API
   15162         (-[WebView draggingUpdated:]): ditto
   15163         (-[WebView concludeDragOperation:]): ditto
   15164         (-[WebView pasteboardTypesForSelection]): implemented API
   15165         (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): ditto
   15166         (-[WebView pasteboardTypesForElement:]): ditto
   15167         (-[WebView writeElement:withPasteboardTypes:toPasteboard:]): ditto
   15168         * WebView.subproj/WebViewPrivate.h:
   15169 
   15170 2004-05-17  Ken Kocienda  <kocienda (a] apple.com>
   15171 
   15172         Reviewed by John
   15173 
   15174         Remove overrides in WebView for scrollPageDown and scrollPageUp.
   15175         NSView behavior gives us just what we want, and there is no
   15176         special behavior required for editing.
   15177 
   15178         <rdar://problem/3655364>: "Editing: -scrollPageDown: method unimplemented (WebKit editing API)"
   15179         <rdar://problem/3655365>: "Editing: -scrollPageUp: method unimplemented (WebKit editing API)"
   15180 
   15181         * WebView.subproj/WebView.h: Comment methods out and add a note about why.
   15182         * WebView.subproj/WebView.m: Remove stubbed out implementation.
   15183 
   15184 2004-05-14  Vicki Murley  <vicki (a] apple.com>
   15185 
   15186         Reviewed by mjs.
   15187  
   15188         <rdar://problem/3642427>: framework marketing number should be 2.0 for DoubleBarrel release
   15189 
   15190         * WebKit.pbproj/project.pbxproj: change CFBundleShortVersionString to 2.0
   15191 
   15192 2004-05-14  David Hyatt  <hyatt (a] apple.com>
   15193 
   15194         Eliminate timedLayout.
   15195         Reviewed by darin
   15196 
   15197         * WebView.subproj/WebFrame.m:
   15198         (-[WebFramePrivate dealloc]):
   15199         (-[WebFrame _detachFromParent]):
   15200         (-[WebFrame _transitionToLayoutAcceptable]):
   15201         (-[WebFrame _setState:]):
   15202         (-[WebFrame _checkLoadCompleteForThisFrame]):
   15203         (-[WebFrame stopLoading]):
   15204         * WebView.subproj/WebFramePrivate.h:
   15205 
   15206 === Safari-140 ===
   15207 
   15208 2004-05-14  Chris Blumenberg  <cblu (a] apple.com>
   15209 
   15210         Fixed: <rdar://problem/3655495>: (exception loading applets)
   15211 
   15212         Reviewed by kocienda.
   15213 
   15214         * WebCoreSupport.subproj/WebBridge.m:
   15215         (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): when calling old cocoa plug-ins, use old keys
   15216 
   15217 2004-05-14  Chris Blumenberg  <cblu (a] apple.com>
   15218 
   15219         Fixed: <rdar://problem/3655204>: (repro assertion failure and crash loading java applets)
   15220 
   15221         Reviewed by kocienda.
   15222 
   15223         * WebCoreSupport.subproj/WebBridge.m:
   15224         (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): call pluginViewWithArguments: for old Cocoa plug-ins
   15225 
   15226 2004-05-14  Chris Blumenberg  <cblu (a] apple.com>
   15227 
   15228         Copied headers from WebCore.
   15229 
   15230         * DOM.subproj/DOMCore.h:
   15231         * DOM.subproj/DOMEvents.h:
   15232 
   15233 2004-05-14  Ken Kocienda  <kocienda (a] apple.com>
   15234 
   15235         Reviewed by me
   15236 
   15237         * Plugins.subproj/WebPluginController.m:
   15238         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Fixed a compile error: undeclared identifier. 
   15239         Looked like a typo.
   15240 
   15241 2004-05-13  Richard Williamson   <rjw (a] apple.com>
   15242 
   15243         Backed out mistaken change that I didn't mean to checkin.
   15244 
   15245         * WebCoreSupport.subproj/WebBridge.m:
   15246         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
   15247 
   15248 2004-05-13  Richard Williamson   <rjw (a] apple.com>
   15249 
   15250         Updated to reflect new API.
   15251 
   15252         Reviewed by Chris.
   15253 
   15254         * WebCoreSupport.subproj/WebBridge.m:
   15255         (-[WebBridge setIsSelected:forView:]):
   15256         * WebView.subproj/WebFrame.m:
   15257         (-[WebFrame _reloadForPluginChanges]):
   15258 
   15259 2004-05-13  Chris Blumenberg  <cblu (a] apple.com>
   15260 
   15261         Fixed some indenting issues in public headers.
   15262 
   15263         * Plugins.subproj/WebJavaPlugIn.h:
   15264         * Plugins.subproj/WebPlugin.h:
   15265         * Plugins.subproj/WebScriptObject.h:
   15266         * WebView.subproj/WebEditingDelegate.h:
   15267         * WebView.subproj/WebFrameView.h:
   15268         * WebView.subproj/WebPolicyDelegate.h:
   15269         * WebView.subproj/WebResourceLoadDelegate.h:
   15270         * WebView.subproj/WebView.h:
   15271 
   15272 2004-05-13  Ken Kocienda  <kocienda (a] apple.com>
   15273 
   15274         Reviewed by Chris
   15275 
   15276         Moved -DOMDocument convenience back to private header.
   15277         I mistakenly moved it to the public header earlier today.
   15278 
   15279         * WebView.subproj/WebView.h: Removed
   15280         * WebView.subproj/WebViewPrivate.h: Re-added
   15281 
   15282 2004-05-13  Richard Williamson   <rjw (a] apple.com>
   15283 
   15284         Updated to implementation to reflect new API.  Left old SPI
   15285         in place for compatibility.  Can remove when the Java plug-in
   15286         updates.
   15287 
   15288         Reviewed by Chris.
   15289 
   15290         * Plugins.subproj/WebPlugin.h:
   15291         * Plugins.subproj/WebPluginContainer.h:
   15292         * Plugins.subproj/WebPluginController.h:
   15293         * Plugins.subproj/WebPluginController.m:
   15294         (-[WebPluginController startAllPlugins]):
   15295         (-[WebPluginController stopAllPlugins]):
   15296         (-[WebPluginController addPlugin:]):
   15297         (-[WebPluginController destroyAllPlugins]):
   15298         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
   15299         (-[WebPluginController showURL:inFrame:]):
   15300         (-[WebPluginController webPlugInContainerShowStatus:]):
   15301         (-[WebPluginController showStatus:]):
   15302         (-[WebPluginController webPlugInContainerSelectionColor]):
   15303         (-[WebPluginController selectionColor]):
   15304         (-[WebPluginController webFrame]):
   15305 
   15306 2004-05-13  Chris Blumenberg  <cblu (a] apple.com>
   15307 
   15308         - Added stubs for WebView action and drag & drop customization API's
   15309         - Fixed: <rdar://problem/3616555>: (API: Make DOM extensions and WebKit DOM operations public)
   15310 
   15311         Reviewed by rjw.
   15312 
   15313         * DOM.subproj/WebDOMOperations.h: added remaining DOM operations
   15314         * DOM.subproj/WebDOMOperationsPrivate.h:
   15315         * Misc.subproj/WebKit.h: added new public headers
   15316         * WebKit.pbproj/project.pbxproj:
   15317         * WebKit.exp: added symbol for WebElementDOMNodeKey
   15318         * WebView.subproj/WebUIDelegate.h: added new UI delegate methods
   15319         * WebView.subproj/WebView.h: added new pasteboard related methods
   15320         * WebView.subproj/WebView.m:
   15321         (+[WebView URLFromPasteboard:]): new stub
   15322         (+[WebView URLTitleFromPasteboard:]): new stub
   15323         (-[WebView dragOperationForDraggingInfo:]): new stub
   15324         (-[WebView pasteboardTypesForSelection]): new stub
   15325         (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): new stub
   15326         (-[WebView pasteboardTypesForElement:]): new stub
   15327         (-[WebView writeElement:withPasteboardTypes:toPasteboard:]): new stub
   15328         * WebView.subproj/WebViewPrivate.h:
   15329 
   15330 2004-05-13  Richard Williamson   <rjw (a] apple.com>
   15331 
   15332         Changed imports of all DOM headers.  DOM headers
   15333         should be imported using the normal #import <WebCore/foo.h>,
   15334         they import is modified when copied to WebKit.
   15335 
   15336         Other approved API changes.  Currently unimplemented.
   15337 
   15338         Reviewed by Chris.
   15339 
   15340         * ChangeLog:
   15341         * DOM.subproj/DOM.h:
   15342         * DOM.subproj/DOMCSS.h:
   15343         * DOM.subproj/DOMCore.h:
   15344         * DOM.subproj/DOMEvents.h:
   15345         * DOM.subproj/DOMExtensions.h:
   15346         * DOM.subproj/DOMHTML.h:
   15347         * DOM.subproj/DOMRange.h:
   15348         * DOM.subproj/DOMStylesheets.h:
   15349         * DOM.subproj/DOMTraversal.h:
   15350         * DOM.subproj/DOMViews.h:
   15351         * Plugins.subproj/WebPlugin.h:
   15352         * Plugins.subproj/WebPluginContainer.h:
   15353         * Plugins.subproj/WebPluginPackage.m:
   15354         * Plugins.subproj/WebPluginViewFactory.h:
   15355         * Plugins.subproj/WebScriptObject.h:
   15356         * WebCoreSupport.subproj/WebBridge.m:
   15357         (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
   15358         (-[WebBridge pluginViewWithPackage:attributes:baseURL:]):
   15359         * WebKit.exp:
   15360         * WebKit.pbproj/project.pbxproj:
   15361         * WebView.subproj/WebFrameLoadDelegate.h:
   15362         * WebView.subproj/WebView.h:
   15363         * WebView.subproj/WebView.m:
   15364         (-[WebView windowScriptObject]):
   15365         * copy-webcore-files-to-webkit:
   15366 
   15367 2004-05-13  Ken Kocienda  <kocienda (a] apple.com>
   15368 
   15369         Reviewed by Kevin
   15370 
   15371         Move WebKit editing APIs to public API files.
   15372 
   15373         * WebCoreSupport.subproj/WebBridge.m: Add WebEditingDelegate include.
   15374         * WebKit.pbproj/project.pbxproj: Go Xcode!
   15375         * WebView.subproj/WebDefaultEditingDelegate.m: Remove WebViewPrivate include; add WebEditingDelegate include.
   15376         * WebView.subproj/WebEditingDelegate.h: Added. New file.
   15377         * WebView.subproj/WebView.h: Move API-approved interfaces to this file.
   15378         * WebView.subproj/WebView.m: Add WebEditingDelegate include.
   15379         * WebView.subproj/WebViewPrivate.h: Move API-approved interfaces from this file.
   15380 
   15381 2004-05-12  Chris Blumenberg  <cblu (a] apple.com>
   15382 
   15383         Fixed: 
   15384         <rdar://problem/3633296>: (Japanese input is not working properly in Carbon Web Kit applications (including CarbonWeb))
   15385         <rdar://problem/3631390>: (can't toggle between Input Methods (IMEs) using cmd-space in Carbon Web Kit applications)
   15386 
   15387         Reviewed by rjw.
   15388 
   15389         * Carbon.subproj/CarbonWindowAdapter.m:
   15390         (-[CarbonWindowAdapter sendSuperEvent:]): call [NSInputContext processInputKeyBindings:inEvent] just as NSApp does
   15391         * Carbon.subproj/HIWebView.m:
   15392         (HIWebViewEventHandler): [NSApp setWindowsNeedUpdate:YES] must be called before events so that ActivateTSMDocument is called to set an active document. Without an active document, TSM will use a default document which uses a bottom-line input window which we don't want.
   15393 
   15394 2004-05-11  Chris Blumenberg  <cblu (a] apple.com>
   15395 
   15396         Fixed:
   15397         <rdar://problem/3616537>: (API: Make WebResource, WebArchive and related API's public)
   15398         <rdar://problem/3616471>: (API: provide way to get from WebFrame to DOMDocument and vice versa)
   15399 
   15400         Reviewed by rjw.
   15401 
   15402         * DOM.subproj/WebDOMOperations.h:
   15403         * DOM.subproj/WebDOMOperations.m:
   15404         (-[DOMHTMLFrameElement contentFrame]): new
   15405         (-[DOMHTMLIFrameElement contentFrame]): new
   15406         (-[DOMHTMLObjectElement contentFrame]): new
   15407         * DOM.subproj/WebDOMOperationsPrivate.h:
   15408         * Misc.subproj/WebNSImageExtras.m:
   15409         (-[NSImage _web_saveAndOpen]): fixed leak
   15410         * WebKit.pbproj/project.pbxproj:
   15411         * WebView.subproj/WebDataSource.h:
   15412         * WebView.subproj/WebDataSource.m:
   15413         (-[WebDataSource _addSubresources:]): made private
   15414         (-[WebDataSource _archiveWithMarkupString:nodes:]): handle object tags with frame content
   15415         (-[WebDataSource _archiveWithCurrentState:]): renamed from _archive, now takes flag
   15416         (-[WebDataSource _replaceSelectionWithArchive:]): call renamed _addSubresources
   15417         (-[WebDataSource webArchive]): new
   15418         (-[WebDataSource mainResource]): new
   15419         (-[WebDataSource subresources]): made public
   15420         (-[WebDataSource subresourceForURL:]): made public
   15421         (-[WebDataSource addSubresource:]): made public
   15422         * WebView.subproj/WebDataSourcePrivate.h:
   15423         * WebView.subproj/WebDocumentPrivate.h:
   15424         * WebView.subproj/WebFrame.h:
   15425         * WebView.subproj/WebFrame.m:
   15426         (-[WebFrame _loadRequest:subresources:subframeArchives:]): call renamed _addSubresources
   15427         (-[WebFrame DOMDocument]): new
   15428         (-[WebFrame frameElement]): new
   15429         (-[WebFrame loadArchive:]): made public
   15430         * WebView.subproj/WebFramePrivate.h:
   15431         * WebView.subproj/WebHTMLRepresentation.m:
   15432         (-[WebHTMLRepresentation loadArchive]): call renamed _addSubresources
   15433         * WebView.subproj/WebImageRepresentation.m:
   15434         (-[WebImageRepresentation archive]): call webArchive on WebDataSource
   15435 
   15436 2004-05-10  Maciej Stachowiak  <mjs (a] apple.com>
   15437 
   15438         Reviewed by Darin.
   15439 
   15440         - avoid redecoding animated images that are only used once for
   15441         ~2.5% iBench speedup (WebCore part of fix)
   15442 
   15443         * WebCoreSupport.subproj/WebImageRenderer.h:
   15444         * WebCoreSupport.subproj/WebImageRenderer.m:
   15445         (-[WebImageRenderer increaseUseCount]):
   15446         (-[WebImageRenderer decreaseUseCount]):
   15447         (-[WebImageRenderer retainOrCopyIfNeeded]):
   15448 
   15449 2004-05-10  Maciej Stachowiak  <mjs (a] apple.com>
   15450 
   15451         Fix build.
   15452 
   15453         * WebView.subproj/WebFrame.m:
   15454 
   15455 2004-05-09  Maciej Stachowiak  <mjs (a] apple.com>
   15456 
   15457         Reviewed by Ken.
   15458 
   15459         - avoid messing with undo manager needlessly for ~1% HTML iBench speedup
   15460 
   15461         * WebCoreSupport.subproj/WebBridge.h:
   15462         * WebCoreSupport.subproj/WebBridge.m:
   15463         (-[WebBridge registerCommandForUndo:]): mark undo/redo item flag
   15464         (-[WebBridge registerCommandForRedo:]): ditto
   15465         (-[WebBridge clearUndoRedoOperations]): check flag before removing items,
   15466         and clear it after removing them
   15467 
   15468 2004-05-08  Maciej Stachowiak  <mjs (a] apple.com>
   15469 
   15470         Reviewed by Darin.
   15471 
   15472         - -[WebFrame childFrames] is so hot that a special internal
   15473         version which avoids the copy and autorelease results in a .75%
   15474         performance improvement on HTML iBench.
   15475 
   15476         * WebView.subproj/WebFramePrivate.h: Prototype new method.
   15477         * WebView.subproj/WebFrame.m:
   15478         (-[WebFrame _internalChildFrames]): New method, just returns
   15479         internal value instead of copying.
   15480 
   15481         (-[WebFrame _descendantFrameNamed:]): Use it
   15482         (-[WebFrame _textSizeMultiplierChanged]): likewise
   15483         (-[WebFrame _viewWillMoveToHostWindow:]): likewise
   15484         (-[WebFrame _viewDidMoveToHostWindow]): likewise
   15485         (-[WebFrame _saveDocumentAndScrollState]): likewise
   15486         (-[WebFrame _numPendingOrLoadingRequests:]): likewise
   15487         (-[WebFrame _checkLoadComplete]): Refactored this and it's two
   15488         helpers a little so we could get away with using
   15489         _internalChildFrames.
   15490         (-[WebFrame _checkLoadCompleteForThisFrame]): Renamed from
   15491         _isLoadComplete
   15492         (-[WebFrame _recursiveCheckLoadComplete]): renamed from (class
   15493         method) _recursiveCheckCompleteFromFrame:
   15494         * WebView.subproj/WebDataSource.m:
   15495         (-[WebDataSource _defersCallbacksChanged]): Use it
   15496         (-[WebDataSource isLoading]): likewise
   15497         * WebView.subproj/WebView.m:
   15498         (-[WebView _frameForDataSource:fromFrame:]): likewise
   15499         (-[WebView _frameForView:fromFrame:]): likewise
   15500 
   15501 2004-05-10  Chris Blumenberg  <cblu (a] apple.com>
   15502 
   15503         Forgot to commit this copied header.
   15504 
   15505         * DOM.subproj/DOMExtensions.h:
   15506 
   15507 === Safari-139 ===
   15508 
   15509 2004-05-06  Chris Blumenberg  <cblu (a] apple.com>
   15510 
   15511         * DOM.subproj/WebDOMOperations.h: improved a header doc comment
   15512 
   15513 2004-05-05  Chris Blumenberg  <cblu (a] apple.com>
   15514 
   15515         - DOM Extensions API tweaks
   15516 
   15517         Reviewed by kocienda.
   15518 
   15519         * DOM.subproj/DOMExtensions.h: copied from WebCore
   15520         * DOM.subproj/WebDOMOperations.h: added header doc comments
   15521         * DOM.subproj/WebDOMOperations.m:
   15522         (-[DOMNode _URLsFromSelectors:]): use renamed URLWithAttributeString
   15523         (-[DOMDocument URLWithAttributeString:]): renamed
   15524         (-[DOMHTMLTableElement _web_background]): new private method
   15525         (-[DOMHTMLTableElement _subresourceURLs]): use new private method
   15526         (-[DOMHTMLTableCellElement _web_background]): new private method
   15527         (-[DOMHTMLTableCellElement _subresourceURLs]): use new private method
   15528 
   15529 2004-05-04  Ken Kocienda  <kocienda (a] apple.com>
   15530 
   15531         Reviewed by Hyatt
   15532 
   15533         * DOM.subproj/DOMTraversal.h: File coppied from WebCore
   15534 
   15535 2004-05-02  Darin Adler  <darin (a] apple.com>
   15536 
   15537         Reviewed by Ken.
   15538 
   15539         - fixed <rdar://problem/3640419>: "_webkit_stringByReplacingValidPercentEscapes does not handle %00 properly"
   15540 
   15541         * Misc.subproj/WebNSURLExtras.m: (-[NSString _webkit_stringByReplacingValidPercentEscapes]):
   15542         Use the function in NSURL instead of implementing our own here.
   15543 
   15544 2004-04-30  John Sullivan  <sullivan (a] apple.com>
   15545 
   15546         * WebView.subproj/WebView.m:
   15547         fixed deployment build breakage
   15548         
   15549 2004-04-30  John Sullivan  <sullivan (a] apple.com>
   15550 
   15551         - more work on getting the font panel to work with editable HTML.
   15552         The font panel in Blot now correctly reflects the first selected font when the
   15553         selection is at least one character long.
   15554 
   15555         Reviewed by Ken.
   15556 
   15557         * WebView.subproj/WebView.m:
   15558         removed unfinished plumbing to support reflecting selected attributes (e.g. text color,
   15559         underline) in font panel, since this doesn't work in Mail or TextEdit either.
   15560         (_fontFromStyle):
   15561         removed assertion for now
   15562         (-[WebView _updateFontPanel]):
   15563         now uses new bridge method to get the NSFont from the node, instead of trying
   15564         to create an NSFont from a DOMCSSStyleDeclaration
   15565 
   15566 2004-04-29  John Sullivan  <sullivan (a] apple.com>
   15567 
   15568         - more work on getting the font panel to work with editable HTML
   15569 
   15570         Reviewed by Ken.
   15571 
   15572         * WebView.subproj/WebView.m:
   15573         (-[WebView computedStyleForElement:pseudoElement:]):
   15574         convert nil pseudoElement to empty string because lower level chokes on nil
   15575         (_fontFromStyle):
   15576         I tried to implement this, but was thwarted by missing API, so I added a
   15577         bunch of FIXMEs instead
   15578         (_stylesRepresentSameFont):
   15579         new function, not yet implementable
   15580         (_stylesRepresentSameAttributes):
   15581         new function, not yet implementable
   15582         (-[WebView _updateFontPanel]):
   15583         added code to get first and last element in selection, and to use
   15584         NodeIterator to walk through the entire selection to see if more than one
   15585         font or set of attributes is in use. However, createNodeIterator is declared
   15586         in DOMTraversal.h but not actually defined anywhere, so I had to prevent this
   15587         code from actually being called.
   15588 
   15589 2004-04-28  Chris Blumenberg  <cblu (a] apple.com>
   15590 
   15591         - Made WebArchive and WebResource conform to NSCoding and NSCopying.
   15592 
   15593         Reviewed by rjw.
   15594 
   15595         * DOM.subproj/WebDOMOperations.h: added header doc comment for WebArchive methods
   15596         * WebView.subproj/WebArchive.h:
   15597         * WebView.subproj/WebArchive.m:
   15598         (-[WebArchive initWithCoder:]): new
   15599         (-[WebArchive encodeWithCoder:]): new
   15600         (-[WebArchive copyWithZone:]): new
   15601         * WebView.subproj/WebResource.h:
   15602         * WebView.subproj/WebResource.m:
   15603         (-[WebResource init]): new
   15604         (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call [self init]
   15605         (-[WebResource initWithCoder:]): new
   15606         (-[WebResource encodeWithCoder:]): new
   15607         (-[WebResource copyWithZone:]): new
   15608 
   15609 2004-04-28  John Sullivan  <sullivan (a] apple.com>
   15610 
   15611         A little bit more progress in wiring up the font panel.
   15612 
   15613         Reviewed by Ken.
   15614 
   15615         * WebView.subproj/WebViewInternal.h:
   15616         put _updateFontPanel here. Also moved _isLoading here, since it was
   15617         already in a category named WebInternal
   15618 
   15619         * WebView.subproj/WebView.m:
   15620         (-[WebView _isLoading]):
   15621         moved into WebInternal category implementation
   15622         (_textAttributesFromStyle):
   15623         changed from method to function
   15624         (_fontFromStyle):
   15625         added, guts not filled in yet
   15626         (-[WebView _updateFontPanel]):
   15627         now calls these two functions (but results are always nil)
   15628         (-[WebView setSelectedDOMRange:affinity:]):
   15629         remove call to _updateFontPanel here since it's now called in
   15630         the proper bottleneck
   15631 
   15632         * WebCoreSupport.subproj/WebBridge.m:
   15633         (-[WebBridge postDidChangeNotification]):
   15634         call -[WebView _updateFontPanel] in addition to sending notification
   15635         (-[WebBridge postDidChangeSelectionNotification]):
   15636         ditto
   15637 
   15638 2004-04-28  John Sullivan  <sullivan (a] apple.com>
   15639 
   15640         - fixed these bugs:
   15641         <rdar://problem/3636570>: "API: [WebPreferences tabsToLinks] should be public API"        
   15642         <rdar://problem/3610597>: "API: could turn "stealth browsing" preference into API"
   15643 
   15644         Reviewed by Darin.
   15645         
   15646         I just moved the declarations and implementations from one place to another.
   15647         (No clients in WebKit needed their #imports updated.) This confused cvs diff quite a bit.
   15648 
   15649         * WebView.subproj/WebPreferences.h:
   15650         * WebView.subproj/WebPreferences.m:
   15651         (-[WebPreferences setTabsToLinks:]):
   15652         (-[WebPreferences tabsToLinks]):
   15653         (-[WebPreferences setPrivateBrowsingEnabled:]):
   15654         (-[WebPreferences privateBrowsingEnabled]):
   15655         (-[WebPreferences _pageCacheSize]):
   15656         (-[WebPreferences _objectCacheSize]):
   15657         (-[WebPreferences _backForwardCacheExpirationInterval]):
   15658         * WebView.subproj/WebPreferencesPrivate.h:
   15659 
   15660 2004-04-27  David Hyatt  <hyatt (a] apple.com>
   15661 
   15662         Cut the time spent on an operation inside widthForNextCharacter from 17% of the function time down to less than 
   15663         5% merely by adding a check for non-zero letter-spacing (thus avoiding double precision math in the 
   15664         common case where we just add 0 between letters).
   15665         Reviewed by rjw
   15666 
   15667         * WebCoreSupport.subproj/WebTextRenderer.m:
   15668         (widthForNextCharacter):
   15669 
   15670 2004-04-28  John Sullivan  <sullivan (a] apple.com>
   15671 
   15672         Initial plumbing to get the font panel to be updated from an editable
   15673         WebView.
   15674 
   15675         Reviewed by Ken.
   15676 
   15677         * WebView.subproj/WebView.m:
   15678         (-[WebView _textAttributesFromStyle:]):
   15679         new dummy method, will need implementation
   15680         (-[WebView _updateFontPanel]):
   15681         new method, sets the font shown in the font panel from the current
   15682         selection. Lots of placeholder stuff.
   15683         (-[WebView setSelectedDOMRange:affinity:]):
   15684         call _updateFontPanel here for now.
   15685 
   15686 2004-04-28  Ken Kocienda  <kocienda (a] apple.com>
   15687 
   15688         Reviewed by Darin
   15689 
   15690         * WebCoreSupport.subproj/WebBridge.m:
   15691         (-[WebBridge postDidChangeNotification]): Posts Cocoa notification when the document changes
   15692         due to editing.
   15693         (-[WebBridge postDidChangeSelectionNotification]): Posts Cocoa notification when the document selection
   15694         changes.
   15695         * WebKit.exp: Export editing notification string constants.
   15696         * WebView.subproj/WebView.m: Define editing notification string constants.
   15697         (-[WebView computedStyleForElement:pseudoElement:]): Add implementation.
   15698         (-[WebView setEditingDelegate:]): Do work to set up delegate to receive notification callbacks.
   15699         (-[WebView DOMDocument]): Simplify to just call the bridge DOMDocument. No need to jump through hoops here.
   15700         (-[WebView insertNewline:]): Consult delegate before taking action.
   15701         (-[WebView deleteBackward:]): Ditto.
   15702         (-[WebView insertText:]): Ditto.
   15703 
   15704 2004-04-27  John Sullivan  <sullivan (a] apple.com>
   15705 
   15706         Fixed broken development build.
   15707 
   15708         * WebView.subproj/WebFrame.m:
   15709         (-[WebFrame _transitionToLayoutAcceptable]):
   15710         updated bad variable name used only in LOG statement to match
   15711         recent change.
   15712 
   15713 2004-04-27  Richard Williamson   <rjw (a] apple.com>
   15714 
   15715         Fixes for:
   15716 
   15717         <rdar://problem/3279301>: API: WebKitErrorCannotFindPlugin and WebKitErrorCannotLoadPlugin should use PlugIn
   15718         <rdar://problem/3278513>: API: Need API to control the size of WebHistory
   15719         <rdar://problem/3564519>: API: please add a way to set the media type for a WebView
   15720         <rdar://problem/3565642>: API: allow a way to extend the MIME types that a WebView will display
   15721         <rdar://problem/3577693>: API: add ability to subclass WebView but still use it with Carbon
   15722         
   15723         Reviewed by Chris.
   15724 
   15725         * Carbon.subproj/HIWebView.h:
   15726         * Carbon.subproj/HIWebView.m:
   15727         (HIWebViewCreate):
   15728         (HIWebViewCreateWithClass):
   15729         (HIWebViewConstructor):
   15730         * History.subproj/WebHistory.h:
   15731         * History.subproj/WebHistory.m:
   15732         (-[WebHistoryPrivate setHistoryAgeInDaysLimit:]):
   15733         (-[WebHistoryPrivate historyAgeInDaysLimit]):
   15734         (-[WebHistoryPrivate setHistoryItemLimit:]):
   15735         (-[WebHistoryPrivate historyItemLimit]):
   15736         (-[WebHistoryPrivate _ageLimitDate]):
   15737         (-[WebHistoryPrivate arrayRepresentation]):
   15738         (-[WebHistory setHistoryItemLimit:]):
   15739         (-[WebHistory historyItemLimit]):
   15740         (-[WebHistory setHistoryAgeInDaysLimit:]):
   15741         (-[WebHistory historyAgeInDaysLimit]):
   15742         * History.subproj/WebHistoryPrivate.h:
   15743         * Misc.subproj/WebKitErrors.h:
   15744         * Misc.subproj/WebKitErrors.m:
   15745         (registerErrors):
   15746         * Plugins.subproj/WebNetscapePluginDocumentView.m:
   15747         (-[WebNetscapePluginDocumentView setDataSource:]):
   15748         * WebCoreSupport.subproj/WebBridge.m:
   15749         (-[WebBridge isViewSelected:]):
   15750         (-[WebBridge overrideMediaType]):
   15751         * WebView.subproj/WebView.h:
   15752         * WebView.subproj/WebView.m:
   15753         (-[WebViewPrivate dealloc]):
   15754         (+[WebView MIMETypesShownAsHTML]):
   15755         (+[WebView setMIMETypesShownAsHTML:]):
   15756         (-[WebView customUserAgent]):
   15757         (-[WebView setMediaStyle:]):
   15758         (-[WebView mediaStyle]):
   15759         * WebView.subproj/WebViewPrivate.h:
   15760 
   15761 2004-04-27  David Hyatt  <hyatt (a] apple.com>
   15762 
   15763         Eliminate the preferences for timed/resource layouts.  Accessing them is now taking 0.5% on the cvs-base
   15764         test, so we're just going to hardcode the values instead.
   15765         Reviewed by mjs
   15766 
   15767         * WebView.subproj/WebFrame.m:
   15768         (-[WebFrame _transitionToLayoutAcceptable]):
   15769         (-[WebFrame _isLoadComplete]):
   15770         * WebView.subproj/WebPreferences.m:
   15771         (+[WebPreferences initialize]):
   15772         (-[WebPreferences _objectCacheSize]):
   15773         * WebView.subproj/WebPreferencesPrivate.h:
   15774         * WebView.subproj/WebView.m:
   15775         (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]):
   15776 
   15777 2004-04-27  Ken Kocienda  <kocienda (a] apple.com>
   15778 
   15779         Reviewed by Hyatt
   15780         
   15781         Make selections draw in a more Cocoa-like way, where
   15782         fully-selected lines draw out to the ends of lines, and
   15783         spaces between lines are drawn with the selection color as well.
   15784 
   15785         * Misc.subproj/WebKitNSStringExtras.m: Use new WebCoreTextGeometry struct. No change in functionality.
   15786         * WebCoreSupport.subproj/WebTextRenderer.m:
   15787         (-[WebTextRenderer drawRun:style:geometry:]): Use new WebCoreTextGeometry struct. No change in functionality.
   15788         (-[WebTextRenderer drawHighlightForRun:style:geometry:]): Ditto.
   15789         (-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]): Many changes to add the new selection drawing behavior.
   15790         (-[WebTextRenderer _CG_drawRun:style:geometry:]):  Use new WebCoreTextGeometry struct. No change in functionality.
   15791         (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]): Many changes to add the new selection drawing behavior.
   15792         (-[WebTextRenderer _ATSU_drawRun:style:geometry:]):  Use new WebCoreTextGeometry struct. No change in functionality.
   15793 
   15794 2004-04-26  Richard Williamson   <rjw (a] apple.com>
   15795 
   15796         Added support for specifying composite operation on an
   15797         image element, i.e.:
   15798 
   15799         <img composite="source-over" src="triangle.png">
   15800         <img style="position:relative; left:-200px;" composite="destination-in" src="circle.png">
   15801 
   15802         This feature was requested by the dashboard guys.  They can use it to apply
   15803         transparency masks to widgies.
   15804 
   15805 
   15806         Reviewed by Ken.
   15807 
   15808         * WebCoreSupport.subproj/WebImageRenderer.h:
   15809         * WebCoreSupport.subproj/WebImageRenderer.m:
   15810         (-[WebImageRenderer initWithMIMEType:]):
   15811         (-[WebImageRenderer initWithData:MIMEType:]):
   15812         (-[WebImageRenderer initWithContentsOfFile:]):
   15813         (-[WebImageRenderer copyWithZone:]):
   15814         (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):
   15815         (-[WebImageRenderer drawImageInRect:fromRect:]):
   15816         (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:]):
   15817 
   15818 2004-04-26  Chris Blumenberg  <cblu (a] apple.com>
   15819 
   15820         More header doc changes after John's review.
   15821         * WebView.subproj/WebDataSourcePrivate.h:
   15822         * WebView.subproj/WebResource.h:
   15823 
   15824 2004-04-26  Chris Blumenberg  <cblu (a] apple.com>
   15825 
   15826         * WebView.subproj/WebDataSourcePrivate.h: added some header doc comments
   15827         * WebView.subproj/WebFramePrivate.h: fixed header doc typo
   15828 
   15829 2004-04-24  Darin Adler  <darin (a] apple.com>
   15830 
   15831         Reviewed by Dave.
   15832 
   15833         * Misc.subproj/WebNSURLExtras.m: (hexDigit): Use capitalized hex, not lowercase, for consistency
   15834         with similar functions in WebCore and what other web browsers do.
   15835 
   15836 2004-04-23  Darin Adler  <darin (a] apple.com>
   15837 
   15838         Reviewed by Maciej.
   15839 
   15840         - fixed <rdar://problem/3627362>: "bad access with libgmalloc in -[_WebCoreHistoryProvider containsItemForURLUnicode:length:]"
   15841 
   15842         * History.subproj/WebHistory.m:
   15843         (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]): Add range checks so we
   15844         don't overrun the buffer while looking for slashes.
   15845 
   15846 2004-04-23  Chris Blumenberg  <cblu (a] apple.com>
   15847 
   15848         Reviewed by John
   15849 
   15850         Added header doc comments to proposed API's.
   15851 
   15852         * WebView.subproj/WebArchive.h:
   15853         * WebView.subproj/WebFramePrivate.h:
   15854         * WebView.subproj/WebResource.h:
   15855 
   15856 === Safari-138 ===
   15857 
   15858 2004-04-23  Ken Kocienda  <kocienda (a] apple.com>
   15859 
   15860         Reviewed by John
   15861 
   15862         Added some plumbing for applying styles.
   15863 
   15864         * DOM.subproj/DOMExtensions.h: Copied from WebCore.
   15865         * WebView.subproj/WebView.m:
   15866         (-[WebView DOMDocument]): Added new helper.
   15867         (-[WebView styleDeclarationWithText:]): Added new helper.
   15868         * WebView.subproj/WebViewPrivate.h: Declare above methods.
   15869 
   15870 2004-04-22  Richard Williamson   <rjw (a] apple.com>
   15871 
   15872         Updates to plugin binding APIs.
   15873         Updates to Java plugin APIs.
   15874         Transparency fix for Dashboard.
   15875         Reviewed by John and Greg Bolsinga.
   15876 
   15877         * Plugins.subproj/WebPluginJava.h: Added.
   15878         New API for Java plugin.        
   15879 
   15880         * Plugins.subproj/npfunctions.h:
   15881         * Plugins.subproj/npruntime.h:
   15882         (_NPString::):
   15883         (_NPString::_NPVariant::):
   15884         * Plugins.subproj/npsap.h: Added.
   15885         New API for plugin bindings.        
   15886 
   15887         * WebView.subproj/WebHTMLView.m:
   15888         (-[WebHTMLView drawRect:]):
   15889         Update for Dashboard.  View must fill with transparency when not
   15890         drawing background.        
   15891 
   15892         * copy-webcore-files-to-webkit:
   15893 
   15894 2004-04-22  Ken Kocienda  <kocienda (a] apple.com>
   15895 
   15896         Reviewed by Hyatt
   15897 
   15898         More work to bring code up to date with the latest API proposal. Note that
   15899         all of the replaceXXX methods below now operate on the current selection, so
   15900         the method implementations have been simplifed accordingly.
   15901 
   15902         * WebView.subproj/WebDataSource.m:
   15903         (-[WebDataSource _replaceSelectionWithArchive:]): New name for _replaceSelectionWithWebArchive.
   15904         * WebView.subproj/WebDataSourcePrivate.h: Ditto.
   15905         * WebView.subproj/WebDefaultEditingDelegate.m:
   15906         (-[WebDefaultEditingDelegate webViewShouldBeginEditing:inDOMRange:]): Added inDOMRange: parameter.
   15907         (-[WebDefaultEditingDelegate webViewShouldEndEditing:inDOMRange:]): Ditto.
   15908         (-[WebDefaultEditingDelegate webView shouldChangeSelectedDOMRange:toDOMRange:proposedRange affinity:stillSelecting:]):
   15909         Missed adding affinity in last patch.
   15910         * WebView.subproj/WebHTMLView.m:
   15911         (-[WebHTMLView _pasteFromPasteboard:]): Call old method with new name: _replaceSelectionWithArchive
   15912         * WebView.subproj/WebView.m:
   15913         (-[WebView replaceSelectionWithNode:]): New version of insertNode:replacingDOMRange:
   15914         (-[WebView replaceSelectionWithText:]): New version of insertText:replacingDOMRange:
   15915         (-[WebView replaceSelectionWithMarkupString:]): New version of insertMarkupString:replacingDOMRange:
   15916         (-[WebView replaceSelectionWithArchive:]): New version of insertWebArchive:replacingDOMRange:
   15917         (-[WebView deleteSelection]): New version of deleteDOMRange:
   15918         (-[WebView applyStyle:]): New version of applyStyle:toElementsInDOMRange:
   15919         * WebView.subproj/WebViewPrivate.h:
   15920 
   15921 2004-04-22  Ken Kocienda  <kocienda (a] apple.com>
   15922 
   15923         Reviewed by John
   15924 
   15925         Adds the notion of selection affinity to the editing API, bringing it up to
   15926         date with the latest proposal.
   15927 
   15928         * WebView.subproj/WebView.m:
   15929         (-[WebView _alterCurrentSelection:direction:granularity:]): Pass selection affinity
   15930         to the delegate. We can just pass the current one since this does not change with arrow keys.
   15931         (-[WebView setSelectedDOMRange:affinity:]): Set the affinity on the selection.
   15932         (-[WebView selectionAffinity]): New accessor.
   15933         (-[WebView insertNode:replacingDOMRange:]): Change to pass selection affinity to call
   15934         to set selection. This is just to get the code to compile for now, since this method
   15935         will soon be removed in place of a similar one from the latest proposal that always
   15936         works on the current selection.
   15937         (-[WebView insertText:replacingDOMRange:]): Ditto.
   15938         (-[WebView insertMarkupString:replacingDOMRange:]): Ditto.
   15939         (-[WebView insertWebArchive:replacingDOMRange:]): Ditto.
   15940         (-[WebView deleteDOMRange:]): Ditto.
   15941         (-[WebView applyStyle:toElementsInDOMRange:]): Ditto.
   15942         * WebView.subproj/WebViewPrivate.h: Add selection affinity to API declarations as needed.
   15943 
   15944 2004-04-22  Ken Kocienda  <kocienda (a] apple.com>
   15945 
   15946         Reviewed by Darin
   15947 
   15948         Work around this bug:
   15949         <rdar://problem/3630640>: "Calling interpretKeyEvents: in a custom text view can fail to process keys right after app startup"
   15950 
   15951         * WebView.subproj/WebView.m:
   15952         (-[WebView _editingKeyDown:]): The issue is with a message to nil in AppKit
   15953         key binding manager code. Add call to [NSKeyBindingManager sharedKeyBindingManager] to make
   15954         sure the not-supposed-to-be-nil object is created before calling interpretKeyEvents:.
   15955 
   15956 2004-04-22  Ken Kocienda  <kocienda (a] apple.com>
   15957 
   15958         Reviewed by Hyatt
   15959 
   15960         Added calls to ensure caret visibility after the editing action is done.
   15961 
   15962         * WebView.subproj/WebView.m:
   15963         (-[WebView _alterCurrentSelection:direction:granularity:]):
   15964         (-[WebView insertNewline:]):
   15965         (-[WebView deleteBackward:]):
   15966         (-[WebView insertText:]):
   15967 
   15968 2004-04-20  Chris Blumenberg  <cblu (a] apple.com>
   15969 
   15970         Fixed: <rdar://problem/3605209>: "HITLIST: REGRESSION (131-132): iframes/frames no longer dump on layout tests"
   15971 
   15972         Reviewed by hyatt.
   15973 
   15974         * WebView.subproj/WebHTMLRepresentation.m:
   15975         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): the encoding was not being set in the about:blank case. Call receivedData:textEncodingName: as we did in the past to set it.
   15976 
   15977 2004-04-20  Ken Kocienda  <kocienda (a] apple.com>
   15978 
   15979         Reviewed by Hyatt
   15980 
   15981          Added implementations for these methods.
   15982 
   15983         * WebView.subproj/WebView.m:
   15984         (-[WebView moveUpAndModifySelection:]):
   15985         (-[WebView moveWordLeft:]):
   15986         (-[WebView moveWordLeftAndModifySelection:]):
   15987         (-[WebView moveWordRight:]):
   15988         (-[WebView moveWordRightAndModifySelection:]):
   15989 
   15990 2004-04-20  John Sullivan  <sullivan (a] apple.com>
   15991 
   15992         - fixed <rdar://problem/3622393>: When in stealth mode, visited webpage 
   15993         contents should not be cached to disk
   15994 
   15995         Reviewed by Ken.
   15996 
   15997         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   15998         (-[WebBaseResourceHandleDelegate willCacheResponse:]):
   15999         if will cache to disk and in stealth mode, replace cache response with
   16000         an identical one that won't cache to disk.
   16001 
   16002 2004-04-19  Ken Kocienda  <kocienda (a] apple.com>
   16003 
   16004         Reviewed by Hyatt
   16005 
   16006         * WebView.subproj/WebView.m:
   16007         (-[WebView moveDown:]): Added implementation.
   16008         (-[WebView moveUp:]): Added implementation.
   16009 
   16010 2004-04-19  Chris Blumenberg  <cblu (a] apple.com>
   16011 
   16012         Added support for pasting frames via WebArchives.
   16013 
   16014         Reviewed by kocienda.
   16015 
   16016         * WebView.subproj/WebDataSource.m:
   16017         (-[WebDataSource _addSubframeArchives:]): renamed, now allows subframe archives to be added at anytime
   16018         (-[WebDataSource _popSubframeArchiveWithName:]): renamed, now deletes the returned subframe to consume less memory
   16019         (-[WebDataSource _replaceSelectionWithWebArchive:]): added support for subframes
   16020         * WebView.subproj/WebDataSourcePrivate.h:
   16021         * WebView.subproj/WebFrame.m:
   16022         (-[WebFrame _loadRequest:subresources:subframeArchives:]): call renamed methods
   16023         (-[WebFrame _loadURL:intoChild:]): ditto
   16024         * WebView.subproj/WebHTMLRepresentation.m:
   16025         (-[WebHTMLRepresentation loadArchive]): ditto
   16026 
   16027 === Safari-137 ===
   16028 
   16029 2004-04-16  Richard Williamson   <rjw (a] apple.com>
   16030 
   16031         Added an SPI to allow ObjC instances to be easily bound to 
   16032         JS.  This is needed by the dashboard guys for their prototyping.
   16033         Eventually they will use new API.
   16034 
   16035         Reviewed by Chris.
   16036 
   16037         * WebView.subproj/WebView.m:
   16038         (-[WebView _bindObject:withName:toFrame:]):
   16039         * WebView.subproj/WebViewPrivate.h:
   16040 
   16041 2004-04-16  Chris Blumenberg  <cblu (a] apple.com>
   16042 
   16043         Fixed: <rdar://problem/3587599>: Mail Page, Web Archives don't preserve subframes
   16044         Moved code that assembled subresource URLs from DOM nodes from WebCore to WebKit.
   16045 
   16046         Reviewed by rjw.
   16047 
   16048         * DOM.subproj/DOMExtensions.h: copied from WebCore
   16049         * DOM.subproj/WebDOMOperations.h:
   16050         * DOM.subproj/WebDOMOperations.m:
   16051         (-[DOMNode webArchive]): call renamed methods
   16052         (-[DOMNode markupString]): ditto
   16053         (-[DOMNode _URLsFromSelectors:]): new, returns array of URLs given selectors
   16054         (-[DOMNode _subresourceURLs]): new, base class does nothing, subclasses call _URLsFromSelectors with URL selectors
   16055         (-[DOMDocument webFrame]): new
   16056         (-[DOMRange webArchive]): call renamed methods
   16057         (-[DOMRange markupString]): ditto
   16058         (-[DOMHTMLBodyElement _subresourceURLs]): new
   16059         (-[DOMHTMLInputElement _subresourceURLs]): new
   16060         (-[DOMHTMLLinkElement _subresourceURLs]): new
   16061         (-[DOMHTMLScriptElement _subresourceURLs]): new
   16062         (-[DOMHTMLImageElement _subresourceURLs]): new
   16063         (-[DOMHTMLEmbedElement _subresourceURLs]): new
   16064         (-[DOMHTMLObjectElement _subresourceURLs]): new
   16065         (-[DOMHTMLParamElement _subresourceURLs]): new
   16066         (-[DOMHTMLTableElement _subresourceURLs]): new
   16067         (-[DOMHTMLTableCellElement _subresourceURLs]): new
   16068         * WebKit.pbproj/project.pbxproj:
   16069         * WebView.subproj/WebArchive.h:
   16070         * WebView.subproj/WebArchive.m:
   16071         (-[WebArchivePrivate dealloc]): release new subframeArchives ivar
   16072         (-[WebArchive initWithMainResource:subresources:subframeArchives:]): take subframeArchives
   16073         (-[WebArchive _initWithPropertyList:]): new, recursively creates WebArchives
   16074         (-[WebArchive initWithData:]): call _initWithPropertyList
   16075         (-[WebArchive subframeArchives]): new
   16076         (-[WebArchive _propertyListRepresentation]): new, recursively creates property lists of WebArchives
   16077         (-[WebArchive data]): call _propertyListRepresentation
   16078         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   16079         (-[WebBaseResourceHandleDelegate saveResource]): call renamed methods
   16080         * WebView.subproj/WebDataSource.m:
   16081         (-[WebDataSourcePrivate dealloc]): release new pendingSubframeArchives ivar
   16082         (-[WebDataSource _archiveWithMarkupString:nodes:]): renamed and reimplemented, handles subframes
   16083         (-[WebDataSource _archive]): new
   16084         (-[WebDataSource _setPendingSubframeArchives:]): new
   16085         (-[WebDataSource _archiveForFrameName:]): new
   16086         * WebView.subproj/WebDataSourcePrivate.h:
   16087         * WebView.subproj/WebFrame.m:
   16088         (-[WebFrame loadArchive:]): handle subframes
   16089         (-[WebFrame _loadRequest:subresources:subframeArchives:]): ditto
   16090         (-[WebFrame _loadURL:intoChild:]): use the subframe archive if we have it
   16091         (-[WebFrame loadRequest:]): call renamed methods
   16092         * WebView.subproj/WebFramePrivate.h:
   16093         * WebView.subproj/WebHTMLRepresentation.m:
   16094         (-[WebHTMLRepresentation loadWebArchive]): call renamed methods and handle subframes
   16095         * WebView.subproj/WebHTMLView.m:
   16096         (-[WebHTMLView _selectedArchive:]): call renamed methods
   16097         (-[WebHTMLView _pasteFromPasteboard:]): call renamed methods
   16098         * WebView.subproj/WebHTMLViewPrivate.h:
   16099         * WebView.subproj/WebImageRepresentation.h:
   16100         * WebView.subproj/WebImageRepresentation.m: instead of storing some items from the data source, just store the data source
   16101         (-[WebImageRepresentation dealloc]): removed use of deleted ivars
   16102         (-[WebImageRepresentation URL]): use dataSource instead of ivar
   16103         (-[WebImageRepresentation doneLoading]): use new boolean ivar
   16104         (-[WebImageRepresentation setDataSource:]): store the data source
   16105         (-[WebImageRepresentation receivedData:withDataSource:]): use dataSource instead of ivar
   16106         (-[WebImageRepresentation receivedError:withDataSource:]): ditto
   16107         (-[WebImageRepresentation finishedLoadingWithDataSource:]): ditto
   16108         (-[WebImageRepresentation title]): ditto
   16109         (-[WebImageRepresentation data]): ditto
   16110         (-[WebImageRepresentation filename]): ditto
   16111         (-[WebImageRepresentation archive]): ditto
   16112         * WebView.subproj/WebResource.h:
   16113         * WebView.subproj/WebResource.m:
   16114         (-[WebResourcePrivate dealloc]): release new frame name ivar
   16115         (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): take a frame name
   16116         (-[WebResource frameName]): new
   16117         (-[WebResource _initWithPropertyList:]): handle frame name
   16118         (-[WebResource _initWithCachedResponse:originalURL:]): call renamed methods
   16119         (-[WebResource _propertyListRepresentation]):
   16120         * WebView.subproj/WebResourcePrivate.h: handle frame name
   16121 
   16122 2004-04-15  David Hyatt  <hyatt (a] apple.com>
   16123 
   16124         Make sure isOpaque returns NO when the WebHTMLVIew doesn't draw its background.
   16125         Reviewed by darin
   16126 
   16127         * WebView.subproj/WebFrameView.m:
   16128         (-[WebFrameView isOpaque]):
   16129         * WebView.subproj/WebHTMLView.m:
   16130         (-[WebHTMLView isOpaque]):
   16131 
   16132 2004-04-15  John Sullivan  <sullivan (a] apple.com>
   16133 
   16134         * WebView.subproj/WebPreferencesPrivate.h:
   16135         added comments
   16136 
   16137 2004-04-14  Richard Williamson   <rjw (a] apple.com>
   16138 
   16139         Updated fix for 3576315.  Don't hardcode 22 as the titlebar
   16140         height.  (Note, other places in CarbonWindowFrame DO hardcode
   16141         window geometry information, yuck!).
   16142 
   16143         Reviewed by Hyatt.
   16144 
   16145         * Carbon.subproj/CarbonWindowFrame.m:
   16146 
   16147 2004-04-14  John Sullivan  <sullivan (a] apple.com>
   16148 
   16149         - changed stealth mode preference name from "historyIsFrozen"
   16150         to "privateBrowsingEnabled"
   16151 
   16152         Reviewed by Darin.
   16153 
   16154         * WebView.subproj/WebFrame.m:
   16155         (-[WebFrame _transitionToCommitted:]):
   16156         updated for method name change
   16157         
   16158         * WebView.subproj/WebPreferences.m:
   16159         changed preference key name
   16160         (+[WebPreferences initialize]):
   16161         updated for preference key name change
   16162         (-[WebPreferences setPrivateBrowsingEnabled:]):
   16163         changed name from setHistoryIsFrozen:
   16164         (-[WebPreferences privateBrowsingEnabled]):
   16165         changed name from historyIsFrozen:
   16166         
   16167         * WebView.subproj/WebPreferencesPrivate.h:
   16168         changed declared method names
   16169 
   16170         * English.lproj/StringsNotToBeLocalized.txt:
   16171         updated for this and other recent changes
   16172 
   16173 2004-04-13  Chris Blumenberg  <cblu (a] apple.com>
   16174 
   16175         - Added WebElementDOMNodeKey as a potential API so that clients can get the node from an element dictionary.
   16176         - Removed WebElementIsEditableKey. This functionality is available via [DOMNode isContentEditable].
   16177 
   16178         Reviewed by rjw.
   16179 
   16180         * DOM.subproj/WebDOMOperations.h:
   16181         * DOM.subproj/WebDOMOperations.m:
   16182         (-[DOMDocument URLWithRelativeString:]): new potential API
   16183         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   16184         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): indenting tweak
   16185         (-[WebDefaultUIDelegate copyImageToClipboard:]): use WebElementDOMNodeKey
   16186         * WebView.subproj/WebHTMLView.m:
   16187         (-[WebHTMLView _handleMouseDragged:]): use WebElementDOMNodeKey
   16188         (-[WebHTMLView _dragOperationForDraggingInfo:]): use isContentEditable
   16189         * WebView.subproj/WebView.h:
   16190         * WebView.subproj/WebView.m:
   16191         * WebView.subproj/WebViewPrivate.h:
   16192 
   16193 2004-04-13  Chris Blumenberg  <cblu (a] apple.com>
   16194 
   16195         Fixed deployment build failure.
   16196 
   16197         Reviewed by john.
   16198 
   16199         * WebView.subproj/WebHTMLView.m:
   16200         (-[WebHTMLView _handleMouseDragged:]): removed use of fileWrapper variable
   16201 
   16202 2004-04-12  Chris Blumenberg  <cblu (a] apple.com>
   16203 
   16204         Factored out WebArchive to DOM code so that it could be used by both [WebHTMLView _pasteFromPasteboard:] and [WebView insertWebArchive:replacingDOMRange:].
   16205 
   16206         Reviewed by kocienda.
   16207 
   16208         * WebView.subproj/WebDataSource.m:
   16209         (-[WebDataSource _replaceSelectionWithMarkupString:baseURL:]): moved from WebHTMLView
   16210         (-[WebDataSource _replaceSelectionWithImageResource:]): ditto
   16211         (-[WebDataSource _replaceSelectionWithWebArchive:]): ditto
   16212         * WebView.subproj/WebDataSourcePrivate.h:
   16213         * WebView.subproj/WebHTMLView.m:
   16214         (-[WebHTMLView _replaceSelectionWithMarkupString:]): renamed
   16215         (-[WebHTMLView _pasteFromPasteboard:]): call renamed methods
   16216         * WebView.subproj/WebView.m:
   16217         (-[WebView insertMarkupString:replacingDOMRange:]): call renamed methods
   16218         (-[WebView insertWebArchive:replacingDOMRange:]): have data source handle the archive instead of the bridge
   16219 
   16220 2004-04-12  Ken Kocienda  <kocienda (a] apple.com>
   16221 
   16222         Reviewed by Dave
   16223         
   16224         Added execCommand support for cut/copy/paste.
   16225 
   16226         * WebCoreSupport.subproj/WebBridge.m:
   16227         (-[WebBridge issueCutCommand]): Glue for calling from WebCore to do a cut in Cocoa.
   16228         (-[WebBridge issueCopyCommand]): Same as above, but for copy.
   16229         (-[WebBridge issuePasteCommand]): Same as above, but for paste.
   16230         * WebView.subproj/WebHTMLView.m:
   16231         (-[WebHTMLView copy:]): Move this to private implementation category so the bridge can see it.
   16232         (-[WebHTMLView cut:]): Ditto.
   16233         (-[WebHTMLView paste:]): Ditto.
   16234         * WebView.subproj/WebHTMLViewPrivate.h: Move copy;, cut:, and paste: to private implementation 
   16235         category so the bridge can see it.
   16236         * WebView.subproj/WebView.m:
   16237         (-[WebView copy:]): Implemented by calling WebHTMLView to do the work.
   16238         (-[WebView cut:]): Ditto.
   16239         (-[WebView paste:]): Ditto.
   16240         * WebView.subproj/WebViewPrivate.h: Added all the NSReponder methods we plan to implement as
   16241         part of the WebKit editing API.
   16242 
   16243 2004-04-09  Ken Kocienda  <kocienda (a] apple.com>
   16244 
   16245         Reviewed by Darin
   16246 
   16247         Stubbed in the entire WebKit editing API, improving some
   16248         methods already present in minor ways, and adding those 
   16249         methods not yet present.
   16250 
   16251         * WebCoreSupport.subproj/WebBridge.m:
   16252         (-[WebBridge editingKeyDown:]):
   16253         * WebView.subproj/WebDefaultEditingDelegate.m:
   16254         (-[WebDefaultEditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:stillSelecting:]):
   16255         * WebView.subproj/WebHTMLView.m:
   16256         (-[WebHTMLView _pasteMarkupString:]):
   16257         * WebView.subproj/WebView.m:
   16258         (-[WebView _alterCurrentSelection:direction:granularity:]):
   16259         (-[WebView _currentSelectionIsEditable]):
   16260         (-[WebView computedStyleForElement:pseudoElement:]):
   16261         (-[WebView _editingKeyDown:]):
   16262         (-[WebView setEditable:]):
   16263         (-[WebView isEditable]):
   16264         (-[WebView setTypingStyle:]):
   16265         (-[WebView typingStyle]):
   16266         (-[WebView setSmartInsertDeleteEnabled:]):
   16267         (-[WebView smartInsertDeleteEnabled]):
   16268         (-[WebView setContinuousSpellCheckingEnabled:]):
   16269         (-[WebView isContinuousSpellCheckingEnabled]):
   16270         (-[WebView spellCheckerDocumentTag]):
   16271         (-[WebView undoManager]):
   16272         (-[WebView insertNode:replacingDOMRange:]):
   16273         (-[WebView insertText:replacingDOMRange:]):
   16274         (-[WebView insertMarkupString:replacingDOMRange:]):
   16275         (-[WebView insertWebArchive:replacingDOMRange:]):
   16276         (-[WebView deleteDOMRange:]):
   16277         (-[WebView applyStyle:toElementsInDOMRange:]):
   16278         (-[WebView centerSelectionInVisibleArea:]):
   16279         (-[WebView moveBackward:]):
   16280         (-[WebView moveBackwardAndModifySelection:]):
   16281         (-[WebView moveDown:]):
   16282         (-[WebView moveDownAndModifySelection:]):
   16283         (-[WebView moveForward:]):
   16284         (-[WebView moveForwardAndModifySelection:]):
   16285         (-[WebView moveLeft:]):
   16286         (-[WebView moveLeftAndModifySelection:]):
   16287         (-[WebView moveRight:]):
   16288         (-[WebView moveRightAndModifySelection:]):
   16289         (-[WebView moveToBeginningOfDocument:]):
   16290         (-[WebView moveToBeginningOfLine:]):
   16291         (-[WebView moveToBeginningOfParagraph:]):
   16292         (-[WebView moveToEndOfDocument:]):
   16293         (-[WebView moveToEndOfLine:]):
   16294         (-[WebView moveToEndOfParagraph:]):
   16295         (-[WebView moveUp:]):
   16296         (-[WebView moveUpAndModifySelection:]):
   16297         (-[WebView moveWordBackward:]):
   16298         (-[WebView moveWordBackwardAndModifySelection:]):
   16299         (-[WebView moveWordForward:]):
   16300         (-[WebView moveWordForwardAndModifySelection:]):
   16301         (-[WebView moveWordLeft:]):
   16302         (-[WebView moveWordLeftAndModifySelection:]):
   16303         (-[WebView moveWordRight:]):
   16304         (-[WebView moveWordRightAndModifySelection:]):
   16305         (-[WebView pageDown:]):
   16306         (-[WebView pageUp:]):
   16307         (-[WebView scrollLineDown:]):
   16308         (-[WebView scrollLineUp:]):
   16309         (-[WebView scrollPageDown:]):
   16310         (-[WebView scrollPageUp:]):
   16311         (-[WebView selectAll:]):
   16312         (-[WebView selectParagraph:]):
   16313         (-[WebView selectLine:]):
   16314         (-[WebView selectWord:]):
   16315         (-[WebView copy:]):
   16316         (-[WebView cut:]):
   16317         (-[WebView paste:]):
   16318         (-[WebView copyFont:]):
   16319         (-[WebView pasteFont:]):
   16320         (-[WebView delete:]):
   16321         (-[WebView pasteAsPlainText:]):
   16322         (-[WebView pasteAsRichText:]):
   16323         (-[WebView changeFont:]):
   16324         (-[WebView changeAttributes:]):
   16325         (-[WebView changeDocumentBackgroundColor:]):
   16326         (-[WebView changeColor:]):
   16327         (-[WebView alignCenter:]):
   16328         (-[WebView alignJustified:]):
   16329         (-[WebView alignLeft:]):
   16330         (-[WebView alignRight:]):
   16331         (-[WebView indent:]):
   16332         (-[WebView insertTab:]):
   16333         (-[WebView insertBacktab:]):
   16334         (-[WebView insertNewline:]):
   16335         (-[WebView insertParagraphSeparator:]):
   16336         (-[WebView changeCaseOfLetter:]):
   16337         (-[WebView uppercaseWord:]):
   16338         (-[WebView lowercaseWord:]):
   16339         (-[WebView capitalizeWord:]):
   16340         (-[WebView deleteForward:]):
   16341         (-[WebView deleteBackward:]):
   16342         (-[WebView deleteBackwardByDecomposingPreviousCharacter:]):
   16343         (-[WebView deleteWordForward:]):
   16344         (-[WebView deleteWordBackward:]):
   16345         (-[WebView deleteToBeginningOfLine:]):
   16346         (-[WebView deleteToEndOfLine:]):
   16347         (-[WebView deleteToBeginningOfParagraph:]):
   16348         (-[WebView deleteToEndOfParagraph:]):
   16349         (-[WebView complete:]):
   16350         (-[WebView checkSpelling:]):
   16351         (-[WebView showGuessPanel:]):
   16352         (-[WebView performFindPanelAction:]):
   16353         (-[WebView startSpeaking:]):
   16354         (-[WebView stopSpeaking:]):
   16355         (-[WebView insertText:]):
   16356         * WebView.subproj/WebViewPrivate.h:
   16357 
   16358 2004-04-09  Darin Adler  <darin (a] apple.com>
   16359 
   16360         Reviewed by Ken.
   16361 
   16362         - added "transparent mode"
   16363 
   16364         * WebView.subproj/WebFrameInternal.h: Added. Contains _updateDrawsBackground.
   16365         * WebView.subproj/WebFrame.m:
   16366         (-[WebFrame _makeDocumentView]): Call _updateDrawsBackground to tell the newly created
   16367         KHTMLView whether to draw a background or not.
   16368         (-[WebFrame _setState:]): Don't tell the scroll view to start drawing background if the
   16369         WebView is not supposed to draw a background.
   16370         (-[WebFrame _updateDrawsBackground]): Call setDrawsBackground: on the bridge, and do the
   16371         same for all subframes.
   16372 
   16373         * WebView.subproj/WebFrameView.m: (-[WebFrameView setFrameSize:]): Only call setDrawsBackground:YES
   16374         on the scroll view if the WebView has drawsBackground set to YES.
   16375 
   16376         * WebView.subproj/WebViewPrivate.h: Added new proposed API, setDrawsBackground and drawsBackground.
   16377         Also added drawsBackground boolean to private structure.
   16378         * WebView.subproj/WebView.m:
   16379         (-[WebView _commonInitializationWithFrameName:groupName:]): Set drawsBackground to YES by default.
   16380         (-[WebView setDrawsBackground:]): Added. Sets boolean and calls _updateDrawsBackground to update
   16381         the flag for each frame.
   16382         (-[WebView drawsBackground]): Added. Returns value of boolean.
   16383         (-[WebView _bridgeForCurrentSelection]): Tweaked comment for no good reason.
   16384 
   16385         * WebView.subproj/WebViewInternal.h: Added, but empty for the moment.
   16386         * WebView.subproj/WebFramePrivate.h: Tweaked a bit.
   16387 
   16388 2004-04-08  Chris Blumenberg  <cblu (a] apple.com>
   16389 
   16390         Fixed:
   16391         <rdar://problem/3616873>: support for pasting and drag and dropping of URLS to editable WebViews
   16392         <rdar://problem/3546417>: support for pasting and drag and dropping of images to editable WebViews
   16393 
   16394         Reviewed by rjw.
   16395 
   16396         * DOM.subproj/WebDOMOperations.h:
   16397         * DOM.subproj/WebDOMOperations.m:
   16398         (-[DOMNode webArchive]): renamed from "archive" because "archive" collides with DOMHTMLObjectElement's method
   16399         (-[DOMRange webArchive]): ditto
   16400         * Misc.subproj/WebNSPasteboardExtras.h:
   16401         * Misc.subproj/WebNSPasteboardExtras.m:
   16402         (-[NSPasteboard _web_writeImage:URL:title:archive:]): take just an archive instead of an HTML string and file wrapper
   16403         * Misc.subproj/WebNSViewExtras.h:
   16404         * Misc.subproj/WebNSViewExtras.m:
   16405         (-[NSView _web_dragImage:archive:rect:URL:title:event:]): take just an archive instead of an HTML string and file wrapper
   16406         * WebView.subproj/WebDataProtocol.h:
   16407         * WebView.subproj/WebDataProtocol.m:
   16408         (+[NSURL _web_uniqueWebDataURL]): new
   16409         (+[NSURL _web_uniqueWebDataURLWithRelativeString:]): new
   16410         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   16411         (-[WebDefaultUIDelegate copyImageToClipboard:]): call renamed _web_writeImage
   16412         * WebView.subproj/WebFrame.m:
   16413         (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]): use _web_uniqueWebDataURL for creating a URL
   16414         * WebView.subproj/WebHTMLView.m:
   16415         (-[WebHTMLView _pasteImageResource:]): new
   16416         (-[WebHTMLView _pasteFromPasteboard:]): renamed, now handles images and URLs
   16417         (-[WebHTMLView _handleMouseDragged:]): call renamed _web_dragImage
   16418         (-[WebHTMLView paste:]): call renamed _pasteFromPasteboard
   16419         (-[WebHTMLView concludeDragOperation:]): call renamed _pasteFromPasteboard
   16420         * WebView.subproj/WebHTMLViewPrivate.h:
   16421         * WebView.subproj/WebImageRepresentation.h:
   16422         * WebView.subproj/WebImageRepresentation.m:
   16423         (-[WebImageRepresentation archive]): new
   16424         * WebView.subproj/WebImageView.m:
   16425         (-[WebImageView writeImageToPasteboard:]): call renamed _web_writeImage
   16426         (-[WebImageView mouseDragged:]): call renamed _web_dragImage
   16427 
   16428 === Safari-136 ===
   16429 
   16430 2004-04-08  Chris Blumenberg  <cblu (a] apple.com>
   16431 
   16432         Fixed: <rdar://problem/3548274>: API: DOM API for WebKit clients
   16433 
   16434         Reviewed by kocienda.
   16435 
   16436         * DOM.subproj/DOM.h: copied from WebCore
   16437         * WebKit.pbproj/project.pbxproj: made our DOM headers public!
   16438 
   16439 2004-04-08  Chris Blumenberg  <cblu (a] apple.com>
   16440 
   16441         Moved WebArchive to its own file.
   16442 
   16443         Reviewed by kocienda.
   16444 
   16445         * WebKit.pbproj/project.pbxproj:
   16446         * WebView.subproj/WebArchive.h: Added.
   16447         * WebView.subproj/WebArchive.m: Added.
   16448         (-[WebArchive data]): renamed from dataRepresentation
   16449         * WebView.subproj/WebDataSource.m:
   16450         * WebView.subproj/WebFrame.m:
   16451         * WebView.subproj/WebHTMLRepresentation.m:
   16452         * WebView.subproj/WebHTMLView.m:
   16453         (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed [WebArchive data]
   16454         * WebView.subproj/WebResource.h:
   16455         * WebView.subproj/WebResource.m:
   16456 
   16457 2004-04-07  Chris Blumenberg  <cblu (a] apple.com>
   16458 
   16459         Created WebDOMOperations which are WebKit-specific categories on DOM objects.
   16460 
   16461         Reviewed by rjw.
   16462 
   16463         * DOM.subproj/DOMExtensions.h:
   16464         * DOM.subproj/WebDOMOperations.h: Added.
   16465         * DOM.subproj/WebDOMOperations.m: Added.
   16466         (-[DOMNode _bridge]): new
   16467         (-[DOMNode archive]): new
   16468         (-[DOMNode markupString]): new
   16469         (-[DOMRange _bridge]): new
   16470         (-[DOMRange archive]): new
   16471         (-[DOMRange markupString]): new
   16472         (-[DOMHTMLImageElement image]):
   16473         * WebCoreSupport.subproj/WebBridge.h:
   16474         * WebCoreSupport.subproj/WebBridge.m:
   16475         (-[WebBridge webFrame]): new
   16476         * WebKit.pbproj/project.pbxproj:
   16477         * WebView.subproj/WebDataSource.m:
   16478         (-[WebDataSource _archiveWithMarkupString:subresourceURLStrings:]): moved from WebHTMLRepresentation
   16479         * WebView.subproj/WebDataSourcePrivate.h:
   16480         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   16481         (-[WebDefaultUIDelegate copyImageToClipboard:]): call markupString on the node
   16482         * WebView.subproj/WebDocumentPrivate.h:
   16483         * WebView.subproj/WebFrame.m:
   16484         (+[WebFrame frameForDOMDocument:]): new
   16485         (-[WebFrame loadArchive:]): renamed
   16486         * WebView.subproj/WebFramePrivate.h:
   16487         * WebView.subproj/WebHTMLRepresentation.h:
   16488         * WebView.subproj/WebHTMLRepresentation.m:
   16489         * WebView.subproj/WebHTMLRepresentationPrivate.h:
   16490         * WebView.subproj/WebHTMLView.m:
   16491         (-[WebHTMLView _selectedArchive:]): renamed
   16492         (-[WebHTMLView _handleMouseDragged:]): called renamed methods
   16493 
   16494 2004-04-07  Darin Adler  <darin (a] apple.com>
   16495 
   16496         Reviewed by Chris.
   16497 
   16498         * DOM.subproj/DOMCSS.h: Updated from WebCore.
   16499 
   16500 2004-04-07  Ken Kocienda  <kocienda (a] apple.com>
   16501 
   16502         Reviewed by Darin and Dave (many weeks ago....I am so ashamed for not landing)
   16503 
   16504         * WebCoreSupport.subproj/WebBridge.m:
   16505         (-[WebBridge expiresTimeForResponse:]): Now adds in the difference between
   16506         the Mac OS X epoch and the "standard" unix epoch when passing back a time
   16507         that WebCore will use for its cache expiration determinations. 
   16508 
   16509 2004-04-07  Richard Williamson   <rjw (a] apple.com>
   16510 
   16511         Fix for 3604388.  The runtime version check (_CFExecutableLinkedOnOrAfter) used by many of
   16512         our frameworks doesn't work for CFM apps.  So, conditional panther bugs fixes aren't
   16513         being pickup by CFM apps that use WebKit, specifically Contribute.  This particular radar
   16514         describes a problem that was conditionally fixed in the AppKit for panther.  The work-around
   16515         is to force NSBitmapImageRep to execute to conditional code.
   16516 
   16517         Reviewed by Maciej.
   16518 
   16519         * Carbon.subproj/CarbonUtils.m:
   16520         (WebInitForCarbon):
   16521 
   16522 2004-04-06  Richard Williamson   <rjw (a] apple.com>
   16523 
   16524         Fixed 3510805.  Only release pool in timer if the current nesting level of the
   16525         pool matches the nesting level when the pool was created.
   16526 
   16527         Reviewed by Chris.
   16528 
   16529         * Carbon.subproj/CarbonUtils.m:
   16530         (getNumPools):
   16531         (WebInitForCarbon):
   16532         (PoolCleaner):
   16533 
   16534 2004-04-06  Chris Blumenberg  <cblu (a] apple.com>
   16535 
   16536         Fixed: <rdar://problem/3613974>: remove "to Clipboard" from context menus because it is redundant
   16537 
   16538         Reviewed by john.
   16539 
   16540         * English.lproj/Localizable.strings:
   16541         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   16542         (-[WebDefaultUIDelegate menuItemWithTag:]):
   16543 
   16544 2004-04-06  Ken Kocienda  <kocienda (a] apple.com>
   16545 
   16546         Reviewed by Dave
   16547 
   16548         * WebCoreSupport.subproj/WebBridge.m:
   16549         (-[WebBridge issueUndoCommand]): New method. Forwards call to the undo manager. Added
   16550         to support undo called via Javascript execCommand.
   16551         (-[WebBridge issueRedoCommand]): Ditto.
   16552 
   16553 2004-04-05  Chris Blumenberg  <cblu (a] apple.com>
   16554 
   16555         Fixed: <rdar://problem/3612580>: SPI: WebPlugin selection
   16556 
   16557         Reviewed by kocienda.
   16558 
   16559         * Plugins.subproj/WebPlugin.h: extended SPI for selection
   16560         * Plugins.subproj/WebPluginContainer.h: ditto
   16561         * Plugins.subproj/WebPluginController.m:
   16562         (-[WebPluginController selectionColor]): new, calls [WebCoreBridge selectionColor]
   16563         * WebCoreSupport.subproj/WebBridge.m:
   16564         (-[WebBridge setIsSelected:forView:]): new, calls [WebPlugin setIsSelected:]
   16565         (-[WebBridge isViewSelected:]): new, calls [WebPlugin isSelected]
   16566 
   16567 2004-04-02  Chris Blumenberg  <cblu (a] apple.com>
   16568 
   16569         Forgot to add the WebKit copy of DOMExtensions.h.
   16570 
   16571         * DOM.subproj/DOMExtensions.h: Added.
   16572 
   16573 2004-04-02  John Sullivan  <sullivan (a] apple.com>
   16574 
   16575         Reviewed by Dave.
   16576         
   16577         * WebView.subproj/WebPreferences.m:
   16578         (-[WebPreferences historyIsFrozen]):
   16579         take out OMIT_TIGER_FEATURES ifdeffing, since if we turn this into API
   16580         then we'll probably want it to work in Panther also. To protect Safari users,
   16581         Safari now explicitly sets historyIsFrozen to NO when starting up in Panther.
   16582 
   16583         * English.lproj/StringsNotToBeLocalized.txt:
   16584         updated for recent changes
   16585 
   16586 2004-04-02  Chris Blumenberg  <cblu (a] apple.com>
   16587 
   16588         Moved the DOM extensions to their own headers
   16589 
   16590         Reviewed by kocienda.
   16591 
   16592         * DOM.subproj/DOM.h: changed from WebCore
   16593         * DOM.subproj/DOMHTML.h: ditto
   16594         * WebKit.pbproj/project.pbxproj: added DOMExtensions.h
   16595         * copy-webcore-files-to-webkit: copy DOMExtensions.h
   16596 
   16597 === Safari-135 ===
   16598 
   16599 2004-04-01  Richard Williamson   <rjw (a] apple.com>
   16600 
   16601         Fixed 3609493.  Don't remove the plugin's view until after
   16602         sending pluginDestroy.  This change was requested by Greg
   16603         and is needed in the Lavender update.
   16604 
   16605         Reviewed by Greg Bolsinga.
   16606 
   16607         * Plugins.subproj/WebPluginController.m:
   16608         (-[WebPluginController destroyAllPlugins]):
   16609         * Plugins.subproj/npruntime.h:
   16610 
   16611 2004-03-31  John Sullivan  <sullivan (a] apple.com>
   16612 
   16613         - fixed <rdar://problem/3577917>: API: mechanism for displaying error 
   16614         page for failed page load
   16615         
   16616         This was not commented on for a week in macosx-api-reviewers, so it
   16617         has the silent rubber stamp of approval.
   16618         
   16619         Note that it isn't guarded by "Tiger only" availability macros because
   16620         we (probably) want to use it in Panther for Safari. Maybe what we should
   16621         do is guard the API with "Tiger only" macros but add an SPI version
   16622         that Safari uses?
   16623 
   16624         Reviewed by Dave.
   16625 
   16626         * WebView.subproj/WebDataSource.h:
   16627         moved unreachableURL to here
   16628         * WebView.subproj/WebDataSource.m:
   16629         (-[WebDataSource unreachableURL]):
   16630         moved this from private category to main section
   16631         
   16632         * WebView.subproj/WebDataSourcePrivate.h:
   16633         removed unreachableURL from here
   16634         
   16635         * WebView.subproj/WebFrame.h:
   16636         moved loadAlternateHTMLString... to here
   16637         * WebView.subproj/WebFrame.m:
   16638         (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]):
   16639         moved this from private category to main section
   16640         
   16641         * WebView.subproj/WebFramePrivate.h:
   16642         removed unreachableURL from here
   16643 
   16644 2004-03-31  Richard Williamson   <rjw (a] apple.com>
   16645 
   16646         Changed to reflect NP_runtime.h to npruntime.h.
   16647 
   16648         * copy-webcore-files-to-webkit:
   16649 
   16650 2004-03-31  John Sullivan  <sullivan (a] apple.com>
   16651 
   16652         Reviewed by Darin.
   16653 
   16654         * WebView.subproj/WebPreferences.m:
   16655         (-[WebPreferences historyIsFrozen]):
   16656         always return NO on Panther and older, so you can't get into a state
   16657         where the WebKit pref is invisibly set and affecting Safari.
   16658 
   16659 2004-03-31  Darin Adler  <darin (a] apple.com>
   16660 
   16661         * WebView.subproj/WebHTMLView.m: Whitespace tweaks.
   16662 
   16663 2004-03-30  Chris Blumenberg  <cblu (a] apple.com>
   16664 
   16665         Fixed: <rdar://problem/3604391>: Plug-in context menus (Flash) don't work in Carbon WebKit applications (e.g., CarbonWeb)
   16666 
   16667         Reviewed by rjw.
   16668 
   16669         * Carbon.subproj/HIWebView.m:
   16670         (ContextMenuClick): instead of calling menuForEvent (which is not implemented on our plug-in view) call rightMouseDown and let AppKit handle the rest
   16671 
   16672 2004-03-29  John Sullivan  <sullivan (a] apple.com>
   16673 
   16674         - some support for "Stealth Browsing"; add a preference that
   16675         controls whether a history item is added when a page is visited.
   16676         This is called "historyIsFrozen" for now, but I wouldn't be
   16677         surprised to see this name change.
   16678 
   16679         Reviewed by Dave.
   16680 
   16681         * WebView.subproj/WebPreferencesPrivate.h:
   16682         new historyIsFrozen, setHistoryIsFrozen: methods
   16683         
   16684         * WebView.subproj/WebPreferences.m:
   16685         new WebKitHistoryIsFrozenPreferenceKey
   16686         (+[WebPreferences initialize]):
   16687         set initial value of WebKitHistoryIsFrozenPreferenceKey
   16688         (-[WebPreferences setHistoryIsFrozen:]):
   16689         set value of WebKitHistoryIsFrozenPreferenceKey
   16690         (-[WebPreferences historyIsFrozen]):
   16691         read value of WebKitHistoryIsFrozenPreferenceKey
   16692 
   16693         * WebView.subproj/WebFrame.m:
   16694         (-[WebFrame _transitionToCommitted:]):
   16695         don't add item to history if history is frozen
   16696 
   16697 2004-03-29  Darin Adler  <darin (a] apple.com>
   16698 
   16699         Reviewed by John.
   16700 
   16701         - fixed <rdar://problem/3559178>: navigator.language always returns "en"
   16702 
   16703         * WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory defaultLanguageCode]):
   16704         Call +[NSUserDefaults _web_preferredLanguageCode] rather than returning "en".
   16705 
   16706         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
   16707 
   16708 2004-03-26  John Sullivan  <sullivan (a] apple.com>
   16709 
   16710         - fixed <rdar://problem/3576334>: Printing "empty" page gives print error, 
   16711         leaves browser window UI broken
   16712 
   16713         Reviewed by Dave.
   16714 
   16715         * WebView.subproj/WebHTMLView.m:
   16716         (-[WebHTMLView knowsPageRange:]):
   16717         AppKit printing mechanism can't handle the case where you tell it there is
   16718         nothing at all to print, so when we hit that case we give it a degenerate
   16719         1-pixel rect to print. This prints a blank page (with correctly-placed
   16720         header & footer if so configured), which matches other browsers' behavior for
   16721         this page.
   16722 
   16723         * Plugins.subproj/npruntime.h:
   16724         cvs keeps thinking I've removed a blank line from this auto-copied file.
   16725         Richard said to just check it in to see if it stops doing this.
   16726         
   16727 === Safari-134 ===
   16728 
   16729 2004-03-26  John Sullivan  <sullivan (a] apple.com>
   16730 
   16731         - fixed the following bugs:
   16732         
   16733         <rdar://problem/3601630>: command-modified keypresses that would activate links are ignored by WebKit
   16734         <rdar://problem/3601604>: WebActionModifierFlagsKey not set correctly for modified keypresses that activate links
   16735         <rdar://problem/3544946>: cmd-return should open a link in a new tab
   16736 
   16737         Reviewed by Darin.
   16738 
   16739         * WebView.subproj/WebFrame.m:
   16740         (-[WebFrame _actionInformationForNavigationType:event:originalURL:]):
   16741         Pass modifier flags always, not just for mouse events. This fixes 3601604.
   16742         
   16743         * WebView.subproj/WebHTMLView.m:
   16744         (-[WebHTMLView performKeyEquivalent:]):
   16745         Give the bridge a chance to intercept command-modified keypresses. This fixes 3601630.
   16746         
   16747         Together these two changes fix 3544946.
   16748 
   16749 2004-03-25  David Hyatt  <hyatt (a] apple.com>
   16750 
   16751         Implement the rest of the search field.
   16752 
   16753         Implement onscroll at the document level.
   16754         Reviewed by darin
   16755 
   16756         * English.lproj/Localizable.strings:
   16757         * WebCoreSupport.subproj/WebBridge.m:
   16758         * WebCoreSupport.subproj/WebViewFactory.m:
   16759         (-[NSMenu addItemWithTitle:action:tag:]):
   16760         (-[WebViewFactory submitButtonDefaultLabel]):
   16761         (-[WebViewFactory cellMenuForSearchField]):
   16762         * WebView.subproj/WebHTMLView.m:
   16763         (-[WebHTMLView _frameOrBoundsChanged]):
   16764         (-[WebHTMLView viewDidMoveToWindow]):
   16765         * WebView.subproj/WebHTMLViewPrivate.h:
   16766 
   16767 2004-03-25  Richard Williamson   <rjw (a] apple.com>
   16768 
   16769         Netscape plugin API header cleanup.
   16770 
   16771         Replaced our hacked up version of npapi.h with the
   16772         "official SDK"  npapi.h.  Moved our changes to the new
   16773         npfunctions.h.  npfunctions.h really replaces what was defined in
   16774         the Netscape npupp.h header.  However, rather than use the "official SDK"
   16775         npupp.h I think the cleaner npfunctions.h is better. npupp.h actually
   16776         has a bunch of Mac classic specific stuff that is no longer needed.
   16777 
   16778         Copied npruntime.h to WebKit using Ken's copy-o-matic mechanism.
   16779 
   16780         Made npapi.h, npruntime.h, and npfunctions.h SPI.  With a bit
   16781         more consideration they will become API.  They will also eventually be made
   16782         available for other platforms/vendors are mozilla.org.
   16783 
   16784         Reviewed by Ken.
   16785 
   16786         * Plugins.subproj/WebBaseNetscapePluginStream.h:
   16787         * Plugins.subproj/WebBaseNetscapePluginStream.m:
   16788         (-[WebBaseNetscapePluginStream dealloc]):
   16789         (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]):
   16790         * Plugins.subproj/WebBaseNetscapePluginView.h:
   16791         * Plugins.subproj/WebNetscapePluginPackage.h:
   16792         * Plugins.subproj/WebNetscapePluginPackage.m:
   16793         (-[WebNetscapePluginPackage load]):
   16794         * Plugins.subproj/npapi.h:
   16795         * Plugins.subproj/npruntime.h: Added.
   16796         * WebKit.pbproj/project.pbxproj:
   16797         * copy-webcore-files-to-webkit:
   16798 
   16799 2004-03-24  Darin Adler  <darin (a] apple.com>
   16800 
   16801         Reviewed by John.
   16802 
   16803         - fixed <rdar://problem/3566805>: REGRESSION: When the subject of mailto is 2 byte Safari failed to send mail address and subject to Mail.app
   16804 
   16805         * Misc.subproj/WebNSURLExtras.m: (applyHostNameFunctionToMailToURLString): Update to handle hostnames
   16806         that end just before a '?' since a '?' ends the entire part of the URL that can contain hostnames.
   16807         Also change the logic so that the '?' will successfully end the search.
   16808 
   16809 2004-03-24  Ken Kocienda  <kocienda (a] apple.com>
   16810 
   16811         Reviewed by me
   16812 
   16813         * DOM.subproj/DOMHTML.h: Checking in copied over version of
   16814         modified file.
   16815 
   16816 2004-03-23  David Hyatt  <hyatt (a] apple.com>
   16817 
   16818         Fix for 3513627, HTML mail prints upside down occasionally.  Change printing so that it never resizes the
   16819         WebHTMLView when formatting for printing.  When computing page rects, instead of using the view's bounds,
   16820         use the root layer's width instead.
   16821         Reviewed by darin
   16822 
   16823         * WebView.subproj/WebHTMLView.m:
   16824         (-[WebHTMLView knowsPageRange:]):
   16825 
   16826 === Safari-133 ===
   16827 
   16828 2004-03-17  David Hyatt  <hyatt (a] apple.com>
   16829 
   16830         Expose ageLimitDate so that the autocomplete code can access it.
   16831         Reviewed by john
   16832 
   16833         * History.subproj/WebHistory.m:
   16834         (-[WebHistory ageLimitDate]):
   16835         * History.subproj/WebHistoryPrivate.h:
   16836 
   16837 2004-03-17  Richard Williamson   <rjw (a] apple.com>
   16838 
   16839         Fixed 3591667.  Plugin view is added to view hierarchy before calling init.
   16840 
   16841         Reviewed by Ken.
   16842 
   16843         * WebView.subproj/WebHTMLView.m:
   16844         (-[WebHTMLView addSubview:]):
   16845 
   16846 2004-03-16  Darin Adler  <darin (a] apple.com>
   16847 
   16848         * DOM.subproj/DOMHTML.h: Updated from WebCore.
   16849         * DOM.subproj/DOMRange.h: Ditto.
   16850 
   16851 2004-03-16  Darin Adler  <darin (a] apple.com>
   16852 
   16853         Reviewed by Ken.
   16854 
   16855         - update for new DOM namespacing and header organization
   16856 
   16857         * DOM.subproj/DOM.h: Changed to include the other DOM headers.
   16858         * DOM.subproj/DOMCSS.h: Added.
   16859         * DOM.subproj/DOMCore.h: Added.
   16860         * DOM.subproj/DOMEvents.h: Added.
   16861         * DOM.subproj/DOMHTML.h: Added.
   16862         * DOM.subproj/DOMRange.h: Added.
   16863         * DOM.subproj/DOMStylesheets.h: Added.
   16864         * DOM.subproj/DOMTraversal.h: Added.
   16865         * DOM.subproj/DOMViews.h: Added.        
   16866         * WebKit.pbproj/project.pbxproj: Added new files.
   16867 
   16868         * WebView.subproj/WebDefaultEditingDelegate.m:
   16869         (-[WebDefaultEditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
   16870         (-[WebDefaultEditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
   16871         Change class names from CSS to DOMCSS.
   16872         * WebView.subproj/WebViewPrivate.h: Ditto.
   16873 
   16874         * copy-webcore-files-to-webkit: Add new files.
   16875 
   16876 2004-03-15  Ken Kocienda  <kocienda (a] apple.com>
   16877 
   16878         Reviewed by John
   16879 
   16880         Fix for this bug:
   16881         
   16882         <rdar://problem/3588717>: REGRESSION (125-131u): Tabbing to links and tabbing in bookmarks view no longer works
   16883 
   16884         WebView can't lay claim to -keyDown: just for editing events, as
   16885         this gets in the way of tab processing. The solution is to give
   16886         WebView a private method for processing editing key events fed to
   16887         it from over the bridge, and leave -keyDown: unimplemented. 
   16888 
   16889         * WebCoreSupport.subproj/WebBridge.m:
   16890         (-[WebBridge editingKeyDown:]): Changed from -keyDown: to keep 
   16891         terminology consistent with renamed WebView -editingKeyDown: method.
   16892         * WebView.subproj/WebView.m:
   16893         (-[WebView editingKeyDown:]): Give WebView a method to handle
   16894         editing key events in a way that does not interfere with other key down
   16895         events it processes.
   16896         * WebView.subproj/WebViewPrivate.h: Declare -editingKeyDown: method.
   16897 
   16898 === Safari-132 ===
   16899 
   16900 2004-03-15  Darin Adler  <darin (a] apple.com>
   16901 
   16902         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
   16903 
   16904 2004-03-12  Darin Adler  <darin (a] apple.com>
   16905 
   16906         Reviewed by Ken.
   16907 
   16908         - fixed <rdar://problem/3433887>: copied &nbsp; characters remain non-breaking spaces; other browsers give normal spaces
   16909 
   16910         * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _writeSelectionToPasteboard:]):
   16911         Convert non-breaking spaces to the normal kind in the plain text part of the pasteboard.
   16912 
   16913 2004-03-12  Ken Kocienda  <kocienda (a] apple.com>
   16914 
   16915         Reviewed by Chris
   16916 
   16917         * WebView.subproj/WebView.m:
   16918         (-[WebView _alterCurrentSelection:direction:granularity:]): Changed name from
   16919         _alterSelection:direction:granularity: to give a little extra clarity. Also, the
   16920         body calls through to renamed rangeByAlteringCurrentSelection:direction:granularity:
   16921         in WebCore.
   16922         (-[WebView moveRight:]): Now calls renamed _alterCurrentSelection:direction:granularity:.
   16923         (-[WebView moveRightAndModifySelection:]): Ditto.
   16924         (-[WebView moveLeft:]): Ditto.
   16925         (-[WebView moveLeftAndModifySelection:]): Ditto.
   16926 
   16927 2004-03-11  Richard Williamson   <rjw (a] apple.com>
   16928 
   16929         Workaround for 3585644.  Force the window number of the
   16930         mouse moved event to be correct.
   16931 
   16932         Reviewed by Chris.
   16933 
   16934         * Carbon.subproj/CarbonWindowFrame.m:
   16935         * Carbon.subproj/HIWebView.m:
   16936         (MouseMoved):
   16937         (MouseDragged):
   16938 
   16939 2004-03-11  Ken Kocienda  <kocienda (a] apple.com>
   16940 
   16941         Reviewed by Dave
   16942 
   16943         Various changes to begin implementing the draft API proposal. 
   16944 
   16945         * DOM.subproj/DOM.h: Checking in generated file.
   16946         * WebCoreSupport.subproj/WebBridge.m:
   16947         (-[WebBridge registerCommandForUndo:]): Now takes an id, a wrapped
   16948         WebCore EditCommand implementation object.
   16949         (-[WebBridge registerCommandForRedo:]): Ditto.
   16950         (-[WebBridge clearUndoRedoOperations]): Use the web view's undo manager.
   16951         (-[WebBridge keyDown:]): Pass keyDown events through to the web view.
   16952         * WebKit.pbproj/project.pbxproj:
   16953         * WebView.subproj/WebDefaultEditingDelegate.h: Added.
   16954         * WebView.subproj/WebDefaultEditingDelegate.m: Added. Stubbed in default
   16955         implementations declared in the draft editing API.
   16956         * WebView.subproj/WebFrame.m:
   16957         (-[WebFramePrivate dealloc]): WebFrame no longer has an undo manager.
   16958         * WebView.subproj/WebFramePrivate.h: Ditto.
   16959         * WebView.subproj/WebHTMLView.m:
   16960         (-[WebHTMLView _selectedWebArchive:]): selectedRange method 
   16961         is now selectedDOMRange.
   16962         * WebView.subproj/WebView.m:
   16963         (-[WebViewPrivate dealloc]): Dealloc new editingDelegateForwarder.
   16964         (-[WebView _editingDelegateForwarder]): Added. 
   16965         (-[WebView keyDown:]): Added. 
   16966         (-[WebView _bridgeForCurrentSelection]): Added. 
   16967         (-[WebView setSelectedDOMRange:]): Added. 
   16968         (-[WebView selectedDOMRange]): Added. 
   16969         (-[WebView insertText:]): Added. 
   16970         (-[WebView _alterSelection:direction:granularity:]): Added. 
   16971         (-[WebView selectWord:]): Added. 
   16972         (-[WebView moveRight:]): Added. 
   16973         (-[WebView moveRightAndModifySelection:]): Added. 
   16974         (-[WebView moveLeft:]): Added. 
   16975         (-[WebView moveLeftAndModifySelection:]): Added. 
   16976         (-[WebView deleteBackward:]): Added. 
   16977         (-[WebView insertNewline:]): Added. 
   16978         (-[WebView insertParagraphSeparator:]): Added. 
   16979         (-[WebView setEditingDelegate:]): Added. 
   16980         (-[WebView editingDelegate]): Added. 
   16981         (-[WebView undoManager]): Added. 
   16982         (-[WebView insertText:replacingDOMRange:]): Added. 
   16983         * WebView.subproj/WebViewPrivate.h: Added a collection of editing API 
   16984         declarations that will be public some day, but are still under review.
   16985 
   16986 2004-03-11  John Sullivan  <sullivan (a] apple.com>
   16987 
   16988         - fixed <rdar://problem/3585056>: Assertion failure if error page is loaded from 
   16989         webView:unableToImplementPolicyWithError:
   16990         - also added HeaderDoc comments to could-be-API-soon methods and fixed a
   16991         conceptual problem with said methods
   16992 
   16993         Reviewed by Darin.
   16994 
   16995         * WebView.subproj/WebDataSourcePrivate.h:
   16996         added HeaderDoc comment for -unreachableURL
   16997         
   16998         * WebView.subproj/WebFramePrivate.h:
   16999         added HeaderDoc comment for -loadAlternateHTMLString:baseURL:forUnreachableURL:;
   17000         also added boolean delegateIsHandlingUnimplementablePolicy ivar to WebFramePrivate
   17001         * WebView.subproj/WebFrame.m:
   17002         (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]):
   17003         treat delegateIsHandlingUnimplementablePolicy like delegateIsDecidingNavigationPolicy.
   17004         Safari serves up error pages during the latter but clients are equally or more likely
   17005         to do so during the former.
   17006         (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]):
   17007         set delegateIsHandlingUnimplementablePolicy during delegate callback
   17008         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
   17009         tweaked assertion so it doesn't erroneously fire for clients that call
   17010         loadAlternateHTML:baseURL:forUnreachableURL: while processing
   17011         webView:unableToImplementPolicyWithError:
   17012 
   17013 2004-03-11  Chris Blumenberg  <cblu (a] apple.com>
   17014 
   17015         Made WebArchive a class instead of a data object. This allows clients to easily get the main resource and subresources from a WebArchive.
   17016 
   17017         Reviewed by kocienda.
   17018 
   17019         * WebKit.exp:
   17020         * WebView.subproj/WebDocumentPrivate.h:
   17021         * WebView.subproj/WebFrame.m:
   17022         (-[WebFrame loadWebArchive:]):
   17023         * WebView.subproj/WebFramePrivate.h:
   17024         * WebView.subproj/WebHTMLRepresentation.m:
   17025         (-[WebHTMLRepresentation loadWebArchive]):
   17026         (-[WebHTMLRepresentation _webArchiveWithMarkupString:subresourceURLStrings:]):
   17027         (-[WebHTMLRepresentation webArchiveFromNode:]):
   17028         (-[WebHTMLRepresentation webArchiveFromRange:]):
   17029         * WebView.subproj/WebHTMLRepresentationPrivate.h:
   17030         * WebView.subproj/WebHTMLView.m:
   17031         (-[WebHTMLView _selectedWebArchive:]):
   17032         (-[WebHTMLView _writeSelectionToPasteboard:]):
   17033         (-[WebHTMLView _pasteMarkupFromPasteboard:]):
   17034         * WebView.subproj/WebResource.h:
   17035         * WebView.subproj/WebResource.m:
   17036         (-[WebArchivePrivate dealloc]):
   17037         (-[WebResource _response]):
   17038         (-[WebArchive init]):
   17039         (-[WebArchive initWithMainResource:subresources:]):
   17040         (-[WebArchive initWithData:]):
   17041         (-[WebArchive dealloc]):
   17042         (-[WebArchive mainResource]):
   17043         (-[WebArchive subresources]):
   17044         (-[WebArchive dataRepresentation]):
   17045         * WebView.subproj/WebResourcePrivate.h:
   17046 
   17047 2004-03-10  Chris Blumenberg  <cblu (a] apple.com>
   17048 
   17049         Made dragging of web archives work.
   17050 
   17051         Reviewed by rjw.
   17052 
   17053         * English.lproj/StringsNotToBeLocalized.txt: updated
   17054         * WebView.subproj/WebMainResourceClient.m:
   17055         (-[WebMainResourceClient connection:didReceiveResponse:]): added a FIXME about working around old Foundations that don't know about web archive files
   17056         * WebView.subproj/WebView.m:
   17057         (+[WebView canShowFile:]): tweak
   17058         (+[WebView suggestedFileExtensionForMIMEType:]): tweak
   17059         (+[WebView _MIMETypeForFile:]): handle web archive files since Foundation may be too old to know about them
   17060 
   17061 2004-03-09  Chris Blumenberg  <cblu (a] apple.com>
   17062 
   17063         Made web archives use NSPropertyListBinaryFormat_v1_0 instead of NSPropertyListXMLFormat_v1_0 because NSPropertyListBinaryFormat_v1_0 is 3-5 times faster to serialize and parse.
   17064 
   17065         Reviewed by rjw.
   17066 
   17067         * WebView.subproj/WebResource.m:
   17068         (+[WebResource _parseWebArchive:mainResource:subresources:]): add timing code
   17069         (+[WebResource _webArchiveWithMainResource:subresources:]): add timing code, use NSPropertyListBinaryFormat_v1_0
   17070 
   17071 2004-03-09  Chris Blumenberg  <cblu (a] apple.com>
   17072 
   17073         Fixed: <rdar://problem/3577508>: API: web archive related API's
   17074         Implemented WebKit side of: <rdar://problem/3144033>: ability to save web sites (images and all)
   17075 
   17076         Reviewed by rjw.
   17077 
   17078         * WebCoreSupport.subproj/WebBridge.h:
   17079         * WebCoreSupport.subproj/WebBridge.m:
   17080         (-[WebBridge receivedData:textEncodingName:]): renamed to take a textEncodingName instead of data source. The data source argument is only needed for the textEncodingName.
   17081         * WebKit.exp:
   17082         * WebView.subproj/WebDataSource.m:
   17083         (-[WebDataSource _subresourcesDictionary]): new
   17084         (+[WebDataSource _repTypesAllowImageTypeOmission:]): include "application/x-webarchive"
   17085         * WebView.subproj/WebDataSourcePrivate.h:
   17086         * WebView.subproj/WebDocumentInternal.h:
   17087         * WebView.subproj/WebDocumentPrivate.h:
   17088         * WebView.subproj/WebFrame.m:
   17089         (-[WebFrame loadWebArchive:]): renamed, code factored out to [WebResource _parseWebArchive:mainResource:subresources:]
   17090         * WebView.subproj/WebFramePrivate.h:
   17091         * WebView.subproj/WebFrameView.m:
   17092         (+[WebFrameView _viewTypesAllowImageTypeOmission:]): include "application/x-webarchive"
   17093         * WebView.subproj/WebHTMLRepresentation.h:
   17094         * WebView.subproj/WebHTMLRepresentation.m:
   17095         (-[WebHTMLRepresentationPrivate dealloc]):
   17096         (-[WebHTMLRepresentation _isDisplayingWebArchive]): new
   17097         (-[WebHTMLRepresentation receivedData:withDataSource:]): don't feed data to WebCore if we're displaying a web archive since web archive can't be progressively loaded
   17098         (-[WebHTMLRepresentation loadWebArchive]): new, feeds web archive data to WebCore
   17099         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): call loadWebArchive if necessary
   17100         (-[WebHTMLRepresentation documentSource]): if displaying a web archive, return the HTML source from within the archive
   17101         (-[WebHTMLRepresentation _webArchiveWithMarkupString:subresourceURLStrings:]): new
   17102         (-[WebHTMLRepresentation markupStringFromNode:]): implementation of new API
   17103         (-[WebHTMLRepresentation markupStringFromRange:]): ditto
   17104         (-[WebHTMLRepresentation webArchiveFromNode:]): ditto
   17105         (-[WebHTMLRepresentation webArchiveFromRange:]): ditto
   17106         * WebView.subproj/WebHTMLRepresentationPrivate.h:
   17107         * WebView.subproj/WebHTMLView.m:
   17108         (+[WebHTMLView _selectionPasteboardTypes]): use renamed WebArchivePboardType
   17109         (-[WebHTMLView _selectedWebArchive:]): renamed, call renamed methods
   17110         (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed methods
   17111         (-[WebHTMLView _haveSelection]): indentation tweak
   17112         (-[WebHTMLView _canDelete]): ditto
   17113         (-[WebHTMLView _canPaste]): ditto
   17114         (-[WebHTMLView _pasteMarkupFromPasteboard:]): renamed, call [WebResource _webArchiveWithMainResource:subresources:]
   17115         (-[WebHTMLView initWithFrame:]): use renamed WebArchivePboardType
   17116         (-[WebHTMLView paste:]): call renamed _pasteMarkupFromPasteboard
   17117         (-[WebHTMLView concludeDragOperation:]): call renamed _pasteMarkupFromPasteboard
   17118         * WebView.subproj/WebHTMLViewPrivate.h:
   17119         * WebView.subproj/WebMainResourceClient.m:
   17120         (-[WebMainResourceClient connection:didReceiveResponse:]): modify the MIME type for web archives since Foundation is not yet web archive aware. This is ifdef'd pre-Tiger code.
   17121         * WebView.subproj/WebResource.h:
   17122         * WebView.subproj/WebResource.m:
   17123         (+[WebResource _parseWebArchive:mainResource:subresources:]): new
   17124         (+[WebResource _webArchiveWithMainResource:subresources:]): new
   17125         * WebView.subproj/WebResourcePrivate.h:
   17126 
   17127 2004-03-09  John Sullivan  <sullivan (a] apple.com>
   17128 
   17129         - fixed the following bugs:
   17130         <rdar://problem/3579715>: Going to an error page in back/forward list doesn't work 
   17131         correctly in some cases
   17132         <rdar://problem/3581031>: REGRESSION (130+): World Leak of WebFrame after trying 
   17133         to load page with unknown scheme
   17134 
   17135         Reviewed by Darin.
   17136 
   17137         * WebView.subproj/WebDataSourcePrivate.h:
   17138         renamed __setRequest -> __adoptRequest
   17139         * WebView.subproj/WebDataSource.m:
   17140         (-[WebDataSource _URLForHistory]): 
   17141         updated comment
   17142         (-[WebDataSource __adoptRequest:]):
   17143         Renamed from __setRequest; now takes an NSMutableURLRequest and uses it as-is.
   17144         (-[WebDataSource _setRequest:]):
   17145         now saves a mutable copy, instead of relying on the caller to do so. The
   17146         (only) caller wasn't doing so in all cases, leading to trouble in River City.
   17147         Also, special-case unreachable URL handling to allow alternate content to 
   17148         replace a URL in a redirect-like way without sending a redirect callback.
   17149         
   17150         * WebView.subproj/WebFrame.m:
   17151         (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]):
   17152         renamed after discussion with Richard (was loadPlaceholderHTMLString:baseURL:unreachableURL:)
   17153         (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]):
   17154         new helper method, returns YES only if we receive a load request for alternate
   17155         content from a delegate for an unreachable URL while we are going back or forward.
   17156         That's a lot of prepositions!
   17157         (-[WebFrame _loadRequest:subresources:]):
   17158         if _shouldReloadToHandleUnreachableURLFromRequest: returns YES, change load type
   17159         to WebFrameLoadTypeReload so b/f list is preserved appropriately.
   17160         (-[WebFrame _transitionToCommitted:]):
   17161         Update currentItem in the unreachableURL case.
   17162         (-[WebFrame _isLoadComplete]):
   17163         Don't reset b/f list before calling provisionalLoadDidFail delegate; instead, determine 
   17164         where to reset b/f list beforehand, and then actually reset list afterwards only if we 
   17165         didn't start an alternate content load in the delegate. Also, set new boolean ivar so we
   17166         know when we're processing a provisionalLoadDidFail delegate callback.
   17167         (-[WebFrame _loadItem:withLoadType:]):
   17168         don't make extra copy before calling __adoptRequest; just pass it the one we made here.
   17169         (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
   17170         If we're loading alternate content for an unreachableURL, don't ask the decision listener,
   17171         just do it. (This avoids problem with nested calls to checking the navigation policy that
   17172         led to a WebFrame leak, and is conceptually the right thing to do also.) Also added some
   17173         asserts that helped me track down the WebFrame leak. Set new boolean ivar so we know
   17174         when we're processing a navigation policy delegate decision.
   17175         (-[WebFrame _currentBackForwardListItemToResetTo]):
   17176         new method, replaces _resetBackForwardListToCurrent. Does the same test as the
   17177         latter but returns a boolean rather than actually resetting.
   17178         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
   17179         save dataSource in a local var before calling stopLoading, and use it for
   17180         _setProvisionalDataSource, because otherwise stopLoading was clobbering the dataSource
   17181         for an unreachable URL handling case.
   17182         
   17183         * WebView.subproj/WebFramePrivate.h:
   17184         two new boolean ivars
   17185         
   17186         * WebView.subproj/WebView.m:
   17187         (+[WebView _canHandleRequest:]):
   17188         return YES when we're loading alternate content for an unreachable URL
   17189 
   17190 === Safari-131 ===
   17191 
   17192 2004-03-08  Ken Kocienda  <kocienda (a] apple.com>
   17193 
   17194         Reviewed by Darin
   17195 
   17196         * WebKit.pbproj/project.pbxproj: Added CFBundleName to Info.plist
   17197 
   17198 2004-03-05  Chris Blumenberg  <cblu (a] apple.com>
   17199 
   17200         Fixed: <rdar://problem/3560132>: REGRESSION: Safari crashed in -[NSPasteboard setData:forType:] dragging a map out of Mapquest.com
   17201 
   17202         Reviewed by john.
   17203 
   17204         * Misc.subproj/WebNSPasteboardExtras.m:
   17205         (-[NSPasteboard _web_writeImage:URL:title:fileWrapper:HTMLString:]): declare the pboard types by calling _web_writeURL:::: before calling setData::
   17206 
   17207 2004-03-05  John Sullivan  <sullivan (a] apple.com>
   17208 
   17209         First cut at WebKit support for showing error pages for unreachable URLs.
   17210         This doesn't work quite right with the back/forward list yet, but is
   17211         good enough for demos.
   17212 
   17213         Reviewed by Darin.
   17214 
   17215         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   17216         (-[WebBaseResourceHandleDelegate didReceiveResponse:]):
   17217         use new _webDataRequextExternalURL to share code
   17218         
   17219         * WebView.subproj/WebDataProtocol.h:
   17220         Three new methods (all internal to WebKit):
   17221         -[NSURLRequest _webDataRequestUnreachableURL], -[NSURLRequest _webDataRequestExternalURL],
   17222         -[NSURLRequest _webDataRequestSetUnreachableURL]
   17223         * WebView.subproj/WebDataProtocol.m:
   17224         new unreachableURL field of WebDataRequestParameters
   17225         (-[WebDataRequestParameters copyWithZone:]):
   17226         copy new field
   17227         (-[WebDataRequestParameters dealloc]):
   17228         release new field
   17229         (-[NSURLRequest _webDataRequestUnreachableURL]):
   17230         read new field
   17231         (-[NSURLRequest _webDataRequestExternalURL]):
   17232         new method, returns baseURL or "about:blank" for webdata protocol requests. This
   17233         was done in multiple places previously.
   17234         (-[NSURLRequest _webDataRequestExternalRequest]):
   17235         now calls _webDataRequestExternalURL to share code
   17236         (-[NSMutableURLRequest _webDataRequestSetUnreachableURL:]):
   17237         write new field
   17238         
   17239         * WebView.subproj/WebDataSource.m:
   17240         (-[WebDataSource unreachableURL]):
   17241         new method, might become API; returns the unreachable URL, if any, for which this datasource
   17242         holds placeholder content
   17243         (-[WebDataSource _URLForHistory]):
   17244         new method, returns the URL to be stored in History for this dataSource. This returns nil
   17245         for run-of-the-mill WebDataProtocol URLs (replacing code elsewhere that checked for this
   17246         case) but returns the unreachableURL for the case where this datasource holds placeholder
   17247         content.
   17248         (-[WebDataSource _setTitle:]):
   17249         now calls _URLForHistory
   17250         
   17251         * WebView.subproj/WebDataSourcePrivate.h:
   17252         added unreachableURL in the should-become-API section, and _URLForHistory elsewhere
   17253         
   17254         * WebView.subproj/WebFrame.m:
   17255         (-[WebFrame loadPlaceholderHTMLString:baseURL:unreachableURL:]):
   17256         new should-become-API method for displaying an error page for an unreachable URL
   17257         (-[WebFrame loadPropertyList:]):
   17258         updated to pass nil for unreachableURL
   17259         (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
   17260         added unreachableURL parameter, which gets set on the data request
   17261         (-[WebFrame _addBackForwardItemClippedAtTarget:]):
   17262         use _URLForHistory instead of just checking for WebDataProtocol
   17263         (-[WebFrame _createItem:]):
   17264         use unreachableURL if there is one
   17265         (-[WebFrame _transitionToCommitted:]):
   17266         use _URLForHistory instead of just checking for WebDataProtocol
   17267         (-[WebFrame _isLoadComplete]):
   17268         check whether a new load has started in the delegate callback and if so, don't
   17269         reset the loading state here
   17270         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
   17271         added unreachableURL parameter, which gets passed through
   17272         (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
   17273         send nil unreachableURL parameter
   17274         (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]):
   17275         new bottleneck method for loadHTMLString:baseURL: and loadPlaceholderHTMLString:baseURL:unreachableURL:;
   17276         this is the guts of loadHTMLString:baseURL: with the new unreachableURL parameter passed through
   17277         (-[WebFrame loadHTMLString:baseURL:]):
   17278         now calls new bottleneck method
   17279         
   17280         * WebView.subproj/WebFramePrivate.h:
   17281         added loadPlaceholderString:baseURL:unreachableURL: to should-be-API section; added unreachableURL
   17282         parameter to _webDataRequestForData:MIMEType:textEncodingName:baseURL:
   17283 
   17284 2004-03-04  Chris Blumenberg  <cblu (a] apple.com>
   17285 
   17286         - Made image dragging and copying always work without needing to re-download by using the data source's WebResource of the image instead of relying on the Foundation cache.
   17287         - Fixed a "drag to self" problem I introduced in my last check-in. You could drag a URL from a WebHTMLView and drop it on its own WebView which we shouldn't allow.
   17288 
   17289         Reviewed by rjw.
   17290 
   17291         * ChangeLog:
   17292         * WebCoreSupport.subproj/WebBridge.m:
   17293         (-[WebBridge fileWrapperForURL:]): call _fileWrapperForURL on WebDataSource
   17294         * WebView.subproj/WebDataSource.m:
   17295         (-[WebDataSource _fileWrapperForURL:]): moved from WebView, creates a wrapper from a WebResource
   17296         * WebView.subproj/WebDataSourcePrivate.h:
   17297         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   17298         (-[WebDefaultUIDelegate copyImageToClipboard:]): call [WebDataSource _fileWrapperForURL:]
   17299         * WebView.subproj/WebHTMLView.m:
   17300         (-[WebHTMLView _handleMouseDragged:]): call [WebDataSource _fileWrapperForURL:]
   17301         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call [WebDataSource _fileWrapperForURL:]
   17302         (-[WebHTMLView _dragOperationForDraggingInfo:]): new, factored out from draggingUpdated:
   17303         (-[WebHTMLView draggingEntered:]): call _dragOperationForDraggingInfo:, if NSDragOperationNone, forward to WebView to it can handle the drag
   17304         (-[WebHTMLView draggingUpdated:]): ditto
   17305         (-[WebHTMLView concludeDragOperation:]): ditto
   17306         * WebView.subproj/WebResource.m:
   17307         (-[WebResource _fileWrapperRepresentation]): new
   17308         * WebView.subproj/WebResourcePrivate.h:
   17309         * WebView.subproj/WebView.m:
   17310         (-[WebViewPrivate dealloc]): release draggedTypes, a new ivar that keeps track of drag types that we're currently registered for
   17311         (-[WebView _setDraggedTypes:]): new
   17312         (-[WebView unregisterDraggedTypes]): new, calls _setDraggedTypes then super
   17313         (-[WebView registerForDraggedTypes:]): ditto 
   17314         (-[WebView _dragOperationForDraggingInfo:]): new, compares the types on the pasteboard against the types we are currently registered for. Normally the AppKit handles this for us, but since these messages can be forwarded from WebHTMLView, we need to do this comparison ourselves. 
   17315         (-[WebView draggingEntered:]): calls _dragOperationForDraggingInfo:
   17316         (-[WebView draggingUpdated:]): ditto
   17317         (-[WebView concludeDragOperation:]): ditto
   17318         * WebView.subproj/WebViewPrivate.h: define new draggedTypes ivar
   17319 
   17320 2004-03-03  Chris Blumenberg  <cblu (a] apple.com>
   17321 
   17322         Fixed a typo.
   17323 
   17324         * WebView.subproj/WebHTMLView.m:
   17325         (-[WebHTMLView concludeDragOperation:]):
   17326 
   17327 2004-03-03  Chris Blumenberg  <cblu (a] apple.com>
   17328 
   17329         Fixed: <rdar://problem/3576070>: REGRESSION: web view won't accept drag of webloc file
   17330 
   17331         Reviewed by rjw.
   17332 
   17333         * WebView.subproj/WebHTMLView.m:
   17334         (-[WebHTMLView draggingUpdated:]): if we're not handling the drag, forward this message to the WebView since it may want to handle it
   17335         (-[WebHTMLView concludeDragOperation:]): if we're not handling the drag, forward this message to the WebView since it may want to handle it
   17336 
   17337 2004-03-03  Darin Adler  <darin (a] apple.com>
   17338 
   17339         Reviewed by Vicki.
   17340 
   17341         * English.lproj/InfoPlist.strings: Removed. No need to localize the version and
   17342         copyright string, and that's all that was in here.
   17343         * WebKit.pbproj/project.pbxproj: Removed InfoPlist.strings from build.
   17344 
   17345 2004-03-03  Ken Kocienda  <kocienda (a] apple.com>
   17346 
   17347         Reviewed by Chris
   17348 
   17349         * copy-webcore-files-to-webkit: Fixed up this script so that
   17350         it does not fail if it is running "non-locally", like for
   17351         B&I. The idiom is to check these files into WebKit after
   17352         copying them from WebCore, hence this script is merely
   17353         a convenience to keep the files in sync.
   17354 
   17355 2004-03-02  Ken Kocienda  <kocienda (a] apple.com>
   17356 
   17357         Reviewed by me
   17358 
   17359         * DOM.subproj/DOM.h: Checked in header copied over
   17360         from WebCore.
   17361 
   17362 2004-03-02  Richard Williamson   <rjw (a] apple.com>
   17363 
   17364         Added WebJavaScriptObject API.  The location of this file may
   17365         change.
   17366 
   17367         Reviewed by Chris.
   17368 
   17369         * Plugins.subproj/NP_objc.h: Added.
   17370         * WebKit.pbproj/project.pbxproj:
   17371 
   17372 2004-03-02  Chris Blumenberg  <cblu (a] apple.com>
   17373 
   17374         Fixed: <rdar://problem/3575598>: REGRESSION: Safari crashes at IS&T website
   17375 
   17376         Reviewed by darin.
   17377 
   17378         * WebView.subproj/WebDataSource.m:
   17379         (-[WebDataSourcePrivate dealloc]): don't stop the icon loader here because that can cause an infinite loop
   17380         (-[WebDataSource _stopLoadingInternal]): always stop the icon loader here instead of just when the data source is loading as well.
   17381 
   17382 === Safari-130 ===
   17383 
   17384 2004-03-02  Ken Kocienda  <kocienda (a] apple.com>
   17385 
   17386         Reviewed by me
   17387 
   17388         * DOM.subproj/DOM.h: Rollout last night's checkin.
   17389         The tree was closed.
   17390 
   17391 2004-03-01  Chris Blumenberg  <cblu (a] apple.com>
   17392 
   17393         Fixed: <rdar://problem/3574979>: REGRESSION (129-TOT): crash loading macromedia.com
   17394 
   17395         deliverResource was being called after it had already been called in setDefersCallbacks:.
   17396 
   17397         Reviewed by rjw.
   17398 
   17399         * WebView.subproj/WebBaseResourceHandleDelegate.h:
   17400         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   17401         (-[WebBaseResourceHandleDelegate deliverResource]): set deliveredResource to YES
   17402         (-[WebBaseResourceHandleDelegate deliverResourceAfterDelay]): new, calls deliverResource after a delay
   17403         (-[WebBaseResourceHandleDelegate loadWithRequest:]): call deliverResourceAfterDelay
   17404         (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): call deliverResourceAfterDelay
   17405 
   17406 2004-03-01  Ken Kocienda  <kocienda (a] apple.com>
   17407 
   17408         Reviewed by me
   17409 
   17410         * DOM.subproj/DOM.h: Checked in header copied over
   17411         from WebCore.
   17412 
   17413 2004-03-01  Ken Kocienda  <kocienda (a] apple.com>
   17414 
   17415         Reviewed by me
   17416 
   17417         * DOM.subproj/DOM.h: Oh, it's like the Keystone Cops this afternoon...
   17418         Backed out an unintended change to thsi file.
   17419 
   17420 2004-03-01  Ken Kocienda  <kocienda (a] apple.com>
   17421 
   17422         Reviewed by me
   17423 
   17424         * copy-webcore-files-to-webkit: Dumb typing error on my part in making
   17425         my previous quick fix. This quick fix works. 
   17426 
   17427 2004-03-01  Chris Blumenberg  <cblu (a] apple.com>
   17428 
   17429         Updated the WebKit project file to 1.1 because a previous check-in reverted to 1.01.
   17430 
   17431         * WebKit.pbproj/project.pbxproj:
   17432 
   17433 2004-03-01  Ken Kocienda  <kocienda (a] apple.com>
   17434 
   17435         Reviewed by me
   17436 
   17437         * copy-webcore-files-to-webkit: Made this file buildit-compliant
   17438 
   17439 2004-03-01  Chris Blumenberg  <cblu (a] apple.com>
   17440 
   17441         Found a bug in my last check-in. If a load that originates from a WebResource is cancelled before the data from the WebResource is delivered, callbacks are sent anyway. 
   17442 
   17443         Reviewed by rjw.
   17444 
   17445         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   17446         (-[WebBaseResourceHandleDelegate cancelWithError:]): cancel the perform request for deliverResource
   17447 
   17448 2004-03-01  Chris Blumenberg  <cblu (a] apple.com>
   17449 
   17450         Reviewed by darin.
   17451 
   17452         * Misc.subproj/WebIconLoader.m:
   17453         (-[WebIconLoader didFinishLoading]): rejigger handle code to avoid Deployment failure
   17454         * WebKit.pbproj/project.pbxproj:
   17455 
   17456 2004-03-01  Chris Blumenberg  <cblu (a] apple.com>
   17457 
   17458         - Made WebResource loading not use Foundation at all. This allows "Mail Page" and paste to more directly load subresources without any indirection involving NSURLConnection and the Foundation cache.
   17459         - Made WebIconLoader a subclass of WebBaseResourceHandleDelegate. This makes favicons appear in the activity window among other things.
   17460 
   17461         Reviewed by kocienda.
   17462 
   17463         * Misc.subproj/WebIconLoader.h:
   17464         * Misc.subproj/WebIconLoader.m: removed connection and data ivars since WebBaseResourceHandleDelegate holds these 
   17465         (-[WebIconLoaderPrivate dealloc]): removed calls to deleted ivars
   17466         (-[WebIconLoader URL]): call renamed request ivar
   17467         (-[WebIconLoader startLoading]): call loadWithRequest
   17468         (-[WebIconLoader stopLoading]): call cancel
   17469         (-[WebIconLoader didFinishLoading]):
   17470         * Plugins.subproj/WebNetscapePluginStream.m:
   17471         (-[WebNetscapePluginConnectionDelegate didReceiveResponse:]): renamed to be connection-less since callbacks may came from a WebResource and not an NSURLConnection
   17472         (-[WebNetscapePluginConnectionDelegate didReceiveData:lengthReceived:]): ditto
   17473         (-[WebNetscapePluginConnectionDelegate didFinishLoading]): ditto
   17474         (-[WebNetscapePluginConnectionDelegate didFailWithError:]): ditto
   17475         * WebCoreSupport.subproj/WebSubresourceClient.m:
   17476         (-[WebSubresourceClient didReceiveResponse:]): ditto
   17477         (-[WebSubresourceClient didReceiveData:lengthReceived:]): ditto
   17478         (-[WebSubresourceClient didFinishLoading]): ditto
   17479         (-[WebSubresourceClient didFailWithError:]): ditto
   17480         * WebKit.pbproj/project.pbxproj:
   17481         * WebView.subproj/WebBaseResourceHandleDelegate.h:
   17482         * WebView.subproj/WebBaseResourceHandleDelegate.m:
   17483         (-[WebBaseResourceHandleDelegate loadWithRequest:]): instead of storing the resource in the Foundation cache in order to later load it from the cache, deliver the callbacks ourselves after a delay
   17484         (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): call deliverResource if callbacks are turned back on
   17485         (-[WebBaseResourceHandleDelegate deliverResource]): new, calls didReceiveResponse:, didReceiveData:lengthReceived:, and didFinishLoading
   17486         (-[WebBaseResourceHandleDelegate willSendRequest:redirectResponse:]): renamed to be connection-less since callbacks may came from a WebResource and not an NSURLConnection
   17487         (-[WebBaseResourceHandleDelegate didReceiveAuthenticationChallenge:]): ditto
   17488         (-[WebBaseResourceHandleDelegate didCancelAuthenticationChallenge:]): ditto
   17489         (-[WebBaseResourceHandleDelegate didReceiveResponse:]): ditto
   17490         (-[WebBaseResourceHandleDelegate didReceiveData:lengthReceived:]): ditto
   17491         (-[WebBaseResourceHandleDelegate didFinishLoading]): ditto
   17492         (-[WebBaseResourceHandleDelegate didFailWithError:]): ditto
   17493         (-[WebBaseResourceHandleDelegate willCacheResponse:]): ditto
   17494         (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): calls connection-less version of this method
   17495         (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): ditto
   17496         (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): ditto
   17497         (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): ditto
   17498         (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): ditto
   17499         (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): ditto
   17500         (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): ditto
   17501         (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): ditto
   17502         (-[WebBaseResourceHandleDelegate cancelWithError:]): call renamed _completeProgressForConnectionDelegate on WebView
   17503         (-[WebBaseResourceHandleDelegate cancelledError]): tweak
   17504         * WebView.subproj/WebDataSource.m:
   17505         (-[WebDataSource _loadIcon]): set the data source on the icon loader so it can callback
   17506         * WebView.subproj/WebResource.m:
   17507         (-[WebResource _response]): new, factored out from _cachedResponseRepresentation
   17508         (-[WebResource _cachedResponseRepresentation]): call _response
   17509         * WebView.subproj/WebResourcePrivate.h:
   17510         * WebView.subproj/WebView.m:
   17511         (-[WebView _incrementProgressForConnectionDelegate:response:]): renamed to be connection-less
   17512         (-[WebView _incrementProgressForConnectionDelegate:data:]): ditto
   17513         (-[WebView _completeProgressForConnectionDelegate:]): ditto
   17514         * WebView.subproj/WebViewPrivate.h:
   17515 
   17516 2004-03-01  Ken Kocienda  <kocienda (a] apple.com>
   17517 
   17518         Reviewed by Darin
   17519         
   17520         Changed all Objective-C DOM classes from protocols to classes. 
   17521 
   17522         * DOM.subproj/DOM-compat.h:
   17523         * DOM.subproj/DOM.h:
   17524         * WebCoreSupport.subproj/WebBridge.m:
   17525         (-[WebBridge loadURL:referrer:reload:onLoadEvent:target:triggeringEvent:form:formValues:]):
   17526         (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
   17527         * WebView.subproj/WebFormDelegate.h:
   17528         * WebView.subproj/WebFormDelegate.m:
   17529         (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
   17530         * WebView.subproj/WebFrame.m:
   17531         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
   17532         (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
   17533         (-[WebFormState initWithForm:values:sourceFrame:]):
   17534         (-[WebFormState form]):
   17535         * WebView.subproj/WebFramePrivate.h:
   17536         * WebView.subproj/WebHTMLRepresentation.h:
   17537         * WebView.subproj/WebHTMLRepresentation.m:
   17538         (-[WebHTMLRepresentation DOMDocument]):
   17539         (-[WebHTMLRepresentation setSelectionFrom:startOffset:to:endOffset:]):
   17540         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
   17541         (-[WebHTMLRepresentation elementWithName:inForm:]):
   17542         (-[WebHTMLRepresentation elementForView:]):
   17543         (-[WebHTMLRepresentation elementDoesAutoComplete:]):
   17544         (-[WebHTMLRepresentation elementIsPassword:]):
   17545         (-[WebHTMLRepresentation formForElement:]):
   17546         (-[WebHTMLRepresentation controlsInForm:]):
   17547         (-[WebHTMLRepresentation searchForLabels:beforeElement:]):
   17548         (-[WebHTMLRepresentation matchLabels:againstElement:]):
   17549 
   17550 2004-02-27  John Sullivan  <sullivan (a] apple.com>
   17551 
   17552         - WebKit changes to allow performance improvements to bookmarks 
   17553 
   17554         Reviewed by Darin.
   17555 
   17556         * History.subproj/WebHistoryItemPrivate.h:
   17557         added notificationsSuppressed/setNotificationsSuppressed, and setURLString
   17558         * History.subproj/WebHistoryItem.m:
   17559         (-[WebHistoryItem setNotificationsSuppressed:]):
   17560         setter for new flag. When this flag is set, making changes to the WebHistoryItem
   17561         will not cause WebHistoryChanged notifications to be sent. This is a big speedup
   17562         for reading bookmarks from disk, since currently each WebBookmarkLeaf object
   17563         keeps around a WebHistoryItem object that isn't really part of history and thus
   17564         doesn't need to send notifications about history changing.
   17565         (-[WebHistoryItem notificationsSuppressed]):
   17566         getter for new flag
   17567         (-[WebHistoryItem setURLString:]):
   17568         new method, extracted from guts of setURL:; this allows callers (though
   17569         currently only callers at Apple) that have a URL string in hand to set
   17570         it directly on the WebHistoryItem rather than converting to a URL and
   17571         back, both relatively slow operations. Also, doesn't sent a notification
   17572         if notifications are suppressed.
   17573         (-[WebHistoryItem setURL:]):
   17574         now calls extracted method
   17575         (-[WebHistoryItem setAlternateTitle:]):
   17576         doesn't send notification if notifications are suppressed
   17577         (-[WebHistoryItem setOriginalURLString:]):
   17578         ditto
   17579         (-[WebHistoryItem setTitle:]):
   17580         ditto
   17581         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
   17582         ditto
   17583 
   17584 2004-02-26  Chris Blumenberg  <cblu (a] apple.com>
   17585 
   17586         WebKit side of:
   17587         <rdar://problem/3056566>: mail a link to this page
   17588         <rdar://problem/2961206>: implement ability to e-mail entire page
   17589 
   17590         Reviewed by john.
   17591 
   17592         * English.lproj/StringsNotToBeLocalized.txt:
   17593         * Misc.subproj/WebIconDatabase.m:
   17594         (-[WebIconDatabase _createFileDatabase]): tweaks
   17595         (-[WebIconDatabase _loadIconDictionaries]): fixed an assertion failure I found in Blot. Keep the original list of icon URLs as a separate list when doing the initial clean-up so we don't over release any icons.
   17596         (-[WebIconDatabase _updateFileDatabase]): tweaks
   17597         (-[WebIconDatabase _setIcon:forIconURL:]): tweaks
   17598         (-[WebIconDatabase _releaseIconForIconURLString:]): tweaks
   17599         (-[WebIconDatabase _retainOriginalIconsOnDisk]): use the original list of icons on disk instead of the current list
   17600         (-[WebIconDatabase _releaseOriginalIconsOnDisk]): use the original list of icons on disk instead of the current list
   17601         * Misc.subproj/WebIconDatabasePrivate.h:
   17602         * WebKit.exp:
   17603         * WebKit.pbproj/project.pbxproj:
   17604         * WebView.subproj/WebDataSource.m:
   17605         (-[WebDataSource _propertyListWithData:subresourceURLStrings:]): new, code moved from [WebHTMLView _selectedPropertyList:], creates property list rep of data and subresources
   17606         (-[WebDataSource propertyList]): does the above with all the data source data, this is what "Mail Page" uses
   17607         * WebView.subproj/WebDataSourcePrivate.h:
   17608         * WebView.subproj/WebFrame.m:
   17609         (-[WebFrame loadPropertyList:]): renamed from loadHTMLPropertyList because the property list may contain non-HTML data
   17610         * WebView.subproj/WebFramePrivate.h:
   17611         * WebView.subproj/WebHTMLView.m:
   17612         (-[WebHTMLView _selectedPropertyList:]): renamed, code moved to [WebDataSource _propertyListWithData:subresourceURLStrings:]
   17613         (-[WebHTMLView _writeSelectionToPasteboard:]): call renamed _selectedPropertyList
   17614 
   17615 2004-02-26  Ken Kocienda  <kocienda (a] apple.com>
   17616 
   17617         Reviewed by Chris
   17618 
   17619         Updated usage of DOM SPI to use new names and conventions. 
   17620 
   17621         Unless indicated otherwise, the changes were to update protocol names for, which
   17622         changed from using a "WebDOM" prefix to a "DOM" prefix, and changing now need 
   17623         only include the DOM.h header from WebKit to get everything.
   17624 
   17625         * DOM.subproj/DOM-compat.h: Added. This header contains some compatibility declarations
   17626         to work with older clients of our DOM SPI. Though this file is checked into WebKit, 
   17627         it really lives and should be updated in WebCore. It is copied into WebKit by the build 
   17628         system as needed.
   17629         * DOM.subproj/DOM.h: Added. This file includes the new "guts" of the DOM SPI. As above,
   17630         this file is checked into WebKit, it really lives and should be updated in WebCore.
   17631         It is copied into WebKit by the build system as needed.
   17632         * DOM.subproj/WebDOMDocument.h: Removed declarations. Now just includes DOM.h and DOM-compat.h
   17633         * DOM.subproj/WebDOMDocument.m: Removed.
   17634         * DOM.subproj/WebDOMElement.h: Removed declarations. Now just includes DOM.h and DOM-compat.h
   17635         * DOM.subproj/WebDOMElement.m: Removed.
   17636         * DOM.subproj/WebDOMNode.h: Removed declarations. Now just includes DOM.h and DOM-compat.h
   17637         * DOM.subproj/WebDOMNode.m: Removed.
   17638         * WebCoreSupport.subproj/WebBridge.m:
   17639         (-[WebBridge loadURL:referrer:reload:onLoadEvent:target:triggeringEvent:form:formValues:])
   17640         (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:])
   17641         * WebKit.pbproj/project.pbxproj:
   17642         * WebView.subproj/WebDefaultContextMenuDelegate.m:
   17643         * WebView.subproj/WebFormDelegate.h:
   17644         * WebView.subproj/WebFormDelegate.m:
   17645         (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:])
   17646         * WebView.subproj/WebFrame.h: Unrelated change. Removed -undoManager accessor from public header. Moved to private header.
   17647         * WebView.subproj/WebFrame.m: 
   17648         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:])
   17649         (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:])
   17650         (-[WebFrame undoManager]): Moved -undoManager accessor to private category implementation.
   17651         (-[WebFormState initWithForm:values:sourceFrame:])
   17652         (-[WebFormState form])
   17653         (-[WebFrame childFrames])
   17654         * WebView.subproj/WebFramePrivate.h: Moved in -undoManager accessor.
   17655         * WebView.subproj/WebHTMLRepresentation.h:
   17656         * WebView.subproj/WebHTMLRepresentation.m:
   17657         (-[WebHTMLRepresentation D