Home | History | Annotate | Download | only in webmin 
      1 
      2 This is the README for the DNSmasq webmin module.
      3 
      4 Problems:
      5 
      6 1) There's only basic error checking - if you enter some bad
      7 addresses or names, they will go straight into the config file
      8 although we do check for things like IP addresses being of
      9 the correct form (no letters, 4 groups of up to 3 digits
     10 separated by dots etc). One thing that ISN'T CHECKED FOR is
     11 that IP dotted quads are all numbers < 256. Another is that
     12 netmasks are logical (you could enter a netmask of 255.0.255.0 
     13 for example). Essentially, if it'll pass the config file
     14 regex scanner (and the above examples will), it won't be 
     15 flagged as "bad" even if it is a big no-no for dnsmasq itself. 
     16 
     17 2) Code is ugly and a kludge - I ain't a programmer! There are probably 
     18 a lot of things that could be done to tidy up the code - eg, 
     19 it probably wouldn't hurt to move some common stuff into the lib file.
     20 
     21 3) I've used the %text hash and written an english lang file, but
     22 I am mono-lingual so no other language support as yet.
     23 
     24 4) for reasons unknown to me, the icon does not appear properly
     25 on the servers page of webmin (at least it doesn't for me!)
     26 
     27 5) icons have been shamelessly stolen from the ipfilter module,
     28 specifically the up and down arrows.
     29 
     30 6) if you delete an item, the config file will contain
     31 an otherwise empty, but commented line. This means that if
     32 you add some new stuff, then delete it, the config file
     33 will have a number of lines at the end that are just comments.
     34 Therefore, the config file could possibly grow quite large.
     35 
     36 7) NO INCLUDE FILES!
     37 if you use an include file, it'll be flagged as an error. 
     38 OK if the include file line is commented out though.
     39 
     40 8) deprecated lines not supported (eg user and group) - they
     41 may produce an error! (user and group don't, but you can't change
     42 them)
     43 
     44 IOW, it works, it's just not very elegant and not very robust.
     45 
     46 Hope you find it useful though - I do, as I prevents me having to ever
     47 wade through the config file and man pages again.
     48 
     49 If you modify it, or add a language file, and you have a spare moment,
     50 please e-mail me - I won't be upset at all if you fix my poor coding!
     51 (rather the opposite - I'd be pleased someone found it usefull)
     52 
     53 Cheers,
     54 	Neil Fisher <neil (a] magnecor.com.au>
     55