Home | History | Annotate | Download | only in Sema 
      1 // RUN: %clang_cc1 -fsyntax-only -verify -Wformat-nonliteral %s
      2 
      3 // Test that -Wformat=0 works:
      4 // RUN: %clang_cc1 -fsyntax-only -Werror -Wformat=0 %s
      5 
      6 #include <stdarg.h>
      7 typedef __typeof(sizeof(int)) size_t;
      8 typedef struct _FILE FILE;
      9 typedef __WCHAR_TYPE__ wchar_t;
     10 
     11 int fscanf(FILE * restrict, const char * restrict, ...) ;
     12 int scanf(const char * restrict, ...) ;
     13 int sscanf(const char * restrict, const char * restrict, ...) ;
     14 int my_scanf(const char * restrict, ...) __attribute__((__format__(__scanf__, 1, 2)));
     15 
     16 int vscanf(const char * restrict, va_list);
     17 int vfscanf(FILE * restrict, const char * restrict, va_list);
     18 int vsscanf(const char * restrict, const char * restrict, va_list);
     19 
     20 void test(const char *s, int *i) {
     21   scanf(s, i); // expected-warning{{format string is not a string literal}}
     22   scanf("%0d", i); // expected-warning{{zero field width in scanf format string is unused}}
     23   scanf("%00d", i); // expected-warning{{zero field width in scanf format string is unused}}
     24   scanf("%d%[asdfasdfd", i, s); // expected-warning{{no closing ']' for '%[' in scanf format string}}
     25 
     26   unsigned short s_x;
     27   scanf ("%" "hu" "\n", &s_x); // no-warning
     28   scanf("%y", i); // expected-warning{{invalid conversion specifier 'y'}}
     29   scanf("%%"); // no-warning
     30   scanf("%%%1$d", i); // no-warning
     31   scanf("%1$d%%", i); // no-warning
     32   scanf("%d", i, i); // expected-warning{{data argument not used by format string}}
     33   scanf("%*d", i); // // expected-warning{{data argument not used by format string}}
     34   scanf("%*d", i); // // expected-warning{{data argument not used by format string}}
     35   scanf("%*d%1$d", i); // no-warning
     36 
     37   scanf("%s", (char*)0); // no-warning
     38   scanf("%s", (volatile char*)0); // no-warning
     39   scanf("%s", (signed char*)0); // no-warning
     40   scanf("%s", (unsigned char*)0); // no-warning
     41   scanf("%hhu", (signed char*)0); // no-warning
     42 }
     43 
     44 void bad_length_modifiers(char *s, void *p, wchar_t *ws, long double *ld) {
     45   scanf("%hhs", "foo"); // expected-warning{{length modifier 'hh' results in undefined behavior or no effect with 's' conversion specifier}}
     46   scanf("%1$zp", &p); // expected-warning{{length modifier 'z' results in undefined behavior or no effect with 'p' conversion specifier}}
     47   scanf("%ls", ws); // no-warning
     48   scanf("%#.2Lf", ld); // expected-warning{{invalid conversion specifier '#'}}
     49 }
     50 
     51 // Test that the scanf call site is where the warning is attached.  If the
     52 // format string is somewhere else, point to it in a note.
     53 void pr9751() {
     54   int *i;
     55   char str[100];
     56   const char kFormat1[] = "%00d"; // expected-note{{format string is defined here}}}
     57   scanf(kFormat1, i); // expected-warning{{zero field width in scanf format string is unused}}
     58   scanf("%00d", i); // expected-warning{{zero field width in scanf format string is unused}}
     59   const char kFormat2[] = "%["; // expected-note{{format string is defined here}}}
     60   scanf(kFormat2, str); // expected-warning{{no closing ']' for '%[' in scanf format string}}
     61   scanf("%[", str); // expected-warning{{no closing ']' for '%[' in scanf format string}}
     62   const char kFormat3[] = "%hu"; // expected-note{{format string is defined here}}}
     63   scanf(kFormat3, &i); // expected-warning {{format specifies type 'unsigned short *' but the argument}}
     64   const char kFormat4[] = "%lp"; // expected-note{{format string is defined here}}}
     65   scanf(kFormat4, &i); // expected-warning {{length modifier 'l' results in undefined behavior or no effect with 'p' conversion specifier}}
     66 }
     67 
     68 void test_variants(int *i, const char *s, ...) {
     69   FILE *f = 0;
     70   char buf[100];
     71 
     72   fscanf(f, "%ld", i); // expected-warning{{format specifies type 'long *' but the argument has type 'int *'}}
     73   sscanf(buf, "%ld", i); // expected-warning{{format specifies type 'long *' but the argument has type 'int *'}}
     74   my_scanf("%ld", i); // expected-warning{{format specifies type 'long *' but the argument has type 'int *'}}
     75 
     76   va_list ap;
     77   va_start(ap, s);
     78 
     79   vscanf("%[abc", ap); // expected-warning{{no closing ']' for '%[' in scanf format string}}
     80   vfscanf(f, "%[abc", ap); // expected-warning{{no closing ']' for '%[' in scanf format string}}
     81   vsscanf(buf, "%[abc", ap); // expected-warning{{no closing ']' for '%[' in scanf format string}}
     82 }
     83 
     84 void test_scanlist(int *ip, char *sp, wchar_t *ls) {
     85   scanf("%[abc]", ip); // expected-warning{{format specifies type 'char *' but the argument has type 'int *'}}
     86   scanf("%h[abc]", sp); // expected-warning{{length modifier 'h' results in undefined behavior or no effect with '[' conversion specifier}}
     87   scanf("%l[xyx]", ls); // no-warning
     88   scanf("%ll[xyx]", ls); // expected-warning {{length modifier 'll' results in undefined behavior or no effect with '[' conversion specifier}}
     89 
     90   // PR19559
     91   scanf("%[]% ]", sp); // no-warning
     92   scanf("%[^]% ]", sp); // no-warning
     93   scanf("%[a^]% ]", sp); // expected-warning {{invalid conversion specifier ' '}}
     94 }
     95 
     96 void test_alloc_extension(char **sp, wchar_t **lsp, float *fp) {
     97   /* Make sure "%a" gets parsed as a conversion specifier for float,
     98    * even when followed by an 's', 'S' or '[', which would cause it to be
     99    * parsed as a length modifier in C90. */
    100   scanf("%as", sp); // expected-warning{{format specifies type 'float *' but the argument has type 'char **'}}
    101   scanf("%aS", lsp); // expected-warning{{format specifies type 'float *' but the argument has type 'wchar_t **'}}
    102   scanf("%a[bcd]", sp); // expected-warning{{format specifies type 'float *' but the argument has type 'char **'}}
    103 
    104   // Test that the 'm' length modifier is only allowed with s, S, c, C or [.
    105   // TODO: Warn that 'm' is an extension.
    106   scanf("%ms", sp); // No warning.
    107   scanf("%mS", lsp); // No warning.
    108   scanf("%mc", sp); // No warning.
    109   scanf("%mC", lsp); // No warning.
    110   scanf("%m[abc]", sp); // No warning.
    111   scanf("%md", sp); // expected-warning{{length modifier 'm' results in undefined behavior or no effect with 'd' conversion specifier}}
    112 
    113   // Test argument type check for the 'm' length modifier.
    114   scanf("%ms", fp); // expected-warning{{format specifies type 'char **' but the argument has type 'float *'}}
    115   scanf("%mS", fp); // expected-warning-re{{format specifies type 'wchar_t **' (aka '{{[^']+}}') but the argument has type 'float *'}}
    116   scanf("%mc", fp); // expected-warning{{format specifies type 'char **' but the argument has type 'float *'}}
    117   scanf("%mC", fp); // expected-warning-re{{format specifies type 'wchar_t **' (aka '{{[^']+}}') but the argument has type 'float *'}}
    118   scanf("%m[abc]", fp); // expected-warning{{format specifies type 'char **' but the argument has type 'float *'}}
    119 }
    120 
    121 void test_quad(int *x, long long *llx) {
    122   scanf("%qd", x); // expected-warning{{format specifies type 'long long *' but the argument has type 'int *'}}
    123   scanf("%qd", llx); // no-warning
    124 }
    125 
    126 void test_writeback(int *x) {
    127   scanf("%n", (void*)0); // expected-warning{{format specifies type 'int *' but the argument has type 'void *'}}
    128   scanf("%n %c", x, x); // expected-warning{{format specifies type 'char *' but the argument has type 'int *'}}
    129 
    130   scanf("%hhn", (signed char*)0); // no-warning
    131   scanf("%hhn", (char*)0); // no-warning
    132   scanf("%hhn", (unsigned char*)0); // no-warning
    133   scanf("%hhn", (int*)0); // expected-warning{{format specifies type 'signed char *' but the argument has type 'int *'}}
    134 
    135   scanf("%hn", (short*)0); // no-warning
    136   scanf("%hn", (unsigned short*)0); // no-warning
    137   scanf("%hn", (int*)0); // expected-warning{{format specifies type 'short *' but the argument has type 'int *'}}
    138 
    139   scanf("%n", (int*)0); // no-warning
    140   scanf("%n", (unsigned int*)0); // no-warning
    141   scanf("%n", (char*)0); // expected-warning{{format specifies type 'int *' but the argument has type 'char *'}}
    142 
    143   scanf("%ln", (long*)0); // no-warning
    144   scanf("%ln", (unsigned long*)0); // no-warning
    145   scanf("%ln", (int*)0); // expected-warning{{format specifies type 'long *' but the argument has type 'int *'}}
    146 
    147   scanf("%lln", (long long*)0); // no-warning
    148   scanf("%lln", (unsigned long long*)0); // no-warning
    149   scanf("%lln", (int*)0); // expected-warning{{format specifies type 'long long *' but the argument has type 'int *'}}
    150 
    151   scanf("%qn", (long long*)0); // no-warning
    152   scanf("%qn", (unsigned long long*)0); // no-warning
    153   scanf("%qn", (int*)0); // expected-warning{{format specifies type 'long long *' but the argument has type 'int *'}}
    154 
    155 }
    156 
    157 void test_qualifiers(const int *cip, volatile int* vip,
    158                      const char *ccp, volatile char* vcp,
    159                      const volatile int *cvip) {
    160   scanf("%d", cip); // expected-warning{{format specifies type 'int *' but the argument has type 'const int *'}}
    161   scanf("%n", cip); // expected-warning{{format specifies type 'int *' but the argument has type 'const int *'}}
    162   scanf("%s", ccp); // expected-warning{{format specifies type 'char *' but the argument has type 'const char *'}}
    163   scanf("%d", cvip); // expected-warning{{format specifies type 'int *' but the argument has type 'const volatile int *'}}
    164 
    165   scanf("%d", vip); // No warning.
    166   scanf("%n", vip); // No warning.
    167   scanf("%c", vcp); // No warning.
    168 
    169   typedef int* ip_t;
    170   typedef const int* cip_t;
    171   scanf("%d", (ip_t)0); // No warning.
    172   scanf("%d", (cip_t)0); // expected-warning{{format specifies type 'int *' but the argument has type 'cip_t' (aka 'const int *')}}
    173 }
    174 
    175 void check_conditional_literal(char *s, int *i) {
    176   scanf(0 ? "%s" : "%d", i); // no warning
    177   scanf(1 ? "%s" : "%d", i); // expected-warning{{format specifies type 'char *'}}
    178   scanf(0 ? "%d %d" : "%d", i); // no warning
    179   scanf(1 ? "%d %d" : "%d", i); // expected-warning{{more '%' conversions than data arguments}}
    180   scanf(0 ? "%d %d" : "%d", i, s); // expected-warning{{data argument not used}}
    181   scanf(1 ? "%d %s" : "%d", i, s); // no warning
    182   scanf(i ? "%d %s" : "%d", i, s); // no warning
    183   scanf(i ? "%d" : "%d", i, s); // expected-warning{{data argument not used}}
    184   scanf(i ? "%s" : "%d", s); // expected-warning{{format specifies type 'int *'}}
    185 }
    186