Home | History | Annotate | Download | only in tests
      1 /*
      2  * Copyright 2013 Google Inc.
      3  *
      4  * Use of this source code is governed by a BSD-style license that can be
      5  * found in the LICENSE file.
      6  */
      7 
      8 #include <functional>
      9 #include "SkCanvas.h"
     10 #include "SkData.h"
     11 #include "SkDevice.h"
     12 #include "SkImage_Base.h"
     13 #include "SkOverdrawCanvas.h"
     14 #include "SkPath.h"
     15 #include "SkRegion.h"
     16 #include "SkRRect.h"
     17 #include "SkSurface.h"
     18 #include "SkUtils.h"
     19 #include "Test.h"
     20 
     21 #if SK_SUPPORT_GPU
     22 #include "GrContext.h"
     23 #include "GrContextPriv.h"
     24 #include "GrRenderTargetContext.h"
     25 #include "GrGpu.h"
     26 #include "GrResourceProvider.h"
     27 #include "GrTest.h"
     28 #include <vector>
     29 #endif
     30 
     31 #include <initializer_list>
     32 
     33 static void release_direct_surface_storage(void* pixels, void* context) {
     34     SkASSERT(pixels == context);
     35     sk_free(pixels);
     36 }
     37 static sk_sp<SkSurface> create_surface(SkAlphaType at = kPremul_SkAlphaType,
     38                                        SkImageInfo* requestedInfo = nullptr) {
     39     const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at);
     40     if (requestedInfo) {
     41         *requestedInfo = info;
     42     }
     43     return SkSurface::MakeRaster(info);
     44 }
     45 static sk_sp<SkSurface> create_direct_surface(SkAlphaType at = kPremul_SkAlphaType,
     46                                               SkImageInfo* requestedInfo = nullptr) {
     47     const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at);
     48     if (requestedInfo) {
     49         *requestedInfo = info;
     50     }
     51     const size_t rowBytes = info.minRowBytes();
     52     void* storage = sk_malloc_throw(info.computeByteSize(rowBytes));
     53     return SkSurface::MakeRasterDirectReleaseProc(info, storage, rowBytes,
     54                                                   release_direct_surface_storage,
     55                                                   storage);
     56 }
     57 #if SK_SUPPORT_GPU
     58 static sk_sp<SkSurface> create_gpu_surface(GrContext* context, SkAlphaType at = kPremul_SkAlphaType,
     59                                            SkImageInfo* requestedInfo = nullptr) {
     60     const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at);
     61     if (requestedInfo) {
     62         *requestedInfo = info;
     63     }
     64     return SkSurface::MakeRenderTarget(context, SkBudgeted::kNo, info);
     65 }
     66 static sk_sp<SkSurface> create_gpu_scratch_surface(GrContext* context,
     67                                                    SkAlphaType at = kPremul_SkAlphaType,
     68                                                    SkImageInfo* requestedInfo = nullptr) {
     69     const SkImageInfo info = SkImageInfo::MakeN32(10, 10, at);
     70     if (requestedInfo) {
     71         *requestedInfo = info;
     72     }
     73     return SkSurface::MakeRenderTarget(context, SkBudgeted::kYes, info);
     74 }
     75 #endif
     76 
     77 DEF_TEST(SurfaceEmpty, reporter) {
     78     const SkImageInfo info = SkImageInfo::Make(0, 0, kN32_SkColorType, kPremul_SkAlphaType);
     79     REPORTER_ASSERT(reporter, nullptr == SkSurface::MakeRaster(info));
     80     REPORTER_ASSERT(reporter, nullptr == SkSurface::MakeRasterDirect(info, nullptr, 0));
     81 
     82 }
     83 #if SK_SUPPORT_GPU
     84 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceEmpty_Gpu, reporter, ctxInfo) {
     85     const SkImageInfo info = SkImageInfo::Make(0, 0, kN32_SkColorType, kPremul_SkAlphaType);
     86     REPORTER_ASSERT(reporter, nullptr ==
     87                     SkSurface::MakeRenderTarget(ctxInfo.grContext(), SkBudgeted::kNo, info));
     88 }
     89 #endif
     90 
     91 static void test_canvas_peek(skiatest::Reporter* reporter,
     92                              sk_sp<SkSurface>& surface,
     93                              const SkImageInfo& requestInfo,
     94                              bool expectPeekSuccess) {
     95     const SkColor color = SK_ColorRED;
     96     const SkPMColor pmcolor = SkPreMultiplyColor(color);
     97     surface->getCanvas()->clear(color);
     98 
     99     SkPixmap pmap;
    100     bool success = surface->getCanvas()->peekPixels(&pmap);
    101     REPORTER_ASSERT(reporter, expectPeekSuccess == success);
    102 
    103     SkPixmap pmap2;
    104     const void* addr2 = surface->peekPixels(&pmap2) ? pmap2.addr() : nullptr;
    105 
    106     if (success) {
    107         REPORTER_ASSERT(reporter, requestInfo == pmap.info());
    108         REPORTER_ASSERT(reporter, requestInfo.minRowBytes() <= pmap.rowBytes());
    109         REPORTER_ASSERT(reporter, pmcolor == *pmap.addr32());
    110 
    111         REPORTER_ASSERT(reporter, pmap.addr() == pmap2.addr());
    112         REPORTER_ASSERT(reporter, pmap.info() == pmap2.info());
    113         REPORTER_ASSERT(reporter, pmap.rowBytes() == pmap2.rowBytes());
    114     } else {
    115         REPORTER_ASSERT(reporter, nullptr == addr2);
    116     }
    117 }
    118 DEF_TEST(SurfaceCanvasPeek, reporter) {
    119     for (auto& surface_func : { &create_surface, &create_direct_surface }) {
    120         SkImageInfo requestInfo;
    121         auto surface(surface_func(kPremul_SkAlphaType, &requestInfo));
    122         test_canvas_peek(reporter, surface, requestInfo, true);
    123     }
    124 }
    125 #if SK_SUPPORT_GPU
    126 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceCanvasPeek_Gpu, reporter, ctxInfo) {
    127     for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) {
    128         SkImageInfo requestInfo;
    129         auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, &requestInfo));
    130         test_canvas_peek(reporter, surface, requestInfo, false);
    131     }
    132 }
    133 #endif
    134 
    135 static void test_snapshot_alphatype(skiatest::Reporter* reporter, const sk_sp<SkSurface>& surface,
    136                                     SkAlphaType expectedAlphaType) {
    137     REPORTER_ASSERT(reporter, surface);
    138     if (surface) {
    139         sk_sp<SkImage> image(surface->makeImageSnapshot());
    140         REPORTER_ASSERT(reporter, image);
    141         if (image) {
    142             REPORTER_ASSERT(reporter, image->alphaType() == expectedAlphaType);
    143         }
    144     }
    145 }
    146 DEF_TEST(SurfaceSnapshotAlphaType, reporter) {
    147     for (auto& surface_func : { &create_surface, &create_direct_surface }) {
    148         for (auto& at: { kOpaque_SkAlphaType, kPremul_SkAlphaType, kUnpremul_SkAlphaType }) {
    149             auto surface(surface_func(at, nullptr));
    150             test_snapshot_alphatype(reporter, surface, at);
    151         }
    152     }
    153 }
    154 #if SK_SUPPORT_GPU
    155 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceSnapshotAlphaType_Gpu, reporter, ctxInfo) {
    156     for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) {
    157         // GPU doesn't support creating unpremul surfaces, so only test opaque + premul
    158         for (auto& at : { kOpaque_SkAlphaType, kPremul_SkAlphaType }) {
    159             auto surface(surface_func(ctxInfo.grContext(), at, nullptr));
    160             test_snapshot_alphatype(reporter, surface, at);
    161         }
    162     }
    163 }
    164 #endif
    165 
    166 static GrBackendObject get_surface_backend_texture_handle(
    167     SkSurface* s, SkSurface::BackendHandleAccess a) {
    168     return s->getTextureHandle(a);
    169 }
    170 static GrBackendObject get_surface_backend_render_target_handle(
    171     SkSurface* s, SkSurface::BackendHandleAccess a) {
    172     GrBackendObject result;
    173     if (!s->getRenderTargetHandle(&result, a)) {
    174         return 0;
    175     }
    176     return result;
    177 }
    178 
    179 static void test_backend_handle_access_copy_on_write(
    180     skiatest::Reporter* reporter, SkSurface* surface, SkSurface::BackendHandleAccess mode,
    181     GrBackendObject (*func)(SkSurface*, SkSurface::BackendHandleAccess)) {
    182     GrBackendObject obj1 = func(surface, mode);
    183     sk_sp<SkImage> snap1(surface->makeImageSnapshot());
    184 
    185     GrBackendObject obj2 = func(surface, mode);
    186     sk_sp<SkImage> snap2(surface->makeImageSnapshot());
    187 
    188     // If the access mode triggers CoW, then the backend objects should reflect it.
    189     REPORTER_ASSERT(reporter, (obj1 == obj2) == (snap1 == snap2));
    190 }
    191 DEF_TEST(SurfaceBackendHandleAccessCopyOnWrite, reporter) {
    192     const SkSurface::BackendHandleAccess accessModes[] = {
    193         SkSurface::kFlushRead_BackendHandleAccess,
    194         SkSurface::kFlushWrite_BackendHandleAccess,
    195         SkSurface::kDiscardWrite_BackendHandleAccess,
    196     };
    197     for (auto& handle_access_func :
    198             { &get_surface_backend_texture_handle, &get_surface_backend_render_target_handle }) {
    199         for (auto& accessMode : accessModes) {
    200             auto surface(create_surface());
    201             test_backend_handle_access_copy_on_write(reporter, surface.get(), accessMode,
    202                                                      handle_access_func);
    203         }
    204     }
    205 }
    206 #if SK_SUPPORT_GPU
    207 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBackendHandleAccessCopyOnWrite_Gpu, reporter, ctxInfo) {
    208         const SkSurface::BackendHandleAccess accessModes[] = {
    209         SkSurface::kFlushRead_BackendHandleAccess,
    210         SkSurface::kFlushWrite_BackendHandleAccess,
    211         SkSurface::kDiscardWrite_BackendHandleAccess,
    212     };
    213     for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) {
    214         for (auto& handle_access_func :
    215                 { &get_surface_backend_texture_handle, &get_surface_backend_render_target_handle }) {
    216             for (auto& accessMode : accessModes) {
    217                 auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr));
    218                 test_backend_handle_access_copy_on_write(reporter, surface.get(), accessMode,
    219                                                          handle_access_func);
    220             }
    221         }
    222     }
    223 }
    224 #endif
    225 
    226 #if SK_SUPPORT_GPU
    227 
    228 static void test_backend_handle_unique_id(
    229     skiatest::Reporter* reporter, SkSurface* surface,
    230     GrBackendObject (*func)(SkSurface*, SkSurface::BackendHandleAccess)) {
    231     sk_sp<SkImage> image0(surface->makeImageSnapshot());
    232     GrBackendObject obj = func(surface, SkSurface::kFlushRead_BackendHandleAccess);
    233     REPORTER_ASSERT(reporter, obj != 0);
    234     sk_sp<SkImage> image1(surface->makeImageSnapshot());
    235     // just read access should not affect the snapshot
    236     REPORTER_ASSERT(reporter, image0->uniqueID() == image1->uniqueID());
    237 
    238     obj = func(surface, SkSurface::kFlushWrite_BackendHandleAccess);
    239     REPORTER_ASSERT(reporter, obj != 0);
    240     sk_sp<SkImage> image2(surface->makeImageSnapshot());
    241     // expect a new image, since we claimed we would write
    242     REPORTER_ASSERT(reporter, image0->uniqueID() != image2->uniqueID());
    243 
    244     obj = func(surface, SkSurface::kDiscardWrite_BackendHandleAccess);
    245     REPORTER_ASSERT(reporter, obj != 0);
    246     sk_sp<SkImage> image3(surface->makeImageSnapshot());
    247     // expect a new(er) image, since we claimed we would write
    248     REPORTER_ASSERT(reporter, image0->uniqueID() != image3->uniqueID());
    249     REPORTER_ASSERT(reporter, image2->uniqueID() != image3->uniqueID());
    250 }
    251 // No CPU test.
    252 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBackendHandleAccessIDs_Gpu, reporter, ctxInfo) {
    253     for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) {
    254         for (auto& test_func : { &test_backend_handle_unique_id }) {
    255             for (auto& handle_access_func :
    256                 { &get_surface_backend_texture_handle, &get_surface_backend_render_target_handle}) {
    257                 auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr));
    258                 test_func(reporter, surface.get(), handle_access_func);
    259             }
    260         }
    261     }
    262 }
    263 #endif
    264 
    265 // Verify that the right canvas commands trigger a copy on write.
    266 static void test_copy_on_write(skiatest::Reporter* reporter, SkSurface* surface) {
    267     SkCanvas* canvas = surface->getCanvas();
    268 
    269     const SkRect testRect =
    270         SkRect::MakeXYWH(SkIntToScalar(0), SkIntToScalar(0),
    271                          SkIntToScalar(4), SkIntToScalar(5));
    272     SkPath testPath;
    273     testPath.addRect(SkRect::MakeXYWH(SkIntToScalar(0), SkIntToScalar(0),
    274                                       SkIntToScalar(2), SkIntToScalar(1)));
    275 
    276     const SkIRect testIRect = SkIRect::MakeXYWH(0, 0, 2, 1);
    277 
    278     SkRegion testRegion;
    279     testRegion.setRect(testIRect);
    280 
    281 
    282     const SkColor testColor = 0x01020304;
    283     const SkPaint testPaint;
    284     const SkPoint testPoints[3] = {
    285         {SkIntToScalar(0), SkIntToScalar(0)},
    286         {SkIntToScalar(2), SkIntToScalar(1)},
    287         {SkIntToScalar(0), SkIntToScalar(2)}
    288     };
    289     const size_t testPointCount = 3;
    290 
    291     SkBitmap testBitmap;
    292     testBitmap.allocN32Pixels(10, 10);
    293     testBitmap.eraseColor(0);
    294 
    295     SkRRect testRRect;
    296     testRRect.setRectXY(testRect, SK_Scalar1, SK_Scalar1);
    297 
    298     SkString testText("Hello World");
    299     const SkPoint testPoints2[] = {
    300         { SkIntToScalar(0), SkIntToScalar(1) },
    301         { SkIntToScalar(1), SkIntToScalar(1) },
    302         { SkIntToScalar(2), SkIntToScalar(1) },
    303         { SkIntToScalar(3), SkIntToScalar(1) },
    304         { SkIntToScalar(4), SkIntToScalar(1) },
    305         { SkIntToScalar(5), SkIntToScalar(1) },
    306         { SkIntToScalar(6), SkIntToScalar(1) },
    307         { SkIntToScalar(7), SkIntToScalar(1) },
    308         { SkIntToScalar(8), SkIntToScalar(1) },
    309         { SkIntToScalar(9), SkIntToScalar(1) },
    310         { SkIntToScalar(10), SkIntToScalar(1) },
    311     };
    312 
    313 #define EXPECT_COPY_ON_WRITE(command)                               \
    314     {                                                               \
    315         sk_sp<SkImage> imageBefore = surface->makeImageSnapshot();  \
    316         sk_sp<SkImage> aur_before(imageBefore);                     \
    317         canvas-> command ;                                          \
    318         sk_sp<SkImage> imageAfter = surface->makeImageSnapshot();   \
    319         sk_sp<SkImage> aur_after(imageAfter);                       \
    320         REPORTER_ASSERT(reporter, imageBefore != imageAfter);       \
    321     }
    322 
    323     EXPECT_COPY_ON_WRITE(clear(testColor))
    324     EXPECT_COPY_ON_WRITE(drawPaint(testPaint))
    325     EXPECT_COPY_ON_WRITE(drawPoints(SkCanvas::kPoints_PointMode, testPointCount, testPoints, \
    326         testPaint))
    327     EXPECT_COPY_ON_WRITE(drawOval(testRect, testPaint))
    328     EXPECT_COPY_ON_WRITE(drawRect(testRect, testPaint))
    329     EXPECT_COPY_ON_WRITE(drawRRect(testRRect, testPaint))
    330     EXPECT_COPY_ON_WRITE(drawPath(testPath, testPaint))
    331     EXPECT_COPY_ON_WRITE(drawBitmap(testBitmap, 0, 0))
    332     EXPECT_COPY_ON_WRITE(drawBitmapRect(testBitmap, testRect, nullptr))
    333     EXPECT_COPY_ON_WRITE(drawBitmapNine(testBitmap, testIRect, testRect, nullptr))
    334     EXPECT_COPY_ON_WRITE(drawString(testText, 0, 1, testPaint))
    335     EXPECT_COPY_ON_WRITE(drawPosText(testText.c_str(), testText.size(), testPoints2, \
    336         testPaint))
    337     EXPECT_COPY_ON_WRITE(drawTextOnPath(testText.c_str(), testText.size(), testPath, nullptr, \
    338         testPaint))
    339 }
    340 DEF_TEST(SurfaceCopyOnWrite, reporter) {
    341     test_copy_on_write(reporter, create_surface().get());
    342 }
    343 #if SK_SUPPORT_GPU
    344 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceCopyOnWrite_Gpu, reporter, ctxInfo) {
    345     for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) {
    346         auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr));
    347         test_copy_on_write(reporter, surface.get());
    348     }
    349 }
    350 #endif
    351 
    352 static void test_writable_after_snapshot_release(skiatest::Reporter* reporter,
    353                                                  SkSurface* surface) {
    354     // This test succeeds by not triggering an assertion.
    355     // The test verifies that the surface remains writable (usable) after
    356     // acquiring and releasing a snapshot without triggering a copy on write.
    357     SkCanvas* canvas = surface->getCanvas();
    358     canvas->clear(1);
    359     surface->makeImageSnapshot();  // Create and destroy SkImage
    360     canvas->clear(2);  // Must not assert internally
    361 }
    362 DEF_TEST(SurfaceWriteableAfterSnapshotRelease, reporter) {
    363     test_writable_after_snapshot_release(reporter, create_surface().get());
    364 }
    365 #if SK_SUPPORT_GPU
    366 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceWriteableAfterSnapshotRelease_Gpu, reporter, ctxInfo) {
    367     for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) {
    368         auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr));
    369         test_writable_after_snapshot_release(reporter, surface.get());
    370     }
    371 }
    372 #endif
    373 
    374 #if SK_SUPPORT_GPU
    375 static void test_crbug263329(skiatest::Reporter* reporter,
    376                              SkSurface* surface1,
    377                              SkSurface* surface2) {
    378     // This is a regression test for crbug.com/263329
    379     // Bug was caused by onCopyOnWrite releasing the old surface texture
    380     // back to the scratch texture pool even though the texture is used
    381     // by and active SkImage_Gpu.
    382     SkCanvas* canvas1 = surface1->getCanvas();
    383     SkCanvas* canvas2 = surface2->getCanvas();
    384     canvas1->clear(1);
    385     sk_sp<SkImage> image1(surface1->makeImageSnapshot());
    386     // Trigger copy on write, new backing is a scratch texture
    387     canvas1->clear(2);
    388     sk_sp<SkImage> image2(surface1->makeImageSnapshot());
    389     // Trigger copy on write, old backing should not be returned to scratch
    390     // pool because it is held by image2
    391     canvas1->clear(3);
    392 
    393     canvas2->clear(4);
    394     sk_sp<SkImage> image3(surface2->makeImageSnapshot());
    395     // Trigger copy on write on surface2. The new backing store should not
    396     // be recycling a texture that is held by an existing image.
    397     canvas2->clear(5);
    398     sk_sp<SkImage> image4(surface2->makeImageSnapshot());
    399     REPORTER_ASSERT(reporter, as_IB(image4)->getTexture() != as_IB(image3)->getTexture());
    400     // The following assertion checks crbug.com/263329
    401     REPORTER_ASSERT(reporter, as_IB(image4)->getTexture() != as_IB(image2)->getTexture());
    402     REPORTER_ASSERT(reporter, as_IB(image4)->getTexture() != as_IB(image1)->getTexture());
    403     REPORTER_ASSERT(reporter, as_IB(image3)->getTexture() != as_IB(image2)->getTexture());
    404     REPORTER_ASSERT(reporter, as_IB(image3)->getTexture() != as_IB(image1)->getTexture());
    405     REPORTER_ASSERT(reporter, as_IB(image2)->getTexture() != as_IB(image1)->getTexture());
    406 }
    407 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceCRBug263329_Gpu, reporter, ctxInfo) {
    408     for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) {
    409         auto surface1(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr));
    410         auto surface2(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr));
    411         test_crbug263329(reporter, surface1.get(), surface2.get());
    412     }
    413 }
    414 #endif
    415 
    416 DEF_TEST(SurfaceGetTexture, reporter) {
    417     auto surface(create_surface());
    418     sk_sp<SkImage> image(surface->makeImageSnapshot());
    419     REPORTER_ASSERT(reporter, !as_IB(image)->isTextureBacked());
    420     surface->notifyContentWillChange(SkSurface::kDiscard_ContentChangeMode);
    421     REPORTER_ASSERT(reporter, !as_IB(image)->isTextureBacked());
    422 }
    423 #if SK_SUPPORT_GPU
    424 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfacepeekTexture_Gpu, reporter, ctxInfo) {
    425     for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) {
    426         auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr));
    427         sk_sp<SkImage> image(surface->makeImageSnapshot());
    428 
    429         REPORTER_ASSERT(reporter, as_IB(image)->isTextureBacked());
    430         GrBackendObject textureHandle = image->getTextureHandle(false);
    431         REPORTER_ASSERT(reporter, 0 != textureHandle);
    432         surface->notifyContentWillChange(SkSurface::kDiscard_ContentChangeMode);
    433         REPORTER_ASSERT(reporter, as_IB(image)->isTextureBacked());
    434         REPORTER_ASSERT(reporter, textureHandle == image->getTextureHandle(false));
    435     }
    436 }
    437 #endif
    438 
    439 #if SK_SUPPORT_GPU
    440 #include "GrGpuResourcePriv.h"
    441 #include "SkGpuDevice.h"
    442 #include "SkImage_Gpu.h"
    443 #include "SkSurface_Gpu.h"
    444 
    445 static SkBudgeted is_budgeted(const sk_sp<SkSurface>& surf) {
    446     SkSurface_Gpu* gsurf = (SkSurface_Gpu*)surf.get();
    447 
    448     GrRenderTargetProxy* proxy = gsurf->getDevice()->accessRenderTargetContext()
    449                                                                         ->asRenderTargetProxy();
    450     return proxy->isBudgeted();
    451 }
    452 
    453 static SkBudgeted is_budgeted(SkImage* image) {
    454     return ((SkImage_Gpu*)image)->peekProxy()->isBudgeted();
    455 }
    456 
    457 static SkBudgeted is_budgeted(const sk_sp<SkImage> image) {
    458     return is_budgeted(image.get());
    459 }
    460 
    461 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceBudget, reporter, ctxInfo) {
    462     SkImageInfo info = SkImageInfo::MakeN32Premul(8,8);
    463     for (auto budgeted : { SkBudgeted::kNo, SkBudgeted::kYes }) {
    464         auto surface(SkSurface::MakeRenderTarget(ctxInfo.grContext(), budgeted, info));
    465         SkASSERT(surface);
    466         REPORTER_ASSERT(reporter, budgeted == is_budgeted(surface));
    467 
    468         sk_sp<SkImage> image(surface->makeImageSnapshot());
    469 
    470         // Initially the image shares a texture with the surface, and the
    471         // the budgets should always match.
    472         REPORTER_ASSERT(reporter, budgeted == is_budgeted(surface));
    473         REPORTER_ASSERT(reporter, budgeted == is_budgeted(image));
    474 
    475         // Now trigger copy-on-write
    476         surface->getCanvas()->clear(SK_ColorBLUE);
    477 
    478         // They don't share a texture anymore but the budgets should still match.
    479         REPORTER_ASSERT(reporter, budgeted == is_budgeted(surface));
    480         REPORTER_ASSERT(reporter, budgeted == is_budgeted(image));
    481     }
    482 }
    483 #endif
    484 
    485 static void test_no_canvas1(skiatest::Reporter* reporter,
    486                             SkSurface* surface,
    487                             SkSurface::ContentChangeMode mode) {
    488     // Test passes by not asserting
    489     surface->notifyContentWillChange(mode);
    490     SkDEBUGCODE(surface->validate();)
    491 }
    492 static void test_no_canvas2(skiatest::Reporter* reporter,
    493                             SkSurface* surface,
    494                             SkSurface::ContentChangeMode mode) {
    495     // Verifies the robustness of SkSurface for handling use cases where calls
    496     // are made before a canvas is created.
    497     sk_sp<SkImage> image1 = surface->makeImageSnapshot();
    498     sk_sp<SkImage> aur_image1(image1);
    499     SkDEBUGCODE(image1->validate();)
    500     SkDEBUGCODE(surface->validate();)
    501     surface->notifyContentWillChange(mode);
    502     SkDEBUGCODE(image1->validate();)
    503     SkDEBUGCODE(surface->validate();)
    504     sk_sp<SkImage> image2 = surface->makeImageSnapshot();
    505     sk_sp<SkImage> aur_image2(image2);
    506     SkDEBUGCODE(image2->validate();)
    507     SkDEBUGCODE(surface->validate();)
    508     REPORTER_ASSERT(reporter, image1 != image2);
    509 }
    510 DEF_TEST(SurfaceNoCanvas, reporter) {
    511     SkSurface::ContentChangeMode modes[] =
    512             { SkSurface::kDiscard_ContentChangeMode, SkSurface::kRetain_ContentChangeMode};
    513     for (auto& test_func : { &test_no_canvas1, &test_no_canvas2 }) {
    514         for (auto& mode : modes) {
    515             test_func(reporter, create_surface().get(), mode);
    516         }
    517     }
    518 }
    519 #if SK_SUPPORT_GPU
    520 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceNoCanvas_Gpu, reporter, ctxInfo) {
    521     SkSurface::ContentChangeMode modes[] =
    522             { SkSurface::kDiscard_ContentChangeMode, SkSurface::kRetain_ContentChangeMode};
    523     for (auto& surface_func : { &create_gpu_surface, &create_gpu_scratch_surface }) {
    524         for (auto& test_func : { &test_no_canvas1, &test_no_canvas2 }) {
    525             for (auto& mode : modes) {
    526                 auto surface(surface_func(ctxInfo.grContext(), kPremul_SkAlphaType, nullptr));
    527                 test_func(reporter, surface.get(), mode);
    528             }
    529         }
    530     }
    531 }
    532 #endif
    533 
    534 static void check_rowbytes_remain_consistent(SkSurface* surface, skiatest::Reporter* reporter) {
    535     SkPixmap surfacePM;
    536     REPORTER_ASSERT(reporter, surface->peekPixels(&surfacePM));
    537 
    538     sk_sp<SkImage> image(surface->makeImageSnapshot());
    539     SkPixmap pm;
    540     REPORTER_ASSERT(reporter, image->peekPixels(&pm));
    541 
    542     REPORTER_ASSERT(reporter, surfacePM.rowBytes() == pm.rowBytes());
    543 
    544     // trigger a copy-on-write
    545     surface->getCanvas()->drawPaint(SkPaint());
    546     sk_sp<SkImage> image2(surface->makeImageSnapshot());
    547     REPORTER_ASSERT(reporter, image->uniqueID() != image2->uniqueID());
    548 
    549     SkPixmap pm2;
    550     REPORTER_ASSERT(reporter, image2->peekPixels(&pm2));
    551     REPORTER_ASSERT(reporter, pm2.rowBytes() == pm.rowBytes());
    552 }
    553 
    554 DEF_TEST(surface_rowbytes, reporter) {
    555     const SkImageInfo info = SkImageInfo::MakeN32Premul(100, 100);
    556 
    557     auto surf0(SkSurface::MakeRaster(info));
    558     check_rowbytes_remain_consistent(surf0.get(), reporter);
    559 
    560     // specify a larger rowbytes
    561     auto surf1(SkSurface::MakeRaster(info, 500, nullptr));
    562     check_rowbytes_remain_consistent(surf1.get(), reporter);
    563 
    564     // Try some illegal rowByte values
    565     auto s = SkSurface::MakeRaster(info, 396, nullptr);    // needs to be at least 400
    566     REPORTER_ASSERT(reporter, nullptr == s);
    567     s = SkSurface::MakeRaster(info, std::numeric_limits<size_t>::max(), nullptr);
    568     REPORTER_ASSERT(reporter, nullptr == s);
    569 }
    570 
    571 DEF_TEST(surface_raster_zeroinitialized, reporter) {
    572     sk_sp<SkSurface> s(SkSurface::MakeRasterN32Premul(100, 100));
    573     SkPixmap pixmap;
    574     REPORTER_ASSERT(reporter, s->peekPixels(&pixmap));
    575 
    576     for (int i = 0; i < pixmap.info().width(); ++i) {
    577         for (int j = 0; j < pixmap.info().height(); ++j) {
    578             REPORTER_ASSERT(reporter, *pixmap.addr32(i, j) == 0);
    579         }
    580     }
    581 }
    582 
    583 #if SK_SUPPORT_GPU
    584 static sk_sp<SkSurface> create_gpu_surface_backend_texture(
    585     GrContext* context, int sampleCnt, uint32_t color, GrBackendTexture* outTexture) {
    586     GrGpu* gpu = context->contextPriv().getGpu();
    587 
    588     const int kWidth = 10;
    589     const int kHeight = 10;
    590     std::unique_ptr<uint32_t[]> pixels(new uint32_t[kWidth * kHeight]);
    591     sk_memset32(pixels.get(), color, kWidth * kHeight);
    592 
    593     *outTexture = gpu->createTestingOnlyBackendTexture(
    594         pixels.get(), kWidth, kHeight, kRGBA_8888_GrPixelConfig, true, GrMipMapped::kNo);
    595 
    596     if (!outTexture->isValid() || !gpu->isTestingOnlyBackendTexture(*outTexture)) {
    597         return nullptr;
    598     }
    599 
    600     sk_sp<SkSurface> surface = SkSurface::MakeFromBackendTexture(context, *outTexture,
    601                                                                  kTopLeft_GrSurfaceOrigin, sampleCnt,
    602                                                                  kRGBA_8888_SkColorType,
    603                                                                  nullptr, nullptr);
    604     if (!surface) {
    605         gpu->deleteTestingOnlyBackendTexture(outTexture);
    606         return nullptr;
    607     }
    608     return surface;
    609 }
    610 
    611 static sk_sp<SkSurface> create_gpu_surface_backend_texture_as_render_target(
    612     GrContext* context, int sampleCnt, uint32_t color, GrBackendTexture* outTexture) {
    613     GrGpu* gpu = context->contextPriv().getGpu();
    614 
    615     const int kWidth = 10;
    616     const int kHeight = 10;
    617     std::unique_ptr<uint32_t[]> pixels(new uint32_t[kWidth * kHeight]);
    618     sk_memset32(pixels.get(), color, kWidth * kHeight);
    619 
    620     *outTexture = gpu->createTestingOnlyBackendTexture(
    621         pixels.get(), kWidth, kHeight, kRGBA_8888_GrPixelConfig, true, GrMipMapped::kNo);
    622 
    623     if (!outTexture->isValid() || !gpu->isTestingOnlyBackendTexture(*outTexture)) {
    624         return nullptr;
    625     }
    626 
    627     sk_sp<SkSurface> surface = SkSurface::MakeFromBackendTextureAsRenderTarget(
    628             context, *outTexture, kTopLeft_GrSurfaceOrigin, sampleCnt, kRGBA_8888_SkColorType,
    629             nullptr, nullptr);
    630 
    631     if (!surface) {
    632         gpu->deleteTestingOnlyBackendTexture(outTexture);
    633         return nullptr;
    634     }
    635     return surface;
    636 }
    637 
    638 static void test_surface_clear(skiatest::Reporter* reporter, sk_sp<SkSurface> surface,
    639                                std::function<sk_sp<GrSurfaceContext>(SkSurface*)> grSurfaceGetter,
    640                                uint32_t expectedValue) {
    641     if (!surface) {
    642         ERRORF(reporter, "Could not create GPU SkSurface.");
    643         return;
    644     }
    645     int w = surface->width();
    646     int h = surface->height();
    647     std::unique_ptr<uint32_t[]> pixels(new uint32_t[w * h]);
    648     sk_memset32(pixels.get(), ~expectedValue, w * h);
    649 
    650     sk_sp<GrSurfaceContext> grSurfaceContext(grSurfaceGetter(surface.get()));
    651     if (!grSurfaceContext) {
    652         ERRORF(reporter, "Could access render target of GPU SkSurface.");
    653         return;
    654     }
    655     surface.reset();
    656 
    657     SkImageInfo ii = SkImageInfo::Make(w, h, kRGBA_8888_SkColorType, kPremul_SkAlphaType);
    658     grSurfaceContext->readPixels(ii, pixels.get(), 0, 0, 0);
    659     for (int y = 0; y < h; ++y) {
    660         for (int x = 0; x < w; ++x) {
    661             uint32_t pixel = pixels.get()[y * w + x];
    662             if (pixel != expectedValue) {
    663                 SkString msg;
    664                 if (expectedValue) {
    665                     msg = "SkSurface should have left render target unmodified";
    666                 } else {
    667                     msg = "SkSurface should have cleared the render target";
    668                 }
    669                 ERRORF(reporter,
    670                        "%s but read 0x%08x (instead of 0x%08x) at %x,%d", msg.c_str(), pixel,
    671                        expectedValue, x, y);
    672                 return;
    673             }
    674         }
    675     }
    676 }
    677 
    678 DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceClear_Gpu, reporter, ctxInfo) {
    679     GrContext* context = ctxInfo.grContext();
    680     GrGpu* gpu = context->contextPriv().getGpu();
    681 
    682     std::function<sk_sp<GrSurfaceContext>(SkSurface*)> grSurfaceContextGetters[] = {
    683         [] (SkSurface* s){
    684             return sk_ref_sp(s->getCanvas()->internal_private_accessTopLayerRenderTargetContext());
    685         },
    686         [] (SkSurface* s){
    687             sk_sp<SkImage> i(s->makeImageSnapshot());
    688             SkImage_Gpu* gpuImage = (SkImage_Gpu *) as_IB(i);
    689             sk_sp<GrTextureProxy> proxy = gpuImage->asTextureProxyRef();
    690             GrContext* context = gpuImage->context();
    691             return context->contextPriv().makeWrappedSurfaceContext(std::move(proxy),
    692                                                                     gpuImage->refColorSpace());
    693         }
    694     };
    695 
    696     for (auto grSurfaceGetter : grSurfaceContextGetters) {
    697         // Test that non-wrapped RTs are created clear.
    698         for (auto& surface_func : {&create_gpu_surface, &create_gpu_scratch_surface}) {
    699             auto surface = surface_func(context, kPremul_SkAlphaType, nullptr);
    700             test_surface_clear(reporter, surface, grSurfaceGetter, 0x0);
    701         }
    702         // Wrapped RTs are *not* supposed to clear (to allow client to partially update a surface).
    703         const uint32_t kOrigColor = 0xABABABAB;
    704         for (auto& surfaceFunc : {&create_gpu_surface_backend_texture,
    705                                   &create_gpu_surface_backend_texture_as_render_target}) {
    706             GrBackendTexture backendTex;
    707             auto surface = surfaceFunc(context, 1, kOrigColor, &backendTex);
    708             test_surface_clear(reporter, surface, grSurfaceGetter, kOrigColor);
    709             surface.reset();
    710             gpu->deleteTestingOnlyBackendTexture(&backendTex);
    711         }
    712     }
    713 }
    714 
    715 static void test_surface_draw_partially(
    716     skiatest::Reporter* reporter, sk_sp<SkSurface> surface, uint32_t origColor) {
    717     const int kW = surface->width();
    718     const int kH = surface->height();
    719     SkPaint paint;
    720     const SkColor kRectColor = ~origColor | 0xFF000000;
    721     paint.setColor(kRectColor);
    722     surface->getCanvas()->drawRect(SkRect::MakeWH(SkIntToScalar(kW), SkIntToScalar(kH)/2),
    723                                    paint);
    724     std::unique_ptr<uint32_t[]> pixels(new uint32_t[kW * kH]);
    725     sk_memset32(pixels.get(), ~origColor, kW * kH);
    726     // Read back RGBA to avoid format conversions that may not be supported on all platforms.
    727     SkImageInfo readInfo = SkImageInfo::Make(kW, kH, kRGBA_8888_SkColorType, kPremul_SkAlphaType);
    728     SkAssertResult(surface->readPixels(readInfo, pixels.get(), kW * sizeof(uint32_t), 0, 0));
    729     bool stop = false;
    730     SkPMColor origColorPM = SkPackARGB_as_RGBA((origColor >> 24 & 0xFF),
    731                                                (origColor >>  0 & 0xFF),
    732                                                (origColor >>  8 & 0xFF),
    733                                                (origColor >> 16 & 0xFF));
    734     SkPMColor rectColorPM = SkPackARGB_as_RGBA((kRectColor >> 24 & 0xFF),
    735                                                (kRectColor >> 16 & 0xFF),
    736                                                (kRectColor >>  8 & 0xFF),
    737                                                (kRectColor >>  0 & 0xFF));
    738     for (int y = 0; y < kH/2 && !stop; ++y) {
    739        for (int x = 0; x < kW && !stop; ++x) {
    740             REPORTER_ASSERT(reporter, rectColorPM == pixels[x + y * kW]);
    741             if (rectColorPM != pixels[x + y * kW]) {
    742                 stop = true;
    743             }
    744         }
    745     }
    746     stop = false;
    747     for (int y = kH/2; y < kH && !stop; ++y) {
    748         for (int x = 0; x < kW && !stop; ++x) {
    749             REPORTER_ASSERT(reporter, origColorPM == pixels[x + y * kW]);
    750             if (origColorPM != pixels[x + y * kW]) {
    751                 stop = true;
    752             }
    753         }
    754     }
    755 }
    756 
    757 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfacePartialDraw_Gpu, reporter, ctxInfo) {
    758     GrGpu* gpu = ctxInfo.grContext()->contextPriv().getGpu();
    759     if (!gpu) {
    760         return;
    761     }
    762     static const uint32_t kOrigColor = 0xFFAABBCC;
    763 
    764     for (auto& surfaceFunc : {&create_gpu_surface_backend_texture,
    765                               &create_gpu_surface_backend_texture_as_render_target}) {
    766         // Validate that we can draw to the canvas and that the original texture color is
    767         // preserved in pixels that aren't rendered to via the surface.
    768         // This works only for non-multisampled case.
    769         GrBackendTexture backendTex;
    770         auto surface = surfaceFunc(ctxInfo.grContext(), 1, kOrigColor, &backendTex);
    771         if (surface) {
    772             test_surface_draw_partially(reporter, surface, kOrigColor);
    773             surface.reset();
    774             gpu->deleteTestingOnlyBackendTexture(&backendTex);
    775         }
    776     }
    777 }
    778 
    779 
    780 DEF_GPUTEST_FOR_GL_RENDERING_CONTEXTS(SurfaceAttachStencil_Gpu, reporter, ctxInfo) {
    781     GrGpu* gpu = ctxInfo.grContext()->contextPriv().getGpu();
    782     if (!gpu) {
    783         return;
    784     }
    785     if (gpu->caps()->avoidStencilBuffers()) {
    786         return;
    787     }
    788     static const uint32_t kOrigColor = 0xFFAABBCC;
    789 
    790     auto resourceProvider = ctxInfo.grContext()->contextPriv().resourceProvider();
    791 
    792     for (auto& surfaceFunc : {&create_gpu_surface_backend_texture,
    793                               &create_gpu_surface_backend_texture_as_render_target}) {
    794         for (int sampleCnt : {1, 4, 8}) {
    795             GrBackendTexture backendTex;
    796             auto surface = surfaceFunc(ctxInfo.grContext(), sampleCnt, kOrigColor, &backendTex);
    797 
    798             if (!surface && sampleCnt > 1) {
    799                 // Certain platforms don't support MSAA, skip these.
    800                 continue;
    801             }
    802 
    803             // Validate that we can attach a stencil buffer to an SkSurface created by either of
    804             // our surface functions.
    805             GrRenderTarget* rt = surface->getCanvas()
    806                 ->internal_private_accessTopLayerRenderTargetContext()->accessRenderTarget();
    807             REPORTER_ASSERT(reporter, resourceProvider->attachStencilAttachment(rt));
    808             gpu->deleteTestingOnlyBackendTexture(&backendTex);
    809         }
    810     }
    811 }
    812 #endif
    813 
    814 static void test_surface_creation_and_snapshot_with_color_space(
    815     skiatest::Reporter* reporter,
    816     const char* prefix,
    817     bool f16Support,
    818     std::function<sk_sp<SkSurface>(const SkImageInfo&)> surfaceMaker) {
    819 
    820     auto srgbColorSpace = SkColorSpace::MakeSRGB();
    821     const SkMatrix44* srgbMatrix = srgbColorSpace->toXYZD50();
    822     SkASSERT(srgbMatrix);
    823     SkColorSpaceTransferFn oddGamma;
    824     oddGamma.fA = 1.0f;
    825     oddGamma.fB = oddGamma.fC = oddGamma.fD = oddGamma.fE = oddGamma.fF = 0.0f;
    826     oddGamma.fG = 4.0f;
    827     auto oddColorSpace = SkColorSpace::MakeRGB(oddGamma, *srgbMatrix);
    828     auto linearColorSpace = SkColorSpace::MakeSRGBLinear();
    829 
    830     const struct {
    831         SkColorType         fColorType;
    832         sk_sp<SkColorSpace> fColorSpace;
    833         bool                fShouldWork;
    834         const char*         fDescription;
    835     } testConfigs[] = {
    836         { kN32_SkColorType,       nullptr,          true,  "N32-nullptr" },
    837         { kN32_SkColorType,       linearColorSpace, false, "N32-linear"  },
    838         { kN32_SkColorType,       srgbColorSpace,   true,  "N32-srgb"    },
    839         { kN32_SkColorType,       oddColorSpace,    false, "N32-odd"     },
    840         { kRGBA_F16_SkColorType,  nullptr,          true,  "F16-nullptr" },
    841         { kRGBA_F16_SkColorType,  linearColorSpace, true,  "F16-linear"  },
    842         { kRGBA_F16_SkColorType,  srgbColorSpace,   false, "F16-srgb"    },
    843         { kRGBA_F16_SkColorType,  oddColorSpace,    false, "F16-odd"     },
    844         { kRGB_565_SkColorType,   srgbColorSpace,   false, "565-srgb"    },
    845         { kAlpha_8_SkColorType,   srgbColorSpace,   false, "A8-srgb"     },
    846     };
    847 
    848     for (auto& testConfig : testConfigs) {
    849         SkString fullTestName = SkStringPrintf("%s-%s", prefix, testConfig.fDescription);
    850         SkImageInfo info = SkImageInfo::Make(10, 10, testConfig.fColorType, kPremul_SkAlphaType,
    851                                              testConfig.fColorSpace);
    852 
    853         // For some GPU contexts (eg ANGLE), we don't have f16 support, so we should fail to create
    854         // any surface of that type:
    855         bool shouldWork = testConfig.fShouldWork &&
    856                           (f16Support || kRGBA_F16_SkColorType != testConfig.fColorType);
    857 
    858         auto surface(surfaceMaker(info));
    859         REPORTER_ASSERT(reporter, SkToBool(surface) == shouldWork, fullTestName.c_str());
    860 
    861         if (shouldWork && surface) {
    862             sk_sp<SkImage> image(surface->makeImageSnapshot());
    863             REPORTER_ASSERT(reporter, image, testConfig.fDescription);
    864             SkColorSpace* imageColorSpace = as_IB(image)->onImageInfo().colorSpace();
    865             REPORTER_ASSERT(reporter, imageColorSpace == testConfig.fColorSpace.get(),
    866                             fullTestName.c_str());
    867         }
    868     }
    869 }
    870 
    871 DEF_TEST(SurfaceCreationWithColorSpace, reporter) {
    872     auto surfaceMaker = [](const SkImageInfo& info) {
    873         return SkSurface::MakeRaster(info);
    874     };
    875 
    876     test_surface_creation_and_snapshot_with_color_space(reporter, "raster", true, surfaceMaker);
    877 }
    878 
    879 #if SK_SUPPORT_GPU
    880 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(SurfaceCreationWithColorSpace_Gpu, reporter, ctxInfo) {
    881     GrContext* context = ctxInfo.grContext();
    882 
    883     bool f16Support = context->caps()->isConfigRenderable(kRGBA_half_GrPixelConfig, false);
    884     auto surfaceMaker = [context](const SkImageInfo& info) {
    885         return SkSurface::MakeRenderTarget(context, SkBudgeted::kNo, info);
    886     };
    887 
    888     test_surface_creation_and_snapshot_with_color_space(reporter, "gpu", f16Support, surfaceMaker);
    889 
    890     std::vector<GrBackendTexture> backendTextures;
    891     auto wrappedSurfaceMaker = [ context, &backendTextures ](const SkImageInfo& info) {
    892         GrGpu* gpu = context->contextPriv().getGpu();
    893 
    894         static const int kSize = 10;
    895         GrPixelConfig config = SkImageInfo2GrPixelConfig(info, *context->caps());
    896 
    897         GrBackendTexture backendTex = gpu->createTestingOnlyBackendTexture(
    898                 nullptr, kSize, kSize, config, true, GrMipMapped::kNo);
    899 
    900         if (!backendTex.isValid() ||
    901             !gpu->isTestingOnlyBackendTexture(backendTex)) {
    902             return sk_sp<SkSurface>(nullptr);
    903         }
    904         backendTextures.push_back(backendTex);
    905 
    906         return SkSurface::MakeFromBackendTexture(context, backendTex,
    907                                                  kTopLeft_GrSurfaceOrigin, 0,
    908                                                  info.colorType(),
    909                                                  sk_ref_sp(info.colorSpace()), nullptr);
    910     };
    911 
    912     test_surface_creation_and_snapshot_with_color_space(reporter, "wrapped", f16Support,
    913                                                         wrappedSurfaceMaker);
    914 
    915     context->flush();
    916 
    917     GrGpu* gpu = context->contextPriv().getGpu();
    918     for (auto backendTex : backendTextures) {
    919         gpu->deleteTestingOnlyBackendTexture(&backendTex);
    920     }
    921 }
    922 #endif
    923 
    924 static void test_overdraw_surface(skiatest::Reporter* r, SkSurface* surface) {
    925     SkOverdrawCanvas canvas(surface->getCanvas());
    926     canvas.drawPaint(SkPaint());
    927     sk_sp<SkImage> image = surface->makeImageSnapshot();
    928 
    929     SkBitmap bitmap;
    930     image->asLegacyBitmap(&bitmap, SkImage::kRO_LegacyBitmapMode);
    931     for (int y = 0; y < 10; y++) {
    932         for (int x = 0; x < 10; x++) {
    933             REPORTER_ASSERT(r, 1 == SkGetPackedA32(*bitmap.getAddr32(x, y)));
    934         }
    935     }
    936 }
    937 
    938 DEF_TEST(OverdrawSurface_Raster, r) {
    939     sk_sp<SkSurface> surface = create_surface();
    940     test_overdraw_surface(r, surface.get());
    941 }
    942 
    943 #if SK_SUPPORT_GPU
    944 DEF_GPUTEST_FOR_RENDERING_CONTEXTS(OverdrawSurface_Gpu, r, ctxInfo) {
    945     GrContext* context = ctxInfo.grContext();
    946     sk_sp<SkSurface> surface = create_gpu_surface(context);
    947     test_overdraw_surface(r, surface.get());
    948 }
    949 #endif
    950 
    951 DEF_TEST(Surface_null, r) {
    952     REPORTER_ASSERT(r, SkSurface::MakeNull(0, 0) == nullptr);
    953 
    954     const int w = 37;
    955     const int h = 1000;
    956     auto surf = SkSurface::MakeNull(w, h);
    957     auto canvas = surf->getCanvas();
    958 
    959     canvas->drawPaint(SkPaint());   // should not crash, but don't expect anything to draw
    960     REPORTER_ASSERT(r, surf->makeImageSnapshot() == nullptr);
    961 }
    962